The Unified and Autonomous Development Platform
fix(cargo): validate publish archive checksum
Chief Work Horse853fa4fe6f61
diff --git a/server-plugin/server-plugin-pack-cargo/src/main/java/io/onedev/server/plugin/pack/cargo/CargoPackHandler.java b/server-plugin/server-plugin-pack-cargo/src/main/java/io/onedev/server/plugin/pack/cargo/CargoPackHandler.javaindex c5a232d968..1a08a0fcea 100644--- a/server-plugin/server-plugin-pack-cargo/src/main/java/io/onedev/server/plugin/pack/cargo/CargoPackHandler.java+++ b/server-plugin/server-plugin-pack-cargo/src/main/java/io/onedev/server/plugin/pack/cargo/CargoPackHandler.java@@ -157,6 +157,9 @@ public class CargoPackHandler implements PackHandler {throw new ClientException(SC_BAD_REQUEST, "Package version not specified");if (!name.equals(name.toLowerCase()))throw new ClientException(SC_BAD_REQUEST, "Package name should be lower case");+ var checksum = metadata.path("cksum").asText(null);+ if (StringUtils.isBlank(checksum))+ throw new ClientException(SC_BAD_REQUEST, "Package checksum not specified");LockUtils.run(getLockName(projectId, name), () -> transactionService.run(() -> {var project = checkProject(projectId, true);@@ -165,7 +168,10 @@ public class CargoPackHandler implements PackHandler {String.format("Package already exists (name: %s, version: %s)", name, version));}- var packBlob = packBlobService.load(packBlobService.uploadBlob(projectId, upload.crateFile, null));+ var packBlobId = packBlobService.uploadBlob(projectId, upload.crateFile, checksum);+ if (packBlobId == null)+ throw new ClientException(SC_BAD_REQUEST, "Digest mismatch");+ var packBlob = packBlobService.load(packBlobId);var pack = new Pack();pack.setType(TYPE);pack.setName(name);