The Unified and Autonomous Development Platform
feat: RESTful API for setting issue links (OD-1929)
Robin Shen85ab0a10f305
diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/IssueLinkResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/IssueLinkResource.javanew file mode 100644index 0000000000..a9c8d2eff7--- /dev/null+++ b/server-core/src/main/java/io/onedev/server/rest/resource/IssueLinkResource.java@@ -0,0 +1,89 @@+package io.onedev.server.rest.resource;++import io.onedev.server.entitymanager.IssueLinkManager;+import io.onedev.server.model.IssueLink;+import io.onedev.server.rest.annotation.Api;+import org.apache.shiro.authz.UnauthorizedException;++import javax.inject.Inject;+import javax.inject.Singleton;+import javax.validation.constraints.NotNull;+import javax.ws.rs.*;+import javax.ws.rs.core.MediaType;+import javax.ws.rs.core.Response;++import static io.onedev.server.security.SecurityUtils.canAccessIssue;+import static io.onedev.server.security.SecurityUtils.canEditIssueLink;++@Api(order=2400)+@Path("/issue-links")+@Consumes(MediaType.APPLICATION_JSON)+@Produces(MediaType.APPLICATION_JSON)+@Singleton+public class IssueLinkResource {++ private final IssueLinkManager linkManager;++ @Inject+ public IssueLinkResource(IssueLinkManager linkManager) {+ this.linkManager = linkManager;+ }++ @Api(order=100)+ @Path("/{linkId}")+ @GET+ public IssueLink get(@PathParam("linkId") Long linkId) {+ var link = linkManager.load(linkId);+ if (!canAccessIssue(link.getTarget()) && !canAccessIssue(link.getSource()))+ throw new UnauthorizedException();+ return link;+ }++ @Api(order=200, description="Create new issue link")+ @POST+ public Long create(@NotNull IssueLink link) {+ if (!canEditIssueLink(link.getSource().getProject(), link.getSpec())+ && !canEditIssueLink(link.getTarget().getProject(), link.getSpec())) {+ throw new UnauthorizedException();+ }+ if (link.getSource().equals(link.getTarget()))+ throw new BadRequestException("Can not link to self");+ if (link.getSpec().getOpposite() != null) {+ if (link.getSource().getTargetLinks().stream().anyMatch(it -> it.getSpec().equals(link.getSpec()) && it.getTarget().equals(link.getTarget())))+ throw new BadRequestException("Source issue already linked to target issue via specified link spec");+ if (!link.getSpec().isMultiple() && link.getSource().getTargetLinks().stream().anyMatch(it -> it.getSpec().equals(link.getSpec())))+ throw new BadRequestException("Link spec is not multiple and the source issue is already linked to another issue via this link spec");+ if (!link.getSpec().getParsedIssueQuery(link.getSource().getProject()).matches(link.getTarget()))+ throw new BadRequestException("Link spec not allowed to link to the target issue");+ if (!link.getSpec().getOpposite().isMultiple() && link.getTarget().getSourceLinks().stream().anyMatch(it -> it.getSpec().equals(link.getSpec())))+ throw new BadRequestException("Opposite side of link spec is not multiple and the target issue is already linked to another issue via this link spec");+ if (!link.getSpec().getOpposite().getParsedIssueQuery(link.getSource().getProject()).matches(link.getSource()))+ throw new BadRequestException("Opposite side of link spec not allowed to link to the source issue");+ } else {+ if (link.getSource().getLinks().stream().anyMatch(it -> it.getSpec().equals(link.getSpec()) && it.getLinked(link.getSource()).equals(link.getTarget())))+ throw new BadRequestException("Specified issues already linked via specified link spec");+ if (!link.getSpec().isMultiple() && link.getSource().getLinks().stream().anyMatch(it -> it.getSpec().equals(link.getSpec())))+ throw new BadRequestException("Link spec is not multiple and source issue is already linked to another issue via this link spec");+ var parsedIssueQuery = link.getSpec().getParsedIssueQuery(link.getSource().getProject());+ if (!parsedIssueQuery.matches(link.getSource()) || !parsedIssueQuery.matches(link.getTarget()))+ throw new BadRequestException("Link spec not allowed to link specified issues");+ }++ linkManager.create(link);+ return link.getId();+ }++ @Api(order=300)+ @Path("/{linkId}")+ @DELETE+ public Response delete(@PathParam("linkId") Long linkId) {+ var link = linkManager.load(linkId);+ if (!canEditIssueLink(link.getSource().getProject(), link.getSpec())+ && !canEditIssueLink(link.getTarget().getProject(), link.getSpec())) {+ throw new UnauthorizedException();+ }+ linkManager.delete(link);+ return Response.ok().build();+ }++}diff --git a/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java b/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.javaindex 38329a3c94..4202259ff7 100644--- a/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java+++ b/server-core/src/main/java/io/onedev/server/rest/resource/IssueResource.java@@ -151,6 +151,16 @@ public class IssueResource {throw new UnauthorizedException();return issue.getWatches();}++ @Api(order=650)+ @Path("/{issueId}/links")+ @GET+ public Collection<IssueLink> getLinks(@PathParam("issueId") Long issueId) {+ Issue issue = issueManager.load(issueId);+ if (!SecurityUtils.canAccessIssue(issue))+ throw new UnauthorizedException();+ return issue.getLinks();+ }@Api(order=700)@Path("/{issueId}/pulls")diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.javaindex c10dd1eadf..ac308e2fc1 100644--- a/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/side/IssueSidePanel.java@@ -297,8 +297,7 @@ public abstract class IssueSidePanel extends Panel {RepeatingView linkedIssuesView = new RepeatingView("linkedIssues");for (Issue linkedIssue: getIssue().findLinkedIssues(spec, opposite)) {LinkDeleteListener deleteListener;- if (canEditIssueLink- && (linkedIssue.getProject().equals(getProject()) || SecurityUtils.canEditIssueLink(linkedIssue.getProject(), spec))) {+ if (canEditIssueLink) {deleteListener = new LinkDeleteListener() {@Override@@ -342,9 +341,6 @@ public abstract class IssueSidePanel extends Panel {getSession().warn("Can not link to self");} else if (getIssue().findLinkedIssues(spec, opposite).contains(selection)) {getSession().warn("Issue already added");- } else if (!selection.getProject().equals(getProject())- && !SecurityUtils.canEditIssueLink(selection.getProject(), spec)) {- getSession().warn("Not authorized to link issue in project '" + selection.getProject() + "'");} else {getIssueChangeManager().addLink(spec, getIssue(), selection, opposite);notifyIssueChange(target, getIssue());@@ -412,11 +408,7 @@ public abstract class IssueSidePanel extends Panel {Long prevLinkedIssueId = bean.getIssueId();- boolean authorized = SecurityUtils.canEditIssueLink(getProject(), side.getSpec())- && (prevLinkedIssue == null- || prevLinkedIssue.getProject().equals(getProject())- || SecurityUtils.canEditIssueLink(prevLinkedIssue.getProject(), side.getSpec()));-+ boolean authorized = SecurityUtils.canEditIssueLink(getProject(), side.getSpec());fragment.add(new InplacePropertyEditLink("edit", new AlignPlacement(100, 0, 100, 0)) {@Override@@ -454,10 +446,6 @@ public abstract class IssueSidePanel extends Panel {if (getIssue().equals(linkedIssue)) {getSession().warn("Can not link to self");singleLinkBean.setIssueId(prevLinkedIssueId);- } else if (linkedIssue != null && !linkedIssue.getProject().equals(getProject())- && !SecurityUtils.canEditIssueLink(linkedIssue.getProject(), side.getSpec())) {- getSession().warn("Not authorized to link issue in project '" + linkedIssue.getProject() + "'");- singleLinkBean.setIssueId(prevLinkedIssueId);} else {Issue prevLinkedIssue = getIssue().findLinkedIssue(side.getSpec(), side.isOpposite());getIssueChangeManager().changeLink(side.getSpec(), getIssue(), prevLinkedIssue, linkedIssue, side.isOpposite());