Skip to content

The Unified and Autonomous Development Platform

Fix issue #932 - CSS: Long field names and/or values break layout in issue details / board view issue details popup

Robin Shen892e7bed63b1
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java b/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java
index 89f29bcdd9..57b15ba8e0 100644
--- a/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java
+++ b/server-core/src/main/java/io/onedev/server/buildspec/job/Job.java
@@ -23,7 +23,6 @@ import javax.servlet.http.HttpServletRequest;
import javax.validation.ConstraintValidatorContext;
import javax.validation.Valid;
import javax.validation.constraints.Min;
-import javax.validation.constraints.Size;
import javax.ws.rs.core.HttpHeaders;
import org.apache.wicket.Component;
@@ -176,7 +175,6 @@ public class Job implements NamedElement, Serializable, Validatable {
}
@Editable(order=200, description="Steps will be executed serially on same node, sharing the same <a href='$docRoot/pages/concepts.md#job-workspace'>job workspace</a>")
- @Size(min=1, max=1000, message="At least one step needs to be configured")
public List<Step> getSteps() {
return steps;
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.html b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.html
index 244eeddae8..5424ef8f63 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.html
+++ b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.html
@@ -49,13 +49,6 @@
<span wicket:id="name"></span>
<span wicket:id="date"></span>
</wicket:fragment>
- <wicket:fragment wicket:id="commitFrag">
- <a wicket:id="hashLink" class="hash"><span wicket:id="hash"></span></a>
- <a wicket:id="copyHash" class="btn btn-xs btn-icon btn-light btn-hover-primary"><wicket:svg href="copy" class="icon"></wicket:svg></a>
- </wicket:fragment>
- <wicket:fragment wicket:id="pullRequestFrag">
- <a wicket:id="link"><span wicket:id="label"></span></a>
- </wicket:fragment>
<wicket:fragment wicket:id="listParamsFrag">
<div class="build-list-params">
<form wicket:id="form">
diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java
index 14cd1459bb..3349a63bf1 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/build/list/BuildListPanel.java
@@ -748,7 +748,6 @@ public abstract class BuildListPanel extends Panel {
@Override
protected void onSubmit(AjaxRequestTarget target, Form<?> form) {
super.onSubmit(target, form);
- modal.close();
if (getProject() != null) {
getProject().getBuildSetting().setListParams(listParams);
OneDev.getInstance(ProjectManager.class).save(getProject());
@@ -756,7 +755,7 @@ public abstract class BuildListPanel extends Panel {
getGlobalBuildSetting().setListParams(listParams);
OneDev.getInstance(SettingManager.class).saveBuildSetting(getGlobalBuildSetting());
}
- target.add(body);
+ setResponsePage(getPage().getClass(), getPage().getPageParameters());
}
});
@@ -1093,7 +1092,7 @@ public abstract class BuildListPanel extends Panel {
@Override
public String getCssClass() {
- return "param d-none d-xl-table-cell";
+ return "param d-none d-xl-table-cell text-break";
}
@Override
diff --git a/server-core/src/main/java/io/onedev/server/web/component/build/side/build-side.css b/server-core/src/main/java/io/onedev/server/web/component/build/side/build-side.css
index 88616206df..307b419359 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/build/side/build-side.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/build/side/build-side.css
@@ -28,6 +28,10 @@
display: table-cell;
padding: 0 0 1.5rem 1rem;
}
+.build-side>.params.properties>div>div.name,
+.build-side>.params.properties>div>div.value {
+ max-width: 150px;
+}
.build-side>.properties>div:last-child>div {
padding-bottom: 0;
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/field-values.css b/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/field-values.css
index 80488c26df..acd4b523ea 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/field-values.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/fieldvalues/field-values.css
@@ -10,4 +10,4 @@
.field-values .icon {
cursor: pointer;
display: none;
-}
\ No newline at end of file
+}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/side/issue-side.css b/server-core/src/main/java/io/onedev/server/web/component/issue/side/issue-side.css
index 7c48774240..556e698971 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/side/issue-side.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/side/issue-side.css
@@ -22,10 +22,21 @@
vertical-align: top;
font-weight: 600;
}
+.issue-side>.fields>.body>table>tbody>tr>td.name>span {
+ max-width: 120px;
+ display: inline-block;
+ word-break: break-all;
+}
.issue-side>.fields>.body>table>tbody>tr>td.values {
padding-bottom: 0.6rem;
vertical-align: top;
}
+.issue-side .field-values .value>span {
+ white-space: normal !important;
+ display: inline-block;
+ word-break: break-all;
+ max-width: 150px;
+}
.issue-side>.fields>.body>table>tbody>tr:last-child>td {
padding-bottom: 0;
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.html b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.html
index 6182f91d8e..5367e9a0d2 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.html
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/workflowreconcile/WorkflowReconcilePanel.html
@@ -82,10 +82,10 @@
<tbody>
<tr wicket:id="rows">
<td class="name">
- <span wicket:id="name"></span>
+ <span wicket:id="name" class="text-break"></span>
</td>
<td class="value">
- <span wicket:id="value"></span>
+ <span wicket:id="value" class="text-break"></span>
</td>
<td class="resolution">
<div wicket:id="resolution"></div>
diff --git a/server-core/src/main/java/io/onedev/server/web/editable/editable.css b/server-core/src/main/java/io/onedev/server/web/editable/editable.css
index 7932c18d54..f54af7299d 100644
--- a/server-core/src/main/java/io/onedev/server/web/editable/editable.css
+++ b/server-core/src/main/java/io/onedev/server/web/editable/editable.css
@@ -46,7 +46,7 @@
}
.editable table.norecords tfoot td {
border: none;
- padding: 0;
+ padding: 4px 0 0 0;
font-style: italic;
background-image: none;
height: auto;