The Unified and Autonomous Development Platform
feat: Mask job secret value while editing (#1787)
Robin Shen8cb9dfd1fb5a
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.javaindex 9d9bda2938..6d5bc4b8de 100644--- a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java+++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobSecretEditPanel.java@@ -18,7 +18,9 @@ import java.util.List;@SuppressWarnings("serial")public abstract class JobSecretEditPanel extends Panel {-++ private static final String MASK = "******";+private final int index;public JobSecretEditPanel(String id, int index) {@@ -36,6 +38,7 @@ public abstract class JobSecretEditPanel extends Panel {JobSecret editingSecret;if (index != -1) {editingSecret = getProject().getBuildSetting().getJobSecrets().get(index);+ editingSecret.setValue(MASK);} else {editingSecret = new JobSecret();}@@ -64,10 +67,13 @@ public abstract class JobSecretEditPanel extends Panel {super.onSubmit(target, form);List<JobSecret> secrets = getProject().getBuildSetting().getJobSecrets();- if (index == -1)+ if (index == -1) {secrets.add(editingSecret);- else+ } else {+ if (editingSecret.getValue().equals(MASK))+ editingSecret.setValue(secrets.get(index).getValue());secrets.set(index, editingSecret);+ }OneDev.getInstance(ProjectManager.class).update(getProject());onSaved(target);}