The Unified and Autonomous Development Platform
Fix issue #683 - Login with remember me ticked result in impersonation
Robin Shen94328e2a619c
diff --git a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.javaindex a02d73be4f..57daf3c6c4 100644--- a/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/simple/security/LoginPage.java@@ -209,10 +209,13 @@ public class LoginPage extends SimplePage {}private void afterLogin(User user) {- SecurityUtils.getSubject().runAs(user.getPrincipals());RememberMeManager rememberMeManager = OneDev.getInstance(RememberMeManager.class);- AuthenticationToken token = new UsernamePasswordToken(userName, password, rememberMe);- rememberMeManager.onSuccessfulLogin(SecurityUtils.getSubject(), token, user);+ if (rememberMe) {+ AuthenticationToken token = new UsernamePasswordToken(userName, password, rememberMe);+ rememberMeManager.onSuccessfulLogin(SecurityUtils.getSubject(), token, user);+ } else {+ SecurityUtils.getSubject().runAs(user.getPrincipals());+ }continueToOriginalDestination();throw new RestartResponseException(getApplication().getHomePage());