Skip to content

The Unified and Autonomous Development Platform

fix: Autoreload of page resulting in incorrect page, lost comment on submittion (OD-1789)

Robin Shen96ce8df979a2
diff --git a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java
index 8a76015ad4..e663a66abd 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/codecomment/CodeCommentPanel.java
@@ -7,7 +7,6 @@ import io.onedev.server.attachment.ProjectAttachmentSupport;
import io.onedev.server.entitymanager.CodeCommentManager;
import io.onedev.server.entitymanager.CodeCommentReplyManager;
import io.onedev.server.entitymanager.CodeCommentStatusChangeManager;
-import io.onedev.server.entitymanager.UserManager;
import io.onedev.server.model.*;
import io.onedev.server.model.support.CompareContext;
import io.onedev.server.security.SecurityUtils;
@@ -91,10 +90,6 @@ public abstract class CodeCommentPanel extends Panel {
return OneDev.getInstance(CodeCommentManager.class).load(commentId);
}
- private UserManager getUserManager() {
- return OneDev.getInstance(UserManager.class);
- }
-
private WebMarkupContainer newCommentOrReplyContainer() {
WebMarkupContainer viewFragment = new Fragment("comment", "commentOrReplyViewFrag", this);
viewFragment.setOutputMarkupId(true);
@@ -178,6 +173,11 @@ public abstract class CodeCommentPanel extends Panel {
SecurityUtils.canManageCodeComments(getProject()));
}
+ @Override
+ protected String getAutosaveKey() {
+ return "code-comment:" + getComment().getId() + ":content";
+ }
+
@Override
protected SuggestionSupport getSuggestionSupport() {
return CodeCommentPanel.this.getSuggestionSupport();
@@ -552,6 +552,11 @@ public abstract class CodeCommentPanel extends Panel {
SecurityUtils.canManageCodeComments(getProject()));
}
+ @Override
+ protected String getAutosaveKey() {
+ return "code-comment:" + getComment().getId() + ":new-reply";
+ }
+
@Override
protected SuggestionSupport getSuggestionSupport() {
return CodeCommentPanel.this.getSuggestionSupport();
@@ -843,7 +848,12 @@ public abstract class CodeCommentPanel extends Panel {
protected SuggestionSupport getSuggestionSupport() {
return CodeCommentPanel.this.getSuggestionSupport();
}
-
+
+ @Override
+ protected String getAutosaveKey() {
+ return "code-comment-reply:" + getReply().getId();
+ }
+
@Override
protected AttachmentSupport getAttachmentSupport() {
return new ProjectAttachmentSupport(getProject(), getComment().getUUID(),
diff --git a/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java b/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java
index 761e6a8df6..b48e7743bb 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/comment/CommentPanel.java
@@ -129,6 +129,11 @@ public abstract class CommentPanel extends Panel {
protected List<User> getParticipants() {
return CommentPanel.this.getParticipants();
}
+
+ @Override
+ protected String getAutosaveKey() {
+ return CommentPanel.this.getAutosaveKey();
+ }
};
input.setRequired(getRequiredLabel() != null).setLabel(Model.of(getRequiredLabel()));
@@ -264,12 +269,10 @@ public abstract class CommentPanel extends Panel {
protected List<User> getParticipants() {
return new ArrayList<>();
}
-
- protected List<User> getMentionables() {
- UserCache cache = OneDev.getInstance(UserManager.class).cloneCache();
- List<User> users = new ArrayList<>(cache.getUsers());
- users.sort(cache.comparingDisplayName(getParticipants()));
- return users;
- }
+
+ @Nullable
+ protected String getAutosaveKey() {
+ return null;
+ }
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
index 046c7214ae..dee1875776 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/diff/revision/RevisionDiffPanel.java
@@ -938,7 +938,12 @@ public abstract class RevisionDiffPanel extends Panel {
}
form.add(contentInput = new CommentInput("content", Model.of(mentions.toString()), true) {
-
+
+ @Override
+ protected String getAutosaveKey() {
+ return "project:" + getProject().getId() + ":new-code-comment";
+ }
+
@Override
protected ProjectAttachmentSupport getAttachmentSupport() {
return new ProjectAttachmentSupport(getProject(), uuid,
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesPanel.java
index b0673e1198..46bfc9f977 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/IssueActivitiesPanel.java
@@ -245,7 +245,11 @@ public abstract class IssueActivitiesPanel extends Panel {
protected List<Behavior> getInputBehaviors() {
return Lists.newArrayList(AttributeModifier.replace("placeholder", "Leave a comment"));
}
-
+
+ @Override
+ protected String getAutosaveKey() {
+ return "issue:" + getIssue().getId() + ":new-comment";
+ }
};
input.setOutputMarkupId(true);
input.setRequired(true).setLabel(Model.of("Comment"));
@@ -272,7 +276,6 @@ public abstract class IssueActivitiesPanel extends Panel {
((BasePage)getPage()).notifyObservablesChange(target, getIssue().getChangeObservables(false));
input.clearMarkdown();
-
target.add(fragment);
}
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java
index fe57a7eed5..aed0c09c79 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueCommentedPanel.java
@@ -23,6 +23,7 @@ import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.markup.html.panel.GenericPanel;
import org.apache.wicket.model.IModel;
+import org.jetbrains.annotations.Nullable;
import java.util.ArrayList;
import java.util.List;
@@ -111,7 +112,12 @@ class IssueCommentedPanel extends GenericPanel<IssueComment> {
deleteCallback.onDelete(target);
};
}
-
+
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "issue-comment:" + IssueCommentedPanel.this.getComment().getId();
+ }
});
setOutputMarkupId(true);
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java
index ff55926151..2277c553d8 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/activities/activity/IssueOpenedPanel.java
@@ -18,6 +18,7 @@ import org.apache.wicket.behavior.AttributeAppender;
import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.markup.html.panel.GenericPanel;
import org.apache.wicket.model.IModel;
+import org.jetbrains.annotations.Nullable;
import java.util.List;
@@ -38,7 +39,7 @@ class IssueOpenedPanel extends GenericPanel<Issue> {
.add(new AttributeAppender("title", DateUtils.formatDateTime(issue.getSubmitDate()))));
add(new CommentPanel("body") {
-
+
@Override
protected String getComment() {
return getIssue().getDescription();
@@ -83,20 +84,19 @@ class IssueOpenedPanel extends GenericPanel<Issue> {
@Override
protected ContentVersionSupport getContentVersionSupport() {
- return new ContentVersionSupport() {
-
- @Override
- public long getVersion() {
- return 0;
- }
-
- };
+ return () -> 0;
}
@Override
protected DeleteCallback getDeleteCallback() {
return null;
}
+
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "issue:" + getIssue().getId() + ":description";
+ }
});
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
index a4c24a1cb1..6b3808ab1b 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/issue/create/NewIssueEditor.java
@@ -305,24 +305,16 @@ public abstract class NewIssueEditor extends FormComponentPanel<Issue> implement
protected Project getProject() {
return NewIssueEditor.this.getProject();
}
-
- };
- descriptionInput.add(new IValidator<String>() {
@Override
- public void validate(IValidatable<String> validatable) {
- if (validatable.getValue().length() > Issue.MAX_DESCRIPTION_LEN) {
- validatable.error(new IValidationError() {
-
- @Override
- public Serializable getErrorMessage(IErrorMessageSource messageSource) {
- return "Description too long";
- }
-
- });
- }
+ protected String getAutosaveKey() {
+ return "project:" + getProject().getId() + ":new-issue";
+ }
+ };
+ descriptionInput.add((IValidator<String>) validatable -> {
+ if (validatable.getValue().length() > Issue.MAX_DESCRIPTION_LEN) {
+ validatable.error((IValidationError) messageSource -> "Description too long");
}
-
});
descriptionInput.setOutputMarkupId(true);
return descriptionInput;
diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java
index 780ba06d52..73c4a5779a 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownEditor.java
@@ -35,6 +35,7 @@ import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
import org.apache.wicket.markup.head.OnLoadHeaderItem;
import org.apache.wicket.markup.html.WebMarkupContainer;
import org.apache.wicket.markup.html.basic.Label;
+import org.apache.wicket.markup.html.form.Form;
import org.apache.wicket.markup.html.form.FormComponentPanel;
import org.apache.wicket.markup.html.form.TextArea;
import org.apache.wicket.markup.html.panel.Fragment;
@@ -73,6 +74,7 @@ import io.onedev.server.web.component.markdown.SuggestionSupport.Selection;
import io.onedev.server.web.component.modal.ModalPanel;
import io.onedev.server.web.page.project.ProjectPage;
import io.onedev.server.web.page.project.blob.render.BlobRenderContext;
+import org.unbescape.javascript.JavaScriptEscape;
@SuppressWarnings("serial")
public class MarkdownEditor extends FormComponentPanel<String> {
@@ -126,6 +128,10 @@ public class MarkdownEditor extends FormComponentPanel<String> {
protected void onModelChanged() {
super.onModelChanged();
input.setModelObject(getModelObject());
+ var target = RequestCycle.get().find(AjaxRequestTarget.class);
+ var form = findParent(Form.class);
+ if (target != null && form != null)
+ target.prependJavaScript(String.format("onedev.server.form.clearAutosavings($('#%s'));", form.getMarkupId()));
}
public void clearMarkdown() {
@@ -606,8 +612,14 @@ public class MarkdownEditor extends FormComponentPanel<String> {
explicit("action"), explicit("param1"), explicit("param2"),
explicit("param3"), explicit("param4")).toString();
String attachmentUploadUrl = attachmentUploadBehavior.getCallbackUrl().toString();
+
+ String escapedAutosaveKey = getAutosaveKey();
+ if (escapedAutosaveKey != null)
+ escapedAutosaveKey = "'" + JavaScriptEscape.escapeJavaScript(escapedAutosaveKey) + "'";
+ else
+ escapedAutosaveKey = "undefined";
- String script = String.format("onedev.server.markdown.onDomReady('%s', %s, %d, %s, %d, %b, %b, '%s', '%s');",
+ String script = String.format("onedev.server.markdown.onDomReady('%s', %s, %d, %s, %d, %b, %b, '%s', '%s', %s);",
container.getMarkupId(),
actionCallback,
ATWHO_LIMIT,
@@ -616,7 +628,8 @@ public class MarkdownEditor extends FormComponentPanel<String> {
getUserMentionSupport() != null,
getReferenceSupport() != null,
escapeJavaScript(ProjectPathValidator.PATTERN.pattern()),
- escapeJavaScript(ProjectKeyValidator.PATTERN.pattern()));
+ escapeJavaScript(ProjectKeyValidator.PATTERN.pattern()),
+ escapedAutosaveKey);
response.render(OnDomReadyHeaderItem.forScript(script));
script = String.format("onedev.server.markdown.onLoad('%s');", container.getMarkupId());
@@ -644,6 +657,11 @@ public class MarkdownEditor extends FormComponentPanel<String> {
|| fileName.endsWith(".gif") || fileName.endsWith(".png");
}
+ @Nullable
+ protected String getAutosaveKey() {
+ return null;
+ }
+
@Nullable
protected AttachmentSupport getAttachmentSupport() {
return null;
diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.css b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.css
index 208e38ff29..dab4cf9ce5 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.css
+++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.css
@@ -26,6 +26,9 @@
padding-bottom: 0.6rem;
display: none;
}
+.markdown-editor>.head>.warning .close .icon {
+ vertical-align: middle;
+}
.markdown-editor>.head>.warning, .markdown-editor>.head>.help, .markdown-editor>.head>.emojis {
margin: 0.3rem;
}
diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
index 8c93c367d6..917a7cc52f 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
+++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
@@ -64,7 +64,7 @@ onedev.server.markdown = {
},
onDomReady: function(containerId, callback, atWhoLimit, attachmentUploadUrl,
attachmentMaxSize, canMentionUser, canReferenceEntity,
- projectPathPattern, projectKeyPattern) {
+ projectPathPattern, projectKeyPattern, autosaveKey) {
var $container = $("#" + containerId);
var useFixedWidthFontCookieName = "markdownEditor.useFixedWidthFont";
var useFixedWidthFont = Cookies.get(useFixedWidthFontCookieName);
@@ -72,6 +72,7 @@ onedev.server.markdown = {
$container.addClass("fixed-width");
$container.data("callback", callback);
+ $container.data("autosaveKey", autosaveKey);
var $head = $container.children(".head");
var $body = $container.children(".body");
@@ -164,6 +165,12 @@ onedev.server.markdown = {
var previewTimeout = 500;
$input.doneEvents("input inserted.atwho", function() {
function render() {
+ if (autosaveKey) {
+ var content = $input.val();
+ if (content.trim().length != 0)
+ localStorage.setItem(autosaveKey, content);
+ }
+
/*
* in case an ajax call is ongoing we postpone the render
* as the ongoing call may alter the component layout
@@ -953,7 +960,18 @@ onedev.server.markdown = {
else
$preview.height(defaultHeight);
}
- }
+ }
+ var autosaveKey = $container.data("autosaveKey");
+ if (autosaveKey) {
+ onedev.server.form.registerAutosaveKey($container.closest("form.leave-confirm"), autosaveKey);
+ var autosaveValue = localStorage.getItem(autosaveKey);
+ if (autosaveValue && $input.val() != autosaveValue) {
+ $input.val(autosaveValue);
+ $warning.show();
+ onedev.server.markdown.fireInputEvent($input);
+ }
+ }
+
},
onRendered: function(containerId, html) {
var $preview = $("#" + containerId + ">.body>.preview");
diff --git a/server-core/src/main/java/io/onedev/server/web/page/base/base.js b/server-core/src/main/java/io/onedev/server/web/page/base/base.js
index 2c10c0d700..c7f722544a 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/base/base.js
+++ b/server-core/src/main/java/io/onedev/server/web/page/base/base.js
@@ -171,6 +171,7 @@ onedev.server = {
var $dirtyForms = $container.find(selector).addBack(selector);
if ($dirtyForms.length != 0) {
if (confirm("There are unsaved changes, do you want to discard and continue?")) {
+ onedev.server.form.clearAutosavings($dirtyForms);
return true;
} else {
return false;
@@ -178,6 +179,16 @@ onedev.server = {
} else {
return true;
}
+ },
+ clearAutosavings: function($dirtyForms) {
+ $dirtyForms.each(function() {
+ var autosaveKey = $(this).data("autosaveKey");
+ if (autosaveKey)
+ localStorage.removeItem(autosaveKey);
+ });
+ },
+ registerAutosaveKey: function($form, autosaveKey) {
+ $form.data("autosaveKey", autosaveKey);
}
},
isDarkMode: function() {
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditor.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditor.java
index bd438e541f..51413af4b7 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditor.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/markdown/MarkdownBlobEditor.java
@@ -23,6 +23,7 @@ import org.apache.wicket.markup.head.IHeaderResponse;
import org.apache.wicket.markup.head.OnDomReadyHeaderItem;
import org.apache.wicket.markup.html.form.FormComponentPanel;
import org.apache.wicket.model.Model;
+import org.jetbrains.annotations.Nullable;
import java.nio.charset.Charset;
import java.nio.charset.StandardCharsets;
@@ -57,6 +58,12 @@ class MarkdownBlobEditor extends FormComponentPanel<byte[]> {
return manager.process(manager.render(markdown), context.getProject(), context, null, false);
}
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "project:" + getBlobRenderContext().getProject().getId() + ":markdown-file";
+ }
+
@Override
protected boolean shouldTrimInput() {
return false;
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java
index 11d7e59f77..a2c863cdc7 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/source/SourceViewPanel.java
@@ -499,7 +499,12 @@ public class SourceViewPanel extends BlobViewPanel implements Positionable, Sear
mark.setRange(range);
form.add(contentInput = new CommentInput("content", Model.of(mentions.toString()), true) {
-
+
+ @Override
+ protected String getAutosaveKey() {
+ return "project:" + context.getProject().getId() + ":new-code-comment";
+ }
+
@Override
protected ProjectAttachmentSupport getAttachmentSupport() {
return new ProjectAttachmentSupport(context.getProject(), uuid,
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java
index a669f5c774..24b24e83ba 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/create/NewPullRequestPage.java
@@ -742,6 +742,11 @@ public class NewPullRequestPage extends ProjectPage implements RevisionDiff.Anno
protected Project getProject() {
return target.getProject();
}
+
+ @Override
+ protected String getAutosaveKey() {
+ return "project:" + getProject().getId() + ":new-pull-request";
+ }
};
descriptionInput.add(validatable -> {
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java
index 18fc7c522a..3fc35295d3 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/PullRequestActivitiesPage.java
@@ -53,6 +53,7 @@ import org.apache.wicket.request.http.WebRequest;
import org.apache.wicket.request.http.WebResponse;
import org.apache.wicket.request.mapper.parameter.PageParameters;
import org.eclipse.jgit.lib.ObjectId;
+import org.jetbrains.annotations.Nullable;
import org.joda.time.DateTime;
import javax.servlet.http.Cookie;
@@ -281,7 +282,13 @@ public class PullRequestActivitiesPage extends PullRequestDetailPage {
protected Project getProject() {
return PullRequestActivitiesPage.this.getProject();
}
-
+
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "pull-request:" + getPullRequest().getId() + ":new-comment";
+ }
+
@Override
protected List<User> getParticipants() {
return getPullRequest().getParticipants();
@@ -317,7 +324,6 @@ public class PullRequestActivitiesPage extends PullRequestDetailPage {
((BasePage)getPage()).notifyObservableChange(target,
PullRequest.getChangeObservable(getPullRequest().getId()));
input.clearMarkdown();
-
target.add(fragment);
}
}
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestCommentedPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestCommentedPanel.java
index dc7e69967b..6b3fafb729 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestCommentedPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestCommentedPanel.java
@@ -24,6 +24,7 @@ import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.markup.html.panel.GenericPanel;
import org.apache.wicket.model.AbstractReadOnlyModel;
import org.apache.wicket.model.IModel;
+import org.jetbrains.annotations.Nullable;
import java.util.List;
@@ -86,6 +87,12 @@ class PullRequestCommentedPanel extends GenericPanel<PullRequestComment> {
return PullRequestCommentedPanel.this.getComment().getProject();
}
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "pull-request-comment:" + PullRequestCommentedPanel.this.getComment().getId();
+ }
+
@Override
protected AttachmentSupport getAttachmentSupport() {
return new ProjectAttachmentSupport(getProject(),
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedPanel.java
index ca5bc14dac..abc15fa7d7 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/pullrequests/detail/activities/activity/PullRequestOpenedPanel.java
@@ -18,6 +18,7 @@ import org.apache.wicket.behavior.AttributeAppender;
import org.apache.wicket.markup.html.basic.Label;
import org.apache.wicket.markup.html.panel.GenericPanel;
import org.apache.wicket.model.IModel;
+import org.jetbrains.annotations.Nullable;
import java.util.List;
@@ -51,6 +52,12 @@ class PullRequestOpenedPanel extends GenericPanel<PullRequest> {
PullRequest.getChangeObservable(getPullRequest().getId()));
}
+ @Nullable
+ @Override
+ protected String getAutosaveKey() {
+ return "pull-request:" + getPullRequest().getId() + ":description";
+ }
+
@Override
protected Project getProject() {
return getPullRequest().getTargetProject();