The Unified and Autonomous Development Platform
Fix issue #1158 - Able to define job properties in project hierarchy
Robin Shen99d3f6335d9f
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.javaindex 9f35e2b665..6e40b23c4f 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/BuildSpec.java@@ -22,6 +22,8 @@ import io.onedev.server.buildspec.step.StepTemplate;import io.onedev.server.buildspec.step.UseTemplateStep;import io.onedev.server.migration.VersionedYamlDoc;import io.onedev.server.migration.XmlBuildSpecMigrator;+import io.onedev.server.model.Project;+import io.onedev.server.model.support.build.JobProperty;import io.onedev.server.util.ComponentContext;import io.onedev.server.util.JobSecretAuthorizationContext;import io.onedev.server.util.validation.Validatable;@@ -84,7 +86,7 @@ public class BuildSpec implements Serializable, Validatable {private List<Service> services = new ArrayList<>();- private List<Property> properties = new ArrayList<>();+ private List<JobProperty> properties = new ArrayList<>();private List<Import> imports = new ArrayList<>();@@ -96,7 +98,7 @@ public class BuildSpec implements Serializable, Validatable {private transient Map<String, Service> serviceMap;- private transient Map<String, Property> propertyMap;+ private transient Map<String, JobProperty> propertyMap;@Editable@Valid@@ -132,11 +134,11 @@ public class BuildSpec implements Serializable, Validatable {}@Editable- public List<Property> getProperties() {+ public List<JobProperty> getProperties() {return properties;}- public void setProperties(List<Property> properties) {+ public void setProperties(List<JobProperty> properties) {this.properties = properties;propertyMap = null;}@@ -192,14 +194,18 @@ public class BuildSpec implements Serializable, Validatable {return jobMap;}- public Map<String, Property> getPropertyMap() {+ public Map<String, JobProperty> getPropertyMap() {if (propertyMap == null) {propertyMap = new LinkedHashMap<>();+ if (Project.get() != null) {+ for (JobProperty property : Project.get().getHierarchyJobProperties())+ propertyMap.put(property.getName(), property);+ }for (BuildSpec buildSpec: getImportedBuildSpecs(new HashSet<>())) {- for (Property property: buildSpec.getProperties())+ for (JobProperty property : buildSpec.getProperties())propertyMap.put(property.getName(), property);}- for (Property property: getProperties())+ for (JobProperty property : getProperties())propertyMap.put(property.getName(), property);}return propertyMap;@@ -306,7 +312,7 @@ public class BuildSpec implements Serializable, Validatable {}}Set<String> propertyNames = new HashSet<>();- for (Property property: properties) {+ for (JobProperty property : properties) {if (!propertyNames.add(property.getName())) {context.buildConstraintViolationWithTemplate("Duplicate property name (" + property.getName() + ")").addPropertyNode(PROP_PROPERTIES).addConstraintViolation();@@ -517,7 +523,7 @@ public class BuildSpec implements Serializable, Validatable {LinearRange match = LinearRange.match(each, matchWith);if (match != null) {completions.add(new InputCompletion(each, each + status.getContentAfterCaret(),- each.length(), "override imported", match));+ each.length(), "override", match));}}diff --git a/server-core/src/main/java/io/onedev/server/git/GitFilter.java b/server-core/src/main/java/io/onedev/server/git/GitFilter.javaindex b26c4f634c..d0f6a2f2a7 100644--- a/server-core/src/main/java/io/onedev/server/git/GitFilter.java+++ b/server-core/src/main/java/io/onedev/server/git/GitFilter.java@@ -30,8 +30,10 @@ import javax.ws.rs.core.MediaType;import javax.ws.rs.core.Response;import javax.ws.rs.core.StreamingOutput;+import io.onedev.server.util.ExceptionUtils;import org.apache.commons.compress.utils.IOUtils;import org.apache.commons.lang3.StringUtils;+import org.apache.shiro.authc.AuthenticationException;import org.apache.shiro.authz.UnauthorizedException;import org.eclipse.jgit.http.server.GitSmartHttpTools;import org.eclipse.jgit.http.server.ServletUtils;@@ -394,11 +396,12 @@ public class GitFilter implements Filter {chain.doFilter(request, response);}} catch (SystemNotReadyException e) {- logger.debug("Unable to serve git request as system is not ready yet");GitSmartHttpTools.sendError(httpRequest, httpResponse, HttpServletResponse.SC_SERVICE_UNAVAILABLE, e.getMessage());- } catch (GitException|InterruptedException|ExecutionException e) {+ } catch (UnauthorizedException|AuthenticationException e) {+ throw e;+ } catch (Exception e) {logger.error("Error serving git request", e);- GitSmartHttpTools.sendError(httpRequest, httpResponse, HttpServletResponse.SC_INTERNAL_SERVER_ERROR, e.getMessage());+ throw ExceptionUtils.unchecked(e);}}diff --git a/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java b/server-core/src/main/java/io/onedev/server/migration/DataMigrator.javaindex f245840089..a29e31f8d8 100644--- a/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java+++ b/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java@@ -4832,4 +4832,17 @@ public class DataMigrator {}}+ private void migrate110(File dataDir, Stack<Integer> versions) {+ for (File file: dataDir.listFiles()) {+ if (file.getName().startsWith("Projects.xml")) {+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);+ for (Element element: dom.getRootElement().elements()) {+ Element buildSettingElement = element.element("buildSetting");+ buildSettingElement.addElement("jobProperties");+ }+ dom.writeToFile(file, false);+ }+ }+ }+}diff --git a/server-core/src/main/java/io/onedev/server/model/Project.java b/server-core/src/main/java/io/onedev/server/model/Project.javaindex 18ccf58fb0..5ac0249d40 100644--- a/server-core/src/main/java/io/onedev/server/model/Project.java+++ b/server-core/src/main/java/io/onedev/server/model/Project.java@@ -54,6 +54,7 @@ import io.onedev.server.web.util.ProjectAware;import io.onedev.server.web.util.WicketUtils;import org.apache.commons.collections4.map.AbstractReferenceMap.ReferenceStrength;import org.apache.commons.collections4.map.ReferenceMap;+import org.apache.commons.lang3.SerializationUtils;import org.apache.shiro.authz.Permission;import org.apache.tika.mime.MediaType;import org.apache.wicket.util.encoding.UrlEncoder;@@ -161,7 +162,7 @@ public class Project extends AbstractEntity implements LabelSupport<ProjectLabelstack.get().pop();}- private static final ReferenceMap<ObjectId, Optional<BuildSpec>> buildSpecCache =+ private static final ReferenceMap<ObjectId, Optional<byte[]>> buildSpecCache =new ReferenceMap<>(ReferenceStrength.HARD, ReferenceStrength.SOFT);@ManyToOne(fetch=FetchType.LAZY)@@ -739,26 +740,35 @@ public class Project extends AbstractEntity implements LabelSupport<ProjectLabel*/@Nullablepublic BuildSpec getBuildSpec(ObjectId commitId) {- Optional<BuildSpec> buildSpec;+ Optional<byte[]> buildSpecBytes;synchronized (buildSpecCache) {- buildSpec = buildSpecCache.get(commitId);+ buildSpecBytes = buildSpecCache.get(commitId);}- if (buildSpec == null) {+ if (buildSpecBytes == null) {Blob blob = getBlob(new BlobIdent(commitId.name(), BuildSpec.BLOB_PATH, FileMode.TYPE_FILE), false);+ BuildSpec buildSpec;if (blob != null) {- buildSpec = Optional.fromNullable(BuildSpec.parse(blob.getBytes()));+ buildSpec = BuildSpec.parse(blob.getBytes());} else {Blob oldBlob = getBlob(new BlobIdent(commitId.name(), ".onedev-buildspec", FileMode.TYPE_FILE), false);if (oldBlob != null)- buildSpec = Optional.fromNullable(BuildSpec.parse(oldBlob.getBytes()));+ buildSpec = BuildSpec.parse(oldBlob.getBytes());else- buildSpec = Optional.absent();+ buildSpec = null;}+ if (buildSpec != null)+ buildSpecBytes = Optional.of(SerializationUtils.serialize(buildSpec));+ else+ buildSpecBytes = Optional.absent();synchronized (buildSpecCache) {- buildSpecCache.put(commitId, buildSpec);+ buildSpecCache.put(commitId, buildSpecBytes);}+ return buildSpec;+ } else if (buildSpecBytes.isPresent()) {+ return SerializationUtils.deserialize(buildSpecBytes.get());+ } else {+ return null;}- return buildSpec.orNull();}public List<String> getJobNames() {@@ -921,6 +931,18 @@ public class Project extends AbstractEntity implements LabelSupport<ProjectLabel}return jobSecrets;}++ public List<JobProperty> getHierarchyJobProperties() {+ List<JobProperty> jobProperties = new ArrayList<>(getBuildSetting().getJobProperties());+ if (getParent() != null) {+ Set<String> names = jobProperties.stream().map(it->it.getName()).collect(Collectors.toSet());+ for (JobProperty jobProperty : getParent().getHierarchyJobProperties()) {+ if (!names.contains(jobProperty.getName()))+ jobProperties.add(jobProperty);+ }+ }+ return jobProperties;+ }public List<ActionAuthorization> getHierarchyActionAuthorizations() {List<ActionAuthorization> actionAuthorizations = new ArrayList<>(getBuildSetting().getActionAuthorizations());@@ -1365,8 +1387,10 @@ public class Project extends AbstractEntity implements LabelSupport<ProjectLabel@Nullablepublic static Project get() {- if (!stack.get().isEmpty()) {+ if (!stack.get().isEmpty()) {return stack.get().peek();+ } else if (Build.get() != null) {+ return Build.get().getProject();} else {ComponentContext componentContext = ComponentContext.get();if (componentContext != null) {diff --git a/server-core/src/main/java/io/onedev/server/buildspec/Property.java b/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.javasimilarity index 76%rename from server-core/src/main/java/io/onedev/server/buildspec/Property.javarename to server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.javaindex d9cf3b30c4..855187a6c9 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/Property.java+++ b/server-core/src/main/java/io/onedev/server/model/support/build/JobProperty.java@@ -1,62 +1,57 @@-package io.onedev.server.buildspec;--import java.io.Serializable;-import java.util.ArrayList;-import java.util.List;--import javax.validation.constraints.NotEmpty;--import io.onedev.commons.codeassist.InputCompletion;-import io.onedev.commons.codeassist.InputStatus;-import io.onedev.commons.codeassist.InputSuggestion;-import io.onedev.server.web.editable.annotation.Editable;-import io.onedev.server.web.editable.annotation.SuggestionProvider;--@Editable-public class Property implements NamedElement, Serializable {-- private static final long serialVersionUID = 1L;-- private String name;-- private String value;-- @Editable(order=100)- @SuggestionProvider("getNameSuggestions")- @NotEmpty- @Override- public String getName() {- return name;- }-- public void setName(String name) {- this.name = name;- }-- @SuppressWarnings("unused")- private static List<InputCompletion> getNameSuggestions(InputStatus status) {- BuildSpec buildSpec = BuildSpec.get();- if (buildSpec != null) {- List<String> candidates = new ArrayList<>(buildSpec.getPropertyMap().keySet());- buildSpec.getProperties().forEach(it->candidates.remove(it.getName()));- return BuildSpec.suggestOverrides(candidates, status);- }- return new ArrayList<>();- }-- @Editable(order=200)- @NotEmpty- public String getValue() {- return value;- }-- public void setValue(String value) {- this.value = value;- }-- @SuppressWarnings("unused")- private static List<InputSuggestion> suggestVariables(String matchWith) {- return BuildSpec.suggestVariables(matchWith, false, false, false);- }--}+package io.onedev.server.model.support.build;++import io.onedev.commons.codeassist.InputCompletion;+import io.onedev.commons.codeassist.InputStatus;+import io.onedev.server.buildspec.BuildSpec;+import io.onedev.server.buildspec.NamedElement;+import io.onedev.server.web.editable.annotation.Editable;+import io.onedev.server.web.editable.annotation.SuggestionProvider;++import javax.validation.constraints.NotEmpty;+import java.io.Serializable;+import java.util.ArrayList;+import java.util.List;++@Editable+public class JobProperty implements NamedElement, Serializable {++ private static final long serialVersionUID = 1L;++ private String name;++ private String value;++ @Editable(order=100)+ @SuggestionProvider("getNameSuggestions")+ @NotEmpty+ @Override+ public String getName() {+ return name;+ }++ public void setName(String name) {+ this.name = name;+ }++ @SuppressWarnings("unused")+ private static List<InputCompletion> getNameSuggestions(InputStatus status) {+ BuildSpec buildSpec = BuildSpec.get();+ if (buildSpec != null) {+ List<String> candidates = new ArrayList<>(buildSpec.getPropertyMap().keySet());+ buildSpec.getProperties().forEach(it->candidates.remove(it.getName()));+ return BuildSpec.suggestOverrides(candidates, status);+ }+ return new ArrayList<>();+ }++ @Editable(order=200)+ @NotEmpty+ public String getValue() {+ return value;+ }++ public void setValue(String value) {+ this.value = value;+ }++}diff --git a/server-core/src/main/java/io/onedev/server/model/support/build/ProjectBuildSetting.java b/server-core/src/main/java/io/onedev/server/model/support/build/ProjectBuildSetting.javaindex 6de508cbe5..c31dd657b9 100644--- a/server-core/src/main/java/io/onedev/server/model/support/build/ProjectBuildSetting.java+++ b/server-core/src/main/java/io/onedev/server/model/support/build/ProjectBuildSetting.java@@ -33,6 +33,8 @@ public class ProjectBuildSetting implements Serializable {private List<String> listParams;private List<NamedBuildQuery> namedQueries;++ private List<JobProperty> jobProperties = new ArrayList<>();private List<JobSecret> jobSecrets = new ArrayList<>();@@ -48,7 +50,15 @@ public class ProjectBuildSetting implements Serializable {actionAuthorizations.add(new CloseMilestoneAuthorization());actionAuthorizations.add(new CreateTagAuthorization());}-++ public List<JobProperty> getJobProperties() {+ return jobProperties;+ }++ public void setJobProperties(List<JobProperty> jobProperties) {+ this.jobProperties = jobProperties;+ }+public List<JobSecret> getJobSecrets() {return jobSecrets;}diff --git a/server-core/src/main/java/io/onedev/server/util/interpolative/VariableInterpolator.java b/server-core/src/main/java/io/onedev/server/util/interpolative/VariableInterpolator.javaindex 9decb43327..bcbbfd2662 100644--- a/server-core/src/main/java/io/onedev/server/util/interpolative/VariableInterpolator.java+++ b/server-core/src/main/java/io/onedev/server/util/interpolative/VariableInterpolator.java@@ -17,7 +17,7 @@ import javax.annotation.Nullable;import io.onedev.commons.utils.ExplicitException;import io.onedev.commons.utils.StringUtils;-import io.onedev.server.buildspec.Property;+import io.onedev.server.model.support.build.JobProperty;import io.onedev.server.buildspec.job.JobVariable;import io.onedev.server.buildspec.param.ParamCombination;import io.onedev.server.buildspec.param.spec.ParamSpec;@@ -91,7 +91,7 @@ public class VariableInterpolator {elsepropertyName = t.substring("properties:".length());- Property property = build.getSpec().getPropertyMap().get(propertyName);+ JobProperty property = build.getSpec().getPropertyMap().get(propertyName);if (property != null)return property.getValue();elsediff --git a/server-core/src/main/java/io/onedev/server/web/mapper/BaseUrlMapper.java b/server-core/src/main/java/io/onedev/server/web/mapper/BaseUrlMapper.javaindex d1eee06426..38896a3cd0 100644--- a/server-core/src/main/java/io/onedev/server/web/mapper/BaseUrlMapper.java+++ b/server-core/src/main/java/io/onedev/server/web/mapper/BaseUrlMapper.java@@ -1,5 +1,6 @@package io.onedev.server.web.mapper;+import io.onedev.server.web.page.project.setting.build.*;import io.onedev.server.web.page.project.setting.code.git.GitPackConfigPage;import io.onedev.server.web.page.project.setting.code.pullrequest.PullRequestSettingPage;import org.apache.wicket.core.request.mapper.ResourceMapper;@@ -121,10 +122,6 @@ import io.onedev.server.web.page.project.pullrequests.detail.codecomments.PullReimport io.onedev.server.web.page.project.setting.authorization.ProjectAuthorizationsPage;import io.onedev.server.web.page.project.setting.avatar.AvatarEditPage;import io.onedev.server.web.page.project.setting.code.branchprotection.BranchProtectionsPage;-import io.onedev.server.web.page.project.setting.build.ActionAuthorizationsPage;-import io.onedev.server.web.page.project.setting.build.BuildPreservationsPage;-import io.onedev.server.web.page.project.setting.build.DefaultFixedIssueFiltersPage;-import io.onedev.server.web.page.project.setting.build.JobSecretsPage;import io.onedev.server.web.page.project.setting.code.analysis.CodeAnalysisSettingPage;import io.onedev.server.web.page.project.setting.general.GeneralProjectSettingPage;import io.onedev.server.web.page.project.setting.pluginsettings.ContributedProjectSettingPage;@@ -373,6 +370,7 @@ public class BaseUrlMapper extends CompoundRequestMapper {add(new ProjectPageMapper("${project}/~settings/git-pack-config", GitPackConfigPage.class));add(new ProjectPageMapper("${project}/~settings/pull-request", PullRequestSettingPage.class));add(new ProjectPageMapper("${project}/~settings/build/job-secrets", JobSecretsPage.class));+ add(new ProjectPageMapper("${project}/~settings/build/job-properties", JobPropertiesPage.class));add(new ProjectPageMapper("${project}/~settings/build/action-authorizations", ActionAuthorizationsPage.class));add(new ProjectPageMapper("${project}/~settings/build/build-preserve-rules", BuildPreservationsPage.class));add(new ProjectPageMapper("${project}/~settings/build/default-fixed-issues-filter", DefaultFixedIssueFiltersPage.class));diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.javaindex f85eb21da5..68959b8f31 100644--- a/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java+++ b/server-core/src/main/java/io/onedev/server/web/page/project/ProjectPage.java@@ -54,10 +54,7 @@ import io.onedev.server.web.page.project.setting.ProjectSettingContribution;import io.onedev.server.web.page.project.setting.ProjectSettingPage;import io.onedev.server.web.page.project.setting.authorization.ProjectAuthorizationsPage;import io.onedev.server.web.page.project.setting.avatar.AvatarEditPage;-import io.onedev.server.web.page.project.setting.build.ActionAuthorizationsPage;-import io.onedev.server.web.page.project.setting.build.BuildPreservationsPage;-import io.onedev.server.web.page.project.setting.build.DefaultFixedIssueFiltersPage;-import io.onedev.server.web.page.project.setting.build.JobSecretsPage;+import io.onedev.server.web.page.project.setting.build.*;import io.onedev.server.web.page.project.setting.code.analysis.CodeAnalysisSettingPage;import io.onedev.server.web.page.project.setting.code.branchprotection.BranchProtectionsPage;import io.onedev.server.web.page.project.setting.code.git.GitPackConfigPage;@@ -281,6 +278,8 @@ public abstract class ProjectPage extends LayoutPage implements ProjectAware {buildSettingMenuItems.add(new SidebarMenuItem.Page(null, "Job Secrets",JobSecretsPage.class, JobSecretsPage.paramsOf(getProject())));+ buildSettingMenuItems.add(new SidebarMenuItem.Page(null, "Job Properties",+ JobPropertiesPage.class, JobPropertiesPage.paramsOf(getProject())));buildSettingMenuItems.add(new SidebarMenuItem.Page(null, "Action Authorizations",ActionAuthorizationsPage.class, ActionAuthorizationsPage.paramsOf(getProject())));buildSettingMenuItems.add(new SidebarMenuItem.Page(null, "Build Preserve Rules",diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.javaindex 6a2a0c8847..53a39117f4 100644--- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java+++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecBlobViewPanel.java@@ -1,725 +1,725 @@-package io.onedev.server.web.page.project.blob.render.renderers.buildspec;--import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getActiveElementIndex;-import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getPosition;-import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getSelection;-import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getUrlSegment;--import java.io.Serializable;-import java.util.ArrayList;-import java.util.List;-import java.util.Map;-import java.util.UUID;--import javax.annotation.Nullable;-import javax.validation.ConstraintViolation;-import javax.validation.Validator;--import org.apache.wicket.Component;-import org.apache.wicket.ajax.AjaxRequestTarget;-import org.apache.wicket.ajax.markup.html.AjaxLink;-import org.apache.wicket.behavior.AttributeAppender;-import org.apache.wicket.behavior.Behavior;-import org.apache.wicket.event.Broadcast;-import org.apache.wicket.feedback.FencedFeedbackPanel;-import org.apache.wicket.markup.ComponentTag;-import org.apache.wicket.markup.head.IHeaderResponse;-import org.apache.wicket.markup.head.JavaScriptHeaderItem;-import org.apache.wicket.markup.head.OnDomReadyHeaderItem;-import org.apache.wicket.markup.html.WebMarkupContainer;-import org.apache.wicket.markup.html.basic.Label;-import org.apache.wicket.markup.html.link.Link;-import org.apache.wicket.markup.html.list.ListItem;-import org.apache.wicket.markup.html.list.ListView;-import org.apache.wicket.markup.html.panel.Fragment;-import org.apache.wicket.markup.repeater.RepeatingView;-import org.eclipse.jgit.lib.FileMode;-import org.unbescape.html.HtmlEscape;--import com.google.common.base.Throwables;--import io.onedev.commons.utils.StringUtils;-import io.onedev.server.OneDev;-import io.onedev.server.buildspec.BuildSpec;-import io.onedev.server.buildspec.Import;-import io.onedev.server.buildspec.NamedElement;-import io.onedev.server.buildspec.Property;-import io.onedev.server.buildspec.Service;-import io.onedev.server.buildspec.job.Job;-import io.onedev.server.buildspec.step.StepTemplate;-import io.onedev.server.git.Blob;-import io.onedev.server.git.BlobIdent;-import io.onedev.server.model.Project;-import io.onedev.server.model.PullRequest;-import io.onedev.server.security.SecurityUtils;-import io.onedev.server.util.ReflectionUtils;-import io.onedev.server.web.asset.icon.IconScope;-import io.onedev.server.web.component.MultilineLabel;-import io.onedev.server.web.component.job.RunJobLink;-import io.onedev.server.web.component.link.ViewStateAwarePageLink;-import io.onedev.server.web.component.pipeline.JobSelectionChange;-import io.onedev.server.web.component.pipeline.PipelinePanel;-import io.onedev.server.web.component.svg.SpriteImage;-import io.onedev.server.web.editable.BeanContext;-import io.onedev.server.web.editable.EditableUtils;-import io.onedev.server.web.editable.PropertyContext;-import io.onedev.server.web.page.base.BasePage;-import io.onedev.server.web.page.project.blob.ProjectBlobPage;-import io.onedev.server.web.page.project.blob.render.BlobRenderContext;-import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel;--@SuppressWarnings("serial")-public class BuildSpecBlobViewPanel extends BlobViewPanel {-- public BuildSpecBlobViewPanel(String id, BlobRenderContext context) {- super(id, context);- }-- @Override- protected void onInitialize() {- super.onInitialize();-- Serializable parseResult;- try {- Blob blob = context.getProject().getBlob(context.getBlobIdent(), true);- parseResult = BuildSpec.parse(blob.getBytes());- } catch (Exception e) {- parseResult = e;- }- if (parseResult != null) {- if (parseResult instanceof BuildSpec) {- BuildSpec buildSpec = (BuildSpec) parseResult;-- add(new Fragment("content", "parseableFrag", this) {-- private void resizeWindow(AjaxRequestTarget target) {- ((BasePage)getPage()).resizeWindow(target);- }-- private void setupPropertiesViewer(@Nullable AjaxRequestTarget target) {- Component propertiesViewer;- List<Property> properties = new ArrayList<>(buildSpec.getPropertyMap().values());-- if (!properties.isEmpty()) {- propertiesViewer = new Fragment("content", "propertiesFrag", BuildSpecBlobViewPanel.this) {-- @Override- protected void onInitialize() {- super.onInitialize();-- add(new ListView<Property>("properties", properties) {-- @Override- protected void populateItem(ListItem<Property> item) {- Property property = item.getModelObject();- item.add(new Label("name", property.getName()));-- Import aImport = null;- for (Import each: buildSpec.getImports()) {- try {- if (each.getBuildSpec().getPropertyMap().get(property.getName()) == property) {- aImport = each;- break;- }- } catch (Exception e) {- // Ignore. This error will be shown when validating- }- }-- if (aImport != null) {- ProjectBlobPage.State state = new ProjectBlobPage.State();- state.blobIdent = new BlobIdent(aImport.getTag(), BuildSpec.BLOB_PATH,- FileMode.REGULAR_FILE.getBits());- state.position = BuildSpecRenderer.getPosition("properties");- Project project = aImport.getProject();- Link<?> link = new ViewStateAwarePageLink<Void>("imported", ProjectBlobPage.class,- ProjectBlobPage.paramsOf(project, state)) {-- @Override- protected void onComponentTag(ComponentTag tag) {- super.onComponentTag(tag);- if (!isEnabled())- tag.setName("span");- }-- };- link.add(AttributeAppender.append("title",- "This property is imported from " + aImport.getProjectPath()));- link.setEnabled(SecurityUtils.canReadCode(project));- item.add(link);- } else {- item.add(new WebMarkupContainer("imported").setVisible(false));- }-- item.add(new Label("value", property.getValue()));- }-- });- }-- };- propertiesViewer.add(AttributeAppender.append("class", "properties autofit pr-3"));- } else {- propertiesViewer = new Label("content", "No properties defined");- String cssClasses = "properties not-defined alert alert-notice alert-light-warning d-flex";- propertiesViewer.add(AttributeAppender.append("class", cssClasses));- }- propertiesViewer.add(new Behavior() {-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.properties');"));- }-- });- propertiesViewer.setOutputMarkupId(true);- if (target != null) {- replace(propertiesViewer);- target.add(propertiesViewer);- } else {- add(propertiesViewer);- }- }-- private <T extends NamedElement> List<T> getAllElements(List<T> elements, Map<String, T> elementMap) {- List<T> allElements = new ArrayList<>(elements);- for (T element: elementMap.values()) {- if (!elements.contains(element))- allElements.add(element);- }- return allElements;- }-- private void setupJobsViewer(@Nullable AjaxRequestTarget target) {- Component jobsViewer;- List<Job> jobs = getAllElements(buildSpec.getJobs(), buildSpec.getJobMap());- if (!jobs.isEmpty()) {- jobsViewer = new Fragment("content", "jobsFrag", BuildSpecBlobViewPanel.this) {-- private void notifyJobSelectionChange(AjaxRequestTarget target, Job job) {- send(this, Broadcast.BREADTH, new JobSelectionChange(target, job));- }-- @Override- protected void onInitialize() {- super.onInitialize();-- int activeJobIndex = getActiveElementIndex(context, Job.class, jobs, 0);-- add(new PipelinePanel("pipeline") {-- @Override- protected Component renderJob(String componentId, int jobIndex) {- Fragment jobNav = new Fragment(componentId, "jobFrag", BuildSpecBlobViewPanel.this);-- AjaxLink<Void> jobLink = new AjaxLink<Void>("select") {-- @Override- public void onClick(AjaxRequestTarget target) {- Job job = getJobs().get(jobIndex);- String position = getPosition("jobs/" + job.getName());- context.pushState(target, context.getBlobIdent(), position);- setupJobDetail(target, jobIndex);- notifyJobSelectionChange(target, job);- resizeWindow(target);- }-- };-- Job job = getJobs().get(jobIndex);- String label = HtmlEscape.escapeHtml5(job.getName());- if (!buildSpec.getJobs().contains(job)) {- String iconHtml = String.format(- "<svg class='icon imported'><use xlink:href='%s'/></svg>",- SpriteImage.getVersionedHref(IconScope.class, "arrow2"));- label += iconHtml;- }- jobLink.add(new Label("label", label).setEscapeModelStrings(false));-- jobNav.add(jobLink);-- jobNav.add(new RunJobLink("run", context.getCommit().copy(), job.getName(), getContext().getRefName()) {-- @Override- protected Project getProject() {- return context.getProject();- }-- @Override- protected PullRequest getPullRequest() {- return null;- }-- @Override- protected String getPipeline() {- return UUID.randomUUID().toString();- }-- });- jobNav.add(AttributeAppender.append("class", "nav btn-group flex-nowrap"));- return jobNav;- }-- @Override- protected List<Job> getJobs() {- return jobs;- }-- @Override- protected int getActiveJobIndex() {- return activeJobIndex;- }-- });-- setupJobDetail(null, activeJobIndex);-- add(AttributeAppender.append("class", "elements jobs d-flex flex-nowrap"));- }-- private void setupJobDetail(@Nullable AjaxRequestTarget target, int jobIndex) {- Job job = jobs.get(jobIndex);- Fragment detailFrag = new Fragment("detail", "elementDetailFrag", BuildSpecBlobViewPanel.this);- detailFrag.add(new ElementImportNoticePanel(buildSpec, Job.class, job.getName()) {-- @Override- protected Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec) {- return buildSpec.getJobMap();- }-- });- detailFrag.add(BeanContext.view("content", job));- detailFrag.setOutputMarkupId(true);-- if (target != null) {- replace(detailFrag);- target.add(detailFrag);- } else {- add(detailFrag);- }- }-- };- } else {- String cssClasses = "jobs not-defined alert alert-notice alert-light-warning d-flex";- jobsViewer = new Label("content", "No jobs defined").add(AttributeAppender.append("class", cssClasses));- }- jobsViewer.add(new Behavior() {-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.jobs');"));- }-- });- jobsViewer.setOutputMarkupId(true);- if (target != null) {- replace(jobsViewer);- target.add(jobsViewer);- } else {- add(jobsViewer);- }- }-- private void setupServicesViewer(@Nullable AjaxRequestTarget target) {- Component servicesViewer;- List<Service> services = getAllElements(buildSpec.getServices(), buildSpec.getServiceMap());- if (!services.isEmpty()) {- servicesViewer = new ElementsViewer<Service>(buildSpec) {-- @Override- protected List<Service> getElements(boolean includeImported) {- if (includeImported)- return services;- else- return buildSpec.getServices();- }-- @Override- protected Map<String, Service> getElementMap(BuildSpec buildSpec) {- return buildSpec.getServiceMap();- }-- };- } else {- String cssClasses = "services not-defined alert alert-notice alert-light-warning d-flex";- servicesViewer = new Label("content", "No services defined").add(AttributeAppender.append("class", cssClasses));- }- servicesViewer.add(new Behavior() {-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.services');"));- }-- });- servicesViewer.setOutputMarkupId(true);- if (target != null) {- replace(servicesViewer);- target.add(servicesViewer);- } else {- add(servicesViewer);- }- }-- private void setupStepTemplatesViewer(@Nullable AjaxRequestTarget target) {- Component templatesViewer;- List<StepTemplate> templates = getAllElements(buildSpec.getStepTemplates(), buildSpec.getStepTemplateMap());- if (!templates.isEmpty()) {- templatesViewer = new ElementsViewer<StepTemplate>(buildSpec) {-- @Override- protected List<StepTemplate> getElements(boolean includeImported) {- if (includeImported)- return templates;- else- return buildSpec.getStepTemplates();- }-- @Override- protected Map<String, StepTemplate> getElementMap(BuildSpec buildSpec) {- return buildSpec.getStepTemplateMap();- }-- };- } else {- String cssClasses = "step-templates not-defined alert alert-notice alert-light-warning d-flex";- templatesViewer = new Label("content", "No step templates defined").add(AttributeAppender.append("class", cssClasses));- }- templatesViewer.add(new Behavior() {-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.step-templates');"));- }-- });- templatesViewer.setOutputMarkupId(true);- if (target != null) {- replace(templatesViewer);- target.add(templatesViewer);- } else {- add(templatesViewer);- }- }-- private void setupImportsViewer(@Nullable AjaxRequestTarget target) {- Component importsViewer;- if (!buildSpec.getImports().isEmpty()) {- importsViewer = PropertyContext.view("content", buildSpec, "imports");- importsViewer.add(AttributeAppender.append("class", "imports autofit pr-3"));- } else {- importsViewer = new Label("content", "No imports defined");- String cssClasses = "imports not-defined alert alert-notice alert-light-warning d-flex";- importsViewer.add(AttributeAppender.append("class", cssClasses));- }- importsViewer.add(new Behavior() {-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.imports');"));- }-- });- importsViewer.setOutputMarkupId(true);- if (target != null) {- replace(importsViewer);- target.add(importsViewer);- } else {- add(importsViewer);- }- }-- @Override- protected void onInitialize() {- super.onInitialize();-- Validator validator = OneDev.getInstance(Validator.class);- for (ConstraintViolation<BuildSpec> violation: validator.validate(buildSpec)) {- if (StringUtils.isNotBlank(violation.getPropertyPath().toString())) {- error(String.format("Error validating build spec (location: %s, error message: %s)",- violation.getPropertyPath(), violation.getMessage()));- } else {- error(String.format("Error validating build spec: %s", violation.getMessage()));- }- }-- add(new FencedFeedbackPanel("feedback", this));-- add(new AjaxLink<Void>("jobs") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition("jobs");- context.pushState(target, context.getBlobIdent(), position);- setupJobsViewer(target);- resizeWindow(target);- }-- });- add(new AjaxLink<Void>("services") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition("services");- context.pushState(target, context.getBlobIdent(), position);- setupServicesViewer(target);- resizeWindow(target);- }-- });- add(new AjaxLink<Void>("stepTemplates") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition("step-templates");- context.pushState(target, context.getBlobIdent(), position);- setupStepTemplatesViewer(target);- resizeWindow(target);- }-- });- add(new AjaxLink<Void>("properties") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition("properties");- context.pushState(target, context.getBlobIdent(), position);- setupPropertiesViewer(target);- resizeWindow(target);- }-- });- add(new AjaxLink<Void>("imports") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition("imports");- context.pushState(target, context.getBlobIdent(), position);- setupImportsViewer(target);- resizeWindow(target);- }-- });-- String selection = getSelection(context.getPosition());- if (selection == null || selection.startsWith("jobs"))- setupJobsViewer(null);- else if (selection.startsWith("services"))- setupServicesViewer(null);- else if (selection.startsWith("step-templates"))- setupStepTemplatesViewer(null);- else if (selection.equals("imports"))- setupImportsViewer(null);- else- setupPropertiesViewer(null);-- add(AttributeAppender.append("class", "parseable"));- }-- }.setOutputMarkupId(true));- } else {- Fragment unparseableFrag = new Fragment("content", "unparseableFrag", this);- unparseableFrag.add(AttributeAppender.append("class", "unparseable"));- unparseableFrag.add(new MultilineLabel("errorMessage",- Throwables.getStackTraceAsString((Throwable) parseResult)));- add(unparseableFrag);- }- } else {- String cssClasses = "not-defined m-4 alert alert-notice alert-light-warning";- add(new Label("content", "Build spec not defined").add(AttributeAppender.append("class", cssClasses)));- }- }-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);- response.render(JavaScriptHeaderItem.forReference(new BuildSpecResourceReference()));- }-- @Override- protected boolean isEditSupported() {- return true;- }-- @Override- protected boolean isViewPlainSupported() {- return true;- }-- private abstract class ElementsViewer<T extends NamedElement> extends Fragment {-- private final BuildSpec buildSpec;-- private final Class<T> elementClass;-- @SuppressWarnings("unchecked")- public ElementsViewer(BuildSpec buildSpec) {- super("content", "elementsFrag", BuildSpecBlobViewPanel.this);-- this.buildSpec = buildSpec;-- List<Class<?>> typeArguments = ReflectionUtils.getTypeArguments(ElementsViewer.class, getClass());- elementClass = (Class<T>) typeArguments.get(0);- }-- @Override- protected void onInitialize() {- super.onInitialize();-- RepeatingView navsView = new RepeatingView("navs");-- String urlSegment = getUrlSegment(elementClass);- for (int i=0; i<getElements(true).size(); i++) {- int elementIndex = i;- NamedElement element = getElements(true).get(elementIndex);- WebMarkupContainer nav = new WebMarkupContainer(navsView.newChildId());- AjaxLink<Void> elementLink = new AjaxLink<Void>("select") {-- @Override- public void onClick(AjaxRequestTarget target) {- String position = getPosition(urlSegment + "s/" + element.getName());- context.pushState(target, context.getBlobIdent(), position);- setupElementDetail(target, elementIndex);- }-- };-- String label = HtmlEscape.escapeHtml5(element.getName());- if (!getElements(false).contains(element)) {- String iconHtml = String.format(- "<svg class='icon imported'><use xlink:href='%s'/></svg>",- SpriteImage.getVersionedHref(IconScope.class, "arrow2"));- label += iconHtml;- }- elementLink.add(new Label("label", label).setEscapeModelStrings(false));-- nav.add(elementLink);-- navsView.add(nav);- }- add(navsView);-- setupElementDetail(null, getActiveElementIndex(context, elementClass, getElements(true), 0));-- add(AttributeAppender.append("class", "elements d-flex flex-nowrap " + urlSegment + "s"));- }-- private void setupElementDetail(@Nullable AjaxRequestTarget target, int elementIndex) {- Fragment detailFrag = new Fragment("detail", "elementDetailFrag", BuildSpecBlobViewPanel.this) {-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);-- String script = String.format("onedev.server.buildSpec.markElementActive(%d);", elementIndex);- response.render(OnDomReadyHeaderItem.forScript(script));- }-- };-- T element = getElements(true).get(elementIndex);-- detailFrag.add(new ElementImportNoticePanel(buildSpec, elementClass, element.getName()) {-- @Override- protected Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec) {- return ElementsViewer.this.getElementMap(buildSpec);- }-- });-- detailFrag.add(BeanContext.view("content", element));- detailFrag.setOutputMarkupId(true);-- if (target != null) {- replace(detailFrag);- target.add(detailFrag);- } else {- add(detailFrag);- }- }-- protected abstract Map<String, T> getElementMap(BuildSpec buildSpec);-- protected abstract List<T> getElements(boolean includeImported);-- }-- private abstract class ElementImportNoticePanel extends Fragment {-- private final Class<? extends NamedElement> elementClass;-- private final String elementName;-- private Import aImport;-- public ElementImportNoticePanel(BuildSpec buildSpec,- Class<? extends NamedElement> elementClass, String elementName) {- super("notice", "elementImportNoticeFrag", BuildSpecBlobViewPanel.this);-- this.elementClass = elementClass;- this.elementName = elementName;-- NamedElement element = getElementMap(buildSpec).get(elementName);- for (Import aImport: buildSpec.getImports()) {- try {- if (getElementMap(aImport.getBuildSpec()).get(elementName) == element) {- this.aImport = aImport;- break;- }- } catch (Exception e) {- // Ignore. This error will be shown when validating- }- }- }-- @Override- protected void onInitialize() {- super.onInitialize();-- add(new Label("elementTypeName", EditableUtils.getDisplayName(elementClass).toLowerCase()));-- if (aImport != null) {- ProjectBlobPage.State state = new ProjectBlobPage.State();- state.blobIdent = new BlobIdent(aImport.getTag(), BuildSpec.BLOB_PATH,- FileMode.REGULAR_FILE.getBits());- String urlSegment = BuildSpecRenderer.getUrlSegment(elementClass);- state.position = BuildSpecRenderer.getPosition(urlSegment+"s/" + elementName);- Project project = aImport.getProject();- Link<?> link = new ViewStateAwarePageLink<Void>("link", ProjectBlobPage.class,- ProjectBlobPage.paramsOf(project, state)) {-- @Override- protected void onComponentTag(ComponentTag tag) {- super.onComponentTag(tag);- if (!isEnabled())- tag.setName("span");- }-- };- link.setEnabled(SecurityUtils.canReadCode(project));- add(link);- link.add(new Label("label", project.getPath() + ":" + aImport.getTag()));- } else {- WebMarkupContainer link = new WebMarkupContainer("link");- link.add(new WebMarkupContainer("label"));- add(link);- }- }-- protected abstract Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec);-- @Override- protected void onConfigure() {- super.onConfigure();- setVisible(aImport != null);- }-- }-}+package io.onedev.server.web.page.project.blob.render.renderers.buildspec;++import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getActiveElementIndex;+import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getPosition;+import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getSelection;+import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getUrlSegment;++import java.io.Serializable;+import java.util.ArrayList;+import java.util.List;+import java.util.Map;+import java.util.UUID;++import javax.annotation.Nullable;+import javax.validation.ConstraintViolation;+import javax.validation.Validator;++import io.onedev.server.model.support.build.JobProperty;+import org.apache.wicket.Component;+import org.apache.wicket.ajax.AjaxRequestTarget;+import org.apache.wicket.ajax.markup.html.AjaxLink;+import org.apache.wicket.behavior.AttributeAppender;+import org.apache.wicket.behavior.Behavior;+import org.apache.wicket.event.Broadcast;+import org.apache.wicket.feedback.FencedFeedbackPanel;+import org.apache.wicket.markup.ComponentTag;+import org.apache.wicket.markup.head.IHeaderResponse;+import org.apache.wicket.markup.head.JavaScriptHeaderItem;+import org.apache.wicket.markup.head.OnDomReadyHeaderItem;+import org.apache.wicket.markup.html.WebMarkupContainer;+import org.apache.wicket.markup.html.basic.Label;+import org.apache.wicket.markup.html.link.Link;+import org.apache.wicket.markup.html.list.ListItem;+import org.apache.wicket.markup.html.list.ListView;+import org.apache.wicket.markup.html.panel.Fragment;+import org.apache.wicket.markup.repeater.RepeatingView;+import org.eclipse.jgit.lib.FileMode;+import org.unbescape.html.HtmlEscape;++import com.google.common.base.Throwables;++import io.onedev.commons.utils.StringUtils;+import io.onedev.server.OneDev;+import io.onedev.server.buildspec.BuildSpec;+import io.onedev.server.buildspec.Import;+import io.onedev.server.buildspec.NamedElement;+import io.onedev.server.buildspec.Service;+import io.onedev.server.buildspec.job.Job;+import io.onedev.server.buildspec.step.StepTemplate;+import io.onedev.server.git.Blob;+import io.onedev.server.git.BlobIdent;+import io.onedev.server.model.Project;+import io.onedev.server.model.PullRequest;+import io.onedev.server.security.SecurityUtils;+import io.onedev.server.util.ReflectionUtils;+import io.onedev.server.web.asset.icon.IconScope;+import io.onedev.server.web.component.MultilineLabel;+import io.onedev.server.web.component.job.RunJobLink;+import io.onedev.server.web.component.link.ViewStateAwarePageLink;+import io.onedev.server.web.component.pipeline.JobSelectionChange;+import io.onedev.server.web.component.pipeline.PipelinePanel;+import io.onedev.server.web.component.svg.SpriteImage;+import io.onedev.server.web.editable.BeanContext;+import io.onedev.server.web.editable.EditableUtils;+import io.onedev.server.web.editable.PropertyContext;+import io.onedev.server.web.page.base.BasePage;+import io.onedev.server.web.page.project.blob.ProjectBlobPage;+import io.onedev.server.web.page.project.blob.render.BlobRenderContext;+import io.onedev.server.web.page.project.blob.render.view.BlobViewPanel;++@SuppressWarnings("serial")+public class BuildSpecBlobViewPanel extends BlobViewPanel {++ public BuildSpecBlobViewPanel(String id, BlobRenderContext context) {+ super(id, context);+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ Serializable parseResult;+ try {+ Blob blob = context.getProject().getBlob(context.getBlobIdent(), true);+ parseResult = BuildSpec.parse(blob.getBytes());+ } catch (Exception e) {+ parseResult = e;+ }+ if (parseResult != null) {+ if (parseResult instanceof BuildSpec) {+ BuildSpec buildSpec = (BuildSpec) parseResult;++ add(new Fragment("content", "parseableFrag", this) {++ private void resizeWindow(AjaxRequestTarget target) {+ ((BasePage)getPage()).resizeWindow(target);+ }++ private void setupPropertiesViewer(@Nullable AjaxRequestTarget target) {+ Component propertiesViewer;+ List<JobProperty> properties = new ArrayList<>(buildSpec.getPropertyMap().values());++ if (!properties.isEmpty()) {+ propertiesViewer = new Fragment("content", "propertiesFrag", BuildSpecBlobViewPanel.this) {++ @Override+ protected void onInitialize() {+ super.onInitialize();++ add(new ListView<JobProperty>("properties", properties) {++ @Override+ protected void populateItem(ListItem<JobProperty> item) {+ JobProperty property = item.getModelObject();+ item.add(new Label("name", property.getName()));++ Import aImport = null;+ for (Import each: buildSpec.getImports()) {+ try {+ if (each.getBuildSpec().getPropertyMap().get(property.getName()) == property) {+ aImport = each;+ break;+ }+ } catch (Exception e) {+ // Ignore. This error will be shown when validating+ }+ }++ if (aImport != null) {+ ProjectBlobPage.State state = new ProjectBlobPage.State();+ state.blobIdent = new BlobIdent(aImport.getTag(), BuildSpec.BLOB_PATH,+ FileMode.REGULAR_FILE.getBits());+ state.position = BuildSpecRenderer.getPosition("properties");+ Project project = aImport.getProject();+ Link<?> link = new ViewStateAwarePageLink<Void>("imported", ProjectBlobPage.class,+ ProjectBlobPage.paramsOf(project, state)) {++ @Override+ protected void onComponentTag(ComponentTag tag) {+ super.onComponentTag(tag);+ if (!isEnabled())+ tag.setName("span");+ }++ };+ link.add(AttributeAppender.append("title",+ "This property is imported from " + aImport.getProjectPath()));+ link.setEnabled(SecurityUtils.canReadCode(project));+ item.add(link);+ } else {+ item.add(new WebMarkupContainer("imported").setVisible(false));+ }++ item.add(new Label("value", property.getValue()));+ }++ });+ }++ };+ propertiesViewer.add(AttributeAppender.append("class", "properties autofit pr-3"));+ } else {+ propertiesViewer = new Label("content", "No properties defined");+ String cssClasses = "properties not-defined alert alert-notice alert-light-warning d-flex";+ propertiesViewer.add(AttributeAppender.append("class", cssClasses));+ }+ propertiesViewer.add(new Behavior() {++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.properties');"));+ }++ });+ propertiesViewer.setOutputMarkupId(true);+ if (target != null) {+ replace(propertiesViewer);+ target.add(propertiesViewer);+ } else {+ add(propertiesViewer);+ }+ }++ private <T extends NamedElement> List<T> getAllElements(List<T> elements, Map<String, T> elementMap) {+ List<T> allElements = new ArrayList<>(elements);+ for (T element: elementMap.values()) {+ if (!elements.contains(element))+ allElements.add(element);+ }+ return allElements;+ }++ private void setupJobsViewer(@Nullable AjaxRequestTarget target) {+ Component jobsViewer;+ List<Job> jobs = getAllElements(buildSpec.getJobs(), buildSpec.getJobMap());+ if (!jobs.isEmpty()) {+ jobsViewer = new Fragment("content", "jobsFrag", BuildSpecBlobViewPanel.this) {++ private void notifyJobSelectionChange(AjaxRequestTarget target, Job job) {+ send(this, Broadcast.BREADTH, new JobSelectionChange(target, job));+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ int activeJobIndex = getActiveElementIndex(context, Job.class, jobs, 0);++ add(new PipelinePanel("pipeline") {++ @Override+ protected Component renderJob(String componentId, int jobIndex) {+ Fragment jobNav = new Fragment(componentId, "jobFrag", BuildSpecBlobViewPanel.this);++ AjaxLink<Void> jobLink = new AjaxLink<Void>("select") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ Job job = getJobs().get(jobIndex);+ String position = getPosition("jobs/" + job.getName());+ context.pushState(target, context.getBlobIdent(), position);+ setupJobDetail(target, jobIndex);+ notifyJobSelectionChange(target, job);+ resizeWindow(target);+ }++ };++ Job job = getJobs().get(jobIndex);+ String label = HtmlEscape.escapeHtml5(job.getName());+ if (!buildSpec.getJobs().contains(job)) {+ String iconHtml = String.format(+ "<svg class='icon imported'><use xlink:href='%s'/></svg>",+ SpriteImage.getVersionedHref(IconScope.class, "arrow2"));+ label += iconHtml;+ }+ jobLink.add(new Label("label", label).setEscapeModelStrings(false));++ jobNav.add(jobLink);++ jobNav.add(new RunJobLink("run", context.getCommit().copy(), job.getName(), getContext().getRefName()) {++ @Override+ protected Project getProject() {+ return context.getProject();+ }++ @Override+ protected PullRequest getPullRequest() {+ return null;+ }++ @Override+ protected String getPipeline() {+ return UUID.randomUUID().toString();+ }++ });+ jobNav.add(AttributeAppender.append("class", "nav btn-group flex-nowrap"));+ return jobNav;+ }++ @Override+ protected List<Job> getJobs() {+ return jobs;+ }++ @Override+ protected int getActiveJobIndex() {+ return activeJobIndex;+ }++ });++ setupJobDetail(null, activeJobIndex);++ add(AttributeAppender.append("class", "elements jobs d-flex flex-nowrap"));+ }++ private void setupJobDetail(@Nullable AjaxRequestTarget target, int jobIndex) {+ Job job = jobs.get(jobIndex);+ Fragment detailFrag = new Fragment("detail", "elementDetailFrag", BuildSpecBlobViewPanel.this);+ detailFrag.add(new ElementImportNoticePanel(buildSpec, Job.class, job.getName()) {++ @Override+ protected Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec) {+ return buildSpec.getJobMap();+ }++ });+ detailFrag.add(BeanContext.view("content", job));+ detailFrag.setOutputMarkupId(true);++ if (target != null) {+ replace(detailFrag);+ target.add(detailFrag);+ } else {+ add(detailFrag);+ }+ }++ };+ } else {+ String cssClasses = "jobs not-defined alert alert-notice alert-light-warning d-flex";+ jobsViewer = new Label("content", "No jobs defined").add(AttributeAppender.append("class", cssClasses));+ }+ jobsViewer.add(new Behavior() {++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.jobs');"));+ }++ });+ jobsViewer.setOutputMarkupId(true);+ if (target != null) {+ replace(jobsViewer);+ target.add(jobsViewer);+ } else {+ add(jobsViewer);+ }+ }++ private void setupServicesViewer(@Nullable AjaxRequestTarget target) {+ Component servicesViewer;+ List<Service> services = getAllElements(buildSpec.getServices(), buildSpec.getServiceMap());+ if (!services.isEmpty()) {+ servicesViewer = new ElementsViewer<Service>(buildSpec) {++ @Override+ protected List<Service> getElements(boolean includeImported) {+ if (includeImported)+ return services;+ else+ return buildSpec.getServices();+ }++ @Override+ protected Map<String, Service> getElementMap(BuildSpec buildSpec) {+ return buildSpec.getServiceMap();+ }++ };+ } else {+ String cssClasses = "services not-defined alert alert-notice alert-light-warning d-flex";+ servicesViewer = new Label("content", "No services defined").add(AttributeAppender.append("class", cssClasses));+ }+ servicesViewer.add(new Behavior() {++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.services');"));+ }++ });+ servicesViewer.setOutputMarkupId(true);+ if (target != null) {+ replace(servicesViewer);+ target.add(servicesViewer);+ } else {+ add(servicesViewer);+ }+ }++ private void setupStepTemplatesViewer(@Nullable AjaxRequestTarget target) {+ Component templatesViewer;+ List<StepTemplate> templates = getAllElements(buildSpec.getStepTemplates(), buildSpec.getStepTemplateMap());+ if (!templates.isEmpty()) {+ templatesViewer = new ElementsViewer<StepTemplate>(buildSpec) {++ @Override+ protected List<StepTemplate> getElements(boolean includeImported) {+ if (includeImported)+ return templates;+ else+ return buildSpec.getStepTemplates();+ }++ @Override+ protected Map<String, StepTemplate> getElementMap(BuildSpec buildSpec) {+ return buildSpec.getStepTemplateMap();+ }++ };+ } else {+ String cssClasses = "step-templates not-defined alert alert-notice alert-light-warning d-flex";+ templatesViewer = new Label("content", "No step templates defined").add(AttributeAppender.append("class", cssClasses));+ }+ templatesViewer.add(new Behavior() {++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.step-templates');"));+ }++ });+ templatesViewer.setOutputMarkupId(true);+ if (target != null) {+ replace(templatesViewer);+ target.add(templatesViewer);+ } else {+ add(templatesViewer);+ }+ }++ private void setupImportsViewer(@Nullable AjaxRequestTarget target) {+ Component importsViewer;+ if (!buildSpec.getImports().isEmpty()) {+ importsViewer = PropertyContext.view("content", buildSpec, "imports");+ importsViewer.add(AttributeAppender.append("class", "imports autofit pr-3"));+ } else {+ importsViewer = new Label("content", "No imports defined");+ String cssClasses = "imports not-defined alert alert-notice alert-light-warning d-flex";+ importsViewer.add(AttributeAppender.append("class", cssClasses));+ }+ importsViewer.add(new Behavior() {++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.imports');"));+ }++ });+ importsViewer.setOutputMarkupId(true);+ if (target != null) {+ replace(importsViewer);+ target.add(importsViewer);+ } else {+ add(importsViewer);+ }+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ Validator validator = OneDev.getInstance(Validator.class);+ for (ConstraintViolation<BuildSpec> violation: validator.validate(buildSpec)) {+ if (StringUtils.isNotBlank(violation.getPropertyPath().toString())) {+ error(String.format("Error validating build spec (location: %s, error message: %s)",+ violation.getPropertyPath(), violation.getMessage()));+ } else {+ error(String.format("Error validating build spec: %s", violation.getMessage()));+ }+ }++ add(new FencedFeedbackPanel("feedback", this));++ add(new AjaxLink<Void>("jobs") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition("jobs");+ context.pushState(target, context.getBlobIdent(), position);+ setupJobsViewer(target);+ resizeWindow(target);+ }++ });+ add(new AjaxLink<Void>("services") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition("services");+ context.pushState(target, context.getBlobIdent(), position);+ setupServicesViewer(target);+ resizeWindow(target);+ }++ });+ add(new AjaxLink<Void>("stepTemplates") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition("step-templates");+ context.pushState(target, context.getBlobIdent(), position);+ setupStepTemplatesViewer(target);+ resizeWindow(target);+ }++ });+ add(new AjaxLink<Void>("properties") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition("properties");+ context.pushState(target, context.getBlobIdent(), position);+ setupPropertiesViewer(target);+ resizeWindow(target);+ }++ });+ add(new AjaxLink<Void>("imports") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition("imports");+ context.pushState(target, context.getBlobIdent(), position);+ setupImportsViewer(target);+ resizeWindow(target);+ }++ });++ String selection = getSelection(context.getPosition());+ if (selection == null || selection.startsWith("jobs"))+ setupJobsViewer(null);+ else if (selection.startsWith("services"))+ setupServicesViewer(null);+ else if (selection.startsWith("step-templates"))+ setupStepTemplatesViewer(null);+ else if (selection.equals("imports"))+ setupImportsViewer(null);+ else+ setupPropertiesViewer(null);++ add(AttributeAppender.append("class", "parseable"));+ }++ }.setOutputMarkupId(true));+ } else {+ Fragment unparseableFrag = new Fragment("content", "unparseableFrag", this);+ unparseableFrag.add(AttributeAppender.append("class", "unparseable"));+ unparseableFrag.add(new MultilineLabel("errorMessage",+ Throwables.getStackTraceAsString((Throwable) parseResult)));+ add(unparseableFrag);+ }+ } else {+ String cssClasses = "not-defined m-4 alert alert-notice alert-light-warning";+ add(new Label("content", "Build spec not defined").add(AttributeAppender.append("class", cssClasses)));+ }+ }++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);+ response.render(JavaScriptHeaderItem.forReference(new BuildSpecResourceReference()));+ }++ @Override+ protected boolean isEditSupported() {+ return true;+ }++ @Override+ protected boolean isViewPlainSupported() {+ return true;+ }++ private abstract class ElementsViewer<T extends NamedElement> extends Fragment {++ private final BuildSpec buildSpec;++ private final Class<T> elementClass;++ @SuppressWarnings("unchecked")+ public ElementsViewer(BuildSpec buildSpec) {+ super("content", "elementsFrag", BuildSpecBlobViewPanel.this);++ this.buildSpec = buildSpec;++ List<Class<?>> typeArguments = ReflectionUtils.getTypeArguments(ElementsViewer.class, getClass());+ elementClass = (Class<T>) typeArguments.get(0);+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ RepeatingView navsView = new RepeatingView("navs");++ String urlSegment = getUrlSegment(elementClass);+ for (int i=0; i<getElements(true).size(); i++) {+ int elementIndex = i;+ NamedElement element = getElements(true).get(elementIndex);+ WebMarkupContainer nav = new WebMarkupContainer(navsView.newChildId());+ AjaxLink<Void> elementLink = new AjaxLink<Void>("select") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ String position = getPosition(urlSegment + "s/" + element.getName());+ context.pushState(target, context.getBlobIdent(), position);+ setupElementDetail(target, elementIndex);+ }++ };++ String label = HtmlEscape.escapeHtml5(element.getName());+ if (!getElements(false).contains(element)) {+ String iconHtml = String.format(+ "<svg class='icon imported'><use xlink:href='%s'/></svg>",+ SpriteImage.getVersionedHref(IconScope.class, "arrow2"));+ label += iconHtml;+ }+ elementLink.add(new Label("label", label).setEscapeModelStrings(false));++ nav.add(elementLink);++ navsView.add(nav);+ }+ add(navsView);++ setupElementDetail(null, getActiveElementIndex(context, elementClass, getElements(true), 0));++ add(AttributeAppender.append("class", "elements d-flex flex-nowrap " + urlSegment + "s"));+ }++ private void setupElementDetail(@Nullable AjaxRequestTarget target, int elementIndex) {+ Fragment detailFrag = new Fragment("detail", "elementDetailFrag", BuildSpecBlobViewPanel.this) {++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);++ String script = String.format("onedev.server.buildSpec.markElementActive(%d);", elementIndex);+ response.render(OnDomReadyHeaderItem.forScript(script));+ }++ };++ T element = getElements(true).get(elementIndex);++ detailFrag.add(new ElementImportNoticePanel(buildSpec, elementClass, element.getName()) {++ @Override+ protected Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec) {+ return ElementsViewer.this.getElementMap(buildSpec);+ }++ });++ detailFrag.add(BeanContext.view("content", element));+ detailFrag.setOutputMarkupId(true);++ if (target != null) {+ replace(detailFrag);+ target.add(detailFrag);+ } else {+ add(detailFrag);+ }+ }++ protected abstract Map<String, T> getElementMap(BuildSpec buildSpec);++ protected abstract List<T> getElements(boolean includeImported);++ }++ private abstract class ElementImportNoticePanel extends Fragment {++ private final Class<? extends NamedElement> elementClass;++ private final String elementName;++ private Import aImport;++ public ElementImportNoticePanel(BuildSpec buildSpec,+ Class<? extends NamedElement> elementClass, String elementName) {+ super("notice", "elementImportNoticeFrag", BuildSpecBlobViewPanel.this);++ this.elementClass = elementClass;+ this.elementName = elementName;++ NamedElement element = getElementMap(buildSpec).get(elementName);+ for (Import aImport: buildSpec.getImports()) {+ try {+ if (getElementMap(aImport.getBuildSpec()).get(elementName) == element) {+ this.aImport = aImport;+ break;+ }+ } catch (Exception e) {+ // Ignore. This error will be shown when validating+ }+ }+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ add(new Label("elementTypeName", EditableUtils.getDisplayName(elementClass).toLowerCase()));++ if (aImport != null) {+ ProjectBlobPage.State state = new ProjectBlobPage.State();+ state.blobIdent = new BlobIdent(aImport.getTag(), BuildSpec.BLOB_PATH,+ FileMode.REGULAR_FILE.getBits());+ String urlSegment = BuildSpecRenderer.getUrlSegment(elementClass);+ state.position = BuildSpecRenderer.getPosition(urlSegment+"s/" + elementName);+ Project project = aImport.getProject();+ Link<?> link = new ViewStateAwarePageLink<Void>("link", ProjectBlobPage.class,+ ProjectBlobPage.paramsOf(project, state)) {++ @Override+ protected void onComponentTag(ComponentTag tag) {+ super.onComponentTag(tag);+ if (!isEnabled())+ tag.setName("span");+ }++ };+ link.setEnabled(SecurityUtils.canReadCode(project));+ add(link);+ link.add(new Label("label", project.getPath() + ":" + aImport.getTag()));+ } else {+ WebMarkupContainer link = new WebMarkupContainer("link");+ link.add(new WebMarkupContainer("label"));+ add(link);+ }+ }++ protected abstract Map<String, ? extends NamedElement> getElementMap(BuildSpec buildSpec);++ @Override+ protected void onConfigure() {+ super.onConfigure();+ setVisible(aImport != null);+ }++ }+}diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.javaindex 4172b73f54..8487f59656 100644--- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java+++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/renderers/buildspec/BuildSpecEditPanel.java@@ -1,1125 +1,1125 @@-package io.onedev.server.web.page.project.blob.render.renderers.buildspec;--import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getActiveElementIndex;-import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getUrlSegment;--import java.io.Serializable;-import java.lang.reflect.InvocationTargetException;-import java.nio.charset.StandardCharsets;-import java.util.ArrayList;-import java.util.Collection;-import java.util.Collections;-import java.util.List;--import javax.annotation.Nullable;-import javax.validation.ConstraintViolation;-import javax.validation.Validator;--import org.apache.commons.lang3.StringUtils;-import org.apache.wicket.Component;-import org.apache.wicket.ajax.AjaxRequestTarget;-import org.apache.wicket.ajax.markup.html.AjaxLink;-import org.apache.wicket.ajax.markup.html.form.AjaxSubmitLink;-import org.apache.wicket.behavior.AttributeAppender;-import org.apache.wicket.behavior.Behavior;-import org.apache.wicket.event.Broadcast;-import org.apache.wicket.event.IEvent;-import org.apache.wicket.feedback.FencedFeedbackPanel;-import org.apache.wicket.markup.head.IHeaderResponse;-import org.apache.wicket.markup.head.JavaScriptHeaderItem;-import org.apache.wicket.markup.head.OnDomReadyHeaderItem;-import org.apache.wicket.markup.html.WebMarkupContainer;-import org.apache.wicket.markup.html.basic.Label;-import org.apache.wicket.markup.html.form.Form;-import org.apache.wicket.markup.html.form.FormComponentPanel;-import org.apache.wicket.markup.html.list.ListItem;-import org.apache.wicket.markup.html.list.ListView;-import org.apache.wicket.markup.html.panel.Fragment;-import org.apache.wicket.model.AbstractReadOnlyModel;-import org.apache.wicket.model.LoadableDetachableModel;-import org.apache.wicket.model.Model;-import org.apache.wicket.request.cycle.RequestCycle;-import org.unbescape.html.HtmlEscape;--import com.google.common.base.Throwables;--import io.onedev.commons.loader.AppLoader;-import io.onedev.server.OneDev;-import io.onedev.server.buildspec.BuildSpec;-import io.onedev.server.buildspec.BuildSpecAware;-import io.onedev.server.buildspec.Import;-import io.onedev.server.buildspec.NamedElement;-import io.onedev.server.buildspec.ParamSpecAware;-import io.onedev.server.buildspec.Property;-import io.onedev.server.buildspec.Service;-import io.onedev.server.buildspec.job.Job;-import io.onedev.server.buildspec.job.JobAware;-import io.onedev.server.buildspec.job.JobSuggestion;-import io.onedev.server.buildspec.param.spec.ParamSpec;-import io.onedev.server.buildspec.step.StepTemplate;-import io.onedev.server.migration.VersionedYamlDoc;-import io.onedev.server.util.Path;-import io.onedev.server.util.PathNode;-import io.onedev.server.util.PathNode.Indexed;-import io.onedev.server.util.PathNode.Named;-import io.onedev.server.util.ReflectionUtils;-import io.onedev.server.web.behavior.sortable.SortBehavior;-import io.onedev.server.web.behavior.sortable.SortPosition;-import io.onedev.server.web.component.MultilineLabel;-import io.onedev.server.web.component.floating.FloatingPanel;-import io.onedev.server.web.component.menu.MenuItem;-import io.onedev.server.web.component.menu.MenuLink;-import io.onedev.server.web.component.pipeline.JobSelectionChange;-import io.onedev.server.web.component.pipeline.PipelinePanel;-import io.onedev.server.web.component.pipeline.Sortable;-import io.onedev.server.web.editable.BeanDescriptor;-import io.onedev.server.web.editable.BeanEditor;-import io.onedev.server.web.editable.BeanUpdating;-import io.onedev.server.web.editable.PropertyContext;-import io.onedev.server.web.editable.PropertyEditor;-import io.onedev.server.web.editable.PropertyUpdating;-import io.onedev.server.web.page.base.BasePage;-import io.onedev.server.web.page.project.blob.render.BlobRenderContext;-import io.onedev.server.web.page.project.blob.render.edit.EditCompleteAware;-import io.onedev.server.web.util.AjaxPayload;--@SuppressWarnings("serial")-public class BuildSpecEditPanel extends FormComponentPanel<byte[]> implements BuildSpecAware, EditCompleteAware {-- private final BlobRenderContext context;-- private Serializable parseResult;-- public BuildSpecEditPanel(String id, BlobRenderContext context, byte[] initialContent) {- super(id, Model.of(initialContent));- this.context = context;- try {- parseResult = BuildSpec.parse(initialContent);- if (parseResult == null)- parseResult = new BuildSpec();- } catch (Exception e) {- parseResult = e;- }- }-- private void resizeWindow(AjaxRequestTarget target) {- ((BasePage)getPage()).resizeWindow(target);- }-- @Override- protected void onInitialize() {- super.onInitialize();-- if (parseResult instanceof BuildSpec) {- BuildSpec buildSpec = (BuildSpec) parseResult;- add(new ParseableFragment("content") {-- private WebMarkupContainer body;-- private void setupJobsEditor(@Nullable AjaxRequestTarget target) {- Fragment jobsEditor = new Fragment("content", "jobsFrag", BuildSpecEditPanel.this) {-- private void notifyJobSelectionChange(AjaxRequestTarget target, Job job) {- send(this, Broadcast.BREADTH, new JobSelectionChange(target, job));- }-- private void setupJobDetail(@Nullable AjaxRequestTarget target, int jobIndex) {- Fragment jobsEditor = this;-- WebMarkupContainer jobDetail;- if (jobIndex != -1) {- jobDetail = new Fragment("detail", "elementDetailFrag", BuildSpecEditPanel.this);-- class JobEditor extends BeanEditor implements JobAware {-- public JobEditor(String id, Job job) {- super(id, new BeanDescriptor(Job.class), Model.of(job));- }-- @Override- public Job getJob() {- return (Job) getConvertedInput();- }-- @Override- public List<ParamSpec> getParamSpecs() {- return ((Job) getConvertedInput()).getParamSpecs();- }-- }-- BeanEditor jobEditor = new JobEditor("body", buildSpec.getJobs().get(jobIndex)) {-- @Override- public void onEvent(IEvent<?> event) {- super.onEvent(event);- if (event.getPayload() instanceof BeanUpdating) {- PropertyUpdating propertyUpdating = ((BeanUpdating) event.getPayload()).getSource();- if (propertyUpdating.getPropertyName().equals(Job.PROP_NAME)- || propertyUpdating.getPropertyName().equals(Job.PROP_JOB_DEPENDENCIES)) {- Job job = (Job) getConvertedInput();- String selection = "jobs";- if (StringUtils.isNotBlank(job.getName()))- selection += "/" + job.getName();- int jobIndex = (int) jobDetail.getDefaultModelObject();- buildSpec.getJobs().set(jobIndex, job);-- AjaxRequestTarget target = (AjaxRequestTarget) propertyUpdating.getHandler();- replaceState(target, selection);- target.add(jobsEditor.get("pipeline"));- resizeWindow(target);- }- } else if (event.getPayload() instanceof FormSubmitted) {- int jobIndex = (int) jobDetail.getDefaultModelObject();- buildSpec.getJobs().set(jobIndex, (Job) getConvertedInput());- }- }-- };-- jobDetail.add(jobEditor);- } else {- jobDetail = new WebMarkupContainer("detail");- jobDetail.setVisible(false);- }- jobDetail.setDefaultModel(Model.of(jobIndex));- jobDetail.setOutputMarkupPlaceholderTag(true);-- if (target != null) {- replace(jobDetail);- target.add(jobDetail);- } else {- add(jobDetail);- }- }-- @Override- protected void onInitialize() {- super.onInitialize();-- Fragment jobsEditor = this;-- add(new PipelinePanel("pipeline") {-- private void addJob(AjaxRequestTarget target, Job job) {- getJobs().add(job);- pushState(target, "new-job");- int jobIndex = getJobs().size()-1;- setupJobDetail(target, jobIndex);- target.add(jobsEditor);- resizeWindow(target);- }-- @Override- protected Component renderJob(String componentId, int jobIndex) {- WebMarkupContainer jobNav = new Fragment(componentId, "jobFrag", BuildSpecEditPanel.this);-- jobNav.add(new AjaxSubmitLink("select") {-- @Override- protected void onInitialize() {- super.onInitialize();- add(new Label("label", new LoadableDetachableModel<String>() {-- @Override- protected String load() {- Job job = getJobs().get(jobIndex);- if (job.getName() != null)- return HtmlEscape.escapeHtml5(job.getName());- else- return "<i>No Name</i>";- }-- }).setEscapeModelStrings(false));- }-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- Job job = getJobs().get(jobIndex);- pushState(target, "jobs/" + job.getName());- setupJobDetail(target, buildSpec.getJobs().indexOf(job));-- notifyJobSelectionChange(target, job);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(jobsEditor);- resizeWindow(target);- }-- });-- jobNav.add(new AjaxLink<Void>("delete") {-- @Override- public void onClick(AjaxRequestTarget target) {- getJobs().remove(jobIndex);-- Component jobDetail = jobsEditor.get("detail");-- int activeJobIndex = (int) jobDetail.getDefaultModelObject();- if (jobIndex == activeJobIndex) {- if (getJobs().isEmpty()) {- replaceState(target, "jobs");- setupJobDetail(target, -1);- } else {- replaceState(target, "jobs/" + getJobs().get(0).getName());- setupJobDetail(target, 0);- }- } else if (jobIndex < activeJobIndex) {- jobDetail.setDefaultModelObject(activeJobIndex-1);- }- target.appendJavaScript("onedev.server.form.markDirty($('.build-spec').closest('form'));");- target.add(jobsEditor.get("pipeline"));- resizeWindow(target);- }-- });-- jobNav.add(AttributeAppender.append("class", "nav btn-group flex-nowrap"));-- return jobNav;- }-- @Override- protected Component renderAction(String componentId) {- Fragment fragment = new Fragment(componentId, "addJobFrag", BuildSpecEditPanel.this);-- AjaxSubmitLink createLink = new AjaxSubmitLink("create") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- addJob(target, new Job());- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(jobsEditor);- resizeWindow(target);- }-- };-- fragment.add(createLink);-- List<Job> suggestedJobs = new ArrayList<>();-- if (context.getBlobIdent().revision != null) {- for (JobSuggestion suggestion: OneDev.getExtensions(JobSuggestion.class))- suggestedJobs.addAll(suggestion.suggestJobs(context.getProject(), context.getCommit()));- }-- if (!suggestedJobs.isEmpty()) {- fragment.add(new MenuLink("suggestions") {-- @Override- protected List<MenuItem> getMenuItems(FloatingPanel dropdown) {- List<MenuItem> menuItems = new ArrayList<>();- for (Job job: suggestedJobs) {- menuItems.add(new MenuItem() {-- @Override- public String getLabel() {- return job.getName();- }-- @Override- public WebMarkupContainer newLink(String id) {- return new AjaxSubmitLink(id, createLink.findParent(Form.class)) {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- addJob(target, job);- dropdown.close();- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(jobsEditor.get("pipeline"));- resizeWindow(target);- }-- };- }-- });- }- return menuItems;- }-- });- } else {- fragment.add(new WebMarkupContainer("suggestions").setVisible(false));- }-- fragment.add(AttributeAppender.append("class", "add-job nav btn-group flex-nowrap"));- return fragment;- }-- @Override- protected List<Job> getJobs() {- return buildSpec.getJobs();- }-- @Override- protected int getActiveJobIndex() {- return (int) jobsEditor.get("detail").getDefaultModelObject();- }-- @Override- protected Sortable getSortable() {- return new Sortable() {-- @Override- public void onSort(AjaxRequestTarget target, int fromIndex, int toIndex) {- if (fromIndex < toIndex) {- for (int i=0; i<toIndex-fromIndex; i++)- Collections.swap(getJobs(), fromIndex+i, fromIndex+i+1);- } else {- for (int i=0; i<fromIndex-toIndex; i++)- Collections.swap(getJobs(), fromIndex-i, fromIndex-i-1);- }-- Component jobDetail = jobsEditor.get("detail");-- int activeIndex = (int) jobDetail.getDefaultModelObject();-- if (fromIndex < activeIndex) {- if (toIndex >= activeIndex)- jobDetail.setDefaultModelObject(activeIndex-1);- } else if (fromIndex == activeIndex) {- jobDetail.setDefaultModelObject(toIndex);- } else {- if (toIndex <= activeIndex)- jobDetail.setDefaultModelObject(activeIndex+1);- }-- target.add(jobsEditor.get("pipeline"));- resizeWindow(target);- }-- };- }-- }.setOutputMarkupId(true));-- if (!buildSpec.getJobs().isEmpty())- setupJobDetail(null, getActiveElementIndex(context, Job.class, buildSpec.getJobs(), 0));- else- setupJobDetail(null, -1);-- add(AttributeAppender.append("class", "elements d-flex flex-nowrap jobs"));-- setOutputMarkupId(true);- }-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);- response.render(OnDomReadyHeaderItem.forScript(- String.format("onedev.server.buildSpec.onTabDomReady('.jobs');")));- }-- };-- if (target != null) {- body.replace(jobsEditor);- target.add(jobsEditor);- } else {- body.add(jobsEditor);- }- }-- private void setupStepTemplatesEditor(@Nullable AjaxRequestTarget target) {- Fragment stepTemplatesEditor = new ElementsEditor<StepTemplate>() {-- @Override- protected List<StepTemplate> getElements() {- return buildSpec.getStepTemplates();- }-- @Override- protected BeanEditor newElementEditor(String componentId, StepTemplate element) {-- class StepTemplateEditor extends BeanEditor implements ParamSpecAware {-- public StepTemplateEditor(String id, NamedElement element) {- super(id, new BeanDescriptor(StepTemplate.class), Model.of(element));- }-- @Override- public List<ParamSpec> getParamSpecs() {- return ((StepTemplate) getConvertedInput()).getParamSpecs();- }-- }-- return new StepTemplateEditor(componentId, element);- }-- };-- if (target != null) {- body.replace(stepTemplatesEditor);- target.add(stepTemplatesEditor);- } else {- body.add(stepTemplatesEditor);- }- }-- private void setupServicesEditor(@Nullable AjaxRequestTarget target) {- Fragment servicesEditor = new ElementsEditor<Service>() {-- @Override- protected List<Service> getElements() {- return buildSpec.getServices();- }-- @Override- protected BeanEditor newElementEditor(String componentId, Service element) {- return new BeanEditor(componentId, new BeanDescriptor(Service.class), Model.of(element));- }-- };-- if (target != null) {- body.replace(servicesEditor);- target.add(servicesEditor);- } else {- body.add(servicesEditor);- }- }-- private void setupPropertiesEditor(@Nullable AjaxRequestTarget target) {- PropertyEditor<Serializable> propertiesEditor = PropertyContext.edit("content", buildSpec, "properties");- propertiesEditor.add(new Behavior() {-- @SuppressWarnings("unchecked")- @Override- public void onEvent(Component component, IEvent<?> event) {- super.onEvent(component, event);- if (event.getPayload() instanceof FormSubmitted)- buildSpec.setProperties((List<Property>) propertiesEditor.getConvertedInput());- }-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.properties');"));- }-- });- propertiesEditor.add(AttributeAppender.append("class", "properties pr-3"));- propertiesEditor.setOutputMarkupId(true);- if (target != null) {- body.replace(propertiesEditor);- target.add(propertiesEditor);- } else {- body.add(propertiesEditor);- }- }-- private void setupImportsEditor(@Nullable AjaxRequestTarget target) {- PropertyEditor<Serializable> importsEditor = PropertyContext.edit("content", buildSpec, "imports");- importsEditor.add(new Behavior() {-- @SuppressWarnings("unchecked")- @Override- public void onEvent(Component component, IEvent<?> event) {- super.onEvent(component, event);- if (event.getPayload() instanceof FormSubmitted)- buildSpec.setImports((List<Import>) importsEditor.getConvertedInput());- }-- @Override- public void renderHead(Component component, IHeaderResponse response) {- super.renderHead(component, response);- response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.imports');"));- }-- });- importsEditor.add(AttributeAppender.append("class", "imports pr-3"));- importsEditor.setOutputMarkupId(true);- if (target != null) {- body.replace(importsEditor);- target.add(importsEditor);- } else {- body.add(importsEditor);- }- }-- @Override- protected void onInitialize() {- super.onInitialize();-- add(new AjaxSubmitLink("jobs") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, "jobs");- setupJobsEditor(target);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(getParent());- resizeWindow(target);- }-- });-- add(new AjaxSubmitLink("services") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, "services");- setupServicesEditor(target);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(getParent());- resizeWindow(target);- }-- });-- add(new AjaxSubmitLink("stepTemplates") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, "step-templates");- setupStepTemplatesEditor(target);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(getParent());- resizeWindow(target);- }-- });-- add(new AjaxSubmitLink("properties") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, "properties");- setupPropertiesEditor(target);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(getParent());- resizeWindow(target);- }-- });-- add(new AjaxSubmitLink("imports") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, "imports");- setupImportsEditor(target);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(getParent());- resizeWindow(target);- }-- });-- add(body = new WebMarkupContainer("body"));- body.add(new FencedFeedbackPanel("feedback", body));-- String selection = getSelection();-- if (selection == null || selection.startsWith("jobs") || selection.equals("new-job"))- setupJobsEditor(null);- else if (selection.startsWith("services") || selection.equals("new-service"))- setupServicesEditor(null);- else if (selection.startsWith("step-templates") || selection.equals("new-step-template"))- setupStepTemplatesEditor(null);- else if (selection.equals("imports"))- setupImportsEditor(null);- else- setupPropertiesEditor(null);-- add(AttributeAppender.append("class", "parseable"));- setOutputMarkupId(true);- }-- @SuppressWarnings("rawtypes")- @Override- public boolean onEditComplete(AjaxRequestTarget target) {- BuildSpec buildSpec = (BuildSpec) parseResult;- Validator validator = AppLoader.getInstance(Validator.class);- Collection<ConstraintViolation<BuildSpec>> violations = validator.validate(buildSpec);- if (!violations.isEmpty()) {- ConstraintViolation<BuildSpec> violation = violations.iterator().next();- Path path = new Path(violation.getPropertyPath());- if (path.getNodes().isEmpty()) {- error(violation.getMessage());- } else {- PathNode.Named named = (Named) path.getNodes().iterator().next();- switch (named.getName()) {- case "jobs":- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- if (path.getNodes().isEmpty()) {- replaceState(target, named.getName());- setupJobsEditor(target);- body.error(violation.getMessage());- } else {- PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- String selection = "jobs/" + buildSpec.getJobs().get(indexed.getIndex()).getName();- replaceState(target, selection);- setupJobsEditor(target);- ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());- }- break;- case "services":- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- if (path.getNodes().isEmpty()) {- replaceState(target, named.getName());- setupServicesEditor(target);- body.error(violation.getMessage());- } else {- PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- String selection = "services/" + buildSpec.getServices().get(indexed.getIndex()).getName();- replaceState(target, selection);- setupServicesEditor(target);- ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());- }- break;- case "stepTemplates":- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- if (path.getNodes().isEmpty()) {- replaceState(target, named.getName());- setupStepTemplatesEditor(target);- body.error(violation.getMessage());- } else {- PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- String selection = "step-templates/" + buildSpec.getStepTemplates().get(indexed.getIndex()).getName();- replaceState(target, selection);- setupStepTemplatesEditor(target);- ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());- }- break;- case "properties":- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- replaceState(target, "properties");- setupPropertiesEditor(target);- ((PropertyEditor)body.get("content")).error(path, violation.getMessage());- break;- case "imports":- path = new Path(path.getNodes().subList(1, path.getNodes().size()));- replaceState(target, "imports");- setupImportsEditor(target);- ((PropertyEditor)body.get("content")).error(path, violation.getMessage());- break;- default:- throw new RuntimeException("Unexpected element name: " + named.getName());- }- }- return false;- } else {- fixState(target);- return true;- }- }-- @Override- public void onEditCancel(AjaxRequestTarget target) {- fixState(target);- }-- private void fixState(AjaxRequestTarget target) {- String selection = getSelection();- if (selection == null || selection.startsWith("jobs")) {- int jobIndex = getActiveElementIndex(context, Job.class, buildSpec.getJobs(), 0);- if (jobIndex < buildSpec.getJobs().size())- replaceState(target, "jobs/" + buildSpec.getJobs().get(jobIndex).getName());- } else if (selection.startsWith("services")) {- int serviceIndex = getActiveElementIndex(context, Service.class, buildSpec.getServices(), 0);- if (serviceIndex < buildSpec.getServices().size())- replaceState(target, "services/" + buildSpec.getServices().get(serviceIndex).getName());- } else if (selection.startsWith("step-templates")) {- int stepTemplateIndex = getActiveElementIndex(context, StepTemplate.class, buildSpec.getStepTemplates(), 0);- if (stepTemplateIndex < buildSpec.getStepTemplates().size())- replaceState(target, "step-templates/" + buildSpec.getStepTemplates().get(stepTemplateIndex).getName());- } else if (selection.equals("new-job")) {- replaceState(target, "jobs");- } else if (selection.equals("new-service")) {- replaceState(target, "services");- } else if (selection.equals("new-step-template")) {- replaceState(target, "step-templates");- }- }-- });- } else {- Fragment unparseableFrag = new Fragment("content", "unparseableFrag", this);- unparseableFrag.add(new MultilineLabel("errorMessage",- Throwables.getStackTraceAsString((Throwable) parseResult)));- unparseableFrag.add(AttributeAppender.append("class", "unparseable"));- add(unparseableFrag);- }-- }-- @Override- public void convertInput() {- if (parseResult instanceof BuildSpec) {- AjaxRequestTarget target = RequestCycle.get().find(AjaxRequestTarget.class);- send(this, Broadcast.BREADTH, new FormSubmitted(target));- setConvertedInput(VersionedYamlDoc.fromBean(parseResult).toYaml().getBytes(StandardCharsets.UTF_8));- } else {- setConvertedInput(getModelObject());- }- }-- private void pushState(AjaxRequestTarget target, String selection) {- String position = BuildSpecRenderer.getPosition(selection);- context.pushState(target, context.getBlobIdent(), position);- }-- private void replaceState(AjaxRequestTarget target, String selection) {- String position = BuildSpecRenderer.getPosition(selection);- context.replaceState(target, context.getBlobIdent(), position);- }-- @Nullable- private String getSelection() {- return BuildSpecRenderer.getSelection(context.getPosition());- }-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);- response.render(JavaScriptHeaderItem.forReference(new BuildSpecResourceReference()));- }-- @Override- public BuildSpec getBuildSpec() {- if (parseResult instanceof BuildSpec)- return (BuildSpec) parseResult;- else- return null;- }-- private static class FormSubmitted extends AjaxPayload {-- public FormSubmitted(AjaxRequestTarget target) {- super(target);- }-- }-- @Override- public boolean onEditComplete(AjaxRequestTarget target) {- Component content = get("content");- if (content instanceof EditCompleteAware)- return ((EditCompleteAware) content).onEditComplete(target);- else- return true;- }-- @Override- public void onEditCancel(AjaxRequestTarget target) {- Component content = get("content");- if (content instanceof EditCompleteAware)- ((EditCompleteAware) content).onEditCancel(target);- }-- private abstract class ParseableFragment extends Fragment implements EditCompleteAware {-- public ParseableFragment(String id) {- super(id, "parseableFrag", BuildSpecEditPanel.this);- }-- }-- private abstract class ElementsEditor<T extends NamedElement> extends Fragment {-- private final Class<T> elementClass;-- @SuppressWarnings("unchecked")- public ElementsEditor() {- super("content", "elementsFrag", BuildSpecEditPanel.this);-- List<Class<?>> typeArguments = ReflectionUtils.getTypeArguments(ElementsEditor.class, getClass());- elementClass = (Class<T>) typeArguments.get(0);- }-- protected abstract List<T> getElements();-- protected abstract BeanEditor newElementEditor(String componentId, T element);-- private void setupElementDetail(@Nullable AjaxRequestTarget target, int elementIndex) {- WebMarkupContainer elementDetail;-- if (elementIndex != -1) {- elementDetail = new Fragment("detail", "elementDetailFrag", BuildSpecEditPanel.this);- elementDetail.setDefaultModel(Model.of(elementIndex));-- BeanEditor elementEditor = newElementEditor("body", getElements().get(elementIndex));-- elementEditor.add(new Behavior() {-- @SuppressWarnings("unchecked")- @Override- public void onEvent(Component component, IEvent<?> event) {- super.onEvent(component, event);- if (event.getPayload() instanceof BeanUpdating) {- PropertyUpdating propertyUpdating = ((BeanUpdating) event.getPayload()).getSource();- if (propertyUpdating.getPropertyName().equals(Job.PROP_NAME)) {- T element = (T) elementEditor.getConvertedInput();- String selection = getUrlSegment(elementClass) + "s";- if (StringUtils.isNotBlank(element.getName()))- selection += "/" + element.getName();- int elementIndex = (int) elementDetail.getDefaultModelObject();- getElements().set(elementIndex, element);-- AjaxRequestTarget target = (AjaxRequestTarget) propertyUpdating.getHandler();- replaceState(target, selection);- target.add(ElementsEditor.this.get("navs"));- resizeWindow(target);- }- } else if (event.getPayload() instanceof FormSubmitted) {- int elementIndex = (int) elementDetail.getDefaultModelObject();- getElements().set(elementIndex, (T) elementEditor.getConvertedInput());- }- }-- });- elementDetail.add(elementEditor);- elementDetail.setOutputMarkupId(true);- } else {- elementDetail = new WebMarkupContainer("detail");- elementDetail.setOutputMarkupPlaceholderTag(true).setVisible(false);- }- elementDetail.setDefaultModel(Model.of(elementIndex));-- if (target != null) {- replace(elementDetail);- target.add(elementDetail);- } else {- add(elementDetail);- }- }-- @Override- protected void onInitialize() {- super.onInitialize();-- WebMarkupContainer navs = new WebMarkupContainer("navs") {-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);-- int elementIndex = (int) ElementsEditor.this.get("detail").getDefaultModelObject();- String script = String.format("onedev.server.buildSpec.markElementActive(%d);", elementIndex);- response.render(OnDomReadyHeaderItem.forScript(script));- }-- };-- navs.add(new ListView<T>("navs", new AbstractReadOnlyModel<List<T>>() {-- @Override- public List<T> getObject() {- return getElements();- }-- }) {-- @Override- protected void populateItem(ListItem<T> item) {- item.add(new AjaxSubmitLink("select") {-- @Override- protected void onInitialize() {- super.onInitialize();- add(new Label("label", new AbstractReadOnlyModel<String>() {-- @Override- public String getObject() {- T element = getElements().get(item.getIndex());- if (element.getName() != null)- return HtmlEscape.escapeHtml5(element.getName());- else- return "<i>No Name</i>";- }-- }).setEscapeModelStrings(false));- }-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- pushState(target, getUrlSegment(elementClass) + "s/" + item.getModelObject().getName());- setupElementDetail(target, item.getIndex());- target.appendJavaScript(String.format(- "onedev.server.buildSpec.markElementActive(%d);", item.getIndex()));- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(ElementsEditor.this);- resizeWindow(target);- }-- });-- item.add(new AjaxLink<Void>("delete") {-- @Override- public void onClick(AjaxRequestTarget target) {- getElements().remove(item.getIndex());-- Component elementDetail = ElementsEditor.this.get("detail");-- int activeElementIndex = (int) elementDetail.getDefaultModelObject();- if (item.getIndex() == activeElementIndex) {- if (getElements().isEmpty()) {- replaceState(target, getUrlSegment(elementClass) + "s");- setupElementDetail(target, -1);- } else {- replaceState(target, getUrlSegment(elementClass) + "s/" + getElements().get(0).getName());- setupElementDetail(target, 0);- }- } else if (item.getIndex() < activeElementIndex) {- elementDetail.setDefaultModelObject(activeElementIndex-1);- }- target.appendJavaScript("onedev.server.form.markDirty($('.build-spec').closest('form'));");- target.add(ElementsEditor.this.get("navs"));- resizeWindow(target);- }-- });- }-- });-- if (!getElements().isEmpty()) {- int elementIndex = getActiveElementIndex(context, elementClass, getElements(), 0);- setupElementDetail(null, elementIndex);- } else {- setupElementDetail(null, -1);- }-- navs.add(new SortBehavior() {-- @Override- protected void onSort(AjaxRequestTarget target, SortPosition from, SortPosition to) {- int fromIndex = from.getItemIndex();- int toIndex = to.getItemIndex();-- if (fromIndex < toIndex) {- for (int i=0; i<toIndex-fromIndex; i++)- Collections.swap(getElements(), fromIndex+i, fromIndex+i+1);- } else {- for (int i=0; i<fromIndex-toIndex; i++)- Collections.swap(getElements(), fromIndex-i, fromIndex-i-1);- }-- Component jobDetail = get("detail");-- int activeIndex = (int) jobDetail.getDefaultModelObject();-- if (fromIndex < activeIndex) {- if (toIndex >= activeIndex)- jobDetail.setDefaultModelObject(activeIndex-1);- } else if (fromIndex == activeIndex) {- jobDetail.setDefaultModelObject(toIndex);- } else {- if (toIndex <= activeIndex)- jobDetail.setDefaultModelObject(activeIndex+1);- }-- target.add(get("navs"));- resizeWindow(target);- }-- }.sortable(null));-- add(navs.setOutputMarkupId(true));-- AjaxSubmitLink createLink = new AjaxSubmitLink("create") {-- @Override- protected void onSubmit(AjaxRequestTarget target, Form<?> form) {- super.onSubmit(target, form);- T newElement;- try {- newElement = elementClass.getDeclaredConstructor().newInstance();- } catch (InstantiationException | IllegalAccessException | IllegalArgumentException- | InvocationTargetException | NoSuchMethodException | SecurityException e) {- throw new RuntimeException(e);- }-- getElements().add(newElement);- pushState(target, "new-" + getUrlSegment(elementClass));- int elementIndex = getElements().size()-1;- setupElementDetail(target, elementIndex);- target.add(ElementsEditor.this);- resizeWindow(target);- }-- @Override- protected void onError(AjaxRequestTarget target, Form<?> form) {- super.onError(target, form);- target.add(ElementsEditor.this);- resizeWindow(target);- }-- };-- add(createLink);-- add(AttributeAppender.append("class", "elements d-flex flex-nowrap " + getUrlSegment(elementClass) + "s"));- setOutputMarkupId(true);- }-- @Override- public void renderHead(IHeaderResponse response) {- super.renderHead(response);- response.render(OnDomReadyHeaderItem.forScript(- String.format("onedev.server.buildSpec.onTabDomReady('.%ss');", getUrlSegment(elementClass))));- }-- }--}+package io.onedev.server.web.page.project.blob.render.renderers.buildspec;++import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getActiveElementIndex;+import static io.onedev.server.web.page.project.blob.render.renderers.buildspec.BuildSpecRenderer.getUrlSegment;++import java.io.Serializable;+import java.lang.reflect.InvocationTargetException;+import java.nio.charset.StandardCharsets;+import java.util.ArrayList;+import java.util.Collection;+import java.util.Collections;+import java.util.List;++import javax.annotation.Nullable;+import javax.validation.ConstraintViolation;+import javax.validation.Validator;++import io.onedev.server.model.support.build.JobProperty;+import org.apache.commons.lang3.StringUtils;+import org.apache.wicket.Component;+import org.apache.wicket.ajax.AjaxRequestTarget;+import org.apache.wicket.ajax.markup.html.AjaxLink;+import org.apache.wicket.ajax.markup.html.form.AjaxSubmitLink;+import org.apache.wicket.behavior.AttributeAppender;+import org.apache.wicket.behavior.Behavior;+import org.apache.wicket.event.Broadcast;+import org.apache.wicket.event.IEvent;+import org.apache.wicket.feedback.FencedFeedbackPanel;+import org.apache.wicket.markup.head.IHeaderResponse;+import org.apache.wicket.markup.head.JavaScriptHeaderItem;+import org.apache.wicket.markup.head.OnDomReadyHeaderItem;+import org.apache.wicket.markup.html.WebMarkupContainer;+import org.apache.wicket.markup.html.basic.Label;+import org.apache.wicket.markup.html.form.Form;+import org.apache.wicket.markup.html.form.FormComponentPanel;+import org.apache.wicket.markup.html.list.ListItem;+import org.apache.wicket.markup.html.list.ListView;+import org.apache.wicket.markup.html.panel.Fragment;+import org.apache.wicket.model.AbstractReadOnlyModel;+import org.apache.wicket.model.LoadableDetachableModel;+import org.apache.wicket.model.Model;+import org.apache.wicket.request.cycle.RequestCycle;+import org.unbescape.html.HtmlEscape;++import com.google.common.base.Throwables;++import io.onedev.commons.loader.AppLoader;+import io.onedev.server.OneDev;+import io.onedev.server.buildspec.BuildSpec;+import io.onedev.server.buildspec.BuildSpecAware;+import io.onedev.server.buildspec.Import;+import io.onedev.server.buildspec.NamedElement;+import io.onedev.server.buildspec.ParamSpecAware;+import io.onedev.server.buildspec.Service;+import io.onedev.server.buildspec.job.Job;+import io.onedev.server.buildspec.job.JobAware;+import io.onedev.server.buildspec.job.JobSuggestion;+import io.onedev.server.buildspec.param.spec.ParamSpec;+import io.onedev.server.buildspec.step.StepTemplate;+import io.onedev.server.migration.VersionedYamlDoc;+import io.onedev.server.util.Path;+import io.onedev.server.util.PathNode;+import io.onedev.server.util.PathNode.Indexed;+import io.onedev.server.util.PathNode.Named;+import io.onedev.server.util.ReflectionUtils;+import io.onedev.server.web.behavior.sortable.SortBehavior;+import io.onedev.server.web.behavior.sortable.SortPosition;+import io.onedev.server.web.component.MultilineLabel;+import io.onedev.server.web.component.floating.FloatingPanel;+import io.onedev.server.web.component.menu.MenuItem;+import io.onedev.server.web.component.menu.MenuLink;+import io.onedev.server.web.component.pipeline.JobSelectionChange;+import io.onedev.server.web.component.pipeline.PipelinePanel;+import io.onedev.server.web.component.pipeline.Sortable;+import io.onedev.server.web.editable.BeanDescriptor;+import io.onedev.server.web.editable.BeanEditor;+import io.onedev.server.web.editable.BeanUpdating;+import io.onedev.server.web.editable.PropertyContext;+import io.onedev.server.web.editable.PropertyEditor;+import io.onedev.server.web.editable.PropertyUpdating;+import io.onedev.server.web.page.base.BasePage;+import io.onedev.server.web.page.project.blob.render.BlobRenderContext;+import io.onedev.server.web.page.project.blob.render.edit.EditCompleteAware;+import io.onedev.server.web.util.AjaxPayload;++@SuppressWarnings("serial")+public class BuildSpecEditPanel extends FormComponentPanel<byte[]> implements BuildSpecAware, EditCompleteAware {++ private final BlobRenderContext context;++ private Serializable parseResult;++ public BuildSpecEditPanel(String id, BlobRenderContext context, byte[] initialContent) {+ super(id, Model.of(initialContent));+ this.context = context;+ try {+ parseResult = BuildSpec.parse(initialContent);+ if (parseResult == null)+ parseResult = new BuildSpec();+ } catch (Exception e) {+ parseResult = e;+ }+ }++ private void resizeWindow(AjaxRequestTarget target) {+ ((BasePage)getPage()).resizeWindow(target);+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ if (parseResult instanceof BuildSpec) {+ BuildSpec buildSpec = (BuildSpec) parseResult;+ add(new ParseableFragment("content") {++ private WebMarkupContainer body;++ private void setupJobsEditor(@Nullable AjaxRequestTarget target) {+ Fragment jobsEditor = new Fragment("content", "jobsFrag", BuildSpecEditPanel.this) {++ private void notifyJobSelectionChange(AjaxRequestTarget target, Job job) {+ send(this, Broadcast.BREADTH, new JobSelectionChange(target, job));+ }++ private void setupJobDetail(@Nullable AjaxRequestTarget target, int jobIndex) {+ Fragment jobsEditor = this;++ WebMarkupContainer jobDetail;+ if (jobIndex != -1) {+ jobDetail = new Fragment("detail", "elementDetailFrag", BuildSpecEditPanel.this);++ class JobEditor extends BeanEditor implements JobAware {++ public JobEditor(String id, Job job) {+ super(id, new BeanDescriptor(Job.class), Model.of(job));+ }++ @Override+ public Job getJob() {+ return (Job) getConvertedInput();+ }++ @Override+ public List<ParamSpec> getParamSpecs() {+ return ((Job) getConvertedInput()).getParamSpecs();+ }++ }++ BeanEditor jobEditor = new JobEditor("body", buildSpec.getJobs().get(jobIndex)) {++ @Override+ public void onEvent(IEvent<?> event) {+ super.onEvent(event);+ if (event.getPayload() instanceof BeanUpdating) {+ PropertyUpdating propertyUpdating = ((BeanUpdating) event.getPayload()).getSource();+ if (propertyUpdating.getPropertyName().equals(Job.PROP_NAME)+ || propertyUpdating.getPropertyName().equals(Job.PROP_JOB_DEPENDENCIES)) {+ Job job = (Job) getConvertedInput();+ String selection = "jobs";+ if (StringUtils.isNotBlank(job.getName()))+ selection += "/" + job.getName();+ int jobIndex = (int) jobDetail.getDefaultModelObject();+ buildSpec.getJobs().set(jobIndex, job);++ AjaxRequestTarget target = (AjaxRequestTarget) propertyUpdating.getHandler();+ replaceState(target, selection);+ target.add(jobsEditor.get("pipeline"));+ resizeWindow(target);+ }+ } else if (event.getPayload() instanceof FormSubmitted) {+ int jobIndex = (int) jobDetail.getDefaultModelObject();+ buildSpec.getJobs().set(jobIndex, (Job) getConvertedInput());+ }+ }++ };++ jobDetail.add(jobEditor);+ } else {+ jobDetail = new WebMarkupContainer("detail");+ jobDetail.setVisible(false);+ }+ jobDetail.setDefaultModel(Model.of(jobIndex));+ jobDetail.setOutputMarkupPlaceholderTag(true);++ if (target != null) {+ replace(jobDetail);+ target.add(jobDetail);+ } else {+ add(jobDetail);+ }+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ Fragment jobsEditor = this;++ add(new PipelinePanel("pipeline") {++ private void addJob(AjaxRequestTarget target, Job job) {+ getJobs().add(job);+ pushState(target, "new-job");+ int jobIndex = getJobs().size()-1;+ setupJobDetail(target, jobIndex);+ target.add(jobsEditor);+ resizeWindow(target);+ }++ @Override+ protected Component renderJob(String componentId, int jobIndex) {+ WebMarkupContainer jobNav = new Fragment(componentId, "jobFrag", BuildSpecEditPanel.this);++ jobNav.add(new AjaxSubmitLink("select") {++ @Override+ protected void onInitialize() {+ super.onInitialize();+ add(new Label("label", new LoadableDetachableModel<String>() {++ @Override+ protected String load() {+ Job job = getJobs().get(jobIndex);+ if (job.getName() != null)+ return HtmlEscape.escapeHtml5(job.getName());+ else+ return "<i>No Name</i>";+ }++ }).setEscapeModelStrings(false));+ }++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ Job job = getJobs().get(jobIndex);+ pushState(target, "jobs/" + job.getName());+ setupJobDetail(target, buildSpec.getJobs().indexOf(job));++ notifyJobSelectionChange(target, job);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(jobsEditor);+ resizeWindow(target);+ }++ });++ jobNav.add(new AjaxLink<Void>("delete") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ getJobs().remove(jobIndex);++ Component jobDetail = jobsEditor.get("detail");++ int activeJobIndex = (int) jobDetail.getDefaultModelObject();+ if (jobIndex == activeJobIndex) {+ if (getJobs().isEmpty()) {+ replaceState(target, "jobs");+ setupJobDetail(target, -1);+ } else {+ replaceState(target, "jobs/" + getJobs().get(0).getName());+ setupJobDetail(target, 0);+ }+ } else if (jobIndex < activeJobIndex) {+ jobDetail.setDefaultModelObject(activeJobIndex-1);+ }+ target.appendJavaScript("onedev.server.form.markDirty($('.build-spec').closest('form'));");+ target.add(jobsEditor.get("pipeline"));+ resizeWindow(target);+ }++ });++ jobNav.add(AttributeAppender.append("class", "nav btn-group flex-nowrap"));++ return jobNav;+ }++ @Override+ protected Component renderAction(String componentId) {+ Fragment fragment = new Fragment(componentId, "addJobFrag", BuildSpecEditPanel.this);++ AjaxSubmitLink createLink = new AjaxSubmitLink("create") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ addJob(target, new Job());+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(jobsEditor);+ resizeWindow(target);+ }++ };++ fragment.add(createLink);++ List<Job> suggestedJobs = new ArrayList<>();++ if (context.getBlobIdent().revision != null) {+ for (JobSuggestion suggestion: OneDev.getExtensions(JobSuggestion.class))+ suggestedJobs.addAll(suggestion.suggestJobs(context.getProject(), context.getCommit()));+ }++ if (!suggestedJobs.isEmpty()) {+ fragment.add(new MenuLink("suggestions") {++ @Override+ protected List<MenuItem> getMenuItems(FloatingPanel dropdown) {+ List<MenuItem> menuItems = new ArrayList<>();+ for (Job job: suggestedJobs) {+ menuItems.add(new MenuItem() {++ @Override+ public String getLabel() {+ return job.getName();+ }++ @Override+ public WebMarkupContainer newLink(String id) {+ return new AjaxSubmitLink(id, createLink.findParent(Form.class)) {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ addJob(target, job);+ dropdown.close();+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(jobsEditor.get("pipeline"));+ resizeWindow(target);+ }++ };+ }++ });+ }+ return menuItems;+ }++ });+ } else {+ fragment.add(new WebMarkupContainer("suggestions").setVisible(false));+ }++ fragment.add(AttributeAppender.append("class", "add-job nav btn-group flex-nowrap"));+ return fragment;+ }++ @Override+ protected List<Job> getJobs() {+ return buildSpec.getJobs();+ }++ @Override+ protected int getActiveJobIndex() {+ return (int) jobsEditor.get("detail").getDefaultModelObject();+ }++ @Override+ protected Sortable getSortable() {+ return new Sortable() {++ @Override+ public void onSort(AjaxRequestTarget target, int fromIndex, int toIndex) {+ if (fromIndex < toIndex) {+ for (int i=0; i<toIndex-fromIndex; i++)+ Collections.swap(getJobs(), fromIndex+i, fromIndex+i+1);+ } else {+ for (int i=0; i<fromIndex-toIndex; i++)+ Collections.swap(getJobs(), fromIndex-i, fromIndex-i-1);+ }++ Component jobDetail = jobsEditor.get("detail");++ int activeIndex = (int) jobDetail.getDefaultModelObject();++ if (fromIndex < activeIndex) {+ if (toIndex >= activeIndex)+ jobDetail.setDefaultModelObject(activeIndex-1);+ } else if (fromIndex == activeIndex) {+ jobDetail.setDefaultModelObject(toIndex);+ } else {+ if (toIndex <= activeIndex)+ jobDetail.setDefaultModelObject(activeIndex+1);+ }++ target.add(jobsEditor.get("pipeline"));+ resizeWindow(target);+ }++ };+ }++ }.setOutputMarkupId(true));++ if (!buildSpec.getJobs().isEmpty())+ setupJobDetail(null, getActiveElementIndex(context, Job.class, buildSpec.getJobs(), 0));+ else+ setupJobDetail(null, -1);++ add(AttributeAppender.append("class", "elements d-flex flex-nowrap jobs"));++ setOutputMarkupId(true);+ }++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);+ response.render(OnDomReadyHeaderItem.forScript(+ String.format("onedev.server.buildSpec.onTabDomReady('.jobs');")));+ }++ };++ if (target != null) {+ body.replace(jobsEditor);+ target.add(jobsEditor);+ } else {+ body.add(jobsEditor);+ }+ }++ private void setupStepTemplatesEditor(@Nullable AjaxRequestTarget target) {+ Fragment stepTemplatesEditor = new ElementsEditor<StepTemplate>() {++ @Override+ protected List<StepTemplate> getElements() {+ return buildSpec.getStepTemplates();+ }++ @Override+ protected BeanEditor newElementEditor(String componentId, StepTemplate element) {++ class StepTemplateEditor extends BeanEditor implements ParamSpecAware {++ public StepTemplateEditor(String id, NamedElement element) {+ super(id, new BeanDescriptor(StepTemplate.class), Model.of(element));+ }++ @Override+ public List<ParamSpec> getParamSpecs() {+ return ((StepTemplate) getConvertedInput()).getParamSpecs();+ }++ }++ return new StepTemplateEditor(componentId, element);+ }++ };++ if (target != null) {+ body.replace(stepTemplatesEditor);+ target.add(stepTemplatesEditor);+ } else {+ body.add(stepTemplatesEditor);+ }+ }++ private void setupServicesEditor(@Nullable AjaxRequestTarget target) {+ Fragment servicesEditor = new ElementsEditor<Service>() {++ @Override+ protected List<Service> getElements() {+ return buildSpec.getServices();+ }++ @Override+ protected BeanEditor newElementEditor(String componentId, Service element) {+ return new BeanEditor(componentId, new BeanDescriptor(Service.class), Model.of(element));+ }++ };++ if (target != null) {+ body.replace(servicesEditor);+ target.add(servicesEditor);+ } else {+ body.add(servicesEditor);+ }+ }++ private void setupPropertiesEditor(@Nullable AjaxRequestTarget target) {+ PropertyEditor<Serializable> propertiesEditor = PropertyContext.edit("content", buildSpec, "properties");+ propertiesEditor.add(new Behavior() {++ @SuppressWarnings("unchecked")+ @Override+ public void onEvent(Component component, IEvent<?> event) {+ super.onEvent(component, event);+ if (event.getPayload() instanceof FormSubmitted)+ buildSpec.setProperties((List<JobProperty>) propertiesEditor.getConvertedInput());+ }++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.properties');"));+ }++ });+ propertiesEditor.add(AttributeAppender.append("class", "properties pr-3"));+ propertiesEditor.setOutputMarkupId(true);+ if (target != null) {+ body.replace(propertiesEditor);+ target.add(propertiesEditor);+ } else {+ body.add(propertiesEditor);+ }+ }++ private void setupImportsEditor(@Nullable AjaxRequestTarget target) {+ PropertyEditor<Serializable> importsEditor = PropertyContext.edit("content", buildSpec, "imports");+ importsEditor.add(new Behavior() {++ @SuppressWarnings("unchecked")+ @Override+ public void onEvent(Component component, IEvent<?> event) {+ super.onEvent(component, event);+ if (event.getPayload() instanceof FormSubmitted)+ buildSpec.setImports((List<Import>) importsEditor.getConvertedInput());+ }++ @Override+ public void renderHead(Component component, IHeaderResponse response) {+ super.renderHead(component, response);+ response.render(OnDomReadyHeaderItem.forScript("onedev.server.buildSpec.onTabDomReady('.imports');"));+ }++ });+ importsEditor.add(AttributeAppender.append("class", "imports pr-3"));+ importsEditor.setOutputMarkupId(true);+ if (target != null) {+ body.replace(importsEditor);+ target.add(importsEditor);+ } else {+ body.add(importsEditor);+ }+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ add(new AjaxSubmitLink("jobs") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, "jobs");+ setupJobsEditor(target);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(getParent());+ resizeWindow(target);+ }++ });++ add(new AjaxSubmitLink("services") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, "services");+ setupServicesEditor(target);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(getParent());+ resizeWindow(target);+ }++ });++ add(new AjaxSubmitLink("stepTemplates") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, "step-templates");+ setupStepTemplatesEditor(target);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(getParent());+ resizeWindow(target);+ }++ });++ add(new AjaxSubmitLink("properties") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, "properties");+ setupPropertiesEditor(target);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(getParent());+ resizeWindow(target);+ }++ });++ add(new AjaxSubmitLink("imports") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, "imports");+ setupImportsEditor(target);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(getParent());+ resizeWindow(target);+ }++ });++ add(body = new WebMarkupContainer("body"));+ body.add(new FencedFeedbackPanel("feedback", body));++ String selection = getSelection();++ if (selection == null || selection.startsWith("jobs") || selection.equals("new-job"))+ setupJobsEditor(null);+ else if (selection.startsWith("services") || selection.equals("new-service"))+ setupServicesEditor(null);+ else if (selection.startsWith("step-templates") || selection.equals("new-step-template"))+ setupStepTemplatesEditor(null);+ else if (selection.equals("imports"))+ setupImportsEditor(null);+ else+ setupPropertiesEditor(null);++ add(AttributeAppender.append("class", "parseable"));+ setOutputMarkupId(true);+ }++ @SuppressWarnings("rawtypes")+ @Override+ public boolean onEditComplete(AjaxRequestTarget target) {+ BuildSpec buildSpec = (BuildSpec) parseResult;+ Validator validator = AppLoader.getInstance(Validator.class);+ Collection<ConstraintViolation<BuildSpec>> violations = validator.validate(buildSpec);+ if (!violations.isEmpty()) {+ ConstraintViolation<BuildSpec> violation = violations.iterator().next();+ Path path = new Path(violation.getPropertyPath());+ if (path.getNodes().isEmpty()) {+ error(violation.getMessage());+ } else {+ PathNode.Named named = (Named) path.getNodes().iterator().next();+ switch (named.getName()) {+ case "jobs":+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ if (path.getNodes().isEmpty()) {+ replaceState(target, named.getName());+ setupJobsEditor(target);+ body.error(violation.getMessage());+ } else {+ PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ String selection = "jobs/" + buildSpec.getJobs().get(indexed.getIndex()).getName();+ replaceState(target, selection);+ setupJobsEditor(target);+ ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());+ }+ break;+ case "services":+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ if (path.getNodes().isEmpty()) {+ replaceState(target, named.getName());+ setupServicesEditor(target);+ body.error(violation.getMessage());+ } else {+ PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ String selection = "services/" + buildSpec.getServices().get(indexed.getIndex()).getName();+ replaceState(target, selection);+ setupServicesEditor(target);+ ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());+ }+ break;+ case "stepTemplates":+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ if (path.getNodes().isEmpty()) {+ replaceState(target, named.getName());+ setupStepTemplatesEditor(target);+ body.error(violation.getMessage());+ } else {+ PathNode.Indexed indexed = (Indexed) path.getNodes().iterator().next();+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ String selection = "step-templates/" + buildSpec.getStepTemplates().get(indexed.getIndex()).getName();+ replaceState(target, selection);+ setupStepTemplatesEditor(target);+ ((BeanEditor)body.get("content:detail:body")).error(path, violation.getMessage());+ }+ break;+ case "properties":+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ replaceState(target, "properties");+ setupPropertiesEditor(target);+ ((PropertyEditor)body.get("content")).error(path, violation.getMessage());+ break;+ case "imports":+ path = new Path(path.getNodes().subList(1, path.getNodes().size()));+ replaceState(target, "imports");+ setupImportsEditor(target);+ ((PropertyEditor)body.get("content")).error(path, violation.getMessage());+ break;+ default:+ throw new RuntimeException("Unexpected element name: " + named.getName());+ }+ }+ return false;+ } else {+ fixState(target);+ return true;+ }+ }++ @Override+ public void onEditCancel(AjaxRequestTarget target) {+ fixState(target);+ }++ private void fixState(AjaxRequestTarget target) {+ String selection = getSelection();+ if (selection == null || selection.startsWith("jobs")) {+ int jobIndex = getActiveElementIndex(context, Job.class, buildSpec.getJobs(), 0);+ if (jobIndex < buildSpec.getJobs().size())+ replaceState(target, "jobs/" + buildSpec.getJobs().get(jobIndex).getName());+ } else if (selection.startsWith("services")) {+ int serviceIndex = getActiveElementIndex(context, Service.class, buildSpec.getServices(), 0);+ if (serviceIndex < buildSpec.getServices().size())+ replaceState(target, "services/" + buildSpec.getServices().get(serviceIndex).getName());+ } else if (selection.startsWith("step-templates")) {+ int stepTemplateIndex = getActiveElementIndex(context, StepTemplate.class, buildSpec.getStepTemplates(), 0);+ if (stepTemplateIndex < buildSpec.getStepTemplates().size())+ replaceState(target, "step-templates/" + buildSpec.getStepTemplates().get(stepTemplateIndex).getName());+ } else if (selection.equals("new-job")) {+ replaceState(target, "jobs");+ } else if (selection.equals("new-service")) {+ replaceState(target, "services");+ } else if (selection.equals("new-step-template")) {+ replaceState(target, "step-templates");+ }+ }++ });+ } else {+ Fragment unparseableFrag = new Fragment("content", "unparseableFrag", this);+ unparseableFrag.add(new MultilineLabel("errorMessage",+ Throwables.getStackTraceAsString((Throwable) parseResult)));+ unparseableFrag.add(AttributeAppender.append("class", "unparseable"));+ add(unparseableFrag);+ }++ }++ @Override+ public void convertInput() {+ if (parseResult instanceof BuildSpec) {+ AjaxRequestTarget target = RequestCycle.get().find(AjaxRequestTarget.class);+ send(this, Broadcast.BREADTH, new FormSubmitted(target));+ setConvertedInput(VersionedYamlDoc.fromBean(parseResult).toYaml().getBytes(StandardCharsets.UTF_8));+ } else {+ setConvertedInput(getModelObject());+ }+ }++ private void pushState(AjaxRequestTarget target, String selection) {+ String position = BuildSpecRenderer.getPosition(selection);+ context.pushState(target, context.getBlobIdent(), position);+ }++ private void replaceState(AjaxRequestTarget target, String selection) {+ String position = BuildSpecRenderer.getPosition(selection);+ context.replaceState(target, context.getBlobIdent(), position);+ }++ @Nullable+ private String getSelection() {+ return BuildSpecRenderer.getSelection(context.getPosition());+ }++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);+ response.render(JavaScriptHeaderItem.forReference(new BuildSpecResourceReference()));+ }++ @Override+ public BuildSpec getBuildSpec() {+ if (parseResult instanceof BuildSpec)+ return (BuildSpec) parseResult;+ else+ return null;+ }++ private static class FormSubmitted extends AjaxPayload {++ public FormSubmitted(AjaxRequestTarget target) {+ super(target);+ }++ }++ @Override+ public boolean onEditComplete(AjaxRequestTarget target) {+ Component content = get("content");+ if (content instanceof EditCompleteAware)+ return ((EditCompleteAware) content).onEditComplete(target);+ else+ return true;+ }++ @Override+ public void onEditCancel(AjaxRequestTarget target) {+ Component content = get("content");+ if (content instanceof EditCompleteAware)+ ((EditCompleteAware) content).onEditCancel(target);+ }++ private abstract class ParseableFragment extends Fragment implements EditCompleteAware {++ public ParseableFragment(String id) {+ super(id, "parseableFrag", BuildSpecEditPanel.this);+ }++ }++ private abstract class ElementsEditor<T extends NamedElement> extends Fragment {++ private final Class<T> elementClass;++ @SuppressWarnings("unchecked")+ public ElementsEditor() {+ super("content", "elementsFrag", BuildSpecEditPanel.this);++ List<Class<?>> typeArguments = ReflectionUtils.getTypeArguments(ElementsEditor.class, getClass());+ elementClass = (Class<T>) typeArguments.get(0);+ }++ protected abstract List<T> getElements();++ protected abstract BeanEditor newElementEditor(String componentId, T element);++ private void setupElementDetail(@Nullable AjaxRequestTarget target, int elementIndex) {+ WebMarkupContainer elementDetail;++ if (elementIndex != -1) {+ elementDetail = new Fragment("detail", "elementDetailFrag", BuildSpecEditPanel.this);+ elementDetail.setDefaultModel(Model.of(elementIndex));++ BeanEditor elementEditor = newElementEditor("body", getElements().get(elementIndex));++ elementEditor.add(new Behavior() {++ @SuppressWarnings("unchecked")+ @Override+ public void onEvent(Component component, IEvent<?> event) {+ super.onEvent(component, event);+ if (event.getPayload() instanceof BeanUpdating) {+ PropertyUpdating propertyUpdating = ((BeanUpdating) event.getPayload()).getSource();+ if (propertyUpdating.getPropertyName().equals(Job.PROP_NAME)) {+ T element = (T) elementEditor.getConvertedInput();+ String selection = getUrlSegment(elementClass) + "s";+ if (StringUtils.isNotBlank(element.getName()))+ selection += "/" + element.getName();+ int elementIndex = (int) elementDetail.getDefaultModelObject();+ getElements().set(elementIndex, element);++ AjaxRequestTarget target = (AjaxRequestTarget) propertyUpdating.getHandler();+ replaceState(target, selection);+ target.add(ElementsEditor.this.get("navs"));+ resizeWindow(target);+ }+ } else if (event.getPayload() instanceof FormSubmitted) {+ int elementIndex = (int) elementDetail.getDefaultModelObject();+ getElements().set(elementIndex, (T) elementEditor.getConvertedInput());+ }+ }++ });+ elementDetail.add(elementEditor);+ elementDetail.setOutputMarkupId(true);+ } else {+ elementDetail = new WebMarkupContainer("detail");+ elementDetail.setOutputMarkupPlaceholderTag(true).setVisible(false);+ }+ elementDetail.setDefaultModel(Model.of(elementIndex));++ if (target != null) {+ replace(elementDetail);+ target.add(elementDetail);+ } else {+ add(elementDetail);+ }+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ WebMarkupContainer navs = new WebMarkupContainer("navs") {++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);++ int elementIndex = (int) ElementsEditor.this.get("detail").getDefaultModelObject();+ String script = String.format("onedev.server.buildSpec.markElementActive(%d);", elementIndex);+ response.render(OnDomReadyHeaderItem.forScript(script));+ }++ };++ navs.add(new ListView<T>("navs", new AbstractReadOnlyModel<List<T>>() {++ @Override+ public List<T> getObject() {+ return getElements();+ }++ }) {++ @Override+ protected void populateItem(ListItem<T> item) {+ item.add(new AjaxSubmitLink("select") {++ @Override+ protected void onInitialize() {+ super.onInitialize();+ add(new Label("label", new AbstractReadOnlyModel<String>() {++ @Override+ public String getObject() {+ T element = getElements().get(item.getIndex());+ if (element.getName() != null)+ return HtmlEscape.escapeHtml5(element.getName());+ else+ return "<i>No Name</i>";+ }++ }).setEscapeModelStrings(false));+ }++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ pushState(target, getUrlSegment(elementClass) + "s/" + item.getModelObject().getName());+ setupElementDetail(target, item.getIndex());+ target.appendJavaScript(String.format(+ "onedev.server.buildSpec.markElementActive(%d);", item.getIndex()));+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(ElementsEditor.this);+ resizeWindow(target);+ }++ });++ item.add(new AjaxLink<Void>("delete") {++ @Override+ public void onClick(AjaxRequestTarget target) {+ getElements().remove(item.getIndex());++ Component elementDetail = ElementsEditor.this.get("detail");++ int activeElementIndex = (int) elementDetail.getDefaultModelObject();+ if (item.getIndex() == activeElementIndex) {+ if (getElements().isEmpty()) {+ replaceState(target, getUrlSegment(elementClass) + "s");+ setupElementDetail(target, -1);+ } else {+ replaceState(target, getUrlSegment(elementClass) + "s/" + getElements().get(0).getName());+ setupElementDetail(target, 0);+ }+ } else if (item.getIndex() < activeElementIndex) {+ elementDetail.setDefaultModelObject(activeElementIndex-1);+ }+ target.appendJavaScript("onedev.server.form.markDirty($('.build-spec').closest('form'));");+ target.add(ElementsEditor.this.get("navs"));+ resizeWindow(target);+ }++ });+ }++ });++ if (!getElements().isEmpty()) {+ int elementIndex = getActiveElementIndex(context, elementClass, getElements(), 0);+ setupElementDetail(null, elementIndex);+ } else {+ setupElementDetail(null, -1);+ }++ navs.add(new SortBehavior() {++ @Override+ protected void onSort(AjaxRequestTarget target, SortPosition from, SortPosition to) {+ int fromIndex = from.getItemIndex();+ int toIndex = to.getItemIndex();++ if (fromIndex < toIndex) {+ for (int i=0; i<toIndex-fromIndex; i++)+ Collections.swap(getElements(), fromIndex+i, fromIndex+i+1);+ } else {+ for (int i=0; i<fromIndex-toIndex; i++)+ Collections.swap(getElements(), fromIndex-i, fromIndex-i-1);+ }++ Component jobDetail = get("detail");++ int activeIndex = (int) jobDetail.getDefaultModelObject();++ if (fromIndex < activeIndex) {+ if (toIndex >= activeIndex)+ jobDetail.setDefaultModelObject(activeIndex-1);+ } else if (fromIndex == activeIndex) {+ jobDetail.setDefaultModelObject(toIndex);+ } else {+ if (toIndex <= activeIndex)+ jobDetail.setDefaultModelObject(activeIndex+1);+ }++ target.add(get("navs"));+ resizeWindow(target);+ }++ }.sortable(null));++ add(navs.setOutputMarkupId(true));++ AjaxSubmitLink createLink = new AjaxSubmitLink("create") {++ @Override+ protected void onSubmit(AjaxRequestTarget target, Form<?> form) {+ super.onSubmit(target, form);+ T newElement;+ try {+ newElement = elementClass.getDeclaredConstructor().newInstance();+ } catch (InstantiationException | IllegalAccessException | IllegalArgumentException+ | InvocationTargetException | NoSuchMethodException | SecurityException e) {+ throw new RuntimeException(e);+ }++ getElements().add(newElement);+ pushState(target, "new-" + getUrlSegment(elementClass));+ int elementIndex = getElements().size()-1;+ setupElementDetail(target, elementIndex);+ target.add(ElementsEditor.this);+ resizeWindow(target);+ }++ @Override+ protected void onError(AjaxRequestTarget target, Form<?> form) {+ super.onError(target, form);+ target.add(ElementsEditor.this);+ resizeWindow(target);+ }++ };++ add(createLink);++ add(AttributeAppender.append("class", "elements d-flex flex-nowrap " + getUrlSegment(elementClass) + "s"));+ setOutputMarkupId(true);+ }++ @Override+ public void renderHead(IHeaderResponse response) {+ super.renderHead(response);+ response.render(OnDomReadyHeaderItem.forScript(+ String.format("onedev.server.buildSpec.onTabDomReady('.%ss');", getUrlSegment(elementClass))));+ }++ }++}diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesBean.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesBean.javanew file mode 100644index 0000000000..de553339f3--- /dev/null+++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesBean.java@@ -0,0 +1,26 @@+package io.onedev.server.web.page.project.setting.build;++import io.onedev.server.model.support.build.JobProperty;+import io.onedev.server.web.editable.annotation.Editable;++import java.io.Serializable;+import java.util.ArrayList;+import java.util.List;++@Editable+public class JobPropertiesBean implements Serializable {++ private static final long serialVersionUID = 1L;++ private List<JobProperty> properties = new ArrayList<>();++ @Editable+ public List<JobProperty> getProperties() {+ return properties;+ }++ public void setProperties(List<JobProperty> properties) {+ this.properties = properties;+ }++}diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.html b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.htmlnew file mode 100644index 0000000000..8a290eeb19--- /dev/null+++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.html@@ -0,0 +1,16 @@+<wicket:extend>+ <div class="alert alert-notice bg-white shadow mb-5 text-gray">+ <wicket:svg href="bulb" class="icon mr-2"/>+ Define properties to be used in build spec. Properties will be inherited by+ child projects, and can be overridden by child properties with same name.+ </div>+ <div class="card">+ <div class="card-body">+ <form wicket:id="form" class="leave-confirm">+ <div wicket:id="feedback" class="mb-4"></div>+ <div wicket:id="editor"></div>+ <input type="submit" value="Save" class="dirty-aware btn btn-primary mt-4">+ </form>+ </div>+ </div>+</wicket:extend>\ No newline at end of filediff --git a/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.javanew file mode 100644index 0000000000..435fd120ae--- /dev/null+++ b/server-core/src/main/java/io/onedev/server/web/page/project/setting/build/JobPropertiesPage.java@@ -0,0 +1,54 @@+package io.onedev.server.web.page.project.setting.build;++import io.onedev.server.OneDev;+import io.onedev.server.entitymanager.ProjectManager;+import io.onedev.server.web.editable.PropertyContext;+import io.onedev.server.web.editable.PropertyEditor;+import org.apache.wicket.Component;+import org.apache.wicket.feedback.FencedFeedbackPanel;+import org.apache.wicket.markup.html.basic.Label;+import org.apache.wicket.markup.html.form.Form;+import org.apache.wicket.request.mapper.parameter.PageParameters;++import java.io.Serializable;++@SuppressWarnings("serial")+public class JobPropertiesPage extends ProjectBuildSettingPage {++ public JobPropertiesPage(PageParameters params) {+ super(params);+ }++ @Override+ protected void onInitialize() {+ super.onInitialize();++ JobPropertiesBean bean = new JobPropertiesBean();+ bean.setProperties(getProject().getBuildSetting().getJobProperties());++ PropertyEditor<Serializable> editor = PropertyContext.edit("editor", bean, "properties");++ Form<?> form = new Form<Void>("form") {++ @Override+ protected void onSubmit() {+ super.onSubmit();+ getSession().success("Job properties saved");+ getProject().getBuildSetting().setJobProperties(bean.getProperties());+ OneDev.getInstance(ProjectManager.class).save(getProject());+ setResponsePage(JobPropertiesPage.class,+ JobPropertiesPage.paramsOf(getProject()));+ }++ };+ form.add(new FencedFeedbackPanel("feedback", form));+ form.add(editor);+ add(form);+ }++ @Override+ protected Component newProjectTitle(String componentId) {+ return new Label(componentId, "Job Properties");+ }++}