Skip to content

The Unified and Autonomous Development Platform

Removed warnings

Robin Shen9e64ef1c67db
diff --git a/server-core/src/main/java/io/onedev/server/git/ssh/SimpleGitSshServer.java b/server-core/src/main/java/io/onedev/server/git/ssh/SimpleGitSshServer.java
index 281da7e4d8..025be7e669 100644
--- a/server-core/src/main/java/io/onedev/server/git/ssh/SimpleGitSshServer.java
+++ b/server-core/src/main/java/io/onedev/server/git/ssh/SimpleGitSshServer.java
@@ -4,8 +4,10 @@ import java.io.IOException;
import java.security.PublicKey;
import java.text.MessageFormat;
import java.util.Collections;
+
import javax.inject.Inject;
import javax.inject.Singleton;
+
import org.apache.sshd.common.config.keys.KeyUtils;
import org.apache.sshd.common.keyprovider.KeyPairProvider;
import org.apache.sshd.server.Environment;
@@ -14,6 +16,7 @@ import org.apache.sshd.server.shell.UnknownCommand;
import org.eclipse.jgit.transport.ReceivePack;
import org.eclipse.jgit.transport.RemoteConfig;
import org.eclipse.jgit.transport.UploadPack;
+
import io.onedev.server.entitymanager.ProjectManager;
import io.onedev.server.entitymanager.SshKeyManager;
import io.onedev.server.git.ssh.command.AbstractProjectAwareGitCommand;
@@ -27,13 +30,13 @@ public class SimpleGitSshServer {
private final SshServer server;
- private final Dao dao;
+// private final Dao dao;
private final ProjectManager projectManager;
- private final ServerConfig serverConfig;
+// private final ServerConfig serverConfig;
- private final WorkExecutor workExecutor;
+// private final WorkExecutor workExecutor;
private final SshKeyManager sshKeyManager;
@@ -45,10 +48,10 @@ public class SimpleGitSshServer {
ServerConfig serverConfig,
WorkExecutor workExecutor,
SshKeyManager sshKeyManager) {
- this.dao = dao;
+// this.dao = dao;
this.projectManager = projectManager;
- this.serverConfig = serverConfig;
- this.workExecutor = workExecutor;
+// this.serverConfig = serverConfig;
+// this.workExecutor = workExecutor;
this.sshKeyManager = sshKeyManager;
this.server = SshServer.setUpDefaultServer();
diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/ssh/SshSettingPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/ssh/SshSettingPage.java
index 34e0953543..d3482d4131 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/admin/ssh/SshSettingPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/admin/ssh/SshSettingPage.java
@@ -37,7 +37,9 @@ public class SshSettingPage extends AdministrationPage {
Form<?> form = new Form<Void>("form") {
- @Override
+ private static final long serialVersionUID = 1L;
+
+ @Override
protected void onSubmit() {
super.onSubmit();
OneDev.getInstance(SettingManager.class).saveSshSetting(sshSetting);
diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserPage.java
index 98d0352f94..cef358a528 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserPage.java
@@ -2,6 +2,7 @@ package io.onedev.server.web.page.admin.user;
import java.util.ArrayList;
import java.util.List;
+
import org.apache.commons.lang3.StringUtils;
import org.apache.wicket.Component;
import org.apache.wicket.RestartResponseException;
@@ -13,11 +14,11 @@ import org.apache.wicket.markup.html.panel.Fragment;
import org.apache.wicket.model.IModel;
import org.apache.wicket.model.LoadableDetachableModel;
import org.apache.wicket.request.mapper.parameter.PageParameters;
+
import io.onedev.server.OneDev;
import io.onedev.server.OneException;
import io.onedev.server.entitymanager.UserManager;
import io.onedev.server.model.User;
-import io.onedev.server.web.OneWebApplication;
import io.onedev.server.web.component.floating.AlignPlacement;
import io.onedev.server.web.component.floating.FloatingPanel;
import io.onedev.server.web.component.link.DropdownLink;
diff --git a/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java b/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java
index 9f69e2f521..a63ba2c072 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/my/sshkeys/MySshKeysPage.java
@@ -1,6 +1,5 @@
package io.onedev.server.web.page.my.sshkeys;
-import java.time.format.DateTimeFormatter;
import java.util.List;
import org.apache.wicket.Component;
@@ -20,8 +19,6 @@ import io.onedev.server.web.page.my.MyPage;
@SuppressWarnings("serial")
public class MySshKeysPage extends MyPage {
- private static final DateTimeFormatter formatter = DateTimeFormatter.ofPattern("yyyy-MM-dd HH:mm:ss");
-
public MySshKeysPage(PageParameters params) {
super(params);