Skip to content

The Unified and Autonomous Development Platform

fix: `PushImageStep` with `trustCertificates` generates malformed shell script - export and crane push merged on same line (OD-2783)

Robin Shena42dc2b439bd
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/CraneStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/CraneStep.java
index cf4ffa781c..403c761f7c 100644
--- a/server-core/src/main/java/io/onedev/server/buildspec/step/CraneStep.java
+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/CraneStep.java
@@ -110,7 +110,7 @@ public abstract class CraneStep extends CommandStep {
commandsBuilder.append("cat <<EOF>> /root/trust-certs.crt\n");
commandsBuilder.append(getTrustCertificates().replace("\r\n", "\n")).append("\n");
commandsBuilder.append("EOF\n");
- commandsBuilder.append("export SSL_CERT_FILE=/root/trust-certs.crt");
+ commandsBuilder.append("export SSL_CERT_FILE=/root/trust-certs.crt\n");
}
commandsBuilder.append(getCommand());
return new CommandFacade(getEffectiveImage(), getRunAs(), registryLogins,