Skip to content

The Unified and Autonomous Development Platform

fix: RCE when using internal database

Robin Shena56514f90edf
diff --git a/server-core/src/main/java/io/onedev/server/persistence/HibernateConfig.java b/server-core/src/main/java/io/onedev/server/persistence/HibernateConfig.java
index 57e6d09f08..b611a0df17 100644
--- a/server-core/src/main/java/io/onedev/server/persistence/HibernateConfig.java
+++ b/server-core/src/main/java/io/onedev/server/persistence/HibernateConfig.java
@@ -16,8 +16,6 @@ import org.apache.commons.io.FileUtils;
import org.apache.commons.lang3.Strings;
import org.hibernate.cfg.Environment;
-import com.google.common.hash.Hashing;
-
import io.onedev.commons.utils.StringUtils;
public class HibernateConfig extends Properties {
@@ -34,8 +32,6 @@ public class HibernateConfig extends Properties {
"hibernate.query.plan_parameter_metadata_max_size"
};
- private volatile String clusterCredential;
-
public HibernateConfig(File installDir) {
File file = new File(installDir, "conf/hibernate.properties");
putAll(loadProperties(file));
@@ -97,15 +93,5 @@ public class HibernateConfig extends Properties {
public boolean isMySQLDialect() {
return isMySQLDialect(getDialect());
}
-
- public String getClusterCredential() {
- if (clusterCredential == null) {
- var dbPassword = getPassword();
- if (dbPassword == null)
- dbPassword = "";
- clusterCredential = Hashing.sha256().hashString(dbPassword, UTF_8).toString();
- }
- return clusterCredential;
- }
-
+
}
diff --git a/server-ee b/server-ee
index b549e16145..1a04a7ad2e 160000
--- a/server-ee
+++ b/server-ee
@@ -1 +1 @@
-Subproject commit b549e16145983efd8ba488788cd766273d4fedd6
+Subproject commit 1a04a7ad2e276dd90ec2c4c9484f1975f963f521