Skip to content

The Unified and Autonomous Development Platform

fix: Allow Escape to collapse pinned side info pane

Work Horseacd6c888ca2b
diff --git a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.js b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.js
index 52723e4773..d95cc12742 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.js
+++ b/server-core/src/main/java/io/onedev/server/web/component/sideinfo/side-info.js
@@ -76,8 +76,8 @@ onedev.server.sideInfo = {
}
});
$(document).on("keydown", function(e) {
- if (onedev.server.sideInfo.isOverlayMode($container)
- && e.keyCode == 27 && $(e.target).closest(".flatpickr-calendar").length == 0
+ // Escape closes both pinned and overlay panes; click-outside stays overlay-only
+ if (e.keyCode == 27 && $(e.target).closest(".flatpickr-calendar").length == 0
&& $container.find(".dropdown-open").length == 0
&& $(".select2-drop:visible").length == 0
&& $(".flatpickr-calendar.open").length == 0