Skip to content

The Unified and Autonomous Development Platform

fix: Exception when display an image exceeding 5M (#1377)

Robin Shenb6e7c559cd0a
diff --git a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java
index d77ad0294f..95a95b54a2 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/project/blob/render/view/BlobViewPanel.java
@@ -292,7 +292,8 @@ public abstract class BlobViewPanel extends Panel {
@Override
public String getObject() {
- return "Displaying first " + context.getProject().getBlob(context.getBlobIdent(), true).getText().getLines().size()
+ var text = context.getProject().getBlob(context.getBlobIdent(), true).getText();
+ return "Displaying first " + text.getLines().size()
+ " lines as file is too large";
}
@@ -301,7 +302,8 @@ public abstract class BlobViewPanel extends Panel {
@Override
protected void onConfigure() {
super.onConfigure();
- setVisible(context.getProject().getBlob(context.getBlobIdent(), true).isPartial());
+ var blob = context.getProject().getBlob(context.getBlobIdent(), true);
+ setVisible(blob.getText() != null && blob.isPartial());
}
});