The Unified and Autonomous Development Platform
Minor bug fix of input assist
Robin Shenba22901168d4
diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.html b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.htmlindex b9954823de..1ec6b869d1 100644--- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.html+++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.html@@ -10,7 +10,7 @@</ul><ul class="help list-unstyled rounded mt-3 mb-0 text-muted bg-light px-3 py-2"><li wicket:id="hints"></li>- <li><span class='complete'></span> ↑↓ to select item. Esc to <a wicket:id="close">close</a></li>+ <li><span class='complete'></span> ↑↓ to select item. Esc to close</li></ul></div></wicket:panel>\ No newline at end of filediff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.javaindex ff35436ebe..1a018a0b75 100644--- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java+++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/AssistPanel.java@@ -6,7 +6,6 @@ import java.util.stream.Collectors;import org.apache.commons.text.StringEscapeUtils;import org.apache.wicket.Component;import org.apache.wicket.ajax.AjaxRequestTarget;-import org.apache.wicket.ajax.markup.html.AjaxLink;import org.apache.wicket.behavior.AttributeAppender;import org.apache.wicket.markup.html.WebMarkupContainer;import org.apache.wicket.markup.html.basic.Label;@@ -86,14 +85,6 @@ abstract class AssistPanel extends Panel {for (String hint: hints)hintsView.add(new Label(hintsView.newChildId(), hint).setEscapeModelStrings(false));- add(new AjaxLink<Void>("close") {-- @Override- public void onClick(AjaxRequestTarget target) {- onClose(target);- }-- });setOutputMarkupId(true);}diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.jsindex 42bc368a79..7491b64758 100644--- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js+++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js@@ -173,7 +173,7 @@ onedev.server.inputassist = {$dropdown.click(function() {$input.focus();});- var $item = $dropdown.find("li");+ var $item = $dropdown.find(".suggestion");$item.click(function() {var $this = $(this);$input.data("update")($this);