Skip to content

The Unified and Autonomous Development Platform

Lazy load of images in markdown for increase page loading speed

Robin Shenbbd27141edfe
diff --git a/server-core/src/main/java/io/onedev/server/util/markdown/CodeProcessor.java b/server-core/src/main/java/io/onedev/server/util/markdown/CodeProcessor.java
index c816094fa1..21eb18f7de 100644
--- a/server-core/src/main/java/io/onedev/server/util/markdown/CodeProcessor.java
+++ b/server-core/src/main/java/io/onedev/server/util/markdown/CodeProcessor.java
@@ -6,8 +6,6 @@ import java.util.List;
import javax.annotation.Nullable;
-import org.apache.wicket.request.cycle.RequestCycle;
-import org.eclipse.jgit.lib.ObjectId;
import org.jsoup.nodes.Document;
import org.jsoup.nodes.Element;
import org.jsoup.nodes.Node;
@@ -21,19 +19,10 @@ import io.onedev.commons.jsyntax.TokenUtils;
import io.onedev.commons.jsyntax.Tokenized;
import io.onedev.commons.jsyntax.Tokenizer;
import io.onedev.commons.jsyntax.TokenizerRegistry;
-import io.onedev.server.git.GitUtils;
import io.onedev.server.model.Project;
-import io.onedev.server.web.page.project.commits.CommitDetailPage;
public class CodeProcessor implements MarkdownProcessor {
- protected String toHtml(Project project, ObjectId commitId) {
- CharSequence url = RequestCycle.get().urlFor(
- CommitDetailPage.class, CommitDetailPage.paramsOf(project, commitId.name()));
- return String.format("<a href='%s' class='commit reference' data-reference='%s'>%s</a>", url, commitId.name(),
- GitUtils.abbreviateSHA(commitId.name()));
- }
-
@Override
public void process(@Nullable Project project, Document rendered, Object context) {
Collection<Element> codeElements = new ArrayList<>();
diff --git a/server-core/src/main/java/io/onedev/server/web/asset/lozad/LozadResourceReference.java b/server-core/src/main/java/io/onedev/server/web/asset/lozad/LozadResourceReference.java
new file mode 100644
index 0000000000..a25bc9c96e
--- /dev/null
+++ b/server-core/src/main/java/io/onedev/server/web/asset/lozad/LozadResourceReference.java
@@ -0,0 +1,13 @@
+package io.onedev.server.web.asset.lozad;
+
+import org.apache.wicket.request.resource.JavaScriptResourceReference;
+
+public class LozadResourceReference extends JavaScriptResourceReference {
+
+ private static final long serialVersionUID = 1L;
+
+ public LozadResourceReference() {
+ super(LozadResourceReference.class, "lozad.min.js");
+ }
+
+}
diff --git a/server-core/src/main/java/io/onedev/server/web/asset/lozad/lozad.min.js b/server-core/src/main/java/io/onedev/server/web/asset/lozad/lozad.min.js
new file mode 100644
index 0000000000..b8aa0b2cbe
--- /dev/null
+++ b/server-core/src/main/java/io/onedev/server/web/asset/lozad/lozad.min.js
@@ -0,0 +1,10 @@
+/*! lozad.js - v1.14.0 - 2019-10-19
+* https://github.com/ApoorvSaxena/lozad.js
+* Copyright (c) 2019 Apoorv Saxena; Licensed MIT */
+!function(t,e){"object"==typeof exports&&"undefined"!=typeof module?module.exports=e():"function"==typeof define&&define.amd?define(e):(t=t||self).lozad=e()}(this,function(){"use strict";
+/**
+ * Detect IE browser
+ * @const {boolean}
+ * @private
+ */var d="undefined"!=typeof document&&document.documentMode,c={rootMargin:"0px",threshold:0,load:function(t){if("picture"===t.nodeName.toLowerCase()){var e=document.createElement("img");d&&t.getAttribute("data-iesrc")&&(e.src=t.getAttribute("data-iesrc")),t.getAttribute("data-alt")&&(e.alt=t.getAttribute("data-alt")),t.append(e)}if("video"===t.nodeName.toLowerCase()&&!t.getAttribute("data-src")&&t.children){for(var r=t.children,a=void 0,o=0;o<=r.length-1;o++)(a=r[o].getAttribute("data-src"))&&(r[o].src=a);t.load()}if(t.getAttribute("data-src")&&(t.src=t.getAttribute("data-src")),t.getAttribute("data-srcset")&&t.setAttribute("srcset",t.getAttribute("data-srcset")),t.getAttribute("data-background-image"))t.style.backgroundImage="url('"+t.getAttribute("data-background-image").split(",").join("'),url('")+"')";else if(t.getAttribute("data-background-image-set")){var i=t.getAttribute("data-background-image-set").split(","),n=i[0].substr(0,i[0].indexOf(" "))||i[0];// Substring before ... 1x
+n=-1===n.indexOf("url(")?"url("+n+")":n,1===i.length?t.style.backgroundImage=n:t.setAttribute("style",(t.getAttribute("style")||"")+"background-image: "+n+"; background-image: -webkit-image-set("+i+"); background-image: image-set("+i+")")}t.getAttribute("data-toggle-class")&&t.classList.toggle(t.getAttribute("data-toggle-class"))},loaded:function(){}};function l(t){t.setAttribute("data-loaded",!0)}var b=function(t){return"true"===t.getAttribute("data-loaded")};return function(){var r,a,o=0<arguments.length&&void 0!==arguments[0]?arguments[0]:".lozad",t=1<arguments.length&&void 0!==arguments[1]?arguments[1]:{},e=Object.assign({},c,t),i=e.root,n=e.rootMargin,d=e.threshold,u=e.load,s=e.loaded,g=void 0;return"undefined"!=typeof window&&window.IntersectionObserver&&(g=new IntersectionObserver((r=u,a=s,function(t,e){t.forEach(function(t){(0<t.intersectionRatio||t.isIntersecting)&&(e.unobserve(t.target),b(t.target)||(r(t.target),l(t.target),a(t.target)))})}),{root:i,rootMargin:n,threshold:d})),{observe:function(){for(var t=function(t){var e=1<arguments.length&&void 0!==arguments[1]?arguments[1]:document;return t instanceof Element?[t]:t instanceof NodeList?t:e.querySelectorAll(t)}(o,i),e=0;e<t.length;e++)b(t[e])||(g?g.observe(t[e]):(u(t[e]),l(t[e]),s(t[e])))},triggerLoad:function(t){b(t)||(u(t),l(t),s(t))},observer:g}}});
diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java
index 654cfb3ef6..7a9fa87efc 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java
+++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/MarkdownViewer.java
@@ -37,6 +37,7 @@ import io.onedev.server.util.ColorUtils;
import io.onedev.server.util.DateUtils;
import io.onedev.server.util.SecurityUtils;
import io.onedev.server.util.markdown.MarkdownManager;
+import io.onedev.server.web.asset.lozad.LozadResourceReference;
import io.onedev.server.web.avatar.AvatarManager;
import io.onedev.server.web.behavior.AbstractPostAjaxBehavior;
import io.onedev.server.web.page.project.ProjectPage;
@@ -215,6 +216,8 @@ public class MarkdownViewer extends GenericPanel<String> {
@Override
public void renderHead(IHeaderResponse response) {
super.renderHead(response);
+
+ response.render(JavaScriptHeaderItem.forReference(new LozadResourceReference()));
response.render(JavaScriptHeaderItem.forReference(new MarkdownResourceReference()));
CharSequence taskCallback = taskBehavior.getCallbackFunction(
diff --git a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
index 6504afd63a..9e5bca1e07 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
+++ b/server-core/src/main/java/io/onedev/server/web/component/markdown/markdown.js
@@ -963,7 +963,18 @@ onedev.server.markdown = {
}
}, alignment);
- onedev.server.markdown.initRendered($container.find(".markdown-rendered"));
+ var $rendered = $container.find(".markdown-rendered");
+ onedev.server.markdown.initRendered($rendered);
+
+ var $img = $rendered.find("img");
+ $img.each(function() {
+ var $this = $(this);
+ var src = $this.attr("src");
+ $this.removeAttr("src");
+ $this.attr("data-src", src);
+ });
+
+ lozad("#" + containerId + " .markdown-rendered img").observe();
},
renderIssueTooltip: function(title, state, stateFontColor, stateBackgroundColor) {
var $tooltip = $("#reference-tooltip");