The Unified and Autonomous Development Platform
fix: Vulnerable to Command Injection via PullRepository job in Pipeline (OD-2221)
Robin Shenbccaf576b568
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java b/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.javaindex 4b63d150dc..182fdddd4a 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/SyncRepository.java@@ -1,5 +1,6 @@package io.onedev.server.buildspec.step;+import com.google.common.base.Preconditions;import io.onedev.commons.codeassist.InputSuggestion;import io.onedev.commons.utils.FileUtils;import io.onedev.commons.utils.StringUtils;@@ -124,6 +125,10 @@ public abstract class SyncRepository extends ServerSideStep {}String protocol = StringUtils.substringBefore(getRemoteUrl(), "//");++ // Fix OD-2221+ Preconditions.checkState(protocol.equals("http:") || protocol.equals("https:"));+String hostAndPath = StringUtils.substringAfter(getRemoteUrl(), "//");String remoteUrlWithCredentials = protocol + "//";