Skip to content

The Unified and Autonomous Development Platform

Fix the issue that removing required reviewer clears its notification status

robin shenc60ee6c0c3d0
diff --git a/core/src/main/java/com/gitplex/server/manager/impl/DefaultReviewInvitationManager.java b/core/src/main/java/com/gitplex/server/manager/impl/DefaultReviewInvitationManager.java
index d4e316834a..7f879b600b 100644
--- a/core/src/main/java/com/gitplex/server/manager/impl/DefaultReviewInvitationManager.java
+++ b/core/src/main/java/com/gitplex/server/manager/impl/DefaultReviewInvitationManager.java
@@ -40,13 +40,13 @@ public class DefaultReviewInvitationManager extends AbstractEntityManager<Review
invitation.setType(ReviewInvitation.Type.EXCLUDE);
PullRequest request = invitation.getRequest();
- save(invitation);
-
User reviewer = invitation.getUser();
if (request.getQualityCheckStatus().getAwaitingReviewers().contains(reviewer)
|| request.getQualityCheckStatus().getEffectiveReviews().containsKey(reviewer)) {
return false;
} else {
+ save(invitation);
+
PullRequestStatusChange statusChange = new PullRequestStatusChange();
statusChange.setDate(new Date());
statusChange.setRequest(request);