Skip to content

The Unified and Autonomous Development Platform

set X-FRAME-OPTIONS response header to avoid XFS attack

robin shend0d9cd87d68d
diff --git a/web/src/main/java/com/gitplex/server/web/DefaultWicketServlet.java b/web/src/main/java/com/gitplex/server/web/DefaultWicketServlet.java
index edddd3f3f0..46f1d4ae27 100644
--- a/web/src/main/java/com/gitplex/server/web/DefaultWicketServlet.java
+++ b/web/src/main/java/com/gitplex/server/web/DefaultWicketServlet.java
@@ -6,6 +6,7 @@ import javax.inject.Inject;
import javax.servlet.ServletException;
import javax.servlet.ServletRequest;
import javax.servlet.ServletResponse;
+import javax.servlet.http.HttpServletResponse;
import org.apache.wicket.protocol.http.WicketFilter;
import org.apache.wicket.protocol.http.WicketServlet;
@@ -36,6 +37,7 @@ public class DefaultWicketServlet extends WicketServlet {
@Sessional
@Override
public void service(ServletRequest req, ServletResponse res) throws ServletException, IOException {
+ ((HttpServletResponse)res).setHeader("X-FRAME-OPTIONS", "SAMEORIGION");
super.service(req, res);
}
diff --git a/web/src/main/java/com/gitplex/server/web/WebSession.java b/web/src/main/java/com/gitplex/server/web/WebSession.java
index 656784407d..bf11bbaa79 100644
--- a/web/src/main/java/com/gitplex/server/web/WebSession.java
+++ b/web/src/main/java/com/gitplex/server/web/WebSession.java
@@ -25,7 +25,7 @@ public class WebSession extends org.apache.wicket.protocol.http.WebSession {
public void login(String userName, String password, boolean rememberMe) {
Subject subject = SecurityUtils.getSubject();
- // Force a new session to prevent fixation attack.
+ // Force a new session to prevent session fixation attack.
// We have to invalidate via both Shiro and Wicket; otherwise it doesn't
// work.
subject.getSession().stop();