Skip to content

The Unified and Autonomous Development Platform

Fix the issue that renaming a project can result in NPE

Robin Shend1bf74fc1980
diff --git a/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/JobExecutor.java b/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/JobExecutor.java
index 0b58835a20..4d77bc0e27 100644
--- a/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/JobExecutor.java
+++ b/server-core/src/main/java/io/onedev/server/model/support/administration/jobexecutor/JobExecutor.java
@@ -94,10 +94,12 @@ public abstract class JobExecutor implements Serializable {
}
public void onRenameProject(String oldPath, String newPath) {
- io.onedev.server.job.requirement.JobRequirement parsedJobRequirement =
- io.onedev.server.job.requirement.JobRequirement.parse(this.jobRequirement);
- parsedJobRequirement.onRenameProject(oldPath, newPath);
- jobRequirement = parsedJobRequirement.toString();
+ if (jobRequirement != null) {
+ io.onedev.server.job.requirement.JobRequirement parsedJobRequirement =
+ io.onedev.server.job.requirement.JobRequirement.parse(jobRequirement);
+ parsedJobRequirement.onRenameProject(oldPath, newPath);
+ jobRequirement = parsedJobRequirement.toString();
+ }
}
public Usage onDeleteUser(String userName) {