Skip to content

The Unified and Autonomous Development Platform

Close symbol hover upon ESC

Robin Shend655074f0505
diff --git a/server-core/src/main/java/io/onedev/server/web/asset/hover/jquery.hover.js b/server-core/src/main/java/io/onedev/server/web/asset/hover/jquery.hover.js
index 00f09c17f6..578c4dff60 100644
--- a/server-core/src/main/java/io/onedev/server/web/asset/hover/jquery.hover.js
+++ b/server-core/src/main/java/io/onedev/server/web/asset/hover/jquery.hover.js
@@ -40,13 +40,22 @@
placement: alignment,
target: {element: trigger}
});
+
+ $popover.data("keydown", function(e) {
+ if (e.keyCode == 27)
+ hide();
+ });
+
+ jQuery(document).on("keydown", $popover.data("keydown"));
}
}
}
function hide() {
if (popover) {
- jQuery(popover).remove();
+ var $popover = jQuery(popover);
+ jQuery(document).off("keydown", $popover.data("keydown"));
+ $popover.remove();
popover = undefined;
}
cancelShow();
@@ -89,3 +98,4 @@
};
}( jQuery ));
+
diff --git a/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/symbol-tooltip.js b/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/symbol-tooltip.js
index d531b37d25..8a8049ff58 100644
--- a/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/symbol-tooltip.js
+++ b/server-core/src/main/java/io/onedev/server/web/component/symboltooltip/symbol-tooltip.js
@@ -96,9 +96,16 @@ onedev.server.symboltooltip = {
};
$(function() {
- $(window).scroll(function() {
+ function closeAll() {
$(".symbol-tooltip-container").each(function() {
onedev.server.symboltooltip.removeTooltip(this);
});
+ }
+
+ $(window).scroll(closeAll);
+
+ $(window).keydown(function(e) {
+ if (e.keyCode == 27)
+ closeAll();
});
});
\ No newline at end of file