The Unified and Autonomous Development Platform
chore: Add loopback address check to report clear errors
Robin Shendc8d2e615fc6
diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/BuildImageWithKanikoStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/BuildImageWithKanikoStep.javaindex 334eee9c2d..347394e9ed 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/step/BuildImageWithKanikoStep.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/BuildImageWithKanikoStep.java@@ -2,6 +2,7 @@ package io.onedev.server.buildspec.step;import io.onedev.agent.BuiltInRegistryLogin;import io.onedev.commons.codeassist.InputSuggestion;+import io.onedev.commons.utils.ExplicitException;import io.onedev.commons.utils.StringUtils;import io.onedev.k8shelper.CommandFacade;import io.onedev.server.OneDev;@@ -202,8 +203,11 @@ public class BuildImageWithKanikoStep extends CommandStep {@Overridepublic String getOptions() {var options = new ArrayList<String>();- for (var destination: StringUtils.splitAndTrim(getDestinations(), " "))+ for (var destination: StringUtils.splitAndTrim(getDestinations(), " ")) {+ if (destination.contains("localhost") || destination.contains("127.0.0.1"))+ throw new ExplicitException("Loopback address not allowed for destination of Kaniko image build step, please use ip address or host name instead");options.add("--destination=" + destination);+ }return StringUtils.join(options, " ");}diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/PullImageStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/PullImageStep.javaindex cf99888c02..1a28581db1 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/step/PullImageStep.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/PullImageStep.java@@ -1,6 +1,7 @@package io.onedev.server.buildspec.step;import io.onedev.commons.codeassist.InputSuggestion;+import io.onedev.commons.utils.ExplicitException;import io.onedev.server.annotation.*;import io.onedev.server.buildspec.BuildSpec;@@ -83,6 +84,9 @@ public class PullImageStep extends CraneStep {builder.append("--platform ").append(getPlatform()).append(" ");if (getMoreOptions() != null)builder.append(getMoreOptions()).append(" ");++ if (getSrcImage().contains("localhost") || getSrcImage().contains("127.0.0.1"))+ throw new ExplicitException("Loopback address not allowed for source docker image of push image step, please use ip address or host name instead");builder.append(getSrcImage()).append(" /onedev-build/workspace/").append(getDestPath());return builder.toString();}diff --git a/server-core/src/main/java/io/onedev/server/buildspec/step/PushImageStep.java b/server-core/src/main/java/io/onedev/server/buildspec/step/PushImageStep.javaindex 549264bedb..df31268a30 100644--- a/server-core/src/main/java/io/onedev/server/buildspec/step/PushImageStep.java+++ b/server-core/src/main/java/io/onedev/server/buildspec/step/PushImageStep.java@@ -1,6 +1,7 @@package io.onedev.server.buildspec.step;import io.onedev.commons.codeassist.InputSuggestion;+import io.onedev.commons.utils.ExplicitException;import io.onedev.server.annotation.*;import io.onedev.server.buildspec.BuildSpec;@@ -66,6 +67,8 @@ public class PushImageStep extends CraneStep {var builder = new StringBuilder("crane push");if (getMoreOptions() != null)builder.append(" ").append(getMoreOptions());+ if (getDestImage().contains("localhost") || getDestImage().contains("127.0.0.1"))+ throw new ExplicitException("Loopback address not allowed for target docker image of push image step, please use ip address or host name instead");builder.append(" /onedev-build/workspace/").append(getSrcPath()).append(" ").append(getDestImage());return builder.toString();}