Skip to content

The Unified and Autonomous Development Platform

Fix code assist not auto-complete issue in some cases

Robin Shene151d27f8b62
diff --git a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js
index cf1535ef71..ef8ab1aca0 100644
--- a/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js
+++ b/server-core/src/main/java/io/onedev/server/web/behavior/inputassist/input-assist.js
@@ -36,13 +36,18 @@ onedev.server.inputassist = {
$input.data("update", function($item) {
var value = $item.data("content");
var caret = $item.data("caret");
- $input.val(value);
- if (caret != undefined)
- $input.caret(caret);
- $input.blur();
- $input.focus();
- $input.trigger("input");
- $input.trigger("assist");
+ if (value != $input.val() || caret != undefined && caret != $input.caret()) {
+ $input.val(value);
+ if (caret != undefined)
+ $input.caret(caret);
+ $input.blur();
+ $input.focus();
+ $input.trigger("input");
+ $input.trigger("assist");
+ return true;
+ } else {
+ return false;
+ }
});
$input.bind("keydown", "up", function() {
@@ -108,10 +113,14 @@ onedev.server.inputassist = {
} else {
tabbing = false;
var $active = $dropdown.find("li.active");
- if ($active.length != 0)
+ if ($active.length != 0) {
$input.data("update")($active);
- else if ($dropdown.find("li").length != 0)
- $input.data("update")($dropdown.find("li").first());
+ } else if ($dropdown.find("li").length != 0) {
+ $dropdown.find("li").each(function() {
+ if ($input.data("update")($(this)))
+ return false;
+ });
+ }
}
return false;
} else {