Skip to content

The Unified and Autonomous Development Platform

fix(pack): keep container tags mutable

Chief Work Horsee7833efd38bb
diff --git a/server-core/src/main/java/io/onedev/server/pack/PackSupport.java b/server-core/src/main/java/io/onedev/server/pack/PackSupport.java
index 76e23caf21..7819deb8f0 100644
--- a/server-core/src/main/java/io/onedev/server/pack/PackSupport.java
+++ b/server-core/src/main/java/io/onedev/server/pack/PackSupport.java
@@ -17,6 +17,10 @@ public interface PackSupport extends Serializable {
String getPackIcon();
String getReference(Pack pack, boolean withProject);
+
+ default boolean isVersionMutable(Pack pack) {
+ return false;
+ }
Component renderContent(String componentId, Pack pack);
diff --git a/server-core/src/main/java/io/onedev/server/service/impl/DefaultPackService.java b/server-core/src/main/java/io/onedev/server/service/impl/DefaultPackService.java
index f9f503222b..0ff49145db 100644
--- a/server-core/src/main/java/io/onedev/server/service/impl/DefaultPackService.java
+++ b/server-core/src/main/java/io/onedev/server/service/impl/DefaultPackService.java
@@ -437,7 +437,7 @@ public class DefaultPackService extends BaseEntityService<Pack>
@Transactional
@Override
public void createOrUpdate(Pack pack, Collection<PackBlob> packBlobs, boolean postPublishEvent) {
- if (!pack.isNew() && packBlobs != null) {
+ if (!pack.isNew() && packBlobs != null && !pack.getSupport().isVersionMutable(pack)) {
var sha256Hashes = packBlobs.stream().map(PackBlob::getSha256Hash).collect(Collectors.toSet());
for (var blobReference: pack.getBlobReferences()) {
if (!sha256Hashes.contains(blobReference.getPackBlob().getSha256Hash())) {
diff --git a/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerPackSupport.java b/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerPackSupport.java
index d1d830d822..12eba6e47a 100644
--- a/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerPackSupport.java
+++ b/server-plugin/server-plugin-pack-container/src/main/java/io/onedev/server/plugin/pack/container/ContainerPackSupport.java
@@ -35,6 +35,11 @@ public class ContainerPackSupport implements PackSupport {
return reference;
}
+ @Override
+ public boolean isVersionMutable(Pack pack) {
+ return true;
+ }
+
@Override
public Component renderContent(String componentId, Pack pack) {
var serverUrl = OneDev.getInstance(SettingService.class).getSystemSetting().getServerUrl();