Skip to content

The Unified and Autonomous Development Platform

Abbreviate issue/pull request description content if too long during migration

Robin Shene8a55367a938
diff --git a/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java b/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java
index 577d02b15b..28fcde599c 100644
--- a/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java
+++ b/server-core/src/main/java/io/onedev/server/migration/DataMigrator.java
@@ -8,6 +8,7 @@ import java.net.UnknownHostException;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
+import java.text.MessageFormat;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
@@ -28,6 +29,8 @@ import org.apache.commons.lang3.RandomStringUtils;
import org.apache.commons.lang3.tuple.Triple;
import org.dom4j.Element;
import org.dom4j.Node;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
import com.google.common.base.Preconditions;
@@ -35,7 +38,11 @@ import io.onedev.commons.bootstrap.Bootstrap;
import io.onedev.commons.utils.ExplicitException;
import io.onedev.commons.utils.FileUtils;
import io.onedev.commons.utils.StringUtils;
+import io.onedev.server.model.Issue;
+import io.onedev.server.model.IssueComment;
import io.onedev.server.model.Project;
+import io.onedev.server.model.PullRequest;
+import io.onedev.server.model.PullRequestComment;
import io.onedev.server.model.User;
import io.onedev.server.util.Pair;
import oshi.SystemInfo;
@@ -45,6 +52,8 @@ import oshi.hardware.HardwareAbstractionLayer;
@SuppressWarnings("unused")
public class DataMigrator {
+ private static final Logger logger = LoggerFactory.getLogger(DataMigrator.class);
+
private void migrate1(File dataDir, Stack<Integer> versions) {
for (File file: dataDir.listFiles()) {
if (file.getName().startsWith("CodeComments.xml")) {
@@ -3956,8 +3965,86 @@ public class DataMigrator {
}
private void migrate83(File dataDir, Stack<Integer> versions) {
+ Map<String, String> issueInfos = new HashMap<>();
+ Map<String, String> pullRequestInfos = new HashMap<>();
for (File file: dataDir.listFiles()) {
- if (file.getName().startsWith("Settings.xml")) {
+ if (file.getName().startsWith("Issues.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ String issueInfo = MessageFormat.format(
+ "project id: {0}, issue number: {1}",
+ element.elementText("project"), element.elementText("number"));
+ issueInfos.put(element.elementTextTrim("id"), issueInfo);
+ }
+ } else if (file.getName().startsWith("PullRequests.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ String pullRequestInfo = MessageFormat.format(
+ "project id: {0}, pull request number: {1}",
+ element.elementText("targetProject"), element.elementText("number"));
+ pullRequestInfos.put(element.elementTextTrim("id"), pullRequestInfo);
+ }
+ }
+ }
+
+ for (File file: dataDir.listFiles()) {
+ if (file.getName().startsWith("Issues.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ Element descriptionElement = element.element("description");
+ if (descriptionElement != null) {
+ String description = descriptionElement.getText().trim();
+ if (description.length() > Issue.MAX_DESCRIPTION_LEN) {
+ descriptionElement.setText(StringUtils.abbreviate(description, Issue.MAX_DESCRIPTION_LEN));
+ logger.warn("Issue description too long and truncated ({})",
+ issueInfos.get(element.elementTextTrim("id")));
+ }
+ }
+ }
+ dom.writeToFile(file, false);
+ } else if (file.getName().startsWith("PullRequests.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ Element descriptionElement = element.element("description");
+ if (descriptionElement != null) {
+ String description = descriptionElement.getText().trim();
+ if (description.length() > PullRequest.MAX_DESCRIPTION_LEN) {
+ descriptionElement.setText(StringUtils.abbreviate(description, PullRequest.MAX_DESCRIPTION_LEN));
+ logger.warn("Pull request description too long and truncated ({})",
+ pullRequestInfos.get(element.elementTextTrim("id")));
+ }
+ }
+ }
+ dom.writeToFile(file, false);
+ } else if (file.getName().startsWith("IssueComments.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ Element contentElement = element.element("content");
+ if (contentElement != null) {
+ String content = contentElement.getText().trim();
+ if (content.length() > IssueComment.MAX_CONTENT_LEN) {
+ contentElement.setText(StringUtils.abbreviate(content, IssueComment.MAX_CONTENT_LEN));
+ logger.warn("Issue comment too long and truncated ({})",
+ issueInfos.get(element.elementText("issue")));
+ }
+ }
+ }
+ dom.writeToFile(file, false);
+ } else if (file.getName().startsWith("PullRequestComments.xml")) {
+ VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
+ for (Element element: dom.getRootElement().elements()) {
+ Element contentElement = element.element("content");
+ if (contentElement != null) {
+ String content = contentElement.getText().trim();
+ if (content.length() > PullRequestComment.MAX_CONTENT_LEN) {
+ contentElement.setText(StringUtils.abbreviate(content, PullRequestComment.MAX_CONTENT_LEN));
+ logger.warn("Pull request comment too long and truncated ({})",
+ pullRequestInfos.get(element.elementText("request")));
+ }
+ }
+ }
+ dom.writeToFile(file, false);
+ } else if (file.getName().startsWith("Settings.xml")) {
VersionedXmlDoc dom = VersionedXmlDoc.fromFile(file);
for (Element element: dom.getRootElement().elements()) {
if (element.elementTextTrim("key").equals("MAIL")) {
diff --git a/server-core/src/main/java/io/onedev/server/model/IssueComment.java b/server-core/src/main/java/io/onedev/server/model/IssueComment.java
index ee98ea6a3f..301f4ffab3 100644
--- a/server-core/src/main/java/io/onedev/server/model/IssueComment.java
+++ b/server-core/src/main/java/io/onedev/server/model/IssueComment.java
@@ -19,7 +19,7 @@ public class IssueComment extends AbstractEntity {
private static final long serialVersionUID = 1L;
- private static final int MAX_CONTENT_LEN = 15000;
+ public static final int MAX_CONTENT_LEN = 15000;
public static final String PROP_CONTENT = "content";