Skip to content

The Unified and Autonomous Development Platform

User with administrative rights is able to impersonate as other user

robin shenefec1d709932
diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.html b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.html
index d93d6f9d70..3669dc7961 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.html
@@ -19,5 +19,6 @@
</wicket:fragment>
<wicket:fragment wicket:id="actionFrag">
<a wicket:id="delete" title="Delete this user"><i class="fa fa-trash"></i></a>
+ <a wicket:id="impersonate" title="Impersonate this user"><i class="fa fa-user-circle"></i></a>
</wicket:fragment>
</wicket:extend>
diff --git a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.java b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.java
index 1eb02c1dc2..3f4eb9be51 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/admin/user/UserListPage.java
@@ -40,6 +40,7 @@ import io.onedev.server.web.component.datatable.LoadableDetachableDataProvider;
import io.onedev.server.web.component.user.UserDeleteLink;
import io.onedev.server.web.component.user.avatar.UserAvatar;
import io.onedev.server.web.page.admin.AdministrationPage;
+import io.onedev.server.web.page.project.ProjectListPage;
import io.onedev.server.web.util.PagingHistorySupport;
@SuppressWarnings("serial")
@@ -162,6 +163,16 @@ public class UserListPage extends AdministrationPage {
});
+ fragment.add(new Link<Void>("impersonate") {
+
+ @Override
+ public void onClick() {
+ SecurityUtils.getSubject().runAs(rowModel.getObject().getPrincipals());
+ setResponsePage(ProjectListPage.class);
+ }
+
+ });
+
cellItem.add(fragment);
}
diff --git a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.html b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.html
index 0d4ea1eb57..585830828e 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.html
@@ -66,7 +66,7 @@
<li wicket:id="myPassword"><a wicket:id="link"><i class="fa fa-fw fa-key"></i> Change Password</a></li>
<li wicket:id="myBuildSetting"><a wicket:id="link"><i class="fa fa-fw fa-cubes"></i> Build Setting</a></li>
<li role="separator" class="divider"></li>
- <li><a wicket:id="signOut"><i class="fa fa-fw fa-sign-out"></i> Sign Out</a></li>
+ <li><a wicket:id="signOut"><i class="fa fa-fw fa-sign-out"></i> <span wicket:id="label"></span></a></li>
</ul>
</li>
</ul>
diff --git a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java
index 0233a05286..518ea3f99f 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java
+++ b/server-core/src/main/java/io/onedev/server/web/page/layout/LayoutPage.java
@@ -2,6 +2,7 @@ package io.onedev.server.web.page.layout;
import org.apache.wicket.Component;
import org.apache.wicket.RestartResponseAtInterceptPageException;
+import org.apache.wicket.Session;
import org.apache.wicket.behavior.AttributeAppender;
import org.apache.wicket.markup.head.CssHeaderItem;
import org.apache.wicket.markup.head.IHeaderResponse;
@@ -48,6 +49,7 @@ import io.onedev.server.web.page.my.MyPasswordPage;
import io.onedev.server.web.page.my.MyProfilePage;
import io.onedev.server.web.page.my.buildsetting.MyBuildSettingPage;
import io.onedev.server.web.page.my.buildsetting.MySecretListPage;
+import io.onedev.server.web.page.project.ProjectListPage;
import io.onedev.server.web.page.security.LoginPage;
import io.onedev.server.web.page.security.LogoutPage;
import io.onedev.server.web.page.security.RegisterPage;
@@ -203,9 +205,28 @@ public abstract class LayoutPage extends BasePage {
item.add(new ViewStateAwarePageLink<Void>("link", MySecretListPage.class));
if (getPage() instanceof MyBuildSettingPage)
item.add(AttributeAppender.append("class", "active"));
-
- signedInContainer.add(new ViewStateAwarePageLink<Void>("signOut", LogoutPage.class));
+
+ if (SecurityUtils.getSubject().isRunAs()) {
+ Link<Void> signOutLink = new Link<Void>("signOut") {
+
+ @Override
+ public void onClick() {
+ SecurityUtils.getSubject().releaseRunAs();
+ Session.get().warn("Exited impersonation");
+ setResponsePage(ProjectListPage.class);
+ }
+
+ };
+ signOutLink.add(new Label("label", "Exit Impersonation"));
+ signedInContainer.add(signOutLink);
+ } else {
+ ViewStateAwarePageLink<Void> signOutLink = new ViewStateAwarePageLink<Void>("signOut", LogoutPage.class);
+ signOutLink.add(new Label("label", "Sign Out"));
+ signedInContainer.add(signOutLink);
+ }
+
signedInContainer.setVisible(loginUser != null);
+
if (getPage() instanceof MyPage)
signedInContainer.add(AttributeAppender.append("class", "active"));
diff --git a/server-core/src/main/java/io/onedev/server/web/page/test/TestPage.html b/server-core/src/main/java/io/onedev/server/web/page/test/TestPage.html
index 795b443f3a..9231f89b4b 100644
--- a/server-core/src/main/java/io/onedev/server/web/page/test/TestPage.html
+++ b/server-core/src/main/java/io/onedev/server/web/page/test/TestPage.html
@@ -1,3 +1,3 @@
<wicket:extend>
<a wicket:id="test">test</a>
-</wicket:extend>
\ No newline at end of file
+s</wicket:extend>
\ No newline at end of file