Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(OK): resolve + serve links to non-markdown files (PRD-6948) (#1698)

Andrew Mikofalvy00954f48903e
diff --git a/.changeset/asset-link-resolution-non-markdown.md b/.changeset/asset-link-resolution-non-markdown.md
new file mode 100644
index 000000000..44dd01cf3
--- /dev/null
+++ b/.changeset/asset-link-resolution-non-markdown.md
@@ -0,0 +1,9 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Fix links to non-markdown files rendering as "non-existent" (red) links even when the file exists.
+
+Links to HTML, GPX, XML, archive (`.7z`/`.tar`/`.rar`/…), legacy Office (`.doc`/`.xls`/`.ppt`), OpenDocument, iWork, and e-book files now resolve and serve like any other asset. The editor treats every non-markdown link target as an asset, but the set that governs indexing, serving, and link resolution previously omitted these types, so their links always showed as broken.
+
+`ASSET_EXTENSIONS` is now a superset of everything you can embed or link, enforced by a runtime guard so the two sets can't drift apart again. Newly admitted types are served as downloads (and open in the OS default app on desktop). HTML files are served inside a sandboxed, opaque origin (`Content-Security-Policy: sandbox allow-scripts; connect-src 'none'`): their scripts run so interactive documents work, but they can't read your knowledge base's cookies or storage, and `connect-src 'none'` blocks them from reaching the local API or exfiltrating over the network. On desktop, clicking an HTML link reveals it in Finder rather than failing silently.
diff --git a/packages/app/src/editor/asset-dispatch/dispatcher.test.ts b/packages/app/src/editor/asset-dispatch/dispatcher.test.ts
index 4ed669e0c..d153a29fc 100644
--- a/packages/app/src/editor/asset-dispatch/dispatcher.test.ts
+++ b/packages/app/src/editor/asset-dispatch/dispatcher.test.ts
@@ -94,24 +94,40 @@ describe('dispatchAssetClick', () => {
expect(openAsset).toHaveBeenCalledTimes(1);
});
- test('openAsset refusal is logged but does not throw or fall through to web', async () => {
+ test('extension-blocked refusal reveals the asset in the file manager (no web fallback)', async () => {
const openAsset = mock(
- async (_: string) =>
- ({
- ok: false,
- reason: 'extension-blocked',
- }) as const,
+ async (_: string) => ({ ok: false, reason: 'extension-blocked' }) as const,
);
+ const revealAsset = mock(async (_: string) => ({ ok: true }) as const);
const openUrl = mock((_: string) => {});
const desktopBridge = {
- shell: { openAsset },
+ shell: { openAsset, revealAsset },
+ } as unknown as NonNullable<typeof window.okDesktop>;
+
+ await dispatchAssetClick(ctx({ ext: 'html', projectRelPath: 'fishing-log/trip-viewer.html' }), {
+ desktopBridge,
+ openUrl,
+ });
+
+ expect(openAsset).toHaveBeenCalledTimes(1);
+ expect(revealAsset).toHaveBeenCalledTimes(1);
+ expect(revealAsset).toHaveBeenCalledWith('fishing-log/trip-viewer.html');
+ expect(openUrl).not.toHaveBeenCalled();
+ });
+
+ test('non-blocked refusal (resolve-error) is logged, does not reveal or fall through to web', async () => {
+ const openAsset = mock(async (_: string) => ({ ok: false, reason: 'resolve-error' }) as const);
+ const revealAsset = mock(async (_: string) => ({ ok: true }) as const);
+ const openUrl = mock((_: string) => {});
+ const desktopBridge = {
+ shell: { openAsset, revealAsset },
} as unknown as NonNullable<typeof window.okDesktop>;
const consoleWarn = mock((..._args: unknown[]) => {});
const origWarn = console.warn;
console.warn = consoleWarn as unknown as typeof console.warn;
try {
- await dispatchAssetClick(ctx({ ext: 'sh', projectRelPath: 'notes/setup.sh' }), {
+ await dispatchAssetClick(ctx({ ext: 'pdf', projectRelPath: 'notes/meeting.pdf' }), {
desktopBridge,
openUrl,
});
@@ -120,6 +136,7 @@ describe('dispatchAssetClick', () => {
}
expect(openAsset).toHaveBeenCalledTimes(1);
+ expect(revealAsset).not.toHaveBeenCalled();
expect(openUrl).not.toHaveBeenCalled();
expect(consoleWarn).toHaveBeenCalled();
});
diff --git a/packages/app/src/editor/asset-dispatch/dispatcher.ts b/packages/app/src/editor/asset-dispatch/dispatcher.ts
index 1ffdffece..3d4036a8a 100644
--- a/packages/app/src/editor/asset-dispatch/dispatcher.ts
+++ b/packages/app/src/editor/asset-dispatch/dispatcher.ts
@@ -30,6 +30,16 @@ export async function dispatchAssetClick(
if (desktopBridge) {
const result = await desktopBridge.shell.openAsset(ctx.projectRelPath);
if (!result.ok) {
+ if (result.reason === 'extension-blocked') {
+ const revealed = await desktopBridge.shell.revealAsset(ctx.projectRelPath);
+ if (!revealed.ok) {
+ console.warn('[asset-dispatch] revealAsset failed:', revealed.reason, {
+ projectRelPath: ctx.projectRelPath,
+ ext: ctx.ext,
+ });
+ }
+ return;
+ }
console.warn('[asset-dispatch] openAsset refused:', result.reason, {
projectRelPath: ctx.projectRelPath,
ext: ctx.ext,
diff --git a/packages/cli/src/commands/ui.test.ts b/packages/cli/src/commands/ui.test.ts
index a90d454f9..bd6e9b40c 100644
--- a/packages/cli/src/commands/ui.test.ts
+++ b/packages/cli/src/commands/ui.test.ts
@@ -700,16 +700,36 @@ describe('startUiServer', () => {
expect(headers.get('x-content-type-options')).toBe('nosniff');
});
- test('asset serve: scripted-document extension is not served from contentDir', async () => {
+ test('asset serve: content .html is served only inside a sandbox CSP (stored-XSS defense)', async () => {
const fs = await import('node:fs');
const seedDoc = resolve(tmpDir, 'doc.md');
fs.writeFileSync(seedDoc, '# seed', 'utf-8');
- const seedHtml = resolve(tmpDir, 'evil.html');
- fs.writeFileSync(seedHtml, '<script>alert(1)</script>', 'utf-8');
+ const seedHtml = resolve(tmpDir, 'viewer.html');
+ fs.writeFileSync(seedHtml, '<h1>viewer</h1><script>alert(1)</script>', 'utf-8');
handle = await startUiServer({ config: config(), cwd: tmpDir, port: 0, host: 'localhost' });
- const { body } = await get(handle.port, '/evil.html');
- expect(body).not.toContain('<script>alert(1)</script>');
+ const { status, headers } = await get(handle.port, '/viewer.html');
+ expect(status).toBe(200);
+ expect(headers.get('content-disposition')).toBe('inline');
+ expect(headers.get('content-security-policy')).toBe(
+ "sandbox allow-scripts; connect-src 'none'",
+ );
+ expect(headers.get('x-content-type-options')).toBe('nosniff');
+ });
+
+ test('asset serve: SPA app shell (/index.html miss) is NOT sandboxed', async () => {
+ const dist = seedDist(tmpDir, 'noshell');
+ handle = await startUiServer({
+ config: config(),
+ cwd: tmpDir,
+ port: 0,
+ host: 'localhost',
+ assetDir: dist,
+ });
+ const { status, headers } = await get(handle.port, '/index.html');
+ expect(status).toBe(200);
+ expect(headers.get('content-security-policy')).toBeNull();
+ expect(headers.get('content-disposition')).toBeNull();
});
test('/api/* gate rejects requests with non-loopback Host header (DNS-rebind defense)', async () => {
diff --git a/packages/core/src/constants/upload.test.ts b/packages/core/src/constants/upload.test.ts
index 0049fa3bf..a290dac4c 100644
--- a/packages/core/src/constants/upload.test.ts
+++ b/packages/core/src/constants/upload.test.ts
@@ -72,6 +72,18 @@ describe('upload extension sets', () => {
expect(AUDIO_EXTENSIONS.has(ext)).toBe(false);
}
});
+
+ test('WIKI_EMBED_EXTENSIONS ⊆ ASSET_EXTENSIONS (embeddable ⇒ servable + resolvable)', () => {
+ for (const ext of WIKI_EMBED_EXTENSIONS) {
+ expect(ASSET_EXTENSIONS.has(ext)).toBe(true);
+ }
+ });
+
+ test('ASSET_EXTENSIONS admits user-linked non-embed types (html/htm/gpx)', () => {
+ expect(ASSET_EXTENSIONS.has('html')).toBe(true);
+ expect(ASSET_EXTENSIONS.has('htm')).toBe(true);
+ expect(ASSET_EXTENSIONS.has('gpx')).toBe(true);
+ });
});
describe('mediaKindForSidebarAssetExtension', () => {
diff --git a/packages/core/src/constants/upload.ts b/packages/core/src/constants/upload.ts
index a925df739..dce9b1072 100644
--- a/packages/core/src/constants/upload.ts
+++ b/packages/core/src/constants/upload.ts
@@ -153,6 +153,10 @@ export const ASSET_EXTENSIONS: ReadonlySet<string> = new Set([
'aac',
'opus',
'zip',
+ '7z',
+ 'tar',
+ 'gz',
+ 'rar',
'woff',
'woff2',
'ttf',
@@ -161,14 +165,36 @@ export const ASSET_EXTENSIONS: ReadonlySet<string> = new Set([
'docx',
'xlsx',
'pptx',
+ 'doc',
+ 'xls',
+ 'ppt',
+ 'odt',
+ 'ods',
+ 'odp',
+ 'pages',
+ 'numbers',
+ 'key',
+ 'epub',
+ 'mobi',
'csv',
+ 'tsv',
'txt',
'rtf',
'json',
+ 'yaml',
+ 'yml',
+ 'xml',
'toml',
'lock',
+ 'gpx',
+ 'html',
+ 'htm',
]);
+export const SANDBOXED_HTML_EXTENSIONS: ReadonlySet<string> = new Set(['html', 'htm']);
+
+export const SANDBOXED_HTML_CSP = "sandbox allow-scripts; connect-src 'none'";
+
export const INLINE_RENDERABLE_EXTENSIONS: ReadonlySet<string> = new Set([
'png',
'jpg',
@@ -288,6 +314,7 @@ assertSubset('SIDEBAR_VIDEO_ASSET_EXTENSIONS', SIDEBAR_VIDEO_EXTENSIONS, VIDEO_E
assertSubset('SIDEBAR_AUDIO_ASSET_EXTENSIONS', SIDEBAR_AUDIO_EXTENSIONS, AUDIO_EXTENSIONS);
assertSubset('SIDEBAR_PDF_ASSET_EXTENSIONS', SIDEBAR_PDF_EXTENSIONS, PDF_EXTENSIONS);
assertSubset('FILE_ATTACHMENT_EXTENSIONS', [...FILE_ATTACHMENT_EXTENSIONS], WIKI_EMBED_EXTENSIONS);
+assertSubset('WIKI_EMBED_EXTENSIONS', [...WIKI_EMBED_EXTENSIONS], ASSET_EXTENSIONS);
export const SIDEBAR_IMAGE_ASSET_EXTENSIONS: ReadonlySet<string> = new Set(
SIDEBAR_IMAGE_EXTENSIONS,
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
index 8ac9ffd90..ad08b485a 100644
--- a/packages/core/src/index.ts
+++ b/packages/core/src/index.ts
@@ -216,6 +216,8 @@ export {
LINKABLE_ASSET_EXTENSIONS,
mediaKindForSidebarAssetExtension,
PDF_EXTENSIONS,
+ SANDBOXED_HTML_CSP,
+ SANDBOXED_HTML_EXTENSIONS,
SIDEBAR_AUDIO_ASSET_EXTENSIONS,
SIDEBAR_IMAGE_ASSET_EXTENSIONS,
SIDEBAR_PDF_ASSET_EXTENSIONS,
diff --git a/packages/desktop/src/main/asset-safety-net.ts b/packages/desktop/src/main/asset-safety-net.ts
index d5ee3c238..c0bc88dab 100644
--- a/packages/desktop/src/main/asset-safety-net.ts
+++ b/packages/desktop/src/main/asset-safety-net.ts
@@ -47,6 +47,7 @@ export function matchAssetUrl(url: string, editorOrigin: string): string | null
const extMatch = lastSegment.match(/\.([a-z0-9]+)$/i);
if (!extMatch) return null;
const ext = (extMatch[1] ?? '').toLowerCase();
+ if (ext === 'html' || ext === 'htm') return null;
if (!ASSET_EXTENSIONS.has(ext)) return null;
return path;
diff --git a/packages/desktop/tests/main/asset-safety-net.test.ts b/packages/desktop/tests/main/asset-safety-net.test.ts
index fda263565..be91dc8a5 100644
--- a/packages/desktop/tests/main/asset-safety-net.test.ts
+++ b/packages/desktop/tests/main/asset-safety-net.test.ts
@@ -24,6 +24,11 @@ describe('matchAssetUrl', () => {
expect(matchAssetUrl('http://localhost:5173/index.html', ORIGIN)).toBeNull();
});
+ test('content html/htm → null (handled by the renderer dispatcher, not the safety net)', () => {
+ expect(matchAssetUrl('http://localhost:5173/fishing-log/trip-viewer.html', ORIGIN)).toBeNull();
+ expect(matchAssetUrl('http://localhost:5173/notes/legacy.htm', ORIGIN)).toBeNull();
+ });
+
test('app bundle without explicit path → null', () => {
expect(matchAssetUrl('http://localhost:5173/', ORIGIN)).toBeNull();
});
diff --git a/packages/server/src/api-asset.test.ts b/packages/server/src/api-asset.test.ts
index 571299789..77f56d398 100644
--- a/packages/server/src/api-asset.test.ts
+++ b/packages/server/src/api-asset.test.ts
@@ -67,7 +67,12 @@ describe('GET /api/asset', () => {
);
writeFileSync(join(contentDir, 'docs', 'data.csv'), 'a,b\n1,2\n');
writeFileSync(join(contentDir, 'docs', 'notes.txt'), 'not renderable');
- writeFileSync(join(contentDir, 'docs', 'page.html'), '<h1>not admitted</h1>');
+ writeFileSync(
+ join(contentDir, 'docs', 'page.html'),
+ '<h1>trip viewer</h1><script>alert("x")</script>',
+ );
+ writeFileSync(join(contentDir, 'docs', 'legacy.htm'), '<h1>legacy</h1>');
+ writeFileSync(join(contentDir, 'docs', 'script.js'), 'alert(1)');
mkdirSync(join(contentDir, 'docs', 'directory.png'));
writeFileSync(join(tmpDir, 'outside.png'), 'outside');
symlinkSync(join(tmpDir, 'outside.png'), join(contentDir, 'docs', 'escape.png'));
@@ -131,11 +136,26 @@ describe('GET /api/asset', () => {
});
test('rejects unsupported extensions even when they have a known content type', async () => {
- const res = await fetch(assetUrl(harness.baseURL, 'docs/page.html'));
+ const res = await fetch(assetUrl(harness.baseURL, 'docs/script.js'));
expect(res.status).toBe(415);
});
+ test.each([
+ 'docs/page.html',
+ 'docs/legacy.htm',
+ ])('serves %s inside a sandboxed opaque origin (scripts run, network blocked, isolated from OK)', async (assetPath) => {
+ const res = await fetch(assetUrl(harness.baseURL, assetPath));
+
+ expect(res.status).toBe(200);
+ expect(res.headers.get('content-type')).toMatch(/^text\/html/);
+ expect(res.headers.get('content-disposition')).toBe('inline');
+ expect(res.headers.get('content-security-policy')).toBe(
+ "sandbox allow-scripts; connect-src 'none'",
+ );
+ expect(res.headers.get('x-content-type-options')).toBe('nosniff');
+ });
+
test('rejects traversal and symlink escapes', async () => {
expect((await fetch(assetUrl(harness.baseURL, '../outside.png'))).status).toBe(400);
expect((await fetch(assetUrl(harness.baseURL, 'docs/escape.png'))).status).toBe(400);
diff --git a/packages/server/src/api-extension.ts b/packages/server/src/api-extension.ts
index 1f2394305..b1afdb666 100644
--- a/packages/server/src/api-extension.ts
+++ b/packages/server/src/api-extension.ts
@@ -123,6 +123,8 @@ import {
RollbackRequestSchema,
RollbackSuccessSchema,
readFmMap,
+ SANDBOXED_HTML_CSP,
+ SANDBOXED_HTML_EXTENSIONS,
SaveVersionRequestSchema,
SaveVersionSuccessSchema,
SearchRequestSchema,
@@ -6028,18 +6030,20 @@ export function createApiExtension(options: ApiExtensionOptions): Extension {
});
return;
}
+ const isSandboxedHtml = SANDBOXED_HTML_EXTENSIONS.has(assetExt);
const headers: Record<string, string> = {
'Content-Type': contentType,
'Content-Length': String(stat.size),
'X-Content-Type-Options': 'nosniff',
- 'Content-Disposition': INLINE_RENDERABLE_EXTENSIONS.has(assetExt)
- ? 'inline'
- : 'attachment',
+ 'Content-Disposition':
+ INLINE_RENDERABLE_EXTENSIONS.has(assetExt) || isSandboxedHtml ? 'inline' : 'attachment',
'Cache-Control': 'no-store',
};
if (assetExt === 'svg') {
headers['Content-Security-Policy'] =
"sandbox; default-src 'none'; style-src 'unsafe-inline'";
+ } else if (isSandboxedHtml) {
+ headers['Content-Security-Policy'] = SANDBOXED_HTML_CSP;
}
res.writeHead(200, headers);
try {
diff --git a/packages/server/src/asset-references.test.ts b/packages/server/src/asset-references.test.ts
index 4af06367b..873f24d03 100644
--- a/packages/server/src/asset-references.test.ts
+++ b/packages/server/src/asset-references.test.ts
@@ -326,6 +326,64 @@ describe('asset reference extraction', () => {
});
}));
+ test('collects referenced existing html / gpx / xml / 7z assets (PRD-6948)', () =>
+ withFixture((dir) => {
+ mkdirSync(join(dir, 'fishing-log'), { recursive: true });
+ writeFileSync(
+ join(dir, 'fishing-log', 'log.md'),
+ [
+ '[viewer](./trip-viewer.html)',
+ '[track](./Morning_Activity.gpx)',
+ '[data](./readings.xml)',
+ '[archive](./bundle.7z)',
+ '[photo](./photo.png)',
+ ].join('\n'),
+ );
+ for (const f of [
+ 'trip-viewer.html',
+ 'Morning_Activity.gpx',
+ 'readings.xml',
+ 'bundle.7z',
+ 'photo.png',
+ ]) {
+ writeFileSync(join(dir, 'fishing-log', f), 'x');
+ }
+ const now = new Date().toISOString();
+ const fileIndex = new Map<string, FileIndexEntry>([
+ [
+ 'fishing-log/log',
+ {
+ size: 1,
+ modified: now,
+ canonicalPath: join(dir, 'fishing-log/log.md'),
+ inode: 1,
+ aliases: [],
+ },
+ ],
+ ]);
+
+ const assets = collectReferencedAssets({
+ contentDir: dir,
+ fileIndex,
+ readMarkdown: () =>
+ [
+ '[viewer](./trip-viewer.html)',
+ '[track](./Morning_Activity.gpx)',
+ '[data](./readings.xml)',
+ '[archive](./bundle.7z)',
+ '[photo](./photo.png)',
+ ].join('\n'),
+ });
+ const paths = assets.map((a) => a.path).sort();
+ expect(paths).toEqual([
+ 'fishing-log/Morning_Activity.gpx',
+ 'fishing-log/bundle.7z',
+ 'fishing-log/photo.png',
+ 'fishing-log/readings.xml',
+ 'fishing-log/trip-viewer.html',
+ ]);
+ }));
+
test('returns empty asset list when content directory cannot be resolved', () => {
const warnSpy = spyOn(console, 'warn').mockImplementation(() => {});
try {
diff --git a/packages/server/src/asset-serve-middleware.test.ts b/packages/server/src/asset-serve-middleware.test.ts
index 80c9b9c2d..bcaf78cfa 100644
--- a/packages/server/src/asset-serve-middleware.test.ts
+++ b/packages/server/src/asset-serve-middleware.test.ts
@@ -28,6 +28,9 @@ function makeRes(): { res: ServerResponse; captured: CapturedResponse } {
setHeader(name: string, value: string) {
captured.headers[name] = value;
},
+ removeHeader(name: string) {
+ delete captured.headers[name];
+ },
writeHead(status: number, headers?: Record<string, string>) {
captured.status = status;
captured.headersSent = true;
@@ -61,8 +64,8 @@ const admitAll: AssetServeFilter = { isPathIgnored: () => false };
const excludeAll: AssetServeFilter = { isPathIgnored: () => true };
const INLINE = new Set(['png', 'jpg', 'pdf', 'mp4', 'm4v', 'svg']);
-const ASSETS = new Set([...INLINE, 'docx', 'csv', 'json', 'txt', 'zip']);
-const BLOCKLIST = new Set(['exe', 'dmg', 'sh', 'html']);
+const ASSETS = new Set([...INLINE, 'docx', 'csv', 'json', 'txt', 'zip', 'html', 'htm']);
+const BLOCKLIST = new Set(['exe', 'dmg', 'sh', 'html', 'htm']);
function buildMiddleware(sirv: SirvLikeMiddleware, filter: AssetServeFilter = admitAll) {
return createAssetServeMiddleware({
@@ -140,6 +143,28 @@ describe('createAssetServeMiddleware', () => {
);
expect(captured.headers['X-Content-Type-Options']).toBe('nosniff');
});
+
+ test('html gets `inline` + sandboxed CSP (opaque origin, no network, no plain inline)', () => {
+ const middleware = buildMiddleware(sirvServes);
+ const { res, captured } = makeRes();
+ middleware(makeReq('/trip-viewer.html'), res, () => {});
+ expect(captured.headers['Content-Disposition']).toBe('inline');
+ expect(captured.headers['Content-Security-Policy']).toBe(
+ "sandbox allow-scripts; connect-src 'none'",
+ );
+ expect(captured.headers['X-Content-Type-Options']).toBe('nosniff');
+ expect(captured.headers['Cache-Control']).toBe('no-store');
+ });
+
+ test('htm is handled identically to html', () => {
+ const middleware = buildMiddleware(sirvServes);
+ const { res, captured } = makeRes();
+ middleware(makeReq('/legacy.htm'), res, () => {});
+ expect(captured.headers['Content-Disposition']).toBe('inline');
+ expect(captured.headers['Content-Security-Policy']).toBe(
+ "sandbox allow-scripts; connect-src 'none'",
+ );
+ });
});
describe('.md / .mdx doc-ext bypass', () => {
@@ -179,6 +204,21 @@ describe('createAssetServeMiddleware', () => {
expect(nextCalled).toBe(false);
});
+ test('html MISS falls through clean (no 404, and sandbox CSP stripped) so the SPA shell serves', () => {
+ let nextCalled = false;
+ const middleware = buildMiddleware(sirvFallThrough);
+ const { res, captured } = makeRes();
+ middleware(makeReq('/index.html'), res, () => {
+ nextCalled = true;
+ });
+ expect(nextCalled).toBe(true);
+ expect(captured.status).not.toBe(404);
+ expect(captured.headers['Content-Security-Policy']).toBeUndefined();
+ expect(captured.headers['Content-Disposition']).toBeUndefined();
+ expect(captured.headers['X-Content-Type-Options']).toBeUndefined();
+ expect(captured.headers['Cache-Control']).toBeUndefined();
+ });
+
test('EXECUTABLE_BLOCKLIST extension (not also an asset extension) falls through to next() before sirv', () => {
let nextCalled = false;
const middleware = buildMiddleware(sirvFallThrough);
diff --git a/packages/server/src/asset-serve-middleware.ts b/packages/server/src/asset-serve-middleware.ts
index 74f7a3917..947b3ae34 100644
--- a/packages/server/src/asset-serve-middleware.ts
+++ b/packages/server/src/asset-serve-middleware.ts
@@ -1,5 +1,6 @@
import type { IncomingMessage, ServerResponse } from 'node:http';
import { extname } from 'node:path';
+import { SANDBOXED_HTML_CSP, SANDBOXED_HTML_EXTENSIONS } from '@inkeep/open-knowledge-core';
import { mimes } from 'mrmime';
Object.assign(mimes, {
@@ -8,6 +9,18 @@ Object.assign(mimes, {
flac: 'audio/flac',
toml: 'application/toml',
lock: 'text/plain',
+ '7z': 'application/x-7z-compressed',
+ tar: 'application/x-tar',
+ rar: 'application/vnd.rar',
+ xls: 'application/vnd.ms-excel',
+ ppt: 'application/vnd.ms-powerpoint',
+ odt: 'application/vnd.oasis.opendocument.text',
+ ods: 'application/vnd.oasis.opendocument.spreadsheet',
+ odp: 'application/vnd.oasis.opendocument.presentation',
+ pages: 'application/vnd.apple.pages',
+ numbers: 'application/vnd.apple.numbers',
+ key: 'application/vnd.apple.keynote',
+ mobi: 'application/x-mobipocket-ebook',
});
export function assetContentTypeForPath(path: string): string | null {
@@ -50,8 +63,9 @@ export function createAssetServeMiddleware(
if (!rel || contentFilter.isPathIgnored(rel) || (!isDocExt && !assetExtensions.has(ext)))
return next();
res.setHeader('X-Content-Type-Options', 'nosniff');
+ const isSandboxedHtml = SANDBOXED_HTML_EXTENSIONS.has(ext);
if (!isDocExt) {
- if (inlineExtensions.has(ext)) {
+ if (inlineExtensions.has(ext) || isSandboxedHtml) {
res.setHeader('Content-Disposition', 'inline');
} else {
res.setHeader('Content-Disposition', 'attachment');
@@ -62,14 +76,24 @@ export function createAssetServeMiddleware(
'Content-Security-Policy',
"sandbox; default-src 'none'; style-src 'unsafe-inline'",
);
+ } else if (isSandboxedHtml) {
+ res.setHeader('Content-Security-Policy', SANDBOXED_HTML_CSP);
+ res.setHeader('Cache-Control', 'no-store');
}
contentSirv(req, res, () => {
if (res.headersSent) return;
- if (assetExtensions.has(ext) || blocklistExtensions.has(ext)) {
+ const isHtml = SANDBOXED_HTML_EXTENSIONS.has(ext);
+ if (!isHtml && (assetExtensions.has(ext) || blocklistExtensions.has(ext))) {
res.statusCode = 404;
res.end();
return;
}
+ if (isHtml) {
+ res.removeHeader('Content-Security-Policy');
+ res.removeHeader('Content-Disposition');
+ res.removeHeader('X-Content-Type-Options');
+ res.removeHeader('Cache-Control');
+ }
next();
});
};
diff --git a/packages/server/src/content-filter.test.ts b/packages/server/src/content-filter.test.ts
index 032270b12..253e4c4f7 100644
--- a/packages/server/src/content-filter.test.ts
+++ b/packages/server/src/content-filter.test.ts
@@ -1160,18 +1160,16 @@ describe('ContentFilter', () => {
expect(filter.isExcluded('apps/web/dist/index.md', { bypassFilters: true })).toBe(false);
});
- test('admits non-md/non-asset extensions (.ts, .py, .sh, .yaml)', () => {
+ test('admits non-md/non-asset extensions (.ts, .py, .sh) only under bypass', () => {
const filter = createContentFilter({ projectDir, contentDir: projectDir });
expect(filter.isExcluded('src/index.ts')).toBe(true);
expect(filter.isExcluded('scripts/build.sh')).toBe(true);
expect(filter.isExcluded('analysis.py')).toBe(true);
- expect(filter.isExcluded('config.yaml')).toBe(true);
expect(filter.isExcluded('src/index.ts', { bypassFilters: true })).toBe(false);
expect(filter.isExcluded('scripts/build.sh', { bypassFilters: true })).toBe(false);
expect(filter.isExcluded('analysis.py', { bypassFilters: true })).toBe(false);
- expect(filter.isExcluded('config.yaml', { bypassFilters: true })).toBe(false);
});
test('STOP rule preserved — reserved system + config doc names stay hidden in bypass mode', () => {