Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(ok): drop the assembly mode from point-release announcement notes (#3314)

Andrew Mikofalvy08cdf5d1b7b3
diff --git a/.github/scripts/point-release-plan.mjs b/.github/scripts/point-release-plan.mjs
index 6aadd6844..2b459da37 100644
--- a/.github/scripts/point-release-plan.mjs
+++ b/.github/scripts/point-release-plan.mjs
@@ -1077,7 +1077,10 @@ export function formatReleaseNotes(plan) {
`Point release over ${plan.latestStableTag}: the current stable plus ${plan.fixRefs.length} applied ` +
`commit(s), isolated from the changes still soaking on main.`,
'',
- `Mode: ${plan.mode}`,
+ // No `Mode:` line. Whether the operator reached this stable by cherry-pick
+ // or by revert is release mechanics; it reads as noise in the Slack and
+ // Discord announcements, which inline this body verbatim. The workflow run
+ // summary still records the mode for whoever is auditing the lane.
// `ref (sha)` is only worth printing when the ref is a NAME — a tag or
// branch the reader cannot resolve themselves. The bug lane dispatches
// full SHAs, where `ref` and `sha` are the same 40 characters and the
diff --git a/.github/scripts/point-release-plan.test.mjs b/.github/scripts/point-release-plan.test.mjs
index fe887548a..b051ded3b 100644
--- a/.github/scripts/point-release-plan.test.mjs
+++ b/.github/scripts/point-release-plan.test.mjs
@@ -807,6 +807,21 @@ describe('runPointRelease cascade', () => {
expect(notes).not.toContain('Changesets added:');
});
+ test('the release notes leave the assembly mode out of the announced body', () => {
+ // Slack and Discord inline this body verbatim, and how the operator
+ // assembled the stable is not something a reader of the announcement acts
+ // on. The workflow run summary keeps the mode for the audit trail.
+ const picked = cherryPickIo();
+ runPointRelease({ mode: 'cherry-pick', fixRefs: ['fix1'], dryRun: false }, picked);
+ expect(picked.releases[0].notes).not.toMatch(/^Mode:/m);
+ expect(picked.releases[0].notes).not.toContain('cherry-pick');
+
+ const reverted = makeIo();
+ runPointRelease({ mode: 'revert', fixRefs: ['bad1'], dryRun: false }, reverted);
+ expect(reverted.releases[0].notes).not.toMatch(/^Mode:/m);
+ expect(reverted.releases[0].notes).not.toContain('revert');
+ });
+
test('an unreadable changeset degrades its notes entry to the id rather than refusing', () => {
const io = makeIo({
changesets: {