Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
feat(acp): tab strip gets unread pulse, per-thread tint, cleaner titles (PRD-8021) (#3868)
Abraham172ea541160a
diff --git a/.changeset/prd-8021-acp-tab-strip-indicator-identity.md b/.changeset/prd-8021-acp-tab-strip-indicator-identity.mdnew file mode 100644index 000000000..d04f3a4dc--- /dev/null+++ b/.changeset/prd-8021-acp-tab-strip-indicator-identity.md@@ -0,0 +1,9 @@+---+"@inkeep/open-knowledge": patch+---++Agent tabs are easier to tell apart. Three changes to the tab strip:++- **Unread indicator.** A settled `ready` tab whose transcript advanced while you were on a different tab now pulses its status dot until you click into it — no more "did that other agent finish yet?" polling.+- **Per-thread identity.** Every thread gets a stable, hashed tint ring around its agent icon, so a row of Claude tabs isn't just "same icon, truncated title" — each thread has a persistent visual anchor.+- **Better auto-titles.** The tab title now strips a leading agent-name *address* (`Claude, what's 2+2?` → `What's 2+2?`, but `Codex is failing to start` passes through unchanged), plus punctuation the prompt itself opens with (`— refactor the parser` → `Refactor the parser`), so the distinguishing words land at the start of the label.diff --git a/knip.config.ts b/knip.config.tsindex b61debe5e..8ad68f996 100644--- a/knip.config.ts+++ b/knip.config.ts@@ -124,7 +124,9 @@ export default {'packages/server': {entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],project: 'src/**',- ignoreDependencies: ['@types/shell-quote'],+ ignoreDependencies: [+ '@types/shell-quote',+ ],},'packages/cli': {entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],diff --git a/packages/app/src/components/SessionsHost.agents.dom.test.tsx b/packages/app/src/components/SessionsHost.agents.dom.test.tsxindex cb9d2cf04..32515c652 100644--- a/packages/app/src/components/SessionsHost.agents.dom.test.tsx+++ b/packages/app/src/components/SessionsHost.agents.dom.test.tsx@@ -88,7 +88,17 @@ vi.doMock('@/lib/acp/thread-client', () => ({() => connectionStatus,() => connectionStatus,),- getAgentThreadClient: () => ({ closeThread, renameThread, openArchivedThread, deleteThread }),+ // Unread affordance is orthogonal to the agents-panel tests; the tab-strip+ // renders both a stable per-thread tint and the unread pulse from this+ // hook, so it just has to exist and return `false` for these fixtures.+ useAgentThreadUnread: () => false,+ getAgentThreadClient: () => ({+ closeThread,+ renameThread,+ openArchivedThread,+ deleteThread,+ markThreadViewed: () => {},+ }),}));// ThreadView is lazy-loaded by the host; stub it (with the composer focus hook).diff --git a/packages/app/src/components/SessionsHost.tsx b/packages/app/src/components/SessionsHost.tsxindex c7555631d..fa33c2971 100644--- a/packages/app/src/components/SessionsHost.tsx+++ b/packages/app/src/components/SessionsHost.tsx@@ -41,6 +41,7 @@ import {import {getAgentThreadClient,useAgentThreadConnection,+ useAgentThreadUnread,useArchivedAgentThreads,useOpenAgentThreadTabs,} from '@/lib/acp/thread-client';@@ -214,10 +215,56 @@ function terminalTabIcon(): ReactNode {);}-/** The agent avatar + live status dot the strip shows before a thread tab's label. */-function threadTabIcon(info: ThreadInfo | undefined): ReactNode {+/**+ * Palette of per-thread tint ring colors — a fixed 8-hue set so identical+ * hashes always land on identical colors and Tailwind's JIT can see every+ * class up front. Small (`ring-1`) to stay quiet against the tab surface.+ *+ * Chosen to be DISJOINT from the status-dot palette in `threadStatusDotClass`+ * (rose/red = error, amber = running/blocked, emerald = ready, sky =+ * installing) so identity tint and lifecycle status read as two independent+ * channels inside the same 14px cluster. A "blocked" amber dot next to an+ * amber identity ring reads as pure alarm.+ */+const THREAD_TINT_RINGS: readonly string[] = [+ 'ring-violet-400/60',+ 'ring-fuchsia-400/60',+ 'ring-pink-400/60',+ 'ring-cyan-400/60',+ 'ring-teal-400/60',+ 'ring-lime-400/60',+ 'ring-yellow-400/60',+ 'ring-stone-400/60',+];++/** Deterministic djb2 hash → palette index. Same threadId → same tint. */+function threadTintClass(threadId: string): string {+ let hash = 5381;+ for (let i = 0; i < threadId.length; i++) {+ hash = ((hash << 5) + hash + threadId.charCodeAt(i)) >>> 0;+ }+ return THREAD_TINT_RINGS[hash % THREAD_TINT_RINGS.length] ?? 'ring-transparent';+}++/**+ * The agent avatar + live status dot the strip shows before a thread tab's+ * label. Reads its own reactive "unread since last view" flag so a settled+ * `ready` tab can pulse when a background reply lands. A stable per-thread+ * tint ring gives each thread a persistent visual identity so a strip of+ * "Claude" tabs no longer relies on truncated title text alone.+ */+function ThreadTabIcon({+ info,+ threadId,+}: {+ info: ThreadInfo | undefined;+ threadId: string;+}): ReactNode {+ const unread = useAgentThreadUnread(threadId);return (- <span className="relative inline-flex shrink-0">+ <span+ className={cn('relative inline-flex shrink-0 rounded-full ring-1', threadTintClass(threadId))}+ ><RegisteredAgentIconagentId={info?.agent.id ?? ''}iconUrl={info?.agent.iconUrl}@@ -228,6 +275,10 @@ function threadTabIcon(info: ThreadInfo | undefined): ReactNode {className={cn('-right-0.5 -bottom-0.5 absolute size-1.5 rounded-full ring-1 ring-background',threadStatusDotClass(info.status),+ // A settled tab whose activity outran the last view pulses the+ // dot — the running/blocked states already carry their own+ // pulse via `threadStatusDotClass`, so we only opt in on ready.+ unread && info.status === 'ready' && 'animate-pulse',)}aria-hidden="true"/>@@ -1631,13 +1682,34 @@ export function SessionsHost({if (active != null) focusSession(active);}, [isShowing]);+ // Mark the active thread tab as viewed — clears its "unread since last view"+ // pulse. Fires on tab activation AND on incoming activity while the tab is+ // already active (so ongoing chatter doesn't accumulate a stale unread+ // flag). Skipped while the whole panel is hidden — activity that lands+ // then is genuinely unread until the panel re-reveals.+ const activeThreadIdForView = (() => {+ const active = sessions.find((s) => s.id === activeSessionId);+ return active?.kind === 'thread' ? active.threadId : null;+ })();+ const activeThreadInfoForView =+ activeThreadIdForView !== null ? threadInfoById.get(activeThreadIdForView) : undefined;+ const activeThreadActivityAt = activeThreadInfoForView?.lastActivityAt ?? null;+ const activeThreadStatus = activeThreadInfoForView?.status ?? null;+ // biome-ignore lint/correctness/useExhaustiveDependencies: `activeThreadActivityAt` and `activeThreadStatus` are not read inside the effect body — they are dep-only, so an incoming activity tick OR a status transition (running → ready without a fresh activityAt) both re-fire the mark-viewed call. Without the status dep, a ready-flip on an unchanged activityAt would leave the tab pulsing forever.+ useEffect(() => {+ if (!isShowing || activeThreadIdForView === null) return;+ getAgentThreadClient().markThreadViewed(activeThreadIdForView);+ }, [activeThreadIdForView, activeThreadActivityAt, activeThreadStatus, isShowing]);+const tabDescriptors: TerminalTabDescriptor[] = sessions.map((session) => ({id: session.id,label: sessionLabel(session),icon:- session.kind === 'terminal'- ? terminalTabIcon()- : threadTabIcon(threadInfoById.get(session.threadId)),+ session.kind === 'terminal' ? (+ terminalTabIcon()+ ) : (+ <ThreadTabIcon info={threadInfoById.get(session.threadId)} threadId={session.threadId} />+ ),}));// Panels render in STABLE order (by immutable ordinal), decoupled from tab order:diff --git a/packages/app/src/lib/acp/thread-client.test.ts b/packages/app/src/lib/acp/thread-client.test.tsindex 4b6f8b854..350ee1a7d 100644--- a/packages/app/src/lib/acp/thread-client.test.ts+++ b/packages/app/src/lib/acp/thread-client.test.ts@@ -354,3 +354,133 @@ describe('store hooks return the useSyncExternalStore subscription value (React});}});++describe('unread affordance (PRD-8021)', () => {+ const info: ThreadInfo = {+ threadId: 't-unread',+ agent: { id: 'a', name: 'A', source: 'custom' },+ title: 'A',+ status: 'ready',+ createdAt: 1,+ lastActivityAt: 100,+ modes: null,+ configOptions: null,+ lastSeq: -1,+ };++ function boot(): {+ client: AgentThreadClient;+ bump: (nextInfo: ThreadInfo) => void;+ } {+ const client = new AgentThreadClient();+ const internals = client as unknown as { handleFrame: (f: ThreadServerFrame) => void };+ internals.handleFrame.call(client, {+ op: 'subscribed',+ threadId: info.threadId,+ fromSeq: 0,+ info,+ });+ return {+ client,+ bump: (nextInfo) =>+ internals.handleFrame.call(client, {+ op: 'info',+ threadId: nextInfo.threadId,+ info: nextInfo,+ }),+ };+ }++ test('a fresh subscription seeds the floor to lastActivityAt — no unread pulse on reload', () => {+ // Contract: the pulse means "advanced while you were elsewhere in+ // THIS window session", not "you just reloaded". The floor is seeded+ // to whatever activity the thread already had when we first learned+ // about it, so a renderer reload does not fabricate an unread state+ // for every idle ready tab.+ const { client } = boot();+ expect(client.getThreadUnread(info.threadId)).toBe(false);+ });++ test('marks unread only after activity advances past the initial floor', () => {+ const { client, bump } = boot();+ // Fresh state (floor seeded): no unread.+ expect(client.getThreadUnread(info.threadId)).toBe(false);+ // Activity moves — unread turns on.+ bump({ ...info, lastActivityAt: 200 });+ expect(client.getThreadUnread(info.threadId)).toBe(true);+ // Viewing clears it until the next bump.+ client.markThreadViewed(info.threadId);+ expect(client.getThreadUnread(info.threadId)).toBe(false);+ bump({ ...info, lastActivityAt: 300 });+ expect(client.getThreadUnread(info.threadId)).toBe(true);+ });++ test('only settled `ready` tabs report unread — a running turn already pulses via its status dot', () => {+ const { client, bump } = boot();+ client.markThreadViewed(info.threadId);+ bump({ ...info, lastActivityAt: 200, status: 'running' });+ expect(client.getThreadUnread(info.threadId)).toBe(false);+ bump({ ...info, lastActivityAt: 200, status: 'ready' });+ expect(client.getThreadUnread(info.threadId)).toBe(true);+ });++ test('unknown thread reports false and never throws', () => {+ const { client } = boot();+ expect(client.getThreadUnread('not-a-thread')).toBe(false);+ // idempotent no-op on unknown ids+ client.markThreadViewed('not-a-thread');+ expect(client.getThreadUnread('not-a-thread')).toBe(false);+ });++ test('a redundant markThreadViewed does not bump the store', () => {+ const { client } = boot();+ client.markThreadViewed(info.threadId);+ let notifications = 0;+ client.subscribe(() => {+ notifications += 1;+ });+ client.markThreadViewed(info.threadId);+ expect(notifications).toBe(0);+ });++ test('mark-viewed on ready flip with unchanged activityAt clears unread', () => {+ // Reviewer regression: a `running → ready` transition may carry no+ // fresh activityAt (an info frame that only flips status). The+ // SessionsHost effect keys on status changes too, so markThreadViewed+ // must still clear unread when the caller re-fires on that flip.+ const { client, bump } = boot();+ bump({ ...info, lastActivityAt: 200 });+ expect(client.getThreadUnread(info.threadId)).toBe(true);+ // Running interlude — activityAt stays at 200.+ bump({ ...info, status: 'running', lastActivityAt: 200 });+ client.markThreadViewed(info.threadId); // no-op under running+ expect(client.getThreadUnread(info.threadId)).toBe(false); // running always reads false+ // Flip back to ready with the SAME activityAt.+ bump({ ...info, status: 'ready', lastActivityAt: 200 });+ // Mark once more (what the effect's status-dep firing does).+ client.markThreadViewed(info.threadId);+ expect(client.getThreadUnread(info.threadId)).toBe(false);+ });++ test('markThreadViewed is a no-op while the thread is `running` — no bump storm during streaming', () => {+ // The SessionsHost mark-viewed effect keys on lastActivityAt, which+ // every streaming event bumps. If markThreadViewed also bumped for+ // each of those, the version-keyed snapshot cache would invalidate+ // once per event and every store subscriber would re-render. The+ // guard collapses those to zero bumps until the turn settles.+ const { client, bump } = boot();+ bump({ ...info, status: 'running', lastActivityAt: 200 });+ let notifications = 0;+ client.subscribe(() => {+ notifications += 1;+ });+ // Simulate five streaming batches, mark-viewed after each.+ for (let i = 1; i <= 5; i++) {+ bump({ ...info, status: 'running', lastActivityAt: 200 + i * 10 });+ client.markThreadViewed(info.threadId);+ }+ // The bumps from `bump()` are the 5 activity-driven ones — no extras+ // from markThreadViewed under `running`.+ expect(notifications).toBe(5);+ });+});diff --git a/packages/app/src/lib/acp/thread-client.ts b/packages/app/src/lib/acp/thread-client.tsindex e0b419d48..cb6dda8fe 100644--- a/packages/app/src/lib/acp/thread-client.ts+++ b/packages/app/src/lib/acp/thread-client.ts@@ -103,11 +103,61 @@ export class AgentThreadClient {private pendingQueueEdits = new Map<string, PendingQueueEdit>();/** Archived threads the user explicitly opened as tabs this session. */private openedArchived = new Set<string>();+ /**+ * Per-thread timestamp of the last activity the user actually saw — bumped+ * to `info.lastActivityAt` when the tab activates. Seeded on first+ * observation of a thread to whatever `lastActivityAt` already is, so a+ * renderer reload does NOT report every idle `ready` tab as unread — the+ * pulse should mean "advanced while you were elsewhere in this window",+ * not "you just reloaded". In-memory only; not persisted across processes.+ */+ private lastViewedByThread = new Map<string, number>();private reqCounter = 0;private status: ThreadConnectionStatus = 'idle';/** Bumped on every store change; the useSyncExternalStore snapshot. */private version = 0;+ /**+ * Mark a thread as "seen up to its current lastActivityAt" — clears the+ * unread affordance on its tab. Called on tab activation, and again on+ * every activity tick (or status transition into `ready`) while the tab+ * stays active.+ */+ markThreadViewed = (threadId: string): void => {+ const state = this.threads.get(threadId);+ if (state === undefined) return;+ // Only meaningful on a settled `ready` tab. Skipping during `running`+ // avoids a bump storm: every streaming event advances lastActivityAt,+ // and the SessionsHost effect keys on it — a bump per batch here+ // would invalidate the snapshot cache and re-render every subscriber+ // once per event. The transition into `ready` re-fires the effect+ // and clears unread with a single bump.+ if (state.info.status !== 'ready') return;+ const at = state.info.lastActivityAt;+ if (this.lastViewedByThread.get(threadId) === at) return;+ this.lastViewedByThread.set(threadId, at);+ this.bump();+ };++ /**+ * Whether the thread has activity the user hasn't seen since last viewing+ * it. Only meaningful on a settled (`ready`) tab — a running turn already+ * carries its own pulse via the status dot.+ */+ getThreadUnread = (threadId: string): boolean => {+ const state = this.threads.get(threadId);+ if (state === undefined) return false;+ if (state.info.status !== 'ready') return false;+ // Floor is seeded at first observation in `upsertInfo`, so any thread+ // present in `this.threads` also has an entry here. The undefined+ // check exists to discharge `Map.get`'s `T | undefined` return for+ // strictNullChecks; it is not a live failure mode (unreachable under+ // the current write set).+ const seen = this.lastViewedByThread.get(threadId);+ if (seen === undefined) return false;+ return state.info.lastActivityAt > seen;+ };+/** Set (or clear) the WS URL. Reconnects when it changes. */setUrl(url: string | null): void {if (url === this.url) return;@@ -802,6 +852,12 @@ export class AgentThreadClient {const existing = this.threads.get(info.threadId);if (existing === undefined) {this.threads.set(info.threadId, { info, events: [], lastSeq: -1 });+ // Seed the unread floor at first observation so a renderer reload+ // doesn't unread every idle `ready` tab — the pulse means "advanced+ // WHILE you were elsewhere in this window", not "you just reloaded".+ if (!this.lastViewedByThread.has(info.threadId)) {+ this.lastViewedByThread.set(info.threadId, info.lastActivityAt);+ }} else if (info.archived === true && existing.info.archived !== true) {// Live → archived (server-side close/reap). The tab derivation drops it// and the retained events would only go stale — free them so a later@@ -881,6 +937,17 @@ export function useAgentThreadModel(threadId: string): ThreadRenderModel | nullreturn useSyncExternalStore(client.subscribe, getSnapshot, getSnapshot);}+/**+ * Reactive "has activity the user hasn't seen since last viewing" flag.+ * True only on a settled `ready` tab whose `lastActivityAt` has advanced+ * past the recorded viewed timestamp — a running/error/permission status+ * already tells its own story on the tab's status dot.+ */+export function useAgentThreadUnread(threadId: string): boolean {+ const getSnapshot = () => client.getThreadUnread(threadId);+ return useSyncExternalStore(client.subscribe, getSnapshot, getSnapshot);+}+/** Reactive connection status for the thread channel. */export function useAgentThreadConnection(): ThreadConnectionStatus {return useSyncExternalStore(diff --git a/packages/core/src/bridge/bind-frontmatter-doc.ts b/packages/core/src/bridge/bind-frontmatter-doc.tsindex d7a845280..dfd95ef49 100644--- a/packages/core/src/bridge/bind-frontmatter-doc.ts+++ b/packages/core/src/bridge/bind-frontmatter-doc.ts@@ -1,3 +1,4 @@+import type * as Y from 'yjs';import type { Err, Ok, Result } from '../config/result.ts';import { type FrontmatterValidationError, toFrontmatterIssue } from '../frontmatter/errors.ts';diff --git a/packages/core/src/bridge/bridge-invariant.ts b/packages/core/src/bridge/bridge-invariant.tsindex 005627195..8bfdb40cd 100644--- a/packages/core/src/bridge/bridge-invariant.ts+++ b/packages/core/src/bridge/bridge-invariant.ts@@ -1,3 +1,4 @@+import { fnv1aDigest } from './hash-util.ts';export type BridgeInvariantSite = 'observer-b' | 'persistence' | 'test-harness';diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.tsindex f4cc8a286..2a597ec3d 100644--- a/packages/core/src/bridge/compose.ts+++ b/packages/core/src/bridge/compose.ts@@ -1,3 +1,4 @@+import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';diff --git a/packages/core/src/bridge/divergence-locate.ts b/packages/core/src/bridge/divergence-locate.tsindex 6b505314d..d979f4b39 100644--- a/packages/core/src/bridge/divergence-locate.ts+++ b/packages/core/src/bridge/divergence-locate.ts@@ -1,3 +1,4 @@+import { findFirstDivergenceIndex } from './tolerance-telemetry.ts';export const BRIDGE_LINE_KINDS = [diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.tsindex 8fb428b90..01ef76a9f 100644--- a/packages/core/src/bridge/doc-boundary-space.ts+++ b/packages/core/src/bridge/doc-boundary-space.ts@@ -1,3 +1,4 @@+import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';diff --git a/packages/core/src/bridge/growth-detect.ts b/packages/core/src/bridge/growth-detect.tsindex 9d9c244b0..463e89595 100644--- a/packages/core/src/bridge/growth-detect.ts+++ b/packages/core/src/bridge/growth-detect.ts@@ -1,3 +1,4 @@+const DEFAULT_MIN_SUBSTANTIVE_LINE_LENGTH = 16;export const DUPLICATION_GATE_MIN_LINE_LENGTH = 8;diff --git a/packages/core/src/bridge/intraline-predicate.ts b/packages/core/src/bridge/intraline-predicate.tsindex c43fdd7e7..0939885bb 100644--- a/packages/core/src/bridge/intraline-predicate.ts+++ b/packages/core/src/bridge/intraline-predicate.ts@@ -1,3 +1,4 @@+export function rawLineCounts(doc: string): Map<string, number> {const counts = new Map<string, number>();for (const line of doc.split('\n')) {diff --git a/packages/core/src/bridge/merge-three-way.ts b/packages/core/src/bridge/merge-three-way.tsindex 251560a35..c0dc65705 100644--- a/packages/core/src/bridge/merge-three-way.ts+++ b/packages/core/src/bridge/merge-three-way.ts@@ -65,6 +65,7 @@ export function tryLineLevelCombine(return { clean: true, merged };}+export type BridgeMergeContentLossSide = 'user' | 'agent';export type BridgeMergeContentLossWhich = 'substring' | 'order' | 'growth';diff --git a/packages/core/src/bridge/normalize.ts b/packages/core/src/bridge/normalize.tsindex 01ac80099..dcc5b0690 100644--- a/packages/core/src/bridge/normalize.ts+++ b/packages/core/src/bridge/normalize.ts@@ -1,3 +1,4 @@+import { stripFrontmatter } from '../extensions/frontmatter.ts';import { bodyEdgeEmpties } from './doc-boundary-space.ts';diff --git a/packages/core/src/bridge/pm-structural-equivalence.ts b/packages/core/src/bridge/pm-structural-equivalence.tsindex 754dc5cc2..0be5203e4 100644--- a/packages/core/src/bridge/pm-structural-equivalence.ts+++ b/packages/core/src/bridge/pm-structural-equivalence.ts@@ -32,6 +32,7 @@ const BR_SENTINEL: PmStructuralNode = { type: '__br__' };const BR_LITERAL_RE = /^<br\s*\/?>$/i;+interface DegradeEntry {readonly label: string;readonly severity: ToleranceClassSeverity;@@ -127,6 +128,7 @@ export interface ComparePmStructuralOptions {ignoreAttrs?: (attrKey: string) => boolean;}+/** Rebuild a node with `fn` applied to each child; identity when childless.* Shared by the degrade canonicalizers so none re-implements the walk. */function mapChildren(@@ -248,6 +250,7 @@ function applyDegrades(tree: PmStructuralNode): {return { normalized: current, fired };}+export function comparePmStructural(expected: PmStructuralNode,actual: PmStructuralNode,diff --git a/packages/core/src/bridge/subsequence.ts b/packages/core/src/bridge/subsequence.tsindex af20de1e2..dca644141 100644--- a/packages/core/src/bridge/subsequence.ts+++ b/packages/core/src/bridge/subsequence.ts@@ -1,3 +1,4 @@+/** True when `needle` is a subsequence of `haystack` (two-pointer, O(n+m)):* insertions in `haystack` are free; any dropped or substituted `needle` byte* fails. */diff --git a/packages/core/src/markdown/callout-transformer.ts b/packages/core/src/markdown/callout-transformer.tsindex 83d47404a..a363dfd54 100644--- a/packages/core/src/markdown/callout-transformer.ts+++ b/packages/core/src/markdown/callout-transformer.ts@@ -1,3 +1,4 @@+import type { Blockquote, Paragraph, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/code-fence.ts b/packages/core/src/markdown/code-fence.tsindex 9807a7e82..4499dbc92 100644--- a/packages/core/src/markdown/code-fence.ts+++ b/packages/core/src/markdown/code-fence.ts@@ -1,3 +1,4 @@+export function selectFenceChar(info: string): '`' | '~' {return info.includes('`') ? '~' : '`';}diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.tsindex 7415c474a..34704165b 100644--- a/packages/core/src/markdown/comment-promoter.ts+++ b/packages/core/src/markdown/comment-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/dedent-block-jsx-close.ts b/packages/core/src/markdown/dedent-block-jsx-close.tsindex ece5c02a1..b6299a948 100644--- a/packages/core/src/markdown/dedent-block-jsx-close.ts+++ b/packages/core/src/markdown/dedent-block-jsx-close.ts@@ -1,3 +1,4 @@+import { findFencedRegions, isInsideFence } from './fence-regions.ts';const INDENTED_BLOCK_JSX_CLOSE_RE = /^([ ]{1,3})(<\/[A-Z][A-Za-z0-9_]*\s*>)([ \t]*)$/gm;diff --git a/packages/core/src/markdown/details-accordion-promoter.ts b/packages/core/src/markdown/details-accordion-promoter.tsindex 54774764a..acd398aa6 100644--- a/packages/core/src/markdown/details-accordion-promoter.ts+++ b/packages/core/src/markdown/details-accordion-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, Parent, Root, Text } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/div-align-promoter.ts b/packages/core/src/markdown/div-align-promoter.tsindex 43ecdc709..ba9b56384 100644--- a/packages/core/src/markdown/div-align-promoter.ts+++ b/packages/core/src/markdown/div-align-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, Parent, Root, Text } from 'mdast';import type { MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/fence-regions.ts b/packages/core/src/markdown/fence-regions.tsindex 6d3f3643e..4513da9bb 100644--- a/packages/core/src/markdown/fence-regions.ts+++ b/packages/core/src/markdown/fence-regions.ts@@ -1,3 +1,4 @@+const FENCE_RE = /^(`{3,}|~{3,})/gm;export function findFencedRegions(src: string): Array<[number, number]> {diff --git a/packages/core/src/markdown/fixtures/index.ts b/packages/core/src/markdown/fixtures/index.tsindex 00f5771ee..6931623c7 100644--- a/packages/core/src/markdown/fixtures/index.ts+++ b/packages/core/src/markdown/fixtures/index.ts@@ -1,3 +1,4 @@+import { readFileSync } from 'node:fs';import { dirname, resolve } from 'node:path';import { fileURLToPath } from 'node:url';@@ -8,6 +9,7 @@ function fixturePath(...segments: string[]): string {return resolve(FIXTURES_DIR, ...segments);}+interface GfmExample {section: string;markdown: string;@@ -17,6 +19,7 @@ export function loadGfmExamples(): GfmExample[] {return JSON.parse(readFileSync(fixturePath('gfm', 'examples.json'), 'utf8')) as GfmExample[];}+interface MdxCrashEntry {id: string;input: string;@@ -68,6 +71,7 @@ export function loadLargeEmbedFixtures(): LargeEmbedFixture[] {) as LargeEmbedFixture[];}+export function loadPrd6955Before(): string {return readFileSync(fixturePath('regression', 'prd-6955-before.md'), 'utf8');}@@ -76,6 +80,7 @@ export function loadPrd6955CorruptedTriplicated(): string {return readFileSync(fixturePath('regression', 'prd-6955-corrupted-triplicated.md'), 'utf8');}+export interface NgPinnedCase {id: string;name: string;@@ -92,6 +97,7 @@ export function loadNgPinnedCases(): NgPinnedCase[] {) as NgPinnedCase[];}+export function loadLargeRealistic(): string {return readFileSync(fixturePath('perf', 'large-realistic.md'), 'utf8');}diff --git a/packages/core/src/markdown/fixtures/perf/generate.ts b/packages/core/src/markdown/fixtures/perf/generate.tsindex 8b1eb8519..daa3ef82b 100644--- a/packages/core/src/markdown/fixtures/perf/generate.ts+++ b/packages/core/src/markdown/fixtures/perf/generate.ts@@ -1,3 +1,4 @@+import { writeFileSync } from 'node:fs';import { dirname, resolve } from 'node:path';import { fileURLToPath } from 'node:url';@@ -10,6 +11,7 @@ const BASELINE_ONLY_COUNTS = [500, 2500] as const;const SEED = 0xf1de1117;+function mulberry32(seed: number): () => number {let a = seed >>> 0;return () => {@@ -36,6 +38,7 @@ function pickWeighted<T>(rand: () => number, items: readonly [T, number][]): T {return items[items.length - 1][0];}+const WORDS = ['lorem','ipsum',@@ -153,6 +156,7 @@ function mdxBlock(rand: () => number): string {return `<${name}>\n\n${sentence(rand)}\n\n</${name}>`;}+type BlockKind = 'paragraph' | 'heading' | 'list' | 'code' | 'table' | 'mdx';const MIX: readonly [BlockKind, number][] = [@@ -191,6 +195,7 @@ function generateDocument(blockCount: number, seed: number): string {return `${blocks.join('\n\n')}\n`;}+function main(): void {for (const count of [...BLOCK_COUNTS, ...BASELINE_ONLY_COUNTS]) {const doc = generateDocument(count, SEED);diff --git a/packages/core/src/markdown/guard-flanking-matrix.ts b/packages/core/src/markdown/guard-flanking-matrix.tsindex 420dc0fe5..32c055c5b 100644--- a/packages/core/src/markdown/guard-flanking-matrix.ts+++ b/packages/core/src/markdown/guard-flanking-matrix.ts@@ -7,6 +7,7 @@ import {import { BACKSLASH_GUARD_SUBSTITUTIONS, encodeBackslashEscapes } from './backslash-escape-guard.ts';import { ENTITY_REF_GUARD_SUBSTITUTIONS, encodeEntityRefs } from './entity-ref-guard.ts';+export const ATTENTION_DELIMITERS = ['*', '_', '**', '~~', '=='] as const;export type FlankClass = 'whitespace' | 'punctuation' | 'other';diff --git a/packages/core/src/markdown/handler-shadow-audit.ts b/packages/core/src/markdown/handler-shadow-audit.tsindex 2653473da..283913255 100644--- a/packages/core/src/markdown/handler-shadow-audit.ts+++ b/packages/core/src/markdown/handler-shadow-audit.ts@@ -1,3 +1,4 @@+export interface HandlerShadowWitness {input: string;expect: 'byte' | 'byte-and-reparse-type';diff --git a/packages/core/src/markdown/highlight-promoter.ts b/packages/core/src/markdown/highlight-promoter.tsindex da0a81d23..5d1000cc4 100644--- a/packages/core/src/markdown/highlight-promoter.ts+++ b/packages/core/src/markdown/highlight-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, PhrasingContent, Root, Text } from 'mdast';import type { MdxJsxTextElement } from 'mdast-util-mdx';import { SKIP, visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/html-to-mdast.ts b/packages/core/src/markdown/html-to-mdast.tsindex 787315157..9681c0056 100644--- a/packages/core/src/markdown/html-to-mdast.ts+++ b/packages/core/src/markdown/html-to-mdast.ts@@ -1,3 +1,4 @@+import type { Element as HastElement, Root as HastRoot } from 'hast';import type { List, Nodes as MdastNodes, Root as MdastRoot } from 'mdast';import rehypeParse from 'rehype-parse';@@ -128,7 +129,8 @@ export function htmlToMdast(html: string, options?: HtmlToMdastOptions): MdastRothrow new HtmlPayloadTooLargeError(html.length, maxBytes);}- const processor = unified().use(rehypeParse, { fragment: true });+ const processor = unified()+ .use(rehypeParse, { fragment: true });for (const plugin of cleanupPlugins) {processor.use(plugin);diff --git a/packages/core/src/markdown/image-promoter.ts b/packages/core/src/markdown/image-promoter.tsindex 706fa9afb..994eb6917 100644--- a/packages/core/src/markdown/image-promoter.ts+++ b/packages/core/src/markdown/image-promoter.ts@@ -1,3 +1,4 @@+import type { Image, Paragraph, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/index.ts b/packages/core/src/markdown/index.tsindex 779e27500..ec1ac1b7e 100644--- a/packages/core/src/markdown/index.ts+++ b/packages/core/src/markdown/index.ts@@ -1,3 +1,4 @@+import {type FromProseMirrorOptions,fromPmMark,@@ -206,6 +207,7 @@ export class MarkdownManager {}}+const registry = createRegistry();function destructureAttrs(@@ -254,6 +256,7 @@ function destructureAttrs(return result;}+function hasDirtyDescendant(node: PmNode): boolean {let found = false;node.descendants((child) => {@@ -276,6 +279,7 @@ function effectiveDirty(node: PmNode, freshnessChecker?: StructuralFreshnessChecreturn freshnessChecker ? freshnessChecker.isDiverged(node.toJSON()) : false;}+function isEmptyMdastParagraph(node: MdastNodes): boolean {if (node.type !== 'paragraph') return false;const children = node.children ?? [];@@ -344,6 +348,7 @@ function extractTextFromMdastNodes(nodes: MdastNodes[]): string {return out;}+import {AUDIO_EXTENSIONS,FILE_ATTACHMENT_EXTENSIONS,@@ -596,6 +601,7 @@ function buildMdastToPmHandlers(}));}+if (m.emphasis) {handlers.emphasis = toPmMark(m.emphasis, (node: Emphasis) => ({sourceDelimiter: node.data?.sourceDelimiter ?? '*',@@ -676,6 +682,7 @@ function buildMdastToPmHandlers(}));}+if (m.link) {const sourceLiteralMark = m.sourceLiteral;handlers.link = (node: Link, _parent: MdastParent, state: MdastToPmState) => {@@ -973,6 +980,7 @@ function buildMdastToPmHandlers(};}+const blockUnknownHandler = (node: {type: string;position?: { start: { offset: number }; end: { offset: number } };@@ -1098,6 +1106,7 @@ function buildMdastToPmHandlers(return handlers as RemarkProseMirrorOptions['handlers'];}+function buildPmToMdastHandlers(schema: Schema,freshness: FreshnessCheckerHolder,diff --git a/packages/core/src/markdown/lint/applies-to.ts b/packages/core/src/markdown/lint/applies-to.tsindex fa0be9e86..b79e9aef7 100644--- a/packages/core/src/markdown/lint/applies-to.ts+++ b/packages/core/src/markdown/lint/applies-to.ts@@ -1,3 +1,4 @@+import picomatch from 'picomatch';import { SUPPORTED_DOC_EXTENSIONS } from '../../constants/doc-extensions.ts';diff --git a/packages/core/src/markdown/lint/config-files.ts b/packages/core/src/markdown/lint/config-files.tsindex 312c9c74b..94b34dee1 100644--- a/packages/core/src/markdown/lint/config-files.ts+++ b/packages/core/src/markdown/lint/config-files.ts@@ -1,3 +1,4 @@+const MARKDOWNLINT_JSON_CONFIG_FILES: ReadonlySet<string> = new Set(['.markdownlint.json','.markdownlint.jsonc',diff --git a/packages/core/src/markdown/lint/config-schemas.ts b/packages/core/src/markdown/lint/config-schemas.tsindex 1a81aa524..fbbd309df 100644--- a/packages/core/src/markdown/lint/config-schemas.ts+++ b/packages/core/src/markdown/lint/config-schemas.ts@@ -52,6 +52,7 @@ const fullPluginShape = Object.fromEntries(LINT_PLUGINS.map((plugin) => [plugin.id, plugin.sliceSchema]),) as z.ZodRawShape;+export const LinterConfigSchema = z.object({enabled: z.boolean(),plugins: z.object(fullPluginShape),diff --git a/packages/core/src/markdown/lint/default-config.ts b/packages/core/src/markdown/lint/default-config.tsindex d48eea5e4..a51f2ffb0 100644--- a/packages/core/src/markdown/lint/default-config.ts+++ b/packages/core/src/markdown/lint/default-config.ts@@ -6,6 +6,7 @@ export const DEFAULT_MARKDOWNLINT_CONFIG: Record<string, MarkdownlintRuleSettingMD013: false,};+export function resolveMarkdownlintConfig(rules: Record<string, MarkdownlintRuleSetting> | undefined,): Configuration {diff --git a/packages/core/src/markdown/lint/frontmatter-schema-edit.ts b/packages/core/src/markdown/lint/frontmatter-schema-edit.tsindex ef478e268..9c9542661 100644--- a/packages/core/src/markdown/lint/frontmatter-schema-edit.ts+++ b/packages/core/src/markdown/lint/frontmatter-schema-edit.ts@@ -1,3 +1,4 @@+import { CANONICAL_SCHEMA_DIALECT_URIS, DEFAULT_SCHEMA_DIALECT } from './frontmatter-validate.ts';export interface FrontmatterFieldConstraint {diff --git a/packages/core/src/markdown/lint/frontmatter-validate.ts b/packages/core/src/markdown/lint/frontmatter-validate.tsindex 5f953d667..b0e7833fd 100644--- a/packages/core/src/markdown/lint/frontmatter-validate.ts+++ b/packages/core/src/markdown/lint/frontmatter-validate.ts@@ -1,3 +1,4 @@+import Ajv, { type ValidateFunction } from 'ajv';import Ajv2019 from 'ajv/dist/2019.js';import Ajv2020 from 'ajv/dist/2020.js';diff --git a/packages/core/src/markdown/lint/index.ts b/packages/core/src/markdown/lint/index.tsindex 11b5abdfd..ffd277a90 100644--- a/packages/core/src/markdown/lint/index.ts+++ b/packages/core/src/markdown/lint/index.ts@@ -1,3 +1,4 @@+import { LINT_PLUGINS, type LinterConfig } from './plugins.ts';import type { LintDiagnostic } from './types.ts';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts b/packages/core/src/markdown/lint/okf-frontmatter/materialize.tsindex 7a5af097e..f438f1b16 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts@@ -1,3 +1,4 @@+import type { OkfRuleId } from '../okf-rule-meta.ts';import { fileNameFor, OKF_SCHEMA_DIR, okfSchemaPathFor } from './paths.ts';import { OKF_FRONTMATTER_REGISTRY } from './registry.ts';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/paths.ts b/packages/core/src/markdown/lint/okf-frontmatter/paths.tsindex 1ee913527..c290b6878 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/paths.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/paths.ts@@ -1,3 +1,4 @@+import type { OkfRuleId } from '../okf-rule-meta.ts';export const OKF_SCHEMA_DIR = '.ok/okf';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/registry.ts b/packages/core/src/markdown/lint/okf-frontmatter/registry.tsindex f325fbbb4..53ecb619d 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/registry.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/registry.ts@@ -1,3 +1,4 @@+import { compileAppliesTo } from '../applies-to.ts';import { validateFrontmatterSource } from '../frontmatter-validate.ts';import {diff --git a/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts b/packages/core/src/markdown/lint/okf-frontmatter/schemas.tsindex f1c37671b..89845d3d5 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts@@ -1,3 +1,4 @@+// file-level form is deliberate: the sibling `biome-ignore` must sit on the line// oxlint-disable unicorn/no-thenablediff --git a/packages/core/src/markdown/lint/okf-project/rules.ts b/packages/core/src/markdown/lint/okf-project/rules.tsindex 6d691ae2b..8b476332e 100644--- a/packages/core/src/markdown/lint/okf-project/rules.ts+++ b/packages/core/src/markdown/lint/okf-project/rules.ts@@ -1,3 +1,4 @@+import { SUPPORTED_DOC_EXTENSIONS } from '../../../constants/doc-extensions.ts';import { isOkfRuleEnabled, type OkfRuleId, type OkfRuleToggles } from '../okf-rule-meta.ts';diff --git a/packages/core/src/markdown/lint/okf-rule-meta.ts b/packages/core/src/markdown/lint/okf-rule-meta.tsindex 4de50d79f..44913a9dc 100644--- a/packages/core/src/markdown/lint/okf-rule-meta.ts+++ b/packages/core/src/markdown/lint/okf-rule-meta.ts@@ -1,3 +1,4 @@+export const OKF_RULE_IDS = ['no-wiki-links','log-shape',diff --git a/packages/core/src/markdown/lint/okf-rules.ts b/packages/core/src/markdown/lint/okf-rules.tsindex 1d5538421..d0999b62e 100644--- a/packages/core/src/markdown/lint/okf-rules.ts+++ b/packages/core/src/markdown/lint/okf-rules.ts@@ -1,3 +1,4 @@+import { isOkfRuleEnabled, type OkfRuleId, type OkfRuleToggles } from './okf-rule-meta.ts';import type { OkfRule } from './okf-runner.ts';import { indexShape } from './rules/index-shape.ts';diff --git a/packages/core/src/markdown/lint/okf-runner.ts b/packages/core/src/markdown/lint/okf-runner.tsindex de130e3f4..fabb08d6e 100644--- a/packages/core/src/markdown/lint/okf-runner.ts+++ b/packages/core/src/markdown/lint/okf-runner.ts@@ -1,3 +1,4 @@+import type { Root } from 'mdast';import remarkFrontmatter from 'remark-frontmatter';import remarkGfm from 'remark-gfm';diff --git a/packages/core/src/markdown/lint/plugins.ts b/packages/core/src/markdown/lint/plugins.tsindex 09c8450ee..0a089990e 100644--- a/packages/core/src/markdown/lint/plugins.ts+++ b/packages/core/src/markdown/lint/plugins.ts@@ -1,3 +1,4 @@+import { z } from 'zod';import { DEFAULT_MARKDOWNLINT_CONFIG, resolveMarkdownlintConfig } from './default-config.ts';import {@@ -23,6 +24,7 @@ import {type OkfSlice,} from './types.ts';+const MarkdownlintRuleSettingSchema = z.union([z.boolean(),z.enum(MARKDOWNLINT_RULE_SEVERITIES),diff --git a/packages/core/src/markdown/lint/rules/index-shape.ts b/packages/core/src/markdown/lint/rules/index-shape.tsindex 59fe9b87d..fcbb1b56c 100644--- a/packages/core/src/markdown/lint/rules/index-shape.ts+++ b/packages/core/src/markdown/lint/rules/index-shape.ts@@ -1,3 +1,4 @@+import type { List, ListItem } from 'mdast';import { EXIT, visit } from 'unist-util-visit';import { defineScopedOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/rules/log-shape.ts b/packages/core/src/markdown/lint/rules/log-shape.tsindex e0159519f..431e4e9c8 100644--- a/packages/core/src/markdown/lint/rules/log-shape.ts+++ b/packages/core/src/markdown/lint/rules/log-shape.ts@@ -1,3 +1,4 @@+import type { Heading } from 'mdast';import { toString as headingText } from 'mdast-util-to-string';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/lint/rules/no-wiki-links.ts b/packages/core/src/markdown/lint/rules/no-wiki-links.tsindex 2123e977f..f75a04d15 100644--- a/packages/core/src/markdown/lint/rules/no-wiki-links.ts+++ b/packages/core/src/markdown/lint/rules/no-wiki-links.ts@@ -1,3 +1,4 @@+import type { Point } from 'unist';import { visit } from 'unist-util-visit';import { defineOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/rules/reserved-casing.ts b/packages/core/src/markdown/lint/rules/reserved-casing.tsindex 89ef3e4a9..c8b4d8f28 100644--- a/packages/core/src/markdown/lint/rules/reserved-casing.ts+++ b/packages/core/src/markdown/lint/rules/reserved-casing.ts@@ -1,3 +1,4 @@+import { SUPPORTED_DOC_EXTENSIONS } from '../../../constants/doc-extensions.ts';import { defineOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/types.ts b/packages/core/src/markdown/lint/types.tsindex 6836b962d..c04fa4de0 100644--- a/packages/core/src/markdown/lint/types.ts+++ b/packages/core/src/markdown/lint/types.ts@@ -1,3 +1,4 @@+import type { BrokenLinkReason } from '../../schemas/api/agent-write.ts';import type { OkfRuleId } from './okf-rule-meta.ts';@@ -112,6 +113,7 @@ export interface OkfSlice {generate?: { index?: boolean };}+interface RuleOptionSpecBase {key: string;description: string;diff --git a/packages/core/src/markdown/lint/validation-counts.ts b/packages/core/src/markdown/lint/validation-counts.tsindex 98238656e..437cc539a 100644--- a/packages/core/src/markdown/lint/validation-counts.ts+++ b/packages/core/src/markdown/lint/validation-counts.ts@@ -1,3 +1,4 @@+export interface ValidationSourceCounts {errorCount: number;warningCount: number;diff --git a/packages/core/src/markdown/math-promoter.ts b/packages/core/src/markdown/math-promoter.tsindex a5b511f25..bd79424c7 100644--- a/packages/core/src/markdown/math-promoter.ts+++ b/packages/core/src/markdown/math-promoter.ts@@ -1,3 +1,4 @@+import type { Code, Root } from 'mdast';import type { Math as MdastMath } from 'mdast-util-math';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';diff --git a/packages/core/src/markdown/mdast-to-hast-handlers.ts b/packages/core/src/markdown/mdast-to-hast-handlers.tsindex ed89371d0..00fbc0035 100644--- a/packages/core/src/markdown/mdast-to-hast-handlers.ts+++ b/packages/core/src/markdown/mdast-to-hast-handlers.ts@@ -1,3 +1,4 @@+import type { Comment, Element, ElementContent, Properties } from 'hast';import type { FootnoteDefinition, FootnoteReference } from 'mdast';import type { MdxJsxFlowElement, MdxJsxTextElement } from 'mdast-util-mdx';diff --git a/packages/core/src/markdown/mdast-to-html.ts b/packages/core/src/markdown/mdast-to-html.tsindex 8ce2b2492..df788a80d 100644--- a/packages/core/src/markdown/mdast-to-html.ts+++ b/packages/core/src/markdown/mdast-to-html.ts@@ -1,3 +1,4 @@+import type { Element, Root as HastRoot, Text as HastText } from 'hast';import type { Root as MdastRoot, Text as MdastText } from 'mdast';import type { Handler } from 'mdast-util-to-hast';diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.tsindex bfd7e3109..fa3cfcd86 100644--- a/packages/core/src/markdown/merged-walker.ts+++ b/packages/core/src/markdown/merged-walker.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, Root } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/mermaid-promoter.ts b/packages/core/src/markdown/mermaid-promoter.tsindex 1a897fca8..17ed2b829 100644--- a/packages/core/src/markdown/mermaid-promoter.ts+++ b/packages/core/src/markdown/mermaid-promoter.ts@@ -1,3 +1,4 @@+import type { Code, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/parse-with-fallback.ts b/packages/core/src/markdown/parse-with-fallback.tsindex d988f4b8b..4aa0490c4 100644--- a/packages/core/src/markdown/parse-with-fallback.ts+++ b/packages/core/src/markdown/parse-with-fallback.ts@@ -168,6 +168,7 @@ export function parseRecursive(}}+interface VFilePlace {offset?: number;start?: { offset?: number };@@ -186,6 +187,7 @@ function extractErrorOffset(err: unknown): number | undefined {return undefined;}+interface Region {start: number;end: number;@@ -209,6 +211,7 @@ function nearestBlankLineAfter(src: string, offset: number): number | null {return null;}+export interface TagEvent {kind: 'open' | 'close' | 'self-close';name: string;@@ -355,6 +358,7 @@ function findFallbackRegion(src: string, errorOffset: number): Region {return { start: blockStart, end: blockEnd };}+interface SourceBlock {src: string;start: number;@@ -452,6 +456,7 @@ function tryPerBlockFallback(};}+function wholeDocRawText(source: string): JSONContent {return {type: 'doc',diff --git a/packages/core/src/markdown/parser-drop-closure.ts b/packages/core/src/markdown/parser-drop-closure.tsindex e6ab4fd57..43d420187 100644--- a/packages/core/src/markdown/parser-drop-closure.ts+++ b/packages/core/src/markdown/parser-drop-closure.ts@@ -1,3 +1,4 @@+export type DroppedTokenAdjudication =| {kind: 'format-dof-axis';diff --git a/packages/core/src/markdown/pipeline.ts b/packages/core/src/markdown/pipeline.tsindex 0e3224206..55736041c 100644--- a/packages/core/src/markdown/pipeline.ts+++ b/packages/core/src/markdown/pipeline.ts@@ -1,3 +1,4 @@+import {type FromProseMirrorOptions,fromProseMirror,diff --git a/packages/core/src/markdown/position-aware-join.ts b/packages/core/src/markdown/position-aware-join.tsindex 91cdf658f..ccf06e94d 100644--- a/packages/core/src/markdown/position-aware-join.ts+++ b/packages/core/src/markdown/position-aware-join.ts@@ -1,3 +1,4 @@+import type { Join } from 'mdast-util-to-markdown';import type { Position } from 'unist';import { isBlankLineParagraph } from './zero-emission-blocks.ts';diff --git a/packages/core/src/markdown/position-slice.ts b/packages/core/src/markdown/position-slice.tsindex 0f399d34c..e5b4c9eba 100644--- a/packages/core/src/markdown/position-slice.ts+++ b/packages/core/src/markdown/position-slice.ts@@ -1,3 +1,4 @@+import type { Nodes, Root } from 'mdast';import { visit } from 'unist-util-visit';import type { VFile } from 'vfile';@@ -476,7 +477,8 @@ export function applyPositionSliceToNode(const first = source[startOff];if (first !== '[' && first !== '<' && !node.title) {node.data.sourceStyle = 'gfm-autolink';- } else if (first === '[') {+ }+ else if (first === '[') {const slice = source.slice(startOff, endOff);const closeBracketIdx = slice.lastIndexOf('](');if (closeBracketIdx !== -1) {diff --git a/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts b/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.tsindex db10fa54b..ca225ce9b 100644--- a/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts+++ b/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts@@ -1,3 +1,4 @@+import type { Comment, Element, Root, Text } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts b/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.tsindex 34068d103..3a2524a9a 100644--- a/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts b/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.tsindex 93151d43b..2279a0189 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts b/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.tsindex 188f02d83..a0f467c42 100644--- a/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts b/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.tsindex 4ba2c3418..4e8542a21 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts b/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.tsindex 1a74b1272..a3c96b24a 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts b/packages/core/src/markdown/rehype-plugins/strip-mso-styles.tsindex de35e7b79..e95cf43d6 100644--- a/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts@@ -1,3 +1,4 @@+import type { Comment, Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts b/packages/core/src/markdown/rehype-plugins/strip-slack-classes.tsindex b4be1b2ea..ffdb4d5b5 100644--- a/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts b/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.tsindex 3c8d88b7c..e2a96d1a7 100644--- a/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/resolve-image-url.ts b/packages/core/src/markdown/resolve-image-url.tsindex cf2c9da8e..0389575ac 100644--- a/packages/core/src/markdown/resolve-image-url.ts+++ b/packages/core/src/markdown/resolve-image-url.ts@@ -1,3 +1,4 @@+import { isRelativeUrl } from './safe-url.ts';function isDevDiagnosticContext(): boolean {diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.tsindex 4d3250d3a..8be632ba4 100644--- a/packages/core/src/markdown/safe-url.ts+++ b/packages/core/src/markdown/safe-url.ts@@ -1,3 +1,4 @@+export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');diff --git a/packages/core/src/markdown/serialize-fidelity.test-helper.ts b/packages/core/src/markdown/serialize-fidelity.test-helper.tsindex 0dd54070e..96304e7a5 100644--- a/packages/core/src/markdown/serialize-fidelity.test-helper.ts+++ b/packages/core/src/markdown/serialize-fidelity.test-helper.ts@@ -1,3 +1,4 @@+import type { JSONContent } from '@tiptap/core';import type { Nodes } from 'mdast';import { expect } from 'vitest';diff --git a/packages/core/src/markdown/serialize-helpers.ts b/packages/core/src/markdown/serialize-helpers.tsindex 7cac5b042..93798cf83 100644--- a/packages/core/src/markdown/serialize-helpers.ts+++ b/packages/core/src/markdown/serialize-helpers.ts@@ -1,3 +1,4 @@+import type { Node as PmNode } from '@tiptap/pm/model';import type {MdxJsxAttribute,diff --git a/packages/core/src/markdown/single-dollar-math-promoter.ts b/packages/core/src/markdown/single-dollar-math-promoter.tsindex b012a5aff..8c08b7a04 100644--- a/packages/core/src/markdown/single-dollar-math-promoter.ts+++ b/packages/core/src/markdown/single-dollar-math-promoter.ts@@ -1,3 +1,4 @@+import type { PhrasingContent, Root, Text } from 'mdast';import type { InlineMath } from 'mdast-util-math';import { SKIP, visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/to-markdown-handlers.ts b/packages/core/src/markdown/to-markdown-handlers.tsindex b50bea5ec..83d4af672 100644--- a/packages/core/src/markdown/to-markdown-handlers.ts+++ b/packages/core/src/markdown/to-markdown-handlers.ts@@ -1,3 +1,4 @@+import type { Nodes, Parents } from 'mdast';import type { MdxJsxAttribute, MdxJsxExpressionAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import type { Handle, Info, State } from 'mdast-util-to-markdown';diff --git a/packages/core/src/markdown/underline-promoter.ts b/packages/core/src/markdown/underline-promoter.tsindex 0f1b0f27d..6e6d73400 100644--- a/packages/core/src/markdown/underline-promoter.ts+++ b/packages/core/src/markdown/underline-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, Root } from 'mdast';import type { MdxJsxTextElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/unknown-mdast-guard.ts b/packages/core/src/markdown/unknown-mdast-guard.tsindex 1a082bda7..932d7d2a8 100644--- a/packages/core/src/markdown/unknown-mdast-guard.ts+++ b/packages/core/src/markdown/unknown-mdast-guard.ts@@ -1,3 +1,4 @@+import type { Root as MdastRoot } from 'mdast';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/whitespace-char-ref.ts b/packages/core/src/markdown/whitespace-char-ref.tsindex d578476a7..ac9f5239b 100644--- a/packages/core/src/markdown/whitespace-char-ref.ts+++ b/packages/core/src/markdown/whitespace-char-ref.ts@@ -1,3 +1,4 @@+const INLINE_WHITESPACE_BY_CODE: ReadonlyMap<number, string> = new Map([[0x20, ' '],[0x09, '\t'],diff --git a/packages/core/src/markdown/wiki-link-micromark.ts b/packages/core/src/markdown/wiki-link-micromark.tsindex 6dad26200..afd9936fe 100644--- a/packages/core/src/markdown/wiki-link-micromark.ts+++ b/packages/core/src/markdown/wiki-link-micromark.ts@@ -17,6 +17,7 @@ declare module 'micromark-util-types' {}}+const CODE_BANG = 33; // !const CODE_LBRACKET = 91; // [const CODE_RBRACKET = 93; // ]@@ -260,6 +261,7 @@ export function wikiLinkSyntax(): Extension {};}+function enterWikiLink(this: CompileContext, token: Token) {this.enter({@@ -385,6 +387,7 @@ export const wikiLinkToMarkdown: {unsafe: [{ character: '[', inConstruct: ['phrasing'] }],};+const MICROMARK_EXT = wikiLinkSyntax();export function remarkWikiLink(this: Processor) {diff --git a/packages/server/src/acp/thread-manager.ts b/packages/server/src/acp/thread-manager.tsindex dcc27d22d..825fdd256 100644--- a/packages/server/src/acp/thread-manager.ts+++ b/packages/server/src/acp/thread-manager.ts@@ -2858,7 +2858,7 @@ export class AcpThreadManager {// the tab label. One-shot: cleared so later prompts derive from content.const source = t.titleHint !== undefined && t.titleHint.trim() !== '' ? t.titleHint : content;t.titleHint = undefined;- t.info.title = deriveThreadTitle(source);+ t.info.title = deriveThreadTitle(source, t.info.agent.name);this.appendEvent(t, { kind: 'title_changed', title: t.info.title, ts: Date.now() });this.emitInfo(t);}diff --git a/packages/server/src/acp/thread-title.test.ts b/packages/server/src/acp/thread-title.test.tsindex 6427cabfc..8d7c6e34c 100644--- a/packages/server/src/acp/thread-title.test.ts+++ b/packages/server/src/acp/thread-title.test.ts@@ -60,6 +60,109 @@ describe('deriveThreadTitle', () => {expect(derived.endsWith('…')).toBe(true);expect(derived).toBe('Update the roadmap document with the newly…');});++ test('strips a leading agent name mention when supplied', () => {+ // Every tab already shows the agent icon; leaving "Claude, …" as the+ // distinguishing lead wastes half the label's width.+ expect(deriveThreadTitle("Claude, what's 2+2?", 'Claude')).toBe("What's 2+2?");+ expect(deriveThreadTitle('@Claude please fix the parser', 'Claude')).toBe('Fix the parser');+ expect(deriveThreadTitle('Cursor — update the sidebar copy', 'Cursor')).toBe(+ 'Update the sidebar copy',+ );+ });++ test('leaves the name in the middle of a sentence alone', () => {+ // Only a LEADING mention is dead weight; "Ask Claude to do X" is real content.+ expect(deriveThreadTitle('Ask Claude to summarize the PR', 'Claude')).toBe(+ 'Ask Claude to summarize the PR',+ );+ });++ test('leaves a subject-position mention alone — "Codex is failing" ≠ "@Codex"', () => {+ // Bare whitespace after the name is not addressing punctuation; the strip+ // fires only for `@Codex …`, `Codex, …`, `Codex — …`. Otherwise a bug+ // report titled after the agent would be mangled into a broken predicate.+ expect(deriveThreadTitle('Codex is failing to start', 'Codex')).toBe(+ 'Codex is failing to start',+ );+ expect(deriveThreadTitle('Claude crashed on startup', 'Claude')).toBe(+ 'Claude crashed on startup',+ );+ expect(deriveThreadTitle('Cursor should not reformat the file', 'Cursor')).toBe(+ 'Cursor should not reformat the file',+ );+ });++ test('rescues a title that opens with punctuation (dash bullet, stray "??")', () => {+ // FILLER_RE already trims its own trailing separator, so this pass only+ // triggers when the input itself opens with punctuation — an em-dash+ // bullet, a leftover `??`, a stray colon after a quote strip.+ expect(deriveThreadTitle('— refactor the parser')).toBe('Refactor the parser');+ expect(deriveThreadTitle('?? fix the parser')).toBe('Fix the parser');+ expect(deriveThreadTitle(': update the roadmap doc')).toBe('Update the roadmap doc');+ });++ test('leaves punctuation glued to the next token alone — .env / --verbose / .gitignore', () => {+ // Coding-agent prompts open with these constantly. If the punctuation+ // strip fired without requiring whitespace after, `.env is missing …`+ // would mangle to `Env is missing …` — same defect class as the+ // bare-space agent-name bug.+ expect(deriveThreadTitle('.env is missing the API key')).toBe('.env is missing the API key');+ expect(deriveThreadTitle('--verbose flag broken on Windows')).toBe(+ '--verbose flag broken on Windows',+ );+ expect(deriveThreadTitle('.gitignore not respected in nested repos')).toBe(+ '.gitignore not respected in nested repos',+ );+ });++ test('leaves an agent name glued to a dotfile alone — Codex.md ≠ Codex', () => {+ // Address form requires a whitespace/EOS delimiter after the punctuation+ // so `Codex.md needs a heading` doesn't strip to `Md needs a heading`.+ expect(deriveThreadTitle('Codex.md needs a heading', 'Codex')).toBe('Codex.md needs a heading');+ expect(deriveThreadTitle('cursor.json is malformed', 'Cursor')).toBe(+ 'cursor.json is malformed',+ );+ // A period followed by a space IS an address form ("Codex. Fix …").+ expect(deriveThreadTitle('Codex. Fix the parser.', 'Codex')).toBe('Fix the parser.');+ });++ test('leaves an `@`-mentioned dotfile alone — @Codex.md ≠ @Codex', () => {+ // The @-mention arm needs the same whitespace-or-EOS delimiter as the+ // bare-name arm; otherwise `@CLAUDE.md needs updating` (an @-mention+ // of the file, not the agent) mangles to `Md needs updating`.+ expect(deriveThreadTitle('@Codex.md needs a heading', 'Codex')).toBe(+ '@Codex.md needs a heading',+ );+ expect(deriveThreadTitle('@CLAUDE.md needs updating', 'Claude')).toBe(+ '@CLAUDE.md needs updating',+ );+ // A real @-mention address still strips.+ expect(deriveThreadTitle('@Claude, fix the parser', 'Claude')).toBe('Fix the parser');+ expect(deriveThreadTitle('@Claude fix the parser', 'Claude')).toBe('Fix the parser');+ // An @-mention with a non-alpha delimiter (`?` / `•` / `|`) is still+ // an address — the delimiter class matches LEADING_PUNCT_RE parity.+ // Both arms share one interpolated `delim` constant (thread-title.ts),+ // so pinning each char through EITHER arm now guards the shared class;+ // exercising the @-arm alongside the bare-name block is belt-and-+ // suspenders in case future changes give the arms independent classes+ // again.+ expect(deriveThreadTitle('@Codex?? fix the parser', 'Codex')).toBe('Fix the parser');+ expect(deriveThreadTitle('@Codex| fix the parser', 'Codex')).toBe('Fix the parser');+ expect(deriveThreadTitle('@Codex• fix the parser', 'Codex')).toBe('Fix the parser');+ });++ test('bare-name arm accepts `?` / `|` / `•` delimiters — parity with LEADING_PUNCT_RE', () => {+ // The bare-name (unprefixed) delimiter class matches LEADING_PUNCT_RE's,+ // so every non-alpha punctuation char that would clean an opening title+ // also counts as an addressing delimiter after the name. Each of these+ // characters is a distinct code point — the test pins them individually+ // so a copy-paste that lands a lookalike (or drops one from the class)+ // reddens.+ expect(deriveThreadTitle('Codex? fix the parser', 'Codex')).toBe('Fix the parser');+ expect(deriveThreadTitle('Codex | fix the parser', 'Codex')).toBe('Fix the parser');+ expect(deriveThreadTitle('Codex • fix the parser', 'Codex')).toBe('Fix the parser');+ });});describe('clampThreadTitle', () => {diff --git a/packages/server/src/acp/thread-title.ts b/packages/server/src/acp/thread-title.tsindex 90d489080..027e91b59 100644--- a/packages/server/src/acp/thread-title.ts+++ b/packages/server/src/acp/thread-title.ts@@ -80,9 +80,20 @@ const FILLER_RE = new RegExp(/** Markdown lead-in on a prompt's first line: headings, quotes, list markers. */const MARKDOWN_LEAD_RE = /^(?:[#>]+\s*|[-*]\s+|\d+[.)]\s+)+/;+/** Leading punctuation the caller wrote (or the markdown-lead strip+ * exposed) — an em-dash bullet, a stray "??", a leftover colon after a+ * quote strip. FILLER_RE already consumes its own trailing separator+ * ("please, do X" → "do X" in one pass), so this pass only rescues+ * inputs that OPEN with punctuation ("— refactor" → "Refactor"). */+const LEADING_PUNCT_RE = /^[\s,:;.!?\-–—•|]+(?=\s|$)/;+/** Guard against a pathological prefix chain; real prompts stack 2-3 deep. */const MAX_STRIP_PASSES = 6;+function escapeRegExp(s: string): string {+ return s.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');+}+function firstLine(raw: string): string {return (raw.trim().split('\n')[0] ?? '').trim();}@@ -108,16 +119,43 @@ export function clampThreadTitle(raw: string): string {* adopted when the remainder still reads as a title (two-plus words, or one* long one) — otherwise the raw first line passes through untouched, so* greeting-only prompts and non-English prompts degrade to today's behavior.+ *+ * When `agentName` is supplied (Claude, Cursor, Codex, …) a leading+ * ADDRESSING mention is stripped first — every tab already carries the+ * agent's icon, so "Claude, what's 2+2?" becomes "What's 2+2?" instead+ * of leaving dead identity text as the distinguishing lead. Only+ * addressing forms strip ("@Claude fix X", "Claude, fix X",+ * "Claude — fix X"); a subject-position mention ("Claude Code+ * crashed on startup") passes through unchanged. A final punctuation+ * trim rescues titles that OPEN with punctuation (em-dash bullet,+ * stray "??").*/-export function deriveThreadTitle(prompt: string): string {+export function deriveThreadTitle(prompt: string, agentName?: string): string {const line = firstLine(prompt);let stripped = line.replace(MARKDOWN_LEAD_RE, '');+ if (agentName !== undefined && agentName.trim() !== '') {+ const name = escapeRegExp(agentName.trim());+ // Only ADDRESSING mentions strip: an `@` prefix (any following+ // separator), or the bare name followed by real punctuation (comma,+ // colon, dash, em-dash, …). Bare whitespace does NOT count — otherwise+ // "Codex is failing to start" would eat "Codex" and become+ // "Is failing to start", mangling every subject-position mention.+ // The delimiter class matches LEADING_PUNCT_RE's parity and is+ // interpolated into both arms from ONE literal so a widening on one+ // arm can't desync from the other.+ const delim = String.raw`[,:;!.?\-–—•|]`;+ const nameRe = new RegExp(+ `^(?:@${name}\\b(?:\\s+|${delim}+(?:\\s+|$)|$)|${name}\\b\\s*${delim}+(?:\\s+|$)|@?${name}\\b$)`,+ 'i',+ );+ stripped = stripped.replace(nameRe, '');+ }for (let pass = 0; pass < MAX_STRIP_PASSES; pass++) {const next = stripped.replace(FILLER_RE, '');if (next === stripped) break;stripped = next;}- stripped = stripped.trim();+ stripped = stripped.replace(LEADING_PUNCT_RE, '').trim();const words = stripped.split(/\s+/).filter((w) => w !== '').length;const viable = stripped !== '' && (words >= 2 || stripped.length >= 12);if (!viable || stripped === line) return clampThreadTitle(line);