Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Stop forcing a layout per table on editor width changes (PRD-9263) (#6160)

Andrew Mikofalvy197cb5ddf00f
diff --git a/.changeset/prd-9263-table-width-change-layout.md b/.changeset/prd-9263-table-width-change-layout.md
new file mode 100644
index 000000000..a6ceab0b9
--- /dev/null
+++ b/.changeset/prd-9263-table-width-change-layout.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Toggling the sidebar or resizing the window no longer stutters on documents with many tables.
diff --git a/knip.config.ts b/knip.config.ts
index 0004a763a..69344114d 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -149,15 +149,11 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: [
- '@types/shell-quote',
- ],
+ ignoreDependencies: ['@types/shell-quote'],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
- ignoreDependencies: [
- 'yjs',
- ],
+ ignoreDependencies: ['yjs'],
},
'packages/desktop': {
entry: [
diff --git a/packages/app/src/editor/extensions/frozen-table-headers.ts b/packages/app/src/editor/extensions/frozen-table-headers.ts
index fcc018994..bed0a0f72 100644
--- a/packages/app/src/editor/extensions/frozen-table-headers.ts
+++ b/packages/app/src/editor/extensions/frozen-table-headers.ts
@@ -47,6 +47,8 @@ interface AppliedFreeze {
const appliedFreezes = new WeakMap<HTMLTableCellElement, AppliedFreeze>();
+const skippedChunks = new WeakSet<Element>();
+
function cancelFreeze(cell: HTMLTableCellElement): void {
const prev = appliedFreezes.get(cell);
if (!prev) return;
@@ -193,33 +195,42 @@ function applyInstantFreeze(cell: HTMLTableCellElement, shift: number): void {
appliedFreezes.set(cell, { key, animations: [animation, occluderAnimation] });
}
+interface MeasuredHeader {
+ firstRow: HTMLTableRowElement;
+ tableRect: DOMRect;
+ headerHeight: number;
+}
+
function computeAndApplyFrozenHeaders(
scrollEl: HTMLElement,
editorDom: HTMLElement,
timeline: AnimationTimeline | null,
- onTableWrapper?: (wrapper: HTMLElement) => void,
+ isRenderingSkipped: (table: HTMLTableElement) => boolean,
): void {
const containerTop = scrollEl.getBoundingClientRect().top;
const scrollTop = scrollEl.scrollTop;
const scrollMax = scrollEl.scrollHeight - scrollEl.clientHeight;
- const wrappers = editorDom.querySelectorAll<HTMLElement>('.tableWrapper');
- for (const wrapper of wrappers) {
- onTableWrapper?.(wrapper);
- const table = wrapper.querySelector('table');
- if (!table) continue;
+ const measured: MeasuredHeader[] = [];
+ for (const table of editorDom.querySelectorAll<HTMLTableElement>('.tableWrapper > table')) {
const firstRow = table.querySelector('tbody')?.rows[0];
if (!firstRow || !Array.from(firstRow.cells).some((c) => c.tagName === 'TH')) {
continue;
}
+ if (isRenderingSkipped(table)) continue;
+ measured.push({
+ firstRow,
+ tableRect: table.getBoundingClientRect(),
+ headerHeight: firstRow.getBoundingClientRect().height,
+ });
+ }
- const tableRect = table.getBoundingClientRect();
- const headerRect = firstRow.getBoundingClientRect();
+ for (const { firstRow, tableRect, headerHeight } of measured) {
const range = computeFreezeRange(
scrollTop,
containerTop,
tableRect.top,
tableRect.height,
- headerRect.height,
+ headerHeight,
);
if (!range) {
@@ -264,16 +275,18 @@ export const FrozenTableHeaders = Extension.create({
let driftTimer: ReturnType<typeof setTimeout> | null = null;
let resizeObserver: ResizeObserver | null = null;
let destroyed = false;
- const cvWired = new Set<HTMLElement>();
+ const editorDom = editorView.dom as HTMLElement;
+
+ const isRenderingSkipped = (table: HTMLTableElement): boolean => {
+ for (let el = table.parentElement; el && el !== editorDom; el = el.parentElement) {
+ if (skippedChunks.has(el)) return true;
+ }
+ return false;
+ };
const run = (): void => {
if (destroyed || !scrollEl) return;
- computeAndApplyFrozenHeaders(
- scrollEl,
- editorView.dom as HTMLElement,
- timeline,
- wireChunkVisibility,
- );
+ computeAndApplyFrozenHeaders(scrollEl, editorDom, timeline, isRenderingSkipped);
};
const scheduleRun = (): void => {
@@ -284,11 +297,19 @@ export const FrozenTableHeaders = Extension.create({
});
};
- function wireChunkVisibility(wrapper: HTMLElement): void {
- if (cvWired.has(wrapper)) return;
- cvWired.add(wrapper);
- wrapper.addEventListener('contentvisibilityautostatechange', scheduleRun);
- }
+ const onChunkVisibilityChange = (event: Event): void => {
+ const chunk = event.target;
+ if (!(chunk instanceof Element)) return;
+ if ((event as ContentVisibilityAutoStateChangeEvent).skipped) {
+ skippedChunks.add(chunk);
+ return;
+ }
+ skippedChunks.delete(chunk);
+ if (chunk.querySelector('table')) scheduleRun();
+ };
+ editorDom.addEventListener('contentvisibilityautostatechange', onChunkVisibilityChange, {
+ capture: true,
+ });
const onScroll = (): void => {
if (timeline) {
@@ -305,9 +326,7 @@ export const FrozenTableHeaders = Extension.create({
requestAnimationFrame(() => {
if (destroyed) return;
- scrollEl = (editorView.dom as HTMLElement).closest<HTMLElement>(
- '[data-testid="editor-scroll-container"]',
- );
+ scrollEl = editorDom.closest<HTMLElement>('[data-testid="editor-scroll-container"]');
if (!scrollEl && import.meta.env.DEV) {
console.warn(
'[frozen-table-headers] editor-scroll-container not found; table headers will not freeze',
@@ -324,7 +343,7 @@ export const FrozenTableHeaders = Extension.create({
if (scrollEl && typeof ResizeObserver !== 'undefined') {
resizeObserver = new ResizeObserver(scheduleRun);
resizeObserver.observe(scrollEl);
- resizeObserver.observe(editorView.dom as HTMLElement);
+ resizeObserver.observe(editorDom);
}
run();
});
@@ -340,13 +359,12 @@ export const FrozenTableHeaders = Extension.create({
resizeObserver?.disconnect();
if (rafId != null) cancelAnimationFrame(rafId);
if (driftTimer != null) clearTimeout(driftTimer);
- for (const wrapper of cvWired) {
- wrapper.removeEventListener('contentvisibilityautostatechange', scheduleRun);
- }
- cvWired.clear();
- for (const row of (
- editorView.dom as HTMLElement
- ).querySelectorAll<HTMLTableRowElement>(
+ editorDom.removeEventListener(
+ 'contentvisibilityautostatechange',
+ onChunkVisibilityChange,
+ { capture: true },
+ );
+ for (const row of editorDom.querySelectorAll<HTMLTableRowElement>(
'.tableWrapper > table > tbody > tr:first-child',
)) {
resetHeaderCells(row);
diff --git a/packages/app/src/editor/extensions/table-insert-controls.ts b/packages/app/src/editor/extensions/table-insert-controls.ts
index 8119dc237..43c0cdbb3 100644
--- a/packages/app/src/editor/extensions/table-insert-controls.ts
+++ b/packages/app/src/editor/extensions/table-insert-controls.ts
@@ -1,4 +1,3 @@
-import { autoUpdate, computePosition } from '@floating-ui/dom';
import type { Editor } from '@tiptap/core';
import { Extension } from '@tiptap/core';
import type { EditorState } from '@tiptap/pm/state';
@@ -26,6 +25,9 @@ function createBar(orientation: 'column' | 'row', label: string): HTMLButtonElem
interface TableOverlay {
container: HTMLElement;
+ colBar: HTMLButtonElement;
+ rowBar: HTMLButtonElement;
+ placement: string;
cleanup: () => void;
}
@@ -35,12 +37,17 @@ class TableInsertControlsView {
private lastEditable: boolean;
private readonly view: EditorView;
private readonly editor: Editor;
+ private readonly resizeObserver: ResizeObserver | null;
+ private positionFrame: number | null = null;
constructor(view: EditorView, editor: Editor) {
this.view = view;
this.editor = editor;
this.mount = view.dom.parentElement ?? view.dom;
this.lastEditable = editor.isEditable;
+ this.resizeObserver =
+ typeof ResizeObserver === 'undefined' ? null : new ResizeObserver(() => this.positionAll());
+ this.resizeObserver?.observe(view.dom);
this.reconcile();
}
@@ -49,15 +56,52 @@ class TableInsertControlsView {
this.lastEditable = this.editor.isEditable;
if (!editableChanged && prevState.doc.eq(this.view.state.doc)) return;
this.reconcile();
+ this.schedulePositionAll();
}
destroy(): void {
- for (const wrapper of this.overlays.keys()) this.removeOverlay(wrapper);
+ this.removeAllOverlays();
+ this.resizeObserver?.disconnect();
+ if (this.positionFrame != null) cancelAnimationFrame(this.positionFrame);
+ this.positionFrame = null;
+ }
+
+ private schedulePositionAll(): void {
+ if (this.positionFrame != null || this.overlays.size === 0) return;
+ this.positionFrame = requestAnimationFrame(() => {
+ this.positionFrame = null;
+ this.positionAll();
+ });
+ }
+
+ private positionAll(): void {
+ const placements = Array.from(this.overlays, ([wrapper, overlay]) => {
+ const table = wrapper.getBoundingClientRect();
+ const origin = overlay.container.getBoundingClientRect();
+ const left = table.left - origin.left;
+ const top = table.top - origin.top;
+ return { overlay, left, top, width: table.width, height: table.height };
+ });
+ for (const { overlay, left, top, width, height } of placements) {
+ const placement = `${left}|${top}|${width}|${height}`;
+ if (overlay.placement === placement) continue;
+ overlay.placement = placement;
+ Object.assign(overlay.colBar.style, {
+ left: `${left + width}px`,
+ top: `${top}px`,
+ height: `${height}px`,
+ });
+ Object.assign(overlay.rowBar.style, {
+ left: `${left}px`,
+ top: `${top + height}px`,
+ width: `${width}px`,
+ });
+ }
}
private reconcile(): void {
if (!this.editor.isEditable) {
- this.destroy();
+ this.removeAllOverlays();
return;
}
const live = new Set(this.view.dom.querySelectorAll<HTMLElement>('.tableWrapper'));
@@ -81,32 +125,6 @@ class TableInsertControlsView {
container.append(colBar, rowBar);
this.mount.appendChild(container);
- const reposition = (): void => {
- const { width, height } = wrapper.getBoundingClientRect();
- void computePosition(wrapper, colBar, {
- strategy: 'absolute',
- placement: 'right-start',
- })
- .then(({ x, y }) => {
- colBar.style.left = `${x}px`;
- colBar.style.top = `${y}px`;
- colBar.style.height = `${height}px`;
- })
- .catch(() => {});
- void computePosition(wrapper, rowBar, {
- strategy: 'absolute',
- placement: 'bottom-start',
- })
- .then(({ x, y }) => {
- rowBar.style.left = `${x}px`;
- rowBar.style.top = `${y}px`;
- rowBar.style.width = `${width}px`;
- })
- .catch(() => {});
- };
-
- const stopAutoUpdate = autoUpdate(wrapper, container, reposition);
-
const onPointerOver = (event: PointerEvent): void => {
const cell =
event.target instanceof Element ? event.target.closest<HTMLElement>('td, th') : null;
@@ -121,10 +139,14 @@ class TableInsertControlsView {
wrapper.addEventListener('pointerover', onPointerOver);
wrapper.addEventListener('pointerleave', onPointerLeave);
+ this.resizeObserver?.observe(wrapper);
this.overlays.set(wrapper, {
container,
+ colBar,
+ rowBar,
+ placement: '',
cleanup: () => {
- stopAutoUpdate();
+ this.resizeObserver?.unobserve(wrapper);
wrapper.removeEventListener('pointerover', onPointerOver);
wrapper.removeEventListener('pointerleave', onPointerLeave);
container.remove();
@@ -132,6 +154,10 @@ class TableInsertControlsView {
});
}
+ private removeAllOverlays(): void {
+ for (const wrapper of this.overlays.keys()) this.removeOverlay(wrapper);
+ }
+
private removeOverlay(wrapper: HTMLElement): void {
const overlay = this.overlays.get(wrapper);
if (!overlay) return;
diff --git a/packages/app/src/globals.css b/packages/app/src/globals.css
index ef3e5d730..d5de3405a 100644
--- a/packages/app/src/globals.css
+++ b/packages/app/src/globals.css
@@ -2774,8 +2774,7 @@ body[data-editor-tab-dragging] * {
/* Table edge "+" bars — Notion-style append-column / append-row affordance.
The TableInsertControls extension mounts one container per table on
- `editor.view.dom.parentElement` and floating-ui sets each bar's `left`/`top`
- plus the stretched cross-axis size inline. Each bar is a persistent but
+ `editor.view.dom.parentElement`. Each bar is a persistent but
transparent hit zone at the table edge; hovering it (the mouse landing inside
the bar) reveals the "+", so reveal is pure CSS — no JS hover tracking. */
.ok-table-insert-controls {
@@ -2803,7 +2802,7 @@ body[data-editor-tab-dragging] * {
strip, so it's hoverable. */
color: transparent;
background: transparent;
- /* The bar sits flush against the table edge (no floating-ui offset). The
+ /* The bar sits flush against the table edge. The
gutter toward the table is transparent padding — `content-box` keeps the
visible highlight off it, preserving the visual gap while making the gutter
itself part of the (hoverable) button, so there's no dead zone between the
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index 4549c74b3..a50b00123 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,4 +1,3 @@
-
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 4fc2c11f9..6fcdc23f2 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 9f2f6feb6..40b5cdfd6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 2a085742b..93666af70 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 878d5196b..867598d34 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 4ada3cf26..0970ac12f 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index cbe2b705f..b632185e1 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,4 +1,3 @@
-
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index 89bc9b4d9..c530ce4ba 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index a78aeb0e4..d3767adc9 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,4 +1,3 @@
-
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index e7cc69c3f..b076f955c 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,4 +1,3 @@
-
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 9ddcd0730..7935e35f8 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/stress/frozen-table-headers.e2e.ts b/packages/app/tests/stress/frozen-table-headers.e2e.ts
index 959b45eca..8daebe441 100644
--- a/packages/app/tests/stress/frozen-table-headers.e2e.ts
+++ b/packages/app/tests/stress/frozen-table-headers.e2e.ts
@@ -567,3 +567,96 @@ test('slot above pinned header stays clean in a prose-heavy doc (pixel-verified)
}
await page.screenshot({ path: testInfo.outputPath('prose-above-frozen.png') });
});
+
+const MANY_TABLES_MARKDOWN = `# Quarterly Review
+
+${Array.from(
+ { length: 15 },
+ (_, t) => `## Region ${t + 1}
+
+${Array.from({ length: 3 }, (_, p) => `Region ${t + 1} summary paragraph ${p + 1}, long enough to wrap at a narrower editor width and push the next table down.`).join('\n\n')}
+
+| Metric | One | Two | Three | Four |
+|--------|-----|-----|-------|------|
+${Array.from({ length: 10 }, (_, r) => `| Row-${t + 1}-${r + 1} | ${r} | ${r * 2} | ${r * 3} | ${r * 4} |`).join('\n')}`,
+).join('\n\n')}
+`;
+
+test('an editor width change lays out once, not once per table in a skipped chunk', async ({
+ page,
+ api,
+ workerServer,
+}) => {
+ await page.setViewportSize({ width: 1440, height: 900 });
+ await api.seedDocs([{ name: 'frozen-hdr-many', markdown: MANY_TABLES_MARKDOWN }]);
+ await page.goto(`${workerServer.baseURL}/#/frozen-hdr-many`);
+ await waitForActiveProviderSynced(page);
+ await page.locator('table').first().waitFor({ state: 'attached' });
+ await waitForQuiescence(page, SCROLL_SELECTOR);
+ await twoFrames(page);
+
+ const skippedTables = await page.evaluate(
+ () =>
+ Array.from(
+ document.querySelectorAll<HTMLElement>('.ProseMirror .tableWrapper > table'),
+ ).filter((table) => !table.checkVisibility({ contentVisibilityAuto: true })).length,
+ );
+ expect(skippedTables).toBeGreaterThanOrEqual(10);
+
+ await page.evaluate(() => {
+ const editor = window.__activeEditor;
+ if (!editor) throw new Error('window.__activeEditor not set');
+ const PluginCtor = editor.state.plugins[0].constructor as new (spec: object) => never;
+ editor.registerPlugin(new PluginCtor({}));
+ });
+ await twoFrames(page);
+
+ const cdp = await page.context().newCDPSession(page);
+ await cdp.send('Performance.enable');
+ const layoutCount = async (): Promise<number> => {
+ const { metrics } = await cdp.send('Performance.getMetrics');
+ return metrics.find((m) => m.name === 'LayoutCount')?.value ?? Number.NaN;
+ };
+
+ const before = await layoutCount();
+ await page.evaluate(
+ (sel) =>
+ new Promise<void>((resolve) => {
+ const scrollEl = document.querySelector(sel) as HTMLElement;
+ scrollEl.style.width = `${scrollEl.clientWidth - 240}px`;
+ requestAnimationFrame(() =>
+ requestAnimationFrame(() => requestAnimationFrame(() => resolve())),
+ );
+ }),
+ SCROLL_SELECTOR,
+ );
+ const layouts = (await layoutCount()) - before;
+ await cdp.detach();
+ expect(layouts, `one width change ran ${layouts} layouts`).toBeLessThan(skippedTables / 2);
+
+ const misplacedBars = await page.evaluate(() =>
+ Array.from(document.querySelectorAll<HTMLElement>('.ProseMirror .tableWrapper')).flatMap(
+ (wrapper, index) => {
+ const controls = Array.from(
+ document.querySelectorAll<HTMLElement>('.ok-table-insert-controls'),
+ )[index];
+ const table = wrapper.getBoundingClientRect();
+ const column = controls?.querySelector('.ok-table-insert-column')?.getBoundingClientRect();
+ const row = controls?.querySelector('.ok-table-insert-row')?.getBoundingClientRect();
+ if (!column || !row) return [`table ${index}: no insert bars`];
+ const errors = {
+ columnLeft: column.left - table.right,
+ columnTop: column.top - table.top,
+ columnHeight: column.height - table.height,
+ rowLeft: row.left - table.left,
+ rowTop: row.top - table.bottom,
+ rowWidth: row.width - table.width,
+ };
+ return Object.entries(errors)
+ .filter(([, delta]) => Math.abs(delta) > 1)
+ .map(([edge, delta]) => `table ${index}: ${edge} off by ${delta}px`);
+ },
+ ),
+ );
+ expect(misplacedBars).toEqual([]);
+});
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index 2a597ec3d..f4cc8a286 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index ffd8fce06..e7e63f43d 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,4 +1,3 @@
-
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index fb0ba5a7c..fc267cbea 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index fa3cfcd86..bfd7e3109 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 8be632ba4..4d3250d3a 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,4 +1,3 @@
-
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');