Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Replace three source-text checks with runtime tests (#5349)

Nick Gomez1af7fca47490
diff --git a/.github/scripts/release-cascade-shape.test.mjs b/.github/scripts/release-cascade-shape.test.mjs
index 1198039e2..db57d8e09 100644
--- a/.github/scripts/release-cascade-shape.test.mjs
+++ b/.github/scripts/release-cascade-shape.test.mjs
@@ -909,19 +909,70 @@ describe('every release-pipeline post prefers the releases webhook', () => {
});
}
- test('the aggregate smoke alarm resolves the releases webhook first', () => {
+ test('the aggregate smoke alarm resolves the releases webhook first', async () => {
const alarm = stepAfter(selectBeta, 'Page the release channel');
expect(alarm).toContain(
'SLACK_RELEASES_WEBHOOK_URL: ${{ secrets.SLACK_RELEASES_WEBHOOK_URL }}',
);
expect(alarm).toContain('node .github/scripts/release-alert-state.mjs');
- const reporter = readFileSync(
- join(WORKFLOWS, '..', 'scripts', 'release-alert-state.mjs'),
- 'utf8',
- );
- expect(reporter).toContain(
- 'process.env.SLACK_RELEASES_WEBHOOK_URL || process.env.SLACK_WEBHOOK_URL',
- );
+ const { execFile } = await import('node:child_process');
+ const { createServer } = await import('node:http');
+ const requests = [];
+ const server = createServer((request, response) => {
+ requests.push(request.url);
+ request.resume();
+ response.end('ok');
+ });
+ const dir = mkdtempSync(join(tmpdir(), 'ok-webhook-precedence-'));
+ try {
+ await new Promise((resolve, reject) => {
+ server.once('error', reject);
+ server.listen(0, '127.0.0.1', resolve);
+ });
+ const origin = `http://127.0.0.1:${server.address().port}`;
+ let index = 0;
+ const state = (value) => (value === undefined ? 'unset' : value ? 'set' : 'empty');
+ for (const releases of [undefined, '', `${origin}/releases`]) {
+ for (const fallback of [undefined, '', `${origin}/fallback`]) {
+ requests.length = 0;
+ const label = `releases webhook ${state(releases)}, fallback webhook ${state(fallback)}`;
+ const statePath = join(dir, `state-${index++}.json`);
+ const env = {
+ ...process.env,
+ ALERT_STATE_PATH: statePath,
+ ALERT_INCIDENT: 'smoke-failure',
+ ALERT_TEXT: 'webhook precedence test',
+ };
+ delete env.SLACK_RELEASES_WEBHOOK_URL;
+ delete env.SLACK_WEBHOOK_URL;
+ delete env.GITHUB_OUTPUT;
+ delete env.NODE_OPTIONS;
+ if (releases !== undefined) env.SLACK_RELEASES_WEBHOOK_URL = releases;
+ if (fallback !== undefined) env.SLACK_WEBHOOK_URL = fallback;
+ const result = await new Promise((resolve) => {
+ execFile(
+ process.execPath,
+ [join(WORKFLOWS, '..', 'scripts', 'release-alert-state.mjs')],
+ { env, timeout: 5_000 },
+ (error, _stdout, stderr) => resolve({ error, stderr }),
+ );
+ });
+ const target = releases ? '/releases' : fallback ? '/fallback' : undefined;
+ const ended = result.error?.signal ?? `exit code ${result.error ? result.error.code : 0}`;
+ const outcome = `${label}, reporter ended with ${ended}: ${result.stderr}`;
+ expect(requests, outcome).toEqual(target ? [target] : []);
+ expect(result.error ? result.error.code : 0, outcome).toBe(target ? 0 : 1);
+ expect(existsSync(statePath), outcome).toBe(Boolean(target));
+ }
+ }
+ } finally {
+ rmSync(dir, { recursive: true, force: true });
+ if (server.listening) {
+ await new Promise((resolve, reject) => {
+ server.close((error) => (error ? reject(error) : resolve()));
+ });
+ }
+ }
});
test('fast-tier attempts have one incident reporter and save only successful acknowledgements', () => {
diff --git a/knip.config.ts b/knip.config.ts
index be41ab16c..37d9ce912 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -145,11 +145,15 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: ['@types/shell-quote'],
+ ignoreDependencies: [
+ '@types/shell-quote',
+ ],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
- ignoreDependencies: ['yjs'],
+ ignoreDependencies: [
+ 'yjs',
+ ],
},
'packages/desktop': {
entry: [
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index 8a60e5826..a28cc2b18 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,3 +1,4 @@
+
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/conflict-gate-coverage.test.ts b/packages/app/tests/integration/conflict-gate-coverage.test.ts
index b92b45c21..35c4173a5 100644
--- a/packages/app/tests/integration/conflict-gate-coverage.test.ts
+++ b/packages/app/tests/integration/conflict-gate-coverage.test.ts
@@ -1,11 +1,19 @@
+import { randomUUID } from 'node:crypto';
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { describe, expect, test } from 'vitest';
+import {
+ AgentSessionManager,
+ applyAgentMarkdownWrite,
+ applyAgentUndo,
+} from '../../../server/src/agent-sessions.ts';
+import { DocInConflictError } from '../../../server/src/conflict-errors.ts';
import {
extractRouteHandlerNames,
HANDLER_RUN_END_NEEDLES,
listNativeRouteFiles,
} from '../native-route-files.test-helper.ts';
+import { createTestServer } from './test-harness.ts';
const API_EXT_PATH = join(import.meta.dirname, '../../../server/src/api-extension.ts');
const source = readFileSync(API_EXT_PATH, 'utf8');
@@ -233,13 +241,63 @@ describe('conflict-gate coverage (FR9)', () => {
expect(untracked).toEqual([]);
});
- test('spine-level gate fires before transact in agent-sessions.ts', () => {
- const sessionsSrc = readFileSync(
- join(import.meta.dirname, '../../../server/src/agent-sessions.ts'),
- 'utf8',
- );
- expect(sessionsSrc).toContain('throw new DocInConflictError');
- const throwMatches = sessionsSrc.match(/throw new DocInConflictError/g) ?? [];
- expect(throwMatches.length).toBeGreaterThanOrEqual(2);
+ test('spine-level gate refuses writes and undo before any document transaction', async () => {
+ const server = await createTestServer();
+ const manager = new AgentSessionManager(server.instance.hocuspocus);
+ try {
+ for (const operation of [
+ 'append',
+ 'prepend',
+ 'replace',
+ 'patch',
+ 'last',
+ 'session',
+ 'count',
+ ] as const) {
+ const label = `${operation} must be refused with DocInConflictError`;
+ const docName = `conflict-gate-${randomUUID()}`;
+ const session = await manager.getSession(docName, 'conflict-gate');
+ const document = session.dc.document;
+ document.transact(() => {
+ applyAgentMarkdownWrite(document, 'Before conflict.\n', 'replace');
+ }, session.origin);
+ session.um.stopCapturing();
+ const before = document.getText('source').toString();
+ const fragmentBefore = document.getXmlFragment('default').toJSON();
+ const undoBefore = session.um.undoStack.length;
+ expect(before, label).toBe('Before conflict.\n');
+ expect(undoBefore, label).toBeGreaterThan(0);
+ server.instance.conflicts.raise({
+ kind: 'reconcile',
+ file: `${docName}.md`,
+ reason: 'disk-markers',
+ stages: { base: before, ours: before, theirs: 'Other.\n' },
+ });
+ expect(server.instance.conflicts.has(docName), label).toBe(true);
+ let transactions = 0;
+ const observe = () => {
+ transactions += 1;
+ };
+ document.on('beforeTransaction', observe);
+ try {
+ expect(() => {
+ if (operation === 'last' || operation === 'session' || operation === 'count') {
+ applyAgentUndo(session, operation, undefined, 1);
+ } else {
+ applyAgentMarkdownWrite(document, 'Forbidden.\n', operation);
+ }
+ }, label).toThrow(DocInConflictError);
+ expect(document.getText('source').toString(), label).toBe(before);
+ expect(document.getXmlFragment('default').toJSON(), label).toBe(fragmentBefore);
+ expect(session.um.undoStack, label).toHaveLength(undoBefore);
+ expect(transactions, label).toBe(0);
+ } finally {
+ document.off('beforeTransaction', observe);
+ }
+ }
+ } finally {
+ await manager.closeAll();
+ await server.cleanup();
+ }
});
});
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 6fcdc23f2..4fc2c11f9 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 40b5cdfd6..9f2f6feb6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 93666af70..2a085742b 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 867598d34..878d5196b 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 0970ac12f..4ada3cf26 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index b632185e1..cbe2b705f 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,3 +1,4 @@
+
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index c530ce4ba..89bc9b4d9 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index d3767adc9..a78aeb0e4 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,3 +1,4 @@
+
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index b076f955c..e7cc69c3f 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,3 +1,4 @@
+
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 7935e35f8..9ddcd0730 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index f4cc8a286..2a597ec3d 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 8fb428b90..01ef76a9f 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,3 +1,4 @@
+
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index fc267cbea..fb0ba5a7c 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index bfd7e3109..fa3cfcd86 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 4d3250d3a..8be632ba4 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,3 +1,4 @@
+
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');
diff --git a/packages/server/src/api-agent-integrations-composition.test.ts b/packages/server/src/api-agent-integrations-composition.test.ts
index 33a59cd8c..e491d0da4 100644
--- a/packages/server/src/api-agent-integrations-composition.test.ts
+++ b/packages/server/src/api-agent-integrations-composition.test.ts
@@ -10,12 +10,7 @@ import {
import { afterEach, expect, test } from 'vitest';
import type { AgentRegistryHostSeam } from './agent-registry-apply.ts';
import type { BootedServer } from './boot.ts';
-import {
- assertPathAbsentFromLegacyRegistry,
- bootCompositionRig,
- parseProblem,
- rawRequest,
-} from './composition-rig.test-helper.ts';
+import { bootCompositionRig, parseProblem, rawRequest } from './composition-rig.test-helper.ts';
const APPLY_PATH = '/api/agent-integrations/apply';
const CLAUDE_PROJECT_MCP = 'claude/mcp/project/config-entry';
@@ -37,8 +32,6 @@ function assertExclusiveNativeOwnership(server: BootedServer): void {
expect(server.serverInstance.nativeApi.paths.filter((path) => path === APPLY_PATH)).toHaveLength(
1,
);
- const source = readFileSync(new URL('./api-extension.ts', import.meta.url), 'utf8');
- assertPathAbsentFromLegacyRegistry(source, APPLY_PATH);
}
async function bootApplyComposition(