Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Show update download failures and checking state (part of PRD-9079) (#5799)
Andrew Mikofalvy1f20cae5c25c
diff --git a/.changeset/prd-9079-update-check-feedback.md b/.changeset/prd-9079-update-check-feedback.mdnew file mode 100644index 000000000..bd6f75b97--- /dev/null+++ b/.changeset/prd-9079-update-check-feedback.md@@ -0,0 +1,5 @@+---+"@inkeep/open-knowledge": patch+---++When **Check for updates…** finds a new version but its download fails, the app now shows an error instead of staying silent, and "Checking for updates…" stays visible during the check, including in Settings.diff --git a/docs/content/reference/what-open-knowledge-writes.mdx b/docs/content/reference/what-open-knowledge-writes.mdxindex 835dbe1a3..b95205cdf 100644--- a/docs/content/reference/what-open-knowledge-writes.mdx+++ b/docs/content/reference/what-open-knowledge-writes.mdx@@ -66,7 +66,7 @@ On every platform the app writes app-level state and logs on launch. The table b| `~/Library/Application Support/OpenKnowledge/bug-report-main-thread-stall.json` | Main-thread stall snapshot. When the liveness witness first sees the main thread blocked for at least 15 seconds, the same background worker writes this file at once, then briefly pauses the main thread to read where it is and resumes it straight away. It holds function names and script locations from the app's own code, and the Node.js runtime beneath it, at the moment of a freeze: at most 24 frames, never document content. A freeze inside native code only lets the pause land once the main thread returns to the app's code, so the file records how long that took, and a session that ended before then keeps the record written when the freeze was first seen. One snapshot per freeze; a later freeze in the same session overwrites it, through a `.tmp-` sibling during each write. A freeze the app recovers from is also noted in the desktop log as it recovers. Read at the next launch; left in place on a clean quit and overwritten by the next freeze. It does not change whether the app prompts you | Outside-project (home dir) || `~/Library/Application Support/OpenKnowledge/bug-report-main-exit.json` | Main-process exit record. Written only when the main process exits without the app having marked a clean quit, for example when code ends the process directly instead of going through the normal quit path. It holds the session's identifier, the time, and the exit code. A crash or a forced kill never gets to write it, which is how the next launch tells those endings apart from an exit the app ran itself. Read only at the next launch, where the result lands in the desktop log a bug report carries; left in place and overwritten by the next such exit. It does not change whether the app prompts you | Outside-project (home dir) |-Stable registers `openknowledge://`; Beta registers `openknowledge-beta://`. Both check for updates — on launch and periodically while running — against separate Stable/Beta paths on the OpenKnowledge update service at `openknowledge.ai/updates`, which redirects to the matching GitHub release asset and counts the update per version and channel (Stable alone can fall back to GitHub directly if the proxy is unreachable). On macOS and Windows an update on your channel downloads in the background and installs on the next quit; on Linux — where there is no apt/rpm repository — the app downloads the new deb/rpm from the release feed and asks you to authorize the install (a `pkexec` password prompt) each time. You can also check on demand from **Check for updates…** in the app and Help menus. The channel is fixed by the product you installed. Older Beta installations named `OpenKnowledge` continue receiving Beta updates in place, preserving their existing settings and CLI commands; they do not silently become the separately installed `OpenKnowledge Beta` app. Reinstall Stable from `openknowledge.ai/download` or Beta from `openknowledge.ai/download/beta`; Windows and Linux installers are available from [GitHub Releases](https://github.com/inkeep/open-knowledge/releases). Override the feed with `OK_UPDATER_FEED_URL`.+Stable registers `openknowledge://`; Beta registers `openknowledge-beta://`. Both check for updates — on launch and periodically while running — against separate Stable/Beta paths on the OpenKnowledge update service at `openknowledge.ai/updates`, which redirects to the matching GitHub release asset and counts the update per version and channel (Stable alone can fall back to GitHub directly if the proxy is unreachable). On macOS and Windows an update on your channel downloads in the background and installs on the next quit; on Linux — where there is no apt/rpm repository — the app downloads the new deb/rpm from the release feed and asks you to authorize the install (a `pkexec` password prompt) each time. You can also check on demand from **Check for updates…** in the app and Help menus; if the check finds a new version but its download fails, the app tells you so you can try again. The channel is fixed by the product you installed. Older Beta installations named `OpenKnowledge` continue receiving Beta updates in place, preserving their existing settings and CLI commands; they do not silently become the separately installed `OpenKnowledge Beta` app. Reinstall Stable from `openknowledge.ai/download` or Beta from `openknowledge.ai/download/beta`; Windows and Linux installers are available from [GitHub Releases](https://github.com/inkeep/open-knowledge/releases). Override the feed with `OK_UPDATER_FEED_URL`.On its first launch the app also opens your default browser once to `openknowledge.ai/continue`, to check whether you installed from a share link and redeem it if so; the exchange completes over a short-lived local loopback listener.diff --git a/knip.config.ts b/knip.config.tsindex 65f0e8807..d3638888e 100644--- a/knip.config.ts+++ b/knip.config.ts@@ -147,11 +147,15 @@ export default {'packages/server': {entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],project: 'src/**',- ignoreDependencies: ['@types/shell-quote'],+ ignoreDependencies: [+ '@types/shell-quote',+ ],},'packages/cli': {entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],- ignoreDependencies: ['yjs'],+ ignoreDependencies: [+ 'yjs',+ ],},'packages/desktop': {entry: [diff --git a/packages/app/src/components/UpdateNotices.shared.ts b/packages/app/src/components/UpdateNotices.shared.tsindex 859f4e7ab..1e31fa4d8 100644--- a/packages/app/src/components/UpdateNotices.shared.ts+++ b/packages/app/src/components/UpdateNotices.shared.ts@@ -55,9 +55,12 @@ export interface UpdateNotice {const PRIORITY_SCHEMA_INCOMPATIBILITY = 0;const PRIORITY_STUCK_HINT = 0;const PRIORITY_RELAUNCH_ERROR = 1;-const PRIORITY_UPDATE_DOWNLOADED = 2;+const PRIORITY_RELAUNCH_IN_PROGRESS = 2;const PRIORITY_MANUAL_CHECK = 3;-const PRIORITY_WHATS_NEW = 4;+const PRIORITY_UPDATE_DOWNLOADED = 4;+const PRIORITY_WHATS_NEW = 5;++export const UPDATE_CHECKING_NOTICE_ID = 'update-checking';export const WHATS_NEW_AUTO_DISMISS_MS = 60_000;const MANUAL_CHECK_AUTO_DISMISS_MS = MANUAL_CHECK_NOTICE_EXPIRY_MS;@@ -83,7 +86,7 @@ export function attachUpdateSubscribers(const downloadedNoticeId = 'update-downloaded';const noLongerPendingNoticeId = 'update-no-longer-pending';- const manualCheckNoticeId = 'update-checking';+ const manualCheckNoticeId = UPDATE_CHECKING_NOTICE_ID;unsubscribers.push(bridge.onUpdateDownloaded(({ version }) => {@@ -101,7 +104,7 @@ export function attachUpdateSubscribers(addNotice({id: noticeId,body: TOAST_A_PROGRESS_BODY,- priority: PRIORITY_UPDATE_DOWNLOADED,+ priority: PRIORITY_RELAUNCH_IN_PROGRESS,dismissible: false,});bridge.update.relaunchNow().then(@@ -132,7 +135,7 @@ export function attachUpdateSubscribers(addNotice({id: downloadedNoticeId,body: TOAST_A_PROGRESS_BODY,- priority: PRIORITY_UPDATE_DOWNLOADED,+ priority: PRIORITY_RELAUNCH_IN_PROGRESS,dismissible: false,});}),@@ -143,7 +146,7 @@ export function attachUpdateSubscribers(addNotice({id: downloadedNoticeId,body: TOAST_A_FETCHING_LATEST_BODY,- priority: PRIORITY_UPDATE_DOWNLOADED,+ priority: PRIORITY_RELAUNCH_IN_PROGRESS,dismissible: false,});}),diff --git a/packages/app/src/components/UpdateNotices.test.ts b/packages/app/src/components/UpdateNotices.test.tsindex f568623a3..527df4c45 100644--- a/packages/app/src/components/UpdateNotices.test.ts+++ b/packages/app/src/components/UpdateNotices.test.ts@@ -660,7 +660,7 @@ describe('Notice A — ok:update:downloaded', () => {expect(notice.id).toBe('update-downloaded');expect(notice.action?.label).toBe(TOAST_A_ACTION);expect(notice.variant).toBeUndefined();- expect(notice.priority).toBe(2);+ expect(notice.priority).toBe(4);expect(notice.dismissible).toBeUndefined();});@@ -822,7 +822,7 @@ describe('Notice B — ok:update:whats-new', () => {expect(notice.id).toBe('whats-new-0.3.1');expect(notice.action?.label).toBe(TOAST_B_ACTION);expect(notice.variant).toBe('success');- expect(notice.priority).toBe(4);+ expect(notice.priority).toBe(5);notice.action?.onClick();expect(bridge.shell.openExternal).toHaveBeenCalledWith(releaseUrl);});@@ -1072,9 +1072,9 @@ describe('Notice E — schema-incompatibility refuse-downgrade', () => {});describe('pickActiveNotice', () => {- const a: UpdateNotice = { id: 'a', body: 'A', priority: 2 };+ const a: UpdateNotice = { id: 'a', body: 'A', priority: 4 };const checking: UpdateNotice = { id: 'update-checking', body: 'Checking', priority: 3 };- const b: UpdateNotice = { id: 'b', body: 'B', priority: 4 };+ const b: UpdateNotice = { id: 'b', body: 'B', priority: 5 };const c: UpdateNotice = { id: 'c', body: 'C', priority: 0 };const err: UpdateNotice = { id: 'err', body: 'Err', priority: 1, variant: 'error' };@@ -1094,14 +1094,60 @@ describe('pickActiveNotice', () => {expect(pickActiveNotice([b, a])).toBe(a);});- test('checking ranks below update notices and above whats-new', () => {+ test('checking outranks the ready card and whats-new but not errors, stuck hint or schema', () => {expect(pickActiveNotice([b, checking])).toBe(checking);- expect(pickActiveNotice([b, checking, a])).toBe(a);+ expect(pickActiveNotice([b, checking, a])).toBe(checking);expect(pickActiveNotice([b, checking, err])).toBe(err);expect(pickActiveNotice([b, checking, c])).toBe(c);});- test('relaunch-error (1) wins over A (2) and B (4) but not C (0)', () => {+ test('an in-flight manual check shows over the ready card and gives it back when it settles', () => {+ const bridge = makeFakeBridge();+ let notices: UpdateNotice[] = [];+ attachUpdateSubscribers(+ castBridge(bridge),+ (notice) => {+ notices = [...notices.filter((n) => n.id !== notice.id), notice];+ },+ (id) => {+ notices = notices.filter((n) => n.id !== id);+ },+ );++ bridge._downloaded?.({ version: '0.1.1' });+ bridge._manualCheck?.({ phase: 'started' });+ expect(pickActiveNotice(notices)?.id).toBe('update-checking');++ bridge._manualCheck?.({ phase: 'settled' });+ expect(pickActiveNotice(notices)?.id).toBe('update-downloaded');+ });++ test.each(['relaunching', 'fetching-latest'] as const)(+ 'a manual check started during a relaunch (%s) keeps the relaunch progress on top',+ (stage) => {+ const bridge = makeFakeBridge();+ let notices: UpdateNotice[] = [];+ attachUpdateSubscribers(+ castBridge(bridge),+ (notice) => {+ notices = [...notices.filter((n) => n.id !== notice.id), notice];+ },+ (id) => {+ notices = notices.filter((n) => n.id !== id);+ },+ );++ bridge._downloaded?.({ version: '0.1.1' });+ if (stage === 'relaunching') bridge._relaunching?.({ version: '0.1.1' });+ else bridge._fetchingLatest?.({ version: '0.1.1' });+ bridge._manualCheck?.({ phase: 'started' });+ expect(pickActiveNotice(notices)?.body).toBe(+ stage === 'relaunching' ? TOAST_A_PROGRESS_BODY : TOAST_A_FETCHING_LATEST_BODY,+ );+ },+ );++ test('relaunch-error (1) wins over A (4) and B (5) but not C (0)', () => {expect(pickActiveNotice([a, b, err])).toBe(err);expect(pickActiveNotice([a, b, err, c])).toBe(c);});diff --git a/packages/app/src/components/settings/SettingsDialogShell.tsx b/packages/app/src/components/settings/SettingsDialogShell.tsxindex bd8b5d450..17bfbd83a 100644--- a/packages/app/src/components/settings/SettingsDialogShell.tsx+++ b/packages/app/src/components/settings/SettingsDialogShell.tsx@@ -5,10 +5,11 @@import { SHOW_INSTALL_SKILL } from '@inkeep/open-knowledge-core/constants/feature-flags';import { Plural, Trans, useLingui } from '@lingui/react/macro';import { ArrowUpRight } from 'lucide-react';-import { Suspense, useEffect, useRef, useState } from 'react';+import { Suspense, useEffect, useRef, useState, useSyncExternalStore } from 'react';import { matchesCommandQuery, splitTextByQueryMatches } from '@/components/command-palette-search';import { SettingsDialogBodyLazy } from '@/components/settings/SettingsDialogBodyLazy';import { SettingsDialogErrorBoundary } from '@/components/settings/SettingsDialogErrorBoundary';+import { UPDATE_CHECKING_NOTICE_ID } from '@/components/UpdateNotices.shared';import {Command,CommandEmpty,@@ -24,6 +25,7 @@ import { useDocumentContext } from '@/editor/DocumentContext';import { useConfigContext } from '@/lib/config-provider';import { isFileProtocolPage } from '@/lib/file-protocol-page';import { useClaudeDesktopIntegration } from '@/lib/handoff/use-claude-desktop-integration';+import { getNoticesSnapshot, subscribeToNotices } from '@/lib/update-notices-store';import { subscribeToSettingsSection } from '@/lib/use-settings-route';import { cn } from '@/lib/utils';import { LINT_PLUGIN_META } from './lint-plugin-meta';@@ -551,9 +553,12 @@ function SettingsSearchResultItem({}function SettingsSidebarVersion() {+ const { t } = useLingui();+ const notices = useSyncExternalStore(subscribeToNotices, getNoticesSnapshot, getNoticesSnapshot);const bridge = typeof window !== 'undefined' ? (window.okDesktop ?? null) : null;const version = bridge?.appVersion;if (!bridge || !version) return null;+ const checkingForUpdates = notices.some((notice) => notice.id === UPDATE_CHECKING_NOTICE_ID);const url = releaseNotesUrl(version);return (@@ -564,6 +569,13 @@ function SettingsSidebarVersion() {>v{version}</p>+ <p+ role="status"+ className="whitespace-nowrap text-xs text-muted-foreground"+ data-testid="settings-sidebar-update-checking"+ >+ {checkingForUpdates ? t`Checking for updates…` : null}+ </p><buttontype="button"onClick={() => {diff --git a/packages/app/src/components/settings/SettingsDialogShell.update-checking.dom.test.tsx b/packages/app/src/components/settings/SettingsDialogShell.update-checking.dom.test.tsxnew file mode 100644index 000000000..f86b9abd9--- /dev/null+++ b/packages/app/src/components/settings/SettingsDialogShell.update-checking.dom.test.tsx@@ -0,0 +1,132 @@+import { act, cleanup, render, screen } from '@testing-library/react';+import type { ReactNode } from 'react';+import { afterAll, afterEach, describe, expect, test, vi } from 'vitest';++type WindowGlobals = { MutationObserver?: typeof MutationObserver; NodeFilter?: typeof NodeFilter };+type GlobalWithDomShims = typeof globalThis &+ WindowGlobals & { window?: WindowGlobals; ResizeObserver?: unknown };+const globalWithDomShims = globalThis as GlobalWithDomShims;+if (+ globalWithDomShims.MutationObserver === undefined &&+ globalWithDomShims.window?.MutationObserver !== undefined+) {+ globalWithDomShims.MutationObserver = globalWithDomShims.window.MutationObserver;+}+if (+ globalWithDomShims.NodeFilter === undefined &&+ globalWithDomShims.window?.NodeFilter !== undefined+) {+ globalWithDomShims.NodeFilter = globalWithDomShims.window.NodeFilter;+}+if (globalWithDomShims.ResizeObserver === undefined) {+ class NoopResizeObserver {+ observe() {}+ unobserve() {}+ disconnect() {}+ }+ globalWithDomShims.ResizeObserver = NoopResizeObserver;+}++vi.doMock('@/components/settings/SettingsDialogBodyLazy', () => ({+ SettingsDialogBodyLazy: () => <div data-testid="settings-body-probe" />,+}));++vi.doMock('@/components/ui/dialog', () => ({+ Dialog: ({ children, open }: { children?: ReactNode; open?: boolean }) =>+ open ? <div role="dialog">{children}</div> : null,+ DialogContent: ({ children, ...props }: { children?: ReactNode; [key: string]: unknown }) => (+ <div {...props}>{children}</div>+ ),+ DialogDescription: ({ children }: { children?: ReactNode }) => <p>{children}</p>,+ DialogTitle: ({ children, id }: { children?: ReactNode; id?: string }) => (+ <h2 id={id}>{children}</h2>+ ),+}));++vi.doMock('@/components/ui/skeleton', () => ({+ Skeleton: ({ className }: { className?: string }) => <div className={className} />,+}));++vi.doMock('@/editor/DocumentContext', () => ({+ useDocumentContext: () => ({ collabUrl: 'ws://test.invalid' }),+}));++vi.doMock('@/lib/config-provider', () => ({+ useConfigContext: () => ({+ userBinding: null,+ userSynced: false,+ okignoreBinding: null,+ okignoreSynced: false,+ }),+}));++vi.doMock('@/lib/handoff/use-claude-desktop-integration', () => ({+ useClaudeDesktopIntegration: () => ({ desktopPresent: false }),+}));++type ManualCheckListener = (info: { phase: 'started' | 'settled' }) => void;+let manualCheckListener: ManualCheckListener | null = null;+const unsubscribe = () => () => {};+(window as unknown as { okDesktop?: unknown }).okDesktop = {+ appVersion: '1.2.3',+ config: { ptyAvailable: false },+ shell: { openExternal: () => Promise.resolve() },+ onUpdateDownloaded: unsubscribe,+ onUpdateRelaunching: unsubscribe,+ onUpdateFetchingLatest: unsubscribe,+ onUpdateRelaunchFailed: unsubscribe,+ onWhatsNew: unsubscribe,+ onWhatsNewDismissed: unsubscribe,+ onUpdateStuckHint: unsubscribe,+ onUpdateManualCheck: (listener: ManualCheckListener) => {+ manualCheckListener = listener;+ return () => {};+ },+ update: {+ relaunchNow: () => Promise.resolve(),+ checkNow: () => Promise.resolve(),+ dismissWhatsNew: () => Promise.resolve(),+ },+ state: {+ query: () => Promise.resolve({ channel: 'latest', schemaIncompatibility: null }),+ resetIncompatible: () => Promise.resolve(),+ },+};++const { installUpdateNoticesBridge } = await import('@/lib/update-notices-store');+const { SettingsDialogShell } = await import('./SettingsDialogShell');+installUpdateNoticesBridge();++describe('SettingsDialogShell sidebar update-check status', () => {+ afterEach(() => {+ act(() => manualCheckListener?.({ phase: 'settled' }));+ cleanup();+ });+ afterAll(() => {+ Reflect.deleteProperty(window, 'okDesktop');+ });++ test('shows Checking for updates while a manual check runs and clears it when the check settles', () => {+ render(<SettingsDialogShell open={true} onOpenChange={() => {}} />);+ expect(screen.getByTestId('settings-sidebar-version').textContent).toBe('v1.2.3');+ const status = screen.getByTestId('settings-sidebar-update-checking');+ expect(status.getAttribute('role')).toBe('status');+ expect(status.textContent).toBe('');++ act(() => manualCheckListener?.({ phase: 'started' }));+ expect(screen.getByTestId('settings-sidebar-update-checking')).toBe(status);+ expect(status.textContent).toBe('Checking for updates…');++ act(() => manualCheckListener?.({ phase: 'settled' }));+ expect(screen.getByTestId('settings-sidebar-update-checking')).toBe(status);+ expect(status.textContent).toBe('');+ });++ test('a check already running when Settings opens shows at once', () => {+ act(() => manualCheckListener?.({ phase: 'started' }));+ render(<SettingsDialogShell open={true} onOpenChange={() => {}} />);+ expect(screen.getByTestId('settings-sidebar-update-checking').textContent).toBe(+ 'Checking for updates…',+ );+ });+});diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.poindex 43da6e76f..111d4f800 100644--- a/packages/app/src/locales/ar/messages.po+++ b/packages/app/src/locales/ar/messages.po@@ -2977,6 +2977,7 @@ msgstr "يجري التحقق من التحديثات"msgid "Checking for updates on GitHub"msgstr "يجري التحقق من التحديثات على GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "يجري التحقق من التحديثات…"diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.poindex 930d725cf..f1afece2c 100644--- a/packages/app/src/locales/bn/messages.po+++ b/packages/app/src/locales/bn/messages.po@@ -2973,6 +2973,7 @@ msgstr "হালনাগাদ দেখা হচ্ছে"msgid "Checking for updates on GitHub"msgstr "GitHub-এ হালনাগাদ দেখা হচ্ছে"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "হালনাগাদ দেখা হচ্ছে…"diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.poindex a199d9215..36bee9b6c 100644--- a/packages/app/src/locales/en/messages.po+++ b/packages/app/src/locales/en/messages.po@@ -2977,6 +2977,7 @@ msgstr "Checking for updates"msgid "Checking for updates on GitHub"msgstr "Checking for updates on GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Checking for updates…"diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.poindex c08c235f7..0465df5d2 100644--- a/packages/app/src/locales/es/messages.po+++ b/packages/app/src/locales/es/messages.po@@ -2977,6 +2977,7 @@ msgstr "Buscando actualizaciones"msgid "Checking for updates on GitHub"msgstr "Buscando actualizaciones en GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Buscando actualizaciones…"diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.poindex 681a9935a..32234e5fc 100644--- a/packages/app/src/locales/fr/messages.po+++ b/packages/app/src/locales/fr/messages.po@@ -2977,6 +2977,7 @@ msgstr "Recherche de mises à jour"msgid "Checking for updates on GitHub"msgstr "Recherche de mises à jour sur GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Recherche de mises à jour…"diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.poindex c0a5a3041..cd65dc225 100644--- a/packages/app/src/locales/hi/messages.po+++ b/packages/app/src/locales/hi/messages.po@@ -2973,6 +2973,7 @@ msgstr "अपडेट देखे जा रहे हैं"msgid "Checking for updates on GitHub"msgstr "GitHub पर अपडेट देखे जा रहे हैं"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "अपडेट देखे जा रहे हैं…"diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.poindex b495c823c..6d6ae836e 100644--- a/packages/app/src/locales/id/messages.po+++ b/packages/app/src/locales/id/messages.po@@ -2973,6 +2973,7 @@ msgstr "Memeriksa pembaruan"msgid "Checking for updates on GitHub"msgstr "Memeriksa pembaruan di GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Memeriksa pembaruan…"diff --git a/packages/app/src/locales/ko/messages.po b/packages/app/src/locales/ko/messages.poindex 5015af25b..e7529005d 100644--- a/packages/app/src/locales/ko/messages.po+++ b/packages/app/src/locales/ko/messages.po@@ -2977,6 +2977,7 @@ msgstr "업데이트 확인 중"msgid "Checking for updates on GitHub"msgstr "GitHub에서 업데이트 확인 중"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "업데이트 확인 중…"diff --git a/packages/app/src/locales/pl/messages.po b/packages/app/src/locales/pl/messages.poindex 51c0e1eb9..6b0ad9bd8 100644--- a/packages/app/src/locales/pl/messages.po+++ b/packages/app/src/locales/pl/messages.po@@ -2977,6 +2977,7 @@ msgstr "Sprawdzanie aktualizacji"msgid "Checking for updates on GitHub"msgstr "Sprawdzanie aktualizacji na GitHubie"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Sprawdzanie aktualizacji…"diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.poindex f2aa8f859..76f450773 100644--- a/packages/app/src/locales/pseudo/messages.po+++ b/packages/app/src/locales/pseudo/messages.po@@ -2973,6 +2973,7 @@ msgstr ""msgid "Checking for updates on GitHub"msgstr ""+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr ""diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.poindex c247c9d3b..f1c93e4da 100644--- a/packages/app/src/locales/pt-BR/messages.po+++ b/packages/app/src/locales/pt-BR/messages.po@@ -2973,6 +2973,7 @@ msgstr "Buscando atualizações"msgid "Checking for updates on GitHub"msgstr "Buscando atualizações no GitHub"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "Buscando atualizações…"diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.poindex 3321d9fed..bfd455cea 100644--- a/packages/app/src/locales/ur/messages.po+++ b/packages/app/src/locales/ur/messages.po@@ -2977,6 +2977,7 @@ msgstr "اپ ڈیٹس دیکھے جا رہے ہیں"msgid "Checking for updates on GitHub"msgstr "GitHub پر اپ ڈیٹس دیکھے جا رہے ہیں"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "اپ ڈیٹس دیکھے جا رہے ہیں…"diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.poindex 962caf55c..0b75976c8 100644--- a/packages/app/src/locales/zh-Hans/messages.po+++ b/packages/app/src/locales/zh-Hans/messages.po@@ -2977,6 +2977,7 @@ msgstr "正在检查更新"msgid "Checking for updates on GitHub"msgstr "正在 GitHub 上检查更新"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "正在检查更新…"diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.poindex e2cfe7156..e3edd3ee4 100644--- a/packages/app/src/locales/zh-Hant/messages.po+++ b/packages/app/src/locales/zh-Hant/messages.po@@ -2977,6 +2977,7 @@ msgstr "正在檢查更新"msgid "Checking for updates on GitHub"msgstr "正在 GitHub 上檢查更新"+#: src/components/settings/SettingsDialogShell.tsx#: src/components/UpdateNotices.shared.tsmsgid "Checking for updates…"msgstr "正在檢查更新…"diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.tsindex a50b00123..4549c74b3 100644--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts@@ -1,3 +1,4 @@+import { readFileSync } from 'node:fs';import { join } from 'node:path';import { setTimeout as wait } from 'node:timers/promises';diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.tsindex 6fcdc23f2..4fc2c11f9 100644--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts@@ -1,3 +1,4 @@+import { setTimeout as wait } from 'node:timers/promises';import { normalizeBridge } from '@inkeep/open-knowledge-core';import { updateYFragment } from '@tiptap/y-tiptap';diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.tsindex 40b5cdfd6..9f2f6feb6 100644--- a/packages/app/tests/integration/interior-edit-freshness.test.ts+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts@@ -1,3 +1,4 @@+import { setTimeout as wait } from 'node:timers/promises';import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';import { afterAll, beforeAll, describe, expect, test } from 'vitest';diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.tsindex 93666af70..2a085742b 100644--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts@@ -1,3 +1,4 @@+import { setTimeout as wait } from 'node:timers/promises';import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';import { afterAll, beforeAll, describe, expect, test } from 'vitest';diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.tsindex 867598d34..878d5196b 100644--- a/packages/app/tests/integration/producer-guard-wiring.test.ts+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts@@ -1,3 +1,4 @@+import { setTimeout as wait } from 'node:timers/promises';import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';import { afterAll, beforeAll, describe, expect, test } from 'vitest';diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.tsindex 0970ac12f..4ada3cf26 100644--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts@@ -1,3 +1,4 @@+import { randomUUID } from 'node:crypto';import { afterEach, describe, expect, test } from 'vitest';import { agentWriteMd, createTestServer, type TestServer } from './test-harness';diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.tsindex b632185e1..cbe2b705f 100644--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts@@ -1,3 +1,4 @@+import { execFileSync } from 'node:child_process';import { randomUUID } from 'node:crypto';import { join } from 'node:path';diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.tsindex c530ce4ba..89bc9b4d9 100644--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts@@ -1,3 +1,4 @@+import { randomUUID } from 'node:crypto';import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';import type * as Y from 'yjs';diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.tsindex d3767adc9..a78aeb0e4 100644--- a/packages/app/tests/integration/undo-after-rollback.test.ts+++ b/packages/app/tests/integration/undo-after-rollback.test.ts@@ -1,3 +1,4 @@+import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';import { afterAll, beforeAll, describe, expect, test } from 'vitest';import * as Y from 'yjs';diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.tsindex b076f955c..e7cc69c3f 100644--- a/packages/app/tests/integration/undo-recycle-reset.test.ts+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts@@ -1,3 +1,4 @@+import { writeFileSync } from 'node:fs';import { join } from 'node:path';import { setTimeout as wait } from 'node:timers/promises';diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.tsindex 7935e35f8..9ddcd0730 100644--- a/packages/app/tests/integration/undo-rederive-survival.test.ts+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts@@ -1,3 +1,4 @@+import { prependFrontmatter } from '@inkeep/open-knowledge-core';import { Plugin, PluginKey } from '@tiptap/pm/state';import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.tsindex f4cc8a286..2a597ec3d 100644--- a/packages/core/src/bridge/compose.ts+++ b/packages/core/src/bridge/compose.ts@@ -1,3 +1,4 @@+import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.tsindex 8fb428b90..01ef76a9f 100644--- a/packages/core/src/bridge/doc-boundary-space.ts+++ b/packages/core/src/bridge/doc-boundary-space.ts@@ -1,3 +1,4 @@+import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.tsindex fc267cbea..fb0ba5a7c 100644--- a/packages/core/src/markdown/comment-promoter.ts+++ b/packages/core/src/markdown/comment-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.tsindex bfd7e3109..fa3cfcd86 100644--- a/packages/core/src/markdown/merged-walker.ts+++ b/packages/core/src/markdown/merged-walker.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, Root } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.tsindex 4d3250d3a..8be632ba4 100644--- a/packages/core/src/markdown/safe-url.ts+++ b/packages/core/src/markdown/safe-url.ts@@ -1,3 +1,4 @@+export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');diff --git a/packages/desktop/src/main/auto-updater.ts b/packages/desktop/src/main/auto-updater.tsindex 68ce86dfa..519ec74ea 100644--- a/packages/desktop/src/main/auto-updater.ts+++ b/packages/desktop/src/main/auto-updater.ts@@ -92,6 +92,7 @@ export type DispatchKind =| 'check-now-watchdog-fired'| 'check-now-relaunch-chosen'| 'check-now-ready-reoffered'+ | 'check-now-download-failed-shown'| 'toast-a-deferred-post-update-quiet'| 'toast-a-quiet-window-elapsed';@@ -144,6 +145,7 @@ type CheckNowResult =}| { kind: 'not-available'; currentVersion: string }| { kind: 'updater-inactive' }+ | { kind: 'download-failed'; latestVersion: string; message: string }| { kind: 'error'; message: string };export interface StartAutoUpdaterHandle {@@ -199,6 +201,8 @@ export const STUCK_HINT_DOWNLOAD_URL = 'https://github.com/inkeep/open-knowledgeexport const UPDATE_CHECK_FAILED_MESSAGE = 'The update check failed. Try again in a moment.';+export const UPDATE_DOWNLOAD_FAILED_MESSAGE = 'Try Check for updates… again in a few minutes.';+export const UPDATE_CHECK_WEDGED_MESSAGE = `OpenKnowledge is still waiting on the update server and will not check again until it restarts. Restart the app, or download the latest build from ${STUCK_HINT_DOWNLOAD_URL}.`;export const RELAUNCH_REFRESH_CHECK_MS = 4_000;@@ -578,6 +582,8 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHaif (retrySettled || destroyed) return;retrySettled = true;fallbackRetryPending = false;+ const owedDownloadFailure = menuDownloadFailureOwed;+ menuDownloadFailureOwed = null;if (outcome !== 'resolved') {const ctx = {code: errorCode(outcome.rejected),@@ -593,6 +599,7 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa});settleMenuCheck({ kind: 'not-available', currentVersion: getAppVersion() });}+ if (owedDownloadFailure !== null) reportMenuDownloadFailure(owedDownloadFailure);};void retryPromise.then(() => settleRetry('resolved'),@@ -692,6 +699,10 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHabroadcastToAllWindows('ok:update:manual-check', { phase: 'settled' });if (result === null) return;if (result.kind === 'ready-to-install') reofferStagedForMenuCheck(result.stagedVersion);+ presentCheckNowResult(result);+ };++ const presentCheckNowResult = (result: CheckNowResult): void => {let response: ReturnType<NonNullable<typeof showCheckNowResult>>;try {response = showCheckNowResult?.(result);@@ -750,6 +761,20 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHalet stagingInFlight: { version: string } | null = null;+ let menuDownloadFailureOwed: string | null = null;++ const downloadFailedResult = (version: string): CheckNowResult => ({+ kind: 'download-failed',+ latestVersion: version,+ message: UPDATE_DOWNLOAD_FAILED_MESSAGE,+ });++ const reportMenuDownloadFailure = (version: string): void => {+ if (destroyed) return;+ onDispatch?.('check-now-download-failed-shown');+ presentCheckNowResult(downloadFailedResult(version));+ };+let stagedThisSession: string | null = null;const declinedForStagedVersion = (offeredVersion: string | undefined): string | null => {@@ -929,6 +954,16 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa: 'channel-mismatch';};+ const reportedDownloadFailures = new WeakSet<Promise<unknown>>();++ const startDownload = (): { download: Promise<unknown>; threwSynchronously: boolean } => {+ try {+ return { download: updater.downloadUpdate(), threwSynchronously: false };+ } catch (err) {+ return { download: Promise.reject(err), threwSynchronously: true };+ }+ };+const onUpdateAvailable = (info: { version?: string }): void => {logger.info('update-available', { version: info.version });const offeredVersion = info.version;@@ -967,9 +1002,15 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa'x-ok-to-version': offeredVersion,};}- stagingInFlight = { version: offeredVersion ?? 'unknown' };+ const staging = {+ version: offeredVersion ?? 'unknown',+ fromMenuCheck: menuCheck !== null || menuDownloadFailureOwed !== null,+ };+ menuDownloadFailureOwed = null;+ stagingInFlight = staging;settleCheckWaiters('available');- void updater.downloadUpdate().catch((err: unknown) => {+ const { download, threwSynchronously } = startDownload();+ void download.catch((err: unknown) => {const code = err instanceof Error ? (err as Error & { code?: unknown }).code : undefined;const logFn = isClassifiedUpdaterError(err) ? logger.warn : logger.debug;logFn('downloadUpdate rejected', {@@ -981,7 +1022,23 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHastagingInFlight = null;settleStagingWaiters(false);}+ if (!staging.fromMenuCheck || destroyed) return;+ if (reportedDownloadFailures.has(download)) return;+ reportedDownloadFailures.add(download);+ if (fallbackRetryPending) {+ menuDownloadFailureOwed = staging.version;+ logger.info('menu-offered download failure deferred to the GitHub retry', {+ version: staging.version,+ });+ return;+ }+ reportMenuDownloadFailure(staging.version);});+ if (threwSynchronously && menuCheck !== null) {+ reportedDownloadFailures.add(download);+ onDispatch?.('check-now-download-failed-shown');+ settleMenuCheck(downloadFailedResult(staging.version));+ }};const onUpdateAvailableForMenuCheck = (info: { version?: string }): void => {@@ -1733,6 +1790,7 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHasettleMenuCheck(null);settleCheckWaiters('settled');stagingInFlight = null;+ menuDownloadFailureOwed = null;settleStagingWaiters(false);const detach = (event: string, handler: (...args: unknown[]) => void): void => {try {diff --git a/packages/desktop/src/main/index.ts b/packages/desktop/src/main/index.tsindex 3707215a0..79bb71248 100644--- a/packages/desktop/src/main/index.ts+++ b/packages/desktop/src/main/index.ts@@ -6875,7 +6875,16 @@ function bootPrimaryInstance(): void {message: "This copy of OpenKnowledge can't update itself.",detail: `Development builds don't receive automatic updates. To update, pull the latest source or download the newest release from ${STUCK_HINT_DOWNLOAD_URL}.`,});- } else {+ } else if (result.kind === 'download-failed') {+ void dialog.showMessageBox(target, {+ type: 'warning',+ buttons: ['OK'],+ defaultId: 0,+ title: "Couldn't Download the Update",+ message: `OpenKnowledge ${result.latestVersion} couldn't be downloaded.`,+ detail: result.message,+ });+ } else if (result.kind === 'error') {void dialog.showMessageBox(target, {type: 'warning',buttons: ['OK'],@@ -6884,6 +6893,9 @@ function bootPrimaryInstance(): void {message: "OpenKnowledge couldn't check for updates right now.",detail: result.message,});+ } else {+ const _exhaustive: never = result;+ return _exhaustive;}},});diff --git a/packages/desktop/tests/integration/auto-updater.test.ts b/packages/desktop/tests/integration/auto-updater.test.tsindex ac4a7829a..c6959db51 100644--- a/packages/desktop/tests/integration/auto-updater.test.ts+++ b/packages/desktop/tests/integration/auto-updater.test.ts@@ -29,6 +29,7 @@ import {UPDATE_CHECK_INTERVAL_MS,UPDATE_CHECK_JITTER_MS,UPDATE_CHECK_WEDGED_MESSAGE,+ UPDATE_DOWNLOAD_FAILED_MESSAGE,type UpdaterLike,versionAtLeast,} from '../../src/main/auto-updater.ts';@@ -4369,6 +4370,238 @@ describe('check-now → showCheckNowResult feedback dispatch', () => {});});+describe('a download that fails after the menu check said "available"', () => {+ const offered = { kind: 'available', currentVersion: '0.4.0', latestVersion: '0.5.0' } as const;+ const downloadFailed = {+ kind: 'download-failed',+ latestVersion: '0.5.0',+ message: UPDATE_DOWNLOAD_FAILED_MESSAGE,+ } as const;++ function assetMissing(): Error {+ return Object.assign(new Error('Cannot find OpenKnowledge-amd64.deb in the latest release'), {+ code: 'ERR_UPDATER_ASSET_NOT_FOUND',+ });+ }++ test.each(['error-then-reject', 'reject-only'] as const)(+ 'shows a download-failed dialog after the available dialog (%s)',+ async (failure) => {+ const showCheckNowResult = vi.fn(() => {});+ const { rig } = makeRig({+ appVersion: '0.4.0',+ platform: 'linux',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ });+ await Promise.resolve();+ rig.updater.downloadUpdate.mockImplementation(() =>+ failure === 'error-then-reject'+ ? rejectAfterErrorEvent(rig.updater, assetMissing())+ : Promise.reject(assetMissing()),+ );+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ expect(showCheckNowResult).toHaveBeenCalledExactlyOnceWith(offered);+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(showCheckNowResult.mock.calls).toEqual([[offered], [downloadFailed]]);+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);+ expect(rig.dispatches).toContain('check-now-download-failed-shown');+ },+ );++ test('a synchronous asset-not-found throw from downloadUpdate reports only the download failure', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const { rig } = makeRig({+ appVersion: '0.4.0',+ platform: 'linux',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ });+ await Promise.resolve();+ rig.updater.downloadUpdate.mockImplementation(() => {+ throw assetMissing();+ });+ rig.ipc.invoke('ok:update:check-now');+ expect(() => rig.updater.emit('update-available', { version: '0.5.0' })).not.toThrow();+ expect(showCheckNowResult).toHaveBeenCalledExactlyOnceWith(downloadFailed);+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(showCheckNowResult.mock.calls).toEqual([[downloadFailed]]);+ expect(rig.dispatches.filter((kind) => kind === 'check-now-download-failed-shown')).toEqual([+ 'check-now-download-failed-shown',+ ]);+ });++ test('two menu checks sharing one in-flight download report its failure once', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const download = Promise.withResolvers<never>();+ const { rig } = makeRig({+ appVersion: '0.4.0',+ platform: 'linux',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ updaterSetup: (updater) => {+ updater.downloadUpdate = vi.fn(() => download.promise);+ },+ });+ await Promise.resolve();+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ download.reject(assetMissing());+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(showCheckNowResult.mock.calls).toEqual([[offered], [offered], [downloadFailed]]);+ });++ test('a menu check that joins a background download in flight reports its failure once', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const download = Promise.withResolvers<never>();+ const { rig } = makeRig({+ appVersion: '0.4.0',+ platform: 'linux',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ updaterSetup: (updater) => {+ updater.downloadUpdate = vi.fn(() => download.promise);+ },+ });+ await Promise.resolve();+ rig.updater.emit('update-available', { version: '0.5.0' });+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ expect(rig.updater.downloadUpdate).toHaveBeenCalledTimes(2);+ download.reject(assetMissing());+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(showCheckNowResult.mock.calls).toEqual([[offered], [downloadFailed]]);+ });++ test('a launch or periodic download failure stays log-only', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const { rig } = makeRig({+ appVersion: '0.4.0',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ });+ await Promise.resolve();+ rig.updater.downloadUpdate.mockImplementation(() =>+ rejectAfterErrorEvent(rig.updater, assetMissing()),+ );+ rig.updater.emit('update-available', { version: '0.5.0' });+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(rig.updater.downloadUpdate).toHaveBeenCalledTimes(1);+ expect(showCheckNowResult).not.toHaveBeenCalled();+ expect(rig.dispatches).not.toContain('check-now-download-failed-shown');+ });++ test('a failed download never arms the ready card or a pending install', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const { rig } = makeRig({+ appVersion: '0.4.0',+ platform: 'linux',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ });+ await Promise.resolve();+ rig.updater.downloadUpdate.mockImplementation(() =>+ rejectAfterErrorEvent(rig.updater, assetMissing()),+ );+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ await new Promise((resolve) => setTimeout(resolve, 0));+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(rig.captured.filter((entry) => entry.channel === 'ok:update:downloaded')).toEqual([]);+ expect(rig.state.versionPendingInstall).toBeNull();+ expect(rig.state.attemptedInstall).toBeNull();+ expect(showCheckNowResult.mock.calls).toEqual([+ [offered],+ [downloadFailed],+ [offered],+ [downloadFailed],+ ]);+ });++ test.each([+ { retry: 'downloads', dialogs: [[offered]] },+ { retry: 'not-available', dialogs: [[offered], [downloadFailed]] },+ { retry: 'download-fails', dialogs: [[offered], [downloadFailed]] },+ { retry: 'check-fails', dialogs: [[offered], [downloadFailed]] },+ ] as const)(+ 'a proxy download failure waits for the GitHub retry before reporting (retry $retry)',+ async ({ retry, dialogs }) => {+ const showCheckNowResult = vi.fn(() => {});+ const { rig } = makeRig({+ appVersion: '0.4.0',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ });+ await Promise.resolve();+ const proxyDownloadError = Object.assign(new Error('proxy unavailable'), {+ code: 'HTTP_ERROR_503',+ });+ rig.updater.checkForUpdates.mockImplementation(() => {+ const feed = rig.updater.setFeedURL.mock.calls.at(-1)?.[0];+ if (typeof feed !== 'object' || feed.provider !== 'github') {+ return Promise.resolve(undefined);+ }+ if (retry === 'check-fails') {+ return rejectAfterErrorEvent(+ rig.updater,+ Object.assign(new Error('GitHub unavailable'), { code: 'HTTP_ERROR_503' }),+ );+ }+ return new Promise<undefined>((resolve) => setTimeout(resolve, 0)).then(() => {+ rig.updater.emit(+ retry === 'not-available' ? 'update-not-available' : 'update-available',+ { version: '0.5.0' },+ );+ return undefined;+ });+ });+ rig.updater.downloadUpdate.mockImplementation(() => {+ if (rig.updater.downloadUpdate.mock.calls.length === 1) {+ return rejectAfterErrorEvent(rig.updater, proxyDownloadError);+ }+ if (retry === 'download-fails') {+ return rejectAfterErrorEvent(rig.updater, assetMissing());+ }+ rig.updater.emit('update-downloaded', { version: '0.5.0' });+ return Promise.resolve([]);+ });+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ for (let tick = 0; tick < 4; tick++) await new Promise((resolve) => setTimeout(resolve, 0));+ expect(rig.updater.setFeedURL).toHaveBeenCalledWith(+ expect.objectContaining({ provider: 'github' }),+ );+ expect(showCheckNowResult.mock.calls).toEqual(dialogs);+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);+ },+ );++ test('destroy before the download fails shows no dialog', async () => {+ const showCheckNowResult = vi.fn(() => {});+ const download = Promise.withResolvers<never>();+ const { rig, handle } = makeRig({+ appVersion: '0.4.0',+ proxyFeed: { base: PROXY_BASE, channels: new Set(['latest']) },+ showCheckNowResult,+ updaterSetup: (updater) => {+ updater.downloadUpdate = vi.fn(() => download.promise);+ },+ });+ rig.ipc.invoke('ok:update:check-now');+ rig.updater.emit('update-available', { version: '0.5.0' });+ handle.destroy();+ download.reject(assetMissing());+ await new Promise((resolve) => setTimeout(resolve, 0));+ expect(showCheckNowResult.mock.calls).toEqual([[offered]]);+ });+});+describe('buildCheckNowResultFromError', () => {test('ERR_UPDATER_CHANNEL_FILE_NOT_FOUND maps to not-available with currentVersion', () => {const err = Object.assign(new Error('Cannot find …'), {