Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(ok): start ACP Plan section collapsed (PRD-8079) (#3682)
Abraham26d46cc2e26d
diff --git a/.changeset/prd-8079-plan-collapsed-by-default.md b/.changeset/prd-8079-plan-collapsed-by-default.mdnew file mode 100644index 000000000..715cd6873--- /dev/null+++ b/.changeset/prd-8079-plan-collapsed-by-default.md@@ -0,0 +1,5 @@+---+"@inkeep/open-knowledge": patch+---++The `Plan (n/m)` header in the ACP transcript now starts collapsed instead of expanded. Plans routinely run to twenty items, and an always-open default buried the running transcript below the fold and gave users no obvious way to reclaim the space (the click zone is one narrow row — easy to miss, easy to think dead). Click the header once to open the list; click again to close it. Extracted the block to its own `PlanChecklist.tsx` file with `data-testid` hooks and DOM coverage for the toggle, the prop-update path (plan stream ticks must not close the drawer someone just opened), and completed-item styling.diff --git a/packages/app/src/components/acp/PlanChecklist.dom.test.tsx b/packages/app/src/components/acp/PlanChecklist.dom.test.tsxnew file mode 100644index 000000000..fb70b0245--- /dev/null+++ b/packages/app/src/components/acp/PlanChecklist.dom.test.tsx@@ -0,0 +1,61 @@+import { cleanup, fireEvent, render } from '@testing-library/react';+import { afterEach, describe, expect, test } from 'vitest';+import { PlanChecklist } from './PlanChecklist';++const p = (content: string, status?: string) => ({ content, status });++describe('PlanChecklist', () => {+ afterEach(cleanup);++ test('starts collapsed — the toggle reads `Plan (0/3)`, no list visible', () => {+ const { queryByTestId, getByTestId, container } = render(+ <PlanChecklist plan={[p('one'), p('two'), p('three')]} />,+ );+ const toggle = getByTestId('agent-thread-plan-toggle');+ expect(toggle.getAttribute('aria-expanded')).toBe('false');+ expect(queryByTestId('agent-thread-plan-list')).toBeNull();+ expect(container.textContent).toContain('Plan (0/3)');+ });++ test('clicking the toggle expands then collapses — aria-expanded and list mount both track', () => {+ const { queryByTestId, getByTestId } = render(+ <PlanChecklist plan={[p('one'), p('two', 'completed'), p('three')]} />,+ );+ const toggle = getByTestId('agent-thread-plan-toggle');++ fireEvent.click(toggle);+ expect(toggle.getAttribute('aria-expanded')).toBe('true');+ const list = getByTestId('agent-thread-plan-list');+ expect(list.querySelectorAll('li')).toHaveLength(3);++ fireEvent.click(toggle);+ expect(toggle.getAttribute('aria-expanded')).toBe('false');+ expect(queryByTestId('agent-thread-plan-list')).toBeNull();+ });++ test('expanded state survives a plan-prop update — stream ticks do not close the drawer', () => {+ const initial = [p('one'), p('two'), p('three')];+ const { getByTestId, queryByTestId, rerender } = render(<PlanChecklist plan={initial} />);+ const toggle = getByTestId('agent-thread-plan-toggle');+ fireEvent.click(toggle);+ expect(toggle.getAttribute('aria-expanded')).toBe('true');++ const next = [p('one', 'completed'), p('two'), p('three')];+ rerender(<PlanChecklist plan={next} />);+ expect(toggle.getAttribute('aria-expanded')).toBe('true');+ expect(queryByTestId('agent-thread-plan-list')).not.toBeNull();+ expect(toggle.textContent).toContain('Plan (1/3)');+ });++ test('completed entries render with a checked glyph and line-through', () => {+ const { getByTestId } = render(+ <PlanChecklist plan={[p('one'), p('two', 'completed'), p('three')]} />,+ );+ fireEvent.click(getByTestId('agent-thread-plan-toggle'));+ const items = getByTestId('agent-thread-plan-list').querySelectorAll('li');+ expect(items[0]?.textContent).toContain('☐');+ expect(items[1]?.textContent).toContain('☑');+ expect(items[1]?.className).toContain('line-through');+ expect(items[2]?.textContent).toContain('☐');+ });+});diff --git a/packages/app/src/components/acp/PlanChecklist.tsx b/packages/app/src/components/acp/PlanChecklist.tsxnew file mode 100644index 000000000..e2420e513--- /dev/null+++ b/packages/app/src/components/acp/PlanChecklist.tsx@@ -0,0 +1,49 @@+import { useLingui } from '@lingui/react/macro';+import { ChevronDown, ChevronRight } from 'lucide-react';+import { type ReactNode, useState } from 'react';+import { Button } from '@/components/ui/button';+import type { PlanEntry } from '@/lib/acp/thread-event-model';+import { cn } from '@/lib/utils';++export function PlanChecklist({ plan }: { plan: readonly PlanEntry[] }): ReactNode {+ const { t } = useLingui();+ const [open, setOpen] = useState(false);+ const done = plan.filter((p) => p.status === 'completed').length;+ return (+ <div className="border-border/60 border-b bg-muted/30 px-3 py-1.5">+ <Button+ type="button"+ variant="ghost"+ size="sm"+ className="h-auto w-full justify-start gap-1.5 p-0 font-medium text-muted-foreground text-xs hover:bg-transparent"+ onClick={() => setOpen((o) => !o)}+ aria-expanded={open}+ data-testid="agent-thread-plan-toggle"+ >+ {open ? (+ <ChevronDown className="size-3.5" aria-hidden="true" />+ ) : (+ <ChevronRight className="size-3.5" aria-hidden="true" />+ )}+ <span>{t`Plan (${done}/${plan.length})`}</span>+ </Button>+ {open ? (+ <ul className="mt-1 flex flex-col gap-0.5" data-testid="agent-thread-plan-list">+ {plan.map((entry, index) => (+ <li+ // biome-ignore lint/suspicious/noArrayIndexKey: plan is a positional list+ key={index}+ className={cn(+ 'flex items-start gap-1.5 text-xs',+ entry.status === 'completed' && 'text-muted-foreground line-through',+ )}+ >+ <span aria-hidden="true">{entry.status === 'completed' ? '☑' : '☐'}</span>+ <span>{entry.content}</span>+ </li>+ ))}+ </ul>+ ) : null}+ </div>+ );+}diff --git a/packages/app/src/components/acp/ThreadView.tsx b/packages/app/src/components/acp/ThreadView.tsxindex 1f031143a..f2516b896 100644--- a/packages/app/src/components/acp/ThreadView.tsx+++ b/packages/app/src/components/acp/ThreadView.tsx@@ -162,6 +162,7 @@ import {pageListFollowOptions,saveFollowFilePref,} from './follow-file';+import { PlanChecklist } from './PlanChecklist';import { appendPresenceWrite, latestAgentWrite, type PresenceWrite } from './presence-follow';import { RegisteredAgentIcon } from './RegisteredAgentIcon';import { transcriptItemId } from './transcript-item-id';@@ -1880,48 +1881,6 @@ function ThreadEmptyState({);}-function PlanChecklist({ plan }: { plan: { content: string; status?: string }[] }): ReactNode {- const { t } = useLingui();- const [open, setOpen] = useState(true);- const done = plan.filter((p) => p.status === 'completed').length;- return (- <div className="border-border/60 border-b bg-muted/30 px-3 py-1.5">- <Button- type="button"- variant="ghost"- size="sm"- className="h-auto w-full justify-start gap-1.5 p-0 font-medium text-muted-foreground text-xs hover:bg-transparent"- onClick={() => setOpen((o) => !o)}- aria-expanded={open}- >- {open ? (- <ChevronDown className="size-3.5" aria-hidden="true" />- ) : (- <ChevronRight className="size-3.5" aria-hidden="true" />- )}- <span>{t`Plan (${done}/${plan.length})`}</span>- </Button>- {open ? (- <ul className="mt-1 flex flex-col gap-0.5">- {plan.map((entry, index) => (- <li- // biome-ignore lint/suspicious/noArrayIndexKey: plan is a positional list- key={index}- className={cn(- 'flex items-start gap-1.5 text-xs',- entry.status === 'completed' && 'text-muted-foreground line-through',- )}- >- <span aria-hidden="true">{entry.status === 'completed' ? '☑' : '☐'}</span>- <span>{entry.content}</span>- </li>- ))}- </ul>- ) : null}- </div>- );-}-// The scroller's imperative API only exists inside its Provider; this bridge// publishes it to a parent-owned ref so send/resume handlers (which live above// the Provider) can call scrollToEnd.diff --git a/packages/app/src/lib/acp/thread-event-model.ts b/packages/app/src/lib/acp/thread-event-model.tsindex 1c73c62d8..57e74d5d6 100644--- a/packages/app/src/lib/acp/thread-event-model.ts+++ b/packages/app/src/lib/acp/thread-event-model.ts@@ -156,7 +156,7 @@ export type RenderedItem =| RenderedNotice| RenderedRuntimeConsent;-interface PlanEntry {+export interface PlanEntry {content: string;priority?: string;status?: string;diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.poindex 787f2e13b..ddd0a015a 100644--- a/packages/app/src/locales/ar/messages.po+++ b/packages/app/src/locales/ar/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "نص عادي"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "الخطة ({done}/{0})"diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.poindex 55f469f1b..2dcf985bb 100644--- a/packages/app/src/locales/bn/messages.po+++ b/packages/app/src/locales/bn/messages.po@@ -9696,7 +9696,7 @@ msgid "Plain text"msgstr "সাধারণ টেক্সট"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "পরিকল্পনা ({done}/{0})"diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.poindex 1c8b02081..b5e3ca85d 100644--- a/packages/app/src/locales/en/messages.po+++ b/packages/app/src/locales/en/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "Plain text"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "Plan ({done}/{0})"diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.poindex 8d6688970..0b5bdbc2d 100644--- a/packages/app/src/locales/es/messages.po+++ b/packages/app/src/locales/es/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "Texto sin formato"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "Plan ({done}/{0})"diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.poindex c99026436..be55d8579 100644--- a/packages/app/src/locales/fr/messages.po+++ b/packages/app/src/locales/fr/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "Texte brut"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "Plan ({done}/{0})"diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.poindex 43995e739..991c75855 100644--- a/packages/app/src/locales/hi/messages.po+++ b/packages/app/src/locales/hi/messages.po@@ -9696,7 +9696,7 @@ msgid "Plain text"msgstr "सादा टेक्स्ट"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "योजना ({done}/{0})"diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.poindex f4e2d1a42..89c2a03e7 100644--- a/packages/app/src/locales/id/messages.po+++ b/packages/app/src/locales/id/messages.po@@ -9696,7 +9696,7 @@ msgid "Plain text"msgstr "Teks biasa"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "Rencana ({done}/{0})"diff --git a/packages/app/src/locales/ko/messages.po b/packages/app/src/locales/ko/messages.poindex 6cf88284f..6931912b5 100644--- a/packages/app/src/locales/ko/messages.po+++ b/packages/app/src/locales/ko/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "일반 텍스트"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "계획 ({done}/{0})"diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.poindex bc23028f2..cc41c0bee 100644--- a/packages/app/src/locales/pseudo/messages.po+++ b/packages/app/src/locales/pseudo/messages.po@@ -9696,7 +9696,7 @@ msgid "Plain text"msgstr ""#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr ""diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.poindex 2ed9e1509..8d31c53f2 100644--- a/packages/app/src/locales/pt-BR/messages.po+++ b/packages/app/src/locales/pt-BR/messages.po@@ -9696,7 +9696,7 @@ msgid "Plain text"msgstr "Texto simples"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "Plano ({done}/{0})"diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.poindex 7348a1b99..267061607 100644--- a/packages/app/src/locales/ur/messages.po+++ b/packages/app/src/locales/ur/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "سادہ متن"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "منصوبہ ({done}/{0})"diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.poindex cff63879f..de6fbd3b0 100644--- a/packages/app/src/locales/zh-Hans/messages.po+++ b/packages/app/src/locales/zh-Hans/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "纯文本"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "计划({done}/{0})"diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.poindex 7db5c72c7..55d4e209e 100644--- a/packages/app/src/locales/zh-Hant/messages.po+++ b/packages/app/src/locales/zh-Hant/messages.po@@ -9700,7 +9700,7 @@ msgid "Plain text"msgstr "純文字"#. placeholder {0}: plan.length-#: src/components/acp/ThreadView.tsx+#: src/components/acp/PlanChecklist.tsxmsgid "Plan ({done}/{0})"msgstr "計畫({done}/{0})"