Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

test(open-knowledge): de-flake e2e URL-navigation assertions (#1773)

Andrew Mikofalvy2cc086eb90b1
diff --git a/packages/app/playwright.config.ts b/packages/app/playwright.config.ts
index b95f8a4b7..f6c9ec05c 100644
--- a/packages/app/playwright.config.ts
+++ b/packages/app/playwright.config.ts
@@ -7,6 +7,7 @@ export default defineConfig({
testMatch: /.*\.e2e\.ts$/,
globalSetup: './tests/stress/_helpers/global-warm-cache.ts',
timeout: 120_000,
+ expect: { timeout: isCI ? 15_000 : 5_000 },
retries: isCI ? 2 : 0,
failOnFlakyTests: false,
forbidOnly: isCI,
diff --git a/packages/app/tests/stress/_helpers/index.ts b/packages/app/tests/stress/_helpers/index.ts
index a6451eff8..dc53a8314 100644
--- a/packages/app/tests/stress/_helpers/index.ts
+++ b/packages/app/tests/stress/_helpers/index.ts
@@ -30,7 +30,7 @@ export {
tailServerLog,
waitForHttpReady,
} from './server-process.ts';
-export { sidebarFileButton } from './sidebar.ts';
+export { createFileViaSidebar, createFolderViaSidebar, sidebarFileButton } from './sidebar.ts';
export {
getSelectedItemSnapshot,
type SelectedItemSnapshot,
diff --git a/packages/app/tests/stress/_helpers/sidebar.ts b/packages/app/tests/stress/_helpers/sidebar.ts
index 531725ec1..9cadad432 100644
--- a/packages/app/tests/stress/_helpers/sidebar.ts
+++ b/packages/app/tests/stress/_helpers/sidebar.ts
@@ -1,6 +1,57 @@
import type { Locator, Page } from '@playwright/test';
+import { expect } from './fixtures.ts';
export function sidebarFileButton(page: Page, name: string): Locator {
const sidebar = page.locator('[data-slot="sidebar-container"]');
return sidebar.getByText(name, { exact: true });
}
+
+function escapeRegExp(value: string): string {
+ return value.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+}
+
+function sidebarTreeItem(page: Page, name: string): Locator {
+ return page
+ .locator('[data-slot="sidebar-container"]')
+ .getByRole('treeitem', { name, exact: true });
+}
+
+function activeEditorTabButton(page: Page, name: string): Locator {
+ return page.locator('[data-active-tab="true"]').getByRole('button', { name, exact: true });
+}
+
+const CREATE_CONVERGED_TIMEOUT = process.env.CI ? 15_000 : 10_000;
+
+export async function createFolderViaSidebar(page: Page, name: string): Promise<void> {
+ await page.getByRole('button', { name: 'New Folder', exact: true }).click();
+ const input = page.getByRole('textbox', { name: /rename New Folder/i });
+ await expect(input).toBeVisible({ timeout: CREATE_CONVERGED_TIMEOUT });
+ await input.fill(name);
+ await input.press('Enter');
+
+ await expect(sidebarTreeItem(page, name)).toBeVisible({ timeout: CREATE_CONVERGED_TIMEOUT });
+ await expect(activeEditorTabButton(page, `${name}/`)).toBeVisible({
+ timeout: CREATE_CONVERGED_TIMEOUT,
+ });
+ await expect(page).toHaveURL(new RegExp(`#/${escapeRegExp(name)}/$`), {
+ timeout: CREATE_CONVERGED_TIMEOUT,
+ });
+}
+
+export async function createFileViaSidebar(page: Page, name: string): Promise<void> {
+ await page.getByRole('button', { name: 'New File', exact: true }).click();
+ const input = page.getByRole('textbox', { name: /rename Untitled\.md/i });
+ await expect(input).toBeVisible({ timeout: CREATE_CONVERGED_TIMEOUT });
+ await input.fill(name);
+ await input.press('Enter');
+
+ await expect(sidebarTreeItem(page, `${name}.md`)).toBeVisible({
+ timeout: CREATE_CONVERGED_TIMEOUT,
+ });
+ await expect(activeEditorTabButton(page, `${name}.md`)).toBeVisible({
+ timeout: CREATE_CONVERGED_TIMEOUT,
+ });
+ await expect(page).toHaveURL(new RegExp(`#/${escapeRegExp(name)}$`), {
+ timeout: CREATE_CONVERGED_TIMEOUT,
+ });
+}
diff --git a/packages/app/tests/stress/file-tree-create.e2e.ts b/packages/app/tests/stress/file-tree-create.e2e.ts
index c6213cfe0..013f863e9 100644
--- a/packages/app/tests/stress/file-tree-create.e2e.ts
+++ b/packages/app/tests/stress/file-tree-create.e2e.ts
@@ -1,7 +1,13 @@
import { existsSync, readdirSync, rmSync, statSync } from 'node:fs';
import { join } from 'node:path';
import type { Page } from '@playwright/test';
-import { type ApiHelpers, expect, test } from './_helpers';
+import {
+ type ApiHelpers,
+ createFileViaSidebar,
+ createFolderViaSidebar,
+ expect,
+ test,
+} from './_helpers';
type DeleteKind = 'file' | 'folder';
@@ -702,16 +708,8 @@ test.describe('FileTree sidebar create', () => {
try {
await gotoRootAndAwaitSidebar(page);
- await page.getByRole('button', { name: 'New Folder', exact: true }).click();
- const input = page.getByRole('textbox', { name: /rename New Folder/i });
- await expect(input).toBeVisible({ timeout: 10_000 });
- await input.fill('hello');
- await input.press('Enter');
+ await createFolderViaSidebar(page, 'hello');
- await expect(sidebarTreeItem(page, 'hello')).toBeVisible({ timeout: 10_000 });
- await expect(page.getByRole('button', { name: 'hello/', exact: true })).toBeVisible({
- timeout: 10_000,
- });
await expect(page.getByRole('button', { name: 'New Folder/', exact: true })).toHaveCount(0);
await expect(page.getByRole('button', { name: 'New Folder.md', exact: true })).toHaveCount(0);
expect(existsSync(join(workerServer.contentDir, 'hello'))).toBe(true);
@@ -738,34 +736,16 @@ test.describe('FileTree sidebar create', () => {
try {
await gotoRootAndAwaitSidebar(page);
- await page.getByRole('button', { name: 'New Folder', exact: true }).click();
- const folderInput = page.getByRole('textbox', { name: /rename New Folder/i });
- await expect(folderInput).toBeVisible({ timeout: 10_000 });
- await folderInput.fill(name);
- await folderInput.press('Enter');
-
+ await createFolderViaSidebar(page, name);
const folderItem = await visibleSidebarItemByPath(page, `${name}/`);
- await expect(activeEditorTabButton(page, `${name}/`)).toBeVisible({
- timeout: 10_000,
- });
- await expect(page).toHaveURL(new RegExp(`#/${name}/$`));
await page.evaluate(() => {
window.location.hash = '#/';
});
await expect(page).toHaveURL(/#\/$/);
- await page.getByRole('button', { name: 'New File', exact: true }).click();
- const fileInput = page.getByRole('textbox', { name: /rename Untitled\.md/i });
- await expect(fileInput).toBeVisible({ timeout: 10_000 });
- await fileInput.fill(name);
- await fileInput.press('Enter');
-
+ await createFileViaSidebar(page, name);
const fileItem = await visibleSidebarItemByPath(page, `${name}.md`);
- await expect(activeEditorTabButton(page, `${name}.md`)).toBeVisible({
- timeout: 10_000,
- });
await expect(editorTabButton(page, `${name}/`).first()).toBeVisible();
- await expect(page).toHaveURL(new RegExp(`#/${name}$`));
await folderItem.click();
await expect(page).toHaveURL(new RegExp(`#/${name}/$`));