Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Close the read-edge gaps the round and push still miss (#6166)

Nick Gomez3270c41696ff
diff --git a/.github/scripts/step-slicer-shape.reads.mjs b/.github/scripts/step-slicer-shape.reads.mjs
new file mode 100644
index 000000000..b0b6a7b7a
--- /dev/null
+++ b/.github/scripts/step-slicer-shape.reads.mjs
@@ -0,0 +1,7 @@
+export const STEP_SLICER_SCAN_ROOTS = ['.github/scripts', 'scripts'];
+
+export const ROUND_READS = {
+ test: './step-slicer-shape.test.mjs',
+ reads: 'the scripts-tier test files it scans for an unguarded slice(indexOf(...)) shape',
+ include: STEP_SLICER_SCAN_ROOTS.map((root) => `${root}/*.test.mjs`),
+};
diff --git a/.github/scripts/step-slicer-shape.test.mjs b/.github/scripts/step-slicer-shape.test.mjs
index e98802245..9e0e08654 100644
--- a/.github/scripts/step-slicer-shape.test.mjs
+++ b/.github/scripts/step-slicer-shape.test.mjs
@@ -2,11 +2,13 @@ import { readdirSync, readFileSync } from 'node:fs';
import { basename, dirname, join } from 'node:path';
import { fileURLToPath } from 'node:url';
import { describe, expect, test } from 'vitest';
+import { STEP_SLICER_SCAN_ROOTS } from './step-slicer-shape.reads.mjs';
const SELF_PATH = fileURLToPath(import.meta.url);
const HERE = dirname(SELF_PATH);
+const OK_ROOT = join(HERE, '..', '..');
-const ROOTS = [HERE, join(HERE, '..', '..', 'scripts')];
+const ROOTS = STEP_SLICER_SCAN_ROOTS.map((root) => join(OK_ROOT, root));
const NESTED_SLICE = /\.slice\(\s*[A-Za-z_$][\w$]*(?:\.[\w$]+)*\.(?:indexOf|lastIndexOf)\(/g;
diff --git a/packages/app/tests/integration/e2e-stop-rules.reads.ts b/packages/app/tests/integration/e2e-stop-rules.reads.ts
index b16e07538..eab99139a 100644
--- a/packages/app/tests/integration/e2e-stop-rules.reads.ts
+++ b/packages/app/tests/integration/e2e-stop-rules.reads.ts
@@ -18,6 +18,8 @@ export const ROUND_READS = {
...APP_SOURCE_EXTENSIONS.map((extension) => `${APP_SOURCE_ROOT}/**/*${extension}`),
APP_STYLESHEET,
'packages/app/package.json',
+ 'packages/app/tests/integration/dev-gate-allowlist.ts',
+ 'test-support/test-only-source-file.mjs',
],
exclude: APP_SOURCE_EXCLUDED_SUFFIXES.map((suffix) => `${APP_SOURCE_ROOT}/**/*${suffix}`),
};