Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(ok): repair-skills must not treat $HOME as a project (PRD-8008) (#3632)
tim-inkeep36e9bf19b0a9
diff --git a/.changeset/repair-skills-home-not-project.md b/.changeset/repair-skills-home-not-project.mdnew file mode 100644index 000000000..8e4d144cb--- /dev/null+++ b/.changeset/repair-skills-home-not-project.md@@ -0,0 +1,5 @@+---+"@inkeep/open-knowledge": patch+---++`ok repair-skills` no longer creates project skill folders in directories that aren't projects. Run from your home directory, it used to read the user-global MCP configs at `~/.cursor/mcp.json` and `~/.codex/config.toml` as though they were project configs, and create two new project skill folders in your home while cleaning others out of it. Each editor is now skipped when its project config path resolves to that editor's own global config, which also covers the cases a home-directory-only check would miss: OpenCode's global config lives at `~/.config/opencode/`, and `CODEX_HOME` or `COPILOT_HOME` can move those globals anywhere. Colliding hosts are reported in the summary and still exit 0.diff --git a/knip.config.ts b/knip.config.tsindex 78162ec09..f9179f2d4 100644--- a/knip.config.ts+++ b/knip.config.ts@@ -123,7 +123,9 @@ export default {'packages/server': {entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],project: 'src/**',- ignoreDependencies: ['@types/shell-quote'],+ ignoreDependencies: [+ '@types/shell-quote',+ ],},'packages/cli': {entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],diff --git a/packages/cli/src/commands/repair-skills.test.ts b/packages/cli/src/commands/repair-skills.test.tsindex 847326e99..0a3ffd19f 100644--- a/packages/cli/src/commands/repair-skills.test.ts+++ b/packages/cli/src/commands/repair-skills.test.ts@@ -1,6 +1,6 @@-import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from 'node:fs';+import { existsSync, mkdirSync, readFileSync, rmSync, symlinkSync, writeFileSync } from 'node:fs';import { tmpdir } from 'node:os';-import { join, resolve } from 'node:path';+import { dirname, join, resolve } from 'node:path';import { PassThrough } from 'node:stream';import type { SkillInstallEvent } from '@inkeep/open-knowledge-server';import { afterEach, beforeEach, describe, expect, it } from 'vitest';@@ -1393,6 +1393,54 @@ describe('repairSkills — JSONL telemetry parity with Desktop', () => {});describe('formatRepairSkillsResult — done-branch stdout formatting', () => {+ it('names the collision skip, so a user running the repro sees why hosts were left alone', () => {+ const out = formatRepairSkillsResult({+ status: 'done',+ legacySwept: [],+ legacyCleanupDeclined: false,+ legacyCleanupFailed: false,+ project: {+ outcome: 'done',+ entries: [+ {+ editorId: 'cursor',+ hostDir: '.cursor',+ path: '/h/.cursor/skills/open-knowledge',+ outcome: 'skipped-global-collision',+ },+ {+ editorId: 'codex',+ hostDir: '.codex',+ path: '/h/.codex/skills/open-knowledge',+ outcome: 'skipped-global-collision',+ },+ ],+ },+ user: { outcome: 'done', version: '9.9.9', entries: [] },+ });+ expect(out).toContain(+ 'Skipped 2 host(s) whose project config path is their user-global config',+ );+ // Collisions must not be folded into a standard counter — a mutation that+ // counted them as `no-token` would still print a plausible summary.+ expect(out).toContain('Project: 0 present, 0 created, 0 no-token, 0 failed.');+ });++ it('omits the collision line when nothing collided', () => {+ const out = formatRepairSkillsResult({+ status: 'done',+ legacySwept: [],+ legacyCleanupDeclined: false,+ legacyCleanupFailed: false,+ project: {+ outcome: 'done',+ entries: [{ editorId: 'claude', hostDir: '.claude', path: '/x', outcome: 'present' }],+ },+ user: { outcome: 'done', version: '9.9.9', entries: [] },+ });+ expect(out).not.toContain('Skipped');+ });+it('renders per-sweep counts when both sweeps ran to done', () => {const out = formatRepairSkillsResult({status: 'done',@@ -1549,6 +1597,45 @@ describe('repairSkillsResultExitCode (PR feedback: standalone exit code mapping)it('done with any user-sweep failure exits 1', () => {expect(repairSkillsResultExitCode(mkDone({ userFailedHost: true }))).toBe(1);});++ // A project-level skip is a real failure and must keep exiting 1. Collisions+ // are per-host entries inside a `done` sweep, so they never take this branch+ // — the two must not be conflated by a future edit.+ it('done-less project skip (bundle-missing) exits 1', () => {+ expect(+ repairSkillsResultExitCode({+ status: 'done',+ project: { outcome: 'skipped', reason: 'bundle-missing' },+ user: { outcome: 'done', version: '9.9.9', entries: [] },+ legacySwept: [],+ legacyCleanupDeclined: false,+ legacyCleanupFailed: false,+ }),+ ).toBe(1);+ });++ it('a sweep whose only non-success entries are global collisions exits 0', () => {+ expect(+ repairSkillsResultExitCode({+ status: 'done',+ project: {+ outcome: 'done',+ entries: [+ {+ editorId: 'cursor',+ hostDir: '.cursor',+ path: '/h/.cursor/skills/open-knowledge',+ outcome: 'skipped-global-collision',+ },+ ],+ },+ user: { outcome: 'done', version: '9.9.9', entries: [] },+ legacySwept: [],+ legacyCleanupDeclined: false,+ legacyCleanupFailed: false,+ }),+ ).toBe(0);+ });});describe('repairSkillsCommand — Commander action wiring (AC-D1, AC-D3)', () => {@@ -1857,3 +1944,162 @@ describe('legacy cleanup — an internal failure is never reported as a decline'expect(out).not.toContain('Cleanup: failed');});});++/**+ * `cd ~ && ok repair-skills` created two PROJECT skill dirs in the home+ * directory. At `$HOME` an editor's project config path resolves onto its+ * USER-GLOBAL config, which is OK-wired, so the create-if-wired gate said yes+ * for the wrong reason. The gate is a per-host path comparison rather than a+ * `projectDir === home` check because `$HOME` is not the only colliding+ * directory: OpenCode's global lives at `$XDG_CONFIG_HOME/opencode`, and+ * `CODEX_HOME` relocates codex's global off `$HOME` entirely.+ */+describe('repairSkills — project config that IS the global config is never swept', () => {+ let scratch: ReturnType<typeof mkScratch>;+ let projectBundleDir: string;+ let discoveryBundleDir: string;+ let logEvents: RepairSkillsLogEvent[];++ const OK_WIRED_MCP_JSON = JSON.stringify({+ mcpServers: {+ 'open-knowledge': {+ command: '/bin/sh',+ args: ['-l', '-c', '# ok-mcp-v2\nexit 127'],+ },+ },+ });+ const OK_WIRED_TOML =+ '[mcp_servers.open-knowledge]\ncommand = "/bin/sh"\nargs = ["-l", "-c", "# ok-mcp-v2\\nexit 127"]\n';++ beforeEach(() => {+ scratch = mkScratch('global-collision');+ projectBundleDir = join(scratch.bundles, 'project');+ discoveryBundleDir = join(scratch.bundles, 'discovery');+ writeBundledSkill(projectBundleDir, '9.9.9');+ writeBundledSkill(discoveryBundleDir, '9.9.9');+ logEvents = [];+ });+ afterEach(() => {+ rmSync(scratch.root, { recursive: true, force: true });+ });++ const run = async (projectDir: string, home = scratch.home): Promise<RepairSkillsResult> =>+ repairSkills({+ projectDir,+ home,+ logger: (event) => logEvents.push(event),+ deps: depsBuilder({+ projectBundleDir,+ discoveryBundleDir,+ bundledVersion: '9.9.9',+ recordedVersion: '9.9.9',+ writtenVersions: [],+ }),+ });++ /** Both hosts the bug report named, each written at its OWN global path. */+ function writeHomeGlobals(home: string): void {+ const cursorGlobal = EDITOR_TARGETS.cursor.configPath('', home);+ const codexGlobal = EDITOR_TARGETS.codex.configPath('', home);+ mkdirSync(dirname(cursorGlobal), { recursive: true });+ mkdirSync(dirname(codexGlobal), { recursive: true });+ writeFileSync(cursorGlobal, OK_WIRED_MCP_JSON);+ writeFileSync(codexGlobal, OK_WIRED_TOML);+ // Each editor's PROJECT path at $HOME is that same file — the collision.+ expect(EDITOR_TARGETS.cursor.projectConfigPath?.(home)).toBe(cursorGlobal);+ expect(EDITOR_TARGETS.codex.projectConfigPath?.(home)).toBe(codexGlobal);+ }++ it('writes no project skill dirs into a home whose global configs are OK-wired', async () => {+ writeHomeGlobals(scratch.home);++ const result = await run(scratch.home);++ if (result.status !== 'done' || result.project.outcome !== 'done')+ throw new Error('unreachable');+ // Both reported hosts skipped for the collision, not vacuously absent.+ for (const editorId of ['cursor', 'codex']) {+ expect(result.project.entries.find((e) => e.editorId === editorId)?.outcome).toBe(+ 'skipped-global-collision',+ );+ }+ // The regression itself: no project skill dir anywhere under home.+ for (const host of HOSTS_WITH_USER_SKILL_DIR) {+ expect(existsSync(join(scratch.home, host.hostDir, 'skills', PROJECT_SKILL_DIR_NAME))).toBe(+ false,+ );+ }+ expect(+ logEvents.some((e) => e.event === 'project-skill-reclaim-skipped-global-collision'),+ ).toBe(true);+ });++ it('exits 0 — skipping colliding hosts is a correct outcome, not a failure', async () => {+ writeHomeGlobals(scratch.home);+ expect(repairSkillsResultExitCode(await run(scratch.home))).toBe(0);+ });++ it('a symlinked home still resolves to the same directory', async () => {+ writeHomeGlobals(scratch.home);+ // Asymmetric on purpose: projectDir arrives via a symlink while `home` is+ // the real path. A plain string compare passes both sides only when they+ // are already identical, so this is what pins the canonicalization.+ const linkedHome = join(scratch.root, 'home-link');+ symlinkSync(scratch.home, linkedHome);++ const result = await run(linkedHome, scratch.home);++ if (result.status !== 'done' || result.project.outcome !== 'done')+ throw new Error('unreachable');+ expect(result.project.entries.find((e) => e.editorId === 'cursor')?.outcome).toBe(+ 'skipped-global-collision',+ );+ expect(existsSync(join(scratch.home, '.cursor', 'skills', PROJECT_SKILL_DIR_NAME))).toBe(false);+ });++ it('skips OpenCode at ~/.config/opencode, where the collision is NOT at $HOME', async () => {+ // The case a `projectDir === home` guard misses entirely: OpenCode's global+ // is `$XDG_CONFIG_HOME/opencode/opencode.json` and its project path is+ // `<cwd>/opencode.json`, so they coincide inside the config dir.+ const openCodeGlobal = EDITOR_TARGETS.opencode.configPath('', scratch.home);+ const openCodeDir = dirname(openCodeGlobal);+ mkdirSync(openCodeDir, { recursive: true });+ // OK-marked on purpose: without it `editorWiredForOk` returns false and the+ // host is skipped as `no-token` anyway, so the test would pass without the+ // guard doing anything. Wired content is what makes this prove prevention.+ writeFileSync(+ openCodeGlobal,+ JSON.stringify({+ mcp: {+ 'open-knowledge': {+ type: 'local',+ command: ['/bin/sh', '-l', '-c', '# ok-mcp-v2\nexit 127'],+ },+ },+ }),+ );+ expect(EDITOR_TARGETS.opencode.projectConfigPath?.(openCodeDir)).toBe(openCodeGlobal);+ expect(openCodeDir).not.toBe(scratch.home);++ const result = await run(openCodeDir);++ if (result.status !== 'done' || result.project.outcome !== 'done')+ throw new Error('unreachable');+ expect(result.project.entries.find((e) => e.editorId === 'opencode')?.outcome).toBe(+ 'skipped-global-collision',+ );+ expect(existsSync(join(openCodeDir, '.opencode', 'skills', PROJECT_SKILL_DIR_NAME))).toBe(+ false,+ );+ });++ it('still sweeps a real project directory beside the same home', async () => {+ writeFileSync(join(scratch.project, '.mcp.json'), OK_WIRED_MCP_JSON);++ const result = await run(scratch.project);++ if (result.status !== 'done' || result.project.outcome !== 'done')+ throw new Error('unreachable');+ expect(result.project.entries.find((e) => e.editorId === 'claude')?.outcome).toBe('created');+ });+});diff --git a/packages/cli/src/commands/repair-skills.ts b/packages/cli/src/commands/repair-skills.tsindex c9d669544..0107d2069 100644--- a/packages/cli/src/commands/repair-skills.ts+++ b/packages/cli/src/commands/repair-skills.ts@@ -29,7 +29,7 @@ import {writeFileSync as fsWriteFileSync,} from 'node:fs';import { homedir } from 'node:os';-import { dirname, join, relative, resolve as resolvePath } from 'node:path';+import { basename, dirname, join, relative, resolve as resolvePath } from 'node:path';import { createInterface } from 'node:readline/promises';import { USER_SKILL_HOSTS } from '@inkeep/open-knowledge-core';import {@@ -47,6 +47,7 @@ import {writeTargetVersion,} from '@inkeep/open-knowledge-server';import { Command } from 'commander';+import { canonicalizeForCompare } from '../integrations/resolve-project-root.ts';import {applyLegacyFanoutSweep,type LegacyFanoutSweepPlan,@@ -55,7 +56,12 @@ import {} from '../integrations/skill-teardown.ts';import { assertProjectPathSafe } from '../integrations/write-project-skill.ts';import { accent, dim, warning } from '../ui/colors.ts';-import { EDITOR_TARGETS, type EditorId, HOSTS_WITH_USER_SKILL_DIR } from './editors.ts';+import {+ EDITOR_TARGETS,+ type EditorId,+ type EditorMcpTarget,+ HOSTS_WITH_USER_SKILL_DIR,+} from './editors.ts';// `HOSTS_WITH_USER_SKILL_DIR` is the canonical core constant (derived from// PROJECT_SKILL_EDITOR_IDS + EDITOR_PROJECT_SKILL_ROOT), shared with the desktop@@ -183,7 +189,12 @@ export interface RepairSkillsContext {confirmLegacyCleanup?: (plan: LegacyFanoutSweepPlan) => Promise<boolean>;}-export type ProjectSkillOutcome = 'no-token' | 'present' | 'created' | 'failed';+export type ProjectSkillOutcome =+ | 'no-token'+ | 'present'+ | 'created'+ | 'failed'+ | 'skipped-global-collision';export type UserSkillCentralOutcome = 'written' | 'skipped-present' | 'failed';export type UserSkillHostOutcome =| 'written'@@ -491,19 +502,67 @@ function editorWiredForOk(configPath: string | undefined, fs: RepairSkillsFsOps)}}+/**+ * True when this editor's PROJECT config path for `projectDir` resolves to the+ * very file that is its USER-GLOBAL config.+ *+ * When they coincide, `editorWiredForOk` is not answering "is this editor wired+ * for this project?" — it is reading the user's global install and saying yes.+ * The sweep then writes a PROJECT skill dir into a real global editor tree.+ *+ * `$HOME` is the case that surfaced this (`~/.cursor/mcp.json`,+ * `~/.codex/config.toml`), but it is not the only one, which is why this is a+ * per-host path comparison rather than a `projectDir === home` guard:+ *+ * - OpenCode's project config is `<cwd>/opencode.json` while its global is+ * `$XDG_CONFIG_HOME/opencode/opencode.json`, so `~/.config/opencode`+ * collides and `$HOME` does not.+ * - `CODEX_HOME` / `COPILOT_HOME` relocate those globals anywhere, moving the+ * colliding directory off `$HOME` entirely.+ *+ * Compared on canonical paths (shared `canonicalizeForCompare` — see its+ * `.native` rationale) so a symlinked home does not read as a different+ * directory. Config paths need not exist yet; the DIRECTORIES are canonicalized+ * and the filenames appended, because `realpathSync` on an absent file throws.+ */+function projectConfigIsGlobalConfig(+ target: EditorMcpTarget | undefined,+ projectConfigPath: string | undefined,+ projectDir: string,+ home: string,+): boolean {+ if (!target || !projectConfigPath) return false;+ let globalConfigPath: string;+ try {+ // Pi and other project-scope targets throw here — no global config exists,+ // so no collision is possible.+ globalConfigPath = target.configPath(projectDir, home);+ } catch {+ return false;+ }+ const canonical = (filePath: string): string =>+ join(canonicalizeForCompare(dirname(filePath)), basename(filePath));+ return canonical(projectConfigPath) === canonical(globalConfigPath);+}+/*** Project-scope sweep. Per-host gate: refresh a host whose `SKILL.md` already* exists; additionally CREATE the skill for any host whose project MCP config- * already carries the OK marker (`editorWiredForOk`). Always create-enabled:- * the only callers are `ok start` (guarded to run inside an `.ok/` project root)- * and the explicit `ok repair-skills` subcommand, so "this is an OK project" is- * already established — there is no fresh/non-OK open to guard against here (the- * Desktop, which DOES see non-OK opens, gates with its own `createIfWired`- * flag). Heals the cohort of OK projects wired for MCP before the project-skill- * writer existed.+ * already carries the OK marker (`editorWiredForOk`). Heals the cohort of OK+ * projects wired for MCP before the project-skill writer existed.+ *+ * `ok start` is guarded to run inside an `.ok/` project root, but+ * `ok repair-skills` passes `process.cwd()` straight through — so "this is a+ * project" is NOT established here, and `editorWiredForOk` alone is not enough+ * to decide. `projectConfigIsGlobalConfig` is the missing half: in a directory+ * where an editor's project config path IS its user-global config, a wired+ * "yes" is the user's global install answering, not this directory. The Desktop+ * has the analogous problem for non-OK opens and gates with its own+ * `createIfWired` flag.*/function runProjectSweep(projectDir: string,+ home: string,deps: Required<RepairSkillsDeps>,fs: RepairSkillsFsOps,logger: (event: RepairSkillsLogEvent) => void,@@ -537,8 +596,28 @@ function runProjectSweep(// `editorId` is a valid `EDITOR_TARGETS` key by the coverage meta-test, so// the lookup + `projectConfigPath` resolution reuse the single source of// truth (no duplicated per-editor path table).- const projectConfigPath =- EDITOR_TARGETS[host.editorId as EditorId]?.projectConfigPath?.(projectDir);+ const target = EDITOR_TARGETS[host.editorId as EditorId];+ const projectConfigPath = target?.projectConfigPath?.(projectDir);+ // Before trusting the wired check: if this project path IS the editor's+ // global config, the "yes" would come from the user's global install, not+ // from this directory being a project. Writing then plants a project skill+ // dir inside a real global editor tree — what `cd ~ && ok repair-skills`+ // did to `~/.cursor/skills` and `~/.codex/skills`.+ if (projectConfigIsGlobalConfig(target, projectConfigPath, projectDir, home)) {+ entries.push({+ editorId: host.editorId,+ hostDir: host.hostDir,+ path: dest,+ outcome: 'skipped-global-collision',+ });+ logger({+ event: 'project-skill-reclaim-skipped-global-collision',+ scope: 'project',+ editorId: host.editorId,+ path: dest,+ });+ continue;+ }const wired = editorWiredForOk(projectConfigPath, fs);if (!wired) {// Greenfield host that never ran `ok init` AND isn't OK-wired, or a host@@ -889,7 +968,7 @@ export async function repairSkills(ctx: RepairSkillsContext): Promise<RepairSkilreturn { status: 'skipped', reason: 'reclaim-disabled' };}- const project = runProjectSweep(ctx.projectDir, deps, fs, logger);+ const project = runProjectSweep(ctx.projectDir, home, deps, fs, logger);const user = await runUserSweep(home, deps, fs, logger);// Explicit-invocation only, and consent-gated even then. `ok init` must never// delete from $HOME unasked — that would answer one scope violation with@@ -967,9 +1046,17 @@ function formatRepairSkillsResult(result: RepairSkillsResult): string {const created = result.project.entries.filter((e) => e.outcome === 'created').length;const noToken = result.project.entries.filter((e) => e.outcome === 'no-token').length;const failed = result.project.entries.filter((e) => e.outcome === 'failed').length;+ const globalCollision = result.project.entries.filter(+ (e) => e.outcome === 'skipped-global-collision',+ ).length;lines.push(` Project: ${present} present, ${created} created, ${noToken} no-token, ${failed} failed.`,);+ if (globalCollision > 0) {+ lines.push(+ ` Skipped ${globalCollision} host(s) whose project config path is their user-global config (not a project directory).`,+ );+ }} else {lines.push(` Project: skipped (${result.project.reason}).`);}diff --git a/packages/cli/src/integrations/resolve-project-root.ts b/packages/cli/src/integrations/resolve-project-root.tsindex 5daa84451..b5e36a279 100644--- a/packages/cli/src/integrations/resolve-project-root.ts+++ b/packages/cli/src/integrations/resolve-project-root.ts@@ -78,8 +78,13 @@ export interface ResolveProjectRootOptions {** Mirrored in `packages/desktop/src/main/folder-admission.ts`; the two copies* must move together (TypeScript cannot catch drift across packages).+ *+ * Exported so in-package path-equality checks (e.g. `repair-skills`'s+ * global-config collision gate) reuse this one implementation instead of+ * re-deriving the idiom — a re-derived copy loses the `.native` rationale+ * above and silently disarms the guard on Windows.*/-function canonicalizeForCompare(p: string): string {+export function canonicalizeForCompare(p: string): string {try {return realpathSync.native(p);} catch {diff --git a/packages/core/src/bridge/bind-frontmatter-doc.ts b/packages/core/src/bridge/bind-frontmatter-doc.tsindex d7a845280..dfd95ef49 100644--- a/packages/core/src/bridge/bind-frontmatter-doc.ts+++ b/packages/core/src/bridge/bind-frontmatter-doc.ts@@ -1,3 +1,4 @@+import type * as Y from 'yjs';import type { Err, Ok, Result } from '../config/result.ts';import { type FrontmatterValidationError, toFrontmatterIssue } from '../frontmatter/errors.ts';diff --git a/packages/core/src/bridge/bridge-invariant.ts b/packages/core/src/bridge/bridge-invariant.tsindex 005627195..8bfdb40cd 100644--- a/packages/core/src/bridge/bridge-invariant.ts+++ b/packages/core/src/bridge/bridge-invariant.ts@@ -1,3 +1,4 @@+import { fnv1aDigest } from './hash-util.ts';export type BridgeInvariantSite = 'observer-b' | 'persistence' | 'test-harness';diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.tsindex f4cc8a286..2a597ec3d 100644--- a/packages/core/src/bridge/compose.ts+++ b/packages/core/src/bridge/compose.ts@@ -1,3 +1,4 @@+import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';diff --git a/packages/core/src/bridge/divergence-locate.ts b/packages/core/src/bridge/divergence-locate.tsindex 6b505314d..d979f4b39 100644--- a/packages/core/src/bridge/divergence-locate.ts+++ b/packages/core/src/bridge/divergence-locate.ts@@ -1,3 +1,4 @@+import { findFirstDivergenceIndex } from './tolerance-telemetry.ts';export const BRIDGE_LINE_KINDS = [diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.tsindex 8fb428b90..01ef76a9f 100644--- a/packages/core/src/bridge/doc-boundary-space.ts+++ b/packages/core/src/bridge/doc-boundary-space.ts@@ -1,3 +1,4 @@+import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';diff --git a/packages/core/src/bridge/growth-detect.ts b/packages/core/src/bridge/growth-detect.tsindex 9d9c244b0..463e89595 100644--- a/packages/core/src/bridge/growth-detect.ts+++ b/packages/core/src/bridge/growth-detect.ts@@ -1,3 +1,4 @@+const DEFAULT_MIN_SUBSTANTIVE_LINE_LENGTH = 16;export const DUPLICATION_GATE_MIN_LINE_LENGTH = 8;diff --git a/packages/core/src/bridge/intraline-predicate.ts b/packages/core/src/bridge/intraline-predicate.tsindex c43fdd7e7..0939885bb 100644--- a/packages/core/src/bridge/intraline-predicate.ts+++ b/packages/core/src/bridge/intraline-predicate.ts@@ -1,3 +1,4 @@+export function rawLineCounts(doc: string): Map<string, number> {const counts = new Map<string, number>();for (const line of doc.split('\n')) {diff --git a/packages/core/src/bridge/merge-three-way.ts b/packages/core/src/bridge/merge-three-way.tsindex 251560a35..c0dc65705 100644--- a/packages/core/src/bridge/merge-three-way.ts+++ b/packages/core/src/bridge/merge-three-way.ts@@ -65,6 +65,7 @@ export function tryLineLevelCombine(return { clean: true, merged };}+export type BridgeMergeContentLossSide = 'user' | 'agent';export type BridgeMergeContentLossWhich = 'substring' | 'order' | 'growth';diff --git a/packages/core/src/bridge/normalize.ts b/packages/core/src/bridge/normalize.tsindex 01ac80099..dcc5b0690 100644--- a/packages/core/src/bridge/normalize.ts+++ b/packages/core/src/bridge/normalize.ts@@ -1,3 +1,4 @@+import { stripFrontmatter } from '../extensions/frontmatter.ts';import { bodyEdgeEmpties } from './doc-boundary-space.ts';diff --git a/packages/core/src/bridge/pm-structural-equivalence.ts b/packages/core/src/bridge/pm-structural-equivalence.tsindex 754dc5cc2..0be5203e4 100644--- a/packages/core/src/bridge/pm-structural-equivalence.ts+++ b/packages/core/src/bridge/pm-structural-equivalence.ts@@ -32,6 +32,7 @@ const BR_SENTINEL: PmStructuralNode = { type: '__br__' };const BR_LITERAL_RE = /^<br\s*\/?>$/i;+interface DegradeEntry {readonly label: string;readonly severity: ToleranceClassSeverity;@@ -127,6 +128,7 @@ export interface ComparePmStructuralOptions {ignoreAttrs?: (attrKey: string) => boolean;}+/** Rebuild a node with `fn` applied to each child; identity when childless.* Shared by the degrade canonicalizers so none re-implements the walk. */function mapChildren(@@ -248,6 +250,7 @@ function applyDegrades(tree: PmStructuralNode): {return { normalized: current, fired };}+export function comparePmStructural(expected: PmStructuralNode,actual: PmStructuralNode,diff --git a/packages/core/src/bridge/subsequence.ts b/packages/core/src/bridge/subsequence.tsindex af20de1e2..dca644141 100644--- a/packages/core/src/bridge/subsequence.ts+++ b/packages/core/src/bridge/subsequence.ts@@ -1,3 +1,4 @@+/** True when `needle` is a subsequence of `haystack` (two-pointer, O(n+m)):* insertions in `haystack` are free; any dropped or substituted `needle` byte* fails. */diff --git a/packages/core/src/markdown/callout-transformer.ts b/packages/core/src/markdown/callout-transformer.tsindex 83d47404a..a363dfd54 100644--- a/packages/core/src/markdown/callout-transformer.ts+++ b/packages/core/src/markdown/callout-transformer.ts@@ -1,3 +1,4 @@+import type { Blockquote, Paragraph, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/code-fence.ts b/packages/core/src/markdown/code-fence.tsindex 9807a7e82..4499dbc92 100644--- a/packages/core/src/markdown/code-fence.ts+++ b/packages/core/src/markdown/code-fence.ts@@ -1,3 +1,4 @@+export function selectFenceChar(info: string): '`' | '~' {return info.includes('`') ? '~' : '`';}diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.tsindex 7415c474a..34704165b 100644--- a/packages/core/src/markdown/comment-promoter.ts+++ b/packages/core/src/markdown/comment-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/dedent-block-jsx-close.ts b/packages/core/src/markdown/dedent-block-jsx-close.tsindex ece5c02a1..b6299a948 100644--- a/packages/core/src/markdown/dedent-block-jsx-close.ts+++ b/packages/core/src/markdown/dedent-block-jsx-close.ts@@ -1,3 +1,4 @@+import { findFencedRegions, isInsideFence } from './fence-regions.ts';const INDENTED_BLOCK_JSX_CLOSE_RE = /^([ ]{1,3})(<\/[A-Z][A-Za-z0-9_]*\s*>)([ \t]*)$/gm;diff --git a/packages/core/src/markdown/details-accordion-promoter.ts b/packages/core/src/markdown/details-accordion-promoter.tsindex 54774764a..acd398aa6 100644--- a/packages/core/src/markdown/details-accordion-promoter.ts+++ b/packages/core/src/markdown/details-accordion-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, Parent, Root, Text } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/div-align-promoter.ts b/packages/core/src/markdown/div-align-promoter.tsindex 43ecdc709..ba9b56384 100644--- a/packages/core/src/markdown/div-align-promoter.ts+++ b/packages/core/src/markdown/div-align-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Paragraph, Parent, Root, Text } from 'mdast';import type { MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/fence-regions.ts b/packages/core/src/markdown/fence-regions.tsindex 6d3f3643e..4513da9bb 100644--- a/packages/core/src/markdown/fence-regions.ts+++ b/packages/core/src/markdown/fence-regions.ts@@ -1,3 +1,4 @@+const FENCE_RE = /^(`{3,}|~{3,})/gm;export function findFencedRegions(src: string): Array<[number, number]> {diff --git a/packages/core/src/markdown/fixtures/index.ts b/packages/core/src/markdown/fixtures/index.tsindex 00f5771ee..6931623c7 100644--- a/packages/core/src/markdown/fixtures/index.ts+++ b/packages/core/src/markdown/fixtures/index.ts@@ -1,3 +1,4 @@+import { readFileSync } from 'node:fs';import { dirname, resolve } from 'node:path';import { fileURLToPath } from 'node:url';@@ -8,6 +9,7 @@ function fixturePath(...segments: string[]): string {return resolve(FIXTURES_DIR, ...segments);}+interface GfmExample {section: string;markdown: string;@@ -17,6 +19,7 @@ export function loadGfmExamples(): GfmExample[] {return JSON.parse(readFileSync(fixturePath('gfm', 'examples.json'), 'utf8')) as GfmExample[];}+interface MdxCrashEntry {id: string;input: string;@@ -68,6 +71,7 @@ export function loadLargeEmbedFixtures(): LargeEmbedFixture[] {) as LargeEmbedFixture[];}+export function loadPrd6955Before(): string {return readFileSync(fixturePath('regression', 'prd-6955-before.md'), 'utf8');}@@ -76,6 +80,7 @@ export function loadPrd6955CorruptedTriplicated(): string {return readFileSync(fixturePath('regression', 'prd-6955-corrupted-triplicated.md'), 'utf8');}+export interface NgPinnedCase {id: string;name: string;@@ -92,6 +97,7 @@ export function loadNgPinnedCases(): NgPinnedCase[] {) as NgPinnedCase[];}+export function loadLargeRealistic(): string {return readFileSync(fixturePath('perf', 'large-realistic.md'), 'utf8');}diff --git a/packages/core/src/markdown/fixtures/perf/generate.ts b/packages/core/src/markdown/fixtures/perf/generate.tsindex 8b1eb8519..daa3ef82b 100644--- a/packages/core/src/markdown/fixtures/perf/generate.ts+++ b/packages/core/src/markdown/fixtures/perf/generate.ts@@ -1,3 +1,4 @@+import { writeFileSync } from 'node:fs';import { dirname, resolve } from 'node:path';import { fileURLToPath } from 'node:url';@@ -10,6 +11,7 @@ const BASELINE_ONLY_COUNTS = [500, 2500] as const;const SEED = 0xf1de1117;+function mulberry32(seed: number): () => number {let a = seed >>> 0;return () => {@@ -36,6 +38,7 @@ function pickWeighted<T>(rand: () => number, items: readonly [T, number][]): T {return items[items.length - 1][0];}+const WORDS = ['lorem','ipsum',@@ -153,6 +156,7 @@ function mdxBlock(rand: () => number): string {return `<${name}>\n\n${sentence(rand)}\n\n</${name}>`;}+type BlockKind = 'paragraph' | 'heading' | 'list' | 'code' | 'table' | 'mdx';const MIX: readonly [BlockKind, number][] = [@@ -191,6 +195,7 @@ function generateDocument(blockCount: number, seed: number): string {return `${blocks.join('\n\n')}\n`;}+function main(): void {for (const count of [...BLOCK_COUNTS, ...BASELINE_ONLY_COUNTS]) {const doc = generateDocument(count, SEED);diff --git a/packages/core/src/markdown/guard-flanking-matrix.ts b/packages/core/src/markdown/guard-flanking-matrix.tsindex 420dc0fe5..32c055c5b 100644--- a/packages/core/src/markdown/guard-flanking-matrix.ts+++ b/packages/core/src/markdown/guard-flanking-matrix.ts@@ -7,6 +7,7 @@ import {import { BACKSLASH_GUARD_SUBSTITUTIONS, encodeBackslashEscapes } from './backslash-escape-guard.ts';import { ENTITY_REF_GUARD_SUBSTITUTIONS, encodeEntityRefs } from './entity-ref-guard.ts';+export const ATTENTION_DELIMITERS = ['*', '_', '**', '~~', '=='] as const;export type FlankClass = 'whitespace' | 'punctuation' | 'other';diff --git a/packages/core/src/markdown/handler-shadow-audit.ts b/packages/core/src/markdown/handler-shadow-audit.tsindex 2653473da..283913255 100644--- a/packages/core/src/markdown/handler-shadow-audit.ts+++ b/packages/core/src/markdown/handler-shadow-audit.ts@@ -1,3 +1,4 @@+export interface HandlerShadowWitness {input: string;expect: 'byte' | 'byte-and-reparse-type';diff --git a/packages/core/src/markdown/highlight-promoter.ts b/packages/core/src/markdown/highlight-promoter.tsindex da0a81d23..5d1000cc4 100644--- a/packages/core/src/markdown/highlight-promoter.ts+++ b/packages/core/src/markdown/highlight-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, PhrasingContent, Root, Text } from 'mdast';import type { MdxJsxTextElement } from 'mdast-util-mdx';import { SKIP, visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/html-to-mdast.ts b/packages/core/src/markdown/html-to-mdast.tsindex 787315157..9681c0056 100644--- a/packages/core/src/markdown/html-to-mdast.ts+++ b/packages/core/src/markdown/html-to-mdast.ts@@ -1,3 +1,4 @@+import type { Element as HastElement, Root as HastRoot } from 'hast';import type { List, Nodes as MdastNodes, Root as MdastRoot } from 'mdast';import rehypeParse from 'rehype-parse';@@ -128,7 +129,8 @@ export function htmlToMdast(html: string, options?: HtmlToMdastOptions): MdastRothrow new HtmlPayloadTooLargeError(html.length, maxBytes);}- const processor = unified().use(rehypeParse, { fragment: true });+ const processor = unified()+ .use(rehypeParse, { fragment: true });for (const plugin of cleanupPlugins) {processor.use(plugin);diff --git a/packages/core/src/markdown/image-promoter.ts b/packages/core/src/markdown/image-promoter.tsindex 706fa9afb..994eb6917 100644--- a/packages/core/src/markdown/image-promoter.ts+++ b/packages/core/src/markdown/image-promoter.ts@@ -1,3 +1,4 @@+import type { Image, Paragraph, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/index.ts b/packages/core/src/markdown/index.tsindex 779e27500..ec1ac1b7e 100644--- a/packages/core/src/markdown/index.ts+++ b/packages/core/src/markdown/index.ts@@ -1,3 +1,4 @@+import {type FromProseMirrorOptions,fromPmMark,@@ -206,6 +207,7 @@ export class MarkdownManager {}}+const registry = createRegistry();function destructureAttrs(@@ -254,6 +256,7 @@ function destructureAttrs(return result;}+function hasDirtyDescendant(node: PmNode): boolean {let found = false;node.descendants((child) => {@@ -276,6 +279,7 @@ function effectiveDirty(node: PmNode, freshnessChecker?: StructuralFreshnessChecreturn freshnessChecker ? freshnessChecker.isDiverged(node.toJSON()) : false;}+function isEmptyMdastParagraph(node: MdastNodes): boolean {if (node.type !== 'paragraph') return false;const children = node.children ?? [];@@ -344,6 +348,7 @@ function extractTextFromMdastNodes(nodes: MdastNodes[]): string {return out;}+import {AUDIO_EXTENSIONS,FILE_ATTACHMENT_EXTENSIONS,@@ -596,6 +601,7 @@ function buildMdastToPmHandlers(}));}+if (m.emphasis) {handlers.emphasis = toPmMark(m.emphasis, (node: Emphasis) => ({sourceDelimiter: node.data?.sourceDelimiter ?? '*',@@ -676,6 +682,7 @@ function buildMdastToPmHandlers(}));}+if (m.link) {const sourceLiteralMark = m.sourceLiteral;handlers.link = (node: Link, _parent: MdastParent, state: MdastToPmState) => {@@ -973,6 +980,7 @@ function buildMdastToPmHandlers(};}+const blockUnknownHandler = (node: {type: string;position?: { start: { offset: number }; end: { offset: number } };@@ -1098,6 +1106,7 @@ function buildMdastToPmHandlers(return handlers as RemarkProseMirrorOptions['handlers'];}+function buildPmToMdastHandlers(schema: Schema,freshness: FreshnessCheckerHolder,diff --git a/packages/core/src/markdown/lint/applies-to.ts b/packages/core/src/markdown/lint/applies-to.tsindex fa0be9e86..b79e9aef7 100644--- a/packages/core/src/markdown/lint/applies-to.ts+++ b/packages/core/src/markdown/lint/applies-to.ts@@ -1,3 +1,4 @@+import picomatch from 'picomatch';import { SUPPORTED_DOC_EXTENSIONS } from '../../constants/doc-extensions.ts';diff --git a/packages/core/src/markdown/lint/config-files.ts b/packages/core/src/markdown/lint/config-files.tsindex 312c9c74b..94b34dee1 100644--- a/packages/core/src/markdown/lint/config-files.ts+++ b/packages/core/src/markdown/lint/config-files.ts@@ -1,3 +1,4 @@+const MARKDOWNLINT_JSON_CONFIG_FILES: ReadonlySet<string> = new Set(['.markdownlint.json','.markdownlint.jsonc',diff --git a/packages/core/src/markdown/lint/config-schemas.ts b/packages/core/src/markdown/lint/config-schemas.tsindex 3d4814597..7d97004fb 100644--- a/packages/core/src/markdown/lint/config-schemas.ts+++ b/packages/core/src/markdown/lint/config-schemas.ts@@ -51,6 +51,7 @@ const fullPluginShape = Object.fromEntries(LINT_PLUGINS.map((plugin) => [plugin.id, plugin.sliceSchema]),) as z.ZodRawShape;+export const LinterConfigSchema = z.object({enabled: z.boolean(),plugins: z.object(fullPluginShape),diff --git a/packages/core/src/markdown/lint/default-config.ts b/packages/core/src/markdown/lint/default-config.tsindex d48eea5e4..a51f2ffb0 100644--- a/packages/core/src/markdown/lint/default-config.ts+++ b/packages/core/src/markdown/lint/default-config.ts@@ -6,6 +6,7 @@ export const DEFAULT_MARKDOWNLINT_CONFIG: Record<string, MarkdownlintRuleSettingMD013: false,};+export function resolveMarkdownlintConfig(rules: Record<string, MarkdownlintRuleSetting> | undefined,): Configuration {diff --git a/packages/core/src/markdown/lint/frontmatter-schema-edit.ts b/packages/core/src/markdown/lint/frontmatter-schema-edit.tsindex ef478e268..9c9542661 100644--- a/packages/core/src/markdown/lint/frontmatter-schema-edit.ts+++ b/packages/core/src/markdown/lint/frontmatter-schema-edit.ts@@ -1,3 +1,4 @@+import { CANONICAL_SCHEMA_DIALECT_URIS, DEFAULT_SCHEMA_DIALECT } from './frontmatter-validate.ts';export interface FrontmatterFieldConstraint {diff --git a/packages/core/src/markdown/lint/frontmatter-validate.ts b/packages/core/src/markdown/lint/frontmatter-validate.tsindex eba37cee7..ca6eed91c 100644--- a/packages/core/src/markdown/lint/frontmatter-validate.ts+++ b/packages/core/src/markdown/lint/frontmatter-validate.ts@@ -1,3 +1,4 @@+import Ajv, { type ValidateFunction } from 'ajv';import Ajv2019 from 'ajv/dist/2019.js';import Ajv2020 from 'ajv/dist/2020.js';diff --git a/packages/core/src/markdown/lint/index.ts b/packages/core/src/markdown/lint/index.tsindex ae5ff2924..9c2a0875e 100644--- a/packages/core/src/markdown/lint/index.ts+++ b/packages/core/src/markdown/lint/index.ts@@ -1,3 +1,4 @@+import { LINT_PLUGINS, type LinterConfig } from './plugins.ts';import type { LintDiagnostic } from './types.ts';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts b/packages/core/src/markdown/lint/okf-frontmatter/materialize.tsindex 7a5af097e..f438f1b16 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/materialize.ts@@ -1,3 +1,4 @@+import type { OkfRuleId } from '../okf-rule-meta.ts';import { fileNameFor, OKF_SCHEMA_DIR, okfSchemaPathFor } from './paths.ts';import { OKF_FRONTMATTER_REGISTRY } from './registry.ts';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/paths.ts b/packages/core/src/markdown/lint/okf-frontmatter/paths.tsindex 1ee913527..c290b6878 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/paths.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/paths.ts@@ -1,3 +1,4 @@+import type { OkfRuleId } from '../okf-rule-meta.ts';export const OKF_SCHEMA_DIR = '.ok/okf';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/registry.ts b/packages/core/src/markdown/lint/okf-frontmatter/registry.tsindex de09740c5..5168602d5 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/registry.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/registry.ts@@ -1,3 +1,4 @@+import { compileAppliesTo } from '../applies-to.ts';import { validateFrontmatterSource } from '../frontmatter-validate.ts';import { isOkfRuleEnabled, type OkfRuleId, type OkfRuleToggles } from '../okf-rule-meta.ts';diff --git a/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts b/packages/core/src/markdown/lint/okf-frontmatter/schemas.tsindex f1c37671b..89845d3d5 100644--- a/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts+++ b/packages/core/src/markdown/lint/okf-frontmatter/schemas.ts@@ -1,3 +1,4 @@+// file-level form is deliberate: the sibling `biome-ignore` must sit on the line// oxlint-disable unicorn/no-thenablediff --git a/packages/core/src/markdown/lint/okf-project/rules.ts b/packages/core/src/markdown/lint/okf-project/rules.tsindex 6d691ae2b..8b476332e 100644--- a/packages/core/src/markdown/lint/okf-project/rules.ts+++ b/packages/core/src/markdown/lint/okf-project/rules.ts@@ -1,3 +1,4 @@+import { SUPPORTED_DOC_EXTENSIONS } from '../../../constants/doc-extensions.ts';import { isOkfRuleEnabled, type OkfRuleId, type OkfRuleToggles } from '../okf-rule-meta.ts';diff --git a/packages/core/src/markdown/lint/okf-rule-meta.ts b/packages/core/src/markdown/lint/okf-rule-meta.tsindex 4de50d79f..44913a9dc 100644--- a/packages/core/src/markdown/lint/okf-rule-meta.ts+++ b/packages/core/src/markdown/lint/okf-rule-meta.ts@@ -1,3 +1,4 @@+export const OKF_RULE_IDS = ['no-wiki-links','log-shape',diff --git a/packages/core/src/markdown/lint/okf-rules.ts b/packages/core/src/markdown/lint/okf-rules.tsindex 1d5538421..d0999b62e 100644--- a/packages/core/src/markdown/lint/okf-rules.ts+++ b/packages/core/src/markdown/lint/okf-rules.ts@@ -1,3 +1,4 @@+import { isOkfRuleEnabled, type OkfRuleId, type OkfRuleToggles } from './okf-rule-meta.ts';import type { OkfRule } from './okf-runner.ts';import { indexShape } from './rules/index-shape.ts';diff --git a/packages/core/src/markdown/lint/okf-runner.ts b/packages/core/src/markdown/lint/okf-runner.tsindex de130e3f4..fabb08d6e 100644--- a/packages/core/src/markdown/lint/okf-runner.ts+++ b/packages/core/src/markdown/lint/okf-runner.ts@@ -1,3 +1,4 @@+import type { Root } from 'mdast';import remarkFrontmatter from 'remark-frontmatter';import remarkGfm from 'remark-gfm';diff --git a/packages/core/src/markdown/lint/plugins.ts b/packages/core/src/markdown/lint/plugins.tsindex 4b9df9c56..03efcf66c 100644--- a/packages/core/src/markdown/lint/plugins.ts+++ b/packages/core/src/markdown/lint/plugins.ts@@ -1,3 +1,4 @@+import { z } from 'zod';import { DEFAULT_MARKDOWNLINT_CONFIG, resolveMarkdownlintConfig } from './default-config.ts';import {@@ -17,6 +18,7 @@ import {type OkfSlice,} from './types.ts';+const MarkdownlintRuleSettingSchema = z.union([z.boolean(),z.enum(MARKDOWNLINT_RULE_SEVERITIES),diff --git a/packages/core/src/markdown/lint/rules/index-shape.ts b/packages/core/src/markdown/lint/rules/index-shape.tsindex 59fe9b87d..fcbb1b56c 100644--- a/packages/core/src/markdown/lint/rules/index-shape.ts+++ b/packages/core/src/markdown/lint/rules/index-shape.ts@@ -1,3 +1,4 @@+import type { List, ListItem } from 'mdast';import { EXIT, visit } from 'unist-util-visit';import { defineScopedOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/rules/log-shape.ts b/packages/core/src/markdown/lint/rules/log-shape.tsindex e0159519f..431e4e9c8 100644--- a/packages/core/src/markdown/lint/rules/log-shape.ts+++ b/packages/core/src/markdown/lint/rules/log-shape.ts@@ -1,3 +1,4 @@+import type { Heading } from 'mdast';import { toString as headingText } from 'mdast-util-to-string';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/lint/rules/no-wiki-links.ts b/packages/core/src/markdown/lint/rules/no-wiki-links.tsindex 2123e977f..f75a04d15 100644--- a/packages/core/src/markdown/lint/rules/no-wiki-links.ts+++ b/packages/core/src/markdown/lint/rules/no-wiki-links.ts@@ -1,3 +1,4 @@+import type { Point } from 'unist';import { visit } from 'unist-util-visit';import { defineOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/rules/reserved-casing.ts b/packages/core/src/markdown/lint/rules/reserved-casing.tsindex 89ef3e4a9..c8b4d8f28 100644--- a/packages/core/src/markdown/lint/rules/reserved-casing.ts+++ b/packages/core/src/markdown/lint/rules/reserved-casing.ts@@ -1,3 +1,4 @@+import { SUPPORTED_DOC_EXTENSIONS } from '../../../constants/doc-extensions.ts';import { defineOkfRule } from '../okf-runner.ts';diff --git a/packages/core/src/markdown/lint/types.ts b/packages/core/src/markdown/lint/types.tsindex 2a8f4a279..4fa9a5a27 100644--- a/packages/core/src/markdown/lint/types.ts+++ b/packages/core/src/markdown/lint/types.ts@@ -1,3 +1,4 @@+import type { BrokenLinkReason } from '../../schemas/api/agent-write.ts';import type { OkfRuleId } from './okf-rule-meta.ts';@@ -105,6 +106,7 @@ export interface OkfSlice {generate?: { index?: boolean };}+interface RuleOptionSpecBase {key: string;description: string;diff --git a/packages/core/src/markdown/lint/validation-counts.ts b/packages/core/src/markdown/lint/validation-counts.tsindex 98238656e..437cc539a 100644--- a/packages/core/src/markdown/lint/validation-counts.ts+++ b/packages/core/src/markdown/lint/validation-counts.ts@@ -1,3 +1,4 @@+export interface ValidationSourceCounts {errorCount: number;warningCount: number;diff --git a/packages/core/src/markdown/math-promoter.ts b/packages/core/src/markdown/math-promoter.tsindex a5b511f25..bd79424c7 100644--- a/packages/core/src/markdown/math-promoter.ts+++ b/packages/core/src/markdown/math-promoter.ts@@ -1,3 +1,4 @@+import type { Code, Root } from 'mdast';import type { Math as MdastMath } from 'mdast-util-math';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';diff --git a/packages/core/src/markdown/mdast-to-hast-handlers.ts b/packages/core/src/markdown/mdast-to-hast-handlers.tsindex ed89371d0..00fbc0035 100644--- a/packages/core/src/markdown/mdast-to-hast-handlers.ts+++ b/packages/core/src/markdown/mdast-to-hast-handlers.ts@@ -1,3 +1,4 @@+import type { Comment, Element, ElementContent, Properties } from 'hast';import type { FootnoteDefinition, FootnoteReference } from 'mdast';import type { MdxJsxFlowElement, MdxJsxTextElement } from 'mdast-util-mdx';diff --git a/packages/core/src/markdown/mdast-to-html.ts b/packages/core/src/markdown/mdast-to-html.tsindex 8ce2b2492..df788a80d 100644--- a/packages/core/src/markdown/mdast-to-html.ts+++ b/packages/core/src/markdown/mdast-to-html.ts@@ -1,3 +1,4 @@+import type { Element, Root as HastRoot, Text as HastText } from 'hast';import type { Root as MdastRoot, Text as MdastText } from 'mdast';import type { Handler } from 'mdast-util-to-hast';diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.tsindex bfd7e3109..fa3cfcd86 100644--- a/packages/core/src/markdown/merged-walker.ts+++ b/packages/core/src/markdown/merged-walker.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, Root } from 'mdast';import { SKIP, visit } from 'unist-util-visit';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/mermaid-promoter.ts b/packages/core/src/markdown/mermaid-promoter.tsindex 1a897fca8..17ed2b829 100644--- a/packages/core/src/markdown/mermaid-promoter.ts+++ b/packages/core/src/markdown/mermaid-promoter.ts@@ -1,3 +1,4 @@+import type { Code, Root } from 'mdast';import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/parse-with-fallback.ts b/packages/core/src/markdown/parse-with-fallback.tsindex d988f4b8b..4aa0490c4 100644--- a/packages/core/src/markdown/parse-with-fallback.ts+++ b/packages/core/src/markdown/parse-with-fallback.ts@@ -168,6 +168,7 @@ export function parseRecursive(}}+interface VFilePlace {offset?: number;start?: { offset?: number };@@ -186,6 +187,7 @@ function extractErrorOffset(err: unknown): number | undefined {return undefined;}+interface Region {start: number;end: number;@@ -209,6 +211,7 @@ function nearestBlankLineAfter(src: string, offset: number): number | null {return null;}+export interface TagEvent {kind: 'open' | 'close' | 'self-close';name: string;@@ -355,6 +358,7 @@ function findFallbackRegion(src: string, errorOffset: number): Region {return { start: blockStart, end: blockEnd };}+interface SourceBlock {src: string;start: number;@@ -452,6 +456,7 @@ function tryPerBlockFallback(};}+function wholeDocRawText(source: string): JSONContent {return {type: 'doc',diff --git a/packages/core/src/markdown/parser-drop-closure.ts b/packages/core/src/markdown/parser-drop-closure.tsindex e6ab4fd57..43d420187 100644--- a/packages/core/src/markdown/parser-drop-closure.ts+++ b/packages/core/src/markdown/parser-drop-closure.ts@@ -1,3 +1,4 @@+export type DroppedTokenAdjudication =| {kind: 'format-dof-axis';diff --git a/packages/core/src/markdown/pipeline.ts b/packages/core/src/markdown/pipeline.tsindex 0e3224206..55736041c 100644--- a/packages/core/src/markdown/pipeline.ts+++ b/packages/core/src/markdown/pipeline.ts@@ -1,3 +1,4 @@+import {type FromProseMirrorOptions,fromProseMirror,diff --git a/packages/core/src/markdown/position-aware-join.ts b/packages/core/src/markdown/position-aware-join.tsindex 91cdf658f..ccf06e94d 100644--- a/packages/core/src/markdown/position-aware-join.ts+++ b/packages/core/src/markdown/position-aware-join.ts@@ -1,3 +1,4 @@+import type { Join } from 'mdast-util-to-markdown';import type { Position } from 'unist';import { isBlankLineParagraph } from './zero-emission-blocks.ts';diff --git a/packages/core/src/markdown/position-slice.ts b/packages/core/src/markdown/position-slice.tsindex 0f399d34c..e5b4c9eba 100644--- a/packages/core/src/markdown/position-slice.ts+++ b/packages/core/src/markdown/position-slice.ts@@ -1,3 +1,4 @@+import type { Nodes, Root } from 'mdast';import { visit } from 'unist-util-visit';import type { VFile } from 'vfile';@@ -476,7 +477,8 @@ export function applyPositionSliceToNode(const first = source[startOff];if (first !== '[' && first !== '<' && !node.title) {node.data.sourceStyle = 'gfm-autolink';- } else if (first === '[') {+ }+ else if (first === '[') {const slice = source.slice(startOff, endOff);const closeBracketIdx = slice.lastIndexOf('](');if (closeBracketIdx !== -1) {diff --git a/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts b/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.tsindex db10fa54b..ca225ce9b 100644--- a/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts+++ b/packages/core/src/markdown/rehype-plugins/skip-notion-whitespace.ts@@ -1,3 +1,4 @@+import type { Comment, Element, Root, Text } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts b/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.tsindex 34068d103..3a2524a9a 100644--- a/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-cocoa-meta.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts b/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.tsindex 93151d43b..2279a0189 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gdocs-wrapper.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts b/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.tsindex 188f02d83..a0f467c42 100644--- a/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-github-hovercard.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts b/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.tsindex 4ba2c3418..4e8542a21 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gmail-classes.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts b/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.tsindex 1a74b1272..a3c96b24a 100644--- a/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-gsheets-wrapper.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts b/packages/core/src/markdown/rehype-plugins/strip-mso-styles.tsindex de35e7b79..e95cf43d6 100644--- a/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-mso-styles.ts@@ -1,3 +1,4 @@+import type { Comment, Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts b/packages/core/src/markdown/rehype-plugins/strip-slack-classes.tsindex b4be1b2ea..ffdb4d5b5 100644--- a/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-slack-classes.ts@@ -1,3 +1,4 @@+import type { Element, ElementContent, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts b/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.tsindex 3c8d88b7c..e2a96d1a7 100644--- a/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts+++ b/packages/core/src/markdown/rehype-plugins/strip-vscode-spans.ts@@ -1,3 +1,4 @@+import type { Element, Root } from 'hast';import type { Plugin } from 'unified';diff --git a/packages/core/src/markdown/resolve-image-url.ts b/packages/core/src/markdown/resolve-image-url.tsindex cf2c9da8e..0389575ac 100644--- a/packages/core/src/markdown/resolve-image-url.ts+++ b/packages/core/src/markdown/resolve-image-url.ts@@ -1,3 +1,4 @@+import { isRelativeUrl } from './safe-url.ts';function isDevDiagnosticContext(): boolean {diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.tsindex 4d3250d3a..8be632ba4 100644--- a/packages/core/src/markdown/safe-url.ts+++ b/packages/core/src/markdown/safe-url.ts@@ -1,3 +1,4 @@+export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');diff --git a/packages/core/src/markdown/serialize-fidelity.test-helper.ts b/packages/core/src/markdown/serialize-fidelity.test-helper.tsindex 0dd54070e..96304e7a5 100644--- a/packages/core/src/markdown/serialize-fidelity.test-helper.ts+++ b/packages/core/src/markdown/serialize-fidelity.test-helper.ts@@ -1,3 +1,4 @@+import type { JSONContent } from '@tiptap/core';import type { Nodes } from 'mdast';import { expect } from 'vitest';diff --git a/packages/core/src/markdown/serialize-helpers.ts b/packages/core/src/markdown/serialize-helpers.tsindex 7cac5b042..93798cf83 100644--- a/packages/core/src/markdown/serialize-helpers.ts+++ b/packages/core/src/markdown/serialize-helpers.ts@@ -1,3 +1,4 @@+import type { Node as PmNode } from '@tiptap/pm/model';import type {MdxJsxAttribute,diff --git a/packages/core/src/markdown/single-dollar-math-promoter.ts b/packages/core/src/markdown/single-dollar-math-promoter.tsindex b012a5aff..8c08b7a04 100644--- a/packages/core/src/markdown/single-dollar-math-promoter.ts+++ b/packages/core/src/markdown/single-dollar-math-promoter.ts@@ -1,3 +1,4 @@+import type { PhrasingContent, Root, Text } from 'mdast';import type { InlineMath } from 'mdast-util-math';import { SKIP, visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/to-markdown-handlers.ts b/packages/core/src/markdown/to-markdown-handlers.tsindex 3e79f8cb6..959cc0bd2 100644--- a/packages/core/src/markdown/to-markdown-handlers.ts+++ b/packages/core/src/markdown/to-markdown-handlers.ts@@ -1,3 +1,4 @@+import type { Nodes, Parents } from 'mdast';import type { MdxJsxAttribute, MdxJsxExpressionAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';import type { Handle, Info, State } from 'mdast-util-to-markdown';diff --git a/packages/core/src/markdown/underline-promoter.ts b/packages/core/src/markdown/underline-promoter.tsindex 0f1b0f27d..6e6d73400 100644--- a/packages/core/src/markdown/underline-promoter.ts+++ b/packages/core/src/markdown/underline-promoter.ts@@ -1,3 +1,4 @@+import type { Nodes, Parent, Root } from 'mdast';import type { MdxJsxTextElement } from 'mdast-util-mdx';import { visit } from 'unist-util-visit';diff --git a/packages/core/src/markdown/unknown-mdast-guard.ts b/packages/core/src/markdown/unknown-mdast-guard.tsindex 1a082bda7..932d7d2a8 100644--- a/packages/core/src/markdown/unknown-mdast-guard.ts+++ b/packages/core/src/markdown/unknown-mdast-guard.ts@@ -1,3 +1,4 @@+import type { Root as MdastRoot } from 'mdast';import type { VFile } from 'vfile';diff --git a/packages/core/src/markdown/whitespace-char-ref.ts b/packages/core/src/markdown/whitespace-char-ref.tsindex d578476a7..ac9f5239b 100644--- a/packages/core/src/markdown/whitespace-char-ref.ts+++ b/packages/core/src/markdown/whitespace-char-ref.ts@@ -1,3 +1,4 @@+const INLINE_WHITESPACE_BY_CODE: ReadonlyMap<number, string> = new Map([[0x20, ' '],[0x09, '\t'],diff --git a/packages/core/src/markdown/wiki-link-micromark.ts b/packages/core/src/markdown/wiki-link-micromark.tsindex 6dad26200..afd9936fe 100644--- a/packages/core/src/markdown/wiki-link-micromark.ts+++ b/packages/core/src/markdown/wiki-link-micromark.ts@@ -17,6 +17,7 @@ declare module 'micromark-util-types' {}}+const CODE_BANG = 33; // !const CODE_LBRACKET = 91; // [const CODE_RBRACKET = 93; // ]@@ -260,6 +261,7 @@ export function wikiLinkSyntax(): Extension {};}+function enterWikiLink(this: CompileContext, token: Token) {this.enter({@@ -385,6 +387,7 @@ export const wikiLinkToMarkdown: {unsafe: [{ character: '[', inConstruct: ['phrasing'] }],};+const MICROMARK_EXT = wikiLinkSyntax();export function remarkWikiLink(this: Processor) {