Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Remove empty JSX braces and gate JSX braces in oxlint (#6770)

Dimitri POSTOLOV45faafd2aa81
diff --git a/biome.jsonc b/biome.jsonc
index 74d2d71b4..e912296a0 100644
--- a/biome.jsonc
+++ b/biome.jsonc
@@ -22,6 +22,16 @@
"enabled": true,
"rules": {
"preset": "recommended",
+ "a11y": {
+ "noAmbiguousAnchorText": "off",
+ "noNoninteractiveTabindex": "off",
+ "noStaticElementInteractions": "off",
+ "useKeyWithClickEvents": "off",
+ "useValidAnchor": "off"
+ },
+ "security": {
+ "noDangerouslySetInnerHtml": "off"
+ },
"suspicious": {
"noReactForwardRef": "error"
},
diff --git a/docs/src/app/d/[encoded]/splash-cli-block.tsx b/docs/src/app/d/[encoded]/splash-cli-block.tsx
index 8a8536cde..5c80c8402 100644
--- a/docs/src/app/d/[encoded]/splash-cli-block.tsx
+++ b/docs/src/app/d/[encoded]/splash-cli-block.tsx
@@ -77,13 +77,11 @@ export function SplashCliBlock({ installCommand, cloneCommand, showHeading }: Sp
return (
<div>
- {}
{showHeading ? (
<p className="mb-2 inline-flex w-fit items-center gap-1.5 font-mono text-sm uppercase tracking-wide text-slide-muted">
{cloneCommand ? 'Open with CLI' : 'Install the CLI'}
</p>
) : null}
- {}
<div className="not-prose relative" data-testid="splash-cli-body">
<div className="rounded-lg border bg-slide-bg dark:bg-white/5">
<pre
@@ -118,7 +116,6 @@ export function SplashCliBlock({ installCommand, cloneCommand, showHeading }: Sp
) : (
<Copy className="size-4" aria-hidden="true" />
)}
- {}
<span className="sr-only" aria-live="polite">
{statusLabel}
</span>
diff --git a/docs/src/app/d/[encoded]/splash-cta-cluster.tsx b/docs/src/app/d/[encoded]/splash-cta-cluster.tsx
index d7b3bee78..cb160b199 100644
--- a/docs/src/app/d/[encoded]/splash-cta-cluster.tsx
+++ b/docs/src/app/d/[encoded]/splash-cta-cluster.tsx
@@ -84,7 +84,6 @@ export function SplashCtaCluster({
<SplashButtonLabel>{attempting ? 'Opening…' : 'Open in desktop app'}</SplashButtonLabel>
</a>
- {}
<SplashDownloadSplitButton
downloadUrl={downloadUrl}
platformBaseUrl={platformBaseUrl}
diff --git a/docs/src/app/d/[encoded]/splash-download-split-button.tsx b/docs/src/app/d/[encoded]/splash-download-split-button.tsx
index 29cc4ef0b..10c06f62f 100644
--- a/docs/src/app/d/[encoded]/splash-download-split-button.tsx
+++ b/docs/src/app/d/[encoded]/splash-download-split-button.tsx
@@ -77,7 +77,6 @@ export function SplashDownloadSplitButton({
)}
>
<ArrowDown aria-hidden="true" className="size-4 shrink-0" />
- {}
{detectedOs === 'unknown' ? 'Download the app' : downloadLabelForOs(detectedOs)}
</a>
diff --git a/docs/src/app/d/[encoded]/splash-share-view.tsx b/docs/src/app/d/[encoded]/splash-share-view.tsx
index 99be4ecd6..1260542d3 100644
--- a/docs/src/app/d/[encoded]/splash-share-view.tsx
+++ b/docs/src/app/d/[encoded]/splash-share-view.tsx
@@ -116,7 +116,6 @@ function SplashChrome() {
<header className="relative z-10 px-6">
<div className="container mx-auto flex pt-8 md:pt-10">
<Link href="/" aria-label="OpenKnowledge home" className="inline-flex items-center">
- {}
<OkWordmark aria-hidden="true" className="h-8 w-auto text-slide-text" />
</Link>
</div>
@@ -138,7 +137,6 @@ export function SplashFallback({ heading, description }: { heading: string; desc
<p className="mt-4 max-w-xl text-slide-muted">{description}</p>
- {}
<div className="mt-10 flex flex-wrap items-center gap-4">
<SplashFallbackCta />
</div>
diff --git a/docs/src/app/docs/changelog/[tag]/page.tsx b/docs/src/app/docs/changelog/[tag]/page.tsx
index 10bebd293..f93c47554 100644
--- a/docs/src/app/docs/changelog/[tag]/page.tsx
+++ b/docs/src/app/docs/changelog/[tag]/page.tsx
@@ -64,7 +64,7 @@ export default async function ReleasePage(props: PageProps<'/docs/changelog/[tag
{date ? <DocsDescription>{`Released ${date}.`}</DocsDescription> : null}
<DocsBody>
{release.bodyHtml ? (
- // biome-ignore lint/security/noDangerouslySetInnerHtml: trusted maintainer-authored release notes, rendered at build time
+ // oxlint-disable-next-line react/no-danger -- trusted maintainer-authored release notes, rendered at build time
<div dangerouslySetInnerHTML={{ __html: release.bodyHtml }} />
) : (
<p>No notes for this release.</p>
diff --git a/docs/src/app/docs/changelog/page.tsx b/docs/src/app/docs/changelog/page.tsx
index 5dd7c5d62..fd7da5166 100644
--- a/docs/src/app/docs/changelog/page.tsx
+++ b/docs/src/app/docs/changelog/page.tsx
@@ -38,7 +38,6 @@ export default async function ChangelogPage() {
<DocsPage toc={toc} tableOfContent={{ style: 'clerk' }} article={{ className: 'pb-12' }}>
<DocsTitle>{PAGE_TITLE}</DocsTitle>
<DocsDescription>{PAGE_DESCRIPTION}</DocsDescription>
- {}
<ChangelogTimeline releases={releases} />
</DocsPage>
);
diff --git a/docs/src/components/changelog-timeline.tsx b/docs/src/components/changelog-timeline.tsx
index 784a78347..12069f065 100644
--- a/docs/src/components/changelog-timeline.tsx
+++ b/docs/src/components/changelog-timeline.tsx
@@ -19,7 +19,6 @@ function ChangelogEntry({ release }: { release: ReleaseNote }) {
id={release.tag}
className="group relative scroll-mt-24 pb-10 md:grid md:grid-cols-[10rem_1fr] md:gap-8"
>
- {}
<div className="relative md:sticky md:top-24 md:self-start md:pb-10">
<div
aria-hidden="true"
@@ -29,7 +28,6 @@ function ChangelogEntry({ release }: { release: ReleaseNote }) {
aria-hidden="true"
className="absolute top-1.5 -right-[1.1875rem] hidden size-2.5 rounded-full border-2 border-fd-background bg-fd-primary md:block"
/>
- {}
<a
href={`${CHANGELOG_ROUTE}/${release.tag}`}
className="font-mono text-sm font-medium text-fd-foreground no-underline transition-colors hover:text-fd-primary"
@@ -50,7 +48,7 @@ function ChangelogEntry({ release }: { release: ReleaseNote }) {
{release.bodyHtml ? (
<div
className="prose max-w-none prose-headings:mt-6 prose-headings:mb-2 first:prose-headings:mt-0"
- // biome-ignore lint/security/noDangerouslySetInnerHtml: trusted maintainer-authored release notes, rendered at build time
+ // oxlint-disable-next-line react/no-danger -- trusted maintainer-authored release notes, rendered at build time
dangerouslySetInnerHTML={{ __html: release.bodyHtml }}
/>
) : (
diff --git a/docs/src/components/copy-prompt.tsx b/docs/src/components/copy-prompt.tsx
index c3e72adf2..a8c5aef59 100644
--- a/docs/src/components/copy-prompt.tsx
+++ b/docs/src/components/copy-prompt.tsx
@@ -37,7 +37,6 @@ export function CopyPrompt({ children }: CopyPromptProps) {
data-copied={copied}
className="ok-overview not-prose group my-2.5 flex w-full cursor-pointer items-start gap-3 rounded-lg border border-fd-border bg-fd-card px-4 py-3 text-start text-[0.9375rem] leading-relaxed text-fd-foreground shadow-sm transition hover:border-[var(--ok-accent)] hover:bg-fd-accent/40"
>
- {}
<span className="flex-1 whitespace-pre-wrap italic">“{text}”</span>
<span
className="mt-px inline-flex shrink-0 items-center gap-1.5 text-[12.5px] font-medium text-fd-muted-foreground transition-colors group-hover:text-[var(--ok-accent)]"
diff --git a/docs/src/components/docs-sidebar-cta.tsx b/docs/src/components/docs-sidebar-cta.tsx
index 4e6fde282..1583bfbd4 100644
--- a/docs/src/components/docs-sidebar-cta.tsx
+++ b/docs/src/components/docs-sidebar-cta.tsx
@@ -12,8 +12,6 @@ const fullStars = new Intl.NumberFormat('en-US');
export function DocsSidebarCta({ stars }: { stars: number | null }) {
return (
<div className="flex gap-2">
- {}
- {}
<DownloadSplitButton cta="docs-sidebar" variant="compact" className="min-w-0 flex-1" />
<MarketingButton
href={GITHUB_URL}
diff --git a/docs/src/components/download-split-button.tsx b/docs/src/components/download-split-button.tsx
index d9e43f7a7..0e5b1d4d0 100644
--- a/docs/src/components/download-split-button.tsx
+++ b/docs/src/components/download-split-button.tsx
@@ -58,7 +58,6 @@ export function DownloadSplitButton({
data-testid="download-split-primary"
className={cn(chrome.base, chrome.primary)}
>
- {}
{variant === 'compact' ? null : <Download className="size-4 shrink-0" aria-hidden="true" />}
<span className="truncate">{variant === 'compact' ? 'Download' : osLabel}</span>
</a>
diff --git a/docs/src/components/download-text-link.tsx b/docs/src/components/download-text-link.tsx
index 8c527a138..c77b43f52 100644
--- a/docs/src/components/download-text-link.tsx
+++ b/docs/src/components/download-text-link.tsx
@@ -35,11 +35,9 @@ export function DownloadTextLink({ cta, className }: DownloadTextLinkProps) {
return (
<>
- {}
<a href={href} className={className}>
Download it{suffix ? ` ${suffix}` : ''}
</a>
- {}
{href === pickerHref ? null : (
<>
<span className="text-slide-muted"> · </span>
diff --git a/docs/src/components/icons/openclaw.tsx b/docs/src/components/icons/openclaw.tsx
index 27690449c..51920bee3 100644
--- a/docs/src/components/icons/openclaw.tsx
+++ b/docs/src/components/icons/openclaw.tsx
@@ -19,14 +19,10 @@ export function OpenClawIcon(props: SVGProps<SVGSVGElement>) {
<circle cx={75} cy={35} r={6} fill="black" />
</mask>
<g fill="currentColor" mask="url(#openclaw-eyes)">
- {}
<path d="M60 10 C30 10 15 35 15 55 C15 75 30 95 45 100 L45 110 L55 110 L55 100 C55 100 60 102 65 100 L65 110 L75 110 L75 100 C90 95 105 75 105 55 C105 35 90 10 60 10Z" />
- {}
<path d="M20 45 C5 40 0 50 5 60 C10 70 20 65 25 55 C28 48 25 45 20 45Z" />
- {}
<path d="M100 45 C115 40 120 50 115 60 C110 70 100 65 95 55 C92 48 95 45 100 45Z" />
</g>
- {}
<path
d="M45 15 Q35 5 30 8"
fill="none"
diff --git a/docs/src/components/mermaid.tsx b/docs/src/components/mermaid.tsx
index a3533332f..8d21c0c49 100644
--- a/docs/src/components/mermaid.tsx
+++ b/docs/src/components/mermaid.tsx
@@ -49,7 +49,7 @@ function MermaidContent({ chart }: { chart: string }) {
ref={(container) => {
if (container) bindFunctions?.(container);
}}
- // biome-ignore lint/security/noDangerouslySetInnerHtml: mermaid renders trusted SVG
+ // oxlint-disable-next-line react/no-danger -- mermaid renders trusted SVG
dangerouslySetInnerHTML={{ __html: svg }}
/>
);
diff --git a/docs/src/components/page-markdown-actions.tsx b/docs/src/components/page-markdown-actions.tsx
index e62e5d7bf..bd60dd99b 100644
--- a/docs/src/components/page-markdown-actions.tsx
+++ b/docs/src/components/page-markdown-actions.tsx
@@ -93,7 +93,6 @@ export function PageMarkdownActions({
</DropdownMenuItem>
<DropdownMenuItem asChild className={menuItemClass}>
<a href={claudeUrl} target="_blank" rel="noreferrer">
- {}
<ClaudeIcon aria-hidden="true" className="size-4 text-[#d97757]" />
Open in Claude
</a>
diff --git a/docs/src/components/previews/math-preview.tsx b/docs/src/components/previews/math-preview.tsx
index 181acde17..b2a07fe88 100644
--- a/docs/src/components/previews/math-preview.tsx
+++ b/docs/src/components/previews/math-preview.tsx
@@ -5,7 +5,7 @@ import katex from 'katex';
export function MathPreview({ formula, display = true }: { formula: string; display?: boolean }) {
const html = renderFormula(formula, display);
- // biome-ignore lint/security/noDangerouslySetInnerHtml: katex output is trusted
+ // oxlint-disable-next-line react/no-danger -- katex output is trusted
return <div className="text-fd-foreground" dangerouslySetInnerHTML={{ __html: html }} />;
}
diff --git a/docs/src/components/product-updates-form.tsx b/docs/src/components/product-updates-form.tsx
index 7e2ec8988..9b845f784 100644
--- a/docs/src/components/product-updates-form.tsx
+++ b/docs/src/components/product-updates-form.tsx
@@ -71,7 +71,6 @@ export function ProductUpdatesForm() {
<label htmlFor={field.name} className="sr-only">
Email
</label>
- {}
<div
data-invalid={fieldState.invalid}
className="flex h-11 items-center rounded-xl border border-input bg-fd-background pr-1 transition-colors focus-within:border-slide-accent focus-within:ring-2 focus-within:ring-slide-accent/40 data-[invalid=true]:border-red-500"
diff --git a/docs/src/components/seo/json-ld.tsx b/docs/src/components/seo/json-ld.tsx
index fd852e9d4..35e66c435 100644
--- a/docs/src/components/seo/json-ld.tsx
+++ b/docs/src/components/seo/json-ld.tsx
@@ -8,7 +8,7 @@ export function JsonLd({ json }: { json: WithContext<Thing> | WithContext<Thing>
return (
<script
type="application/ld+json"
- // biome-ignore lint/security/noDangerouslySetInnerHtml: JSON-LD requires raw JSON inside a <script> tag; React children would be HTML-escaped and break the JSON. </script>-escape guard above keeps the tag breakout-safe.
+ // oxlint-disable-next-line react/no-danger -- JSON-LD requires raw JSON inside a <script> tag; React children would be HTML-escaped and break the JSON. </script>-escape guard above keeps the tag breakout-safe.
dangerouslySetInnerHTML={{ __html: safeJsonLdSerialize(json) }}
/>
);
diff --git a/docs/src/components/slide-page.tsx b/docs/src/components/slide-page.tsx
index a0264149e..2c7f373c1 100644
--- a/docs/src/components/slide-page.tsx
+++ b/docs/src/components/slide-page.tsx
@@ -20,7 +20,6 @@ export function SlidePageShell({ children }: { children: ReactNode }) {
<header className="relative z-10 px-6">
<div className="container mx-auto flex pt-8 md:pt-10">
<Link href="/" aria-label="OpenKnowledge home" className="inline-flex items-center">
- {}
<OkWordmark aria-hidden="true" className="h-8 w-auto text-slide-text" />
</Link>
</div>
diff --git a/knip.config.ts b/knip.config.ts
index 36a395261..da29e330e 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -71,7 +71,7 @@ export default {
'packages/app/src/editor/http-client.ts': ['types'],
'.{agents,codex}/skills/**': ['files'],
'lint-plugins/no-comments/__fixtures__/**': ['files'],
- 'lint-plugins/ok-rules/__fixtures__/**': ['files'],
+ 'lint-plugins/ok-rules/__fixtures__/**': ['files', 'exports'],
'**/*.reads.{ts,mjs}': ['files', 'exports'],
'scripts/compute-next-beta.mjs': ['files'],
'scripts/build-slack-release-payload.mjs': ['files'],
diff --git a/lint-plugins/no-comments/README.md b/lint-plugins/no-comments/README.md
index 401b19f51..bee106ad2 100644
--- a/lint-plugins/no-comments/README.md
+++ b/lint-plugins/no-comments/README.md
@@ -701,7 +701,7 @@ The exit code is the machine half of that recipe, so a chained command can branc
| code | meaning |
|---|---|
| 0 | clean: nothing was refused, and with `--write` everything in scope was stripped. `--write` is opt-in, so a plain invocation is a dry run that reaches this code having written nothing — 0 means "no file was refused", never "the tree was rewritten". The report's first line says which of the two ran, and a dry run labels its counters `would change` / `would remove`. A protected-region hit is reported but does not change the code, so a run whose only outstanding item is a protected region also exits 0 |
-| 1 | a file was refused, so nothing was written for it and the run carried on. Each reason prints as the literal below. `identity-divergence`, the strip failed its family's oracle — a significant-token mismatch for the c-family; a `shfmt -mn` canonical-form mismatch, a changed shebang or a `bash -n` rejection for shell — and `kept-comment-lost`, an allowlisted comment the strip removed: both are bugs to report rather than rebase steps. `non-utf8-bytes`, a file whose bytes do not round-trip UTF-8 (decoding it would rewrite them as U+FFFD, so the codemod never decodes it) — convert or exclude it by hand. `no-grammar`, a path no family claims — declare it in the config or leave it out. `no-identity-oracle`, a family the codemod cannot prove a strip invariant for. `source-changed-since-plan`, a file another writer rewrote between the read that planned the strip and the write — re-run. `source-unreadable-at-flush`, a planned file that could not be re-read before its write — fix the permission or the missing path; re-running alone will not clear it. Where a reason carries more detail the report prints it in parentheses after the name. A refusal outranks pending human work, so a run that also leaves rot survivors or over-cap citations exits 1, not 3 — branch on 1 before 3, and read `--proposals` on both, since it is written whenever the flag is passed and the run completed, whatever the code |
+| 1 | a file was refused, so nothing was written for it and the run carried on. Each reason prints as the literal below. `identity-divergence`, the strip failed its family's oracle — a significant-token mismatch for the c-family; a `shfmt -mn` canonical-form mismatch, a changed shebang or a `bash -n` rejection for shell — and `kept-comment-lost`, an allowlisted comment the strip removed: both are bugs to report rather than rebase steps, with one exception. A JSX comment whose braces sit between two runs of text also refuses with `identity-divergence`, because removing the braces would join the runs into one. That refusal is expected, and the comment needs a hand edit. `non-utf8-bytes`, a file whose bytes do not round-trip UTF-8 (decoding it would rewrite them as U+FFFD, so the codemod never decodes it) — convert or exclude it by hand. `no-grammar`, a path no family claims — declare it in the config or leave it out. `no-identity-oracle`, a family the codemod cannot prove a strip invariant for. `source-changed-since-plan`, a file another writer rewrote between the read that planned the strip and the write — re-run. `source-unreadable-at-flush`, a planned file that could not be re-read before its write — fix the permission or the missing path; re-running alone will not clear it. Where a reason carries more detail the report prints it in parentheses after the name. A refusal outranks pending human work, so a run that also leaves rot survivors or over-cap citations exits 1, not 3 — branch on 1 before 3, and read `--proposals` on both, since it is written whenever the flag is passed and the run completed, whatever the code |
| 2 | the invocation was refused before any work: an argument the parser does not claim (printed as `unrecognized argument(s): <tokens>`, followed by the accepted grammar), including a bare path — name files with `--file <path>` — a value-taking flag other than `--file` passed twice (`repeated argument(s): <flags>`, since the parser resolves one to its first occurrence), a value-taking flag (`--root`, `--file`, `--manifest`, `--proposals`, `--reader-probe`) with no path after it, a `--file` outside `--root`, a `--file` no unit claims, a scope config that does not load (printed as `scope-config: UNREADABLE` with the offending key, or `scope-config: NOT FOUND` on a root that declares none), a precedent registry that does not load (printed as `precedent-registry: UNREADABLE` with the manifest key or the PRECEDENTS.md numbering problem behind it), an absent pinned `shfmt` when a target is shell (printed as `shfmt v<version> is not available` — run `node scripts/provision-shfmt.mjs`; the tree is untouched in both lanes), `--write` with no protected-region net, or `--write` where a target's family has no registered identity oracle — under `--allow-unscoped`, no family at all. Oracle availability is knowable before a byte is read, so it refuses the whole invocation rather than skipping the file. Any other internal error also exits 2; every file is planned and verified before the first is written, so an error while planning leaves the tree untouched, and an error while writing names every file whose rewrite landed; the file that aborted is untouched, because each write is staged beside its target and renamed over it only after the staged bytes are read back and matched |
| 3 | a human still has work, and with `--write` everything writable was written: `rot-in-survivor`, a rot token inside an otherwise legitimate marker, left in place for you to strip by hand and counted in the summary as `rot-refused`; or `citation-over-cap`, a citation comment past the three-line cap, counted as `over-cap`, whose trimmed candidates the `--proposals <path>` channel carries — and nothing was refused; a refusal outranks this and takes the run to 1 with the same records still written. A dry run reaches this code too, having written nothing |
diff --git a/lint-plugins/ok-rules/README.md b/lint-plugins/ok-rules/README.md
index 1b15d606a..4d42626e5 100644
--- a/lint-plugins/ok-rules/README.md
+++ b/lint-plugins/ok-rules/README.md
@@ -10,7 +10,9 @@ One plugin holding every rule is deliberate: oxlint walks the AST once and dispa
**All custom lint enforcement uses oxlint JS-plugin rules** — [PRECEDENTS.md #42](../../PRECEDENTS.md#custom-lint-enforcement-precedent-42). Add a module under `rules/` + a fixture-file test. The fixture-file test is non-negotiable: it preserves the mutation-self-test property by asserting the exact position of every diagnostic, filtered by the rule's own code, on a fixture pairing positive cases with negative cases.
-**Rule modules carry no prose comments.** These are `.mjs` files, so the [no-comments policy](../no-comments/README.md) applies to them — unlike the `.grit` files they replaced, which sat outside it and carried long rationale headers. That rationale lives here instead, in the rule's section below. When you write a rule, budget for writing its README section in the same change; there is nowhere else for the reasoning to go.
+**Rule modules carry no prose comments.** Most are `.mjs` files and a few are `.ts` files, and the [no-comments policy](../no-comments/README.md) applies to both — unlike the `.grit` files they replaced, which sat outside it and carried long rationale headers. That rationale lives here instead, in the rule's section below. When you write a rule, budget for writing its README section in the same change; there is nowhere else for the reasoning to go.
+
+**A rule can be TypeScript.** oxlint loads a `.ts` rule module under the pinned Node, which strips its types, so `index.mjs` imports it by its full `.ts` path. Type it with a type-only import of oxlint's own rule typings, as `no-empty-jsx-expression.ts` does. Its fixture test is then `<rule>.uncached.test.ts`. `pnpm run typecheck:lint-plugins` checks the `.ts` rules and tests with `lint-plugins/ok-rules/tsconfig.json`, and `turbo run typecheck` runs it.
**Diagnostic messages name the fix and link the docs.** Every message has two load-bearing pieces: (a) a noun-phrase or action verb-phrase that names what to do to fix the violation (the fix-noun — readers see this and know the next move without leaving the editor); (b) a trailing `See <docs-URL>` pointing at the rule's section in this README so the message stays self-documenting. Process metadata (decision markers like `D19:`, spec-section refs) does NOT belong in the diagnostic — it rots the same way it rots in source comments. The fixture test asserts both pieces are present (substring match for the fix-noun + URL regex) so the convention survives drift.
@@ -550,7 +552,7 @@ Reading-direction discipline. Chrome layout takes its side from the reading dire
**Scoped** (see the rule's `RULE_SCOPES` entry in [`scope.mjs`](scope.mjs)) to `packages/{app,desktop,plugin}/src/**/*.tsx`. `.tsx` only: the single branch matches a JSX attribute, so a `.ts` glob would be dead scope rather than extra coverage. Exemptions as negative `!`-globs: `!packages/app/src/editor/**` (ProseMirror and CodeMirror own their DOM and take per-string direction from the text rather than from the chrome), `!packages/app/src/components/ui/**` (shadcn primitives are regenerated by `shadcn add`, so an edit there is overwritten on the next pull), and `!**/*.test.tsx` / `!**/*.dom.test.tsx`.
-**Pre-rule backlog (ratchet pattern).** The 81 files that pre-date the rule carry a file-level `// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — …` header, same contract as `no-raw-html-interactive-element`: the comment list across the codebase IS the visible backlog, and review treats each header as a backlog marker rather than a free pass. Drain a file by swapping `ml`/`mr` → `ms`/`me`, `pl`/`pr` → `ps`/`pe`, `left`/`right` → `start`/`end`, then deleting the header — the rule starts firing again immediately, so a partial pass that misses one utility fails the gate. 81 of the 292 chrome files in scope carry a header (148 utilities in total), so the rule is live on the other 211 today.
+**Pre-rule backlog (ratchet pattern).** The 66 files that pre-date the rule carry a file-level `// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — …` header, same contract as `no-raw-html-interactive-element`: the comment list across the codebase IS the visible backlog, and review treats each header as a backlog marker rather than a free pass. Drain a file by swapping `ml`/`mr` → `ms`/`me`, `pl`/`pr` → `ps`/`pe`, `left`/`right` → `start`/`end`, then deleting the header — the rule starts firing again immediately, so a partial pass that misses one utility fails the gate. 66 of the 375 chrome files in scope carry a header (127 utilities in total), so the rule is live on the other 309 today.
The rule does NOT catch:
@@ -728,6 +730,58 @@ Included: `packages/app/src/**/*.ts`, `packages/app/src/**/*.tsx`, `packages/des
Rule: [`no-fixed-palette-color.mjs`](rules/no-fixed-palette-color.mjs). Fixture: [`no-fixed-palette-color.fixture.tsx`](__fixtures__/no-fixed-palette-color.fixture.tsx). Test: [`no-fixed-palette-color.uncached.test.mjs`](tests/no-fixed-palette-color.uncached.test.mjs).
+### `no-empty-jsx-expression`
+
+Flags JSX expression braces in a child position that hold no expression. It has two messages.
+
+**Empty braces.** `{}`, or braces with only whitespace between them, compile to nothing, so they are dead code. They are the shape a comment strip leaves when it removes a JSX comment but not its braces. Delete the braces, and the line when nothing else is on it. Read the JSX text around them first: braces between two runs of text keep those runs apart as separate children, so deleting them can join the text. `one`, `{}` and `two` on three lines render `onetwo`; without the braces they render `one two`.
+
+**Comment braces.** `{/* ... */}` exists only to carry a comment. Put the comment between the element's props, or after its tag name, and delete the braces:
+
+```tsx
+<div
+ // a comment between props
+ className="row"
+>
+<div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- reason
+ onClick={select}
+>
+```
+
+A comment between `<` and the tag name is not an option: TypeScript 7 rejects it (`TS1003`).
+
+Two directives have no other place, so they keep their braces:
+- a single `biome-ignore`. Biome reports at the opening `<`, so a `biome-ignore` between props or after the tag name does not apply.
+- a single `oxlint-disable-next-line` directly before JSX text, or before an element whose first child is JSX text. A rule that reports on the text (`ok/microcopy-ellipsis`) can be suppressed only by a comment on the line above that text.
+
+Any other comment, or a second comment next to a directive, is flagged. The [no-comments rule](../no-comments/README.md) still judges the text of every comment.
+
+Biome and oxlint reject `<div title={} />` as a parse error (`TS17000`), so no lint rule runs on it.
+
+`oxlint.config.ts` ignores `lint-plugins/no-comments/__fixtures__/`, because the no-comments fixtures hold JSX comments and unused directives on purpose.
+
+Unscoped, because any JSX file can carry one.
+
+Rule: [`no-empty-jsx-expression.ts`](rules/no-empty-jsx-expression.ts). Fixture: [`no-empty-jsx-expression.fixture.tsx`](__fixtures__/no-empty-jsx-expression.fixture.tsx). Test: [`no-empty-jsx-expression.uncached.test.ts`](tests/no-empty-jsx-expression.uncached.test.ts).
+
+### `no-redundant-jsx-element-braces`
+
+Pairs with the built-in `react/jsx-curly-brace-presence` rule, which `oxlint.config.ts` enables with `children: "never"` and `props: "never"`. The built-in rule reports braces around a single child element, `<p>{<b>x</b>}</p>`, and string braces such as `{'text'}` and `title={'x'}`. It skips any braces that hold a comment, and this rule covers that case.
+
+This rule flags braces in a child position that hold one element or fragment and at least one comment. The comment can sit before or after the element, between its props, or on a child inside it. A comment strip leaves this shape when the braces held a line comment before the element.
+
+The fix is to delete the braces and write the element as a direct child. A comment that the braces carried goes between the element's props, or after its tag name (`<div // ...`). The compiled output does not change.
+
+The rule does NOT catch:
+- braces whose only comment outside the element is a single `biome-ignore` directive. Biome reports at the opening `<`, so a `biome-ignore` between props or after the tag name does not apply.
+- braces with no comment. The built-in rule reports them.
+- an element as an attribute value (`icon={<Icon />}`), where the braces are needed.
+- an element inside a larger expression (`{ok && <b>x</b>}`, `{ok ? <b>x</b> : null}`).
+
+Unscoped, because any JSX file can carry one.
+
+Rule: [`no-redundant-jsx-element-braces.ts`](rules/no-redundant-jsx-element-braces.ts). Fixture: [`no-redundant-jsx-element-braces.fixture.tsx`](__fixtures__/no-redundant-jsx-element-braces.fixture.tsx). Test: [`no-redundant-jsx-element-braces.uncached.test.ts`](tests/no-redundant-jsx-element-braces.uncached.test.ts).
+
### `no-native-renderer-dialog`
Feedback-surface discipline, from the display guide at [`plugins/ok/skills/feedback-surfaces/SKILL.md`][feedback-surfaces-guide]. Renderer code never opens the browser's native `confirm`, `alert` or `prompt` dialog. The native dialog has no title, no destructive button, no app theme and no focus handling, and its button labels come from the browser, so Lingui cannot translate them. Confirmations use `AlertDialog` from `@/components/ui/alert-dialog`, or `DeleteConfirmationDialog` for a delete.
@@ -803,10 +857,10 @@ Current production suppressions:
| rule | line-level | file-level (backlog) |
| - | - | - |
-| `no-physical-direction-utility` | 4 | 73 |
-| `no-loosely-typed-webcontents-ipc` | 31 | 0 |
-| `no-raw-html-interactive-element` | 0 | 20 |
-| `no-unportaled-editor-content` | 7 | 0 |
+| `no-physical-direction-utility` | 4 | 66 |
+| `no-loosely-typed-webcontents-ipc` | 32 | 0 |
+| `no-raw-html-interactive-element` | 0 | 19 |
+| `no-unportaled-editor-content` | 10 | 0 |
| `require-windowshide-on-spawn` | 6 | 0 |
| `microcopy-ellipsis` | 2 | 0 |
| `no-unwrapped-user-facing-string` | 1 | 0 |
@@ -846,7 +900,7 @@ export const ruleName = {
};
```
-**No prose comments.** Rule modules are `.mjs` and the [no-comments policy](../no-comments/README.md) applies. Rationale goes in this README, in the rule's own section.
+**No prose comments.** Rule modules are `.mjs` or `.ts`, and the [no-comments policy](../no-comments/README.md) applies to both. Rationale goes in this README, in the rule's own section.
**Message shape (load-bearing).** The diagnostic message has three parts in order: (1) the problem statement, (2) the fix-noun naming the action that resolves it, (3) `See <docs-URL>` built by `docsUrl('<rule-name>')` so no message hand-writes the base URL.
@@ -862,7 +916,7 @@ Add a `RULE_SCOPES['<rule-name>']` entry in [`scope.mjs`](scope.mjs): an array o
Scope lives here rather than in `oxlint.config.ts#overrides` because **oxlint's `overrides[].files` does not honour `!` negation** (measured on oxlint 1.66.0: with the rule `off` at root and an override of `files: ['lint-plugins/ok-rules/__fixtures__/**', '!**/*.fixture.tsx']`, the rule still fired on the excluded fixture — the negative glob did not subtract from the positive one. Re-check this on an oxlint upgrade; if negation lands, this whole scope table becomes revisitable) — a negative glob in that list does not subtract from a positive one, so an override-scoped rule silently fires on its exclusions. Biome's `includes` did honour it, which is why the rules this replaced could scope in config.
-**Workspace-wide is a claim about this table, not about oxlint.** A rule with no `RULE_SCOPES` entry is one no entry here narrows; it is not a rule oxlint feeds every file in the repo. Selection happens first and is narrower: `ignorePatterns` in [`oxlint.config.ts`](../../oxlint.config.ts) drops `/reports/**`, `/specs/**`, `.agents/skills/**`, `.codex/skills/**` and the fixtures directory before any rule sees them, and naming one of those files positionally on the command line does not override it (measured on oxlint 1.80.0: `--debug=files` prints nothing for such a file while a control under `packages/` is listed, and `--no-ignore` does not rescue it — that flag governs `.gitignore`, not this list). The pre-push lane is narrower still, since `lint-staged` routes only `packages/**`, `docs/**`, `{scripts,.github/scripts}/**/*.mjs` and root `*.ts` through oxlint.
+**Workspace-wide is a claim about this table, not about oxlint.** A rule with no `RULE_SCOPES` entry is one no entry here narrows; it is not a rule oxlint feeds every file in the repo. Selection happens first and is narrower: `ignorePatterns` in [`oxlint.config.ts`](../../oxlint.config.ts) drops `/reports/**`, `/specs/**`, `.agents/skills/**`, `.codex/skills/**`, `lint-plugins/no-comments/__fixtures__/**` and `lint-plugins/ok-rules/__fixtures__/**` before any rule sees them, and naming one of those files positionally on the command line does not override it (measured on oxlint 1.80.0: `--debug=files` prints nothing for such a file while a control under `packages/` is listed, and `--no-ignore` does not rescue it — that flag governs `.gitignore`, not this list). The pre-push lane is narrower still, since `lint-staged` routes only `packages/**`, `docs/**`, `{scripts,.github/scripts}/**/*.mjs` and root `*.ts` through oxlint.
### 4. Author the fixture file
diff --git a/lint-plugins/ok-rules/__fixtures__/no-empty-jsx-expression.fixture.tsx b/lint-plugins/ok-rules/__fixtures__/no-empty-jsx-expression.fixture.tsx
new file mode 100644
index 000000000..84edb1ea6
--- /dev/null
+++ b/lint-plugins/ok-rules/__fixtures__/no-empty-jsx-expression.fixture.tsx
@@ -0,0 +1,113 @@
+// FIXTURE: drives `no-empty-jsx-expression.uncached.test.ts` via shell-out to
+// oxlint. Not part of the main lint: `__fixtures__/` is in
+// `oxlint.config.ts#ignorePatterns`, and `__fixtures__/oxlint.fixtures.json`
+// re-enables the rules for the test.
+//
+// 6 positive cases (rule MUST fire): 3 empty braces and 3 comment braces.
+// 6 negative cases (rule must NOT fire). The boundary negatives are the two
+// directives with no other place: a single biome-ignore, and a single
+// oxlint-disable-next-line directly before JSX text.
+
+declare const label: string;
+
+// === Positive cases: must fire ===
+
+// (1) Empty braces alone on their line.
+export function PositiveOwnLine() {
+ return (
+ <div>
+ {}
+ <span />
+ </div>
+ );
+}
+
+// (2) Empty braces sharing a line with siblings.
+export function PositiveSharedLine() {
+ return (
+ <p>
+ <b>x</b>{}<i>y</i>
+ </p>
+ );
+}
+
+// (3) Braces holding only whitespace are still empty.
+export function PositiveWhitespaceOnly() {
+ return <div>{ }</div>;
+}
+
+// (4) A prose comment goes between props instead.
+export function PositiveProseComment() {
+ return <div>{/* prose */}</div>;
+}
+
+// (5) An oxlint directive before an element with no text child goes after
+// the tag name instead.
+export function PositiveOxlintBeforeElement() {
+ return (
+ <div>
+ {/* oxlint-disable-next-line ok/no-physical-direction-utility -- fixture */}
+ <section className="pr-6">
+ <span />
+ </section>
+ </div>
+ );
+}
+
+// (6) A directive with a second comment is not a single directive.
+export function PositiveDirectiveAndProse() {
+ return (
+ <div>
+ {/* biome-ignore lint/a11y/useSemanticElements: fixture */ /* and prose */}
+ <div role="group" />
+ </div>
+ );
+}
+
+// === Negative cases: must NOT fire ===
+
+// (7) Boundary: a single biome-ignore keeps its braces.
+export function NegativeBiomeIgnore() {
+ return (
+ <div>
+ {/* biome-ignore lint/a11y/useSemanticElements: a fixture group, not a form */}
+ <div role="group" />
+ </div>
+ );
+}
+
+// (8) Boundary: a single oxlint directive before an element whose first
+// child is text keeps its braces.
+export function NegativeOxlintBeforeTextElement() {
+ return (
+ <p>
+ {/* oxlint-disable-next-line ok/microcopy-ellipsis -- quoting a menu label */}
+ <strong>Open…</strong>
+ </p>
+ );
+}
+
+// (9) Boundary: a single oxlint directive before bare text keeps its braces.
+export function NegativeOxlintBeforeText() {
+ return (
+ <p>
+ {/* oxlint-disable-next-line ok/microcopy-ellipsis -- quoting a menu label */}
+ Open…
+ </p>
+ );
+}
+
+// (10) A real expression.
+export function NegativeExpression() {
+ return <div>{label}</div>;
+}
+
+// (11) An empty object literal in an attribute is an expression, not an empty container.
+export function NegativeEmptyObjectAttribute() {
+ return <div style={{}} />;
+}
+
+// (12) An empty string child is an expression.
+export function NegativeEmptyString() {
+ return <div>{''}</div>;
+}
diff --git a/lint-plugins/ok-rules/__fixtures__/no-redundant-jsx-element-braces.fixture.tsx b/lint-plugins/ok-rules/__fixtures__/no-redundant-jsx-element-braces.fixture.tsx
new file mode 100644
index 000000000..e1007a9b5
--- /dev/null
+++ b/lint-plugins/ok-rules/__fixtures__/no-redundant-jsx-element-braces.fixture.tsx
@@ -0,0 +1,110 @@
+// FIXTURE: drives `no-redundant-jsx-element-braces.uncached.test.ts` via
+// shell-out to oxlint. Not part of the main lint: `__fixtures__/` is in
+// `oxlint.config.ts#ignorePatterns`, and `__fixtures__/oxlint.fixtures.json`
+// re-enables the rules for the test.
+//
+// The custom rule covers what `react/jsx-curly-brace-presence` skips: braces
+// around one child element when the braces hold a comment. 4 positive cases
+// (custom rule MUST fire) and 6 negative cases (custom rule must NOT fire).
+// Negative (6) is the plain shape, which the built-in rule reports instead.
+
+declare const ok: boolean;
+declare function Icon(): null;
+declare function Wrapper(props: { icon: unknown }): null;
+
+// === Positive cases: must fire ===
+
+// (1) A comment between the element's props.
+export function PositivePropComment() {
+ return (
+ <div>
+ {
+ <section
+ // note
+ id="a"
+ >
+ x
+ </section>
+ }
+ </div>
+ );
+}
+
+// (2) A directive on a child inside the element.
+export function PositiveChildDirective() {
+ return (
+ <div>
+ {
+ <section>
+ {/* biome-ignore lint/a11y/useSemanticElements: fixture */}
+ <div role="group" />
+ </section>
+ }
+ </div>
+ );
+}
+
+// (3) A prose comment before the element, inside the braces.
+export function PositiveLeadingProse() {
+ return (
+ <div>
+ {
+ // prose
+ <b>x</b>
+ }
+ </div>
+ );
+}
+
+// (4) A trailing block comment after the element.
+export function PositiveTrailingComment() {
+ return <div>{<b>x</b> /* trailing */}</div>;
+}
+
+// === Negative cases: must NOT fire ===
+
+// (5) Boundary: a lone biome-ignore before the element is the one comment
+// the braces may carry.
+export function NegativeLeadingDirective() {
+ return (
+ <div>
+ {
+ // biome-ignore lint/a11y/useSemanticElements: fixture
+ <div role="group" />
+ }
+ </div>
+ );
+}
+
+// (6) Boundary: no comment at all. `react/jsx-curly-brace-presence` reports it.
+export function NegativePlain() {
+ return <p>{<b>x</b>}</p>;
+}
+
+// (7) An element as an attribute value needs the braces.
+export function NegativeAttribute() {
+ return <Wrapper icon={<Icon />} />;
+}
+
+// (8) A conditional is an expression, not a lone element.
+export function NegativeConditional() {
+ return <div>{ok ? <b>x</b> : null}</div>;
+}
+
+// (9) A logical expression is an expression, not a lone element.
+export function NegativeLogical() {
+ return <div>{ok && <b>x</b>}</div>;
+}
+
+// (10) A fragment with no comment is the built-in rule's case too.
+export function NegativePlainFragment() {
+ return (
+ <div>
+ {
+ <>
+ <Icon />
+ </>
+ }
+ </div>
+ );
+}
diff --git a/lint-plugins/ok-rules/__fixtures__/oxlint.fixtures.json b/lint-plugins/ok-rules/__fixtures__/oxlint.fixtures.json
index 93f417b25..b3cacdebc 100644
--- a/lint-plugins/ok-rules/__fixtures__/oxlint.fixtures.json
+++ b/lint-plugins/ok-rules/__fixtures__/oxlint.fixtures.json
@@ -1,6 +1,11 @@
{
+ "plugins": ["unicorn", "typescript", "oxc", "react"],
"jsPlugins": ["../index.mjs"],
"rules": {
+ "react/jsx-curly-brace-presence": [
+ "error",
+ { "children": "never", "props": "never", "propElementValues": "ignore" }
+ ],
"ok/class-proof-registration-discipline": "error",
"ok/cst-pm-handler-todo-stub": "error",
"ok/microcopy-ellipsis": "error",
@@ -9,6 +14,7 @@
"ok/no-blocking-error-box": "error",
"ok/no-custom-toast": "error",
"ok/no-demoted-dialog-confirm": "error",
+ "ok/no-empty-jsx-expression": "error",
"ok/no-fixed-palette-color": "error",
"ok/no-hand-rolled-branch-validation": "error",
"ok/no-hand-rolled-test-file-suffix": "error",
@@ -20,6 +26,7 @@
"ok/no-raw-error-toast": "error",
"ok/no-raw-html-interactive-element": "error",
"ok/no-raw-route-hash-construction": "error",
+ "ok/no-redundant-jsx-element-braces": "error",
"ok/no-resolved-value-theme-source": "error",
"ok/no-roundtrip-identity-oracle": "error",
"ok/no-sentinel-signal-target": "error",
diff --git a/lint-plugins/ok-rules/index.mjs b/lint-plugins/ok-rules/index.mjs
index 0e6d8a47a..8f83aae6e 100644
--- a/lint-plugins/ok-rules/index.mjs
+++ b/lint-plugins/ok-rules/index.mjs
@@ -8,6 +8,7 @@ import { noBlindAgentHostFanout } from './rules/no-blind-agent-host-fanout.mjs';
import { noBlockingErrorBox } from './rules/no-blocking-error-box.mjs';
import { noCustomToast } from './rules/no-custom-toast.mjs';
import { noDemotedDialogConfirm } from './rules/no-demoted-dialog-confirm.mjs';
+import { noEmptyJsxExpression } from './rules/no-empty-jsx-expression.ts';
import { noFixedPaletteColor } from './rules/no-fixed-palette-color.mjs';
import { noHandRolledBranchValidation } from './rules/no-hand-rolled-branch-validation.mjs';
import { noHandRolledSpinner } from './rules/no-hand-rolled-spinner.mjs';
@@ -19,6 +20,7 @@ import { noPhysicalDirectionUtility } from './rules/no-physical-direction-utilit
import { noRawErrorToast } from './rules/no-raw-error-toast.mjs';
import { noRawHtmlInteractiveElement } from './rules/no-raw-html-interactive-element.mjs';
import { noRawRouteHashConstruction } from './rules/no-raw-route-hash-construction.mjs';
+import { noRedundantJsxElementBraces } from './rules/no-redundant-jsx-element-braces.ts';
import { noResolvedValueThemeSource } from './rules/no-resolved-value-theme-source.mjs';
import { noRoundtripIdentityOracle } from './rules/no-roundtrip-identity-oracle.mjs';
import { noSentinelSignalTarget } from './rules/no-sentinel-signal-target.mjs';
@@ -47,6 +49,7 @@ const declared = {
'no-blocking-error-box': noBlockingErrorBox,
'no-custom-toast': noCustomToast,
'no-demoted-dialog-confirm': noDemotedDialogConfirm,
+ 'no-empty-jsx-expression': noEmptyJsxExpression,
'no-fixed-palette-color': noFixedPaletteColor,
'no-hand-rolled-branch-validation': noHandRolledBranchValidation,
'no-hand-rolled-test-file-suffix': noHandRolledTestFileSuffix,
@@ -58,6 +61,7 @@ const declared = {
'no-raw-error-toast': noRawErrorToast,
'no-raw-html-interactive-element': noRawHtmlInteractiveElement,
'no-raw-route-hash-construction': noRawRouteHashConstruction,
+ 'no-redundant-jsx-element-braces': noRedundantJsxElementBraces,
'no-resolved-value-theme-source': noResolvedValueThemeSource,
'no-roundtrip-identity-oracle': noRoundtripIdentityOracle,
'no-sentinel-signal-target': noSentinelSignalTarget,
diff --git a/lint-plugins/ok-rules/rules/no-empty-jsx-expression.ts b/lint-plugins/ok-rules/rules/no-empty-jsx-expression.ts
new file mode 100644
index 000000000..ff719713f
--- /dev/null
+++ b/lint-plugins/ok-rules/rules/no-empty-jsx-expression.ts
@@ -0,0 +1,70 @@
+import type { RuleTester } from 'oxlint/plugins-dev';
+// @ts-expect-error untyped ESM lint-plugin module
+import { docsUrl } from '../docs.mjs';
+
+type Rule = Parameters<RuleTester['run']>[1];
+
+const URL: string = docsUrl('no-empty-jsx-expression');
+
+const EMPTY_MESSAGE = `Empty JSX expression \`{}\` renders nothing. Delete the braces, and the line when nothing else is on it. See ${URL}`;
+
+const COMMENT_MESSAGE = `JSX expression braces that hold only a comment are not allowed. Put the comment between an element's props, or after its tag name (\`<div // ...\`), and delete the braces. The braces may hold a single biome-ignore directive, or a single oxlint-disable-next-line directly before JSX text. See ${URL}`;
+
+type JsxChild =
+ | { type: 'JSXText'; value: string }
+ | { type: 'JSXElement' | 'JSXFragment'; children: readonly JsxChild[] }
+ | { type: 'JSXExpressionContainer' | 'JSXSpreadChild' };
+
+function isBlankText(child: JsxChild): boolean {
+ return child.type === 'JSXText' && !child.value.trim();
+}
+
+function firstNonBlank(children: readonly JsxChild[]): JsxChild | undefined {
+ return children.find((child) => !isBlankText(child));
+}
+
+function textFollows(siblings: readonly JsxChild[], index: number): boolean {
+ const next = firstNonBlank(siblings.slice(index + 1));
+ if (next === undefined) return false;
+ if (next.type === 'JSXText') return true;
+ if (next.type !== 'JSXElement' && next.type !== 'JSXFragment') return false;
+ return firstNonBlank(next.children)?.type === 'JSXText';
+}
+
+export const noEmptyJsxExpression: Rule = {
+ meta: {
+ type: 'problem',
+ docs: {
+ description:
+ 'JSX expression braces hold an expression or a single lint directive that has no other place, never nothing and never another comment.',
+ url: URL,
+ },
+ },
+ create(context) {
+ const source = context.sourceCode;
+ return {
+ JSXExpressionContainer(node) {
+ if (node.expression.type !== 'JSXEmptyExpression') return;
+ const parent = node.parent;
+ if (parent.type !== 'JSXElement' && parent.type !== 'JSXFragment') return;
+ const comments = source.getCommentsInside(node);
+ if (comments.length === 0) {
+ context.report({ node, message: EMPTY_MESSAGE });
+ return;
+ }
+ if (comments.length === 1) {
+ const directive = comments[0].value.trim();
+ if (directive.startsWith('biome-ignore')) return;
+ const siblings: readonly JsxChild[] = parent.children;
+ if (
+ directive.startsWith('oxlint-disable-next-line') &&
+ textFollows(siblings, siblings.indexOf(node))
+ ) {
+ return;
+ }
+ }
+ context.report({ node, message: COMMENT_MESSAGE });
+ },
+ };
+ },
+};
diff --git a/lint-plugins/ok-rules/rules/no-redundant-jsx-element-braces.ts b/lint-plugins/ok-rules/rules/no-redundant-jsx-element-braces.ts
new file mode 100644
index 000000000..b8dd8b400
--- /dev/null
+++ b/lint-plugins/ok-rules/rules/no-redundant-jsx-element-braces.ts
@@ -0,0 +1,37 @@
+import type { RuleTester } from 'oxlint/plugins-dev';
+// @ts-expect-error untyped ESM lint-plugin module
+import { docsUrl } from '../docs.mjs';
+
+type Rule = Parameters<RuleTester['run']>[1];
+
+const URL: string = docsUrl('no-redundant-jsx-element-braces');
+
+const MESSAGE = `JSX expression braces around a single element do nothing, and a comment does not need them. Delete the braces, and put the comment between the element's props, or after its tag name (\`<div // ...\`). See ${URL}`;
+
+const ELEMENT_TYPES = new Set(['JSXElement', 'JSXFragment']);
+
+export const noRedundantJsxElementBraces: Rule = {
+ meta: {
+ type: 'problem',
+ docs: {
+ description:
+ 'A JSX child element is written bare, not wrapped in expression braces that carry a comment.',
+ url: URL,
+ },
+ },
+ create(context) {
+ const source = context.sourceCode;
+ return {
+ JSXExpressionContainer(node) {
+ if (!ELEMENT_TYPES.has(node.parent.type) || !ELEMENT_TYPES.has(node.expression.type))
+ return;
+ const comments = source.getCommentsInside(node);
+ if (comments.length === 0) return;
+ const { start, end } = node.expression;
+ const outside = comments.filter((comment) => comment.end <= start || comment.start >= end);
+ if (outside.length === 1 && outside[0].value.trim().startsWith('biome-ignore')) return;
+ context.report({ node, message: MESSAGE });
+ },
+ };
+ },
+};
diff --git a/lint-plugins/ok-rules/scope.mjs b/lint-plugins/ok-rules/scope.mjs
index ddcbfde07..edb3e8b54 100644
--- a/lint-plugins/ok-rules/scope.mjs
+++ b/lint-plugins/ok-rules/scope.mjs
@@ -15,8 +15,10 @@ function matches(glob, path) {
export const UNSCOPED_RULES = new Set([
'microcopy-ellipsis',
+ 'no-empty-jsx-expression',
'no-hand-rolled-spinner',
'no-loosely-typed-webcontents-ipc',
+ 'no-redundant-jsx-element-braces',
'no-resolved-value-theme-source',
'no-sentinel-signal-target',
'no-split-suggestion-dispatch',
diff --git a/lint-plugins/ok-rules/tests/no-empty-jsx-expression.uncached.test.ts b/lint-plugins/ok-rules/tests/no-empty-jsx-expression.uncached.test.ts
new file mode 100644
index 000000000..d485229de
--- /dev/null
+++ b/lint-plugins/ok-rules/tests/no-empty-jsx-expression.uncached.test.ts
@@ -0,0 +1,44 @@
+import { fileURLToPath } from 'node:url';
+import { describe, expect, test } from 'vitest';
+import {
+ lintOkRulesFixture,
+ readEnabledRuleIds,
+ readRegisteredRuleNames,
+} from '../../../test-support/read-ok-rules-config.test-helper.ts';
+import fixtureUrl from '../__fixtures__/no-empty-jsx-expression.fixture.tsx?url';
+
+const REPO_ROOT = fileURLToPath(new URL('../../..', import.meta.url));
+const RULE = 'no-empty-jsx-expression';
+const CODE = `ok(${RULE})`;
+const FIXTURE = fixtureUrl.replace(/^\//, '');
+const DOCS = `lint-plugins/ok-rules/README.md#${RULE}`;
+
+describe(`${RULE} oxlint rule`, () => {
+ test('fires at exactly its 3 empty braces, with the delete message', () => {
+ const fires = lintOkRulesFixture(FIXTURE).filter(
+ (d) => d.code === CODE && d.message.startsWith('Empty JSX expression'),
+ );
+ expect(fires.map((fire) => fire.position)).toEqual(['19:7', '29:15', '36:15']);
+ for (const fire of fires) {
+ expect(fire.message).toContain('Delete the braces');
+ expect(fire.message).toContain(DOCS);
+ }
+ });
+
+ test('fires at exactly its 3 comment braces, and on no single directive that has no other place', () => {
+ const fires = lintOkRulesFixture(FIXTURE).filter(
+ (d) => d.code === CODE && !d.message.startsWith('Empty JSX expression'),
+ );
+ expect(fires.map((fire) => fire.position)).toEqual(['41:15', '49:7', '61:7']);
+ for (const fire of fires) {
+ expect(fire.message).toContain('between an element');
+ expect(fire.message).toMatch(/https?:\/\/[^\s]+/);
+ expect(fire.message).toContain(DOCS);
+ }
+ });
+
+ test('rule is registered, enabled, and deliberately unscoped', async () => {
+ expect(await readRegisteredRuleNames(REPO_ROOT)).toContain(RULE);
+ expect(await readEnabledRuleIds(REPO_ROOT)).toContain(`ok/${RULE}`);
+ });
+});
diff --git a/lint-plugins/ok-rules/tests/no-redundant-jsx-element-braces.uncached.test.ts b/lint-plugins/ok-rules/tests/no-redundant-jsx-element-braces.uncached.test.ts
new file mode 100644
index 000000000..5deba605e
--- /dev/null
+++ b/lint-plugins/ok-rules/tests/no-redundant-jsx-element-braces.uncached.test.ts
@@ -0,0 +1,37 @@
+import { fileURLToPath } from 'node:url';
+import { describe, expect, test } from 'vitest';
+import {
+ lintOkRulesFixture,
+ readEnabledRuleIds,
+ readRegisteredRuleNames,
+} from '../../../test-support/read-ok-rules-config.test-helper.ts';
+import fixtureUrl from '../__fixtures__/no-redundant-jsx-element-braces.fixture.tsx?url';
+
+const REPO_ROOT = fileURLToPath(new URL('../../..', import.meta.url));
+const RULE = 'no-redundant-jsx-element-braces';
+const CODE = `ok(${RULE})`;
+const BUILT_IN = 'react(jsx-curly-brace-presence)';
+const FIXTURE = fixtureUrl.replace(/^\//, '');
+const DOCS = `lint-plugins/ok-rules/README.md#${RULE}`;
+
+describe(`${RULE} oxlint rule`, () => {
+ test('fires at exactly its 4 lone-element braces that carry a comment, and on no other braces', () => {
+ const fires = lintOkRulesFixture(FIXTURE).filter((d) => d.code === CODE);
+ expect(fires.map((fire) => fire.position)).toEqual(['21:7', '37:7', '51:7', '61:15']);
+ for (const fire of fires) {
+ expect(fire.message).toContain('Delete the braces');
+ expect(fire.message).toMatch(/https?:\/\/[^\s]+/);
+ expect(fire.message).toContain(DOCS);
+ }
+ });
+
+ test('the built-in rule reports the comment-free lone elements that this rule leaves to it', () => {
+ const fires = lintOkRulesFixture(FIXTURE).filter((d) => d.code === BUILT_IN);
+ expect(fires.map((fire) => fire.position)).toEqual(['81:14', '104:9']);
+ });
+
+ test('rule is registered, enabled, and deliberately unscoped', async () => {
+ expect(await readRegisteredRuleNames(REPO_ROOT)).toContain(RULE);
+ expect(await readEnabledRuleIds(REPO_ROOT)).toContain(`ok/${RULE}`);
+ });
+});
diff --git a/lint-plugins/ok-rules/tests/ok-rules-scope-partition.uncached.test.mjs b/lint-plugins/ok-rules/tests/ok-rules-scope-partition.uncached.test.mjs
index b86908a74..3961adf64 100644
--- a/lint-plugins/ok-rules/tests/ok-rules-scope-partition.uncached.test.mjs
+++ b/lint-plugins/ok-rules/tests/ok-rules-scope-partition.uncached.test.mjs
@@ -16,7 +16,7 @@ const REPO_ROOT = fileURLToPath(new URL('../../..', import.meta.url));
const TESTS_DIR = join(REPO_ROOT, OK_RULES_TESTS_DIR);
const FIXTURES_DIR = join(REPO_ROOT, OK_RULES_FIXTURES_DIR);
const FIXTURE_CONFIG = join(FIXTURES_DIR, 'oxlint.fixtures.json');
-const TIER_TEST = /\.uncached\.test\.mjs$/;
+const TIER_TEST = /\.uncached\.test\.(?:mjs|ts)$/;
const CODE_FILE = /\.[cm]?[jt]sx?$/;
const META_TESTS = ['ok-rules-scope-partition', 'ok-rules-vocabulary'];
@@ -39,8 +39,10 @@ describe('ok-rules scope table', () => {
test('UNSCOPED_RULES holds exactly the rules that are deliberately global', () => {
expect([...UNSCOPED_RULES].sort()).toEqual([
'microcopy-ellipsis',
+ 'no-empty-jsx-expression',
'no-hand-rolled-spinner',
'no-loosely-typed-webcontents-ipc',
+ 'no-redundant-jsx-element-braces',
'no-resolved-value-theme-source',
'no-sentinel-signal-target',
'no-split-suggestion-dispatch',
@@ -163,7 +165,7 @@ describe('ok-rules fixture tests', () => {
);
expect(
misplaced,
- 'a fixture test here is named <rule>.uncached.test.mjs, so the uncached tier runs it',
+ 'a fixture test here is named <rule>.uncached.test.mjs or <rule>.uncached.test.ts, so the uncached tier runs it',
).toEqual([]);
});
@@ -171,7 +173,7 @@ describe('ok-rules fixture tests', () => {
const stems = new Set(publicTestStems());
expect(
registered.filter((rule) => !stems.has(rule)),
- 'a rule ships with lint-plugins/ok-rules/tests/<rule>.uncached.test.mjs (precedent #42)',
+ 'a rule ships with lint-plugins/ok-rules/tests/<rule>.uncached.test.mjs or .uncached.test.ts (precedent #42)',
).toEqual([]);
});
diff --git a/lint-plugins/ok-rules/tsconfig.json b/lint-plugins/ok-rules/tsconfig.json
new file mode 100644
index 000000000..1acf1d582
--- /dev/null
+++ b/lint-plugins/ok-rules/tsconfig.json
@@ -0,0 +1,9 @@
+{
+ "extends": "../../tsconfig.json",
+ "compilerOptions": {
+ "noEmit": true,
+ "types": ["node"],
+ "allowImportingTsExtensions": true
+ },
+ "include": ["**/*.ts"]
+}
diff --git a/lint-plugins/ok-rules/vite-url-import.d.ts b/lint-plugins/ok-rules/vite-url-import.d.ts
new file mode 100644
index 000000000..fdf37311c
--- /dev/null
+++ b/lint-plugins/ok-rules/vite-url-import.d.ts
@@ -0,0 +1,4 @@
+declare module '*?url' {
+ const url: string;
+ export default url;
+}
diff --git a/no-comments.config.jsonc b/no-comments.config.jsonc
index 9a3684275..84d5968dd 100644
--- a/no-comments.config.jsonc
+++ b/no-comments.config.jsonc
@@ -22,7 +22,8 @@
{ "id": "github-scripts", "family": "esm-script", "roots": [".github/scripts"] },
{ "id": "docs", "family": "typescript-multi-suffix", "roots": ["docs"] },
{ "id": "root-configs", "family": "typescript-config", "roots": ["."] },
- { "id": "lint-plugins", "family": "esm-script", "roots": ["lint-plugins"] },
+ { "id": "lint-plugins", "family": "typescript", "roots": ["lint-plugins"] },
+ { "id": "lint-plugins-esm", "family": "esm-script", "roots": ["lint-plugins"] },
{ "id": "plugins", "family": "esm-script", "roots": ["plugins"] },
{
"id": "app-catalog-compiler",
diff --git a/oxlint.config.ts b/oxlint.config.ts
index 8dfc1f8ae..c11b5d2c7 100644
--- a/oxlint.config.ts
+++ b/oxlint.config.ts
@@ -38,11 +38,14 @@ export default defineConfig({
'.codex/skills/**',
'/reports/**',
'/specs/**',
+ 'lint-plugins/no-comments/__fixtures__/**',
'lint-plugins/ok-rules/__fixtures__/**',
],
options: {
+ reportUnusedDisableDirectives: 'error',
typeAware: true,
},
+ plugins: ['unicorn', 'typescript', 'oxc', 'react', 'jsx-a11y'],
jsPlugins: [
{ name: 'eslint-js', specifier: 'oxlint-plugin-eslint' },
NO_COMMENTS_PLUGIN,
@@ -57,6 +60,7 @@ export default defineConfig({
'ok/no-blocking-error-box': 'error',
'ok/no-custom-toast': 'error',
'ok/no-demoted-dialog-confirm': 'error',
+ 'ok/no-empty-jsx-expression': 'error',
'ok/no-fixed-palette-color': 'error',
'ok/no-hand-rolled-branch-validation': 'error',
'ok/no-hand-rolled-test-file-suffix': 'error',
@@ -68,6 +72,7 @@ export default defineConfig({
'ok/no-raw-error-toast': 'error',
'ok/no-raw-html-interactive-element': 'error',
'ok/no-raw-route-hash-construction': 'error',
+ 'ok/no-redundant-jsx-element-braces': 'error',
'ok/no-resolved-value-theme-source': 'error',
'ok/no-roundtrip-identity-oracle': 'error',
'ok/no-sentinel-signal-target': 'error',
@@ -90,6 +95,10 @@ export default defineConfig({
},
],
'eslint-js/no-restricted-syntax': ['error', ...restrictedSyntax],
+ 'react/jsx-curly-brace-presence': [
+ 'error',
+ { children: 'never', props: 'never', propElementValues: 'ignore' },
+ ],
'no-restricted-imports': [
'error',
{
@@ -131,6 +140,56 @@ export default defineConfig({
'oxc/erasing-op': 'off',
'typescript/no-useless-default-assignment': 'off',
'typescript/prefer-as-const': 'off',
+ 'react/set-state-in-effect': 'off',
+ 'react-hooks/exhaustive-deps': 'off',
+ 'react/refs': 'off',
+ 'react/globals': 'off',
+ 'react/static-components': 'off',
+ 'react/immutability': 'off',
+ 'jsx-a11y/anchor-ambiguous-text': 'error',
+ 'jsx-a11y/anchor-is-valid': 'error',
+ 'jsx-a11y/click-events-have-key-events': 'error',
+ 'jsx-a11y/no-noninteractive-tabindex': 'error',
+ 'jsx-a11y/no-static-element-interactions': [
+ 'error',
+ {
+ handlers: [
+ 'onBlur',
+ 'onClick',
+ 'onContextMenu',
+ 'onDblClick',
+ 'onDoubleClick',
+ 'onDrag',
+ 'onDragEnd',
+ 'onDragEnter',
+ 'onDragExit',
+ 'onDragLeave',
+ 'onDragOver',
+ 'onDragStart',
+ 'onDrop',
+ 'onFocus',
+ 'onKeyDown',
+ 'onKeyPress',
+ 'onKeyUp',
+ 'onMouseDown',
+ 'onMouseEnter',
+ 'onMouseLeave',
+ 'onMouseMove',
+ 'onMouseOut',
+ 'onMouseOver',
+ 'onMouseUp',
+ ],
+ },
+ ],
+ 'react/no-danger': 'error',
+ 'jsx-a11y/prefer-tag-over-role': 'off',
+ 'jsx-a11y/no-autofocus': 'off',
+ 'jsx-a11y/no-noninteractive-element-interactions': 'off',
+ 'jsx-a11y/interactive-supports-focus': 'off',
+ 'jsx-a11y/media-has-caption': 'off',
+ 'jsx-a11y/control-has-associated-label': 'off',
+ 'jsx-a11y/role-has-required-aria-props': 'off',
+ 'jsx-a11y/heading-has-content': 'off',
},
overrides: [
{
diff --git a/package.json b/package.json
index c830210ca..2737d70b7 100644
--- a/package.json
+++ b/package.json
@@ -53,6 +53,7 @@
"changeset": "changeset",
"version": "changeset version",
"release": "changeset publish",
+ "typecheck:lint-plugins": "tsc --noEmit -p lint-plugins/ok-rules/tsconfig.json",
"typecheck:no-net-connect": "tsc --noEmit -p test-support/tsconfig.no-net-connect.json"
},
"lint-staged": {
diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx
index f570f6e51..ef4de39a7 100644
--- a/packages/app/src/App.tsx
+++ b/packages/app/src/App.tsx
@@ -626,33 +626,24 @@ function AppBody() {
<BranchRecycleBanner />
<PageListProvider>
<NoteWindowMainActionReceiver />
- {}
{!noteWindow && <SystemDocSubscriber />}
<ValidationFreshness />
- {}
<SkillTrackInGitDialog />
<NavigationHandler />
<ActiveTargetBridgePush />
<NewItemShortcutHandler />
- {}
{!singleFile && !noteWindow && <SettingsShortcutHandler />}
{SHOW_INSTALL_SKILL && <InstallInClaudeDesktopTrigger />}
- {}
{desktopBridge ? <CreateProjectMenuTrigger bridge={desktopBridge} /> : null}
- {}
{desktopBridge ? <ReportBugMenuTrigger /> : null}
- {}
{desktopBridge ? <FeedbackMenuTrigger /> : null}
- {}
<McpConsentDialog />
- {}
{desktopBridge ? (
<Suspense fallback={null}>
<ShareBranchSwitchDialog bridge={desktopBridge} />
<ShareReceiveMissDialog />
</Suspense>
) : null}
- {}
{!noteWindow && (
<CommandPalette
bridge={desktopBridge}
@@ -660,7 +651,6 @@ function AppBody() {
onOpenChange={setCommandPaletteOpen}
/>
)}
- {}
{isElectronHost && !showAppHeader && (
<div
aria-hidden="true"
@@ -669,9 +659,7 @@ function AppBody() {
className="pointer-events-none fixed inset-x-0 top-0 z-50 h-2 [-webkit-app-region:drag]"
/>
)}
- {}
<TerminalLaunchProvider value={terminalLaunch}>
- {}
<CommentQueueShortcut />
{showAppHeader && <AppHeader onOpenSearch={() => setCommandPaletteOpen(true)} />}
<SidebarProvider className="h-[calc(100vh-var(--ok-app-header-height,0px))] min-h-[calc(100svh-var(--ok-app-header-height,0px))]">
diff --git a/packages/app/src/comments/CommentBubbleButton.tsx b/packages/app/src/comments/CommentBubbleButton.tsx
index f3f234ec7..b6f505055 100644
--- a/packages/app/src/comments/CommentBubbleButton.tsx
+++ b/packages/app/src/comments/CommentBubbleButton.tsx
@@ -12,7 +12,6 @@ export function CommentBubbleButton() {
return (
<>
<Separator orientation="vertical" className="mx-0.5 h-5 data-vertical:self-center" />
- {}
<Tooltip>
<TooltipTrigger asChild>
<Button
diff --git a/packages/app/src/comments/CommentListPanel.tsx b/packages/app/src/comments/CommentListPanel.tsx
index 9ac63d91f..557923942 100644
--- a/packages/app/src/comments/CommentListPanel.tsx
+++ b/packages/app/src/comments/CommentListPanel.tsx
@@ -178,7 +178,6 @@ export function CommentListPanel({
</PanelTitle>
<PanelCount>{active.length}</PanelCount>
</div>
- {}
<div className="flex items-center gap-1">
{resolved.length > 0 && (
<Tooltip>
@@ -196,7 +195,6 @@ export function CommentListPanel({
data-testid={`${testIdPrefix}-resolved-toggle`}
onClick={() => setShowResolved((v) => !v)}
>
- {}
{showResolved ? (
<CircleDot aria-hidden="true" className="size-3.5" />
) : (
@@ -207,13 +205,11 @@ export function CommentListPanel({
</span>
</Button>
</TooltipTrigger>
- {}
<TooltipContent>
{showResolved ? <Trans>Hide resolved</Trans> : <Trans>Show resolved</Trans>}
</TooltipContent>
</Tooltip>
)}
- {}
{groups.length > 1 && (
<Tooltip>
<TooltipTrigger asChild>
@@ -242,7 +238,6 @@ export function CommentListPanel({
</div>
</PanelHeader>
{scopeSwitch}
- {}
<PanelBody className={groupByDocument ? 'flex flex-col gap-3' : 'flex flex-col gap-0'}>
{visible.length === 0 ? (
<PanelEmpty>{empty}</PanelEmpty>
@@ -261,7 +256,6 @@ export function CommentListPanel({
onOpenChange={(open) => toggleFile(group.docName, open)}
className="group/file-card flex flex-col"
>
- {}
<div className="group/file flex items-center gap-2 border-b px-3 py-2.5 group-data-[state=closed]/file-card:border-b-0">
<span className="relative size-4 shrink-0">
{tick === false && (
@@ -312,7 +306,6 @@ export function CommentListPanel({
visible.map(card)
)}
</PanelBody>
- {}
{active.length > 0 && (
<CommentSendFooter
threadIds={scopedSending}
diff --git a/packages/app/src/comments/CommentSelectionAffordance.tsx b/packages/app/src/comments/CommentSelectionAffordance.tsx
index c14a5fd89..1ac120109 100644
--- a/packages/app/src/comments/CommentSelectionAffordance.tsx
+++ b/packages/app/src/comments/CommentSelectionAffordance.tsx
@@ -186,8 +186,6 @@ export function CommentSelectionAffordance({
style={{ position: 'fixed', top: 0, left: 0 }}
data-testid="comment-composer"
>
- {}
- {}
<ComposerMentionInput
ref={inputRef}
ariaLabel={t`Add a comment`}
@@ -199,15 +197,12 @@ export function CommentSelectionAffordance({
onEscape={reset}
className="max-h-40 min-h-16 overflow-y-auto rounded-md border px-2 py-1 text-sm subtle-scrollbar"
/>
- {}
- {}
<div
className={cn(
'flex items-center gap-1.5',
commentsOnScreen ? 'justify-end' : 'justify-between',
)}
>
- {}
{commentsOnScreen ? null : (
<Button
size="sm"
diff --git a/packages/app/src/comments/CommentSendFooter.tsx b/packages/app/src/comments/CommentSendFooter.tsx
index 90c12e63d..3e7398982 100644
--- a/packages/app/src/comments/CommentSendFooter.tsx
+++ b/packages/app/src/comments/CommentSendFooter.tsx
@@ -47,7 +47,6 @@ export function CommentSendFooter({
return (
<PanelFooter className="px-3 py-2">
- {}
<div className="flex w-full min-w-0 flex-wrap items-center gap-2">
<div className="flex min-w-max flex-1 items-center justify-between gap-2">
<label
@@ -82,8 +81,6 @@ export function CommentSendFooter({
primary={
<>
{destinationIcon}
- {}
- {}
<span className="truncate">
{openSession !== null ? (
<Trans>Send to chat</Trans>
diff --git a/packages/app/src/comments/PropertyCommentButton.tsx b/packages/app/src/comments/PropertyCommentButton.tsx
index dd38d362d..7d8f3cea9 100644
--- a/packages/app/src/comments/PropertyCommentButton.tsx
+++ b/packages/app/src/comments/PropertyCommentButton.tsx
@@ -66,7 +66,6 @@ export function PropertyCommentButton({
</Button>
</PopoverTrigger>
<PopoverContent align="end" className="flex w-80 flex-col gap-2 p-3">
- {}
{quote === null ? (
<p className="truncate text-[11px] text-muted-foreground">
<Trans>
diff --git a/packages/app/src/comments/ThreadCard.tsx b/packages/app/src/comments/ThreadCard.tsx
index 392c1ad74..2da03d0b9 100644
--- a/packages/app/src/comments/ThreadCard.tsx
+++ b/packages/app/src/comments/ThreadCard.tsx
@@ -1,5 +1,3 @@
-// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
-
import { Trans, useLingui } from '@lingui/react/macro';
import { CheckCheck, MapPin, Pencil, RotateCcw, Trash2 } from 'lucide-react';
import { useEffect, useRef, useState } from 'react';
@@ -184,7 +182,7 @@ export function ThreadCard({
const cardSelects = !editing && !isResolved;
return (
- // biome-ignore lint/a11y/useKeyWithClickEvents: pointer-only affordance — clicking the card's whitespace solos its tick; keyboard/AT users compose the same state from the real controls (the card's checkbox + the footer's master tick). See focus-composer-on-card-pointer.ts for the sibling pattern.
+ // oxlint-disable-next-line jsx-a11y/click-events-have-key-events -- pointer-only affordance — clicking the card's whitespace solos its tick; keyboard/AT users compose the same state from the real controls (the card's checkbox + the footer's master tick). See focus-composer-on-card-pointer.ts for the sibling pattern.
<article
ref={cardRef}
onPointerEnter={() => setActiveThread(thread.id)}
@@ -223,10 +221,8 @@ export function ThreadCard({
: 'ring-2 ring-primary'),
)}
>
- {}
<div className="flex items-center justify-between gap-2">
<div className="flex min-w-0 items-center gap-2">
- {}
{!isResolved && (
<Checkbox
checked={sending}
@@ -237,7 +233,6 @@ export function ThreadCard({
{isResolved && (
<CheckCheck aria-hidden="true" className="size-4 shrink-0 text-muted-foreground" />
)}
- {}
<span
className="shrink-0 text-xs text-muted-foreground"
title={new Date(thread.updatedAt).toLocaleString()}
@@ -291,7 +286,6 @@ export function ThreadCard({
</TooltipContent>
</Tooltip>
)}
- {}
<Tooltip>
<TooltipTrigger asChild>
<Button
@@ -312,7 +306,6 @@ export function ThreadCard({
</div>
</div>
- {}
{isOrphaned ? (
<div className="flex flex-col gap-2">
{thread.anchor !== null && (
@@ -320,13 +313,12 @@ export function ThreadCard({
className="truncate text-sm text-muted-foreground line-through border-l-2 border-l-muted-foreground/40 px-2 py-0.5"
title={thread.anchor.quote}
>
- {}“{thread.anchor.quote}”
+ “{thread.anchor.quote}”
</p>
)}
</div>
) : (
<Tooltip>
- {}
<TooltipTrigger asChild>
<span className="w-full">
<Button
@@ -361,7 +353,6 @@ export function ThreadCard({
</Tooltip>
)}
- {}
{editing ? (
<div className="flex flex-col gap-1.5">
<ComposerMentionInput
@@ -378,7 +369,6 @@ export function ThreadCard({
onEscape={cancelEdit}
className="max-h-40 overflow-y-auto rounded-md border px-2 py-1 text-sm subtle-scrollbar bg-background"
/>
- {}
<div className="flex items-center justify-end gap-1.5">
<Button size="sm" variant="ghost-mono" onClick={cancelEdit}>
<Trans>Cancel</Trans>
@@ -402,7 +392,6 @@ export function ThreadCard({
</p>
)}
- {}
{isOrphaned && (
<div className="flex flex-col items-start gap-0.5">
<p className="text-xs text-muted-foreground">
diff --git a/packages/app/src/comments/comment-chips.tsx b/packages/app/src/comments/comment-chips.tsx
index d13475496..f15879963 100644
--- a/packages/app/src/comments/comment-chips.tsx
+++ b/packages/app/src/comments/comment-chips.tsx
@@ -53,7 +53,6 @@ export function QueuedCommentsChip({
'text-xs text-muted-foreground',
)}
>
- {}
<Tooltip>
<TooltipTrigger asChild>
<Button
@@ -66,7 +65,6 @@ export function QueuedCommentsChip({
className="h-auto min-h-0 gap-1 px-0.5 py-0 text-xs font-normal text-muted-foreground hover:text-foreground"
>
<MessageSquare className="size-3" />
- {}
{docs.length > 1 ? (
<Trans>
<Plural value={count} one="# comment" other="# comments" /> across{' '}
@@ -77,7 +75,6 @@ export function QueuedCommentsChip({
)}
</Button>
</TooltipTrigger>
- {}
<TooltipContent className="max-w-64">
{docs.length > 1 ? (
<ul className="flex flex-col gap-0.5">
diff --git a/packages/app/src/comments/property-anchor-click.dom.test.tsx b/packages/app/src/comments/property-anchor-click.dom.test.tsx
index d660393f5..87d304fb8 100644
--- a/packages/app/src/comments/property-anchor-click.dom.test.tsx
+++ b/packages/app/src/comments/property-anchor-click.dom.test.tsx
@@ -37,7 +37,6 @@ function Panel() {
usePropertyAnchorClick(ref, 'recipes/chicken-alfredo-pasta');
return (
<div ref={ref}>
- {}
<div data-testid="property-row" data-key="cuisine">
<Textarea aria-label="cuisine" defaultValue="Italian-American" />
</div>
diff --git a/packages/app/src/components/ActivityModeContent.tsx b/packages/app/src/components/ActivityModeContent.tsx
index 883dbe506..05afa75ad 100644
--- a/packages/app/src/components/ActivityModeContent.tsx
+++ b/packages/app/src/components/ActivityModeContent.tsx
@@ -271,7 +271,6 @@ function ActivityModeBody({
<EmptyState />
) : (
<>
- {}
{!data.sessionAlive && lastTs !== null ? <SessionEndedBanner lastTs={lastTs} /> : null}
{data.files.length === 0 ? (
<EmptyState />
diff --git a/packages/app/src/components/ActivityPanelBurstRow.tsx b/packages/app/src/components/ActivityPanelBurstRow.tsx
index 96098abc5..61e4473aa 100644
--- a/packages/app/src/components/ActivityPanelBurstRow.tsx
+++ b/packages/app/src/components/ActivityPanelBurstRow.tsx
@@ -92,7 +92,6 @@ export function ActivityPanelBurstRow({
<span className="text-destructive">−{burst.deletions}</span>
</span>
</button>
- {}
<span aria-hidden="true" className="mx-1.5 h-3 w-px shrink-0 bg-border" />
<Tooltip>
<TooltipTrigger asChild>
diff --git a/packages/app/src/components/ActivityPanelFileRow.tsx b/packages/app/src/components/ActivityPanelFileRow.tsx
index f6ef1c700..b52e1832c 100644
--- a/packages/app/src/components/ActivityPanelFileRow.tsx
+++ b/packages/app/src/components/ActivityPanelFileRow.tsx
@@ -61,7 +61,6 @@ export function ActivityPanelFileRow({
return (
<div className="border-b border-border" data-testid="activity-panel-file-row">
- {}
<div className="flex items-center gap-2 px-3 py-2 text-sm">
<button
type="button"
@@ -87,7 +86,6 @@ export function ActivityPanelFileRow({
) : null}
</div>
- {}
<div>
{file.bursts.map((burst) => (
<ActivityPanelBurstRow
diff --git a/packages/app/src/components/AddPropertiesButton.tsx b/packages/app/src/components/AddPropertiesButton.tsx
index f98851285..8eb619ae6 100644
--- a/packages/app/src/components/AddPropertiesButton.tsx
+++ b/packages/app/src/components/AddPropertiesButton.tsx
@@ -58,14 +58,12 @@ export function AddPropertiesButton({
<span className="font-medium">
<Trans>This document is missing required properties</Trans>
</span>
- {}
{problemMessages?.map((message, index) => (
// biome-ignore lint/suspicious/noArrayIndexKey: static within a render
<span key={index} className="opacity-90">
{message}
</span>
))}
- {}
<span className="pt-0.5 opacity-70">
<Trans>Click to add and fill them in</Trans>
</span>
diff --git a/packages/app/src/components/AddPropertyNameField.tsx b/packages/app/src/components/AddPropertyNameField.tsx
index a4a5a58fc..9ea6c7dab 100644
--- a/packages/app/src/components/AddPropertyNameField.tsx
+++ b/packages/app/src/components/AddPropertyNameField.tsx
@@ -152,7 +152,6 @@ export function AddPropertyNameField({
}}
className="w-64 max-h-64 overflow-y-auto p-1"
>
- {}
<div
aria-hidden
className="px-2 py-1 text-[10px] font-medium text-muted-foreground uppercase tracking-wide"
diff --git a/packages/app/src/components/AgentDiffPane.tsx b/packages/app/src/components/AgentDiffPane.tsx
index 2363ad6e1..7349f250a 100644
--- a/packages/app/src/components/AgentDiffPane.tsx
+++ b/packages/app/src/components/AgentDiffPane.tsx
@@ -227,7 +227,6 @@ export function AgentDiffPane({
className="absolute inset-0 z-20 flex flex-col bg-background"
data-testid="agent-diff-pane"
>
- {}
<div className="flex flex-wrap items-center gap-x-2 gap-y-1.5 border-b border-border px-3 py-2">
<Tooltip>
<TooltipTrigger asChild>
@@ -337,7 +336,6 @@ export function AgentDiffPane({
</div>
</div>
- {}
<div ref={diffBodyRef} className="min-h-0 flex-1 overflow-auto subtle-scrollbar">
{result.status === 'loading' && (
<div className="flex items-center gap-2 px-4 py-3 text-xs text-muted-foreground">
diff --git a/packages/app/src/components/AppErrorBoundary.tsx b/packages/app/src/components/AppErrorBoundary.tsx
index 267e20d12..cf78dd231 100644
--- a/packages/app/src/components/AppErrorBoundary.tsx
+++ b/packages/app/src/components/AppErrorBoundary.tsx
@@ -27,7 +27,6 @@ function AppErrorFallback({ error, resetErrorBoundary }: FallbackProps) {
data-slot="app-error-boundary"
className="flex h-screen flex-col items-center justify-center gap-8 p-8 text-center"
>
- {}
<OkBlobRunnerEasterEgg keyboard={false} />
<div className="flex flex-col items-center gap-1">
<h1 id="app-error-title" className="text-2xl font-light tracking-tighter text-balance">
diff --git a/packages/app/src/components/AssetPreview.tsx b/packages/app/src/components/AssetPreview.tsx
index 90192e3b6..56b5cfe66 100644
--- a/packages/app/src/components/AssetPreview.tsx
+++ b/packages/app/src/components/AssetPreview.tsx
@@ -26,7 +26,6 @@ function assetTextUrl(assetPath: string): string {
export function AssetPreview({ assetPath, mediaKind }: AssetPreviewProps) {
return (
<div className="flex h-full min-h-0 flex-col">
- {}
<NotInSidebarIndicator
entry={{ kind: 'asset', path: assetPath }}
className="shrink-0 border-b bg-background px-3 py-1.5"
diff --git a/packages/app/src/components/AuthModal.tsx b/packages/app/src/components/AuthModal.tsx
index 38ee6e297..4168c0d63 100644
--- a/packages/app/src/components/AuthModal.tsx
+++ b/packages/app/src/components/AuthModal.tsx
@@ -268,7 +268,6 @@ function PatBody({
<div className="flex flex-col gap-3">
{showGhOption ? (
<>
- {}
<Button type="button" onClick={onGhSignIn}>
<Trans>Continue in browser</Trans>
</Button>
@@ -297,7 +296,6 @@ function PatBody({
<Trans>Create a token on {host}</Trans>
<ArrowUpRight className="inline size-3.5" aria-hidden />
</a>
- {}
<p className="text-xs text-muted-foreground">
<Trans>The token needs the repo and read:user scopes.</Trans>
</p>
@@ -312,7 +310,6 @@ function PatBody({
}}
/>
{error && <p className="text-1sm text-destructive">{error}</p>}
- {}
{!showGhOption && (
<div className="mt-1 rounded-md border border-border/60 bg-muted/40 p-3 text-sm text-muted-foreground">
<p>
diff --git a/packages/app/src/components/BottomComposer.tsx b/packages/app/src/components/BottomComposer.tsx
index 51d896b10..3e57b5317 100644
--- a/packages/app/src/components/BottomComposer.tsx
+++ b/packages/app/src/components/BottomComposer.tsx
@@ -687,7 +687,7 @@ export function BottomComposer({
}
const cardContent = (
- // biome-ignore lint/a11y/noStaticElementInteractions: pointer clicks only delegate focus to the composer's editable; keyboard users focus it directly (Tab / ⇧⌘L).
+ // oxlint-disable-next-line jsx-a11y/no-static-element-interactions -- pointer clicks only delegate focus to the composer's editable; keyboard users focus it directly (Tab / ⇧⌘L).
<div
ref={cardRef}
onMouseDown={(event) => focusComposerInputOnCardPointer(event, inputRef)}
@@ -752,7 +752,6 @@ export function BottomComposer({
'bg-destructive/5 outline-2 outline-dashed outline-offset-2 outline-destructive/60',
)}
>
- {}
{!folderMode ? (
<Button
type="button"
@@ -765,7 +764,6 @@ export function BottomComposer({
<ChevronDown className="size-3.5" aria-hidden />
</Button>
) : null}
- {}
<ComposerContextChips
files={fileChips}
onRemoveFile={(path) =>
@@ -778,13 +776,11 @@ export function BottomComposer({
>
{pinnedSelection ? (
<>
- {}
<span
data-testid="composer-selection-pill"
title={pinnedLabel}
className="group/chip inline-flex max-w-[16rem] items-center gap-1 rounded-md border bg-muted/40 py-0.5 pr-1.5 pl-1 text-muted-foreground text-xs"
>
- {}
<Button
type="button"
variant="ghost"
@@ -805,7 +801,6 @@ export function BottomComposer({
aria-hidden
/>
</Button>
- {}
<Button
type="button"
variant="ghost"
@@ -830,7 +825,6 @@ export function BottomComposer({
) : null}
</>
) : null}
- {}
{hasQueuedComments && (
<QueuedCommentsChip
count={selectedCommentCount}
@@ -901,7 +895,6 @@ export function BottomComposer({
initialDoc={savedDraftDoc ?? undefined}
className="max-h-[200px] overflow-y-auto overscroll-contain text-base md:text-sm"
/>
- {}
{isEmpty ? (
<RotatingComposerPlaceholder
phrases={suggestions}
@@ -942,7 +935,6 @@ export function BottomComposer({
<Trans>Ask</Trans>
)}
</span>
- {}
{resolvedTarget ? <ArrowUpRight aria-hidden className="size-3.5" /> : null}
{pending ? <Spinner className="size-3.5" aria-hidden /> : null}
</>
diff --git a/packages/app/src/components/BugReportHistory.tsx b/packages/app/src/components/BugReportHistory.tsx
index 343088ff4..7b41d5caa 100644
--- a/packages/app/src/components/BugReportHistory.tsx
+++ b/packages/app/src/components/BugReportHistory.tsx
@@ -178,17 +178,14 @@ function ReportRow({
<li className="flex items-start gap-2.5 rounded-md border px-3 py-2.5">
<div className="min-w-0 flex-1 space-y-1">
<div className="flex items-center gap-2">
- {}
<p dir="auto" className="min-w-0 flex-1 truncate text-1sm" title={title}>
{title}
</p>
<StateBadge state={row.state} />
</div>
- {}
<div className="flex flex-wrap items-center gap-x-1.5 gap-y-1 text-xs text-muted-foreground">
{row.bundleLevel !== 'unknown' ? <Badge variant="gray">{row.bundleLevel}</Badge> : null}
<span className="whitespace-nowrap">{when}</span>
- {}
{row.zipBytes > 0 ? (
<>
<span aria-hidden>·</span>
@@ -334,7 +331,6 @@ export function BugReportPreviousReports() {
return (
<Collapsible open={open} onOpenChange={setOpen}>
<CollapsibleTrigger asChild>
- {}
<Button
variant="ghost"
size="sm"
diff --git a/packages/app/src/components/BugReportSendToast.tsx b/packages/app/src/components/BugReportSendToast.tsx
index f5f2e6c05..b255147cc 100644
--- a/packages/app/src/components/BugReportSendToast.tsx
+++ b/packages/app/src/components/BugReportSendToast.tsx
@@ -103,12 +103,10 @@ function SendingLayout({
<p id={titleId} className="font-medium text-sm">
<Trans>Sending report</Trans>
</p>
- {}
<span className="ms-auto shrink-0 text-muted-foreground text-xs">
<Trans>{formatBundleSize(operation.zipSizeBytes)} total</Trans>
</span>
</div>
- {}
<Progress
value={null}
indeterminateFillPercent={operation.fillPercent}
@@ -138,7 +136,6 @@ function SentLayout({
<Trans>We've filed it with the team and attached your logs.</Trans>
</p>
<div className="mt-0.5 flex items-center gap-1.5">
- {}
<span className="shrink-0 text-muted-foreground text-xs">
<Trans>Reference</Trans>
</span>
@@ -147,7 +144,6 @@ function SentLayout({
</span>
<CopyReferenceButton reference={operation.reference} write={actions.writeToClipboard} />
</div>
- {}
</ToastCard>
);
}
@@ -169,7 +165,6 @@ function EmailDraftLayout({
<p className="font-medium text-sm">
<Trans>Send your report by email</Trans>
</p>
- {}
<p className="text-muted-foreground text-sm">
<Trans>
Nothing was uploaded. The report stays on this computer until you email it to us.
@@ -216,7 +211,6 @@ function FailedLayout({
<Button size="sm" onClick={actions.retry}>
<Trans>Try again</Trans>
</Button>
- {}
{mailtoUrl !== undefined && (
<Button size="sm" variant="outline" onClick={() => actions.openExternal(mailtoUrl)}>
<Trans>Open email draft</Trans>
@@ -241,7 +235,6 @@ function AlreadySendingLayout({ actions }: { actions: BugReportSendToastActions
<p className="font-medium text-sm">
<Trans>Already sending this report</Trans>
</p>
- {}
<p className="text-muted-foreground text-sm">
<Trans>
This report is already on its way. Its result will appear in your bug report history.
diff --git a/packages/app/src/components/CloneDialog.tsx b/packages/app/src/components/CloneDialog.tsx
index 521d28d16..560ac9268 100644
--- a/packages/app/src/components/CloneDialog.tsx
+++ b/packages/app/src/components/CloneDialog.tsx
@@ -415,7 +415,7 @@ export function CloneDialog({
</div>
) : (
suggestions.map((repo, i) => (
- // biome-ignore lint/a11y/useKeyWithClickEvents: WAI-ARIA combobox pattern — keyboard is handled on the input (Arrow/Enter via handleComboKeyDown) and routed to the highlighted option through aria-activedescendant; per-option key handlers would double-fire.
+ // oxlint-disable-next-line jsx-a11y/click-events-have-key-events -- WAI-ARIA combobox pattern — keyboard is handled on the input (Arrow/Enter via handleComboKeyDown) and routed to the highlighted option through aria-activedescendant; per-option key handlers would double-fire.
<div
key={repo.full_name}
id={`${listboxId}-opt-${i}`}
diff --git a/packages/app/src/components/CommandPalette.tsx b/packages/app/src/components/CommandPalette.tsx
index 377f8535a..08fc410b1 100644
--- a/packages/app/src/components/CommandPalette.tsx
+++ b/packages/app/src/components/CommandPalette.tsx
@@ -1108,7 +1108,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
isSemanticMode ? t`Search by meaning` : t`Search files, folders, or commands`
}
/>
- {}
<div className="flex flex-wrap gap-1.5 border-b px-3 py-2">
<button
type="button"
@@ -1135,7 +1134,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
<Trans>By tag</Trans>
</span>
</button>
- {}
{semanticSearchOffered ? (
<button
type="button"
@@ -1160,7 +1158,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
<CommandList ref={listRef} className="subtle-scrollbar">
{isSemanticMode && semanticView ? (
<>
- {}
{semanticCoverageIncomplete ? (
<div
className="px-3 py-2 text-muted-foreground text-xs"
@@ -1177,7 +1174,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
</div>
) : null}
- {}
{semanticView.submit ? (
<CommandGroup>
<CommandItem
@@ -1273,7 +1269,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
{isSemanticMode && semanticView ? (
<>
- {}
{semanticView.results.show ? (
<CommandGroup
heading={
@@ -1450,7 +1445,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
) : null}
</CommandList>
- {}
<SearchHint
mode={classifyOmnibarSearchHint(trimmedDeferredQuery, visibleSearchResults, {
truncated: searchTruncated,
@@ -1482,7 +1476,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
onOpenChange={setSeedDialogOpen}
onSeedApplied={revealEditor}
/>
- {}
{bridge ? (
<CreateProjectDialog
open={createProjectOpen}
@@ -1490,9 +1483,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
bridge={bridge}
/>
) : null}
- {}
{bridge ? <ReportBugDialog capture={bugReport.capture} onClose={bugReport.close} /> : null}
- {}
{bridge && historyEverOpened ? (
<Suspense fallback={null}>
<BugReportHistoryDialog
@@ -1504,7 +1495,6 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
/>
</Suspense>
) : null}
- {}
<FeedbackFormDialog
open={feedbackOpen}
onOpenChange={setFeedbackOpen}
diff --git a/packages/app/src/components/ComposerContextChips.tsx b/packages/app/src/components/ComposerContextChips.tsx
index 783887e98..e83b5b21e 100644
--- a/packages/app/src/components/ComposerContextChips.tsx
+++ b/packages/app/src/components/ComposerContextChips.tsx
@@ -22,7 +22,6 @@ function FileChip({ path, onRemove }: { path: string; onRemove: () => void }) {
title={path}
className="group/chip inline-flex max-w-[14rem] items-center gap-1 rounded-md border bg-muted/40 py-0.5 pr-1.5 pl-1 text-muted-foreground text-xs"
>
- {}
<Button
type="button"
variant="ghost"
diff --git a/packages/app/src/components/ConflictFilePreview.tsx b/packages/app/src/components/ConflictFilePreview.tsx
index 545a71125..54eb2dc81 100644
--- a/packages/app/src/components/ConflictFilePreview.tsx
+++ b/packages/app/src/components/ConflictFilePreview.tsx
@@ -30,7 +30,7 @@ export function ConflictFilePreview({ filename, content }: ConflictFilePreviewPr
return (
<section
ref={containerRef}
- // biome-ignore lint/a11y/noNoninteractiveTabindex: keyboard-focusable scroll container — this render has no focusable descendants at all, so without the stop the body cannot be scrolled by keyboard. Same pattern as SyncStatusBadge's scroll container.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- keyboard-focusable scroll container — this render has no focusable descendants at all, so without the stop the body cannot be scrolled by keyboard. Same pattern as SyncStatusBadge's scroll container.
tabIndex={0}
aria-label={t`Preview of ${filename}`}
className="conflict-view h-full overflow-y-auto subtle-scrollbar"
diff --git a/packages/app/src/components/ConflictView.tsx b/packages/app/src/components/ConflictView.tsx
index cbf608302..4f99e6947 100644
--- a/packages/app/src/components/ConflictView.tsx
+++ b/packages/app/src/components/ConflictView.tsx
@@ -364,13 +364,11 @@ export function ConflictView({
</Alert>
</div>
)}
- {}
{absentStageBanner && (
<p role="status" className="shrink-0 border-b px-3 py-2 text-xs text-muted-foreground">
{absentStageBanner}
</p>
)}
- {}
<div aria-live="polite" aria-atomic="true" className="sr-only">
{liveRemaining === null
? ''
@@ -426,12 +424,11 @@ export function ConflictView({
)}
<section
ref={containerRef}
- // biome-ignore lint/a11y/noNoninteractiveTabindex: keyboard-focusable scroll container — Chromium doesn't make overflow:auto elements focusable without tabIndex, and axe's scrollable-region-focusable requires the stop. Same pattern as SyncStatusBadge's scroll container.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- keyboard-focusable scroll container — Chromium doesn't make overflow:auto elements focusable without tabIndex, and axe's scrollable-region-focusable requires the stop. Same pattern as SyncStatusBadge's scroll container.
tabIndex={0}
aria-label={t`Conflict diff for ${fileName}`}
className="conflict-view min-h-0 flex-1 overflow-y-auto subtle-scrollbar"
/>
- {}
<div
ref={conflictFooterRef}
className="flex shrink-0 items-center justify-end gap-2 border-t px-3 py-2"
@@ -455,7 +452,6 @@ export function ConflictView({
</Button>
)}
</div>
- {}
{!parseMismatch &&
controls.map((control) =>
createPortal(
diff --git a/packages/app/src/components/ConnectingBanner.tsx b/packages/app/src/components/ConnectingBanner.tsx
index f6b6035cb..8575811e6 100644
--- a/packages/app/src/components/ConnectingBanner.tsx
+++ b/packages/app/src/components/ConnectingBanner.tsx
@@ -93,7 +93,6 @@ export function ConnectingBanner() {
>
<Trans>Try again</Trans>
</button>
- {}
{openBlobRunner ? (
<button
type="button"
diff --git a/packages/app/src/components/ConsentDialogBody.tsx b/packages/app/src/components/ConsentDialogBody.tsx
index c0831ac9b..a664daa9e 100644
--- a/packages/app/src/components/ConsentDialogBody.tsx
+++ b/packages/app/src/components/ConsentDialogBody.tsx
@@ -1,5 +1,3 @@
-// oxlint-disable ok/no-raw-html-interactive-element -- pre-rule backlog — file uses raw <button>/<input>/<textarea> awaiting shadcn migration; tracked at https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-raw-html-interactive-element
-
// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
import { receivesProjectIntegrationWrite } from '@inkeep/open-knowledge-core/constants/editors';
@@ -337,7 +335,6 @@ function ConsentDialogForm({ payload, store, toast, detectionGraceMs }: ConsentD
<form id={formId} onSubmit={onSubmit} data-testid="consent-form" className="space-y-6">
{contentDirSafe ? <ProbePreview probe={probe} /> : null}
- {}
<ProjectAiToolsField
detectedEditors={detectedEditors}
checked={connectEditors}
diff --git a/packages/app/src/components/CreateProjectDialog.tsx b/packages/app/src/components/CreateProjectDialog.tsx
index a1724a9d9..07788e9a9 100644
--- a/packages/app/src/components/CreateProjectDialog.tsx
+++ b/packages/app/src/components/CreateProjectDialog.tsx
@@ -611,7 +611,6 @@ export function CreateProjectDialog({
className={cn('sm:max-w-lg', step === 'pick' && 'sm:max-w-3xl')}
data-testid="create-project-dialog"
>
- {}
<span aria-live="polite" className="sr-only" data-testid="create-step-announcer">
{stepAnnouncement}
</span>
@@ -719,7 +718,6 @@ export function CreateProjectDialog({
</div>
<div className="flex flex-col gap-2">
- {}
<Label>
<Trans>Location</Trans>
</Label>
@@ -785,7 +783,6 @@ export function CreateProjectDialog({
onChoiceChange={setRootChoice}
onSubfolderChange={setSubfolder}
/>
- {}
{cascade.kind === 'confirm-git' ? (
<p
className="text-1sm text-muted-foreground"
@@ -798,7 +795,6 @@ export function CreateProjectDialog({
</Trans>
</p>
) : null}
- {}
{packPreview.kind === 'error' && packPreview.blocking ? (
<div
role="alert"
@@ -811,7 +807,6 @@ export function CreateProjectDialog({
</div>
) : null}
- {}
<ProjectAiToolsField
detectedEditors={detectedEditors}
checked={connectEditors}
@@ -821,7 +816,6 @@ export function CreateProjectDialog({
itemTestIdPrefix="create-editor"
/>
- {}
{packSkillCount > 0 ? (
<p className="text-1sm text-muted-foreground" data-testid="create-pack-skills-note">
{skillsInstallable ? (
@@ -861,7 +855,6 @@ export function CreateProjectDialog({
)}
<DialogFooter>
- {}
{(step === 'configure' || step === 'review') && canChangePack ? (
<Button
type="button"
@@ -875,7 +868,6 @@ export function CreateProjectDialog({
<Trans>Change pack</Trans>
</Button>
) : null}
- {}
{step !== 'review' ? (
<Button
type="button"
diff --git a/packages/app/src/components/CreatedItemsList.tsx b/packages/app/src/components/CreatedItemsList.tsx
index 01588dcd4..b0d376164 100644
--- a/packages/app/src/components/CreatedItemsList.tsx
+++ b/packages/app/src/components/CreatedItemsList.tsx
@@ -243,7 +243,6 @@ export function CreatedItemsList({
const Icon = row.icon;
return (
<li key={row.key} className="flex items-center gap-3">
- {}
<div
aria-hidden="true"
className="flex size-8 shrink-0 items-center justify-center rounded-lg border border-border/60"
@@ -251,7 +250,6 @@ export function CreatedItemsList({
<Icon className="size-4 text-muted-foreground" />
</div>
<div className="min-w-0 flex-1 py-0.5">
- {}
<div className="flex items-center gap-2">
<code
className="min-w-0 flex-1 truncate font-mono text-1sm text-foreground/90"
@@ -262,7 +260,6 @@ export function CreatedItemsList({
{row.pill ? (
row.pillTooltip && row.pillTooltip.length > 0 ? (
<Tooltip>
- {}
<TooltipTrigger className="shrink-0 cursor-help rounded bg-transparent p-0 font-mono text-2xs uppercase tracking-wide text-muted-foreground transition-colors hover:text-foreground/70 focus-visible:text-foreground/70 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring/50">
{row.pill}
</TooltipTrigger>
diff --git a/packages/app/src/components/DeleteConfirmationDialog.tsx b/packages/app/src/components/DeleteConfirmationDialog.tsx
index 2a0a7c2f8..59bff0257 100644
--- a/packages/app/src/components/DeleteConfirmationDialog.tsx
+++ b/packages/app/src/components/DeleteConfirmationDialog.tsx
@@ -58,7 +58,6 @@ export function DeleteConfirmationDialog({
<AlertDialogCancel disabled={isSubmitting}>
<Trans>Cancel</Trans>
</AlertDialogCancel>
- {}
<Button variant="destructive" onClick={onDelete} disabled={isSubmitting}>
{isSubmitting ? (
<>
diff --git a/packages/app/src/components/DiffViewBoundary.tsx b/packages/app/src/components/DiffViewBoundary.tsx
index 8efee9b84..13e6dba3b 100644
--- a/packages/app/src/components/DiffViewBoundary.tsx
+++ b/packages/app/src/components/DiffViewBoundary.tsx
@@ -221,7 +221,6 @@ export function DiffViewBoundary({ docName, conflict }: DiffViewBoundaryProps) {
disabled={isResolving}
onClick={() => void handleResolveStrategy(resolveConflictDelete)}
>
- {}
<Trans>Keep file deleted</Trans>
</Button>
{offersTheirs && (
diff --git a/packages/app/src/components/DocPanel.tsx b/packages/app/src/components/DocPanel.tsx
index ad681f9e6..706678e02 100644
--- a/packages/app/src/components/DocPanel.tsx
+++ b/packages/app/src/components/DocPanel.tsx
@@ -163,7 +163,6 @@ export function DocPanel({
}, [isCollapsed, mode, effectiveTab]);
return (
<>
- {}
{showTabStrip ? (
<div
data-doc-panel-header=""
diff --git a/packages/app/src/components/DocumentErrorBoundary.tsx b/packages/app/src/components/DocumentErrorBoundary.tsx
index e2b36b72d..760164f62 100644
--- a/packages/app/src/components/DocumentErrorBoundary.tsx
+++ b/packages/app/src/components/DocumentErrorBoundary.tsx
@@ -126,7 +126,6 @@ function DocumentErrorFallback({
data-slot="document-error-boundary"
className="flex h-full flex-col items-center justify-center gap-8 p-8 text-center"
>
- {}
<OkBlobRunnerEasterEgg keyboard={isServerReachError(error)} />
<div className="flex flex-col items-center gap-1">
<h2 id="document-error-title" className="text-2xl font-light tracking-tighter text-balance">
diff --git a/packages/app/src/components/EditorActivityPool.tsx b/packages/app/src/components/EditorActivityPool.tsx
index 68f1e9fa6..9d4ee19c8 100644
--- a/packages/app/src/components/EditorActivityPool.tsx
+++ b/packages/app/src/components/EditorActivityPool.tsx
@@ -740,7 +740,7 @@ function WarmContentFallback({ html }: { html: string }) {
<div className="tiptap-editor h-full pointer-events-none" aria-hidden="true">
<div
className="tiptap ProseMirror tiptap-editor-portal-content"
- // biome-ignore lint/security/noDangerouslySetInnerHtml: editor.getHTML() routes through DOMSerializer.serializeFragment — attribute values via setAttribute(), text via createTextNode(); both escape correctly
+ // oxlint-disable-next-line react/no-danger -- editor.getHTML() routes through DOMSerializer.serializeFragment — attribute values via setAttribute(), text via createTextNode(); both escape correctly
dangerouslySetInnerHTML={{ __html: html }}
/>
</div>
@@ -865,7 +865,6 @@ function ActivityEntry({
return (
<Activity mode={isVisible ? 'visible' : 'hidden'} name={`editor:${entry.docName}`}>
- {}
<ScrollPreservingContainer
isActive={isVisible}
docName={entry.docName}
@@ -878,14 +877,12 @@ function ActivityEntry({
<ServerRestartRecoveryPanel view={recoveryView} />
) : (
<>
- {}
<DocumentErrorBoundary
activeDocName={entry.docName}
previousDocName={previousDocName}
onNavigateBack={onNavigateBack}
onRecycle={onRecycle}
>
- {}
<Suspense
fallback={
warmHtml && isDualEditor ? (
@@ -919,7 +916,6 @@ function ActivityEntry({
<TextDocEditor docName={entry.docName} provider={entry.provider} />
) : (
<div className="flex h-full flex-col">
- {}
{!effectiveIsSourceMode &&
(isManagedArtifactDocName(entry.docName) ||
parseProjectSkillContentDocName(entry.docName) ||
@@ -936,7 +932,6 @@ function ActivityEntry({
<PropertyPanel provider={entry.provider} />
</>
))}
- {}
<div
ref={bodyAnchorRef}
aria-hidden
diff --git a/packages/app/src/components/EditorActivityPool.warm-skeleton.dom.test.tsx b/packages/app/src/components/EditorActivityPool.warm-skeleton.dom.test.tsx
index a5a49db6c..61604b196 100644
--- a/packages/app/src/components/EditorActivityPool.warm-skeleton.dom.test.tsx
+++ b/packages/app/src/components/EditorActivityPool.warm-skeleton.dom.test.tsx
@@ -18,7 +18,7 @@ function WarmContentFallbackReplica({ html }: { html: string }) {
<div className="tiptap-editor h-full pointer-events-none" aria-hidden="true">
<div
className="tiptap ProseMirror tiptap-editor-portal-content"
- // biome-ignore lint/security/noDangerouslySetInnerHtml: test replica mirrors editor.getHTML() serialization
+ // oxlint-disable-next-line react/no-danger -- test replica mirrors editor.getHTML() serialization
dangerouslySetInnerHTML={{ __html: html }}
/>
</div>
diff --git a/packages/app/src/components/EditorArea.dom.test.tsx b/packages/app/src/components/EditorArea.dom.test.tsx
index ed4b89bd3..51f0544ff 100644
--- a/packages/app/src/components/EditorArea.dom.test.tsx
+++ b/packages/app/src/components/EditorArea.dom.test.tsx
@@ -436,6 +436,7 @@ vi.doMock('@/components/ui/resizable', () => ({
data-doc-panel-handle={props['data-doc-panel-handle']}
data-terminal-panel-handle={props['data-terminal-panel-handle']}
onPointerDown={onPointerDown}
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- mirrors react-resizable-panels' Separator, which renders tabIndex 0; a focusable separator is a widget.
tabIndex={0}
/>
),
diff --git a/packages/app/src/components/EditorArea.tsx b/packages/app/src/components/EditorArea.tsx
index 1c427f392..53022c26f 100644
--- a/packages/app/src/components/EditorArea.tsx
+++ b/packages/app/src/components/EditorArea.tsx
@@ -1,5 +1,3 @@
-// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
-
import type { HocuspocusProvider } from '@hocuspocus/provider';
import { parseExternalSkillDocName } from '@inkeep/open-knowledge-core/constants/cc1';
import { detectEmbeddedHostFromBrowser } from '@inkeep/open-knowledge-core/constants/embedded-host';
@@ -475,7 +473,6 @@ function renderTabsWithoutHeader(tabs: ReactNode, chrome: WorkspaceHeaderChrome)
export function EditorArea(props: EditorAreaProps) {
return (
<ProfilerBoundary name="editor-area">
- {}
<PropertyProvider>
<EditorAreaInner {...props} />
<SettingsDialogPortal />
@@ -1442,10 +1439,8 @@ function EditorAreaInner({
});
viewContent = (
<div className="relative flex h-full min-h-0 flex-col">
- {}
<div className="relative flex min-h-0 flex-1 flex-col">
<FolderOverview folderPath={activeTarget.folderPath} />
- {}
{showFolderComposer ? (
<div
aria-hidden
@@ -1564,7 +1559,6 @@ function EditorAreaInner({
const externalSkillEdit = activeDocName ? parseExternalSkillDocName(activeDocName) : null;
const renderEditorContent = (activityMount: ReactNode) => (
<div className="relative flex h-full flex-col">
- {}
{externalSkillEdit ? (
<Suspense fallback={null}>
<SkillEditBanner name={externalSkillEdit.name} />
@@ -1572,11 +1566,9 @@ function EditorAreaInner({
) : null}
<DocChangeNotice docName={activeDocName} timelineAvailable={!noteWindow} />
<div className="relative min-h-0 flex-1">
- {}
<div className="relative h-full">
{activityMount}
<FindReplaceController activeDocName={activeDocName} isSourceMode={isSourceMode} />
- {}
{shouldPaintOverlay({
activeDocName,
deferredActiveDocName,
@@ -1585,11 +1577,9 @@ function EditorAreaInner({
}) ? (
<div className="absolute inset-0 z-10 bg-background">
<EditorSkeleton />
- {}
{activeDocName !== null ? <MountStalledAffordance docName={activeDocName} /> : null}
</div>
) : null}
- {}
{timelineDiff && timelineDiff.docName === activeDocName ? (
<Suspense fallback={null}>
<LazyTimelineDiffPane
@@ -1601,7 +1591,6 @@ function EditorAreaInner({
/>
</Suspense>
) : null}
- {}
{agentDiff && agentDiffDoc === activeDocName ? (
<Suspense fallback={null}>
<LazyAgentDiffPane
@@ -1614,7 +1603,6 @@ function EditorAreaInner({
</Suspense>
) : null}
</div>
- {}
{showBottomComposer ? (
<BottomComposer
docName={activeDocName}
diff --git a/packages/app/src/components/EditorBreadcrumb.tsx b/packages/app/src/components/EditorBreadcrumb.tsx
index 1c451162f..2cc4fa219 100644
--- a/packages/app/src/components/EditorBreadcrumb.tsx
+++ b/packages/app/src/components/EditorBreadcrumb.tsx
@@ -78,7 +78,6 @@ export function EditorBreadcrumb({
const isCurrentPage = node.kind === 'segment' && node.key === currentPageKey;
return (
<Fragment key={key}>
- {}
{index > 0 && (
<BreadcrumbSeparator className="shrink-0 text-muted-foreground/70 [&>svg]:size-3" />
)}
@@ -91,7 +90,6 @@ export function EditorBreadcrumb({
>
<MoreHorizontalIcon className="size-3.5" />
</span>
- {}
<span className="sr-only">
<UserText>{node.hidden.join(' / ')}</UserText>
</span>
diff --git a/packages/app/src/components/EditorFooter.tsx b/packages/app/src/components/EditorFooter.tsx
index 83258e3a5..b12369870 100644
--- a/packages/app/src/components/EditorFooter.tsx
+++ b/packages/app/src/components/EditorFooter.tsx
@@ -49,7 +49,6 @@ export function EditorFooter({
aria-hidden
className="pointer-events-none absolute inset-x-0 bottom-full h-2 bg-linear-to-t from-background to-transparent"
/>
- {}
{composerBadge ? (
<Button
type="button"
@@ -108,8 +107,12 @@ function CheckoutDetail({ detail, projectPath }: { detail: string; projectPath:
return (
<Tooltip>
<TooltipTrigger asChild>
- {/* biome-ignore lint/a11y/noNoninteractiveTabindex: tooltip-on-static-text pattern — focusable span lets keyboard users surface the full project path that mouse users see on hover. */}
- <span tabIndex={0} className="flex min-w-0" data-testid="editor-footer-checkout">
+ <span
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- tooltip-on-static-text pattern — focusable span lets keyboard users surface the full project path that mouse users see on hover.
+ tabIndex={0}
+ className="flex min-w-0"
+ data-testid="editor-footer-checkout"
+ >
{row}
</span>
</TooltipTrigger>
diff --git a/packages/app/src/components/EditorModeToggle.tsx b/packages/app/src/components/EditorModeToggle.tsx
index d8141e782..6eac34f7d 100644
--- a/packages/app/src/components/EditorModeToggle.tsx
+++ b/packages/app/src/components/EditorModeToggle.tsx
@@ -45,7 +45,6 @@ export function EditorModeToggle({
>
<Tooltip>
<TooltipTrigger asChild>
- {}
<div>
<ToggleGroupItem
value="wysiwyg"
@@ -75,7 +74,6 @@ export function EditorModeToggle({
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
- {}
<div>
<ToggleGroupItem
value="source"
diff --git a/packages/app/src/components/EditorPane.tsx b/packages/app/src/components/EditorPane.tsx
index e89d3c268..d2ffb9634 100644
--- a/packages/app/src/components/EditorPane.tsx
+++ b/packages/app/src/components/EditorPane.tsx
@@ -1311,11 +1311,9 @@ export function EditorPane() {
return (
<>
- {}
<Suspense fallback={null}>
<AgentThreadClientBinder />
</Suspense>
- {}
<div className="flex min-h-0 flex-1">
<div className="flex min-w-0 flex-1 flex-col">
<EditorArea
@@ -1342,7 +1340,6 @@ export function EditorPane() {
/>
</div>
</div>
- {}
{noteWindow ? null : (
<Suspense fallback={null}>
<SessionsHost
@@ -1401,7 +1398,6 @@ export function EditorPane() {
/>
<TagDialog />
<EmojiInsertPopover />
- {}
</>
);
}
diff --git a/packages/app/src/components/EditorTabs.tsx b/packages/app/src/components/EditorTabs.tsx
index e482bbaa7..846aa3edd 100644
--- a/packages/app/src/components/EditorTabs.tsx
+++ b/packages/app/src/components/EditorTabs.tsx
@@ -236,7 +236,7 @@ function SortableTab({
sortableKeyDown?.(event);
}
return (
- // biome-ignore lint/a11y/noStaticElementInteractions: dnd-kit attributes inject role and tabIndex; this composes the sortable key listener.
+ // oxlint-disable-next-line jsx-a11y/no-static-element-interactions -- dnd-kit attributes inject role and tabIndex; this composes the sortable key listener.
<div
ref={composedRef}
data-editor-tab-sortable=""
diff --git a/packages/app/src/components/EditorToolbar.tsx b/packages/app/src/components/EditorToolbar.tsx
index 7060e26a3..8997b848d 100644
--- a/packages/app/src/components/EditorToolbar.tsx
+++ b/packages/app/src/components/EditorToolbar.tsx
@@ -81,12 +81,9 @@ export function EditorToolbar({
data-testid="editor-toolbar"
className="pointer-events-none absolute inset-x-0 top-0 z-10 @container/toolbar"
>
- {}
<div className="editor-content-aligned bg-background py-2">
<div className="grid grid-cols-3 items-center">
- {}
<div className="pointer-events-auto flex min-w-0 items-center gap-2">
- {}
{activeSkill ? (
<Suspense fallback={null}>
<SkillOriginInline scope={activeSkill.scope} name={activeSkill.name} />
@@ -94,7 +91,6 @@ export function EditorToolbar({
) : externalSkill ? null : (
<EditorBreadcrumb docName={activeDocName} />
)}
- {}
{activeDocName === null ? null : (
<NotInSidebarIndicator
entry={{ kind: 'document', docName: activeDocName }}
@@ -103,7 +99,6 @@ export function EditorToolbar({
)}
</div>
<div className="pointer-events-auto flex justify-center">
- {}
{activeDocName !== null &&
(isEditableTextDocFile(activeDocName) || isExcalidrawDocFile(activeDocName)) ? null : (
<EditorModeToggle
@@ -113,10 +108,8 @@ export function EditorToolbar({
/>
)}
</div>
- {}
</div>
</div>
- {}
<div className="pointer-events-auto absolute top-0 right-0 flex min-w-0 max-w-[calc(50%_-_3rem)] items-center justify-end gap-1 py-2 pr-2">
{activeSkill && activeDocName ? (
<Suspense fallback={null}>
diff --git a/packages/app/src/components/EditorWorkspace.tsx b/packages/app/src/components/EditorWorkspace.tsx
index 14869c530..ab37dece5 100644
--- a/packages/app/src/components/EditorWorkspace.tsx
+++ b/packages/app/src/components/EditorWorkspace.tsx
@@ -342,7 +342,6 @@ function WorkspacePane({
onPointerDownCapture={() => focusPane(pane.id)}
onFocusCapture={() => focusPane(pane.id)}
>
- {}
<div className="relative flex min-h-0 flex-1 flex-col">
{renderPane({
pane,
diff --git a/packages/app/src/components/EmptyEditorState.tsx b/packages/app/src/components/EmptyEditorState.tsx
index fcdbe4952..f64941cbb 100644
--- a/packages/app/src/components/EmptyEditorState.tsx
+++ b/packages/app/src/components/EmptyEditorState.tsx
@@ -218,16 +218,13 @@ function OnboardingView({
celebrateSignal={celebrateSignal}
onRageStreak={onRageStreak}
/>
- {}
{isEmbedded ? (
<CopyablePromptList scenario="new-project" />
) : (
<CreatePromptComposer scenario="new-project" />
)}
- {}
<div className="flex w-full flex-col gap-3">
<TemplateDivider label={isEmbedded ? t`Use a starter pack` : t`Or use a starter pack`} />
- {}
<PackCardGrid
onPackSelect={onPackSelect}
onCreateBlankFile={() => emitCreateTopLevelFile()}
diff --git a/packages/app/src/components/ExploreSkills.tsx b/packages/app/src/components/ExploreSkills.tsx
index fb3246a3c..0804c62c9 100644
--- a/packages/app/src/components/ExploreSkills.tsx
+++ b/packages/app/src/components/ExploreSkills.tsx
@@ -111,7 +111,6 @@ export function ExploreSkills({
aria-label={t`Search skills`}
/>
</InputGroup>
- {}
{q.length >= 2 && state === 'idle' && results.length > 0 ? (
<Select value={sortBy} onValueChange={(v) => setSortBy(v as 'relevance' | 'installs')}>
<SelectTrigger className="h-9! w-40 shrink-0" aria-label={t`Sort skills`}>
@@ -127,7 +126,6 @@ export function ExploreSkills({
</Select>
) : null}
</div>
- {}
{/* biome-ignore lint/a11y/useSemanticElements: a filter-chip row is a
button cluster, not a form-control set; <fieldset>/<legend> would impose
form chrome. role="group" on a div is the shape the rest of the app uses. */}
@@ -219,7 +217,6 @@ export function ExploreSkills({
})
)}
</div>
- {}
<p className="-mb-3.5 shrink-0 text-center text-[11px] text-muted-foreground/80">
<Trans>
Skill discovery powered by{' '}
diff --git a/packages/app/src/components/FeedbackForm.tsx b/packages/app/src/components/FeedbackForm.tsx
index 0e8aae317..6799d5d67 100644
--- a/packages/app/src/components/FeedbackForm.tsx
+++ b/packages/app/src/components/FeedbackForm.tsx
@@ -179,7 +179,6 @@ export const FeedbackForm = ({
) : null}
</div>
)}
- {}
<FormField
control={form.control}
name="rating"
@@ -241,7 +240,6 @@ export const FeedbackForm = ({
{showBeyondRating && (
<>
<div className={compact ? 'space-y-5' : 'space-y-3'}>
- {}
{rating === 'negative' && (
<FormField
control={form.control}
@@ -276,7 +274,6 @@ export const FeedbackForm = ({
/>
)}
- {}
<FormField
control={form.control}
name="message"
@@ -294,7 +291,6 @@ export const FeedbackForm = ({
/>
</div>
<div className="space-y-2">
- {}
<FormField
control={form.control}
name="shareEmail"
diff --git a/packages/app/src/components/FileSidebar.tsx b/packages/app/src/components/FileSidebar.tsx
index 0f38b2cbd..42328bae2 100644
--- a/packages/app/src/components/FileSidebar.tsx
+++ b/packages/app/src/components/FileSidebar.tsx
@@ -596,256 +596,236 @@ function FileSidebarInner() {
{pendingSettingsReason}
</span>
) : null}
- {}
<ContextMenu>
<ContextMenuTrigger asChild>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: ContextMenuTrigger
- * delegation surface — display:contents wrapper for the asChild Slot's
- * single-child requirement. Keyboard equivalents live on the individual
- * interactive controls inside (toolbar buttons, Pierre tree rows,
- * sidebar rail); this wrapper
- * has no perceivable interactive surface of its own. The onContextMenu
- * handler delegates the button-target opt-out for the sidebar-wide
- * context menu — same a11y semantics as a Radix Slot. */}
- <div className="contents" onContextMenu={handleSidebarSurfaceContextMenu}>
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- ContextMenuTrigger delegation surface — display:contents wrapper for the asChild Slot's single-child requirement. Keyboard equivalents live on the individual interactive controls inside (toolbar buttons, Pierre tree rows, sidebar rail); this wrapper has no perceivable interactive surface of its own. The onContextMenu handler delegates the button-target opt-out for the sidebar-wide context menu — same a11y semantics as a Radix Slot.
+ className="contents"
+ onContextMenu={handleSidebarSurfaceContextMenu}
+ >
<SidebarContent>
{cover ? null : <ConflictsSection />}
- {}
- {
- <Collapsible
- open={filesOpen}
- onOpenChange={setFilesOpen}
- className="group/files flex min-h-0 flex-col data-[state=open]:min-h-48 data-[state=open]:flex-1"
- >
- <SidebarGroup className="min-h-0 flex-1 px-0 pt-0">
- {}
- <SidebarGroupLabel
- data-sidebar-project-row=""
+ <Collapsible
+ open={filesOpen}
+ onOpenChange={setFilesOpen}
+ className="group/files flex min-h-0 flex-col data-[state=open]:min-h-48 data-[state=open]:flex-1"
+ >
+ <SidebarGroup className="min-h-0 flex-1 px-0 pt-0">
+ <SidebarGroupLabel
+ data-sidebar-project-row=""
+ className={cn(
+ 'h-11 shrink-0 gap-1 rounded-none',
+ cover && 'sticky top-0 z-10 bg-sidebar',
+ )}
+ >
+ {cover ? (
+ <Button
+ data-files-back=""
+ variant="ghost"
+ size="icon-sm"
+ aria-label={t`Back to editor`}
+ title={t`Back to editor`}
+ onClick={() => dismissCover()}
+ onKeyDown={(event) => {
+ if (event.key !== 'Escape' || isOverlayLayerOpen()) return;
+ event.preventDefault();
+ dismissCover();
+ }}
+ >
+ <ChevronLeft aria-hidden="true" />
+ </Button>
+ ) : null}
+ <CollapsibleTrigger
+ data-sidebar-root-context
+ className="flex min-w-0 flex-1 items-center gap-1.5"
+ >
+ <ChevronRight className="size-4 shrink-0 text-tree-muted transition-transform group-data-[state=open]/files:rotate-90" />
+ <span className="truncate text-sm font-normal text-muted-foreground">
+ {projectName}
+ </span>
+ </CollapsibleTrigger>
+ {/* biome-ignore lint/a11y/useSemanticElements: same call as ui/button-group — a toolbar cluster is not a form-control set, so the semantic alternative would impose form-field semantics and chrome. */}
+ <div
+ role="group"
+ aria-label={t`Files toolbar`}
+ data-testid="sidebar-toolbar"
className={cn(
- 'h-11 shrink-0 gap-1 rounded-none',
- cover && 'sticky top-0 z-10 bg-sidebar',
+ 'flex items-center gap-0.5',
+ isElectronHost && '[&>*]:[-webkit-app-region:no-drag]',
)}
>
- {cover ? (
- <Button
- data-files-back=""
- variant="ghost"
- size="icon-sm"
- aria-label={t`Back to editor`}
- title={t`Back to editor`}
- onClick={() => dismissCover()}
- onKeyDown={(event) => {
- if (event.key !== 'Escape' || isOverlayLayerOpen()) return;
- event.preventDefault();
- dismissCover();
- }}
- >
- <ChevronLeft aria-hidden="true" />
- </Button>
- ) : null}
- <CollapsibleTrigger
- data-sidebar-root-context
- className="flex min-w-0 flex-1 items-center gap-1.5"
- >
- <ChevronRight className="size-4 shrink-0 text-tree-muted transition-transform group-data-[state=open]/files:rotate-90" />
- <span className="truncate text-sm font-normal text-muted-foreground">
- {projectName}
- </span>
- </CollapsibleTrigger>
- {/* biome-ignore lint/a11y/useSemanticElements: same call as ui/button-group — a toolbar cluster is not a form-control set, so the semantic alternative would impose form-field semantics and chrome. */}
- <div
- role="group"
- aria-label={t`Files toolbar`}
- data-testid="sidebar-toolbar"
- className={cn(
- 'flex items-center gap-0.5',
- isElectronHost && '[&>*]:[-webkit-app-region:no-drag]',
- )}
- >
- {}
- <DropdownMenu>
- <ToolbarDropdownTrigger
- icon={ListCollapse}
- label={t`Tree view options`}
- />
- {sidebarState === 'expanded' ? (
- <DropdownMenuContent
- align="end"
- className="min-w-52"
- data-testid="tree-options-menu"
- onCloseAutoFocus={(event) => {
- if (!suppressTreeMenuFocusRestoreRef.current) return;
- suppressTreeMenuFocusRestoreRef.current = false;
- event.preventDefault();
- }}
- >
- {showExpandAll ? (
- <DropdownMenuItem onSelect={() => tree?.expandAll()}>
- <UnfoldVertical aria-hidden="true" />
- <Trans>Expand all</Trans>
- </DropdownMenuItem>
- ) : null}
- {showCollapseAll ? (
- <DropdownMenuItem onSelect={() => tree?.collapseAll()}>
- <FoldVertical aria-hidden="true" />
- <Trans>Collapse all</Trans>
- </DropdownMenuItem>
- ) : null}
- {showTreeStateSection ? <DropdownMenuSeparator /> : null}
- {}
- <SettingsLoadingMenuGroupTooltip reason={pendingSettingsReason}>
- <DropdownMenuGroup aria-label={t`Show`}>
- <DropdownMenuLabel>
- <Trans>Show</Trans>
- </DropdownMenuLabel>
- <DropdownMenuCheckboxItem
- checked={showHiddenFiles}
- onCheckedChange={(checked) =>
- patchSidebarVisibility({ showHiddenFiles: checked })
- }
- aria-disabled={pendingSettingsReason ? true : undefined}
- onSelect={preventPendingSettingsSelection}
- aria-describedby={
- pendingSettingsReason ? settingsLoadingReasonId : undefined
- }
- data-testid="tree-options-show-hidden-files"
- >
- <Trans>Hidden files</Trans>
- </DropdownMenuCheckboxItem>
- <DropdownMenuCheckboxItem
- checked={showOkFolders}
- onCheckedChange={(checked) =>
- patchSidebarVisibility({ showOkFolders: checked })
- }
- aria-disabled={pendingSettingsReason ? true : undefined}
- onSelect={preventPendingSettingsSelection}
- aria-describedby={
- pendingSettingsReason ? settingsLoadingReasonId : undefined
- }
- data-testid="tree-options-show-ok-folders"
- >
- <Trans>.ok folders</Trans>
- </DropdownMenuCheckboxItem>
- <DropdownMenuCheckboxItem
- checked={showOnlyMarkdownFiles}
- onCheckedChange={(checked) =>
- patchSidebarVisibility({ showOnlyMarkdownFiles: checked })
- }
- aria-disabled={pendingSettingsReason ? true : undefined}
- onSelect={preventPendingSettingsSelection}
- aria-describedby={
- pendingSettingsReason ? settingsLoadingReasonId : undefined
- }
- data-testid="tree-options-show-only-markdown-files"
- >
- <Trans>Only markdown files</Trans>
- </DropdownMenuCheckboxItem>
- <DropdownMenuCheckboxItem
- checked={showSkillsSection}
- onCheckedChange={(checked) =>
- patchSidebarVisibility({ showSkillsSection: checked })
- }
- aria-disabled={pendingSettingsReason ? true : undefined}
- onSelect={preventPendingSettingsSelection}
- aria-describedby={
- pendingSettingsReason ? settingsLoadingReasonId : undefined
- }
- data-testid="tree-options-show-skills"
- >
- <Trans>Skills Studio</Trans>
- </DropdownMenuCheckboxItem>
- </DropdownMenuGroup>
- </SettingsLoadingMenuGroupTooltip>
- {}
- {showSkillsSection ? (
- <>
- <DropdownMenuSeparator />
- <SettingsLoadingMenuGroupTooltip reason={pendingSettingsReason}>
- <DropdownMenuGroup>
- <DropdownMenuCheckboxItem
- checked={showSkillGroups}
- onCheckedChange={(checked) =>
- patchSidebarVisibility({ showSkillGroups: checked })
- }
- aria-disabled={pendingSettingsReason ? true : undefined}
- onSelect={preventPendingSettingsSelection}
- aria-describedby={
- pendingSettingsReason
- ? settingsLoadingReasonId
- : undefined
- }
- data-testid="tree-options-group-skills"
- >
- <Trans>Group skills by source</Trans>
- </DropdownMenuCheckboxItem>
- </DropdownMenuGroup>
- </SettingsLoadingMenuGroupTooltip>
- </>
- ) : null}
- <DropdownMenuSeparator />
- <DropdownMenuGroup>
- <DropdownMenuItem
- data-files-hide=""
- onSelect={() => {
- suppressTreeMenuFocusRestoreRef.current = true;
- setOpen(false);
- dismissCover();
- }}
+ <DropdownMenu>
+ <ToolbarDropdownTrigger icon={ListCollapse} label={t`Tree view options`} />
+ {sidebarState === 'expanded' ? (
+ <DropdownMenuContent
+ align="end"
+ className="min-w-52"
+ data-testid="tree-options-menu"
+ onCloseAutoFocus={(event) => {
+ if (!suppressTreeMenuFocusRestoreRef.current) return;
+ suppressTreeMenuFocusRestoreRef.current = false;
+ event.preventDefault();
+ }}
+ >
+ {showExpandAll ? (
+ <DropdownMenuItem onSelect={() => tree?.expandAll()}>
+ <UnfoldVertical aria-hidden="true" />
+ <Trans>Expand all</Trans>
+ </DropdownMenuItem>
+ ) : null}
+ {showCollapseAll ? (
+ <DropdownMenuItem onSelect={() => tree?.collapseAll()}>
+ <FoldVertical aria-hidden="true" />
+ <Trans>Collapse all</Trans>
+ </DropdownMenuItem>
+ ) : null}
+ {showTreeStateSection ? <DropdownMenuSeparator /> : null}
+ <SettingsLoadingMenuGroupTooltip reason={pendingSettingsReason}>
+ <DropdownMenuGroup aria-label={t`Show`}>
+ <DropdownMenuLabel>
+ <Trans>Show</Trans>
+ </DropdownMenuLabel>
+ <DropdownMenuCheckboxItem
+ checked={showHiddenFiles}
+ onCheckedChange={(checked) =>
+ patchSidebarVisibility({ showHiddenFiles: checked })
+ }
+ aria-disabled={pendingSettingsReason ? true : undefined}
+ onSelect={preventPendingSettingsSelection}
+ aria-describedby={
+ pendingSettingsReason ? settingsLoadingReasonId : undefined
+ }
+ data-testid="tree-options-show-hidden-files"
>
- <PanelLeftClose aria-hidden="true" />
- <Trans>Hide Files</Trans>
- </DropdownMenuItem>
+ <Trans>Hidden files</Trans>
+ </DropdownMenuCheckboxItem>
+ <DropdownMenuCheckboxItem
+ checked={showOkFolders}
+ onCheckedChange={(checked) =>
+ patchSidebarVisibility({ showOkFolders: checked })
+ }
+ aria-disabled={pendingSettingsReason ? true : undefined}
+ onSelect={preventPendingSettingsSelection}
+ aria-describedby={
+ pendingSettingsReason ? settingsLoadingReasonId : undefined
+ }
+ data-testid="tree-options-show-ok-folders"
+ >
+ <Trans>.ok folders</Trans>
+ </DropdownMenuCheckboxItem>
+ <DropdownMenuCheckboxItem
+ checked={showOnlyMarkdownFiles}
+ onCheckedChange={(checked) =>
+ patchSidebarVisibility({ showOnlyMarkdownFiles: checked })
+ }
+ aria-disabled={pendingSettingsReason ? true : undefined}
+ onSelect={preventPendingSettingsSelection}
+ aria-describedby={
+ pendingSettingsReason ? settingsLoadingReasonId : undefined
+ }
+ data-testid="tree-options-show-only-markdown-files"
+ >
+ <Trans>Only markdown files</Trans>
+ </DropdownMenuCheckboxItem>
+ <DropdownMenuCheckboxItem
+ checked={showSkillsSection}
+ onCheckedChange={(checked) =>
+ patchSidebarVisibility({ showSkillsSection: checked })
+ }
+ aria-disabled={pendingSettingsReason ? true : undefined}
+ onSelect={preventPendingSettingsSelection}
+ aria-describedby={
+ pendingSettingsReason ? settingsLoadingReasonId : undefined
+ }
+ data-testid="tree-options-show-skills"
+ >
+ <Trans>Skills Studio</Trans>
+ </DropdownMenuCheckboxItem>
</DropdownMenuGroup>
- </DropdownMenuContent>
- ) : null}
- </DropdownMenu>
- <ToolbarButton
- icon={SquarePen}
- label={t`New file`}
- onClick={() => tree?.startCreating('file', initialCreateDir)}
- shortcutId="new-item"
- />
- {activeFolderHasTemplates ? (
- <DropdownMenu>
- <ToolbarDropdownTrigger icon={FilePlus} label={t`New from template`} />
- <DropdownMenuContent
- align="end"
- className="min-w-52"
- onCloseAutoFocus={handleCreateMenuCloseAutoFocus}
- >
- <TemplateMenuRows
- parentDir={initialCreateDir}
- onSelectTemplate={(templateName) => {
- suppressCreateMenuFocusRestoreRef.current = true;
- tree?.createFromTemplate(initialCreateDir, templateName);
+ </SettingsLoadingMenuGroupTooltip>
+ {showSkillsSection ? (
+ <>
+ <DropdownMenuSeparator />
+ <SettingsLoadingMenuGroupTooltip reason={pendingSettingsReason}>
+ <DropdownMenuGroup>
+ <DropdownMenuCheckboxItem
+ checked={showSkillGroups}
+ onCheckedChange={(checked) =>
+ patchSidebarVisibility({ showSkillGroups: checked })
+ }
+ aria-disabled={pendingSettingsReason ? true : undefined}
+ onSelect={preventPendingSettingsSelection}
+ aria-describedby={
+ pendingSettingsReason ? settingsLoadingReasonId : undefined
+ }
+ data-testid="tree-options-group-skills"
+ >
+ <Trans>Group skills by source</Trans>
+ </DropdownMenuCheckboxItem>
+ </DropdownMenuGroup>
+ </SettingsLoadingMenuGroupTooltip>
+ </>
+ ) : null}
+ <DropdownMenuSeparator />
+ <DropdownMenuGroup>
+ <DropdownMenuItem
+ data-files-hide=""
+ onSelect={() => {
+ suppressTreeMenuFocusRestoreRef.current = true;
+ setOpen(false);
+ dismissCover();
}}
- ItemComponent={DropdownMenuItem}
- />
- </DropdownMenuContent>
- </DropdownMenu>
+ >
+ <PanelLeftClose aria-hidden="true" />
+ <Trans>Hide Files</Trans>
+ </DropdownMenuItem>
+ </DropdownMenuGroup>
+ </DropdownMenuContent>
) : null}
- <ToolbarButton
- icon={FolderPlus}
- label={t`New folder`}
- onClick={() => tree?.startCreating('folder', initialCreateDir)}
- shortcutId={isElectronHost ? 'new-folder' : undefined}
- />
- </div>
- </SidebarGroupLabel>
- <CollapsibleContent className="flex min-h-0 flex-1 flex-col overflow-hidden">
- <FileTree ref={setTree} />
- </CollapsibleContent>
- </SidebarGroup>
- </Collapsible>
- }
- {}
+ </DropdownMenu>
+ <ToolbarButton
+ icon={SquarePen}
+ label={t`New file`}
+ onClick={() => tree?.startCreating('file', initialCreateDir)}
+ shortcutId="new-item"
+ />
+ {activeFolderHasTemplates ? (
+ <DropdownMenu>
+ <ToolbarDropdownTrigger icon={FilePlus} label={t`New from template`} />
+ <DropdownMenuContent
+ align="end"
+ className="min-w-52"
+ onCloseAutoFocus={handleCreateMenuCloseAutoFocus}
+ >
+ <TemplateMenuRows
+ parentDir={initialCreateDir}
+ onSelectTemplate={(templateName) => {
+ suppressCreateMenuFocusRestoreRef.current = true;
+ tree?.createFromTemplate(initialCreateDir, templateName);
+ }}
+ ItemComponent={DropdownMenuItem}
+ />
+ </DropdownMenuContent>
+ </DropdownMenu>
+ ) : null}
+ <ToolbarButton
+ icon={FolderPlus}
+ label={t`New folder`}
+ onClick={() => tree?.startCreating('folder', initialCreateDir)}
+ shortcutId={isElectronHost ? 'new-folder' : undefined}
+ />
+ </div>
+ </SidebarGroupLabel>
+ <CollapsibleContent className="flex min-h-0 flex-1 flex-col overflow-hidden">
+ <FileTree ref={setTree} />
+ </CollapsibleContent>
+ </SidebarGroup>
+ </Collapsible>
{cover ? <ConflictsSection /> : null}
{showSkillsSection ? <SkillsSidebarDock filesOpen={filesOpen} /> : null}
</SidebarContent>
<SidebarFooter className="px-0 empty:hidden">
<OnboardingCardMount />
</SidebarFooter>
- {}
<SidebarRail
enableToggle={false}
enableDrag={!(isEmbedded && sidebarState === 'collapsed')}
@@ -854,7 +834,6 @@ function FileSidebarInner() {
</div>
</ContextMenuTrigger>
<ContextMenuContent className="min-w-52" onCloseAutoFocus={handleCreateMenuCloseAutoFocus}>
- {}
<ContextMenuItem
disabled={!workspace}
onSelect={handleEmptySpaceCreateFile}
diff --git a/packages/app/src/components/FileTree.preview-tabs.dom.test.tsx b/packages/app/src/components/FileTree.preview-tabs.dom.test.tsx
index 6194a5098..e5fd2a557 100644
--- a/packages/app/src/components/FileTree.preview-tabs.dom.test.tsx
+++ b/packages/app/src/components/FileTree.preview-tabs.dom.test.tsx
@@ -261,7 +261,6 @@ vi.doMock('@pierre/trees/react', () => ({
onClickCapture={onClickCapture}
onDoubleClickCapture={onDoubleClickCapture}
>
- {}
<div
role="treeitem"
aria-label="note.md"
@@ -271,7 +270,6 @@ vi.doMock('@pierre/trees/react', () => ({
tabIndex={-1}
>
note.md
- {}
<input data-testid="rename-input" defaultValue="note.md" />
</div>
<div
@@ -283,7 +281,6 @@ vi.doMock('@pierre/trees/react', () => ({
>
docs/
</div>
- {}
<div
data-testid="sticky-docs"
data-item-path="docs/"
diff --git a/packages/app/src/components/FileTree.showall-lazy.dom.test.tsx b/packages/app/src/components/FileTree.showall-lazy.dom.test.tsx
index a01860217..134053bc5 100644
--- a/packages/app/src/components/FileTree.showall-lazy.dom.test.tsx
+++ b/packages/app/src/components/FileTree.showall-lazy.dom.test.tsx
@@ -266,7 +266,7 @@ vi.doMock('@pierre/trees/react', () => ({
<div data-testid="fake-pierre-tree" role="tree" onClickCapture={onClickCapture}>
{header}
{[...model.items.values()].map((item) => (
- // biome-ignore lint/a11y/useKeyWithClickEvents: stub row standing in for Pierre's own row button; the keyboard path lives in the real library.
+ // oxlint-disable-next-line jsx-a11y/click-events-have-key-events -- stub row standing in for Pierre's own row button; the keyboard path lives in the real library.
<div
key={item.path}
role="treeitem"
diff --git a/packages/app/src/components/FileTree.tsx b/packages/app/src/components/FileTree.tsx
index 6d068333d..7f0e2bffe 100644
--- a/packages/app/src/components/FileTree.tsx
+++ b/packages/app/src/components/FileTree.tsx
@@ -1,5 +1,4 @@
// oxlint-disable ok/no-raw-error-toast -- pre-rule backlog: toasts here show raw error text; delete this line once the file maps each failure to written copy. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-raw-error-toast
-// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
import type { OkignoreBinding } from '@inkeep/open-knowledge-core/config/bind-okignore-doc';
import { isDocumentOverOpenByteLimit } from '@inkeep/open-knowledge-core/constants/document-open';
@@ -3158,7 +3157,6 @@ export function FileTree({ ref }: { ref?: Ref<FileTreeHandle | null> }) {
error && (
<>
<FileTreeHeaderNotice kind="error">{error}</FileTreeHeaderNotice>
- {}
{serverUnreachable ? <RestartServerButton className="mx-2 mb-1" /> : null}
</>
)
diff --git a/packages/app/src/components/FolderPropertiesCard.tsx b/packages/app/src/components/FolderPropertiesCard.tsx
index a1ed94c09..38edb0503 100644
--- a/packages/app/src/components/FolderPropertiesCard.tsx
+++ b/packages/app/src/components/FolderPropertiesCard.tsx
@@ -185,9 +185,7 @@ export function FolderPropertiesCard({ folderPath, state, onChange }: Props) {
/>
<Trans>Folder properties</Trans>
</span>
- {}
- {/* biome-ignore lint/a11y/useKeyWithClickEvents: <code> is non-focusable; keyboard activation lives on the wrapping <button>. */}
- <code
+ <code // oxlint-disable-line jsx-a11y/click-events-have-key-events -- <code> is non-focusable; keyboard activation lives on the wrapping <button>.
className="text-xs text-muted-foreground font-mono cursor-text select-text break-all"
onClick={(e) => e.stopPropagation()}
>
diff --git a/packages/app/src/components/FrontmatterRow.tsx b/packages/app/src/components/FrontmatterRow.tsx
index f6038eaf8..a2dbd21c3 100644
--- a/packages/app/src/components/FrontmatterRow.tsx
+++ b/packages/app/src/components/FrontmatterRow.tsx
@@ -117,7 +117,6 @@ export function FrontmatterRow({
>
{(dragHandle) => (
<>
- {}
<div className="flex items-start gap-1 @max-[26rem]/prow:flex-wrap">
{dragHandle}
<div className="flex items-center gap-1" data-testid="property-row-identity">
@@ -539,7 +538,6 @@ export function AddPropertyRow({
ref={valueCellRef}
className="min-w-0 flex-1 @max-[26rem]/prow:order-last @max-[26rem]/prow:mt-0.5 @max-[26rem]/prow:basis-full @max-[26rem]/prow:pl-[2rem]"
>
- {}
{enumConstraint && !enumConstraint.multi ? (
<EnumSelectWidget
keyName="__add__"
diff --git a/packages/app/src/components/GraphPanel.tsx b/packages/app/src/components/GraphPanel.tsx
index b197bcad3..e3389e435 100644
--- a/packages/app/src/components/GraphPanel.tsx
+++ b/packages/app/src/components/GraphPanel.tsx
@@ -456,11 +456,11 @@ export function GraphPanel({
isExpanded && isElectronHost && '[-webkit-app-region:drag]',
)}
>
- {/**
- * The fullscreen chrome row reserves the macOS traffic-light footprint via
- * `--ok-titlebar-reserve-left` (precedent #49).
- */}
<div
+ /**
+ * The fullscreen chrome row reserves the macOS traffic-light footprint via
+ * `--ok-titlebar-reserve-left` (precedent #49).
+ */
data-slot="graph-title-cluster"
className={cn('flex min-w-0 items-center gap-1.5', isExpanded && 'ml-4')}
>
diff --git a/packages/app/src/components/HelpPopover.tsx b/packages/app/src/components/HelpPopover.tsx
index 06d43e8c9..00302ba09 100644
--- a/packages/app/src/components/HelpPopover.tsx
+++ b/packages/app/src/components/HelpPopover.tsx
@@ -224,10 +224,8 @@ export const HelpPopover: FC = () => {
}
/>
))}
- {}
{section.key === 'resources' && (
<>
- {}
{hasDesktopBridge && (
<ActionRow
icon={Bug}
@@ -287,7 +285,6 @@ export const HelpPopover: FC = () => {
<Trans>Subscribe</Trans>
</Button>
</PopoverTrigger>
- {}
<PopoverContent side="left" align="center" sideOffset={20} className="w-80">
<SubscribeForm
source="resources_menu"
@@ -325,7 +322,6 @@ export const HelpPopover: FC = () => {
) : null}
</PopoverContent>
</Popover>
- {}
{hasDesktopBridge && (
<ReportBugDialog capture={bugReport.capture} onClose={bugReport.close} />
)}
diff --git a/packages/app/src/components/ImageAttachments.tsx b/packages/app/src/components/ImageAttachments.tsx
index 5c46d0855..cd5171821 100644
--- a/packages/app/src/components/ImageAttachments.tsx
+++ b/packages/app/src/components/ImageAttachments.tsx
@@ -275,8 +275,7 @@ export function ImageAttachmentTextarea({
const problemMessage = useImageAttachmentProblemMessage();
return (
<div className="flex min-w-0 flex-col gap-2">
- {/* biome-ignore lint/a11y/noStaticElementInteractions: file drop target only; keyboard users paste or use the attach button. */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- file drop target only; keyboard users paste or use the attach button.
className="relative"
onDragOver={intake.onDragOver}
onDragLeave={intake.onDragLeave}
diff --git a/packages/app/src/components/ImportSkillDialog.tsx b/packages/app/src/components/ImportSkillDialog.tsx
index 01cad3e48..066a81b65 100644
--- a/packages/app/src/components/ImportSkillDialog.tsx
+++ b/packages/app/src/components/ImportSkillDialog.tsx
@@ -30,7 +30,6 @@ export function ImportSkillDialog({
}: Props) {
return (
<Dialog open={open} onOpenChange={onOpenChange}>
- {}
<DialogContent className="flex max-h-[85vh] flex-col gap-4 sm:max-w-4xl">
<DialogHeader>
<DialogTitle>
@@ -40,7 +39,6 @@ export function ImportSkillDialog({
<Trans>Browse or upload a skill for this project.</Trans>
</DialogDescription>
</DialogHeader>
- {}
<Tabs defaultValue={defaultTab} className="flex min-h-0 flex-1 flex-col gap-3">
<TabsList variant="line" className="w-full justify-start gap-4 border-b p-0">
<TabsTrigger variant="line" value="skills-sh">
@@ -50,11 +48,9 @@ export function ImportSkillDialog({
<Trans>Upload</Trans>
</TabsTrigger>
</TabsList>
- {}
<TabsContent value="skills-sh" className="h-[62vh] min-h-0 flex-none">
<ExploreSkills scope={defaultScope} onNavigate={() => onOpenChange(false)} />
</TabsContent>
- {}
<TabsContent value="upload" className="mt-3 flex min-h-0 flex-1 flex-col gap-6">
<ImportSkillForm
defaultScope={defaultScope}
diff --git a/packages/app/src/components/ImportSkillForm.tsx b/packages/app/src/components/ImportSkillForm.tsx
index 82e575d62..ab9737a37 100644
--- a/packages/app/src/components/ImportSkillForm.tsx
+++ b/packages/app/src/components/ImportSkillForm.tsx
@@ -180,7 +180,6 @@ export function ImportSkillForm({
<Label id={sourceGroupId}>
<Trans>Source</Trans>
</Label>
- {}
<RadioGroup
value={source}
onValueChange={(v) => {
@@ -256,7 +255,6 @@ export function ImportSkillForm({
</RadioGroup>
{isUpload ? (
<>
- {}
<Input
key={source}
ref={inputRef}
@@ -311,7 +309,6 @@ export function ImportSkillForm({
placeholder={t`owner/repo, a git URL, or a local path`}
className="font-mono"
/>
- {}
{discovering || discoverMiss || (discovered && discovered.length === 1) ? (
<p className="text-1sm text-muted-foreground">
{discovering ? (
@@ -355,7 +352,6 @@ export function ImportSkillForm({
</p>
</div>
) : null}
- {}
<div role="note" className="space-y-3" data-testid="skill-import-disclosure">
<p className="font-medium text-xs font-mono text-muted-foreground/80 uppercase tracking-wider">
<Trans>What happens next</Trans>
diff --git a/packages/app/src/components/InstallInClaudeDesktopDialog.tsx b/packages/app/src/components/InstallInClaudeDesktopDialog.tsx
index 4a2172671..9c661c829 100644
--- a/packages/app/src/components/InstallInClaudeDesktopDialog.tsx
+++ b/packages/app/src/components/InstallInClaudeDesktopDialog.tsx
@@ -208,7 +208,6 @@ export function InstallInClaudeDesktopDialog({
<DialogBody>
<div className="flex flex-col gap-6 py-2">
- {}
{phase.kind === 'idle' && isElectron && (
<>
<div className="flex flex-col gap-2">
@@ -228,7 +227,6 @@ export function InstallInClaudeDesktopDialog({
</>
)}
- {}
{phase.kind === 'idle' && !isElectron && (
<>
<div className="flex flex-col gap-2">
@@ -268,7 +266,6 @@ export function InstallInClaudeDesktopDialog({
</>
)}
- {}
{phase.kind === 'downloading' && (
<div className="flex items-center gap-2 text-sm">
<Spinner aria-hidden="true" className="h-4 w-4" />
@@ -279,7 +276,6 @@ export function InstallInClaudeDesktopDialog({
</div>
)}
- {}
{phase.kind === 'handed-off' && isElectron && (
<>
<div className="flex items-start gap-2 rounded-md border border-primary/30 bg-primary/5 px-3 py-2">
@@ -297,7 +293,6 @@ export function InstallInClaudeDesktopDialog({
</>
)}
- {}
{phase.kind === 'handed-off' && !isElectron && (
<>
<div className="flex items-start gap-2 rounded-md border border-primary/30 bg-primary/5 px-3 py-2">
@@ -317,7 +312,6 @@ export function InstallInClaudeDesktopDialog({
</>
)}
- {}
{phase.kind === 'error' && (
<div className="flex flex-col gap-2 text-sm">
<span className="text-destructive">{phase.message}</span>
diff --git a/packages/app/src/components/LargeFileEditorState.tsx b/packages/app/src/components/LargeFileEditorState.tsx
index f091bcc57..9ae041338 100644
--- a/packages/app/src/components/LargeFileEditorState.tsx
+++ b/packages/app/src/components/LargeFileEditorState.tsx
@@ -50,7 +50,6 @@ export function LargeFileEditorState({ docName, size, limit, backNav }: LargeFil
<FileWarning className="size-9" aria-hidden="true" />
</EmptyMedia>
<EmptyHeader className="max-w-md gap-1">
- {}
<EmptyTitle asChild className="text-2xl font-normal outline-none">
<h2 ref={headingRef} id={titleId} tabIndex={canGoBack ? undefined : -1}>
<Trans>File too large to open</Trans>
diff --git a/packages/app/src/components/LintConfigEditor.tsx b/packages/app/src/components/LintConfigEditor.tsx
index 35fe20678..d544666dc 100644
--- a/packages/app/src/components/LintConfigEditor.tsx
+++ b/packages/app/src/components/LintConfigEditor.tsx
@@ -29,7 +29,6 @@ export function LintConfigEditor({ assetPath }: LintConfigEditorProps) {
return (
<div className="flex h-full min-h-0 flex-col bg-background" data-lint-config-editor="">
- {}
<NotInSidebarIndicator
entry={{ kind: 'asset', path: assetPath }}
className="shrink-0 border-b bg-background px-3 py-1.5"
@@ -57,7 +56,6 @@ export function LintConfigEditor({ assetPath }: LintConfigEditorProps) {
) : (
<div className="min-h-0 flex-1 overflow-y-auto px-4 py-4 sm:px-6">
<div className="mx-auto w-full max-w-3xl">
- {}
<MarkdownlintRuleBrowser hideConfigSourceNote />
</div>
</div>
diff --git a/packages/app/src/components/McpConsentDialogBody.tsx b/packages/app/src/components/McpConsentDialogBody.tsx
index ecb48f613..c6b222079 100644
--- a/packages/app/src/components/McpConsentDialogBody.tsx
+++ b/packages/app/src/components/McpConsentDialogBody.tsx
@@ -1,5 +1,3 @@
-// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
-
import { i18n } from '@lingui/core';
import { Trans, useLingui } from '@lingui/react/macro';
import { useTheme } from 'next-themes';
@@ -237,7 +235,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
return (
<Surface.Root open onOpenChange={onOpenChange}>
- {}
<Surface.Content
className={cn(
'sm:max-w-2xl md:max-w-3xl',
@@ -249,9 +246,7 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
>
<Surface.Header>
<Surface.Title className="flex flex-col gap-8 text-2xl tracking-tighter">
- {}
<OkIcon className="size-10 shrink-0" aria-hidden />
- {}
{firstRun ? (
<span className="flex flex-col gap-1.5">
<span className="uppercase font-mono font-normal text-2xs text-muted-foreground tracking-widest">
@@ -273,7 +268,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</Surface.Header>
<Surface.Body className="flex flex-col gap-6 min-h-0">
- {}
{pathInstall.shellDetected && (
<div className="flex flex-col gap-1.5">
<h3 className="text-sm font-medium text-foreground">
@@ -281,7 +275,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
Terminal
</Trans>
</h3>
- {}
<div
className={cn(
'relative overflow-hidden rounded-lg border border-border bg-card/50 px-4 py-3',
@@ -296,7 +289,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
: 'flex min-w-0 flex-col items-start gap-1 font-normal'
}
>
- {}
<span className="flex w-full items-center gap-2.5">
<Checkbox
id={`${idPrefix}-path`}
@@ -363,17 +355,14 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</div>
)}
- {}
{(hasEditors || skillsOffered) && (
<>
- {}
<div className="flex flex-col gap-1.5">
<h3 className="text-sm font-medium text-foreground">
<Trans comment="Section label above the AI-tools checkboxes in the first-launch dialog">
Connect your AI tools
</Trans>
</h3>
- {}
{hasEditors ? (
<p className={cn(SECTION_SUBTEXT, 'mb-1')}>
<Trans comment="Description under the AI-tools section label in the first-launch dialog">
@@ -406,16 +395,13 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</Trans>
</span>
</span>
- {}
<span className={ROW_SUBTEXT}>
- {}
<Trans comment="Subtext under the AI-tools MCP checkbox">
Adds an OpenKnowledge MCP entry to{' '}
<span className="font-medium text-foreground">{connectToolList}</span>,
so your agents can read and edit your files.
</Trans>
</span>
- {}
{showExistingStatus && (
<span className={ROW_SUBTEXT} data-testid="mcp-consent-connect-existing">
{t({
@@ -430,7 +416,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
className={ROW_WARNING}
data-testid="mcp-consent-connect-replace-warning"
>
- {}
{replacingAll
? t`Replaces the OpenKnowledge entry each of them already has.`
: t`Replaces the existing OpenKnowledge entry in ${formatToolList(
@@ -463,7 +448,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</div>
) : null}
- {}
{skillsOffered && (
<div className="relative overflow-hidden rounded-lg border border-border bg-card/50 px-4 py-3 hover:bg-accent">
<Label
@@ -516,7 +500,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</div>
)}
- {}
{!hasEditors && (
<p className={SECTION_SUBTEXT} data-testid="mcp-consent-no-tools">
<Trans comment="Shown in place of the AI-tools checkbox when no AI tool was detected; agentConnectionsLabel is the Settings sidebar pane name">
@@ -529,7 +512,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</div>
</>
)}
- {}
<div className="flex flex-col gap-1.5">
<h3 className="text-sm font-medium text-foreground">
<Trans comment="Section label above the light/dark/system cards in the first-launch dialog">
@@ -551,8 +533,6 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
</div>
</Surface.Body>
<Surface.Footer className="sm:justify-between">
- {}
- {}
{firstRun ? (
<AlertDialogCancel
variant="link-muted"
@@ -572,11 +552,9 @@ function McpConsentDialogForm({ payload, store, toast }: McpConsentDialogFormPro
data-testid="mcp-consent-skip"
onClick={onDismiss}
>
- {}
<Trans>Cancel</Trans>
</Button>
)}
- {}
<Button onClick={() => void onContinue()} disabled={busy} data-testid="mcp-consent-add">
{busy ? (
<Trans>Working</Trans>
diff --git a/packages/app/src/components/NavigatorApp.first-run.dom.test.tsx b/packages/app/src/components/NavigatorApp.first-run.dom.test.tsx
index 49c0e3b86..75fcaac93 100644
--- a/packages/app/src/components/NavigatorApp.first-run.dom.test.tsx
+++ b/packages/app/src/components/NavigatorApp.first-run.dom.test.tsx
@@ -104,7 +104,6 @@ vi.doMock('./CreateProjectDialog', () => ({
data-pack-id={props.initialPackId ?? ''}
data-pack-count={props.packs === undefined ? '' : String(props.packs.length)}
>
- {}
<button
type="button"
data-testid="create-dialog-close"
diff --git a/packages/app/src/components/NavigatorApp.tsx b/packages/app/src/components/NavigatorApp.tsx
index e2c6877b2..32ffc1102 100644
--- a/packages/app/src/components/NavigatorApp.tsx
+++ b/packages/app/src/components/NavigatorApp.tsx
@@ -252,7 +252,6 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
return (
<div className="relative flex h-screen w-screen flex-col overflow-hidden bg-primary-foreground dark:bg-background text-foreground">
- {}
<div
className={`pointer-events-none absolute inset-x-0 top-0 z-10 h-9 ${
isElectronHost ? '[-webkit-app-region:drag]' : ''
@@ -260,7 +259,6 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
data-electron-drag={isElectronHost ? '' : undefined}
data-testid="nav-chrome-row"
>
- {}
{shouldShowAppMenubar() && (
<div className="pointer-events-auto flex h-full items-center px-2">
<Suspense fallback={null}>
@@ -293,7 +291,6 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
</div>
</header>
- {}
<div className="shrink-0 space-y-6">
<section className="grid sm:grid-cols-2 gap-3">
<NavigatorCard
@@ -326,7 +323,6 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
/>
</section>
- {}
{!loading && !recentsLoadFailed && recents.length === 0 ? (
<StarterPackRow onPackSelect={onPackSelect} />
) : null}
@@ -384,10 +380,8 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
<NavigatorSettings />
</ConfigContext>
- {}
<McpConsentDialog />
- {}
<ConsentDialog />
<CreateProjectDialog
@@ -453,7 +447,6 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
}}
/>
- {}
<Suspense fallback={null}>
<ShareReceiveDialog
bridge={bridge}
@@ -612,7 +605,6 @@ function RecentRow({
className="h-auto min-w-0 flex-1 justify-between gap-3 py-3.5 pl-4 pr-2 text-left hover:bg-transparent"
>
<div className="flex min-w-0 items-center gap-3">
- {}
<Folder aria-hidden="true" className="size-[18px] shrink-0 text-muted-foreground" />
<div className="flex min-w-0 flex-col gap-1 truncate">
<div className="flex min-w-0 items-center gap-2">
diff --git a/packages/app/src/components/NewItemDialog.tsx b/packages/app/src/components/NewItemDialog.tsx
index 9dc95fba1..abe24dc99 100644
--- a/packages/app/src/components/NewItemDialog.tsx
+++ b/packages/app/src/components/NewItemDialog.tsx
@@ -258,7 +258,6 @@ export function NewItemDialog({
return (
<Dialog open={open} onOpenChange={onOpenChange}>
- {}
<DialogContent className="sm:max-w-md" data-ok-layer-spawned="">
<DialogHeader>
<DialogTitle>
@@ -276,7 +275,6 @@ export function NewItemDialog({
<DialogBody className="space-y-6 pb-1">
{showTemplatePicker && (
<div className="flex flex-col gap-2">
- {}
<span id={templatePickerLabelId} className="text-sm font-medium">
<Trans>Start from</Trans>
</span>
@@ -511,7 +509,6 @@ function TemplatePickerCombobox({
</CommandItem>
);
})}
- {}
<CommandItem
value="Blank note empty"
onSelect={() => {
diff --git a/packages/app/src/components/NewWorktreeDialog.tsx b/packages/app/src/components/NewWorktreeDialog.tsx
index 04bb1756a..275dd95f2 100644
--- a/packages/app/src/components/NewWorktreeDialog.tsx
+++ b/packages/app/src/components/NewWorktreeDialog.tsx
@@ -240,7 +240,6 @@ export function NewWorktreeDialog({
) : (
<Plus aria-hidden="true" className="mt-0.5 size-3.5 shrink-0 text-success" />
)}
- {}
<span className="min-w-0 flex-1">
{isExistingWorktree ? (
<Trans>
@@ -306,7 +305,6 @@ export function NewWorktreeDialog({
))}
</div>
) : null}
- {}
{!isCheckout ? (
<div className="mt-1 flex flex-col gap-2">
<Label id={baseLabelId} htmlFor={baseTriggerId}>
@@ -430,7 +428,6 @@ export function NewWorktreeDialog({
className="size-3.5 shrink-0 text-muted-foreground"
/>
<span className="min-w-0 flex-1 truncate text-left">{name}</span>
- {}
{behind !== undefined && behind > 0 ? (
<span
className="shrink-0 text-xs text-warning"
diff --git a/packages/app/src/components/NoteWindowDeletedState.tsx b/packages/app/src/components/NoteWindowDeletedState.tsx
index f14735446..97b81bb58 100644
--- a/packages/app/src/components/NoteWindowDeletedState.tsx
+++ b/packages/app/src/components/NoteWindowDeletedState.tsx
@@ -17,7 +17,6 @@ export function NoteWindowDeletedState({ docName }: { docName: string }) {
<h2 className="font-medium text-base text-foreground">
<Trans>This document was deleted</Trans>
</h2>
- {}
<p className="max-w-md break-all text-muted-foreground text-sm">
<UserText>{docName}</UserText>
</p>
diff --git a/packages/app/src/components/OkBlob.tsx b/packages/app/src/components/OkBlob.tsx
index 97d3d276b..e394bb9c2 100644
--- a/packages/app/src/components/OkBlob.tsx
+++ b/packages/app/src/components/OkBlob.tsx
@@ -263,16 +263,13 @@ export function OkBlob({
onClick={handleClick}
onMouseDown={(e) => e.preventDefault()}
>
- {}
<g
key={`body-${clickSeq}`}
className={cn('ok-blob-group', isSleeping && 'ok-blob-sleeping', bounceClass)}
>
<path d={MASCOT_OUTLINE_PATH} className="ok-blob-body" />
- {}
<g ref={eyesGroupRef}>
- {}
<ellipse
cx={LEFT_EYE_CX}
cy={EYE_CY}
@@ -291,7 +288,6 @@ export function OkBlob({
)}
/>
- {}
<path
d={happyEyeArc(LEFT_EYE_CX, activeLevel)}
strokeWidth="1.2"
@@ -313,7 +309,6 @@ export function OkBlob({
)}
/>
- {}
{isSleeping ? (
<>
<path
@@ -335,7 +330,6 @@ export function OkBlob({
</g>
</g>
- {}
{isSleeping ? (
<g>
<text x={21} y={7} className="ok-blob-z ok-blob-z-1">
@@ -347,7 +341,6 @@ export function OkBlob({
</g>
) : null}
- {}
{particles.length > 0 && (
<g key={`firework-${burstSeq}`} data-slot="ok-blob-burst">
{particles.map((p) => (
diff --git a/packages/app/src/components/OkBlobRunner.tsx b/packages/app/src/components/OkBlobRunner.tsx
index 974afcf37..865940243 100644
--- a/packages/app/src/components/OkBlobRunner.tsx
+++ b/packages/app/src/components/OkBlobRunner.tsx
@@ -238,7 +238,6 @@ export function OkBlobRunner({ autoStart = false }: OkBlobRunnerProps = {}) {
))}
</div>
- {}
<div className="relative mt-1.5 h-5">
<div
data-slot="ok-blob-runner-score"
diff --git a/packages/app/src/components/OkBlobRunnerPage.tsx b/packages/app/src/components/OkBlobRunnerPage.tsx
index 11d092e1c..bd7325635 100644
--- a/packages/app/src/components/OkBlobRunnerPage.tsx
+++ b/packages/app/src/components/OkBlobRunnerPage.tsx
@@ -27,7 +27,6 @@ export function OkBlobRunnerPage({ autoStart = false }: OkBlobRunnerPageProps =
<Trans>Space to jump, down arrow to duck. That is the whole game.</Trans>
</p>
</div>
- {}
<div className="w-full">
<OkBlobRunner autoStart={autoStart} />
</div>
diff --git a/packages/app/src/components/OnboardingCard.tsx b/packages/app/src/components/OnboardingCard.tsx
index 48c4114c6..6f49ff9c8 100644
--- a/packages/app/src/components/OnboardingCard.tsx
+++ b/packages/app/src/components/OnboardingCard.tsx
@@ -88,7 +88,6 @@ export function OnboardingCard({
return (
<>
- {}
<div className="sr-only" role="status" aria-live="polite">
{allComplete ? t`You're all set up!` : ''}
</div>
@@ -104,7 +103,6 @@ export function OnboardingCard({
: 'animate-in fade-in-0 zoom-in-95 duration-300',
)}
>
- {}
<OkBlob size={36} celebrateSignal={celebrateSignal} />
<span className="font-medium text-sm">
<Trans>You're all set up!</Trans>
diff --git a/packages/app/src/components/PackCardGrid.tsx b/packages/app/src/components/PackCardGrid.tsx
index 170d5f974..78767c84f 100644
--- a/packages/app/src/components/PackCardGrid.tsx
+++ b/packages/app/src/components/PackCardGrid.tsx
@@ -133,7 +133,6 @@ export function PackCardGrid({
return (
<div className={cn('@container/packgrid w-full max-w-5xl', className)}>
- {}
<Collapsible open={expanded} onOpenChange={setExpanded}>
<div className={gridClassName}>
{visiblePacks.map((pack) => (
@@ -209,12 +208,10 @@ function PackCard({ pack, onSelect }: PackCardProps) {
</p>
</div>
- {}
<span
data-slot="pack-card-reveal"
className="pointer-events-none absolute inset-0 flex items-center justify-center gap-1.5 rounded-[inherit] bg-card/85 text-sm font-medium text-muted-foreground opacity-0 transition-opacity duration-200 ease-out-strong group-hover:opacity-100 group-focus-visible:opacity-100 supports-backdrop-filter:bg-card/35 supports-backdrop-filter:backdrop-blur-md reduced-transparency:bg-card"
>
- {}
<span className="inline-flex items-center gap-1.5 motion-safe:translate-y-1 motion-safe:transition-[translate] motion-safe:duration-200 motion-safe:ease-out-strong motion-safe:group-hover:translate-y-0 motion-safe:group-focus-visible:translate-y-0">
<Trans>See what's added</Trans>
<ArrowRight aria-hidden="true" className="size-3.5" />
@@ -228,7 +225,6 @@ function PackCard({ pack, onSelect }: PackCardProps) {
return (
<Tooltip>
<TooltipTrigger asChild>{card}</TooltipTrigger>
- {}
<TooltipContent className="flex-col items-start gap-1.5">
<ul className="flex flex-col gap-1.5 text-left">
{pack.folders.map((folder) => (
diff --git a/packages/app/src/components/PageHeader.tsx b/packages/app/src/components/PageHeader.tsx
index 9267d1652..2ceac2168 100644
--- a/packages/app/src/components/PageHeader.tsx
+++ b/packages/app/src/components/PageHeader.tsx
@@ -159,7 +159,6 @@ function CoverBanner({ cover, focalY, onCommitFocalY }: CoverBannerProps) {
return (
<div className="page-header-cover" data-testid="page-header-cover">
- {}
<div
ref={wrapperRef}
role="slider"
@@ -179,7 +178,6 @@ function CoverBanner({ cover, focalY, onCommitFocalY }: CoverBannerProps) {
data-testid="page-header-cover-slider"
data-dragging={dragY !== null || undefined}
>
- {}
<img
src={cover.value}
alt=""
diff --git a/packages/app/src/components/PageHeaderWidgets.tsx b/packages/app/src/components/PageHeaderWidgets.tsx
index c870d5e91..8358f9a04 100644
--- a/packages/app/src/components/PageHeaderWidgets.tsx
+++ b/packages/app/src/components/PageHeaderWidgets.tsx
@@ -145,7 +145,6 @@ export function PageCoverWidget({ keyName, value, onCommit }: CommonWidgetProps<
return (
<div className="flex w-full flex-col gap-1">
<div className="flex w-full items-center gap-2">
- {}
<input
type="text"
data-testid="page-cover-widget"
@@ -194,7 +193,6 @@ export function PageCoverWidget({ keyName, value, onCommit }: CommonWidgetProps<
<ImagePlus className="size-4" />
)}
</Button>
- {}
<button
type="button"
aria-label={t`Replace ${keyName}`}
@@ -220,7 +218,6 @@ export function PageCoverWidget({ keyName, value, onCommit }: CommonWidgetProps<
<X className="size-4" />
</Button>
) : null}
- {}
<input
ref={fileInputRef}
type="file"
diff --git a/packages/app/src/components/ProblemsPanel.tsx b/packages/app/src/components/ProblemsPanel.tsx
index 36cefe09e..1031d4311 100644
--- a/packages/app/src/components/ProblemsPanel.tsx
+++ b/packages/app/src/components/ProblemsPanel.tsx
@@ -184,7 +184,6 @@ function DiagnosticRowBody({
) : null}
</span>
<span className="flex items-center gap-1.5 ps-5 font-mono text-xs text-muted-foreground">
- {}
<Badge
variant="gray"
data-testid="problems-source-tag"
@@ -197,7 +196,6 @@ function DiagnosticRowBody({
{KindIcon !== null ? <KindIcon aria-hidden="true" className="size-2.5" /> : null}
{diagnostic.source}
</Badge>
- {}
<span className="min-w-0 truncate">
{grouped ? diagnostic.code : `${diagnostic.code} · ${t`line ${displayLine}`}`}
</span>
@@ -241,7 +239,6 @@ function DiagnosticGroupItem({
const actions = renderActions(first);
return (
<li className="group relative rounded transition-colors hover:bg-muted">
- {}
<button
type="button"
onClick={() => onNavigate(first)}
@@ -262,7 +259,6 @@ function DiagnosticGroupItem({
return (
<li className="rounded" data-testid="problems-duplicate-group">
<Collapsible>
- {}
<CollapsibleTrigger className="group flex w-full cursor-pointer flex-col gap-0.5 rounded px-2 py-1.5 text-left transition-colors hover:bg-muted">
<DiagnosticRowBody diagnostic={first} instanceCount={group.instances.length} />
</CollapsibleTrigger>
@@ -353,7 +349,6 @@ function ActionTooltip({
return (
<Tooltip>
<TooltipTrigger asChild>
- {}
<span className="inline-flex shrink-0">{children}</span>
</TooltipTrigger>
<TooltipContent data-testid={testId}>{tip}</TooltipContent>
@@ -702,7 +697,6 @@ export function ProblemsPanel({
{scope === 'doc' && sorted.length > 0 && <PanelCount>{sorted.length}</PanelCount>}
{showActivePluginsPill && (
<Tooltip>
- {}
<TooltipTrigger
className="shrink-0 cursor-default rounded-md bg-muted-foreground/5 px-2 py-1 font-mono text-xs text-muted-foreground"
data-testid="problems-active-plugins"
@@ -880,7 +874,6 @@ function ProjectAuditBody({
}
return (
<PanelBody className="px-2 py-2" data-testid="problems-project-scope">
- {}
<div className="flex flex-col gap-1 px-2 pb-1">
<div className="flex items-center justify-between gap-2">
<p
@@ -896,7 +889,6 @@ function ProjectAuditBody({
)}
</p>
<div className="flex shrink-0 items-center gap-1">
- {}
{loadedFiles.length > 0 ? (
<Tooltip>
<TooltipTrigger asChild>
@@ -926,7 +918,6 @@ function ProjectAuditBody({
</TooltipContent>
</Tooltip>
) : null}
- {}
<Tooltip>
<TooltipTrigger asChild>
<Button
@@ -948,13 +939,11 @@ function ProjectAuditBody({
</div>
</div>
<div className="flex flex-wrap items-center justify-end gap-1">
- {}
{fixing !== null ? (
<span className="sr-only" role="status">
{t`Fixing ${fixing.done} of ${fixing.total} files`}
</span>
) : null}
- {}
{fixing !== null ? (
<Tooltip>
<TooltipTrigger asChild>
diff --git a/packages/app/src/components/ProjectAiToolsField.tsx b/packages/app/src/components/ProjectAiToolsField.tsx
index ad49bae8e..4e249e96c 100644
--- a/packages/app/src/components/ProjectAiToolsField.tsx
+++ b/packages/app/src/components/ProjectAiToolsField.tsx
@@ -68,9 +68,7 @@ export function ProjectAiToolsField({
return (
<>
- {}
{statusRegion}
- {}
<div className="relative overflow-hidden rounded-lg border border-border bg-card/50 px-4 py-3 hover:bg-accent">
<Label
htmlFor={checkboxId}
@@ -84,7 +82,6 @@ export function ProjectAiToolsField({
disabled={disabled}
data-testid={`${testIdPrefix}-checkbox`}
/>
- {}
<span
className="flex min-w-0 flex-1 items-center gap-1.5 pe-28 text-sm font-medium text-foreground"
data-testid={`${testIdPrefix}-title`}
@@ -94,12 +91,10 @@ export function ProjectAiToolsField({
</Trans>
</span>
</span>
- {}
<span
className="text-1sm leading-normal ps-6.5 text-muted-foreground"
data-testid={`${testIdPrefix}-summary`}
>
- {}
<Trans comment="Subtext under the project AI-tools checkbox">
Adds an OpenKnowledge MCP entry and the project skill to{' '}
<span className="font-medium text-foreground">{toolList}</span>, so your agents can
@@ -108,7 +103,6 @@ export function ProjectAiToolsField({
</span>
</Label>
<RowDisclosure title={t`Adds these files`} testId={`${testIdPrefix}-details-toggle`}>
- {}
<ul className="flex flex-col gap-2" data-testid={`${testIdPrefix}-details`}>
{status.editors.map((id) => {
const configPath = STABLE_EDITOR_PROJECT_CONFIG_PATH[id];
diff --git a/packages/app/src/components/ProjectSwitcher.tsx b/packages/app/src/components/ProjectSwitcher.tsx
index 5e6b23420..c36db05a5 100644
--- a/packages/app/src/components/ProjectSwitcher.tsx
+++ b/packages/app/src/components/ProjectSwitcher.tsx
@@ -155,7 +155,6 @@ export function ProjectSwitcher({ bridge }: ProjectSwitcherProps) {
return (
<>
- {}
<DropdownMenu open={open} onOpenChange={handleOpenChange} modal={false}>
<DropdownMenuTrigger asChild>
<Button
@@ -201,14 +200,12 @@ export function ProjectSwitcher({ bridge }: ProjectSwitcherProps) {
className="min-w-[260px]"
data-testid="project-switcher-menu"
>
- {}
{recents === null ? null : recents.length === 0 ? (
<DropdownMenuLabel className="font-normal text-muted-foreground text-xs">
<Trans>No recent projects.</Trans>
</DropdownMenuLabel>
) : (
<>
- {}
<InputGroup className="mb-1 h-8 border-0 shadow-none has-[[data-slot=input-group-control]:focus-visible]:ring-0">
<InputGroupInput
aria-label={t`Search projects`}
@@ -226,7 +223,6 @@ export function ProjectSwitcher({ bridge }: ProjectSwitcherProps) {
</InputGroupAddon>
</InputGroup>
<DropdownMenuSeparator />
- {}
<div
className="max-h-64 overflow-x-hidden overflow-y-auto overscroll-contain subtle-scrollbar scroll-fade-mask"
data-testid="project-switcher-scroll"
@@ -291,7 +287,6 @@ export function ProjectSwitcher({ bridge }: ProjectSwitcherProps) {
<FileText aria-hidden="true" className="text-muted-foreground" />
<Trans>Open file</Trans>
</DropdownMenuItem>
- {}
{branch !== null ? (
<>
<DropdownMenuSeparator />
diff --git a/packages/app/src/components/PropertyDisclosure.tsx b/packages/app/src/components/PropertyDisclosure.tsx
index 85c150324..6c490bff9 100644
--- a/packages/app/src/components/PropertyDisclosure.tsx
+++ b/packages/app/src/components/PropertyDisclosure.tsx
@@ -47,7 +47,6 @@ export function PropertyDisclosure({
data-testid={testId}
>
<Collapsible open={open} onOpenChange={setOpen}>
- {}
<div className={cn('flex w-fit items-center gap-1.5', open && 'mb-1.5')}>
<CollapsibleTrigger asChild>
<Button
@@ -69,7 +68,6 @@ export function PropertyDisclosure({
</CollapsibleTrigger>
{typeof problemCount === 'number' && problemCount > 0 ? (
<Tooltip>
- {}
<TooltipTrigger
data-testid="property-problem-badge-trigger"
aria-label={t`${plural(problemCount, {
@@ -91,7 +89,6 @@ export function PropertyDisclosure({
</TooltipTrigger>
<TooltipContent side="bottom">
<span className="flex flex-col gap-0.5">
- {}
{problemMessages?.map((message, index) => (
// biome-ignore lint/suspicious/noArrayIndexKey: static within a render
<span key={index}>{message}</span>
diff --git a/packages/app/src/components/PropertyPanel.tsx b/packages/app/src/components/PropertyPanel.tsx
index e1f2264da..3fa97714c 100644
--- a/packages/app/src/components/PropertyPanel.tsx
+++ b/packages/app/src/components/PropertyPanel.tsx
@@ -463,7 +463,6 @@ export function PropertyPanel({ provider, reservedKeys, identitySlot }: Property
return (
<FrontmatterBindingProvider binding={binding}>
- {}
<CommentedDocProvider docName={docName === '' ? null : docName}>
<PropertyDisclosure
ref={panelRef}
@@ -493,7 +492,6 @@ export function PropertyPanel({ provider, reservedKeys, identitySlot }: Property
</div>
</div>
) : null}
- {}
{identitySlot}
<DndContext
sensors={sensors}
@@ -538,7 +536,6 @@ export function PropertyPanel({ provider, reservedKeys, identitySlot }: Property
})}
</SortableContext>
</DndContext>
- {}
{!reserved.has('tags') && !Object.hasOwn(map, 'tags') ? (
<FrontmatterRow
key="virtual-tags"
diff --git a/packages/app/src/components/PropertyWidgets.tsx b/packages/app/src/components/PropertyWidgets.tsx
index dc857398a..30a02de9f 100644
--- a/packages/app/src/components/PropertyWidgets.tsx
+++ b/packages/app/src/components/PropertyWidgets.tsx
@@ -345,7 +345,6 @@ export function DateWidget({ keyName, value, onCommit, onSubmit }: CommonWidgetP
</Button>
</PopoverTrigger>
<PopoverContent className="w-auto overflow-hidden p-0" align="end">
- {}
<Suspense fallback={<div className="h-[19rem] w-[17rem]" />}>
<Calendar
mode="single"
@@ -585,8 +584,11 @@ export function TypeIconButton({
return (
<Tooltip>
<TooltipTrigger asChild>
- {/* biome-ignore lint/a11y/noNoninteractiveTabindex: shadcn's tooltip-on-disabled-button pattern requires a focusable <span> wrapper so keyboard users can reach the tooltip — the inner <button disabled> is removed from tab order. https://ui.shadcn.com/docs/components/radix/tooltip#disabled-button */}
- <span tabIndex={0} className="inline-flex">
+ <span
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- shadcn's tooltip-on-disabled-button pattern requires a focusable <span> wrapper so keyboard users can reach the tooltip — the inner <button disabled> is removed from tab order. https://ui.shadcn.com/docs/components/radix/tooltip#disabled-button
+ tabIndex={0}
+ className="inline-flex"
+ >
<button
type="button"
disabled
diff --git a/packages/app/src/components/RecentProjectsMenu.tsx b/packages/app/src/components/RecentProjectsMenu.tsx
index 36e0e72e7..c720ab6db 100644
--- a/packages/app/src/components/RecentProjectsMenu.tsx
+++ b/packages/app/src/components/RecentProjectsMenu.tsx
@@ -390,9 +390,7 @@ function FlyoutGroup({
data-flyout-open={flyoutOpen ? 'true' : undefined}
data-current={containsCurrent ? 'true' : undefined}
>
- {}
<span className="flex min-w-0 flex-1 flex-col gap-0.5">
- {}
<span
className="truncate font-medium text-sm"
data-project-open={primaryIsOpenable ? '' : undefined}
@@ -413,7 +411,6 @@ function FlyoutGroup({
{group.primaryProject?.missing === true ? (
<MissingCheckoutStatus className="mt-0.5" />
) : null}
- {}
{openedWorktreeCount === null ? null : (
<span
className="mt-0.5 shrink-0 text-muted-foreground text-xs"
@@ -518,7 +515,6 @@ function WorktreeFlyout({
data-testid={`project-switcher-flyout-${group.project.path}`}
>
<InputGroup className="mb-1 h-8 shrink-0">
- {}
<InputGroupAddon align="inline-start">
<Search aria-hidden="true" />
</InputGroupAddon>
@@ -571,7 +567,6 @@ function WorktreeFlyout({
>
{q === '' ? t`No worktrees found.` : t`No matching worktrees or branches.`}
</DropdownMenuLabel>
- {}
{canCreate ? (
<DropdownMenuItem
onSelect={(e) => {
diff --git a/packages/app/src/components/ReportBugDialogBody.tsx b/packages/app/src/components/ReportBugDialogBody.tsx
index b34db282c..aa9bb522f 100644
--- a/packages/app/src/components/ReportBugDialogBody.tsx
+++ b/packages/app/src/components/ReportBugDialogBody.tsx
@@ -313,8 +313,10 @@ function ReportBugDialog({
<DialogContent className="gap-2 sm:max-w-[46.25rem]" onPaste={attachmentIntake.onPaste}>
{phase.step === 'compose' && (
<>
- {/* oxlint-disable-next-line ok/no-physical-direction-utility -- Matches the shared dialog close button's physical right-2 position, including RTL. */}
- <DialogHeader className="gap-2 pr-6">
+ <DialogHeader
+ // oxlint-disable-next-line ok/no-physical-direction-utility -- Matches the shared dialog close button's physical right-2 position, including RTL.
+ className="gap-2 pr-6"
+ >
<DialogTitle>
<Trans>Report a bug</Trans>
</DialogTitle>
@@ -338,7 +340,6 @@ function ReportBugDialog({
<p className="font-medium">
<Trans>OpenKnowledge quit unexpectedly last time.</Trans>
</p>
- {}
<DialogDescription className="mt-0.5 text-xs">
<Trans>
A report helps us find the cause. Nothing is sent until you review it.
@@ -436,8 +437,10 @@ function ReportBugDialog({
</Button>
</DialogTrigger>
<DialogContent className="sm:max-w-5xl">
- {/* oxlint-disable-next-line ok/no-physical-direction-utility -- Matches the shared dialog close button's physical right-2 position, including RTL. */}
- <DialogHeader className="pr-6">
+ <DialogHeader
+ // oxlint-disable-next-line ok/no-physical-direction-utility -- Matches the shared dialog close button's physical right-2 position, including RTL.
+ className="pr-6"
+ >
<DialogTitle>
<Trans>Screenshot preview</Trans>
</DialogTitle>
@@ -649,7 +652,6 @@ function ReportBugDialog({
ZIP before sending.
</Trans>
</p>
- {}
<div className="flex flex-col gap-2">
<div className="flex items-center gap-2.5">
<Checkbox
@@ -689,7 +691,6 @@ function ReportBugDialog({
</div>
)}
</div>
- {}
{crashInvite === undefined && crashContext === undefined ? (
<BugReportPreviousReports />
) : null}
diff --git a/packages/app/src/components/RowDisclosure.tsx b/packages/app/src/components/RowDisclosure.tsx
index 52ac3109c..41b632ac4 100644
--- a/packages/app/src/components/RowDisclosure.tsx
+++ b/packages/app/src/components/RowDisclosure.tsx
@@ -32,7 +32,6 @@ export function RowDisclosure({
aria-label={title}
className="max-h-(--radix-popover-content-available-height) w-96 max-w-(--radix-popover-content-available-width) overflow-y-auto p-3 subtle-scrollbar"
>
- {}
<div className="flex flex-col gap-2 text-xs leading-normal">
<span className="font-mono text-2xs text-muted-foreground uppercase tracking-wide">
{title}
diff --git a/packages/app/src/components/SchemaConfigEditor.tsx b/packages/app/src/components/SchemaConfigEditor.tsx
index 29104eece..63f7f88bf 100644
--- a/packages/app/src/components/SchemaConfigEditor.tsx
+++ b/packages/app/src/components/SchemaConfigEditor.tsx
@@ -1,5 +1,3 @@
-// oxlint-disable ok/no-physical-direction-utility -- pre-rule backlog — physical margin/padding/inset utilities predate the rule; drain by swapping ml/mr → ms/me, pl/pr → ps/pe, left/right → start/end, then deleting this line. See https://github.com/inkeep/open-knowledge/blob/main/lint-plugins/ok-rules/README.md#no-physical-direction-utility
-
import { useLingui } from '@lingui/react/macro';
import { useEffect, useState } from 'react';
import { EditorModeToggle } from '@/components/EditorModeToggle';
diff --git a/packages/app/src/components/SeedDialog.tsx b/packages/app/src/components/SeedDialog.tsx
index 1880e6b6f..c3b99fa10 100644
--- a/packages/app/src/components/SeedDialog.tsx
+++ b/packages/app/src/components/SeedDialog.tsx
@@ -302,7 +302,6 @@ function SeedDialogBody({
<Trans>The folders and templates are already here, so there's nothing to add.</Trans>
</p>
</div>
- {}
<PackSkillConflicts plan={phase.plan} />
</div>
);
diff --git a/packages/app/src/components/SeedRootPicker.tsx b/packages/app/src/components/SeedRootPicker.tsx
index 6e5f1af76..26da0b9c5 100644
--- a/packages/app/src/components/SeedRootPicker.tsx
+++ b/packages/app/src/components/SeedRootPicker.tsx
@@ -32,7 +32,6 @@ export function SeedRootPicker({
const groupLabelId = `${idPrefix}-group-label`;
return (
<div className="space-y-2 py-1">
- {}
<p id={groupLabelId} className="text-sm font-medium">
<Trans>Where should it live?</Trans>
</p>
diff --git a/packages/app/src/components/ShareButton.tsx b/packages/app/src/components/ShareButton.tsx
index 64df9cf79..b455d6366 100644
--- a/packages/app/src/components/ShareButton.tsx
+++ b/packages/app/src/components/ShareButton.tsx
@@ -99,7 +99,6 @@ export function ShareButton({ input, onClickWhenNoRemote, triggerRef }: ShareBut
if (!open) setSharePopover(null);
}}
>
- {}
<PopoverAnchor asChild>
<Button
ref={triggerRef}
@@ -121,7 +120,6 @@ export function ShareButton({ input, onClickWhenNoRemote, triggerRef }: ShareBut
className={cn('flex flex-col gap-2', showFreshnessRow ? 'w-96' : 'w-80')}
data-testid="share-button-popover"
>
- {}
<p
id={headingId}
className="font-mono tracking-wide uppercase text-muted-foreground text-xs"
@@ -148,7 +146,6 @@ export function ShareButton({ input, onClickWhenNoRemote, triggerRef }: ShareBut
data-testid="share-button-url"
aria-label={t`Share URL`}
/>
- {}
<div className="absolute inset-y-0 right-1 flex items-center">
<div className="rounded-md bg-background/50 backdrop-blur-sm">
<CopyButton
diff --git a/packages/app/src/components/ShareReceiveDialog.tsx b/packages/app/src/components/ShareReceiveDialog.tsx
index e2ab1d538..015fccec7 100644
--- a/packages/app/src/components/ShareReceiveDialog.tsx
+++ b/packages/app/src/components/ShareReceiveDialog.tsx
@@ -592,7 +592,6 @@ function ShareReceiveDialogInner({
}}
data-testid="share-receive-clone-retry"
>
- {}
<Trans>Try again</Trans>
</Button>
<Button
diff --git a/packages/app/src/components/SharingModeField.tsx b/packages/app/src/components/SharingModeField.tsx
index 21cfcaed0..110ff21a4 100644
--- a/packages/app/src/components/SharingModeField.tsx
+++ b/packages/app/src/components/SharingModeField.tsx
@@ -41,8 +41,7 @@ export function SharingModeField({
<Trans>Share this setup with your team?</Trans>
</span>
<ConfigSharingInfoTooltip />
- {/* biome-ignore lint/a11y/noAmbiguousAnchorText: the accessible name comes from aria-label, which this rule only recognises as a string literal; the i18n directive requires the t macro. */}
- <a
+ <a // oxlint-disable-line jsx-a11y/anchor-ambiguous-text -- the accessible name comes from aria-label, which this rule only recognises as a string literal; the i18n directive requires the t macro.
href={CONFIG_SHARING_DOCS_URL}
target="_blank"
rel="noopener noreferrer"
@@ -55,7 +54,6 @@ export function SharingModeField({
<Trans>Learn more</Trans>
</a>
</div>
- {}
<RadioGroup
value={value}
onValueChange={(v) => onValueChange(v as SharingMode)}
diff --git a/packages/app/src/components/SkillBundlePreview.tsx b/packages/app/src/components/SkillBundlePreview.tsx
index 3c6a72096..0a3528c67 100644
--- a/packages/app/src/components/SkillBundlePreview.tsx
+++ b/packages/app/src/components/SkillBundlePreview.tsx
@@ -118,7 +118,6 @@ export function SkillBundlePreview({
{findOpen ? (
<ProseFindBar containerRef={scrollRef} onClose={() => setFindOpen(false)} />
) : null}
- {}
<SkillModeBanner icon={<Eye className="size-4" aria-hidden />} actions={headerActions}>
{headerLine}
</SkillModeBanner>
@@ -128,9 +127,7 @@ export function SkillBundlePreview({
ref={scrollRef}
className="editor-doc-scroll min-h-0 flex-1 overflow-auto subtle-scrollbar scroll-fade-mask"
>
- {}
{selectedPath === SKILL_MD ? banner : null}
- {}
{selectedPath === SKILL_MD ? (
<div className="editor-content-aligned pt-6">
<div className="space-y-0.5">
diff --git a/packages/app/src/components/SkillDirectoryCard.tsx b/packages/app/src/components/SkillDirectoryCard.tsx
index 4ac201c4b..30fc675ef 100644
--- a/packages/app/src/components/SkillDirectoryCard.tsx
+++ b/packages/app/src/components/SkillDirectoryCard.tsx
@@ -27,7 +27,6 @@ export function SkillDirectoryCard({
onMouseEnter={onHover}
onFocus={onHover}
>
- {}
<Button
variant="ghost"
aria-label={t`View ${name}`}
diff --git a/packages/app/src/components/SkillDirectoryResult.tsx b/packages/app/src/components/SkillDirectoryResult.tsx
index 9759e89ad..db7d1f698 100644
--- a/packages/app/src/components/SkillDirectoryResult.tsx
+++ b/packages/app/src/components/SkillDirectoryResult.tsx
@@ -76,7 +76,6 @@ export function SkillDirectoryResult({
meta={
<div className="mt-0.5 flex items-center gap-1.5 text-muted-foreground text-xs">
<span className="truncate">{result.publisher ?? result.source}</span>
- {}
{result.publisher === 'openknowledge' || result.publisher === 'inkeep' ? (
<Badge variant="secondary" className="h-4 px-1 text-[10px] uppercase tracking-wide">
<Trans>By OpenKnowledge</Trans>
@@ -85,7 +84,6 @@ export function SkillDirectoryResult({
{result.installs != null ? (
<>
<span aria-hidden>·</span>
- {}
<span className="shrink-0">
<span aria-hidden="true">↓ </span>
<span className="sr-only">
@@ -95,7 +93,6 @@ export function SkillDirectoryResult({
</span>
</>
) : null}
- {}
{cost ? (
<>
<span aria-hidden>·</span>
diff --git a/packages/app/src/components/SkillEditorActions.tsx b/packages/app/src/components/SkillEditorActions.tsx
index 45f47401f..d035ffe7c 100644
--- a/packages/app/src/components/SkillEditorActions.tsx
+++ b/packages/app/src/components/SkillEditorActions.tsx
@@ -52,7 +52,6 @@ export function SkillEditorActions({
return (
<div className="flex min-w-0 items-center gap-1.5">
- {}
{showNewFile ? (
<Button
variant="outline"
@@ -66,10 +65,8 @@ export function SkillEditorActions({
<FilePlus className="size-4" aria-hidden />
</Button>
) : null}
- {}
<DropdownMenu modal={false} open={menuOpen} onOpenChange={setMenuOpen}>
<DropdownMenuTrigger asChild>
- {}
<Button
variant="outline"
size="sm"
@@ -90,7 +87,6 @@ export function SkillEditorActions({
) : (
<>
<Trans>Installed</Trans>
- {}
<AgentIconCluster hosts={installedEditors} className="text-muted-foreground" />
</>
)}
diff --git a/packages/app/src/components/SkillFileViewer.tsx b/packages/app/src/components/SkillFileViewer.tsx
index 7fb9e5ee3..eca8b8016 100644
--- a/packages/app/src/components/SkillFileViewer.tsx
+++ b/packages/app/src/components/SkillFileViewer.tsx
@@ -46,7 +46,6 @@ export function SkillFileViewer({
{isMarkdown && findOpen ? (
<ProseFindBar containerRef={proseRef} onClose={() => setFindOpen(false)} />
) : null}
- {}
<div className="flex shrink-0 items-center gap-1.5 border-border border-b bg-muted/35 px-3 py-2 text-muted-foreground text-sm">
<Eye className="size-4 shrink-0" aria-hidden />
<span className="truncate">{t`Read-only file in the ${name} skill`}</span>
diff --git a/packages/app/src/components/SkillForkDialog.tsx b/packages/app/src/components/SkillForkDialog.tsx
index 7f9400cfd..bb9268ddb 100644
--- a/packages/app/src/components/SkillForkDialog.tsx
+++ b/packages/app/src/components/SkillForkDialog.tsx
@@ -112,7 +112,6 @@ export function SkillForkDialog({
if (!open && !busy) onOpenChange(false);
}}
>
- {}
<DialogContent className="flex max-h-[85vh] w-full flex-col sm:max-w-5xl">
<DialogHeader>
<DialogTitle>
diff --git a/packages/app/src/components/SkillInstallMenu.tsx b/packages/app/src/components/SkillInstallMenu.tsx
index 55481dd94..024b5bd30 100644
--- a/packages/app/src/components/SkillInstallMenu.tsx
+++ b/packages/app/src/components/SkillInstallMenu.tsx
@@ -441,8 +441,6 @@ export function SkillInstallMenuItems({
};
return (
<>
- {}
- {}
<SkillMenuLabel menuKind={menuKind} className="flex items-center justify-between gap-2">
<Trans>Install on</Trans>
<Hint hint={t`Install on all agents`}>
@@ -458,7 +456,6 @@ export function SkillInstallMenuItems({
</Button>
</Hint>
</SkillMenuLabel>
- {}
{sourceRow !== null ? (
<Hint hint={t`The skill's own folder — the source other locations copy or link from`}>
<SkillMenuCheckboxItem
@@ -468,7 +465,6 @@ export function SkillInstallMenuItems({
onSelect={(e) => e.preventDefault()}
data-testid="skill-source-row"
>
- {}
<Folder aria-hidden className="size-4 text-muted-foreground" />
<span className="flex min-w-0 flex-1 items-baseline gap-1.5">
<span className="min-w-0 truncate font-mono text-xs">{sourceRow}</span>
@@ -535,10 +531,8 @@ export function SkillInstallMenuItems({
data-testid={`skill-install-editor-${editor}`}
>
<AgentBrandIcon host={editor} aria-hidden className="size-4" />
- {}
<span className="flex min-w-0 flex-1 items-baseline gap-1.5">
<span className="min-w-0 truncate font-mono text-xs">{path ?? label}</span>
- {}
{audience.length > 0 ? (
<span
className="flex shrink-0 items-center gap-0.5"
@@ -576,11 +570,9 @@ export function SkillInstallMenuItems({
</span>
) : hostSet.has(editor) && skill?.hosts ? (
<>
- {}
{!busy && (linked.has(editor) ? 'link' : 'copy') !== expectedMode
? convertRow(editor, path ?? label, linked.has(editor) ? 'link' : 'copy')
: null}
- {}
<Hint hint={t`Make this the source — the skill's real folder moves here`}>
<Button
variant="ghost"
@@ -610,7 +602,6 @@ export function SkillInstallMenuItems({
</Hint>
);
})}
- {}
{customRootRows.map((r) => {
const path = r.display;
return (
@@ -690,7 +681,6 @@ export function SkillInstallMenuItems({
);
})}
- {}
{rows.length === 0 && customRootRows.length === 0 && sourceRow === null ? (
<div
className="px-2 py-1.5 text-[11px] text-muted-foreground leading-snug"
@@ -700,7 +690,6 @@ export function SkillInstallMenuItems({
</div>
) : null}
- {}
{convertible.length > 0 && toggles.convertLocations ? (
<div className="flex items-center gap-1 px-2 pt-1 pb-1.5">
<Button
@@ -741,7 +730,6 @@ export function SkillInstallMenuItems({
<Trans>Convert locations to symlinks</Trans>
)}
</Button>
- {}
<Hint
hint={t`A copy is a real folder of its own, and OK keeps it in step with the source: edit the skill here and every copy is refreshed. That stops the moment you hand-edit a copy outside OK — from then on it goes its own way and shows up as a separate skill. A symlink is a pointer to the source instead, so nothing can drift, but a location stops working if the source is deleted.`}
>
@@ -759,7 +747,6 @@ export function SkillInstallMenuItems({
</div>
) : null}
<SkillMenuSeparator menuKind={menuKind} />
- {}
<Hint
hint={t`Opens Settings → Skills Studio, where you link a whole folder into another so both agents read the same skills, and add custom skill roots.`}
>
diff --git a/packages/app/src/components/SkillMarkdownViewer.tsx b/packages/app/src/components/SkillMarkdownViewer.tsx
index 7f3af2f1c..a43d1b4d2 100644
--- a/packages/app/src/components/SkillMarkdownViewer.tsx
+++ b/packages/app/src/components/SkillMarkdownViewer.tsx
@@ -90,7 +90,6 @@ export function SkillMarkdownViewer({
data-skill-markdown-viewer-state="loaded"
>
<div className="editor-doc-scroll min-h-0 flex-1 overflow-auto subtle-scrollbar scroll-fade-mask">
- {}
<ReadonlyPropertyPanel text={text} />
{grid}
</div>
diff --git a/packages/app/src/components/SkillModeBanner.tsx b/packages/app/src/components/SkillModeBanner.tsx
index bbd8ac69a..bec37af77 100644
--- a/packages/app/src/components/SkillModeBanner.tsx
+++ b/packages/app/src/components/SkillModeBanner.tsx
@@ -15,7 +15,6 @@ export function SkillModeBanner({
<div className="flex shrink-0 items-center justify-between gap-3 border-b border-border bg-muted/35 px-3 py-2">
<div className="flex min-w-0 items-start gap-1.5 text-muted-foreground text-sm">
<span className="mt-0.5 shrink-0">{icon}</span>
- {}
<p className={clampLines ? 'line-clamp-2' : 'min-w-0 break-words'}>{children}</p>
</div>
{actions ? (
diff --git a/packages/app/src/components/SkillOriginInline.tsx b/packages/app/src/components/SkillOriginInline.tsx
index f27573cd7..ae425ddee 100644
--- a/packages/app/src/components/SkillOriginInline.tsx
+++ b/packages/app/src/components/SkillOriginInline.tsx
@@ -55,7 +55,6 @@ export function SkillOriginInline({ scope, name }: { scope: SkillScope; name: st
return (
<div className="flex min-w-0 items-center gap-1.5 text-muted-foreground text-xs">
- {}
{github ? (
<a
href={github}
@@ -164,7 +163,6 @@ export function SkillOriginInline({ scope, name }: { scope: SkillScope; name: st
) : (
<RefreshCw className="size-3" aria-hidden />
)}
- {}
<span className="hidden @xl/toolbar:inline">
{reimporting ? <Trans>Updating</Trans> : <Trans>Update</Trans>}
</span>
diff --git a/packages/app/src/components/SkillPluginBundleBanner.tsx b/packages/app/src/components/SkillPluginBundleBanner.tsx
index 01d32a4b6..781a5539c 100644
--- a/packages/app/src/components/SkillPluginBundleBanner.tsx
+++ b/packages/app/src/components/SkillPluginBundleBanner.tsx
@@ -40,9 +40,7 @@ export function SkillPluginBundleBanner({
return (
<div className="editor-content-aligned">
- {}
<Alert role="note" className="my-3 bg-muted/40 px-4 py-3">
- {}
<PackageIcon className="size-4" aria-hidden />
<AlertTitle>
{plugin ? (
@@ -53,7 +51,6 @@ export function SkillPluginBundleBanner({
<Trans>{siblings.length} other skills by this publisher</Trans>
)}
</AlertTitle>
- {}
<AlertDescription className="min-w-0">
{caps.length > 0 ? (
<Trans>
@@ -61,7 +58,6 @@ export function SkillPluginBundleBanner({
</Trans>
) : null}
</AlertDescription>
- {}
<div className="mt-2 flex flex-wrap items-center gap-x-2 gap-y-1.5 group-has-[>svg]/alert:col-start-2">
{shownSiblings.map((n) => (
<code
diff --git a/packages/app/src/components/SkillPluginBundleDialog.tsx b/packages/app/src/components/SkillPluginBundleDialog.tsx
index 73b388956..decc7af0c 100644
--- a/packages/app/src/components/SkillPluginBundleDialog.tsx
+++ b/packages/app/src/components/SkillPluginBundleDialog.tsx
@@ -265,7 +265,6 @@ function OpenSkillPluginBundleDialog({
{allSelected ? <Trans>Clear</Trans> : <Trans>Select all</Trans>}
</Button>
</div>
- {}
<div className="max-h-72 overflow-y-auto rounded-md border border-border divide-y divide-border">
{names.map((name) => {
const description = described.get(name);
@@ -300,7 +299,6 @@ function OpenSkillPluginBundleDialog({
);
})}
</div>
- {}
<div
className="flex flex-wrap items-center gap-1.5 text-1sm text-muted-foreground"
data-testid="plugin-bundle-destination"
@@ -378,7 +376,6 @@ function OpenSkillPluginBundleDialog({
{EDITOR_LABELS[editor] ?? editor}
</Label>
))}
- {}
{offeredCustomRoots.map((root) => (
<Label
key={root}
diff --git a/packages/app/src/components/SkillPreviewTab.tsx b/packages/app/src/components/SkillPreviewTab.tsx
index 3dcd69ed2..11476550b 100644
--- a/packages/app/src/components/SkillPreviewTab.tsx
+++ b/packages/app/src/components/SkillPreviewTab.tsx
@@ -255,7 +255,6 @@ export function SkillPreviewTab({ flavor, source, name, subtitle, level, path }:
<Trans>Open file</Trans>
</Button>
) : null}
- {}
<SkillEditorActions scope={targetScope} name={name} showNewFile={false} />
</div>
) : builtin ? (
@@ -321,7 +320,6 @@ export function SkillPreviewTab({ flavor, source, name, subtitle, level, path }:
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className={SKILL_INSTALL_MENU_WIDTH}>
- {}
{pluginInfo || foreign ? (
<>
<DropdownMenuLabel className="font-normal text-muted-foreground text-xs leading-snug whitespace-normal">
diff --git a/packages/app/src/components/SkillToolbarControls.tsx b/packages/app/src/components/SkillToolbarControls.tsx
index 4aeeae06b..97f10b4a2 100644
--- a/packages/app/src/components/SkillToolbarControls.tsx
+++ b/packages/app/src/components/SkillToolbarControls.tsx
@@ -35,7 +35,6 @@ export function SkillToolbarControls({
return (
<>
- {}
<div className="flex items-center gap-2">
<SkillLevelSelect
value={scope}
@@ -77,7 +76,6 @@ export function SkillToolbarControls({
) : null}
</DropdownMenuContent>
</DropdownMenu>
- {}
{move.dialog}
</>
);
diff --git a/packages/app/src/components/SkillUpdateConflictDialog.tsx b/packages/app/src/components/SkillUpdateConflictDialog.tsx
index ede5bd9ff..6c5d844c6 100644
--- a/packages/app/src/components/SkillUpdateConflictDialog.tsx
+++ b/packages/app/src/components/SkillUpdateConflictDialog.tsx
@@ -31,7 +31,6 @@ export function SkillUpdateConflictDialog({
}) {
return (
<Dialog open={open} onOpenChange={onOpenChange}>
- {}
<DialogContent className="flex max-h-[85vh] flex-col sm:max-w-5xl">
<DialogHeader>
<DialogTitle>
@@ -45,7 +44,6 @@ export function SkillUpdateConflictDialog({
</DialogDescription>
</DialogHeader>
<DialogBody className="min-h-0 flex-1 overflow-auto">
- {}
<MultiFileDiff
className="pierre-diff"
oldFile={{ name: skillName, contents: localBody }}
diff --git a/packages/app/src/components/SkillsSidebarDock.tsx b/packages/app/src/components/SkillsSidebarDock.tsx
index 45c30888b..9f0f8b042 100644
--- a/packages/app/src/components/SkillsSidebarDock.tsx
+++ b/packages/app/src/components/SkillsSidebarDock.tsx
@@ -173,7 +173,6 @@ export function SkillsSidebarDock({ filesOpen = true }: { filesOpen?: boolean }
/>
</div>
</div>
- {}
<CollapsibleContent
ref={contentRef}
className={cn(
diff --git a/packages/app/src/components/SkillsTree.tsx b/packages/app/src/components/SkillsTree.tsx
index 2fd789570..a1c05f155 100644
--- a/packages/app/src/components/SkillsTree.tsx
+++ b/packages/app/src/components/SkillsTree.tsx
@@ -1137,7 +1137,6 @@ export function SkillsTree({
return (
<>
- {}
<div
ref={iconPoolRef}
aria-hidden
@@ -1151,20 +1150,16 @@ export function SkillsTree({
<span {...{ [HOST_POOL_KEY_ATTR]: 'generic' }}>
<Sparkles />
</span>
- {}
<span {...{ [PROVENANCE_POOL_KEY_ATTR]: PROVENANCE_PLUGIN_POOL_KEY }}>
<Package />
</span>
- {}
<span {...{ [PROVENANCE_POOL_KEY_ATTR]: PROVENANCE_PIN_POOL_KEY }}>
<Pin />
</span>
- {}
<span {...{ [PROVENANCE_POOL_KEY_ATTR]: PROVENANCE_LIBRARY_POOL_KEY }}>
<LibraryBig />
</span>
</div>
- {}
{installMenu ? (
<DropdownMenu
open
diff --git a/packages/app/src/components/SubscribeForm.tsx b/packages/app/src/components/SubscribeForm.tsx
index fcff06f4a..5b8992cd3 100644
--- a/packages/app/src/components/SubscribeForm.tsx
+++ b/packages/app/src/components/SubscribeForm.tsx
@@ -81,7 +81,6 @@ export function SubscribeForm({
<div className={cn('flex flex-col gap-3', className)}>
<div className="flex items-start justify-between gap-3">
<div className="flex flex-col gap-1">
- {}
<p
ref={successHeadingRef}
tabIndex={subscribed ? -1 : undefined}
@@ -96,7 +95,6 @@ export function SubscribeForm({
(title ?? <Trans>Stay in the loop</Trans>)
)}
</p>
- {}
<p className="text-1sm text-muted-foreground" role="status">
{subscribed ? (
<Trans>Thanks for subscribing. Watch your inbox for product updates.</Trans>
diff --git a/packages/app/src/components/SyncBlockingChanges.tsx b/packages/app/src/components/SyncBlockingChanges.tsx
index 35b811566..ceae951a9 100644
--- a/packages/app/src/components/SyncBlockingChanges.tsx
+++ b/packages/app/src/components/SyncBlockingChanges.tsx
@@ -43,8 +43,6 @@ export function SyncBlockingChanges({ paths }: { paths: readonly string[] }) {
</span>
</div>
- {}
- {}
<ul
aria-labelledby="sync-blocking-heading"
className="flex max-h-28 flex-col gap-1 overflow-y-auto overscroll-contain"
@@ -61,7 +59,6 @@ export function SyncBlockingChanges({ paths }: { paths: readonly string[] }) {
))}
</ul>
- {}
{failed && (
<p role="alert" className="text-xs text-destructive" data-testid="sync-blocking-error">
<Trans>That did not go through. Check the server logs and try again.</Trans>
diff --git a/packages/app/src/components/SyncStatusBadge.tsx b/packages/app/src/components/SyncStatusBadge.tsx
index 30e533006..f4790968d 100644
--- a/packages/app/src/components/SyncStatusBadge.tsx
+++ b/packages/app/src/components/SyncStatusBadge.tsx
@@ -671,7 +671,7 @@ function WorktreeRow({
<TooltipTrigger asChild>
<span
dir="auto"
- // biome-ignore lint/a11y/noNoninteractiveTabindex: tooltip-on-static-text pattern (see EditorFooter) — Radix opens on the trigger's focus, so a non-focusable span leaves sighted keyboard-only users no way to recover a truncated path. Sibling rows that link are buttons and already take focus, so this also stops the list silently skipping the rows whose path is their only content.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- tooltip-on-static-text pattern (see EditorFooter) — Radix opens on the trigger's focus, so a non-focusable span leaves sighted keyboard-only users no way to recover a truncated path. Sibling rows that link are buttons and already take focus, so this also stops the list silently skipping the rows whose path is their only content.
tabIndex={0}
className={`min-w-0 rounded-xs focus-visible:outline-none focus-visible:ring-3 focus-visible:ring-ring/50 ${pathClassName}`}
>
@@ -682,7 +682,6 @@ function WorktreeRow({
{entry.path}
</TooltipContent>
</Tooltip>
- {}
{label !== entry.path && <span className="sr-only">{entry.path}</span>}
</>
)}
@@ -949,12 +948,11 @@ function WorktreeStatusSection({
worktree && (
<section
className="flex max-h-56 flex-col gap-2.5 overflow-y-auto overscroll-contain focus-visible:outline-none focus-visible:ring-3 focus-visible:ring-ring/50"
- // biome-ignore lint/a11y/noNoninteractiveTabindex: keyboard-focusable scroll container — Chromium doesn't make overflow:auto divs focusable without tabIndex.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- keyboard-focusable scroll container — Chromium doesn't make overflow:auto divs focusable without tabIndex.
tabIndex={0}
aria-labelledby="worktree-status-label"
data-testid="worktree-listing"
>
- {}
<WorktreeGroup title={<Trans>Pull brings in</Trans>} entries={incoming} />
<WorktreeGroup title={<Trans>Push includes</Trans>} entries={willPush} />
<WorktreeGroup
@@ -1004,13 +1002,11 @@ function UpdatedLine({
if (label === null) return <span />;
return (
<span className="text-xs text-muted-foreground" data-testid="sync-popover-last-sync">
- {}
{showArrows && (
<span className="sr-only" data-testid="sync-popover-last-sync-label">
{label}
</span>
)}
- {}
{showArrows ? (
<span aria-hidden="true" className="inline-flex items-center gap-1">
{pulled !== null && (
@@ -1111,7 +1107,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
return (
<div className="flex flex-col gap-3.5">
<div className="flex items-center justify-between gap-2">
- {}
<div className="flex shrink-0 items-center gap-2">
<BadgeIcon status={status} />
<span className="text-1sm font-medium">
@@ -1143,7 +1138,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
strandedCommitCount={strandedCommitCount}
/>
- {}
<div className="flex flex-col gap-1.5">
<SectionLabel>
<Trans>Sync mode</Trans>
@@ -1166,7 +1160,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
<SelectContent>
<SelectItem value="off" className="text-xs">{t`Manual`}</SelectItem>
<SelectItem value="follow" className="text-xs">{t`Auto (Pull only)`}</SelectItem>
- {}
<SelectItem value="full" className="text-xs" disabled={genuineReadOnly}>
{t`Auto (Pull and Push)`}
</SelectItem>
@@ -1183,7 +1176,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
</p>
</div>
- {}
<div className="flex flex-col gap-2 border-t pt-3">
<SectionLabel>
<Trans>Manual</Trans>
@@ -1240,8 +1232,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
)}
</div>
- {}
- {}
<div
role="status"
aria-live="polite"
@@ -1266,7 +1256,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
</p>
))}
- {}
{isParkedOnNotFoundAsIdentity(status) && status.pushPermission?.checkStatus === 'denied'
? formatDeniedIdentitySentences(status.pushPermission).map((sentence) => (
<p key={sentence} className="text-xs text-muted-foreground">
@@ -1328,7 +1317,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
{state === 'conflict' && (
<div className="flex items-start gap-2">
<p className="min-w-0 flex-1 text-xs text-warning">
- {}
<Trans>A document has a conflict — resolve it to keep it up to date.</Trans>
</p>
{firstConflictDocName !== null && (
@@ -1385,7 +1373,6 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
</p>
)}
- {}
<WorktreeStatusSection
status={status}
worktree={worktree}
@@ -1395,10 +1382,8 @@ function PopoverBody({ status, onSignIn, onSetIdentity }: PopoverBodyProps) {
lastReadAt={worktreeLastReadAt}
/>
- {}
<div className="flex items-center justify-between gap-2">
<UpdatedLine pulledAt={pulledAt} pushedAt={pushedAt} combinedAt={combinedAt} />
- {}
<PopoverClose asChild>
<Button
variant="link"
@@ -1508,7 +1493,6 @@ export function SyncStatusBadge({ onSignIn, onSetIdentity }: SyncStatusBadgeProp
</TooltipTrigger>
<TooltipContent>{tooltipLabel(status)}</TooltipContent>
</Tooltip>
- {}
<PopoverContent
align="end"
className="flex max-h-(--radix-popover-content-available-height) w-80 flex-col overflow-y-auto p-3"
diff --git a/packages/app/src/components/TemplateRow.tsx b/packages/app/src/components/TemplateRow.tsx
index de9bef742..86da79fba 100644
--- a/packages/app/src/components/TemplateRow.tsx
+++ b/packages/app/src/components/TemplateRow.tsx
@@ -61,7 +61,6 @@ export function TemplateRow({ template, onEdit, onDelete, onCreate, badge }: Tem
<Trans>Create</Trans>
</Button>
) : null}
- {}
<DropdownMenu modal={false}>
<DropdownMenuTrigger asChild>
<Button
diff --git a/packages/app/src/components/TerminalNewChatButton.tsx b/packages/app/src/components/TerminalNewChatButton.tsx
index 3e784f923..9d67f54ad 100644
--- a/packages/app/src/components/TerminalNewChatButton.tsx
+++ b/packages/app/src/components/TerminalNewChatButton.tsx
@@ -210,7 +210,6 @@ export function TerminalNewChatButton({
</DropdownMenuTrigger>
) : null}
<DropdownMenuContent align="start" className="max-h-80 min-w-[200px]">
- {}
{showAgents && registeredAgents.length > 0 ? (
<DropdownMenuGroup aria-label={t`In app`}>
<DropdownMenuLabel>
@@ -276,7 +275,6 @@ export function TerminalNewChatButton({
</DropdownMenuItem>
);
})}
- {}
<DropdownMenuItem
onSelect={onPickTerminal}
data-testid="terminal-new-chat-terminal"
@@ -292,10 +290,8 @@ export function TerminalNewChatButton({
</DropdownMenuItem>
</DropdownMenuGroup>
) : null}
- {}
{showAgents ? (
<>
- {}
{registeredAgents.length > 0 || showClis ? <DropdownMenuSeparator /> : null}
<DropdownMenuItem onSelect={onOpenSettings} data-testid="terminal-new-chat-settings">
<SlidersHorizontal aria-hidden="true" className="size-4 text-muted-foreground" />
diff --git a/packages/app/src/components/TerminalPanel.tsx b/packages/app/src/components/TerminalPanel.tsx
index d1dfa84b6..68788c128 100644
--- a/packages/app/src/components/TerminalPanel.tsx
+++ b/packages/app/src/components/TerminalPanel.tsx
@@ -95,7 +95,6 @@ export function TerminalPanel({
style={{ backgroundColor: xtermTheme.background }}
className={cn('relative flex h-full w-full flex-col overflow-hidden', className)}
>
- {}
<div className="relative min-h-0 flex-1">
<TerminalSession
key={restartKey}
@@ -1024,7 +1023,6 @@ function TerminalSession({
</TerminalNoticeBanner>
) : null
) : null}
- {}
<div className="relative min-h-0 flex-1">
<div
ref={containerRef}
diff --git a/packages/app/src/components/TerminalTabStrip.tsx b/packages/app/src/components/TerminalTabStrip.tsx
index 66e7c7fed..243faf392 100644
--- a/packages/app/src/components/TerminalTabStrip.tsx
+++ b/packages/app/src/components/TerminalTabStrip.tsx
@@ -330,7 +330,6 @@ export function TerminalTabStrip({
items={sessions.map((session) => session.id)}
strategy={horizontalListSortingStrategy}
>
- {}
<div
onWheel={scrollTabStripOnWheel}
className={cn(
@@ -488,15 +487,12 @@ export function TerminalTabStrip({
</div>
</SortableContext>
</DndContext>
- {}
{newButton != null ? (
<div className={cn('shrink-0', windowDragRegion && '[-webkit-app-region:no-drag]')}>
{newButton}
</div>
) : null}
- {}
<div className="flex-1" />
- {}
{trailingControls != null ? (
<div className={cn('shrink-0', windowDragRegion && '[-webkit-app-region:no-drag]')}>
{trailingControls}
diff --git a/packages/app/src/components/TerminalWindowApp.tsx b/packages/app/src/components/TerminalWindowApp.tsx
index 6217a6e9d..f0ef32c16 100644
--- a/packages/app/src/components/TerminalWindowApp.tsx
+++ b/packages/app/src/components/TerminalWindowApp.tsx
@@ -16,7 +16,6 @@ export function TerminalWindowApp({ bridge }: TerminalWindowAppProps) {
return (
<ConfigProvider collabUrl={collabUrl} collabTerminal={collabUrl === null}>
<TerminalWindowBody bridge={bridge} />
- {}
<ReportBugMenuTrigger systemWide={collabUrl === null} />
</ConfigProvider>
);
@@ -30,7 +29,6 @@ function TerminalWindowBody({ bridge }: TerminalWindowAppProps) {
return (
<>
- {}
<div
ref={setContainer}
className="flex h-screen min-h-0 flex-col"
diff --git a/packages/app/src/components/ThemePicker.tsx b/packages/app/src/components/ThemePicker.tsx
index 3cf4ef51f..bc0a97a9d 100644
--- a/packages/app/src/components/ThemePicker.tsx
+++ b/packages/app/src/components/ThemePicker.tsx
@@ -89,7 +89,6 @@ function ThemePickerOption({
>
<span className="relative block overflow-hidden rounded-md border border-border/60">
<ThemePreview tone={preview} />
- {}
<span
className="absolute end-1.5 top-1.5 hidden size-4 items-center justify-center rounded-full bg-primary text-primary-foreground group-data-[state=checked]:flex"
aria-hidden
@@ -98,7 +97,6 @@ function ThemePickerOption({
</span>
</span>
<span className="flex items-center gap-1.5 px-0.5 pb-0.5 font-medium text-1sm text-foreground">
- {}
<Icon aria-hidden className="size-3.5 shrink-0 text-muted-foreground" />
{label}
</span>
@@ -111,7 +109,6 @@ function ThemePreview({ tone }: { tone: PreviewTone }) {
return (
<span className="relative block" aria-hidden>
<MockWindow tone="light" />
- {}
<span className="absolute inset-y-0 start-0 w-1/2 overflow-hidden">
<span className="block w-[200%]">
<MockWindow tone="dark" />
diff --git a/packages/app/src/components/TimelineDiffPane.tsx b/packages/app/src/components/TimelineDiffPane.tsx
index 89800ef96..370612783 100644
--- a/packages/app/src/components/TimelineDiffPane.tsx
+++ b/packages/app/src/components/TimelineDiffPane.tsx
@@ -268,7 +268,6 @@ export function TimelineDiffPane({
className="absolute inset-0 z-20 flex flex-col bg-background"
data-testid="timeline-diff-pane"
>
- {}
<div className="flex flex-wrap items-center gap-x-2 gap-y-1.5 border-b border-border px-3 py-2">
<Tooltip>
<TooltipTrigger asChild>
@@ -420,7 +419,6 @@ export function TimelineDiffPane({
</div>
</div>
- {}
<div ref={diffBodyRef} className="min-h-0 flex-1 overflow-auto subtle-scrollbar">
{result.status === 'loading' && (
<div className="flex items-center gap-2 px-4 py-3 text-xs text-muted-foreground">
diff --git a/packages/app/src/components/TimelinePanel.tsx b/packages/app/src/components/TimelinePanel.tsx
index de0a89937..6d663c4ab 100644
--- a/packages/app/src/components/TimelinePanel.tsx
+++ b/packages/app/src/components/TimelinePanel.tsx
@@ -535,11 +535,9 @@ function EntryRow({
}
}}
>
- {}
<span className="mt-0.5 shrink-0">{leadingIcon}</span>
<div className="min-w-0 flex-1 space-y-0.5">
- {}
<div className="flex items-center gap-1.5">
<span className="truncate text-xs text-foreground">{authorName}</span>
<time
@@ -549,7 +547,6 @@ function EntryRow({
>
{relative}
</time>
- {}
<span aria-hidden="true" className="h-3 w-px shrink-0 bg-border" />
<Tooltip>
<TooltipTrigger asChild>
@@ -577,7 +574,6 @@ function EntryRow({
</Tooltip>
</div>
- {}
{allSummaries.length > 0 && <SummaryBullets summaries={allSummaries} />}
<EntryDetail
descriptor={descriptor}
@@ -697,15 +693,12 @@ export function TimelineContent({ docName }: TimelineContentProps) {
return (
<div className="flex h-full flex-col">
- {}
<PanelHeader>
<PanelTitle>
<Trans>Timeline</Trans>
</PanelTitle>
</PanelHeader>
- {}
<div className="flex-1 overflow-y-auto subtle-scrollbar scroll-fade-mask">
- {}
{loading && (
<div
className="flex flex-col gap-1 p-2"
@@ -725,14 +718,12 @@ export function TimelineContent({ docName }: TimelineContentProps) {
</div>
)}
- {}
{!loading && error && (
<div className="px-4 py-3">
<p className="text-xs text-destructive">{error}</p>
</div>
)}
- {}
{!loading && !error && entries.length === 0 && (
<div className="px-4 py-8 text-center">
<p className="text-xs text-muted-foreground">
@@ -741,7 +732,6 @@ export function TimelineContent({ docName }: TimelineContentProps) {
</div>
)}
- {}
{!loading && !error && entries.length > 0 && (
<div className="flex flex-col gap-1 p-2">
{entries.map((entry, index) => (
diff --git a/packages/app/src/components/TrashFailureModal.tsx b/packages/app/src/components/TrashFailureModal.tsx
index 12a25d94c..22fbf4212 100644
--- a/packages/app/src/components/TrashFailureModal.tsx
+++ b/packages/app/src/components/TrashFailureModal.tsx
@@ -118,7 +118,6 @@ export function TrashFailureModal({
>
<Trans>Cancel</Trans>
</AlertDialogCancel>
- {}
<Button
variant="outline"
onClick={onRetry}
diff --git a/packages/app/src/components/WebProjectName.tsx b/packages/app/src/components/WebProjectName.tsx
index 1831a0ecd..904ca8b8b 100644
--- a/packages/app/src/components/WebProjectName.tsx
+++ b/packages/app/src/components/WebProjectName.tsx
@@ -16,8 +16,12 @@ export function WebProjectName() {
return (
<Tooltip>
<TooltipTrigger asChild>
- {/* biome-ignore lint/a11y/noNoninteractiveTabindex: tooltip-on-static-text pattern — focusable span lets keyboard users surface the full project path that mouse users see on hover. */}
- <span tabIndex={0} data-testid="web-project-name" className={CENTRE_LABEL_CLASS}>
+ <span
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- tooltip-on-static-text pattern — focusable span lets keyboard users surface the full project path that mouse users see on hover.
+ tabIndex={0}
+ data-testid="web-project-name"
+ className={CENTRE_LABEL_CLASS}
+ >
<Folder aria-hidden="true" className="size-4 shrink-0" />
<span className="sr-only">{t`Project`}</span>
<span
diff --git a/packages/app/src/components/WorkingAvatar.tsx b/packages/app/src/components/WorkingAvatar.tsx
index bc3865e8a..ce499b270 100644
--- a/packages/app/src/components/WorkingAvatar.tsx
+++ b/packages/app/src/components/WorkingAvatar.tsx
@@ -77,11 +77,9 @@ export function WorkingAvatar({ status, className, testId }: WorkingAvatarProps)
return (
<div className={cn('ok-working-enter flex items-center gap-2', className)} data-testid={testId}>
- {}
<span aria-live="polite" className="sr-only" role="status">
{announced}
</span>
- {}
<span className="grid shrink-0 place-items-center text-muted-foreground/80">
<svg
width={MARK_SIZE}
@@ -122,7 +120,6 @@ export function WorkingAvatar({ status, className, testId }: WorkingAvatarProps)
</g>
</svg>
</span>
- {}
<span key={status} className="ok-working-status text-sm">
<span className="shimmer">{status}</span>
</span>
diff --git a/packages/app/src/components/acp/AgentMarkdown.dom.test.tsx b/packages/app/src/components/acp/AgentMarkdown.dom.test.tsx
index 15d9d79ac..f3e34723d 100644
--- a/packages/app/src/components/acp/AgentMarkdown.dom.test.tsx
+++ b/packages/app/src/components/acp/AgentMarkdown.dom.test.tsx
@@ -10,7 +10,7 @@ describe('AgentMarkdown', () => {
afterEach(cleanup);
test('renders emphasis and inline code as elements, not raw delimiters', () => {
- const { container } = render(<AgentMarkdown text={'**bold** and `inline`'} />);
+ const { container } = render(<AgentMarkdown text="**bold** and `inline`" />);
expect(container.querySelector('[data-streamdown="strong"]')?.textContent).toBe('bold');
expect(container.querySelector('code')?.textContent).toBe('inline');
expect(container.textContent).not.toContain('**');
@@ -18,7 +18,7 @@ describe('AgentMarkdown', () => {
test('untrusted text renders no raw HTML element and loads no image', () => {
const { container } = render(
- <AgentMarkdown text={'<b>bold</b> then ![a chart](https://example.com/x.png)'} untrusted />,
+ <AgentMarkdown text="<b>bold</b> then ![a chart](https://example.com/x.png)" untrusted />,
);
expect(container.querySelector('b')).toBeNull();
expect(container.querySelector('img')).toBeNull();
@@ -60,14 +60,14 @@ describe('AgentMarkdown', () => {
});
test('an unterminated construct mid-stream shows text without delimiter noise', () => {
- const { container } = render(<AgentMarkdown text={'streaming **partial'} />);
+ const { container } = render(<AgentMarkdown text="streaming **partial" />);
expect(container.textContent).toContain('partial');
expect(container.textContent).not.toContain('**');
});
test('sanitizes raw HTML from the agent', () => {
const { container } = render(
- <AgentMarkdown text={'before <img src="x" onerror="window.__pwned = true"> after'} />,
+ <AgentMarkdown text='before <img src="x" onerror="window.__pwned = true"> after' />,
);
for (const img of container.querySelectorAll('img')) {
expect(img.getAttribute('onerror')).toBeNull();
@@ -83,9 +83,7 @@ describe('AgentMarkdown', () => {
autolinks: [{ prefix: 'PRD-', url: 'https://linear.app/inkeep/issue/PRD-<num>' }],
}}
>
- <AgentMarkdown
- text={'Fixes PRD-8223 and inkeep/agents-private#4971, not `PRD-1` or #12.'}
- />
+ <AgentMarkdown text="Fixes PRD-8223 and inkeep/agents-private#4971, not `PRD-1` or #12." />
</ReferenceRulesContext>,
);
const anchors = [...container.querySelectorAll('a')].map((a) => [
@@ -147,7 +145,7 @@ describe('AgentMarkdown', () => {
});
test('hardens links to open in a new context', () => {
- const { container } = render(<AgentMarkdown text={'[docs](https://example.com/)'} />);
+ const { container } = render(<AgentMarkdown text="[docs](https://example.com/)" />);
const anchor = container.querySelector('a');
expect(anchor?.getAttribute('href')).toBe('https://example.com/');
expect(anchor?.getAttribute('target')).toBe('_blank');
@@ -170,7 +168,7 @@ describe('single newlines', () => {
const table = render(<AgentMarkdown text={'| a | b |\n| - | - |\n| 1 | 2 |'} />);
expect(table.container.querySelector('table')).not.toBeNull();
- const strike = render(<AgentMarkdown text={'~~gone~~'} />);
+ const strike = render(<AgentMarkdown text="~~gone~~" />);
expect(strike.container.querySelector('del')).not.toBeNull();
});
});
@@ -316,7 +314,7 @@ describe('AgentMarkdown doc-path links', () => {
setDocPathResolver(resolver);
const { container } = render(
<DocPathResolverReadyContext value={resolver !== null}>
- <AgentMarkdown text={'open docs/intro.mdx for the setup steps'} />
+ <AgentMarkdown text="open docs/intro.mdx for the setup steps" />
</DocPathResolverReadyContext>,
);
const link = container.querySelector('a[data-testid="agent-thread-doc-link"]');
diff --git a/packages/app/src/components/acp/ThreadView.tsx b/packages/app/src/components/acp/ThreadView.tsx
index b51c3f120..9c7009b20 100644
--- a/packages/app/src/components/acp/ThreadView.tsx
+++ b/packages/app/src/components/acp/ThreadView.tsx
@@ -1195,8 +1195,7 @@ export function ThreadView({
preview={imagePreview}
onOpenChange={(open) => !open && setImagePreview(null)}
/>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: drop-target — keyboard/AT users have the + picker button in the composer; drop is a pointer-only affordance. */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- drop-target — keyboard/AT users have the + picker button in the composer; drop is a pointer-only affordance.
className="relative flex min-h-0 flex-1 flex-col text-gray-800 dark:text-gray-200"
data-agent-thread-root=""
onDragEnter={(event) => {
@@ -1236,7 +1235,6 @@ export function ThreadView({
<DocPathResolverReadyContext value={resolverReady}>
<ReferenceRulesContext value={referenceRules}>
<ThreadHeader info={info} followFile={followFile} onToggleFollow={toggleFollow} />
- {}
<AgentNoticeAnnouncer
notices={agentNotices}
agentName={agentName}
@@ -1593,8 +1591,13 @@ function PermissionPostureBadge({ info }: { info: ThreadInfo }): ReactNode {
return (
<Tooltip>
<TooltipTrigger asChild>
- {/* biome-ignore lint/a11y/noNoninteractiveTabindex: a status indicator whose detail lives in its tooltip must be focusable or keyboard users can never surface it — same rationale as the tooltip-on-disabled-button span wrapper. */}
- <span tabIndex={0} role="img" aria-label={label} className={focusRing}>
+ <span
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- a status indicator whose detail lives in its tooltip must be focusable or keyboard users can never surface it — same rationale as the tooltip-on-disabled-button span wrapper.
+ tabIndex={0}
+ role="img"
+ aria-label={label}
+ className={focusRing}
+ >
<span className="inline-flex shrink-0 text-warning" data-testid="agent-thread-posture">
<ShieldAlert className="size-3.5" aria-hidden="true" />
</span>
@@ -1907,14 +1910,12 @@ function AgentSettingsPopover({
) : null}
</AgentSettingsTrigger>
</DropdownMenuTrigger>
- {}
<DropdownMenuContent
align="end"
className="w-60"
data-bug-report-launcher=""
data-testid="agent-thread-settings-popover"
>
- {}
{info.archived === true ? (
<DropdownMenuLabel
className="font-normal text-muted-foreground"
@@ -2161,9 +2162,7 @@ function ConfigSelectSub({
{selectOptionSummary(agentId, option)}
</span>
</DropdownMenuSubTrigger>
- {}
<DropdownMenuSubContent className="max-h-[min(22rem,var(--radix-dropdown-menu-content-available-height))] max-w-72 overscroll-contain">
- {}
<DropdownMenuLabel>{option.name}</DropdownMenuLabel>
<DropdownMenuRadioGroup value={option.currentValue} onValueChange={onSelect}>
{flat.map((entry) => (
@@ -2198,7 +2197,6 @@ function ConfigRadioItem({
className="items-start"
data-testid={`agent-thread-config-option-${entry.value}`}
>
- {}
<div className="flex min-w-0 flex-col">
<span className="truncate">{entry.name}</span>
{entry.description ? (
@@ -2709,7 +2707,6 @@ function ThreadAuthPrompt({
data-testid="agent-thread-notice"
>
<RegisteredAgentIcon agentId={agent.id} iconUrl={agent.iconUrl} className="size-12" />
- {}
<div className="sr-only" role="status" aria-live="polite">
{signingIn ? t`Signing in to ${agentName}` : ''}
</div>
@@ -2745,7 +2742,6 @@ function ThreadAuthPrompt({
{authPending === method.id ? (
<Spinner className="size-3.5" aria-hidden="true" />
) : null}
- {}
{signInMethods.length === 1 ? t`Sign in with ${method.name}` : method.name}
</Button>
))}
@@ -3072,7 +3068,6 @@ function MessageBubble({
className="w-full wrap-break-word text-sm text-foreground"
data-testid="agent-thread-agent-message"
>
- {}
<AgentMarkdown text={item.text} />
</div>
);
@@ -3107,7 +3102,6 @@ function MessageBubble({
/>
) : (
<>
- {}
<AgentMarkdown text={item.text} />
{attachments !== undefined && attachments.length > 0 ? (
<UserMessageAttachments attachments={attachments} />
@@ -3504,7 +3498,6 @@ function ToolCallCard({
{display.preview}
</span>
)}
- {}
<span className="ml-auto flex shrink-0 items-center gap-1.5">
<PermissionRefusalMark permission={permission} status={call.status} />
<ToolStatusIndicator
@@ -3829,7 +3822,7 @@ function ShellCommandBlock({ id, command }: { id: string; command: string }): Re
id={id}
dir="ltr"
translate="no"
- // biome-ignore lint/a11y/noNoninteractiveTabindex: keyboard-focusable scroll container — a long command scrolls inside this bounded box, and Safari leaves overflow:auto elements out of the tab order.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- keyboard-focusable scroll container — a long command scrolls inside this bounded box, and Safari leaves overflow:auto elements out of the tab order.
tabIndex={0}
className="max-h-64 overflow-auto whitespace-pre-wrap break-words rounded bg-muted/50 px-2 py-1 text-start font-mono text-[11px] leading-relaxed"
>
@@ -4121,7 +4114,6 @@ function RuntimeConsentPrompt({
<Spinner className="size-3.5 shrink-0" aria-hidden="true" />
<span id={downloadLabelId}>{t`Downloading ${item.displayName} ${item.version}…`}</span>
</div>
- {}
<Progress
value={pct}
indeterminateFillPercent={40}
@@ -4387,7 +4379,6 @@ function ContextUsageRing({
</svg>
</TooltipTrigger>
<TooltipContent side="top">
- {}
<div className="flex flex-col items-center gap-0.5 text-center">
<span className="text-background/60">{t`Context window:`}</span>
<span>{t`${percent}% used (${left}% left)`}</span>
@@ -4526,9 +4517,7 @@ function ThreadComposer({
{queue.length > 0 && !archived ? (
<QueuedMessageList threadId={info.threadId} queue={queue} turnActive={turnActive} />
) : null}
- {}
- {/* biome-ignore lint/a11y/noStaticElementInteractions: pointer-only affordance — pressing the card's whitespace focuses the composer input; keyboard/AT users reach it via Tab. See focus-composer-on-card-pointer.ts. */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- pointer-only affordance — pressing the card's whitespace focuses the composer input; keyboard/AT users reach it via Tab. See focus-composer-on-card-pointer.ts.
onMouseDown={(event) => focusComposerInputOnCardPointer(event, composerRef)}
onPaste={(event) => {
const files = collectImageFiles(event.clipboardData);
@@ -4542,8 +4531,6 @@ function ThreadComposer({
}}
className="relative cursor-text rounded-lg border border-input bg-transparent transition-colors focus-within:border-ring focus-within:ring-3 focus-within:ring-ring/50 dark:bg-input/30"
>
- {}
- {}
{hasQueuedComments ? (
<ComposerContextChips className="px-3 pt-2 pb-1">
<QueuedCommentsChip
@@ -4596,7 +4583,6 @@ function ThreadComposer({
/>
) : null}
</div>
- {}
<div className="flex items-center gap-0.5 px-1.5 pt-1 pb-1.5">
<ComposerAddMenu
composerRef={composerRef}
@@ -4647,7 +4633,6 @@ function ThreadComposer({
{usagePercent !== null && usage?.used !== undefined && usage?.size !== undefined ? (
<ContextUsageRing used={usage.used} size={usage.size} percent={usagePercent} />
) : null}
- {}
{turnActive && (cancelPending || !hasSendableContent) ? (
<Tooltip>
<TooltipTrigger asChild>
@@ -4667,12 +4652,10 @@ function ThreadComposer({
)}
</Button>
</TooltipTrigger>
- {}
<TooltipContent side="top">{t`Stop (Esc)`}</TooltipContent>
</Tooltip>
) : canQueue ? (
<>
- {}
{!isEmpty ? (
<Tooltip>
<TooltipTrigger asChild>
@@ -4694,7 +4677,6 @@ function ThreadComposer({
) : null}
<Tooltip>
<TooltipTrigger asChild>{sendButton}</TooltipTrigger>
- {}
<TooltipContent side="top">{t`Queues behind the running turn`}</TooltipContent>
</Tooltip>
</>
@@ -4851,7 +4833,6 @@ function QueuedMessageRow({
</span>
{held ? (
<>
- {}
<span className="shrink-0 font-medium text-[10px] text-muted-foreground/70 uppercase tracking-wide">
{t`Held`}
</span>
@@ -4915,8 +4896,7 @@ function QueuedMessageRow({
function ChatPanelDropOverlay({ onDismiss }: { onDismiss: () => void }): ReactNode {
const { t } = useLingui();
return (
- // biome-ignore lint/a11y/noStaticElementInteractions: transient drop overlay — keyboard/AT users never see it (drag-only surface), and click-to-dismiss is a safety escape for a stuck overlay.
- // biome-ignore lint/a11y/useKeyWithClickEvents: same reason — the overlay is drag-only, never keyboard-reachable, so a keyboard handler would be dead code.
+ // oxlint-disable-next-line jsx-a11y/no-static-element-interactions, jsx-a11y/click-events-have-key-events -- transient drop overlay — keyboard/AT users never see it (drag-only surface), and click-to-dismiss is a safety escape for a stuck overlay.
<div
className="pointer-events-auto absolute inset-0 z-20 flex items-center justify-center bg-background/85 backdrop-blur-sm"
onClick={onDismiss}
diff --git a/packages/app/src/components/acp/UserMessageActions.tsx b/packages/app/src/components/acp/UserMessageActions.tsx
index 516e48f75..5877c3285 100644
--- a/packages/app/src/components/acp/UserMessageActions.tsx
+++ b/packages/app/src/components/acp/UserMessageActions.tsx
@@ -75,7 +75,6 @@ export function UserMessageActions({
{formatSentAt(sentAt, now, i18n.locale || undefined)}
</time>
) : null}
- {}
<CopyButton
copyContent={text}
clipboardWrite={scheduleClipboardWrite}
@@ -83,7 +82,6 @@ export function UserMessageActions({
ariaLabel={t`Copy message`}
testId="agent-thread-user-message-copy"
/>
- {}
<Tooltip disableHoverableContent>
<TooltipTrigger asChild>
<Button
@@ -246,7 +244,6 @@ export function UserMessageEditor({
</DropdownMenuContent>
</DropdownMenu>
</ButtonGroup>
- {}
<span role="status" aria-live="polite" className="sr-only">
{sending ? t`Sending…` : null}
</span>
diff --git a/packages/app/src/components/composer-shared-draft.dom.test.tsx b/packages/app/src/components/composer-shared-draft.dom.test.tsx
index 82609c4b5..086377fac 100644
--- a/packages/app/src/components/composer-shared-draft.dom.test.tsx
+++ b/packages/app/src/components/composer-shared-draft.dom.test.tsx
@@ -155,7 +155,6 @@ vi.doMock('@/editor/ComposerMentionInput', () => ({
}
}}
/>
- {}
{mentionNodes.map((node, i) => (
<span
// biome-ignore lint/suspicious/noArrayIndexKey: stable list of seeded chips in a test double
@@ -166,7 +165,6 @@ vi.doMock('@/editor/ComposerMentionInput', () => ({
@{String(node.attrs?.label ?? node.attrs?.path ?? '')}
</span>
))}
- {}
<button
type="button"
data-testid={`insert-mention-${ariaLabel}`}
diff --git a/packages/app/src/components/empty-state/CopyablePromptList.tsx b/packages/app/src/components/empty-state/CopyablePromptList.tsx
index a39e57da8..d310da59f 100644
--- a/packages/app/src/components/empty-state/CopyablePromptList.tsx
+++ b/packages/app/src/components/empty-state/CopyablePromptList.tsx
@@ -48,7 +48,6 @@ export function CopyablePromptList({ scenario, className }: CopyablePromptListPr
className="group flex items-start gap-3 p-3.5"
data-testid={`copy-prompt-${suggestion.id}`}
>
- {}
<Icon className="mt-0.5 size-4 shrink-0 text-muted-foreground" aria-hidden="true" />
<div className="flex min-w-0 flex-1 flex-col gap-1.5">
<span className="text-sm font-medium leading-tight text-foreground">
diff --git a/packages/app/src/components/empty-state/CreatePromptComposer.tsx b/packages/app/src/components/empty-state/CreatePromptComposer.tsx
index 3f5187a95..986236e4a 100644
--- a/packages/app/src/components/empty-state/CreatePromptComposer.tsx
+++ b/packages/app/src/components/empty-state/CreatePromptComposer.tsx
@@ -377,8 +377,7 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
return (
<div className={cn('flex w-full flex-col gap-3', className)}>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: pointer clicks only delegate focus to the composer's editable; keyboard users focus it directly (Tab / ⌥⌘L). */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- pointer clicks only delegate focus to the composer's editable; keyboard users focus it directly (Tab / ⌥⌘L).
onMouseDown={(event) => focusComposerInputOnCardPointer(event, inputRef)}
onPaste={(event) => {
const files = collectImageFiles(event.clipboardData);
@@ -441,7 +440,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
'bg-destructive/5 outline-2 outline-dashed outline-offset-2 outline-destructive/60',
)}
>
- {}
<ComposerMentionInput
ref={inputRef}
ariaLabel={
@@ -496,7 +494,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
/>
) : null}
</div>
- {}
<div className="flex flex-wrap items-center justify-between gap-2 px-3 pb-3">
<div className="flex min-w-0 items-center gap-2">
{threadSelected ? (
@@ -583,7 +580,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
</Button>
</DropdownMenuTrigger>
<DropdownMenuContent align="end" className="max-h-80 min-w-[200px]">
- {}
{showThreadSection ? (
<DropdownMenuGroup aria-label={t`In app`}>
<DropdownMenuLabel>
@@ -619,7 +615,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
<DropdownMenuLabel>
<Trans>Terminal</Trans>
</DropdownMenuLabel>
- {}
{terminalClis.map((cli) => {
const { displayName } = TERMINAL_CLIS[cli];
return (
@@ -669,7 +664,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
</DropdownMenuGroup>
</>
) : null}
- {}
<DropdownMenuSeparator />
<DropdownMenuItem
onSelect={openAgentSettings}
@@ -689,7 +683,6 @@ export function CreatePromptComposer({ scenario, className }: CreatePromptCompos
)}
</div>
</div>
- {}
{scenario === 'new-project' && suggestions.length > 0 ? (
<div className="flex flex-wrap items-center justify-center gap-2">
<span className="text-1sm text-muted-foreground">
diff --git a/packages/app/src/components/empty-state/CreateView.tsx b/packages/app/src/components/empty-state/CreateView.tsx
index 397642d74..81bdfd637 100644
--- a/packages/app/src/components/empty-state/CreateView.tsx
+++ b/packages/app/src/components/empty-state/CreateView.tsx
@@ -43,7 +43,6 @@ export function CreateView({
onRageStreak={onRageStreak}
/>
- {}
{isEmbedded ? (
<CopyablePromptList scenario="existing-repo" />
) : (
@@ -88,7 +87,6 @@ export function FileCreationActions({
/>
) : null}
- {}
<div
data-testid="file-creation-action-row"
className={cn(
@@ -107,7 +105,6 @@ export function FileCreationActions({
<Trans>Add a starter pack</Trans>
</Button>
) : null}
- {}
<Button
variant="link-muted"
size="sm"
@@ -165,13 +162,12 @@ function TemplatesSection({
</Badge>
) : null}
</header>
- {}
{listVisible ? (
<div className="w-full overflow-hidden rounded-xl border border-border/60 bg-card">
<section
aria-busy={loading}
aria-label={t`Template list`}
- // biome-ignore lint/a11y/noNoninteractiveTabindex: focusable scroll region per WCAG 2.1.1 (keyboard-operable)
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- focusable scroll region per WCAG 2.1.1 (keyboard-operable)
tabIndex={0}
className={cn(
'subtle-scrollbar scroll-fade-mask flex max-h-[260px] w-full flex-col overflow-y-auto focus-visible:outline-none focus-visible:ring-3 focus-visible:ring-ring/50',
diff --git a/packages/app/src/components/handoff/AgentSplitButton.tsx b/packages/app/src/components/handoff/AgentSplitButton.tsx
index 06a1b4ca9..894f111ec 100644
--- a/packages/app/src/components/handoff/AgentSplitButton.tsx
+++ b/packages/app/src/components/handoff/AgentSplitButton.tsx
@@ -140,7 +140,6 @@ export function AgentSplitButton({
data-testid={testIds.menu}
{...menuAttributes}
>
- {}
{menuLeading ? (
<>
{menuLeading}
@@ -184,7 +183,6 @@ export function AgentSplitButton({
<DropdownMenuLabel>
<Trans>Terminal</Trans>
</DropdownMenuLabel>
- {}
{cliRows?.map((row) => (
<DropdownMenuItem
key={row.cli}
@@ -192,7 +190,6 @@ export function AgentSplitButton({
data-testid={terminalTestId(row.cli)}
aria-label={row.ariaLabel}
>
- {}
<TargetIcon
id={cliIconTargetId(row.cli)}
className="size-4"
@@ -253,9 +250,7 @@ export function AgentSplitButton({
) : null}
</>
) : null}
- {}
{!showThreadAgents && !hasOptions ? menuEmptyState : null}
- {}
{showThreadAgents || hasOptions ? <DropdownMenuSeparator /> : null}
<DropdownMenuItem onSelect={onOpenSettings} data-testid={testIds.settings}>
<SlidersHorizontal aria-hidden="true" className="size-4 text-muted-foreground" />
diff --git a/packages/app/src/components/handoff/OpenInAgentContextSubmenu.tsx b/packages/app/src/components/handoff/OpenInAgentContextSubmenu.tsx
index c610e36cd..0d96873c9 100644
--- a/packages/app/src/components/handoff/OpenInAgentContextSubmenu.tsx
+++ b/packages/app/src/components/handoff/OpenInAgentContextSubmenu.tsx
@@ -93,7 +93,6 @@ export function OpenInAgentContextSubmenu(props: OpenInAgentContextSubmenuProps)
<Trans>Open with AI</Trans>
</DropdownMenuSubTrigger>
<DropdownMenuSubContent className="max-h-80">
- {}
{showThreadSection ? (
<DropdownMenuGroup aria-label={t`In app`}>
<DropdownMenuLabel>
@@ -139,7 +138,6 @@ export function OpenInAgentContextSubmenu(props: OpenInAgentContextSubmenuProps)
<DropdownMenuLabel>
<Trans>Terminal</Trans>
</DropdownMenuLabel>
- {}
{terminalClis.map((cli) => {
const { displayName } = TERMINAL_CLIS[cli];
return (
@@ -168,7 +166,6 @@ export function OpenInAgentContextSubmenu(props: OpenInAgentContextSubmenuProps)
) : null}
{showDesktopSection ? (
<>
- {}
{showTerminalSection ? <DropdownMenuSeparator /> : null}
<DropdownMenuGroup aria-label={t`External apps`}>
<DropdownMenuLabel className="flex items-center gap-1.5">
@@ -215,7 +212,6 @@ export function OpenInAgentContextSubmenu(props: OpenInAgentContextSubmenuProps)
</DropdownMenuGroup>
</>
) : null}
- {}
{showThreadSection || showTerminalSection || showDesktopSection ? (
<DropdownMenuSeparator />
) : null}
diff --git a/packages/app/src/components/handoff/OpenInAgentEmptySpaceSubmenu.tsx b/packages/app/src/components/handoff/OpenInAgentEmptySpaceSubmenu.tsx
index 523d741cd..c62db6f3b 100644
--- a/packages/app/src/components/handoff/OpenInAgentEmptySpaceSubmenu.tsx
+++ b/packages/app/src/components/handoff/OpenInAgentEmptySpaceSubmenu.tsx
@@ -91,7 +91,6 @@ export function OpenInAgentEmptySpaceSubmenu(props: OpenInAgentEmptySpaceSubmenu
<Trans>Open with AI</Trans>
</ContextMenuSubTrigger>
<ContextMenuSubContent className="max-h-80">
- {}
{showThreadSection ? (
<ContextMenuGroup aria-label={t`In app`}>
<ContextMenuLabel>
@@ -136,7 +135,6 @@ export function OpenInAgentEmptySpaceSubmenu(props: OpenInAgentEmptySpaceSubmenu
<ContextMenuLabel>
<Trans>Terminal</Trans>
</ContextMenuLabel>
- {}
{terminalClis.map((cli) => {
const { displayName } = TERMINAL_CLIS[cli];
return (
@@ -164,7 +162,6 @@ export function OpenInAgentEmptySpaceSubmenu(props: OpenInAgentEmptySpaceSubmenu
) : null}
{showDesktopSection ? (
<>
- {}
{showTerminalSection ? <ContextMenuSeparator /> : null}
<ContextMenuGroup aria-label={t`External apps`}>
<ContextMenuLabel className="flex items-center gap-1.5">
@@ -209,7 +206,6 @@ export function OpenInAgentEmptySpaceSubmenu(props: OpenInAgentEmptySpaceSubmenu
</ContextMenuGroup>
</>
) : null}
- {}
{showThreadSection || showTerminalSection || showDesktopSection ? (
<ContextMenuSeparator />
) : null}
diff --git a/packages/app/src/components/icons/openclaw.tsx b/packages/app/src/components/icons/openclaw.tsx
index 22e9b6f5a..66eaeac50 100644
--- a/packages/app/src/components/icons/openclaw.tsx
+++ b/packages/app/src/components/icons/openclaw.tsx
@@ -20,14 +20,10 @@ export function OpenClawIcon(props: SVGProps<SVGSVGElement>) {
<circle cx={75} cy={35} r={6} fill="black" />
</mask>
<g fill="currentColor" mask={`url(#${maskId})`}>
- {}
<path d="M60 10 C30 10 15 35 15 55 C15 75 30 95 45 100 L45 110 L55 110 L55 100 C55 100 60 102 65 100 L65 110 L75 110 L75 100 C90 95 105 75 105 55 C105 35 90 10 60 10Z" />
- {}
<path d="M20 45 C5 40 0 50 5 60 C10 70 20 65 25 55 C28 48 25 45 20 45Z" />
- {}
<path d="M100 45 C115 40 120 50 115 60 C110 70 100 65 95 55 C92 48 95 45 100 45Z" />
</g>
- {}
<path
d="M45 15 Q35 5 30 8"
fill="none"
diff --git a/packages/app/src/components/resizable-panel-pointerleave-delta.dom.test.tsx b/packages/app/src/components/resizable-panel-pointerleave-delta.dom.test.tsx
index cbbb8ce77..8e52dcf42 100644
--- a/packages/app/src/components/resizable-panel-pointerleave-delta.dom.test.tsx
+++ b/packages/app/src/components/resizable-panel-pointerleave-delta.dom.test.tsx
@@ -35,7 +35,6 @@ function CollapsibleRightGroup() {
editor
</Panel>
<Separator />
- {}
<Panel
id="right"
collapsible
diff --git a/packages/app/src/components/settings/AgentConnectionDialogs.tsx b/packages/app/src/components/settings/AgentConnectionDialogs.tsx
index a9826295d..fabff5579 100644
--- a/packages/app/src/components/settings/AgentConnectionDialogs.tsx
+++ b/packages/app/src/components/settings/AgentConnectionDialogs.tsx
@@ -335,7 +335,6 @@ function PartCheckbox({
className="items-start gap-3"
data-disabled={disabled || undefined}
>
- {}
<div className="flex h-7 items-center">
<Checkbox
id={id}
@@ -350,12 +349,10 @@ function PartCheckbox({
<Label htmlFor={id} className="cursor-pointer">
<FieldTitle>{title}</FieldTitle>
</Label>
- {}
{warning !== null ? (
<PartExceptionChip message={warning} path={path} info={disabled ? null : info} />
) : (
<PartInfo>
- {}
<span className="flex flex-col gap-1.5">
{info}
{path === null ? null : (
@@ -380,7 +377,6 @@ function PartCheckbox({
))}
</div>
)}
- {}
{alsoAffects === null ? null : (
<p id={sharedId} className="text-sm leading-relaxed text-warning">
{t`This folder is also ${alsoAffects}'s.`}
diff --git a/packages/app/src/components/settings/AgentConnectionsSection.tsx b/packages/app/src/components/settings/AgentConnectionsSection.tsx
index 1e0edbf0a..3da7e3a7f 100644
--- a/packages/app/src/components/settings/AgentConnectionsSection.tsx
+++ b/packages/app/src/components/settings/AgentConnectionsSection.tsx
@@ -124,7 +124,6 @@ function AgentRow({
return (
<div className="flex items-center justify-between gap-3 px-3 py-2.5" data-testid={rowTestId}>
<div className="flex min-w-0 items-start gap-2.5">
- {}
<span className="flex h-5 shrink-0 items-center">{icon}</span>
<div className="flex min-w-0 flex-col">
<span className="truncate text-sm leading-5">{name}</span>
diff --git a/packages/app/src/components/settings/BuiltInSkillsSection.tsx b/packages/app/src/components/settings/BuiltInSkillsSection.tsx
index 489c2048b..12ddbfef3 100644
--- a/packages/app/src/components/settings/BuiltInSkillsSection.tsx
+++ b/packages/app/src/components/settings/BuiltInSkillsSection.tsx
@@ -105,7 +105,6 @@ export function BuiltInSkillsSection() {
data-testid="settings-builtin-skills"
>
{heading}
- {}
<div
role="status"
aria-live="polite"
diff --git a/packages/app/src/components/settings/ColorThemePicker.tsx b/packages/app/src/components/settings/ColorThemePicker.tsx
index f75392770..734311fa5 100644
--- a/packages/app/src/components/settings/ColorThemePicker.tsx
+++ b/packages/app/src/components/settings/ColorThemePicker.tsx
@@ -103,7 +103,6 @@ function ThemeSwatch({
className="aspect-[4/3] w-full overflow-hidden rounded-md border"
style={{ backgroundColor: c.surface, borderColor: c.line }}
>
- {}
<div
className="flex h-1/3 items-center gap-1 px-1.5"
style={{ backgroundColor: c.chrome, borderBottom: `1px solid ${c.line}` }}
@@ -114,7 +113,6 @@ function ThemeSwatch({
style={{ backgroundColor: c.line }}
/>
</div>
- {}
<div className="flex h-2/3">
<div
className="flex w-1/4 flex-col items-center justify-center gap-1"
diff --git a/packages/app/src/components/settings/CustomThemeEditor.tsx b/packages/app/src/components/settings/CustomThemeEditor.tsx
index 9aa3b7841..b5484d6c0 100644
--- a/packages/app/src/components/settings/CustomThemeEditor.tsx
+++ b/packages/app/src/components/settings/CustomThemeEditor.tsx
@@ -379,7 +379,6 @@ export function CustomThemeEditor({
</div>
</div>
- {}
<ThemePreviewCanvas scheme={scheme} highlightSlot={hoveredSlot} className="w-full" />
<ColorWorkbench
diff --git a/packages/app/src/components/settings/LanguageSelect.tsx b/packages/app/src/components/settings/LanguageSelect.tsx
index 6d44b9a20..68d85e7b2 100644
--- a/packages/app/src/components/settings/LanguageSelect.tsx
+++ b/packages/app/src/components/settings/LanguageSelect.tsx
@@ -56,7 +56,6 @@ export function LanguageSelect({
const choice = toLanguageChoice(value);
return (
<Select value={choice} onValueChange={(next) => onValueChange(toLanguageChoice(next))}>
- {}
<SelectTrigger {...slotForwarded} ref={ref} onBlur={onBlur} size="sm" className="w-48">
<SelectValue>
<ChoiceLabel choice={choice} />
diff --git a/packages/app/src/components/settings/LintingSection.tsx b/packages/app/src/components/settings/LintingSection.tsx
index 88ba79bdb..5cd4e090a 100644
--- a/packages/app/src/components/settings/LintingSection.tsx
+++ b/packages/app/src/components/settings/LintingSection.tsx
@@ -625,7 +625,6 @@ export function OkfPluginSection() {
<Label htmlFor="settings-okf-generate-index" className="text-sm font-medium">
<Trans>Maintain index.md</Trans>
</Label>
- {}
<p className="text-sm text-muted-foreground">
<Trans>
Open Knowledge maintains a navigation file named index.md in every folder that
diff --git a/packages/app/src/components/settings/NetworkAccessSection.tsx b/packages/app/src/components/settings/NetworkAccessSection.tsx
index 0a38fb26e..1514e0d83 100644
--- a/packages/app/src/components/settings/NetworkAccessSection.tsx
+++ b/packages/app/src/components/settings/NetworkAccessSection.tsx
@@ -392,7 +392,6 @@ export function NetworkAccessSection() {
{portError}
</p>
) : null}
- {}
{portUnavailable && !probeUnavailableRedundant ? (
<p
id="settings-network-port-unavailable"
@@ -415,7 +414,6 @@ export function NetworkAccessSection() {
{t`Port ${portDraft.trim()} is available.`}
</p>
) : null}
- {}
{portInUse && !applying ? (
<p
id="settings-network-port-inuse"
diff --git a/packages/app/src/components/settings/OkCliPathRow.tsx b/packages/app/src/components/settings/OkCliPathRow.tsx
index c6a2b3ee1..3f3d17948 100644
--- a/packages/app/src/components/settings/OkCliPathRow.tsx
+++ b/packages/app/src/components/settings/OkCliPathRow.tsx
@@ -56,7 +56,6 @@ export function OkCliPathRow() {
return (
<div className="flex flex-col gap-1.5" data-testid="ok-cli-path-row">
- {}
<div className="flex items-start overflow-hidden rounded-md border border-border bg-card/50 hover:bg-accent">
<Label
htmlFor="ok-cli-path"
@@ -99,7 +98,6 @@ export function OkCliPathRow() {
<Info className="size-3.5" />
</Button>
</TooltipTrigger>
- {}
<TooltipContent side="left" className="max-w-sm text-left">
<div className="flex min-w-0 flex-col gap-1">
<p className="opacity-70">
diff --git a/packages/app/src/components/settings/ProjectSkillSection.tsx b/packages/app/src/components/settings/ProjectSkillSection.tsx
index 47dc23a6f..8134b14e4 100644
--- a/packages/app/src/components/settings/ProjectSkillSection.tsx
+++ b/packages/app/src/components/settings/ProjectSkillSection.tsx
@@ -21,7 +21,6 @@ export function ProjectSkillSection() {
const heading = (
<div>
<h4 className="text-sm font-medium">
- {}
<Trans comment="Heading above the project's own skill row, in Settings → This project → Skills Studio">
Skills from OpenKnowledge
</Trans>
@@ -56,7 +55,6 @@ export function ProjectSkillSection() {
data-testid="settings-project-skill"
>
{heading}
- {}
<div
role="status"
aria-live="polite"
diff --git a/packages/app/src/components/settings/ScopeBadge.tsx b/packages/app/src/components/settings/ScopeBadge.tsx
index c9a0b30ee..c9dc651f9 100644
--- a/packages/app/src/components/settings/ScopeBadge.tsx
+++ b/packages/app/src/components/settings/ScopeBadge.tsx
@@ -9,7 +9,6 @@ export function ScopeBadge({ scope }: { scope: SettingsScope }) {
<TooltipProvider>
<Tooltip>
<TooltipTrigger asChild>
- {}
<Badge
variant="gray"
tabIndex={0}
diff --git a/packages/app/src/components/settings/SearchSection.tsx b/packages/app/src/components/settings/SearchSection.tsx
index 30353277c..f89a07769 100644
--- a/packages/app/src/components/settings/SearchSection.tsx
+++ b/packages/app/src/components/settings/SearchSection.tsx
@@ -364,7 +364,6 @@ export function SearchSection({ transport }: { transport?: EmbeddingsKeyTranspor
data-testid="settings-search-base-url"
className="h-8 font-mono text-sm"
/>
- {}
<p
id="settings-search-base-url-message"
aria-live="polite"
diff --git a/packages/app/src/components/settings/SettingsDialogShell.tsx b/packages/app/src/components/settings/SettingsDialogShell.tsx
index 76fb5f3c5..d497353aa 100644
--- a/packages/app/src/components/settings/SettingsDialogShell.tsx
+++ b/packages/app/src/components/settings/SettingsDialogShell.tsx
@@ -507,7 +507,7 @@ function SettingsDialogFrame({
ref={contentRef}
aria-label={t`Settings content`}
className="min-h-0 flex-1 overflow-y-auto overscroll-contain subtle-scrollbar p-6"
- // biome-ignore lint/a11y/noNoninteractiveTabindex: this scrollable content section must be focusable so keyboard users can scroll long settings pages.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- this scrollable content section must be focusable so keyboard users can scroll long settings pages.
tabIndex={0}
>
<SettingsConfigNotices onDismissFocus={() => contentRef.current?.focus()} />
@@ -563,7 +563,6 @@ function SettingsSidebar({
aria-label={t`Settings sections`}
className="flex shrink-0 gap-x-3 overflow-x-auto overscroll-contain subtle-scrollbar scroll-fade-mask-x-max-sm border-b bg-muted/30 px-3 py-2 max-sm:pt-10 sm:h-full sm:min-h-0 sm:flex-col sm:gap-0 sm:overflow-x-visible sm:border-r sm:border-b-0 sm:py-4"
>
- {}
<Command
shouldFilter={false}
className="h-auto w-full shrink-0 bg-transparent sm:mb-3 [&_[data-slot=command-input-wrapper]]:h-9 [&_[data-slot=command-input-wrapper]]:rounded-lg [&_[data-slot=command-input-wrapper]]:border [&_[data-slot=command-input-wrapper]]:border-input"
@@ -576,7 +575,6 @@ function SettingsSidebar({
className="py-0"
data-testid="settings-search-input"
/>
- {}
<span aria-live="polite" className="sr-only" data-testid="settings-search-result-count">
{query !== '' ? <Plural value={results.length} one="# result" other="# results" /> : null}
</span>
@@ -625,9 +623,7 @@ function SettingsSidebar({
) : null}
</Command>
- {}
<div className="contents subtle-scrollbar sm:flex sm:min-h-0 sm:flex-1 sm:flex-col sm:overflow-y-auto sm:overscroll-contain">
- {}
{query === ''
? groups.map((group) => (
<SettingsSidebarGroup
@@ -659,7 +655,6 @@ function SettingsSearchResultItem({
onSelect={() => onNavigate(entry)}
data-testid={`settings-search-result-${entry.id}`}
>
- {}
<span className="min-w-0 truncate">
{splitTextByQueryMatches(entry.label, query).map((segment) =>
segment.match ? (
@@ -671,7 +666,6 @@ function SettingsSearchResultItem({
),
)}
</span>
- {}
{entry.context !== undefined ? (
<span className="ms-auto shrink-0 truncate ps-3 text-1sm text-muted-foreground">
{entry.context}
diff --git a/packages/app/src/components/settings/SettingsSectionHeader.tsx b/packages/app/src/components/settings/SettingsSectionHeader.tsx
index 1ea04929f..fcc1bea47 100644
--- a/packages/app/src/components/settings/SettingsSectionHeader.tsx
+++ b/packages/app/src/components/settings/SettingsSectionHeader.tsx
@@ -42,7 +42,7 @@ export function SettingsSectionHeader({
</div>
{children ? <p className="text-sm text-muted-foreground">{children}</p> : null}
{docUrl !== undefined ? (
- // biome-ignore lint/a11y/noAmbiguousAnchorText: the accessible name comes from aria-label, which this rule only recognises as a string literal; the i18n directive requires the t macro.
+ // oxlint-disable-next-line jsx-a11y/anchor-ambiguous-text -- the accessible name comes from aria-label, which this rule only recognises as a string literal; the i18n directive requires the t macro.
<a
href={docUrl}
target="_blank"
diff --git a/packages/app/src/components/settings/SharingSection.tsx b/packages/app/src/components/settings/SharingSection.tsx
index c8b415fec..8fd58b17e 100644
--- a/packages/app/src/components/settings/SharingSection.tsx
+++ b/packages/app/src/components/settings/SharingSection.tsx
@@ -120,7 +120,6 @@ function SharingSectionBody() {
scope="project"
level="block"
/>
- {}
<div role="status" aria-live="polite" aria-busy="true">
<span className="sr-only">
<Trans>Loading config sharing</Trans>
@@ -174,7 +173,6 @@ function SharingSectionBody() {
aria-labelledby={TITLE_ID}
data-testid="settings-sharing-radiogroup"
>
- {}
<label htmlFor="settings-sharing-local-only" className="flex items-start gap-2 text-sm">
<RadioGroupItem
id="settings-sharing-local-only"
diff --git a/packages/app/src/components/settings/SkillFolderLinkConfirmDialog.tsx b/packages/app/src/components/settings/SkillFolderLinkConfirmDialog.tsx
index 1e68d52f4..87095dd6a 100644
--- a/packages/app/src/components/settings/SkillFolderLinkConfirmDialog.tsx
+++ b/packages/app/src/components/settings/SkillFolderLinkConfirmDialog.tsx
@@ -88,7 +88,6 @@ export function SkillFolderLinkConfirmDialog({
</AlertDialogDescription>
</AlertDialogHeader>
<AlertDialogBody className="flex flex-col gap-4 py-1">
- {}
<div className="flex items-center gap-2" data-testid="skill-folder-link-direction">
<div className="min-w-0 flex-1 rounded border border-border/60 px-2 py-1.5">
<code className="block break-all font-mono text-[11px]">{pick}</code>
diff --git a/packages/app/src/components/settings/SkillTargetsPicker.tsx b/packages/app/src/components/settings/SkillTargetsPicker.tsx
index ad2a1e637..70f918153 100644
--- a/packages/app/src/components/settings/SkillTargetsPicker.tsx
+++ b/packages/app/src/components/settings/SkillTargetsPicker.tsx
@@ -141,7 +141,6 @@ export function SkillTargetsPicker({ scope }: { scope: SkillScope }) {
<AgentBrandIcon host={f.host} aria-hidden className="size-4 shrink-0" />
<span className="min-w-0 flex-1 truncate font-mono text-xs">
{display}
- {}
{f.state === 'linked' || f.state === 'linked-parent' ? (
<span className="text-muted-foreground"> → {f.target ?? '?'}</span>
) : null}
@@ -183,7 +182,6 @@ export function SkillTargetsPicker({ scope }: { scope: SkillScope }) {
<Trans>Link</Trans>
</Button>
</DropdownMenuTrigger>
- {}
<DropdownMenuContent align="end" className="w-auto">
{targets.map((o) => (
<DropdownMenuItem
@@ -214,7 +212,6 @@ export function SkillTargetsPicker({ scope }: { scope: SkillScope }) {
</Button>
) : null}
</div>
- {}
{following.length > 0 ? (
<p
className="mt-1 ml-6 text-muted-foreground text-xs"
@@ -226,7 +223,6 @@ export function SkillTargetsPicker({ scope }: { scope: SkillScope }) {
)} share this folder.`}
</p>
) : null}
- {}
{following.length > 0 ? (
<ul
className="mt-1 ml-2 space-y-1 border-border/60 border-l pl-3"
@@ -273,7 +269,6 @@ export function SkillTargetsPicker({ scope }: { scope: SkillScope }) {
})}
</ul>
)}
- {}
<form
className="flex items-center gap-2 pt-1"
onSubmit={(e) => {
diff --git a/packages/app/src/components/settings/SlidesPluginSection.tsx b/packages/app/src/components/settings/SlidesPluginSection.tsx
index 42b65573c..32343f6eb 100644
--- a/packages/app/src/components/settings/SlidesPluginSection.tsx
+++ b/packages/app/src/components/settings/SlidesPluginSection.tsx
@@ -108,7 +108,6 @@ function StatusRow({ availability }: { availability: Availability }) {
return (
<div className="space-y-3" data-testid="slides-status-missing">
- {}
<p className="text-sm text-warning">
<Trans>
Slidev isn't installed, so the Slidev action stays hidden. Install it, then return to this
@@ -187,7 +186,6 @@ export function SlidesPluginSection() {
Slidev CLI, which OpenKnowledge does not bundle.
</Trans>
</SettingsSectionHeader>
- {}
<div aria-live="polite">
<StatusRow availability={availability} />
</div>
diff --git a/packages/app/src/components/settings/SyncSection.tsx b/packages/app/src/components/settings/SyncSection.tsx
index a09fbd9db..7d167329d 100644
--- a/packages/app/src/components/settings/SyncSection.tsx
+++ b/packages/app/src/components/settings/SyncSection.tsx
@@ -434,7 +434,6 @@ function SyncSectionContent({
{genuineReadOnlyDenied ? (
<Tooltip>
<TooltipTrigger asChild>
- {}
<span className="inline-flex">
<ToggleGroupItem
value="full"
@@ -524,7 +523,6 @@ function SyncSectionContent({
<SyncRefusedSymlinks paths={status.refusedSymlinkPaths} />
</div>
)}
- {}
{status.pushPermission?.checkStatus === 'denied' &&
(parkedOnNotFound || showSwitchToPullOnly || showDeniedHint) ? (
<div className="mt-2 space-y-1" data-testid="settings-sync-identity">
@@ -551,7 +549,6 @@ function SyncSectionContent({
</div>
)}
</div>
- {}
{mode !== 'off' && (
<Collapsible open={advancedOpen} onOpenChange={setAdvancedOpen}>
<CollapsibleTrigger asChild>
@@ -651,7 +648,6 @@ function SyncSectionContent({
)}
<div className="rounded-md border p-3 space-y-2" data-testid="settings-sync-default">
<div className="space-y-0.5">
- {}
<div className="flex items-center gap-2">
<div id="settings-sync-default-label" className="text-sm font-medium">
<Trans>Shared default</Trans>
diff --git a/packages/app/src/components/settings/TerminalSection.tsx b/packages/app/src/components/settings/TerminalSection.tsx
index b0ec51c52..63566f91f 100644
--- a/packages/app/src/components/settings/TerminalSection.tsx
+++ b/packages/app/src/components/settings/TerminalSection.tsx
@@ -72,7 +72,6 @@ export function TerminalSection() {
data-field="section:terminal"
data-testid="settings-terminal"
>
- {}
<SettingsSectionHeader
titleId="settings-terminal-title"
title={t`Terminal`}
diff --git a/packages/app/src/components/settings/ThemePreviewCanvas.tsx b/packages/app/src/components/settings/ThemePreviewCanvas.tsx
index 3179ab840..c74f537fd 100644
--- a/packages/app/src/components/settings/ThemePreviewCanvas.tsx
+++ b/packages/app/src/components/settings/ThemePreviewCanvas.tsx
@@ -54,7 +54,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
)}
style={{ backgroundColor: p.base00, color: p.base05, borderColor: p.base02 }}
>
- {}
<div
className="flex items-center gap-1.5 px-2 py-1.5"
style={{ backgroundColor: p.base01, borderBottom: `1px solid ${p.base02}` }}
@@ -73,7 +72,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
</div>
<div className="flex">
- {}
<div
className="w-[26%] shrink-0 space-y-[3px] p-1.5"
style={{ backgroundColor: p.base01, borderRight: `1px solid ${p.base02}` }}
@@ -94,7 +92,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
</Lit>
</div>
- {}
<div className="min-w-0 flex-1 space-y-1.5 p-2">
<Lit slot="base0D" active={hl} className="block font-semibold">
<span style={{ color: tok['syntax-func'] }}>{t`Release plan`}</span>
@@ -110,7 +107,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
<span style={{ color: p.base05 }}>.</span>
</div>
- {}
<Lit
slot="base0A"
active={hl}
@@ -125,7 +121,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
</span>
</Lit>
- {}
<div
className="rounded px-1.5 py-1 font-mono"
style={{ backgroundColor: tok['syntax-bg'] }}
@@ -154,7 +149,6 @@ export function ThemePreviewCanvas({ scheme, highlightSlot, className }: ThemePr
</div>
</div>
- {}
<div
className="flex items-center gap-1 rounded px-1.5 py-1 font-mono"
style={{ backgroundColor: p.base00, border: `1px solid ${p.base02}` }}
diff --git a/packages/app/src/components/settings/field-controls.theme-cards.dom.test.tsx b/packages/app/src/components/settings/field-controls.theme-cards.dom.test.tsx
index 23e0c846e..a1d3c6739 100644
--- a/packages/app/src/components/settings/field-controls.theme-cards.dom.test.tsx
+++ b/packages/app/src/components/settings/field-controls.theme-cards.dom.test.tsx
@@ -39,9 +39,7 @@ function Harness({ theme }: { theme?: 'system' | 'light' | 'dark' }) {
});
return (
<>
- {}
<span data-testid="dirty-fields">{JSON.stringify(form.formState.dirtyFields)}</span>
- {}
<TooltipProvider>
<FormProvider {...form}>
<SettingsField
diff --git a/packages/app/src/components/settings/markdownlint-rule-browser.tsx b/packages/app/src/components/settings/markdownlint-rule-browser.tsx
index 75d261745..82f579ad9 100644
--- a/packages/app/src/components/settings/markdownlint-rule-browser.tsx
+++ b/packages/app/src/components/settings/markdownlint-rule-browser.tsx
@@ -242,7 +242,6 @@ function RuleRow({
return (
<Collapsible data-testid={`markdownlint-rule-row-${rule.id}`}>
<div className="flex items-center justify-between gap-3 px-3 py-2">
- {}
<CollapsibleTrigger
className="group flex min-w-0 flex-1 items-center gap-1.5 rounded-md py-0.5 text-left hover:bg-muted/50"
data-testid={`markdownlint-rule-expand-${rule.id}`}
diff --git a/packages/app/src/components/settings/rule-option-field.dom.test.tsx b/packages/app/src/components/settings/rule-option-field.dom.test.tsx
index 7f2a9d085..4155302de 100644
--- a/packages/app/src/components/settings/rule-option-field.dom.test.tsx
+++ b/packages/app/src/components/settings/rule-option-field.dom.test.tsx
@@ -258,7 +258,7 @@ describe('RuleOptionField — string', () => {
<RuleOptionField
ruleId="MD001"
spec={catalogSpec('MD001', 'front_matter_title')}
- value={'^title:'}
+ value="^title:"
onChange={onChange}
/>,
);
@@ -293,7 +293,7 @@ describe('RuleOptionField — enum', () => {
<RuleOptionField
ruleId="MD003"
spec={catalogSpec('MD003', 'style')}
- value={'atx'}
+ value="atx"
onChange={() => {}}
/>,
);
diff --git a/packages/app/src/components/share-receive-miss-content.tsx b/packages/app/src/components/share-receive-miss-content.tsx
index 0894b74e0..3cb4d4099 100644
--- a/packages/app/src/components/share-receive-miss-content.tsx
+++ b/packages/app/src/components/share-receive-miss-content.tsx
@@ -158,7 +158,6 @@ function SyncNowButton({
<Trans>Sync now</Trans>
</Button>
)}
- {}
<span
role="status"
aria-live="polite"
@@ -276,7 +275,6 @@ function PullNowButton({ pending, onPull }: { pending: boolean; onPull: () => vo
<Trans>Pull latest changes</Trans>
</Button>
)}
- {}
<span
role="status"
aria-live="polite"
@@ -555,7 +553,6 @@ export function ShareReceiveMissContent({
</div>
<p className="max-w-md text-balance text-base leading-6 text-foreground/90">{message}</p>
{failureLine}
- {}
<div className="flex flex-col-reverse gap-2 sm:flex-row sm:flex-wrap sm:justify-center">
{actions}
</div>
diff --git a/packages/app/src/components/ui/alert-dialog.tsx b/packages/app/src/components/ui/alert-dialog.tsx
index c9ee72585..5d5c6e323 100644
--- a/packages/app/src/components/ui/alert-dialog.tsx
+++ b/packages/app/src/components/ui/alert-dialog.tsx
@@ -45,7 +45,6 @@ function AlertDialogContent({
return (
<AlertDialogPortal>
<AlertDialogOverlay {...overlayProps} />
- {}
<ElectronDragStrip testId="alert-dialog-drag-strip" />
<AlertDialogPrimitive.Content
data-slot="alert-dialog-content"
diff --git a/packages/app/src/components/ui/command.tsx b/packages/app/src/components/ui/command.tsx
index ef1bf59a7..657cd53a9 100644
--- a/packages/app/src/components/ui/command.tsx
+++ b/packages/app/src/components/ui/command.tsx
@@ -47,7 +47,6 @@ function CommandDialog({
onEscapeKeyDown={onEscapeKeyDown}
{...contentAttributes}
>
- {}
<DialogTitle className="sr-only">{title}</DialogTitle>
<DialogDescription className="sr-only">{description}</DialogDescription>
<Command
diff --git a/packages/app/src/components/ui/dialog.tsx b/packages/app/src/components/ui/dialog.tsx
index 55cdafd78..71e81f0c1 100644
--- a/packages/app/src/components/ui/dialog.tsx
+++ b/packages/app/src/components/ui/dialog.tsx
@@ -51,7 +51,6 @@ function DialogContent({
return (
<DialogPortal>
<DialogOverlay />
- {}
<ElectronDragStrip testId="dialog-drag-strip" />
<DialogPrimitive.Content
data-slot="dialog-content"
diff --git a/packages/app/src/components/ui/dropdown-menu.tsx b/packages/app/src/components/ui/dropdown-menu.tsx
index cff5dde9d..db7270d43 100644
--- a/packages/app/src/components/ui/dropdown-menu.tsx
+++ b/packages/app/src/components/ui/dropdown-menu.tsx
@@ -131,7 +131,6 @@ function DropdownMenuRadioItem({
data-slot="dropdown-menu-radio-item-indicator"
>
<DropdownMenuPrimitive.ItemIndicator>
- {}
<CircleIcon className="size-2 fill-primary stroke-primary" />
</DropdownMenuPrimitive.ItemIndicator>
</span>
diff --git a/packages/app/src/components/ui/input-group.tsx b/packages/app/src/components/ui/input-group.tsx
index 027628237..cd44c7342 100644
--- a/packages/app/src/components/ui/input-group.tsx
+++ b/packages/app/src/components/ui/input-group.tsx
@@ -43,7 +43,7 @@ function InputGroupAddon({
...props
}: React.ComponentProps<'div'> & VariantProps<typeof inputGroupAddonVariants>) {
return (
- // biome-ignore lint/a11y/noStaticElementInteractions: pointer clicks only delegate focus to the sibling input; keyboard users can focus that input directly.
+ // oxlint-disable-next-line jsx-a11y/no-static-element-interactions -- pointer clicks only delegate focus to the sibling input; keyboard users can focus that input directly.
<div
data-slot="input-group-addon"
data-align={align}
diff --git a/packages/app/src/components/ui/sidebar-escape.dom.test.tsx b/packages/app/src/components/ui/sidebar-escape.dom.test.tsx
index 930f551ee..5ebbabd4b 100644
--- a/packages/app/src/components/ui/sidebar-escape.dom.test.tsx
+++ b/packages/app/src/components/ui/sidebar-escape.dom.test.tsx
@@ -28,7 +28,6 @@ function renderNarrowSidebar(onOpenChange: (open: boolean) => void) {
return render(
<SidebarProvider open onOpenChange={onOpenChange}>
<textarea data-testid="field" aria-label="a text field" />
- {}
<div data-testid="editor" contentEditable suppressContentEditableWarning />
<div data-testid="plain">not a text surface</div>
</SidebarProvider>,
diff --git a/packages/app/src/components/ui/tag-pill-input.tsx b/packages/app/src/components/ui/tag-pill-input.tsx
index fda35e508..d64e386b4 100644
--- a/packages/app/src/components/ui/tag-pill-input.tsx
+++ b/packages/app/src/components/ui/tag-pill-input.tsx
@@ -149,7 +149,6 @@ function TagPillInput({
highlighted && 'ring-2 ring-ring/70',
)}
>
- {}
<button
type="button"
tabIndex={-1}
diff --git a/packages/app/src/editor/ComposerMentionInput.tsx b/packages/app/src/editor/ComposerMentionInput.tsx
index 008520252..4ef834422 100644
--- a/packages/app/src/editor/ComposerMentionInput.tsx
+++ b/packages/app/src/editor/ComposerMentionInput.tsx
@@ -332,8 +332,11 @@ export function ComposerMentionInput({
return (
<>
- {/* oxlint-disable-next-line ok/no-unportaled-editor-content -- standalone single-instance composer editor — not an Activity-pool document editor. EditorContent's own wrapper element still exclusively parents view.dom (every other node this component renders is a sibling of that wrapper, never inside it), so the H6 cross-doc DOM vacuum the portal guards against (precedent #44) cannot apply here. */}
- <EditorContent editor={editor} className={className} {...dropSurfaceProps} />
+ <EditorContent // oxlint-disable-line ok/no-unportaled-editor-content -- standalone single-instance composer editor — not an Activity-pool document editor. EditorContent's own wrapper element still exclusively parents view.dom (every other node this component renders is a sibling of that wrapper, never inside it), so the H6 cross-doc DOM vacuum the portal guards against (precedent #44) cannot apply here.
+ editor={editor}
+ className={className}
+ {...dropSurfaceProps}
+ />
{dropPolicy.kind !== 'host' ? (
<div role="status" aria-live="polite" data-testid="composer-drop-refusal">
{dropRefusal !== null ? (
@@ -343,7 +346,6 @@ export function ComposerMentionInput({
) : null}
</div>
) : null}
- {}
{slashCommands !== undefined ? (
<p
className={cn(
diff --git a/packages/app/src/editor/TiptapEditor.tsx b/packages/app/src/editor/TiptapEditor.tsx
index e754738c6..cd6dfcf9e 100644
--- a/packages/app/src/editor/TiptapEditor.tsx
+++ b/packages/app/src/editor/TiptapEditor.tsx
@@ -1264,11 +1264,9 @@ const TiptapEditorChrome: FC<TiptapEditorChromeProps> = ({
data-agent-flash-position="append"
data-agent-flash-agent-id=""
>
- {}
{!isSourceMode && editorPaneOnScreen && (
<BubbleMenuBar editor={editor} shortcutEnabled={docName === activeDocName} />
)}
- {}
{!isSourceMode && (
<CommentsBoundary>
<CommentSelectionAffordance
@@ -1281,8 +1279,6 @@ const TiptapEditorChrome: FC<TiptapEditorChromeProps> = ({
</CommentsBoundary>
)}
{!isSourceMode && <TableCellHandles editor={editor} />}
- {}
- {}
<div ref={portalSlotRef} style={{ display: 'contents' }} />
{createPortal(
// oxlint-disable-next-line ok/no-unportaled-editor-content -- canonical portaled site — H6 fix per PRECEDENTS.md #44
@@ -1293,13 +1289,14 @@ const TiptapEditorChrome: FC<TiptapEditorChromeProps> = ({
/>,
portalTarget,
)}
- {}
<SelectionAnnouncer editor={editor} />
- {/**
- * RawMdxFallback renders inline via `RawMdxFallbackCMView` (precedent #30) and never
- * registers with InteractionLayer.
- */}
- <InteractionLayerView store={getInteractionLayer(editor).store} />
+ <InteractionLayerView
+ /**
+ * RawMdxFallback renders inline via `RawMdxFallbackCMView` (precedent #30) and never
+ * registers with InteractionLayer.
+ */
+ store={getInteractionLayer(editor).store}
+ />
</div>
);
};
diff --git a/packages/app/src/editor/components/CodePreviewEditModal.tsx b/packages/app/src/editor/components/CodePreviewEditModal.tsx
index 492b78adc..aa6151c09 100644
--- a/packages/app/src/editor/components/CodePreviewEditModal.tsx
+++ b/packages/app/src/editor/components/CodePreviewEditModal.tsx
@@ -216,7 +216,6 @@ export function CodePreviewEditModal({
className={`flex min-h-0 flex-1 gap-3 overflow-y-auto overscroll-contain ${previewEnabled ? 'flex-col md:flex-row-reverse' : 'flex-col'}`}
data-testid="ok-code-preview-edit-modal-body"
>
- {}
<div
ref={setHostRef}
className="ok-codepreview-cm min-h-[260px] flex-1 overflow-hidden rounded-md border border-border md:min-h-0"
diff --git a/packages/app/src/editor/components/ColorPickerInput.tsx b/packages/app/src/editor/components/ColorPickerInput.tsx
index 1fa6b7127..c3f32f659 100644
--- a/packages/app/src/editor/components/ColorPickerInput.tsx
+++ b/packages/app/src/editor/components/ColorPickerInput.tsx
@@ -50,7 +50,6 @@ export function ColorPickerInput({ id, value, onChange, autoFocus }: ColorPicker
)}
</div>
<div className="relative">
- {}
<Button
type="button"
variant="outline"
diff --git a/packages/app/src/editor/components/ExcalidrawEmbed.tsx b/packages/app/src/editor/components/ExcalidrawEmbed.tsx
index d54864894..1b327ceff 100644
--- a/packages/app/src/editor/components/ExcalidrawEmbed.tsx
+++ b/packages/app/src/editor/components/ExcalidrawEmbed.tsx
@@ -299,7 +299,6 @@ export function ExcalidrawEmbed({
<div className="font-medium">
<Trans>Excalidraw board failed to load.</Trans>
</div>
- {}
<div className="mt-1">{errorDetail}</div>
<div className="mt-1 break-words font-mono text-[11px] opacity-90">
{boardDocName ?? src}
@@ -359,7 +358,6 @@ export function ExcalidrawEmbed({
title={t`Open board`}
data-testid="excalidraw-embed-open"
>
- {}
<a href={hashFromDocName(boardDocName)} aria-label={t`Open board`}>
<ExternalLink className="size-4" aria-hidden="true" />
</a>
diff --git a/packages/app/src/editor/components/IconPickerInput.tsx b/packages/app/src/editor/components/IconPickerInput.tsx
index 2a7bc8fa4..afff03a27 100644
--- a/packages/app/src/editor/components/IconPickerInput.tsx
+++ b/packages/app/src/editor/components/IconPickerInput.tsx
@@ -93,7 +93,6 @@ export function IconPickerInput({ id, value, onChange, autoFocus }: IconPickerIn
</CommandGroup>
)}
<CommandGroup heading="Lucide">
- {}
<CommandPrimitive.Group className="[&_[cmdk-group-items]]:grid [&_[cmdk-group-items]]:grid-cols-6 [&_[cmdk-group-items]]:gap-1 [&_[cmdk-group-items]]:p-1">
{LUCIDE_ICON_ENTRIES.map(([name, Icon]) => {
const isSelected = name === selectedName;
diff --git a/packages/app/src/editor/components/Math.tsx b/packages/app/src/editor/components/Math.tsx
index 8e427d704..75d4f890b 100644
--- a/packages/app/src/editor/components/Math.tsx
+++ b/packages/app/src/editor/components/Math.tsx
@@ -21,7 +21,7 @@ const KatexRender = lazy(async () => {
className="math math-display"
data-component-type="math"
id={props.id}
- // biome-ignore lint/security/noDangerouslySetInnerHtml: KaTeX renderToString returns a strict HTML-allowlist string with no script execution; this is the documented integration path.
+ // oxlint-disable-next-line react/no-danger -- KaTeX renderToString returns a strict HTML-allowlist string with no script execution; this is the documented integration path.
dangerouslySetInnerHTML={{ __html: html }}
/>
);
diff --git a/packages/app/src/editor/components/Mermaid.tsx b/packages/app/src/editor/components/Mermaid.tsx
index fc507cca2..d09a37745 100644
--- a/packages/app/src/editor/components/Mermaid.tsx
+++ b/packages/app/src/editor/components/Mermaid.tsx
@@ -416,11 +416,9 @@ export function MermaidView({ chart = '', className, editBinding, onExpand }: Me
</pre>
</div>
</div>
- {}
<pre className="mermaid-error-source">{chart}</pre>
</>
)}
- {}
<div
contentEditable={false}
className={cn(
@@ -460,7 +458,6 @@ export function MermaidLightbox({
style={{ '--tw-enter-scale': '0.92', '--tw-exit-scale': '0.92' } as React.CSSProperties}
>
<DialogTitle className="sr-only">{t`Mermaid diagram`}</DialogTitle>
- {}
<span className="absolute top-2 left-3 flex h-7 items-center text-xs text-muted-foreground">
{t`View only`}
</span>
diff --git a/packages/app/src/editor/components/Mirror.tsx b/packages/app/src/editor/components/Mirror.tsx
index ebcf9efe3..2a894c774 100644
--- a/packages/app/src/editor/components/Mirror.tsx
+++ b/packages/app/src/editor/components/Mirror.tsx
@@ -94,7 +94,6 @@ export function Mirror(props: MirrorProps) {
data-mirror-src={src}
data-mirror-anchor={anchor}
>
- {}
<div
className='ok-mirror-badge pointer-events-none absolute -top-2.5 left-2 flex items-center gap-1 rounded-md bg-background px-1.5 text-xs text-muted-foreground opacity-0 transition-opacity [.jsx-component-wrapper:hover_&]:opacity-100 [.jsx-component-wrapper[data-selected="true"]_&]:opacity-100'
aria-hidden="true"
@@ -106,8 +105,10 @@ export function Mirror(props: MirrorProps) {
</Trans>
</span>
</div>
- {/* biome-ignore lint/security/noDangerouslySetInnerHtml: shared sanitization pipeline gates URL schemes + element-level passthrough — see `mdast-to-html.ts`. */}
- <div dangerouslySetInnerHTML={{ __html: status.html }} />
+ <div
+ // oxlint-disable-next-line react/no-danger -- shared sanitization pipeline gates URL schemes + element-level passthrough — see `mdast-to-html.ts`.
+ dangerouslySetInnerHTML={{ __html: status.html }}
+ />
</div>
);
}
diff --git a/packages/app/src/editor/components/Pdf.tsx b/packages/app/src/editor/components/Pdf.tsx
index cad2b5f35..26083bde2 100644
--- a/packages/app/src/editor/components/Pdf.tsx
+++ b/packages/app/src/editor/components/Pdf.tsx
@@ -475,7 +475,6 @@ export function Pdf(props: PdfProps) {
<Trans>Failed to load PDF: {error}</Trans>
</div>
)}
- {}
{Array.from({ length: totalPages }, (_, i) => {
const pageNumber = i + 1;
return (
diff --git a/packages/app/src/editor/components/PropPanel.tsx b/packages/app/src/editor/components/PropPanel.tsx
index 4b88f8104..451dbc418 100644
--- a/packages/app/src/editor/components/PropPanel.tsx
+++ b/packages/app/src/editor/components/PropPanel.tsx
@@ -333,7 +333,6 @@ function PropControl({
<label htmlFor={stringId} className="text-xs text-muted-foreground">
{humanizePropName(propDef.name)}
</label>
- {}
<div className="flex flex-col gap-1.5">
{accept !== undefined ? (
<SrcAutocomplete
@@ -422,7 +421,6 @@ function PropControl({
<SelectTrigger id={enumId} size="sm">
<SelectValue />
</SelectTrigger>
- {}
<SelectContent className="z-70">
{propDef.enumValues.map((v) => (
<SelectItem key={v} value={v}>
diff --git a/packages/app/src/editor/components/SrcAutocomplete.tsx b/packages/app/src/editor/components/SrcAutocomplete.tsx
index ea1332fdb..1ba053cfa 100644
--- a/packages/app/src/editor/components/SrcAutocomplete.tsx
+++ b/packages/app/src/editor/components/SrcAutocomplete.tsx
@@ -218,7 +218,6 @@ export function SrcAutocomplete({
}
}}
>
- {}
<div
id={listboxId}
role="listbox"
diff --git a/packages/app/src/editor/components/TagDialog.tsx b/packages/app/src/editor/components/TagDialog.tsx
index 09e325a4f..6e748976c 100644
--- a/packages/app/src/editor/components/TagDialog.tsx
+++ b/packages/app/src/editor/components/TagDialog.tsx
@@ -86,7 +86,6 @@ export function TagDialog() {
<DialogHeader>
<DialogTitle>
<Trans>
- {}
Documents tagged <span className="font-mono break-all">#{tagName}</span>
</Trans>
</DialogTitle>
diff --git a/packages/app/src/editor/composer-drop-parity.dom.test.tsx b/packages/app/src/editor/composer-drop-parity.dom.test.tsx
index 9eec5858d..79d9a7f1e 100644
--- a/packages/app/src/editor/composer-drop-parity.dom.test.tsx
+++ b/packages/app/src/editor/composer-drop-parity.dom.test.tsx
@@ -273,8 +273,7 @@ describe('every ComposerMentionInput surface either refuses the drop with a reas
const hostDrops: string[] = [];
render(
<TooltipProvider>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: test-harness drop-target probe standing in for the host panel — drop is a pointer-only affordance, mirroring ThreadView's real drop host. */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- test-harness drop-target probe standing in for the host panel — drop is a pointer-only affordance, mirroring ThreadView's real drop host.
onDrop={(event) => {
hostDrops.push(...Array.from(event.dataTransfer.files).map((file) => file.name));
}}
diff --git a/packages/app/src/editor/composer-mention/ComposerMentionMenu.tsx b/packages/app/src/editor/composer-mention/ComposerMentionMenu.tsx
index 9efaa31f5..5713540ee 100644
--- a/packages/app/src/editor/composer-mention/ComposerMentionMenu.tsx
+++ b/packages/app/src/editor/composer-mention/ComposerMentionMenu.tsx
@@ -65,7 +65,6 @@ export function ComposerMentionMenu({
tabIndex={-1}
className="max-h-64 overflow-y-auto overscroll-contain subtle-scrollbar"
>
- {}
<span className="sr-only" aria-live="polite" aria-atomic="true">
{selectedItem ? selectedItem.title : ''}
</span>
@@ -105,7 +104,6 @@ export function ComposerMentionMenu({
</span>
) : null}
</span>
- {}
<span className="line-clamp-2 break-all text-xs text-muted-foreground">
{displayPath}
</span>
diff --git a/packages/app/src/editor/composer-mention/ComposerSlashMenu.tsx b/packages/app/src/editor/composer-mention/ComposerSlashMenu.tsx
index eb5648ac9..f85ea0940 100644
--- a/packages/app/src/editor/composer-mention/ComposerSlashMenu.tsx
+++ b/packages/app/src/editor/composer-mention/ComposerSlashMenu.tsx
@@ -51,7 +51,6 @@ export function ComposerSlashMenu({
tabIndex={-1}
className="max-h-64 overflow-y-auto overscroll-contain subtle-scrollbar"
>
- {}
<span className="sr-only" aria-live="polite" aria-atomic="true">
{selectedItem ? `/${selectedItem.name}` : ''}
</span>
diff --git a/packages/app/src/editor/extensions/CodeBlockView.tsx b/packages/app/src/editor/extensions/CodeBlockView.tsx
index 70bfb213d..04aa276aa 100644
--- a/packages/app/src/editor/extensions/CodeBlockView.tsx
+++ b/packages/app/src/editor/extensions/CodeBlockView.tsx
@@ -254,7 +254,7 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
onMouseLeave={() => setHovered(false)}
>
{previewActive ? (
- // biome-ignore lint/a11y/noStaticElementInteractions: stopPropagation required so resize-handle drags don't bubble into PM
+ // oxlint-disable-next-line jsx-a11y/no-static-element-interactions -- stopPropagation required so resize-handle drags don't bubble into PM
<div
ref={previewWrapperRef}
className={cn(
@@ -308,7 +308,6 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
/>
) : null}
- {}
{title ? (
<div
className="ok-codeblock-title"
@@ -320,7 +319,6 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
</div>
) : null}
- {}
<pre
className={cn(
'ok-codeblock-pre m-0 overflow-x-auto px-5 py-4 font-mono text-sm leading-relaxed',
@@ -338,8 +336,7 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
/>
</pre>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: stopPropagation required inside PM NodeView */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- stopPropagation required inside PM NodeView
className="ok-codeblock-chrome"
contentEditable={false}
onMouseDown={(e) => e.stopPropagation()}
diff --git a/packages/app/src/editor/extensions/InternalLinkPropPanel.tsx b/packages/app/src/editor/extensions/InternalLinkPropPanel.tsx
index 1209cf7a7..6d3604438 100644
--- a/packages/app/src/editor/extensions/InternalLinkPropPanel.tsx
+++ b/packages/app/src/editor/extensions/InternalLinkPropPanel.tsx
@@ -235,7 +235,6 @@ function EditMarkdownLinkDialog({
placeholder={t`heading-slug`}
onKeyDown={handleKeyDown}
/>
- {}
{showHeadings ? (
<div
id={headingListId}
diff --git a/packages/app/src/editor/extensions/JsxComponentView.tsx b/packages/app/src/editor/extensions/JsxComponentView.tsx
index 1c89d9b39..4d437cf98 100644
--- a/packages/app/src/editor/extensions/JsxComponentView.tsx
+++ b/packages/app/src/editor/extensions/JsxComponentView.tsx
@@ -606,17 +606,12 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
onClick={handleBodyClick}
onKeyDown={handleKeyDown}
>
- {}
- {/* biome-ignore lint/a11y/noStaticElementInteractions: stopPropagation required inside PM NodeView */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- stopPropagation required inside PM NodeView
className="jsx-component-chrome"
contentEditable={false}
onMouseDown={(e) => e.stopPropagation()}
{...{ [OPT_OUT_ATTR]: 'true' }}
>
- {}
-
- {}
{descriptor.name === 'Embed' &&
typeof primitiveProps.src === 'string' &&
/^https?:\/\//i.test(primitiveProps.src) && (
@@ -632,7 +627,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</a>
)}
- {}
{descriptor.name === 'Mirror' &&
typeof primitiveProps.src === 'string' &&
primitiveProps.src.length > 0 &&
@@ -656,7 +650,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
);
})()}
- {}
{canMoveUp && (
<button
type="button"
@@ -739,7 +732,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</button>
)}
- {}
{editableSource && typeof pos === 'number' ? (
<button
type="button"
@@ -752,7 +744,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</button>
) : null}
- {}
{expandableChart !== null ? (
<button
type="button"
@@ -765,7 +756,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</button>
) : null}
- {}
{boardExpandable ? (
<button
type="button"
@@ -778,7 +768,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</button>
) : null}
- {}
{!isEmbedded && commentLeafText(node).length > 0 && typeof pos === 'number' ? (
<button
type="button"
@@ -821,7 +810,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</button>
) : null}
- {}
<button
type="button"
className="jsx-chrome-btn jsx-chrome-btn--delete"
@@ -864,7 +852,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
<Trash2 size={12} aria-hidden="true" />
</button>
- {}
{hasEditableProps && (
<PopoverTrigger asChild>
<button
@@ -879,8 +866,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
)}
</div>
- {}
- {}
{showPlaceholder && resolvedPlaceholder ? (
<PopoverAnchor asChild>
<DescriptorPlaceholder
@@ -945,7 +930,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
</ComponentErrorBoundary>
)}
- {}
{descriptor.emptyChildName &&
!(descriptor.name === 'Tabs' && node.childCount > 0) &&
(() => {
@@ -1032,7 +1016,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
}}
/>
) : null}
- {}
{hasEditableProps && (
<PopoverContent
side={showPlaceholder ? 'bottom' : 'right'}
@@ -1102,7 +1085,6 @@ export function JsxComponentView({ node, editor, extension, getPos, selected }:
markUserTyping();
}}
/>
- {}
<div className="mt-3 flex justify-end border-t border-border pt-2">
<Button
type="button"
diff --git a/packages/app/src/editor/extensions/JsxInlineView.tsx b/packages/app/src/editor/extensions/JsxInlineView.tsx
index c73264be7..0792a6239 100644
--- a/packages/app/src/editor/extensions/JsxInlineView.tsx
+++ b/packages/app/src/editor/extensions/JsxInlineView.tsx
@@ -82,7 +82,6 @@ function RegisteredInlineView({
>
<Popover open={popoverOpen} onOpenChange={setPopoverOpen}>
<PopoverTrigger asChild>
- {}
<span data-jsx-inline-widget="">
<ErrorBoundary
resetKeys={[resetKey]}
diff --git a/packages/app/src/editor/extensions/MathInlineView.tsx b/packages/app/src/editor/extensions/MathInlineView.tsx
index c5f582048..1425ea741 100644
--- a/packages/app/src/editor/extensions/MathInlineView.tsx
+++ b/packages/app/src/editor/extensions/MathInlineView.tsx
@@ -42,7 +42,7 @@ const KatexInlineRender = lazy(async () => {
return (
<span
className="math math-inline"
- // biome-ignore lint/security/noDangerouslySetInnerHtml: KaTeX renderToString returns a strict HTML-allowlist string with no script execution; this is the documented integration path.
+ // oxlint-disable-next-line react/no-danger -- KaTeX renderToString returns a strict HTML-allowlist string with no script execution; this is the documented integration path.
dangerouslySetInnerHTML={{ __html: html }}
/>
);
@@ -92,7 +92,6 @@ export function MathInlineView({ node, selected, getPos, editor }: NodeViewProps
return (
<NodeViewWrapper as="span" className={selected ? 'math-inline-selected' : undefined}>
<Popover open={popoverOpen} onOpenChange={setPopoverOpen}>
- {}
<PopoverTrigger asChild>
<span
className="math-inline-trigger"
@@ -174,7 +173,6 @@ export function MathInlineView({ node, selected, getPos, editor }: NodeViewProps
}}
onDismiss={() => setPopoverOpen(false)}
/>
- {}
<div className="mt-3 flex justify-end border-t border-border pt-2">
<Button
type="button"
diff --git a/packages/app/src/editor/extensions/RawMdxFallbackCMView.tsx b/packages/app/src/editor/extensions/RawMdxFallbackCMView.tsx
index 99d7f16e5..772eefdb5 100644
--- a/packages/app/src/editor/extensions/RawMdxFallbackCMView.tsx
+++ b/packages/app/src/editor/extensions/RawMdxFallbackCMView.tsx
@@ -454,8 +454,7 @@ export function RawMdxFallbackView({ node, editor, getPos }: NodeViewProps) {
data-severity={severity}
{...wildcardChromeProps}
>
- {/* biome-ignore lint/a11y/noStaticElementInteractions: stopPropagation required inside PM NodeView */}
- <div
+ <div // oxlint-disable-line jsx-a11y/no-static-element-interactions -- stopPropagation required inside PM NodeView
className="absolute top-1 right-1 z-10 flex items-center gap-1.5"
contentEditable={false}
onMouseDown={(e) => e.stopPropagation()}
diff --git a/packages/app/src/editor/extensions/WikiLinkPropPanel.tsx b/packages/app/src/editor/extensions/WikiLinkPropPanel.tsx
index e66708a25..b641093c7 100644
--- a/packages/app/src/editor/extensions/WikiLinkPropPanel.tsx
+++ b/packages/app/src/editor/extensions/WikiLinkPropPanel.tsx
@@ -209,7 +209,6 @@ function EditWikiLinkDialog({
placeholder={t`heading-slug`}
onKeyDown={handleKeyDown}
/>
- {}
{showHeadings && (
<div
id={headingListId}
diff --git a/packages/app/src/editor/internal-link-helpers.ts b/packages/app/src/editor/internal-link-helpers.ts
index 58a7fea72..6db16c19f 100644
--- a/packages/app/src/editor/internal-link-helpers.ts
+++ b/packages/app/src/editor/internal-link-helpers.ts
@@ -37,7 +37,6 @@ export function openHashHrefInNewTab(href: string): void {
if (href.startsWith('#') || isSafeNavigationUrl(href)) {
window.open(href, '_blank', 'noopener,noreferrer');
} else {
- // eslint-disable-next-line no-console
console.warn('[safe-nav] blocked non-safe scheme:', href);
}
}
diff --git a/packages/app/src/editor/link-path-suggestions.tsx b/packages/app/src/editor/link-path-suggestions.tsx
index 5a1cf2466..ededf43e0 100644
--- a/packages/app/src/editor/link-path-suggestions.tsx
+++ b/packages/app/src/editor/link-path-suggestions.tsx
@@ -340,7 +340,6 @@ export function LinkPathSuggestionInput({
autoComplete="off"
className={className}
/>
- {}
{suggestionPanel && createPortal(suggestionPanel, document.body)}
</div>
);
diff --git a/packages/app/src/editor/slash-command/SlashCommandMenu.tsx b/packages/app/src/editor/slash-command/SlashCommandMenu.tsx
index e0db500c1..a4a7a32b6 100644
--- a/packages/app/src/editor/slash-command/SlashCommandMenu.tsx
+++ b/packages/app/src/editor/slash-command/SlashCommandMenu.tsx
@@ -91,7 +91,6 @@ export function SlashCommandMenu({
className="w-56 overflow-y-auto subtle-scrollbar rounded-lg border bg-popover p-1 shadow-md"
style={{ maxHeight: 'var(--suggestion-menu-max-height, 40vh)' }}
>
- {}
<span className="sr-only" aria-live="polite" aria-atomic="true">
{selectedItem ? `${selectedItem.label}${secondLine(selectedItem)}` : ''}
</span>
diff --git a/packages/app/src/editor/slash-command/component-items.tsx b/packages/app/src/editor/slash-command/component-items.tsx
index 0f389632c..165830597 100644
--- a/packages/app/src/editor/slash-command/component-items.tsx
+++ b/packages/app/src/editor/slash-command/component-items.tsx
@@ -117,7 +117,6 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
render: () => (
<div className="flex h-full w-full flex-col overflow-hidden rounded-md border border-border bg-background">
<div className="flex items-center gap-1 border-b border-border bg-muted/40 px-1.5 py-1">
- {}
<svg viewBox="0 0 12 12" className="size-3 text-muted-foreground" aria-hidden="true">
<title>Thumbnails</title>
<rect x="1" y="1" width="4" height="4" fill="currentColor" rx="0.5" />
@@ -136,13 +135,11 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
</span>
</div>
<div className="flex flex-1 gap-1 p-1.5">
- {}
<div className="flex w-6 flex-col gap-0.5">
<span className="h-3 rounded-sm bg-muted-foreground/20" />
<span className="h-3 rounded-sm border border-foreground/60 bg-background" />
<span className="h-3 rounded-sm bg-muted-foreground/20" />
</div>
- {}
<div className="flex flex-1 flex-col gap-1 rounded-sm bg-background p-1.5">
<span className="h-1.5 w-1/2 rounded-sm bg-foreground/50" />
<span className="h-1 w-full rounded-sm bg-muted-foreground/30" />
@@ -177,7 +174,6 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
<path d="M 0 0 L 10 5 L 0 10 z" fill="currentColor" />
</marker>
</defs>
- {}
<rect
x="14"
y="20"
@@ -192,7 +188,6 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
<text x="42" y="38" textAnchor="middle" fontSize="10" fill="currentColor">
Start
</text>
- {}
<polygon
points="100,18 140,50 100,82 60,50"
fill="currentColor"
@@ -203,7 +198,6 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
<text x="100" y="54" textAnchor="middle" fontSize="10" fill="currentColor">
Ready?
</text>
- {}
<rect
x="130"
y="84"
@@ -218,7 +212,6 @@ const PREVIEW_CONFIG: Record<string, PreviewConfig> = {
<text x="158" y="102" textAnchor="middle" fontSize="10" fill="currentColor">
End
</text>
- {}
<line
x1="70"
y1="34"
@@ -573,8 +566,12 @@ export function getInlineComponentItems(): SlashCommandItem[] {
<p className="text-sm leading-7">
<Trans>
See{' '}
- {/* biome-ignore lint/a11y/useValidAnchor: preview mockup of an <a className="tag"> — no real navigation target needed inside the slash menu's pointer-events-none preview frame */}
- <a className="tag pointer-events-none">#design-docs</a> for the latest specs.
+ <a // oxlint-disable-line jsx-a11y/anchor-is-valid -- preview mockup of an <a className="tag"> — no real navigation target needed inside the slash menu's pointer-events-none preview frame
+ className="tag pointer-events-none"
+ >
+ #design-docs
+ </a>{' '}
+ for the latest specs.
</Trans>
</p>
),
diff --git a/packages/app/src/editor/tag-suggestion/TagSuggestionMenu.tsx b/packages/app/src/editor/tag-suggestion/TagSuggestionMenu.tsx
index e2efd133c..82655e881 100644
--- a/packages/app/src/editor/tag-suggestion/TagSuggestionMenu.tsx
+++ b/packages/app/src/editor/tag-suggestion/TagSuggestionMenu.tsx
@@ -105,7 +105,6 @@ export function TagSuggestionMenu({
className="w-64 overflow-y-auto subtle-scrollbar rounded-lg border bg-popover p-1 shadow-md"
style={{ maxHeight: 'var(--suggestion-menu-max-height, 40vh)' }}
>
- {}
<span className="sr-only" aria-live="polite" aria-atomic="true">
{selectedItem ? announcementText(selectedItem) : ''}
</span>
diff --git a/packages/app/src/editor/wiki-link-suggestion/WikiLinkSuggestionMenu.tsx b/packages/app/src/editor/wiki-link-suggestion/WikiLinkSuggestionMenu.tsx
index f59cf81c9..6b780a2d2 100644
--- a/packages/app/src/editor/wiki-link-suggestion/WikiLinkSuggestionMenu.tsx
+++ b/packages/app/src/editor/wiki-link-suggestion/WikiLinkSuggestionMenu.tsx
@@ -131,7 +131,6 @@ export function WikiLinkSuggestionMenu({
className="w-80 overflow-y-auto subtle-scrollbar rounded-lg border bg-popover p-1 shadow-md"
style={{ maxHeight: 'var(--suggestion-menu-max-height, 40vh)' }}
>
- {}
<span className="sr-only" aria-live="polite" aria-atomic="true">
{selectedItem ? announcementText(selectedItem) : ''}
</span>
@@ -192,7 +191,6 @@ export function WikiLinkSuggestionMenu({
<span className="truncate font-medium">
{item.kind === 'create' ? item.actionLabel : item.title}
</span>
- {}
{item.kind === 'page' && item.title !== item.docName && (
<span className="line-clamp-2 break-all text-xs text-muted-foreground">
{item.docName}
diff --git a/packages/app/src/lib/perf/cold-mount-instrumentation.ts b/packages/app/src/lib/perf/cold-mount-instrumentation.ts
index faf6322d2..d437f431c 100644
--- a/packages/app/src/lib/perf/cold-mount-instrumentation.ts
+++ b/packages/app/src/lib/perf/cold-mount-instrumentation.ts
@@ -20,7 +20,6 @@ export function wrapMethod<T extends Record<string, unknown>>(
): void {
const original = target[key] as unknown as (...args: unknown[]) => unknown;
if (typeof original !== 'function') {
- // eslint-disable-next-line no-console -- diagnostic
console.warn(`[cold-mount-instrumentation] target missing method "${key}"`);
return;
}
diff --git a/packages/app/src/lib/perf/collector.ts b/packages/app/src/lib/perf/collector.ts
index f679acee6..1f0cc43c9 100644
--- a/packages/app/src/lib/perf/collector.ts
+++ b/packages/app/src/lib/perf/collector.ts
@@ -13,7 +13,6 @@ declare global {
interface Window {
__ok_perf?: PerfCollector;
}
- // eslint-disable-next-line no-var -- required for `globalThis` augmentation
var __ok_perf: PerfCollector | undefined;
}
diff --git a/packages/app/src/lib/perf/mark.ts b/packages/app/src/lib/perf/mark.ts
index 79c38bec5..82e4b5ad0 100644
--- a/packages/app/src/lib/perf/mark.ts
+++ b/packages/app/src/lib/perf/mark.ts
@@ -55,7 +55,6 @@ export interface MarkFn {
function markImpl(name: string, props?: Record<string, unknown>, opts?: MarkOptions): void {
if (!import.meta.env?.PROD && !validatePerfMarkName(name)) {
- // eslint-disable-next-line no-console -- dev-only lint
console.warn(`[perf] mark name "${name}" does not match ok/<subsystem>/<event>`);
}
@@ -96,7 +95,6 @@ function markImpl(name: string, props?: Record<string, unknown>, opts?: MarkOpti
function countImpl(name: string, props?: Record<string, string | number | boolean>): void {
if (!import.meta.env?.PROD && !validatePerfMarkName(name)) {
- // eslint-disable-next-line no-console -- dev-only lint
console.warn(`[perf] mark.count name "${name}" does not match ok/<subsystem>/<event>`);
}
recordCounter(name, props);
@@ -108,7 +106,6 @@ function histogramImpl(
durationMs: number,
): void {
if (!import.meta.env?.PROD && !validatePerfMarkName(name)) {
- // eslint-disable-next-line no-console -- dev-only lint
console.warn(`[perf] mark.histogram name "${name}" does not match ok/<subsystem>/<event>`);
}
markImpl(name, { ...props, durationMs }, { duration: durationMs });
diff --git a/packages/app/src/lib/perf/web-vitals.ts b/packages/app/src/lib/perf/web-vitals.ts
index 60d3166f6..a3381e938 100644
--- a/packages/app/src/lib/perf/web-vitals.ts
+++ b/packages/app/src/lib/perf/web-vitals.ts
@@ -45,7 +45,6 @@ export async function initWebVitals(): Promise<void> {
onFCP(handleMetric);
} catch (err) {
if (!import.meta.env?.PROD) {
- // eslint-disable-next-line no-console
console.warn('[perf] web-vitals init failed', err);
}
}
diff --git a/packages/app/src/main.tsx b/packages/app/src/main.tsx
index 45e2449b2..8e14a1e2a 100644
--- a/packages/app/src/main.tsx
+++ b/packages/app/src/main.tsx
@@ -150,16 +150,13 @@ createRoot(root).render(
storageKey="ok-theme-v1"
>
<RegisteredAgentHydrator />
- {}
<TooltipProvider>
<AppErrorBoundary>{selectDesktopRootApp(desktopBridge)}</AppErrorBoundary>
- {}
{desktopBridge !== undefined && (
<CrashReportingBoundary>
<ReportBugCrashInviteTrigger bridge={desktopBridge} />
</CrashReportingBoundary>
)}
- {}
<Toaster richColors closeButton />
</TooltipProvider>
</ThemeProvider>
diff --git a/packages/app/src/presence/PresenceBar.tsx b/packages/app/src/presence/PresenceBar.tsx
index 1864af53d..2da06a057 100644
--- a/packages/app/src/presence/PresenceBar.tsx
+++ b/packages/app/src/presence/PresenceBar.tsx
@@ -218,7 +218,6 @@ function AgentAvatar({
style={{ backgroundColor: presence.color }}
onClick={() => onClickAgent(agentId, realCurrentDoc)}
>
- {}
<AgentIcon icon={presence.icon} width={16} height={16} className="text-white" aria-hidden />
</button>
) : (
diff --git a/packages/app/src/telemetry-impl.ts b/packages/app/src/telemetry-impl.ts
index b5fafe7f1..b28e8a38b 100644
--- a/packages/app/src/telemetry-impl.ts
+++ b/packages/app/src/telemetry-impl.ts
@@ -62,10 +62,8 @@ export function install(): void {
}),
],
});
- // eslint-disable-next-line no-console
console.info(`[otel] frontend telemetry initialized — OTLP/HTTP → ${baseUrl}/v1/traces`);
} catch (err) {
- // eslint-disable-next-line no-console
console.warn('[otel] frontend telemetry init failed — continuing without', err);
if (registered && provider) {
void provider.shutdown().catch(() => {});
diff --git a/packages/app/src/uninstall/UninstallNoticeScreen.tsx b/packages/app/src/uninstall/UninstallNoticeScreen.tsx
index 3dc2fae5c..1e3d5a8b6 100644
--- a/packages/app/src/uninstall/UninstallNoticeScreen.tsx
+++ b/packages/app/src/uninstall/UninstallNoticeScreen.tsx
@@ -123,7 +123,7 @@ export function UninstallNoticeScreen({
{notice.log !== undefined && (
<section
aria-label={t`Cleanup log`}
- // biome-ignore lint/a11y/noNoninteractiveTabindex: focusable scroll region per WCAG 2.1.1 — the log is the only in-product account of what cleanup failed to remove, so reading it must not require a pointer.
+ // oxlint-disable-next-line jsx-a11y/no-noninteractive-tabindex -- focusable scroll region per WCAG 2.1.1 — the log is the only in-product account of what cleanup failed to remove, so reading it must not require a pointer.
tabIndex={0}
className="subtle-scrollbar mt-0.5 mb-2.5 min-h-20 flex-1 overflow-auto rounded-lg border border-border border-dotted bg-muted/40 px-3 py-2.5 focus-visible:outline-none focus-visible:ring-3 focus-visible:ring-ring/50"
>
diff --git a/packages/app/src/uninstall/UninstallPickerScreen.tsx b/packages/app/src/uninstall/UninstallPickerScreen.tsx
index f9bbb13e2..74bd36ff7 100644
--- a/packages/app/src/uninstall/UninstallPickerScreen.tsx
+++ b/packages/app/src/uninstall/UninstallPickerScreen.tsx
@@ -144,7 +144,6 @@ export function UninstallPickerScreen({
</div>
) : (
<div className="flex min-h-0 flex-1 flex-col overflow-hidden rounded-lg border border-border">
- {}
<div className="flex shrink-0 items-center gap-2.5 border-border border-b px-3 py-2.5 bg-muted/30">
<Checkbox
id={selectAllId}
@@ -154,7 +153,6 @@ export function UninstallPickerScreen({
<Label htmlFor={selectAllId} className="flex-1 font-medium text-sm">
<Trans>Select all</Trans>
</Label>
- {}
<span
role="status"
aria-label={t`${selected.size} of ${projects.length} projects selected`}
@@ -163,7 +161,6 @@ export function UninstallPickerScreen({
{selected.size} / {projects.length}
</span>
</div>
- {}
<div className="subtle-scrollbar min-h-0 flex-1 overflow-y-scroll [scrollbar-gutter:stable]">
{projects.map((project, index) => (
<ProjectRow
@@ -186,7 +183,6 @@ export function UninstallPickerScreen({
</section>
<footer className="flex items-center justify-end gap-2.5 border-border border-t bg-muted/50 px-6 pt-3.5 pb-4">
- {}
<Button type="button" variant="outline-mono" autoFocus onClick={onCancel}>
<Trans>Cancel</Trans>
</Button>
diff --git a/packages/app/src/uninstall/UninstallSurveyScreen.tsx b/packages/app/src/uninstall/UninstallSurveyScreen.tsx
index ccbd433a5..d00eb1976 100644
--- a/packages/app/src/uninstall/UninstallSurveyScreen.tsx
+++ b/packages/app/src/uninstall/UninstallSurveyScreen.tsx
@@ -72,7 +72,6 @@ export function UninstallSurveyScreen({ onSend, onSkip }: UninstallSurveyScreenP
</p>
</header>
- {}
<form
className="flex min-h-0 flex-1 flex-col"
onSubmit={(event) => {
@@ -87,7 +86,6 @@ export function UninstallSurveyScreen({ onSend, onSkip }: UninstallSurveyScreenP
}}
>
<div className="subtle-scrollbar min-h-0 flex-1 overflow-y-auto px-6 pt-1 pb-4">
- {}
<div className="mb-6">
<p id={legendId} className="mb-2 font-medium text-sm">
<Trans>Before you go, mind sharing why?</Trans>
diff --git a/packages/app/tests/perf/fixtures/generate-view-count-fixtures.ts b/packages/app/tests/perf/fixtures/generate-view-count-fixtures.ts
index 4edddda70..c02b19733 100644
--- a/packages/app/tests/perf/fixtures/generate-view-count-fixtures.ts
+++ b/packages/app/tests/perf/fixtures/generate-view-count-fixtures.ts
@@ -183,12 +183,10 @@ function logResult(targetViews: number, outDir: string, result: ConvergeResult):
const minOk = Math.floor(targetViews * (1 - TOLERANCE_RATIO));
const maxOk = Math.ceil(targetViews * (1 + TOLERANCE_RATIO));
const ok = result.measuredViews >= minOk && result.measuredViews <= maxOk;
- // eslint-disable-next-line no-console
console.log(
`[gen-fixtures] target=${targetViews} measured=${result.measuredViews} chips=${result.chips} iters=${result.iterations} ok=${ok} → ${outDir}/FIXTURE.md`,
);
if (!ok) {
- // eslint-disable-next-line no-console
console.warn(
`[gen-fixtures] WARN: ${result.measuredViews} not within ±${TOLERANCE_RATIO * 100}% of ${targetViews} (range ${minOk}..${maxOk})`,
);
@@ -207,11 +205,9 @@ if (import.meta.main) {
const targetViews = args.targetViews;
const outDir = args.outDir ?? (targetViews ? defaultOutDir(targetViews) : null);
if (typeof targetViews !== 'number' || !outDir) {
- // eslint-disable-next-line no-console
console.error(
'Usage: bun run generate-view-count-fixtures.ts --target-views <N> [--out-dir <path>]',
);
- // eslint-disable-next-line no-console
console.error(' or: bun run generate-view-count-fixtures.ts --all');
process.exit(2);
}
diff --git a/packages/cli/src/commands/diagnose-health-checks/runner.test.ts b/packages/cli/src/commands/diagnose-health-checks/runner.test.ts
index 81f1b77fe..8d6f09ce5 100644
--- a/packages/cli/src/commands/diagnose-health-checks/runner.test.ts
+++ b/packages/cli/src/commands/diagnose-health-checks/runner.test.ts
@@ -42,7 +42,6 @@ describe('runCheck', () => {
const def: CheckDefinition = {
name: 'bun',
run: async () => {
- // eslint-disable-next-line @typescript-eslint/no-throw-literal
throw 'string error';
},
};
diff --git a/packages/desktop/tests/smoke/_nav-empty-840x600.capture.ts b/packages/desktop/tests/smoke/_nav-empty-840x600.capture.ts
index f585fe7c9..7c0cfeafd 100644
--- a/packages/desktop/tests/smoke/_nav-empty-840x600.capture.ts
+++ b/packages/desktop/tests/smoke/_nav-empty-840x600.capture.ts
@@ -106,7 +106,6 @@ test.describe('Navigator empty-state screenshot (dev-only)', () => {
await nav.waitForTimeout(1000);
const outPath = join(SHOT_DIR, 'nav-shot-empty-840x600.png');
await nav.screenshot({ path: outPath });
- // eslint-disable-next-line no-console
console.log(`captured empty 840x600 -> ${outPath}`);
} finally {
rmSafe(tmpHome);
diff --git a/packages/desktop/tests/smoke/_nav-size-screenshots.capture.ts b/packages/desktop/tests/smoke/_nav-size-screenshots.capture.ts
index 19e525c5e..ce03ed1f2 100644
--- a/packages/desktop/tests/smoke/_nav-size-screenshots.capture.ts
+++ b/packages/desktop/tests/smoke/_nav-size-screenshots.capture.ts
@@ -152,7 +152,6 @@ test.describe('Navigator size screenshots (dev-only)', () => {
await nav.waitForTimeout(900);
const outPath = join(SHOT_DIR, `nav-shot-${label}.png`);
await nav.screenshot({ path: outPath });
- // eslint-disable-next-line no-console
console.log(`captured ${w}x${h} -> ${outPath}`);
}
} finally {
diff --git a/turbo.json b/turbo.json
index e3846a31e..f831643f5 100644
--- a/turbo.json
+++ b/turbo.json
@@ -71,7 +71,15 @@
"dependsOn": ["^types", "build"]
},
"typecheck": {
- "dependsOn": ["^types", "//#typecheck:no-net-connect"]
+ "dependsOn": ["^types", "//#typecheck:no-net-connect", "//#typecheck:lint-plugins"]
+ },
+ "//#typecheck:lint-plugins": {
+ "inputs": [
+ "lint-plugins/ok-rules/**/*.ts",
+ "lint-plugins/ok-rules/tsconfig.json",
+ "test-support/*.ts",
+ "tsconfig.json"
+ ]
},
"//#typecheck:no-net-connect": {
"inputs": [
diff --git a/vitest.scripts.config.ts b/vitest.scripts.config.ts
index d7c567f14..b99598a2f 100644
--- a/vitest.scripts.config.ts
+++ b/vitest.scripts.config.ts
@@ -15,6 +15,7 @@ export default defineConfig({
'scripts/**/*.test.mjs',
'.github/scripts/**/*.test.mjs',
'lint-plugins/**/*.test.mjs',
+ 'lint-plugins/**/*.test.ts',
'plugins/**/*.test.mjs',
'test-support/**/*.test.ts',
'test-support/**/*.test.mjs',