Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

PRD-8485 Fix blank Slidev presentation windows (#4089)

serafin-garcia4a1d8ecd81a3
diff --git a/.changeset/slidev-render-readiness.md b/.changeset/slidev-render-readiness.md
new file mode 100644
index 000000000..03bf38199
--- /dev/null
+++ b/.changeset/slidev-render-readiness.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Slidev presentation windows now stay hidden until the first slide finishes rendering. If Slidev serves its shell but the deck never mounts, OpenKnowledge reports a retryable render failure instead of showing a blank window.
diff --git a/knip.config.ts b/knip.config.ts
index a0ba1bf42..68adb81cc 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -127,7 +127,9 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: ['@types/shell-quote'],
+ ignoreDependencies: [
+ '@types/shell-quote',
+ ],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
diff --git a/packages/app/src/components/SlidesToolbarControls.dom.test.tsx b/packages/app/src/components/SlidesToolbarControls.dom.test.tsx
index 109238fe7..1f0f6efd1 100644
--- a/packages/app/src/components/SlidesToolbarControls.dom.test.tsx
+++ b/packages/app/src/components/SlidesToolbarControls.dom.test.tsx
@@ -11,9 +11,20 @@ import { TooltipProvider } from '@/components/ui/tooltip';
import type { OkSlidesOpenResult, OkSlidesStatusResult } from '@/lib/desktop-bridge-types';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
-const { toastErrorSpy } = vi.hoisted(() => ({ toastErrorSpy: vi.fn() }));
+const { toastDismissSpy, toastErrorSpy, toastLoadingSpy } = vi.hoisted(() => ({
+ toastDismissSpy: vi.fn(),
+ toastErrorSpy: vi.fn(),
+ toastLoadingSpy: vi.fn(() => 'slides-opening'),
+}));
vi.mock('sonner', () => ({
- toast: { error: toastErrorSpy, success: vi.fn(), info: vi.fn(), warning: vi.fn() },
+ toast: {
+ dismiss: toastDismissSpy,
+ error: toastErrorSpy,
+ info: vi.fn(),
+ loading: toastLoadingSpy,
+ success: vi.fn(),
+ warning: vi.fn(),
+ },
}));
vi.doMock('@lingui/react/macro', () => ({
@@ -206,7 +217,7 @@ describe('SlidesToolbarControls — activation', () => {
await waitFor(() => expect(openSpy).toHaveBeenCalledWith('/proj/talks/Deck.md'));
});
- test('activating the action emits the ok.slides.opened marker', async () => {
+ test('one in-flight open reports busy progress and suppresses duplicate activation', async () => {
const spanNames: string[] = [];
const getTracerSpy = vi.spyOn(trace, 'getTracer').mockImplementation(
() =>
@@ -219,14 +230,30 @@ describe('SlidesToolbarControls — activation', () => {
);
try {
const user = userEvent.setup();
- installBridge({
+ let resolveOpen: ((result: OkSlidesOpenResult) => void) | undefined;
+ const pendingOpen = new Promise<OkSlidesOpenResult>((resolve) => {
+ resolveOpen = resolve;
+ });
+ const { openSpy } = installBridge({
status: () => Promise.resolve({ kind: 'status', available: true, source: 'global' }),
+ open: () => pendingOpen,
});
await renderControls(makeProvider('---\nslides: true\n---\nbody\n'));
- await user.click(await screen.findByTestId('slides-toolbar-action'));
+ const action = await screen.findByTestId('slides-toolbar-action');
+ await user.click(action);
+ await user.click(action);
- await waitFor(() => expect(spanNames).toContain('ok.slides.opened'));
+ expect(openSpy).toHaveBeenCalledTimes(1);
+ expect(spanNames.filter((name) => name === 'ok.slides.opened')).toHaveLength(1);
+ expect(action.getAttribute('aria-busy')).toBe('true');
+ expect(toastLoadingSpy).toHaveBeenCalledWith('Opening...', {
+ duration: Number.POSITIVE_INFINITY,
+ });
+
+ resolveOpen?.({ kind: 'open', ok: true });
+ await waitFor(() => expect(action.getAttribute('aria-busy')).toBe('false'));
+ expect(toastDismissSpy).toHaveBeenCalledWith('slides-opening');
} finally {
getTracerSpy.mockRestore();
}
@@ -243,7 +270,10 @@ describe('SlidesToolbarControls — activation', () => {
await user.click(await screen.findByTestId('slides-toolbar-action'));
await waitFor(() =>
- expect(toastErrorSpy).toHaveBeenCalledWith('Slidev timed out while starting. Try again.'),
+ expect(toastErrorSpy).toHaveBeenCalledWith(
+ 'Slidev timed out while starting. Try again.',
+ expect.objectContaining({ id: 'slides-opening' }),
+ ),
);
});
@@ -258,10 +288,129 @@ describe('SlidesToolbarControls — activation', () => {
await user.click(await screen.findByTestId('slides-toolbar-action'));
await waitFor(() =>
- expect(toastErrorSpy).toHaveBeenCalledWith("Slidev couldn't render this document."),
+ expect(toastErrorSpy).toHaveBeenCalledWith(
+ "Slidev couldn't render this document.",
+ expect.objectContaining({
+ action: expect.objectContaining({ label: 'Try again' }),
+ id: 'slides-opening',
+ }),
+ ),
+ );
+ });
+
+ test('retry keeps the failed path without blocking another deck', async () => {
+ const spanNames: string[] = [];
+ const getTracerSpy = vi.spyOn(trace, 'getTracer').mockImplementation(
+ () =>
+ ({
+ startSpan: (name: string) => {
+ spanNames.push(name);
+ return { end: () => undefined };
+ },
+ }) as unknown as Tracer,
+ );
+ try {
+ const user = userEvent.setup();
+ const providerA = makeProvider('---\nslides: true\n---\nA\n');
+ const providerB = makeProvider('---\nslides: true\n---\nB\n');
+ let resolveRetry: ((result: OkSlidesOpenResult) => void) | undefined;
+ let resolveDeckB: ((result: OkSlidesOpenResult) => void) | undefined;
+ let attempts = 0;
+ const { openSpy } = installBridge({
+ status: () => Promise.resolve({ kind: 'status', available: true, source: 'global' }),
+ open: (docPath) => {
+ attempts += 1;
+ if (attempts === 1) {
+ return Promise.resolve({ kind: 'open', ok: false, reason: 'renderer-failed' });
+ }
+ return new Promise<OkSlidesOpenResult>((resolve) => {
+ if (docPath.endsWith('/A.md')) resolveRetry = resolve;
+ else resolveDeckB = resolve;
+ });
+ },
+ });
+ const rendered = await renderControls(providerA, 'talks/A');
+
+ await user.click(await screen.findByTestId('slides-toolbar-action'));
+ await waitFor(() => expect(toastErrorSpy).toHaveBeenCalledTimes(1));
+ const retry = (
+ toastErrorSpy.mock.calls[0]?.[1] as { action?: { onClick?: () => void } } | undefined
+ )?.action?.onClick;
+ expect(retry).toBeTypeOf('function');
+
+ const { SlidesToolbarControls } = await import('./SlidesToolbarControls');
+ rendered.rerender(
+ <TooltipProvider>
+ <SlidesToolbarControls
+ provider={providerB as unknown as HocuspocusProvider}
+ docName="talks/B"
+ />
+ </TooltipProvider>,
+ );
+ act(() => retry?.());
+
+ const action = await screen.findByTestId('slides-toolbar-action');
+ expect(action.getAttribute('aria-busy')).toBe('false');
+ await user.click(action);
+
+ expect(openSpy).toHaveBeenCalledTimes(3);
+ expect(openSpy.mock.calls.map(([docPath]) => docPath)).toEqual([
+ '/proj/talks/A.md',
+ '/proj/talks/A.md',
+ '/proj/talks/B.md',
+ ]);
+ expect(toastLoadingSpy).toHaveBeenCalledTimes(3);
+ expect(spanNames.filter((name) => name === 'ok.slides.opened')).toHaveLength(2);
+ expect(action.getAttribute('aria-busy')).toBe('true');
+
+ await act(async () => {
+ resolveRetry?.({ kind: 'open', ok: true });
+ });
+ expect(action.getAttribute('aria-busy')).toBe('true');
+ resolveDeckB?.({ kind: 'open', ok: true });
+ await waitFor(() => expect(action.getAttribute('aria-busy')).toBe('false'));
+ } finally {
+ getTracerSpy.mockRestore();
+ }
+ });
+
+ test('a shell that never renders a deck surfaces the render-failure message', async () => {
+ const user = userEvent.setup();
+ installBridge({
+ status: () => Promise.resolve({ kind: 'status', available: true, source: 'global' }),
+ open: () => Promise.resolve({ kind: 'open', ok: false, reason: 'renderer-failed' }),
+ });
+ await renderControls(makeProvider('---\nslides: true\n---\nbody\n'));
+
+ await user.click(await screen.findByTestId('slides-toolbar-action'));
+
+ await waitFor(() =>
+ expect(toastErrorSpy).toHaveBeenCalledWith(
+ "Slidev couldn't render this document.",
+ expect.objectContaining({
+ action: expect.objectContaining({ label: 'Try again' }),
+ id: 'slides-opening',
+ }),
+ ),
);
});
+ test('closing the hidden window cancels progress without showing an error', async () => {
+ const user = userEvent.setup();
+ installBridge({
+ status: () => Promise.resolve({ kind: 'status', available: true, source: 'global' }),
+ open: () => Promise.resolve({ kind: 'open', ok: false, reason: 'cancelled' }),
+ });
+ await renderControls(makeProvider('---\nslides: true\n---\nbody\n'));
+
+ const action = await screen.findByTestId('slides-toolbar-action');
+ await user.click(action);
+
+ await waitFor(() => expect(toastDismissSpy).toHaveBeenCalledWith('slides-opening'));
+ expect(toastErrorSpy).not.toHaveBeenCalled();
+ expect(action.getAttribute('aria-busy')).toBe('false');
+ });
+
test('a foreign or too-old server on the port surfaces the unsupported-version message', async () => {
const user = userEvent.setup();
installBridge({
@@ -273,7 +422,10 @@ describe('SlidesToolbarControls — activation', () => {
await user.click(await screen.findByTestId('slides-toolbar-action'));
await waitFor(() =>
- expect(toastErrorSpy).toHaveBeenCalledWith("This isn't a supported version of Slidev."),
+ expect(toastErrorSpy).toHaveBeenCalledWith(
+ "This isn't a supported version of Slidev.",
+ expect.objectContaining({ id: 'slides-opening' }),
+ ),
);
});
@@ -287,7 +439,12 @@ describe('SlidesToolbarControls — activation', () => {
await user.click(await screen.findByTestId('slides-toolbar-action'));
- await waitFor(() => expect(toastErrorSpy).toHaveBeenCalledWith("Couldn't start Slidev."));
+ await waitFor(() =>
+ expect(toastErrorSpy).toHaveBeenCalledWith(
+ "Couldn't start Slidev.",
+ expect.objectContaining({ id: 'slides-opening' }),
+ ),
+ );
});
test('an open that rejects at the IPC boundary surfaces an error and logs the cause', async () => {
diff --git a/packages/app/src/components/SlidesToolbarControls.tsx b/packages/app/src/components/SlidesToolbarControls.tsx
index 58367758e..9e04a5843 100644
--- a/packages/app/src/components/SlidesToolbarControls.tsx
+++ b/packages/app/src/components/SlidesToolbarControls.tsx
@@ -1,10 +1,11 @@
import type { HocuspocusProvider } from '@hocuspocus/provider';
import { Trans, useLingui } from '@lingui/react/macro';
import { Presentation } from 'lucide-react';
-import { useEffect, useState } from 'react';
+import { useEffect, useRef, useState } from 'react';
import { toast } from 'sonner';
import { Button } from '@/components/ui/button';
import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';
+import type { OkSlidesOpenResult } from '@/lib/desktop-bridge-types';
import { recordSlidesOpened } from '@/lib/slides-telemetry';
import { useBooleanFrontmatterField } from '@/lib/use-boolean-frontmatter-field';
import { useWorkspace } from '@/lib/use-workspace';
@@ -12,6 +13,100 @@ import { docNameToRelativePath, joinWorkspacePath } from '@/lib/workspace-paths'
type SlidevAvailability = 'pending' | 'available' | 'unavailable';
+interface SlidesOpenCopy {
+ readonly opening: string;
+ readonly timeout: string;
+ readonly renderFailed: string;
+ readonly openFailed: string;
+ readonly unsupported: string;
+ readonly startFailed: string;
+ readonly retry: string;
+}
+
+async function openSlidesDeck(
+ slides: { open(docPath: string): Promise<OkSlidesOpenResult> },
+ docPath: string,
+ copy: SlidesOpenCopy,
+ retry: () => void,
+): Promise<void> {
+ const toastId = toast.loading(copy.opening, { duration: Number.POSITIVE_INFINITY });
+ try {
+ const result = await slides.open(docPath);
+ if (result.ok) {
+ toast.dismiss(toastId);
+ return;
+ }
+ if (result.reason === 'cancelled') {
+ toast.dismiss(toastId);
+ return;
+ }
+ let message: string;
+ let retryable = false;
+ switch (result.reason) {
+ case 'timeout':
+ message = copy.timeout;
+ retryable = true;
+ break;
+ case 'exited-early':
+ case 'renderer-failed':
+ message = copy.renderFailed;
+ retryable = true;
+ break;
+ case 'load-failed':
+ message = copy.openFailed;
+ retryable = true;
+ break;
+ case 'unsupported-server':
+ message = copy.unsupported;
+ break;
+ case 'spawn-error':
+ message = copy.startFailed;
+ retryable = true;
+ break;
+ case 'not-available':
+ case 'invalid-path':
+ message = copy.openFailed;
+ break;
+ default: {
+ const _exhaustive: never = result.reason;
+ message = copy.openFailed;
+ }
+ }
+ toast.error(message, {
+ id: toastId,
+ ...(retryable ? { action: { label: copy.retry, onClick: retry } } : {}),
+ });
+ } catch (err) {
+ console.warn('[slides] open dispatch failed:', err instanceof Error ? err : String(err));
+ toast.error(copy.openFailed, {
+ id: toastId,
+ action: { label: copy.retry, onClick: retry },
+ });
+ }
+}
+
+async function runOpenAttempt(
+ slides: { open(docPath: string): Promise<OkSlidesOpenResult> },
+ docPath: string,
+ copy: SlidesOpenCopy,
+ openingPathsRef: { current: Set<string> },
+ setOpeningPaths: (paths: ReadonlySet<string>) => void,
+ recordActivation: boolean,
+): Promise<void> {
+ if (openingPathsRef.current.has(docPath)) return;
+ openingPathsRef.current.add(docPath);
+ try {
+ setOpeningPaths(new Set(openingPathsRef.current));
+ if (recordActivation) recordSlidesOpened();
+ await openSlidesDeck(slides, docPath, copy, () => {
+ void runOpenAttempt(slides, docPath, copy, openingPathsRef, setOpeningPaths, false);
+ });
+ } finally {
+ openingPathsRef.current.delete(docPath);
+ setOpeningPaths(new Set(openingPathsRef.current));
+ }
+}
+
function useSlidevAvailability(isDeck: boolean): SlidevAvailability {
const [availability, setAvailability] = useState<SlidevAvailability>('pending');
useEffect(() => {
@@ -68,50 +163,39 @@ export function SlidesToolbarControls({
const isDeck = useBooleanFrontmatterField(provider, 'slides');
const availability = useSlidevAvailability(isDeck);
const workspace = useWorkspace();
+ const openingPathsRef = useRef(new Set<string>());
+ const [openingPaths, setOpeningPaths] = useState<ReadonlySet<string>>(() => new Set());
if (!isDeck || availability !== 'available') return null;
+ const docPath =
+ workspace == null
+ ? null
+ : joinWorkspacePath(
+ workspace.contentDir,
+ docNameToRelativePath(docName),
+ workspace.pathSeparator,
+ );
+
async function openAsSlides() {
const slides = window.okDesktop?.slides;
- if (slides == null || workspace == null) return;
- recordSlidesOpened();
- const docPath = joinWorkspacePath(
- workspace.contentDir,
- docNameToRelativePath(docName),
- workspace.pathSeparator,
+ if (slides == null || docPath == null) return;
+ await runOpenAttempt(
+ slides,
+ docPath,
+ {
+ opening: t`Opening...`,
+ timeout: t`Slidev timed out while starting. Try again.`,
+ renderFailed: t`Slidev couldn't render this document.`,
+ openFailed: t`Couldn't open this document in Slidev.`,
+ unsupported: t`This isn't a supported version of Slidev.`,
+ startFailed: t`Couldn't start Slidev.`,
+ retry: t`Try again`,
+ },
+ openingPathsRef,
+ setOpeningPaths,
+ true,
);
- try {
- const result = await slides.open(docPath);
- if (!result.ok) {
- let message: string;
- switch (result.reason) {
- case 'timeout':
- message = t`Slidev timed out while starting. Try again.`;
- break;
- case 'exited-early':
- message = t`Slidev couldn't render this document.`;
- break;
- case 'unsupported-server':
- message = t`This isn't a supported version of Slidev.`;
- break;
- case 'spawn-error':
- message = t`Couldn't start Slidev.`;
- break;
- case 'not-available':
- case 'invalid-path':
- message = t`Couldn't open this document in Slidev.`;
- break;
- default: {
- const _exhaustive: never = result.reason;
- message = t`Couldn't open this document in Slidev.`;
- }
- }
- toast.error(message);
- }
- } catch (err) {
- console.warn('[slides] open dispatch failed:', err instanceof Error ? err : String(err));
- toast.error(t`Couldn't open this document in Slidev.`);
- }
}
return (
@@ -121,6 +205,7 @@ export function SlidesToolbarControls({
size="icon"
onClick={openAsSlides}
aria-label={t`Open in Slidev`}
+ aria-busy={docPath != null && openingPaths.has(docPath)}
data-testid="slides-toolbar-action"
asChild
>
diff --git a/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx b/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
index 9e043d02b..3a15d1233 100644
--- a/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
+++ b/packages/app/src/editor/extensions/source-dirty-fold-atomicity.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { sharedExtensions as coreExtensions, MarkdownManager } from '@inkeep/open-knowledge-core';
import { type ObserverDispatchKind, setupServerObservers } from '@inkeep/open-knowledge-server';
import { cleanup } from '@testing-library/react';
diff --git a/packages/app/src/locales/ar/messages.po b/packages/app/src/locales/ar/messages.po
index bd3078064..f899767be 100644
--- a/packages/app/src/locales/ar/messages.po
+++ b/packages/app/src/locales/ar/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "يجري فتح شجرة العمل"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "يجري الفتح..."
@@ -14166,6 +14167,7 @@ msgstr "جرّب موجّهًا"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "أعد المحاولة"
diff --git a/packages/app/src/locales/bn/messages.po b/packages/app/src/locales/bn/messages.po
index 881750230..ce1b3d739 100644
--- a/packages/app/src/locales/bn/messages.po
+++ b/packages/app/src/locales/bn/messages.po
@@ -9480,6 +9480,7 @@ msgid "Opening worktree"
msgstr "ওয়ার্কট্রি খোলা হচ্ছে"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "খোলা হচ্ছে…"
@@ -14162,6 +14163,7 @@ msgstr "একটি প্রম্পট চেষ্টা করে দে
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "আবার চেষ্টা করুন"
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index 9fc4cc695..71e351fff 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "Opening worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "Opening..."
@@ -14166,6 +14167,7 @@ msgstr "Try a prompt"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "Try again"
diff --git a/packages/app/src/locales/es/messages.po b/packages/app/src/locales/es/messages.po
index 81463c68d..0a6b23c40 100644
--- a/packages/app/src/locales/es/messages.po
+++ b/packages/app/src/locales/es/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "Abriendo el worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "Abriendo..."
@@ -14166,6 +14167,7 @@ msgstr "Prueba un prompt"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "Inténtalo de nuevo"
diff --git a/packages/app/src/locales/fr/messages.po b/packages/app/src/locales/fr/messages.po
index fad143759..52ba115d1 100644
--- a/packages/app/src/locales/fr/messages.po
+++ b/packages/app/src/locales/fr/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "Ouverture du worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "Ouverture…"
@@ -14166,6 +14167,7 @@ msgstr "Essayer une invite"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "Réessayer"
diff --git a/packages/app/src/locales/hi/messages.po b/packages/app/src/locales/hi/messages.po
index 21794b777..b5e659d07 100644
--- a/packages/app/src/locales/hi/messages.po
+++ b/packages/app/src/locales/hi/messages.po
@@ -9480,6 +9480,7 @@ msgid "Opening worktree"
msgstr "वर्कट्री खोला जा रहा है"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "खोला जा रहा है…"
@@ -14162,6 +14163,7 @@ msgstr "कोई प्रॉम्प्ट आज़माएँ"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "फिर कोशिश करें"
diff --git a/packages/app/src/locales/id/messages.po b/packages/app/src/locales/id/messages.po
index 64622f626..e3e89e383 100644
--- a/packages/app/src/locales/id/messages.po
+++ b/packages/app/src/locales/id/messages.po
@@ -9480,6 +9480,7 @@ msgid "Opening worktree"
msgstr "Membuka worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "Membuka..."
@@ -14162,6 +14163,7 @@ msgstr "Coba sebuah prompt"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "Coba lagi"
diff --git a/packages/app/src/locales/ko/messages.po b/packages/app/src/locales/ko/messages.po
index 966b61eac..18454c536 100644
--- a/packages/app/src/locales/ko/messages.po
+++ b/packages/app/src/locales/ko/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "워크트리 여는 중"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "여는 중…"
@@ -14166,6 +14167,7 @@ msgstr "프롬프트 사용"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "다시 시도"
diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.po
index 22ac00f4c..8648a13ca 100644
--- a/packages/app/src/locales/pseudo/messages.po
+++ b/packages/app/src/locales/pseudo/messages.po
@@ -9480,6 +9480,7 @@ msgid "Opening worktree"
msgstr ""
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr ""
@@ -14162,6 +14163,7 @@ msgstr ""
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr ""
diff --git a/packages/app/src/locales/pt-BR/messages.po b/packages/app/src/locales/pt-BR/messages.po
index 815597597..246645489 100644
--- a/packages/app/src/locales/pt-BR/messages.po
+++ b/packages/app/src/locales/pt-BR/messages.po
@@ -9480,6 +9480,7 @@ msgid "Opening worktree"
msgstr "Abrindo o worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "Abrindo..."
@@ -14162,6 +14163,7 @@ msgstr "Experimente um prompt"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "Tente de novo"
diff --git a/packages/app/src/locales/ur/messages.po b/packages/app/src/locales/ur/messages.po
index cb8d10664..7211863e1 100644
--- a/packages/app/src/locales/ur/messages.po
+++ b/packages/app/src/locales/ur/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "ورک ٹری کھولا جا رہا ہے"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "کھولا جا رہا ہے..."
@@ -14166,6 +14167,7 @@ msgstr "کوئی پرامپٹ آزمائیں"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "دوبارہ کوشش کریں"
diff --git a/packages/app/src/locales/zh-Hans/messages.po b/packages/app/src/locales/zh-Hans/messages.po
index 5a9be06ca..976716c54 100644
--- a/packages/app/src/locales/zh-Hans/messages.po
+++ b/packages/app/src/locales/zh-Hans/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "正在打开 worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "正在打开…"
@@ -14166,6 +14167,7 @@ msgstr "试试一段提示词"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "重试"
diff --git a/packages/app/src/locales/zh-Hant/messages.po b/packages/app/src/locales/zh-Hant/messages.po
index 768123e49..9b448c96d 100644
--- a/packages/app/src/locales/zh-Hant/messages.po
+++ b/packages/app/src/locales/zh-Hant/messages.po
@@ -9484,6 +9484,7 @@ msgid "Opening worktree"
msgstr "正在開啟 worktree"
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
msgid "Opening..."
msgstr "正在開啟…"
@@ -14166,6 +14167,7 @@ msgstr "試試一段提示"
#: src/components/settings/AccountSection.tsx
#: src/components/settings/SavedThemesTiles.tsx
#: src/components/ShareReceiveDialog.tsx
+#: src/components/SlidesToolbarControls.tsx
#: src/editor/components/ExcalidrawEmbed.tsx
msgid "Try again"
msgstr "再試一次"
diff --git a/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx b/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
index f81d64a77..65162a22f 100644
--- a/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
+++ b/packages/app/tests/dom/input-rule-atom-ranges.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { cleanup } from '@testing-library/react';
import { Editor, getSchema } from '@tiptap/core';
import type { MarkType, Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx b/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
index c4c510031..c5b8ad023 100644
--- a/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
+++ b/packages/app/tests/dom/jsx-interior-input-rule-suppression.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { cleanup } from '@testing-library/react';
import { Editor, type JSONContent } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx b/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
index 931aaa880..65b32f4b3 100644
--- a/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
+++ b/packages/app/tests/dom/plain-text-clipboard.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { cleanup } from '@testing-library/react';
import { Editor } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx b/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
index c9744993d..2ab40357a 100644
--- a/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
+++ b/packages/app/tests/dom/serializer-seam-rederive.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { MarkdownManager, stripFrontmatter } from '@inkeep/open-knowledge-core';
import { cleanup } from '@testing-library/react';
import { Editor, type JSONContent } from '@tiptap/core';
diff --git a/packages/app/tests/dom/task-list-input-rule.dom.test.tsx b/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
index e01856aac..1db8b25a9 100644
--- a/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
+++ b/packages/app/tests/dom/task-list-input-rule.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { cleanup } from '@testing-library/react';
import type { Editor } from '@tiptap/core';
import type { Node as PMNode } from '@tiptap/pm/model';
diff --git a/packages/app/tests/dom/underline-round-trip.dom.test.tsx b/packages/app/tests/dom/underline-round-trip.dom.test.tsx
index f0bea3f33..652d75f43 100644
--- a/packages/app/tests/dom/underline-round-trip.dom.test.tsx
+++ b/packages/app/tests/dom/underline-round-trip.dom.test.tsx
@@ -1,3 +1,4 @@
+
import { MarkdownManager, sharedExtensions, stripFrontmatter } from '@inkeep/open-knowledge-core';
import { cleanup } from '@testing-library/react';
import { Editor, getSchema, type JSONContent } from '@tiptap/core';
diff --git a/packages/app/tests/integration/api-error-envelope/create-folder.test.ts b/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
index 49257d365..079b42e9a 100644
--- a/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
+++ b/packages/app/tests/integration/api-error-envelope/create-folder.test.ts
@@ -1,3 +1,4 @@
+
import { CreateFolderSuccessSchema, ProblemDetailsSchema } from '@inkeep/open-knowledge-core';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import { HARNESS_BOOT_TIMEOUT_MS } from '../harness-boot-timeout';
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index 8a60e5826..a28cc2b18 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,3 +1,4 @@
+
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 6fcdc23f2..4fc2c11f9 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 40b5cdfd6..9f2f6feb6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 93666af70..2a085742b 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 867598d34..878d5196b 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,3 +1,4 @@
+
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 0970ac12f..4ada3cf26 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index b632185e1..cbe2b705f 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,3 +1,4 @@
+
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index c530ce4ba..89bc9b4d9 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,3 +1,4 @@
+
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index d3767adc9..a78aeb0e4 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,3 +1,4 @@
+
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index be1a29fbc..39e64a221 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,3 +1,4 @@
+
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 7935e35f8..9ddcd0730 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index f4cc8a286..2a597ec3d 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,3 +1,4 @@
+
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 8fb428b90..01ef76a9f 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,3 +1,4 @@
+
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/desktop-bridge.ts b/packages/core/src/desktop-bridge.ts
index c15852429..8f7425f1c 100644
--- a/packages/core/src/desktop-bridge.ts
+++ b/packages/core/src/desktop-bridge.ts
@@ -740,6 +740,9 @@ export type SlidevOpenFailureReason =
| 'invalid-path'
| 'spawn-error'
| 'exited-early'
+ | 'cancelled'
+ | 'load-failed'
+ | 'renderer-failed'
| 'timeout'
| 'unsupported-server';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index bfbd5a2e8..20a68d2a1 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/fixtures/index.ts b/packages/core/src/markdown/fixtures/index.ts
index 00f5771ee..6931623c7 100644
--- a/packages/core/src/markdown/fixtures/index.ts
+++ b/packages/core/src/markdown/fixtures/index.ts
@@ -1,3 +1,4 @@
+
import { readFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
@@ -8,6 +9,7 @@ function fixturePath(...segments: string[]): string {
return resolve(FIXTURES_DIR, ...segments);
}
+
interface GfmExample {
section: string;
markdown: string;
@@ -17,6 +19,7 @@ export function loadGfmExamples(): GfmExample[] {
return JSON.parse(readFileSync(fixturePath('gfm', 'examples.json'), 'utf8')) as GfmExample[];
}
+
interface MdxCrashEntry {
id: string;
input: string;
@@ -68,6 +71,7 @@ export function loadLargeEmbedFixtures(): LargeEmbedFixture[] {
) as LargeEmbedFixture[];
}
+
export function loadPrd6955Before(): string {
return readFileSync(fixturePath('regression', 'prd-6955-before.md'), 'utf8');
}
@@ -76,6 +80,7 @@ export function loadPrd6955CorruptedTriplicated(): string {
return readFileSync(fixturePath('regression', 'prd-6955-corrupted-triplicated.md'), 'utf8');
}
+
export interface NgPinnedCase {
id: string;
name: string;
@@ -92,6 +97,7 @@ export function loadNgPinnedCases(): NgPinnedCase[] {
) as NgPinnedCase[];
}
+
export function loadLargeRealistic(): string {
return readFileSync(fixturePath('perf', 'large-realistic.md'), 'utf8');
}
diff --git a/packages/core/src/markdown/fixtures/perf/generate.ts b/packages/core/src/markdown/fixtures/perf/generate.ts
index 8b1eb8519..daa3ef82b 100644
--- a/packages/core/src/markdown/fixtures/perf/generate.ts
+++ b/packages/core/src/markdown/fixtures/perf/generate.ts
@@ -1,3 +1,4 @@
+
import { writeFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
@@ -10,6 +11,7 @@ const BASELINE_ONLY_COUNTS = [500, 2500] as const;
const SEED = 0xf1de1117;
+
function mulberry32(seed: number): () => number {
let a = seed >>> 0;
return () => {
@@ -36,6 +38,7 @@ function pickWeighted<T>(rand: () => number, items: readonly [T, number][]): T {
return items[items.length - 1][0];
}
+
const WORDS = [
'lorem',
'ipsum',
@@ -153,6 +156,7 @@ function mdxBlock(rand: () => number): string {
return `<${name}>\n\n${sentence(rand)}\n\n</${name}>`;
}
+
type BlockKind = 'paragraph' | 'heading' | 'list' | 'code' | 'table' | 'mdx';
const MIX: readonly [BlockKind, number][] = [
@@ -191,6 +195,7 @@ function generateDocument(blockCount: number, seed: number): string {
return `${blocks.join('\n\n')}\n`;
}
+
function main(): void {
for (const count of [...BLOCK_COUNTS, ...BASELINE_ONLY_COUNTS]) {
const doc = generateDocument(count, SEED);
diff --git a/packages/core/src/markdown/image-promoter.ts b/packages/core/src/markdown/image-promoter.ts
index 706fa9afb..994eb6917 100644
--- a/packages/core/src/markdown/image-promoter.ts
+++ b/packages/core/src/markdown/image-promoter.ts
@@ -1,3 +1,4 @@
+
import type { Image, Paragraph, Root } from 'mdast';
import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';
import { visit } from 'unist-util-visit';
diff --git a/packages/core/src/markdown/math-promoter.ts b/packages/core/src/markdown/math-promoter.ts
index a5b511f25..bd79424c7 100644
--- a/packages/core/src/markdown/math-promoter.ts
+++ b/packages/core/src/markdown/math-promoter.ts
@@ -1,3 +1,4 @@
+
import type { Code, Root } from 'mdast';
import type { Math as MdastMath } from 'mdast-util-math';
import type { MdxJsxAttribute, MdxJsxFlowElement } from 'mdast-util-mdx';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index bfd7e3109..fa3cfcd86 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,3 +1,4 @@
+
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 4d3250d3a..8be632ba4 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,3 +1,4 @@
+
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');
diff --git a/packages/desktop/src/main/graceful-terminate.test.ts b/packages/desktop/src/main/graceful-terminate.test.ts
index 43e85874a..ee5b03dc8 100644
--- a/packages/desktop/src/main/graceful-terminate.test.ts
+++ b/packages/desktop/src/main/graceful-terminate.test.ts
@@ -60,6 +60,29 @@ describe('gracefulTerminate', () => {
expect(result).toEqual({ escalated: false });
});
+ it('waits for asynchronous signal dispatch before polling liveness', async () => {
+ let releaseSignal: (() => void) | undefined;
+ let polled = false;
+ const termination = gracefulTerminate({
+ sendSignal: () =>
+ new Promise<void>((resolve) => {
+ releaseSignal = resolve;
+ }),
+ isAlive: () => {
+ polled = true;
+ return false;
+ },
+ now: () => 0,
+ sleep: () => Promise.resolve(),
+ });
+
+ await Promise.resolve();
+ expect(polled).toBe(false);
+ releaseSignal?.();
+ await termination;
+ expect(polled).toBe(true);
+ });
+
it('defaults the grace and poll cadence to the shared lifecycle constants', async () => {
const { deps, signals, sleeps } = scriptedDeps({ aliveForChecks: Infinity });
const result = await gracefulTerminate(deps);
diff --git a/packages/desktop/src/main/graceful-terminate.ts b/packages/desktop/src/main/graceful-terminate.ts
index 356f1f3a3..c5dfef0b1 100644
--- a/packages/desktop/src/main/graceful-terminate.ts
+++ b/packages/desktop/src/main/graceful-terminate.ts
@@ -1,7 +1,7 @@
import { DEFAULT_SIGTERM_GRACE_MS, DEFAULT_SIGTERM_POLL_MS } from '@inkeep/open-knowledge-core';
export interface GracefulTerminateDeps {
- sendSignal(signal: 'SIGTERM' | 'SIGKILL'): void;
+ sendSignal(signal: 'SIGTERM' | 'SIGKILL'): void | Promise<void>;
isAlive(): boolean;
now(): number;
sleep(ms: number): Promise<void>;
@@ -15,12 +15,12 @@ export async function gracefulTerminate(
const graceMs = deps.graceMs ?? DEFAULT_SIGTERM_GRACE_MS;
const pollMs = deps.pollMs ?? DEFAULT_SIGTERM_POLL_MS;
- deps.sendSignal('SIGTERM');
+ await deps.sendSignal('SIGTERM');
const deadline = deps.now() + graceMs;
while (deps.now() < deadline) {
if (!deps.isAlive()) return { escalated: false };
await deps.sleep(pollMs);
}
- deps.sendSignal('SIGKILL');
+ await deps.sendSignal('SIGKILL');
return { escalated: true };
}
diff --git a/packages/desktop/src/main/index.ts b/packages/desktop/src/main/index.ts
index 6903aa9de..60ce622ff 100644
--- a/packages/desktop/src/main/index.ts
+++ b/packages/desktop/src/main/index.ts
@@ -278,7 +278,7 @@ import {
} from './ipc/local-op.ts';
import { handleSeedApply, handleSeedListPacks, handleSeedPlan } from './ipc/seed.ts';
import { handleSharingSetMode, handleSharingStatus } from './ipc/sharing.ts';
-import { handleSlidesOpen, handleSlidesStatus } from './ipc/slides.ts';
+import { handleSlidesOpen, handleSlidesStatus, shouldLogSlidesOpenError } from './ipc/slides.ts';
import {
detectProtocol as detectProtocolImpl,
recordHandoff as recordHandoffImpl,
@@ -4446,7 +4446,7 @@ function registerIpcHandlers() {
},
recordOpenAttempt: recordDeckOpen,
openWindow: (deck) => {
- createSlidesWindow({
+ return createSlidesWindow({
createWindow: (winOpts) => {
const win = new BrowserWindow({
...DEFAULT_WIN_OPTS,
@@ -4476,7 +4476,7 @@ function registerIpcHandlers() {
window.focus();
},
});
- if (!opened.ok) {
+ if (shouldLogSlidesOpenError(opened)) {
logIpcError({
event: 'ipc.error',
channel: 'ok:slides:dispatch',
@@ -6381,7 +6381,15 @@ function bootPrimaryInstance(): void {
const runTerminalQuitDrain = createTerminalQuitDrain({
defer: (callback) => setImmediate(callback),
- drain: () => terminalReaper?.killAll() ?? Promise.resolve(),
+ drain: async () => {
+ const [terminalResult] = await Promise.allSettled([
+ terminalReaper?.killAll() ?? Promise.resolve(),
+ slidesDeckRegistry.reapAll(),
+ ]);
+ if (terminalResult.status === 'rejected') {
+ getLogger('lifecycle').warn({ err: terminalResult.reason }, 'terminal quit drain failed');
+ }
+ },
resumeQuit: () => app.quit(),
});
app.on('will-quit', (event) => {
@@ -6393,8 +6401,6 @@ function bootPrimaryInstance(): void {
crashSentinelHeartbeat = null;
}
rendererRecovery = null;
- void terminalReaper?.killAll();
- slidesDeckRegistry.reapAll();
dockVisibleForWindow.clear();
agentPanelVisibleForWindow.clear();
dockOrderForWindow.clear();
diff --git a/packages/desktop/src/main/ipc/slides.test.ts b/packages/desktop/src/main/ipc/slides.test.ts
index b9f6bd2d7..682bc81ea 100644
--- a/packages/desktop/src/main/ipc/slides.test.ts
+++ b/packages/desktop/src/main/ipc/slides.test.ts
@@ -4,7 +4,7 @@ import type { OkSlidesOpenResult } from '../../shared/ipc-channels.ts';
import { createSlidesDeckRegistry, type SlidesDeckWindow } from '../slides-registry.ts';
import type { SlidevResolveProbes } from '../slidev-resolve.ts';
import type { SlidevProcess, StartSlidevDeps } from '../slidev-server.ts';
-import { handleSlidesOpen, handleSlidesStatus } from './slides.ts';
+import { handleSlidesOpen, handleSlidesStatus, shouldLogSlidesOpenError } from './slides.ts';
const PROJECT = '/tmp/deck-project';
const LOCAL_BIN = join(PROJECT, 'node_modules', '.bin', 'slidev');
@@ -73,18 +73,32 @@ describe('handleSlidesStatus', () => {
const DECK = '/decks/talk/slides.md';
-function fakeSlidevProcess(): SlidevProcess {
- return { onExit: () => {}, signal: () => {}, isAlive: () => true, pid: 7 };
+function fakeSlidevProcess(signals?: Array<'SIGTERM' | 'SIGKILL'>): SlidevProcess {
+ return {
+ onExit: () => {},
+ signal: (signal) => {
+ signals?.push(signal);
+ return Promise.resolve();
+ },
+ isAlive: () => true,
+ pid: 7,
+ };
}
function fakeWindow(id: number): SlidesDeckWindow {
return { id } as unknown as SlidesDeckWindow;
}
-function readyStartDeps(port: number): { deps: StartSlidevDeps; process: SlidevProcess } {
- const process = fakeSlidevProcess();
+function readyStartDeps(port: number): {
+ deps: StartSlidevDeps;
+ process: SlidevProcess;
+ signals: Array<'SIGTERM' | 'SIGKILL'>;
+} {
+ const signals: Array<'SIGTERM' | 'SIGKILL'> = [];
+ const process = fakeSlidevProcess(signals);
return {
process,
+ signals,
deps: {
findFreePort: () => Promise.resolve(port),
spawnSlidev: () => process,
@@ -126,7 +140,10 @@ describe('handleSlidesOpen', () => {
const result = await handleSlidesOpen(DECK, {
registry,
startDeps,
- openWindow: (deck) => opened.push(deck),
+ openWindow: async (deck) => {
+ opened.push(deck);
+ return { shown: true };
+ },
focusWindow: () => {
throw new Error('a fresh open must not focus an existing window');
},
@@ -160,9 +177,10 @@ describe('handleSlidesOpen', () => {
const deps = {
registry,
startDeps,
- openWindow: (deck: { docPath: string; port: number; process: SlidevProcess }) => {
+ openWindow: async (deck: { docPath: string; port: number; process: SlidevProcess }) => {
opened.push({ docPath: deck.docPath, port: deck.port });
registry.register({ ...deck, window: fakeWindow(opened.length) });
+ return { shown: true };
},
focusWindow: () => {},
recordOpenAttempt: () => {},
@@ -239,8 +257,9 @@ describe('handleSlidesOpen', () => {
const result = await handleSlidesOpen(DECK, {
registry,
startDeps,
- openWindow: () => {
+ openWindow: async () => {
openedCount += 1;
+ return { shown: true };
},
focusWindow: () => {},
recordOpenAttempt: () => {},
@@ -250,13 +269,64 @@ describe('handleSlidesOpen', () => {
expect(openedCount).toBe(0);
});
+ it('reports renderer-failed when the server shell loads but the deck never mounts', async () => {
+ const registry = createSlidesDeckRegistry();
+ const attempts: OkSlidesOpenResult[] = [];
+ const started = readyStartDeps(5200);
+ const result = await handleSlidesOpen(DECK, {
+ registry,
+ startDeps: started.deps,
+ openWindow: async () => ({ shown: false, reason: 'renderer-failed' }),
+ focusWindow: () => {},
+ recordOpenAttempt: (attempt) => attempts.push(attempt),
+ });
+
+ expect(result).toEqual({ kind: 'open', ok: false, reason: 'renderer-failed' });
+ expect(attempts).toEqual([{ kind: 'open', ok: false, reason: 'renderer-failed' }]);
+ await registry.reapAll();
+ expect(started.signals).toEqual(['SIGKILL']);
+ });
+
+ it('preserves a navigation failure from the hidden window lifecycle', async () => {
+ const registry = createSlidesDeckRegistry();
+ const attempts: OkSlidesOpenResult[] = [];
+ const result = await handleSlidesOpen(DECK, {
+ registry,
+ startDeps: readyStartDeps(5200).deps,
+ openWindow: async () => ({ shown: false, reason: 'load-failed' }),
+ focusWindow: () => {},
+ recordOpenAttempt: (attempt) => attempts.push(attempt),
+ });
+
+ expect(result).toEqual({ kind: 'open', ok: false, reason: 'load-failed' });
+ expect(attempts).toEqual([{ kind: 'open', ok: false, reason: 'load-failed' }]);
+ });
+
+ it('does not record a user-cancelled hidden window as a failed open', async () => {
+ const registry = createSlidesDeckRegistry();
+ const attempts: OkSlidesOpenResult[] = [];
+ const result = await handleSlidesOpen(DECK, {
+ registry,
+ startDeps: readyStartDeps(5200).deps,
+ openWindow: async () => ({ shown: false, reason: 'cancelled' }),
+ focusWindow: () => {},
+ recordOpenAttempt: (attempt) => attempts.push(attempt),
+ });
+
+ expect(result).toEqual({ kind: 'open', ok: false, reason: 'cancelled' });
+ expect(attempts).toEqual([]);
+ });
+
it('records exactly one open attempt for a fresh spawn', async () => {
const registry = createSlidesDeckRegistry();
const attempts: OkSlidesOpenResult[] = [];
await handleSlidesOpen(DECK, {
registry,
startDeps: readyStartDeps(5200).deps,
- openWindow: (deck) => registry.register({ ...deck, window: fakeWindow(1) }),
+ openWindow: async (deck) => {
+ registry.register({ ...deck, window: fakeWindow(1) });
+ return { shown: true };
+ },
focusWindow: () => {},
recordOpenAttempt: (r) => attempts.push(r),
});
@@ -304,8 +374,10 @@ describe('handleSlidesOpen', () => {
const deps = {
registry,
startDeps,
- openWindow: (deck: { docPath: string; port: number; process: SlidevProcess }) =>
- registry.register({ ...deck, window: fakeWindow(1) }),
+ openWindow: async (deck: { docPath: string; port: number; process: SlidevProcess }) => {
+ registry.register({ ...deck, window: fakeWindow(1) });
+ return { shown: true };
+ },
focusWindow: () => {},
recordOpenAttempt: (r: OkSlidesOpenResult) => attempts.push(r),
};
@@ -325,7 +397,10 @@ describe('handleSlidesOpen', () => {
handleSlidesOpen(docPath, {
registry,
startDeps: readyStartDeps(port).deps,
- openWindow: (deck) => opened.push({ docPath: deck.docPath, port: deck.port }),
+ openWindow: async (deck) => {
+ opened.push({ docPath: deck.docPath, port: deck.port });
+ return { shown: true };
+ },
focusWindow: () => {
throw new Error('distinct decks never focus');
},
@@ -341,3 +416,16 @@ describe('handleSlidesOpen', () => {
]);
});
});
+
+describe('shouldLogSlidesOpenError', () => {
+ it('does not classify user cancellation as an IPC error', () => {
+ expect(shouldLogSlidesOpenError({ kind: 'open', ok: false, reason: 'cancelled' })).toBe(false);
+ });
+
+ it('keeps operational failures observable', () => {
+ expect(shouldLogSlidesOpenError({ kind: 'open', ok: false, reason: 'renderer-failed' })).toBe(
+ true,
+ );
+ expect(shouldLogSlidesOpenError({ kind: 'open', ok: true })).toBe(false);
+ });
+});
diff --git a/packages/desktop/src/main/ipc/slides.ts b/packages/desktop/src/main/ipc/slides.ts
index 2cf7a2f79..57a957a0a 100644
--- a/packages/desktop/src/main/ipc/slides.ts
+++ b/packages/desktop/src/main/ipc/slides.ts
@@ -1,5 +1,6 @@
import type { OkSlidesOpenResult, OkSlidesStatusResult } from '../../shared/ipc-channels.ts';
import type { SlidesDeckRegistry, SlidesDeckWindow } from '../slides-registry.ts';
+import type { SlidesWindowOutcome } from '../slides-window.ts';
import { resolveSlidev, type SlidevResolveProbes } from '../slidev-resolve.ts';
import { type SlidevProcess, type StartSlidevDeps, startSlidevServer } from '../slidev-server.ts';
@@ -16,15 +17,14 @@ export async function handleSlidesStatus(
export interface SlidesOpenDeps {
registry: Pick<
SlidesDeckRegistry,
- | 'get'
- | 'getOpenInFlight'
- | 'setOpenInFlight'
- | 'clearOpenInFlight'
- | 'trackSpawned'
- | 'untrackSpawned'
+ 'get' | 'getOpenInFlight' | 'setOpenInFlight' | 'clearOpenInFlight' | 'trackSpawned'
>;
startDeps: StartSlidevDeps;
- openWindow(deck: { docPath: string; port: number; process: SlidevProcess }): void;
+ openWindow(deck: {
+ docPath: string;
+ port: number;
+ process: SlidevProcess;
+ }): Promise<SlidesWindowOutcome>;
focusWindow(window: SlidesDeckWindow): void;
recordOpenAttempt(result: OkSlidesOpenResult): void;
}
@@ -47,20 +47,25 @@ export async function handleSlidesOpen(
onSpawned: (process) => deps.registry.trackSpawned(docPath, process),
});
if (!started.ok) {
- deps.registry.untrackSpawned(docPath);
const result: OkSlidesOpenResult = { kind: 'open', ok: false, reason: started.reason };
deps.recordOpenAttempt(result);
return result;
}
+ let opened: SlidesWindowOutcome;
try {
- deps.openWindow({ docPath, port: started.port, process: started.process });
+ opened = await deps.openWindow({
+ docPath,
+ port: started.port,
+ process: started.process,
+ });
} catch (err) {
- started.process.signal('SIGTERM');
+ void started.process.signal('SIGTERM');
throw err;
- } finally {
- deps.registry.untrackSpawned(docPath);
}
- const result: OkSlidesOpenResult = { kind: 'open', ok: true };
+ const result: OkSlidesOpenResult = opened.shown
+ ? { kind: 'open', ok: true }
+ : { kind: 'open', ok: false, reason: opened.reason };
+ if (!opened.shown && opened.reason === 'cancelled') return result;
deps.recordOpenAttempt(result);
return result;
})();
@@ -71,3 +76,9 @@ export async function handleSlidesOpen(
deps.registry.clearOpenInFlight(docPath);
}
}
+
+export function shouldLogSlidesOpenError(
+ result: OkSlidesOpenResult,
+): result is Extract<OkSlidesOpenResult, { ok: false }> {
+ return !result.ok && result.reason !== 'cancelled';
+}
diff --git a/packages/desktop/src/main/slides-registry.test.ts b/packages/desktop/src/main/slides-registry.test.ts
index 1d2587aae..db0280fd4 100644
--- a/packages/desktop/src/main/slides-registry.test.ts
+++ b/packages/desktop/src/main/slides-registry.test.ts
@@ -19,6 +19,7 @@ function fakeDeck(docPath: string, port: number) {
onExit: () => {},
signal: (sig) => {
signals.push(sig);
+ return Promise.resolve();
},
isAlive: () => true,
pid: undefined,
@@ -37,7 +38,7 @@ describe('createSlidesDeckRegistry', () => {
expect(registry.get('/decks/other.md')).toBeUndefined();
});
- it('signals every server to stop with SIGTERM and empties on reapAll', () => {
+ it('force-stops every server and empties on reapAll', () => {
const registry = createSlidesDeckRegistry();
const a = fakeDeck('/decks/a.md', 3001);
const b = fakeDeck('/decks/b.md', 3002);
@@ -47,8 +48,8 @@ describe('createSlidesDeckRegistry', () => {
registry.reapAll();
- expect(a.signals()).toEqual(['SIGTERM']);
- expect(b.signals()).toEqual(['SIGTERM']);
+ expect(a.signals()).toEqual(['SIGKILL']);
+ expect(b.signals()).toEqual(['SIGKILL']);
expect(registry.size()).toBe(0);
expect(registry.get('/decks/a.md')).toBeUndefined();
});
@@ -104,23 +105,55 @@ describe('createSlidesDeckRegistry', () => {
expect(registry.size()).toBe(0);
expect(registry.getOpenInFlight('/decks/b.md')).toBeUndefined();
});
+
+ it('clears immediately but waits for every process signal', async () => {
+ const registry = createSlidesDeckRegistry();
+ let release: (() => void) | undefined;
+ const pendingSignal = new Promise<void>((resolve) => {
+ release = resolve;
+ });
+ const { deck } = fakeDeck('/decks/a.md', 3001);
+ deck.process.signal = () => pendingSignal;
+ registry.register(deck);
+ let settled = false;
+
+ const drain = registry.reapAll().then(() => {
+ settled = true;
+ });
+ expect(registry.size()).toBe(0);
+ await Promise.resolve();
+ expect(settled).toBe(false);
+
+ release?.();
+ await drain;
+ expect(settled).toBe(true);
+ });
});
describe('reapAll reaches children that are spawned but not yet registered', () => {
function fakeProc() {
const signals: string[] = [];
+ const exitHandlers: Array<(code: number | null) => void> = [];
+ let alive = true;
return {
signals,
proc: {
- onExit: () => {},
- signal: (s: 'SIGTERM' | 'SIGKILL') => signals.push(s),
- isAlive: () => true,
+ onExit: (handler: (code: number | null) => void) => exitHandlers.push(handler),
+ signal: (s: 'SIGTERM' | 'SIGKILL') => {
+ signals.push(s);
+ return Promise.resolve();
+ },
+ isAlive: () => alive,
pid: 1234,
},
+ emitExit: (code: number | null = 0) => {
+ alive = false;
+ for (const handler of exitHandlers) handler(code);
+ },
};
}
- it('SIGTERMs a spawned-but-unregistered child', () => {
+ it('force-stops a spawned-but-unregistered child', () => {
const registry = createSlidesDeckRegistry();
const { signals, proc } = fakeProc();
registry.trackSpawned('/proj/deck.md', proc);
@@ -128,10 +161,10 @@ describe('reapAll reaches children that are spawned but not yet registered', ()
registry.reapAll();
- expect(signals).toEqual(['SIGTERM']);
+ expect(signals).toEqual(['SIGKILL']);
});
- it('does not double-signal once the child has been handed to decks', () => {
+ it('retains a handed-off child until exit without double-signalling it', () => {
const registry = createSlidesDeckRegistry();
const { signals, proc } = fakeProc();
registry.trackSpawned('/proj/deck.md', proc);
@@ -141,10 +174,54 @@ describe('reapAll reaches children that are spawned but not yet registered', ()
process: proc,
window: { on: () => {}, focus: () => {}, isDestroyed: () => false } as never,
});
- registry.untrackSpawned('/proj/deck.md');
+ registry.unregister('/proj/deck.md');
+ registry.reapAll();
+
+ expect(signals).toEqual(['SIGKILL']);
+ });
+
+ it('keeps an older failed child when a retry for the same deck is handed off', () => {
+ const registry = createSlidesDeckRegistry();
+ const failed = fakeProc();
+ const opened = fakeProc();
+ registry.trackSpawned('/proj/deck.md', failed.proc);
+ registry.trackSpawned('/proj/deck.md', opened.proc);
+ registry.register({
+ docPath: '/proj/deck.md',
+ port: 4300,
+ process: opened.proc,
+ window: { on: () => {}, focus: () => {}, isDestroyed: () => false } as never,
+ });
+ registry.reapAll();
+
+ expect(failed.signals).toEqual(['SIGKILL']);
+ expect(opened.signals).toEqual(['SIGKILL']);
+ });
+
+ it('forgets a failed child after the process exits', () => {
+ const registry = createSlidesDeckRegistry();
+ const failed = fakeProc();
+ registry.trackSpawned('/proj/deck.md', failed.proc);
+
+ failed.emitExit(1);
+ registry.reapAll();
+
+ expect(failed.signals).toEqual([]);
+ });
+
+ it('does not signal a registered process that already exited', () => {
+ const registry = createSlidesDeckRegistry();
+ const opened = fakeProc();
+ registry.register({
+ docPath: '/proj/deck.md',
+ port: 4300,
+ process: opened.proc,
+ window: { on: () => {}, focus: () => {}, isDestroyed: () => false } as never,
+ });
+ opened.emitExit(1);
registry.reapAll();
- expect(signals).toEqual(['SIGTERM']);
+ expect(opened.signals).toEqual([]);
});
});
diff --git a/packages/desktop/src/main/slides-registry.ts b/packages/desktop/src/main/slides-registry.ts
index 0fda3d11c..299c81248 100644
--- a/packages/desktop/src/main/slides-registry.ts
+++ b/packages/desktop/src/main/slides-registry.ts
@@ -15,19 +15,18 @@ export interface SlidesDeckRegistry {
get(docPath: string): RunningSlidesDeck | undefined;
register(deck: RunningSlidesDeck): void;
unregister(docPath: string): void;
- reapAll(): void;
+ reapAll(): Promise<void>;
size(): number;
getOpenInFlight(docPath: string): Promise<OkSlidesOpenResult> | undefined;
setOpenInFlight(docPath: string, attempt: Promise<OkSlidesOpenResult>): void;
clearOpenInFlight(docPath: string): void;
trackSpawned(docPath: string, process: SlidevProcess): void;
- untrackSpawned(docPath: string): void;
}
export function createSlidesDeckRegistry(): SlidesDeckRegistry {
const decks = new Map<string, RunningSlidesDeck>();
const opening = new Map<string, Promise<OkSlidesOpenResult>>();
- const spawned = new Map<string, SlidevProcess>();
+ const spawned = new Map<string, Set<SlidevProcess>>();
return {
get: (docPath) => decks.get(docPath),
register: (deck) => {
@@ -36,12 +35,20 @@ export function createSlidesDeckRegistry(): SlidesDeckRegistry {
unregister: (docPath) => {
decks.delete(docPath);
},
- reapAll: () => {
- for (const deck of decks.values()) deck.process.signal('SIGTERM');
- for (const proc of spawned.values()) proc.signal('SIGTERM');
+ reapAll: async () => {
+ const processes = new Set<SlidevProcess>();
+ for (const deck of decks.values()) {
+ if (deck.process.isAlive()) processes.add(deck.process);
+ }
+ for (const spawnedProcesses of spawned.values()) {
+ for (const process of spawnedProcesses) {
+ if (process.isAlive()) processes.add(process);
+ }
+ }
decks.clear();
spawned.clear();
opening.clear();
+ await Promise.allSettled(Array.from(processes, (process) => process.signal('SIGKILL')));
},
size: () => decks.size,
getOpenInFlight: (docPath) => opening.get(docPath),
@@ -52,10 +59,17 @@ export function createSlidesDeckRegistry(): SlidesDeckRegistry {
opening.delete(docPath);
},
trackSpawned: (docPath, process) => {
- spawned.set(docPath, process);
- },
- untrackSpawned: (docPath) => {
- spawned.delete(docPath);
+ const processes = spawned.get(docPath) ?? new Set<SlidevProcess>();
+ processes.add(process);
+ spawned.set(docPath, processes);
+ const forget = () => {
+ processes.delete(process);
+ if (processes.size === 0 && spawned.get(docPath) === processes) {
+ spawned.delete(docPath);
+ }
+ };
+ process.onExit(forget);
+ if (!process.isAlive()) forget();
},
};
}
diff --git a/packages/desktop/src/main/slides-telemetry.test.ts b/packages/desktop/src/main/slides-telemetry.test.ts
index 7443a4805..cda87eb5c 100644
--- a/packages/desktop/src/main/slides-telemetry.test.ts
+++ b/packages/desktop/src/main/slides-telemetry.test.ts
@@ -102,6 +102,8 @@ describe('recordDeckOpen — lazily-cached instrument', () => {
const failures: OkSlidesOpenResult[] = [
{ kind: 'open', ok: false, reason: 'timeout' },
{ kind: 'open', ok: false, reason: 'exited-early' },
+ { kind: 'open', ok: false, reason: 'load-failed' },
+ { kind: 'open', ok: false, reason: 'renderer-failed' },
{ kind: 'open', ok: false, reason: 'unsupported-server' },
{ kind: 'open', ok: false, reason: 'spawn-error' },
];
@@ -110,6 +112,8 @@ describe('recordDeckOpen — lazily-cached instrument', () => {
expect(counterAdds).toEqual([
{ value: 1, attributes: { 'ok.slides.reason': 'timeout' } },
{ value: 1, attributes: { 'ok.slides.reason': 'exited-early' } },
+ { value: 1, attributes: { 'ok.slides.reason': 'load-failed' } },
+ { value: 1, attributes: { 'ok.slides.reason': 'renderer-failed' } },
{ value: 1, attributes: { 'ok.slides.reason': 'unsupported-server' } },
{ value: 1, attributes: { 'ok.slides.reason': 'spawn-error' } },
]);
diff --git a/packages/desktop/src/main/slides-window.test.ts b/packages/desktop/src/main/slides-window.test.ts
index fcc728dbb..59c7a5d26 100644
--- a/packages/desktop/src/main/slides-window.test.ts
+++ b/packages/desktop/src/main/slides-window.test.ts
@@ -4,7 +4,12 @@ import {
type RunningSlidesDeck,
type SlidesDeckWindow,
} from './slides-registry.ts';
-import { createSlidesWindow, slidesWindowChrome } from './slides-window.ts';
+import {
+ createSlidesWindow,
+ SLIDEV_RENDERED_CHECK,
+ slidesWindowChrome,
+ waitForSlidevRenderer,
+} from './slides-window.ts';
describe('slidesWindowChrome', () => {
test('gives the deck an ordinary native title bar to drag by', () => {
@@ -30,7 +35,10 @@ describe('slidesWindowChrome', () => {
});
});
-function makeFakeWindow(id: number) {
+function makeFakeWindow(
+ id: number,
+ opts: { closeEmitsClosed?: boolean; destroyEmitsClosed?: boolean; rendererReady?: boolean } = {},
+) {
const closedHandlers: Array<() => void> = [];
const readyHandlers: Array<() => void> = [];
let windowOpenHandler: ((details: { url: string }) => { action: 'allow' | 'deny' }) | undefined;
@@ -42,12 +50,17 @@ function makeFakeWindow(id: number) {
| undefined;
const show = vi.fn(() => {});
const close = vi.fn(() => {
- for (const cb of closedHandlers) cb();
+ if (opts.closeEmitsClosed !== false) for (const cb of closedHandlers) cb();
+ });
+ const destroy = vi.fn(() => {
+ if (opts.destroyEmitsClosed !== false) for (const cb of closedHandlers) cb();
});
+ const executeJavaScript = vi.fn(async () => opts.rendererReady ?? true);
const window = {
id,
show,
close,
+ destroy,
once: (event: string, cb: () => void) => {
if (event === 'ready-to-show') readyHandlers.push(cb);
},
@@ -55,6 +68,7 @@ function makeFakeWindow(id: number) {
if (event === 'closed') closedHandlers.push(cb);
},
webContents: {
+ executeJavaScript,
setWindowOpenHandler: (
handler: (details: { url: string }) => { action: 'allow' | 'deny' },
) => {
@@ -75,6 +89,8 @@ function makeFakeWindow(id: number) {
window,
show,
close,
+ destroy,
+ executeJavaScript,
fireReadyToShow: () => {
for (const cb of readyHandlers) cb();
},
@@ -95,15 +111,19 @@ function makeFakeWindow(id: number) {
};
}
-function fakeProcess(opts: { alive?: boolean } = {}) {
+function fakeProcess(opts: { alive?: boolean; diesOnSigterm?: boolean } = {}) {
const signals: Array<'SIGTERM' | 'SIGKILL'> = [];
+ let alive = opts.alive ?? true;
return {
process: {
onExit: () => {},
signal: (sig: 'SIGTERM' | 'SIGKILL') => {
signals.push(sig);
+ if (sig === 'SIGTERM' && opts.diesOnSigterm !== false) alive = false;
+ if (sig === 'SIGKILL') alive = false;
+ return Promise.resolve();
},
- isAlive: () => opts.alive ?? false,
+ isAlive: () => alive,
pid: 4321,
},
signals: () => signals,
@@ -113,7 +133,7 @@ function fakeProcess(opts: { alive?: boolean } = {}) {
function makeDeck(
docPath: string,
port: number,
- opts: { alive?: boolean } = {},
+ opts: { alive?: boolean; diesOnSigterm?: boolean } = {},
): Omit<RunningSlidesDeck, 'window'> & {
signals: () => Array<'SIGTERM' | 'SIGKILL'>;
} {
@@ -139,10 +159,10 @@ async function flushTeardown() {
}
describe('createSlidesWindow', () => {
- test('loads the embedded loopback URL — never OK content over file://', () => {
+ test('loads the embedded loopback URL — never OK content over file://', async () => {
const fake = makeFakeWindow(80_001);
const registry = createSlidesDeckRegistry();
- createSlidesWindow({
+ await createSlidesWindow({
createWindow: () => fake.window,
registry,
deck: makeDeck('/decks/talk.md', 4300),
@@ -152,9 +172,9 @@ describe('createSlidesWindow', () => {
expect(fake.window.loadFile).not.toHaveBeenCalled();
});
- test('denies every new-window request the deck makes — no window.open to any origin', () => {
+ test('denies every new-window request the deck makes — no window.open to any origin', async () => {
const fake = makeFakeWindow(80_001);
- createSlidesWindow({
+ await createSlidesWindow({
createWindow: () => fake.window,
registry: createSlidesDeckRegistry(),
deck: makeDeck('/decks/talk.md', 4300),
@@ -164,9 +184,9 @@ describe('createSlidesWindow', () => {
expect(fake.requestNewWindow('http://localhost:4300/presenter')).toEqual({ action: 'deny' });
});
- test('blocks a top-level navigation off the deck origin but allows in-deck routing', () => {
+ test('blocks a top-level navigation off the deck origin but allows in-deck routing', async () => {
const fake = makeFakeWindow(80_001);
- createSlidesWindow({
+ await createSlidesWindow({
createWindow: () => fake.window,
registry: createSlidesDeckRegistry(),
deck: makeDeck('/decks/talk.md', 4300),
@@ -177,9 +197,9 @@ describe('createSlidesWindow', () => {
expect(fake.navigateTo('not a url')).toBe(true);
});
- test('refuses a cross-origin redirect that a same-origin navigation lands on', () => {
+ test('refuses a cross-origin redirect that a same-origin navigation lands on', async () => {
const fake = makeFakeWindow(80_001);
- createSlidesWindow({
+ await createSlidesWindow({
createWindow: () => fake.window,
registry: createSlidesDeckRegistry(),
deck: makeDeck('/decks/talk.md', 4300),
@@ -189,10 +209,10 @@ describe('createSlidesWindow', () => {
expect(fake.redirectTo('http://localhost:4300/1')).toBe(false);
});
- test('creates the window on an isolated, non-persistent session partition', () => {
+ test('creates the window on an isolated, non-persistent session partition', async () => {
const fake = makeFakeWindow(80_001);
const createWindow = vi.fn((_o: { partition: string; title: string }) => fake.window);
- createSlidesWindow({
+ await createSlidesWindow({
createWindow,
registry: createSlidesDeckRegistry(),
deck: makeDeck('/decks/talk.md', 4300),
@@ -203,11 +223,11 @@ describe('createSlidesWindow', () => {
expect(opts?.partition.startsWith('persist:')).toBe(false);
});
- test('records the deck (with its window) in the registry', () => {
+ test('records the deck (with its window) in the registry after it renders', async () => {
const fake = makeFakeWindow(80_001);
const registry = createSlidesDeckRegistry();
const deck = makeDeck('/decks/talk.md', 4300);
- createSlidesWindow({ createWindow: () => fake.window, registry, deck });
+ await createSlidesWindow({ createWindow: () => fake.window, registry, deck });
const entry = registry.get('/decks/talk.md');
expect(entry?.port).toBe(4300);
@@ -215,24 +235,60 @@ describe('createSlidesWindow', () => {
expect(entry?.window).toBe(fake.window);
});
- test('shows the window on first paint', () => {
+ test('waits for the mounted deck instead of showing on first paint', async () => {
const fake = makeFakeWindow(80_001);
- createSlidesWindow({
+ let reportRendered: (() => void) | undefined;
+ const rendered = new Promise<{ kind: 'rendered' }>((resolve) => {
+ reportRendered = () => resolve({ kind: 'rendered' });
+ });
+ const opened = createSlidesWindow({
createWindow: () => fake.window,
registry: createSlidesDeckRegistry(),
deck: makeDeck('/decks/talk.md', 4300),
+ waitForRenderer: () => rendered,
});
- expect(fake.show).not.toHaveBeenCalled();
fake.fireReadyToShow();
+ expect(fake.show).not.toHaveBeenCalled();
+ reportRendered?.();
+
+ await expect(opened).resolves.toEqual({ shown: true });
expect(fake.show).toHaveBeenCalledTimes(1);
+ expect(fake.close).not.toHaveBeenCalled();
+ });
+
+ test('does not show a shell-only window whose renderer never mounts', async () => {
+ const fake = makeFakeWindow(80_001, { rendererReady: false });
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const deck = makeDeck('/decks/talk.md', 4300);
+ const opened = createSlidesWindow({
+ createWindow: () => fake.window,
+ registry: createSlidesDeckRegistry(),
+ deck,
+ rendererTimeoutMs: 1,
+ });
+
+ expect(fake.show).not.toHaveBeenCalled();
+ fake.fireReadyToShow();
+ await expect(opened).resolves.toEqual({ shown: false, reason: 'renderer-failed' });
+
+ expect(fake.show).not.toHaveBeenCalled();
+ expect(fake.executeJavaScript).toHaveBeenCalledWith(SLIDEV_RENDERED_CHECK);
+ expect(fake.destroy).toHaveBeenCalledTimes(1);
+ expect(deck.signals()).toEqual(['SIGKILL']);
+ expect(JSON.parse(warnSpy.mock.calls[0]?.[0] as string)).toMatchObject({
+ event: 'slides-renderer-timed-out',
+ windowId: 80_001,
+ port: 4300,
+ });
+ warnSpy.mockRestore();
});
test('closing the window gracefully stops the deck: SIGTERM, then SIGKILL when it stays alive', async () => {
const fake = makeFakeWindow(80_001);
const registry = createSlidesDeckRegistry();
- const deck = makeDeck('/decks/talk.md', 4300, { alive: true });
- createSlidesWindow({
+ const deck = makeDeck('/decks/talk.md', 4300, { alive: true, diesOnSigterm: false });
+ await createSlidesWindow({
createWindow: () => fake.window,
registry,
deck,
@@ -252,7 +308,7 @@ describe('createSlidesWindow', () => {
const fake = makeFakeWindow(80_001);
const registry = createSlidesDeckRegistry();
const deck = makeDeck('/decks/talk.md', 4300);
- createSlidesWindow({
+ await createSlidesWindow({
createWindow: () => fake.window,
registry,
deck,
@@ -266,20 +322,22 @@ describe('createSlidesWindow', () => {
expect(registry.get('/decks/talk.md')).toBeUndefined();
});
- test('two decks open independent windows on their own ports', () => {
+ test('two decks open independent windows on their own ports', async () => {
const registry = createSlidesDeckRegistry();
const a = makeFakeWindow(80_001);
const b = makeFakeWindow(80_002);
- createSlidesWindow({
- createWindow: () => a.window,
- registry,
- deck: makeDeck('/decks/a.md', 4300),
- });
- createSlidesWindow({
- createWindow: () => b.window,
- registry,
- deck: makeDeck('/decks/b.md', 4301),
- });
+ await Promise.all([
+ createSlidesWindow({
+ createWindow: () => a.window,
+ registry,
+ deck: makeDeck('/decks/a.md', 4300),
+ }),
+ createSlidesWindow({
+ createWindow: () => b.window,
+ registry,
+ deck: makeDeck('/decks/b.md', 4301),
+ }),
+ ]);
expect(a.window.loadURL).toHaveBeenCalledWith('http://localhost:4300/?embedded=true');
expect(b.window.loadURL).toHaveBeenCalledWith('http://localhost:4301/?embedded=true');
@@ -297,13 +355,12 @@ describe('createSlidesWindow', () => {
const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
const registry = createSlidesDeckRegistry();
- createSlidesWindow({
+ const opened = createSlidesWindow({
createWindow: () => fake.window,
registry,
deck: makeDeck('/decks/talk.md', 4300),
});
- await Promise.resolve();
- await Promise.resolve();
+ await expect(opened).resolves.toEqual({ shown: false, reason: 'load-failed' });
expect(warnSpy).toHaveBeenCalledTimes(1);
const payload = JSON.parse(warnSpy.mock.calls[0]?.[0] as string);
@@ -314,9 +371,105 @@ describe('createSlidesWindow', () => {
message: 'slidev boom',
});
expect(JSON.stringify(payload)).not.toContain('/decks/talk.md');
- expect(fake.close).toHaveBeenCalledTimes(1);
+ expect(fake.destroy).toHaveBeenCalledTimes(1);
expect(registry.get('/decks/talk.md')).toBeUndefined();
warnSpy.mockRestore();
});
+
+ test('a navigation that never settles is bounded and force-reaps the server', async () => {
+ const fake = makeFakeWindow(80_001, { destroyEmitsClosed: false });
+ const deck = makeDeck('/decks/talk.md', 4300);
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ (fake.window as unknown as { loadURL: () => Promise<void> }).loadURL = () =>
+ new Promise(() => {});
+
+ await expect(
+ createSlidesWindow({
+ createWindow: () => fake.window,
+ registry: createSlidesDeckRegistry(),
+ deck,
+ navigationTimeoutMs: 1,
+ }),
+ ).resolves.toEqual({ shown: false, reason: 'load-failed' });
+
+ expect(deck.signals()).toEqual(['SIGKILL']);
+ expect(fake.destroy).toHaveBeenCalledTimes(1);
+ expect(JSON.parse(warnSpy.mock.calls[0]?.[0] as string)).toMatchObject({
+ event: 'slides-load-timed-out',
+ windowId: 80_001,
+ port: 4300,
+ });
+ warnSpy.mockRestore();
+ });
+});
+
+describe('waitForSlidevRenderer', () => {
+ test('keeps polling until Slidev mounts a deck page', async () => {
+ let now = 0;
+ const probes = [false, false, true];
+ const probe = vi.fn(async () => probes.shift());
+
+ await expect(
+ waitForSlidevRenderer({
+ probe,
+ isProcessAlive: () => true,
+ now: () => now,
+ sleep: async (ms) => {
+ now += ms;
+ },
+ timeoutMs: 1_000,
+ pollIntervalMs: 100,
+ }),
+ ).resolves.toEqual({ kind: 'rendered' });
+ expect(probe).toHaveBeenCalledTimes(3);
+ });
+
+ test('fails when the shell stays empty through the renderer deadline', async () => {
+ let now = 0;
+ const probe = vi.fn(async () => false);
+
+ await expect(
+ waitForSlidevRenderer({
+ probe,
+ isProcessAlive: () => true,
+ now: () => now,
+ sleep: async (ms) => {
+ now += ms;
+ },
+ timeoutMs: 200,
+ pollIntervalMs: 100,
+ }),
+ ).resolves.toEqual({ kind: 'timed-out' });
+ expect(probe).toHaveBeenCalledTimes(3);
+ });
+
+ test('fails immediately when Slidev exits before mounting', async () => {
+ const probe = vi.fn(async () => true);
+
+ await expect(
+ waitForSlidevRenderer({
+ probe,
+ isProcessAlive: () => false,
+ now: () => 0,
+ sleep: async () => {},
+ }),
+ ).resolves.toEqual({ kind: 'process-exited' });
+ expect(probe).not.toHaveBeenCalled();
+ });
+
+ test('a probe that never settles is bounded without starting overlapping probes', async () => {
+ const probe = vi.fn(() => new Promise<unknown>(() => {}));
+
+ await expect(
+ waitForSlidevRenderer({
+ probe,
+ isProcessAlive: () => true,
+ now: () => 0,
+ sleep: async () => {},
+ timeoutMs: 1,
+ }),
+ ).resolves.toEqual({ kind: 'timed-out' });
+ expect(probe).toHaveBeenCalledTimes(1);
+ });
});
diff --git a/packages/desktop/src/main/slides-window.ts b/packages/desktop/src/main/slides-window.ts
index 3a7ca187c..b9655d62b 100644
--- a/packages/desktop/src/main/slides-window.ts
+++ b/packages/desktop/src/main/slides-window.ts
@@ -9,6 +9,31 @@ const SLIDES_PARTITION = 'slides';
const SLIDES_WINDOW_TITLE = 'Slidev — OpenKnowledge';
+const SLIDEV_RENDER_STABILITY_MS = 500;
+
+export const SLIDEV_RENDERED_CHECK = `(() => {
+ const readySinceKey = '__okSlidevReadySince';
+ const slide = document.querySelector('#app [data-slidev-no]');
+ const ready =
+ slide !== null &&
+ !slide.matches('.slidev-slide-loading') &&
+ slide.querySelector('.slidev-slide-loading') === null;
+ if (!ready) {
+ delete window[readySinceKey];
+ return false;
+ }
+ const now = performance.now();
+ const readySince = window[readySinceKey];
+ if (typeof readySince !== 'number') {
+ window[readySinceKey] = now;
+ return false;
+ }
+ return now - readySince >= ${SLIDEV_RENDER_STABILITY_MS};
+})()`;
+const NAVIGATION_TIMEOUT_MS = 30_000;
+const RENDERER_TIMEOUT_MS = 30_000;
+const RENDERER_POLL_INTERVAL_MS = 100;
+
export interface SlidesWindowChrome {
readonly titleBarStyle: 'default';
readonly titleBarOverlay: false;
@@ -49,6 +74,9 @@ export interface CreateSlidesWindowDeps {
createWindow(opts: { partition: string; title: string }): SlidesDeckWindow;
registry: Pick<SlidesDeckRegistry, 'register' | 'unregister'>;
deck: Omit<RunningSlidesDeck, 'window'>;
+ waitForRenderer?(window: SlidesDeckWindow): Promise<SlidevRendererOutcome>;
+ navigationTimeoutMs?: number;
+ rendererTimeoutMs?: number;
terminateClock?: {
now(): number;
sleep(ms: number): Promise<void>;
@@ -57,36 +85,135 @@ export interface CreateSlidesWindowDeps {
};
}
-export function createSlidesWindow(deps: CreateSlidesWindowDeps): SlidesDeckWindow {
+export interface WaitForSlidevRendererDeps {
+ probe(): Promise<unknown>;
+ isProcessAlive(): boolean;
+ now(): number;
+ sleep(ms: number): Promise<void>;
+ timeoutMs?: number;
+ pollIntervalMs?: number;
+}
+
+export type SlidevRendererOutcome =
+ | { readonly kind: 'rendered' }
+ | { readonly kind: 'process-exited' }
+ | { readonly kind: 'timed-out'; readonly lastProbeError?: string };
+
+export type SlidesWindowOutcome =
+ | { readonly shown: true }
+ | {
+ readonly shown: false;
+ readonly reason: 'cancelled' | 'exited-early' | 'load-failed' | 'renderer-failed';
+ };
+
+type TimeoutOutcome<T> =
+ | { readonly timedOut: false; readonly value: T }
+ | { readonly timedOut: true };
+
+async function withTimeout<T>(work: Promise<T>, timeoutMs: number): Promise<TimeoutOutcome<T>> {
+ let timer: ReturnType<typeof setTimeout> | undefined;
+ const timeout = new Promise<TimeoutOutcome<T>>((resolve) => {
+ timer = setTimeout(() => resolve({ timedOut: true }), timeoutMs);
+ });
+ try {
+ return await Promise.race([
+ work.then((value): TimeoutOutcome<T> => ({ timedOut: false, value })),
+ timeout,
+ ]);
+ } finally {
+ if (timer !== undefined) clearTimeout(timer);
+ }
+}
+
+export async function waitForSlidevRenderer(
+ deps: WaitForSlidevRendererDeps,
+): Promise<SlidevRendererOutcome> {
+ const deadline = deps.now() + (deps.timeoutMs ?? RENDERER_TIMEOUT_MS);
+ const pollIntervalMs = deps.pollIntervalMs ?? RENDERER_POLL_INTERVAL_MS;
+ let stopped = false;
+ let lastProbeError: string | undefined;
+
+ const poll = async (): Promise<SlidevRendererOutcome> => {
+ while (!stopped && deps.isProcessAlive()) {
+ try {
+ if ((await deps.probe()) === true) return { kind: 'rendered' };
+ } catch (err: unknown) {
+ lastProbeError = err instanceof Error ? `${err.name}: ${err.message}` : String(err);
+ }
+ if (!deps.isProcessAlive()) return { kind: 'process-exited' };
+ if (deps.now() >= deadline) return { kind: 'timed-out', lastProbeError };
+ await deps.sleep(pollIntervalMs);
+ }
+ return deps.isProcessAlive()
+ ? { kind: 'timed-out', lastProbeError }
+ : { kind: 'process-exited' };
+ };
+
+ const bounded = await withTimeout(poll(), deps.timeoutMs ?? RENDERER_TIMEOUT_MS);
+ stopped = true;
+ if (!bounded.timedOut) return bounded.value;
+ return deps.isProcessAlive() ? { kind: 'timed-out', lastProbeError } : { kind: 'process-exited' };
+}
+
+export async function createSlidesWindow(
+ deps: CreateSlidesWindowDeps,
+): Promise<SlidesWindowOutcome> {
const { deck } = deps;
const window = deps.createWindow({ partition: SLIDES_PARTITION, title: SLIDES_WINDOW_TITLE });
containToDeckOrigin(window, deck.port);
- deps.registry.register({ ...deck, window });
-
- window.once('ready-to-show', () => window.show?.());
const clock = deps.terminateClock;
- window.on('closed', () => {
+ let closed = false;
+ let termination: Promise<void> | undefined;
+
+ const gracefullyTerminateDeck = (): Promise<void> => {
+ if (termination !== undefined) return termination;
deps.registry.unregister(deck.docPath);
- void gracefulTerminate({
+ const pending = gracefulTerminate({
sendSignal: (sig) => deck.process.signal(sig),
isAlive: () => deck.process.isAlive(),
now: clock?.now ?? Date.now,
sleep: clock?.sleep ?? ((ms) => new Promise((resolveSleep) => setTimeout(resolveSleep, ms))),
graceMs: clock?.graceMs,
pollMs: clock?.pollMs,
- }).catch((err: unknown) => {
- console.warn(
- JSON.stringify({
- event: 'slides-terminate-failed',
- port: deck.port,
- message: err instanceof Error ? err.message : String(err),
- }),
- );
- });
+ })
+ .then(() => undefined)
+ .catch((err: unknown) => {
+ console.warn(
+ JSON.stringify({
+ event: 'slides-terminate-failed',
+ port: deck.port,
+ message: err instanceof Error ? err.message : String(err),
+ }),
+ );
+ });
+ termination = pending;
+ return pending;
+ };
+
+ const rejectWindow = (): void => {
+ deps.registry.unregister(deck.docPath);
+ if (termination === undefined) {
+ if (deck.process.isAlive()) void deck.process.signal('SIGKILL');
+ termination = Promise.resolve();
+ }
+ if (closed) return;
+ if (window.destroy !== undefined) window.destroy();
+ else window.close?.();
+ };
+
+ window.on('closed', () => {
+ closed = true;
+ void gracefullyTerminateDeck();
});
- window.loadURL(slidesEmbedUrl(deck.port)).catch((err: unknown) => {
+ let navigation: TimeoutOutcome<void>;
+ try {
+ navigation = await withTimeout(
+ window.loadURL(slidesEmbedUrl(deck.port)),
+ deps.navigationTimeoutMs ?? NAVIGATION_TIMEOUT_MS,
+ );
+ } catch (err: unknown) {
console.warn(
JSON.stringify({
event: 'slides-load-failed',
@@ -95,8 +222,90 @@ export function createSlidesWindow(deps: CreateSlidesWindowDeps): SlidesDeckWind
message: err instanceof Error ? err.message : String(err),
}),
);
- window.close?.();
- });
+ rejectWindow();
+ return { shown: false, reason: 'load-failed' };
+ }
- return window;
+ if (navigation.timedOut) {
+ console.warn(
+ JSON.stringify({
+ event: 'slides-load-timed-out',
+ windowId: window.id,
+ port: deck.port,
+ }),
+ );
+ rejectWindow();
+ return { shown: false, reason: 'load-failed' };
+ }
+
+ if (closed) {
+ await gracefullyTerminateDeck();
+ return { shown: false, reason: 'cancelled' };
+ }
+
+ let renderer: SlidevRendererOutcome;
+ try {
+ renderer = await (deps.waitForRenderer?.(window) ??
+ waitForSlidevRenderer({
+ probe: () => window.webContents.executeJavaScript(SLIDEV_RENDERED_CHECK),
+ isProcessAlive: () => deck.process.isAlive(),
+ now: Date.now,
+ sleep: (ms) => new Promise((resolveSleep) => setTimeout(resolveSleep, ms)),
+ timeoutMs: deps.rendererTimeoutMs,
+ }));
+ } catch (err: unknown) {
+ console.warn(
+ JSON.stringify({
+ event: 'slides-renderer-probe-failed',
+ windowId: window.id,
+ port: deck.port,
+ message: err instanceof Error ? err.message : String(err),
+ }),
+ );
+ rejectWindow();
+ return { shown: false, reason: 'renderer-failed' };
+ }
+
+ if (closed) {
+ await gracefullyTerminateDeck();
+ return { shown: false, reason: 'cancelled' };
+ }
+
+ if (renderer.kind !== 'rendered') {
+ console.warn(
+ JSON.stringify({
+ event:
+ renderer.kind === 'process-exited'
+ ? 'slides-renderer-exited'
+ : 'slides-renderer-timed-out',
+ windowId: window.id,
+ port: deck.port,
+ ...(renderer.kind === 'timed-out' && renderer.lastProbeError !== undefined
+ ? { probeError: renderer.lastProbeError }
+ : {}),
+ }),
+ );
+ rejectWindow();
+ return {
+ shown: false,
+ reason: renderer.kind === 'process-exited' ? 'exited-early' : 'renderer-failed',
+ };
+ }
+
+ try {
+ deps.registry.register({ ...deck, window });
+ window.show?.();
+ return { shown: true };
+ } catch (err: unknown) {
+ console.warn(
+ JSON.stringify({
+ event: 'slides-show-failed',
+ windowId: window.id,
+ port: deck.port,
+ message: err instanceof Error ? err.message : String(err),
+ }),
+ );
+ rejectWindow();
+ return { shown: false, reason: 'renderer-failed' };
+ }
}
diff --git a/packages/desktop/src/main/slidev-server.test.ts b/packages/desktop/src/main/slidev-server.test.ts
index cb9ffbd6f..3b3dcea7b 100644
--- a/packages/desktop/src/main/slidev-server.test.ts
+++ b/packages/desktop/src/main/slidev-server.test.ts
@@ -1,17 +1,28 @@
+import type { ChildProcess } from 'node:child_process';
+import { EventEmitter } from 'node:events';
import { createServer as createHttpServer, type Server } from 'node:http';
import { createServer } from 'node:net';
import { afterEach, describe, expect, it, vi } from 'vitest';
import { validateSpawnPath } from './path-containment.ts';
import {
+ adaptSlidevChild,
buildSlidevInvocation,
findFreePort,
probeSlidevReady,
type ReadinessProbe,
type SlidevProcess,
type StartSlidevDeps,
+ signalSlidevChild,
startSlidevServer,
} from './slidev-server.ts';
+function fakeChildProcess(pid: number | undefined): ChildProcess {
+ return Object.assign(new EventEmitter(), {
+ pid,
+ kill: vi.fn(() => true),
+ }) as unknown as ChildProcess;
+}
+
function fakeProcess(opts: { exitImmediately?: boolean } = {}) {
let exitCb: ((code: number | null) => void) | null = null;
let alive = true;
@@ -26,6 +37,7 @@ function fakeProcess(opts: { exitImmediately?: boolean } = {}) {
},
signal: (sig) => {
signals.push(sig);
+ return Promise.resolve();
},
isAlive: () => alive,
pid: 4242,
@@ -201,6 +213,58 @@ describe('startSlidevServer', () => {
});
});
+describe('adaptSlidevChild', () => {
+ it.each([0, null] as const)('marks the process dead and forwards exit code %s', (code) => {
+ const child = fakeChildProcess(4321);
+ const process = adaptSlidevChild(child);
+ const onExit = vi.fn();
+ process.onExit(onExit);
+
+ child.emit('exit', code, code === null ? 'SIGTERM' : null);
+
+ expect(process.isAlive()).toBe(false);
+ expect(onExit).toHaveBeenCalledExactlyOnceWith(code);
+ });
+
+ it('keeps a spawned process alive and tracked after a child error', () => {
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ try {
+ const child = fakeChildProcess(4321);
+ const process = adaptSlidevChild(child);
+ const onExit = vi.fn();
+ process.onExit(onExit);
+
+ child.emit('error', new Error('late pipe error'));
+
+ expect(process.isAlive()).toBe(true);
+ expect(process.spawnError).toBeUndefined();
+ expect(onExit).not.toHaveBeenCalled();
+ } finally {
+ warnSpy.mockRestore();
+ }
+ });
+
+ it('reports an error before a pid is assigned as a spawn failure', () => {
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ try {
+ const child = fakeChildProcess(undefined);
+ const process = adaptSlidevChild(child);
+ const onExit = vi.fn();
+ process.onExit(onExit);
+ const error = Object.assign(new Error('not found'), { code: 'ENOENT' });
+
+ child.emit('error', error);
+ child.emit('exit', null, null);
+
+ expect(process.isAlive()).toBe(false);
+ expect(process.spawnError).toBe(error);
+ expect(onExit).toHaveBeenCalledExactlyOnceWith(null);
+ } finally {
+ warnSpy.mockRestore();
+ }
+ });
+});
+
describe('buildSlidevInvocation', () => {
it('spawns a project-local install directly with the deck path and port', () => {
const invocation = buildSlidevInvocation(
@@ -398,3 +462,96 @@ describe('buildSlidevInvocation — Windows command-line injection', () => {
expect(validateSpawnPath('C:\\proj\\Q1 & Q2.md', 'win32')).toBe(true);
});
});
+
+describe('signalSlidevChild', () => {
+ function fakeChild() {
+ const kill = vi.fn(() => true);
+ return {
+ child: { pid: 4321, kill } as unknown as ChildProcess,
+ kill,
+ };
+ }
+
+ it('terminates the complete cmd.exe process tree on Windows', async () => {
+ const { child, kill } = fakeChild();
+ const treeKills: number[] = [];
+
+ await signalSlidevChild(child, 'SIGKILL', {
+ platform: 'win32',
+ killWindowsTree: async (pid) => {
+ treeKills.push(pid);
+ },
+ });
+
+ expect(treeKills).toEqual([4321]);
+ expect(kill).not.toHaveBeenCalled();
+ });
+
+ it('logs a failed Windows tree kill without retrying a bare PID', async () => {
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ const { child, kill } = fakeChild();
+ const killWindowsTree = vi.fn(() => Promise.reject(new Error('taskkill failed')));
+
+ await signalSlidevChild(child, 'SIGKILL', { platform: 'win32', killWindowsTree });
+
+ expect(warnSpy).toHaveBeenCalledTimes(1);
+ expect(killWindowsTree).toHaveBeenCalledTimes(1);
+ expect(kill).not.toHaveBeenCalled();
+ expect(JSON.parse(warnSpy.mock.calls[0]?.[0] as string)).toMatchObject({
+ event: 'slides-tree-kill-failed',
+ pid: 4321,
+ signal: 'SIGKILL',
+ message: 'taskkill failed',
+ });
+ warnSpy.mockRestore();
+ });
+
+ it('waits for the Windows tree kill to settle', async () => {
+ const { child } = fakeChild();
+ let release: (() => void) | undefined;
+ const killWindowsTree = vi.fn(
+ () =>
+ new Promise<void>((resolve) => {
+ release = resolve;
+ }),
+ );
+ let settled = false;
+
+ const signal = signalSlidevChild(child, 'SIGTERM', {
+ platform: 'win32',
+ killWindowsTree,
+ }).then(() => {
+ settled = true;
+ });
+ await Promise.resolve();
+ expect(settled).toBe(false);
+
+ release?.();
+ await signal;
+ expect(settled).toBe(true);
+ });
+
+ it('bounds a hanging Windows tree kill', async () => {
+ vi.useFakeTimers();
+ const warnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});
+ try {
+ const { child } = fakeChild();
+ const signal = signalSlidevChild(child, 'SIGTERM', {
+ platform: 'win32',
+ killWindowsTree: () => new Promise<void>(() => {}),
+ timeoutMs: 5_000,
+ });
+
+ await vi.advanceTimersByTimeAsync(5_000);
+ await signal;
+
+ expect(JSON.parse(warnSpy.mock.calls[0]?.[0] as string)).toMatchObject({
+ event: 'slides-tree-kill-failed',
+ message: 'taskkill timed out',
+ });
+ } finally {
+ warnSpy.mockRestore();
+ vi.useRealTimers();
+ }
+ });
+});
diff --git a/packages/desktop/src/main/slidev-server.ts b/packages/desktop/src/main/slidev-server.ts
index 001ad3fb6..4b9c9b93f 100644
--- a/packages/desktop/src/main/slidev-server.ts
+++ b/packages/desktop/src/main/slidev-server.ts
@@ -8,7 +8,7 @@ import { projectLocalSlidevBin } from './slidev-resolve.ts';
export interface SlidevProcess {
onExit(cb: (code: number | null) => void): void;
- signal(signal: 'SIGTERM' | 'SIGKILL'): void;
+ signal(signal: 'SIGTERM' | 'SIGKILL'): Promise<void>;
isAlive(): boolean;
readonly pid: number | undefined;
readonly spawnError?: NodeJS.ErrnoException | undefined;
@@ -75,11 +75,11 @@ export async function startSlidevServer(deps: StartSlidevDeps): Promise<StartSli
}
if (probe.reachable) {
if (probe.hasVersionMeta) return { ok: true, port, process: child };
- child.signal('SIGKILL');
+ void child.signal('SIGKILL');
return { ok: false, reason: 'unsupported-server' };
}
if (deps.now() >= deadline) {
- child.signal('SIGKILL');
+ void child.signal('SIGKILL');
return { ok: false, reason: 'timeout' };
}
await deps.delay(pollIntervalMs);
@@ -173,14 +173,78 @@ export function buildSlidevInvocation(
return { mode: 'login-shell', file: config.shell, args: ['-l', '-i', '-c', cmdline] };
}
-function signalSlidevChild(child: ChildProcess, sig: 'SIGTERM' | 'SIGKILL'): void {
+export interface SignalSlidevChildDeps {
+ readonly platform?: NodeJS.Platform;
+ readonly killWindowsTree?: (pid: number) => Promise<void>;
+ readonly timeoutMs?: number;
+}
+
+const WINDOWS_TREE_KILL_TIMEOUT_MS = 5_000;
+
+function taskkillWindowsTree(pid: number, timeoutMs: number): Promise<void> {
+ return new Promise<void>((resolve, reject) => {
+ const killer = spawn('taskkill', ['/pid', String(pid), '/T', '/F'], {
+ stdio: 'ignore',
+ windowsHide: true,
+ });
+ let settled = false;
+ const settle = (error?: Error) => {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timer);
+ if (error === undefined) resolve();
+ else reject(error);
+ };
+ const timer = setTimeout(() => {
+ killer.kill();
+ settle(new Error('taskkill timed out'));
+ }, timeoutMs);
+ timer.unref();
+ killer.once('error', (error) => settle(error));
+ killer.once('exit', (code) => {
+ if (code === 0) settle();
+ else settle(new Error(`taskkill exited with status ${code ?? 'unknown'}`));
+ });
+ });
+}
+
+export function signalSlidevChild(
+ child: ChildProcess,
+ sig: 'SIGTERM' | 'SIGKILL',
+ deps: SignalSlidevChildDeps = {},
+): Promise<void> {
const pid = child.pid;
- if (pid === undefined) return;
- if (process.platform === 'win32') {
- try {
- child.kill();
- } catch {}
- return;
+ if (pid === undefined) return Promise.resolve();
+ if ((deps.platform ?? process.platform) === 'win32') {
+ const timeoutMs = deps.timeoutMs ?? WINDOWS_TREE_KILL_TIMEOUT_MS;
+ const killTree = deps.killWindowsTree ?? ((treePid) => taskkillWindowsTree(treePid, timeoutMs));
+ return new Promise<void>((resolve) => {
+ let settled = false;
+ const finish = (err?: unknown) => {
+ if (settled) return;
+ settled = true;
+ clearTimeout(timer);
+ if (err !== undefined) {
+ console.warn(
+ JSON.stringify({
+ event: 'slides-tree-kill-failed',
+ pid,
+ signal: sig,
+ message: err instanceof Error ? err.message : String(err),
+ }),
+ );
+ }
+ resolve();
+ };
+ const timer = setTimeout(() => finish(new Error('taskkill timed out')), timeoutMs);
+ timer.unref();
+ void Promise.resolve()
+ .then(() => killTree(pid))
+ .then(
+ () => finish(),
+ (err: unknown) => finish(err),
+ );
+ });
}
try {
process.kill(-pid, sig);
@@ -189,6 +253,7 @@ function signalSlidevChild(child: ChildProcess, sig: 'SIGTERM' | 'SIGKILL'): voi
child.kill(sig);
} catch {}
}
+ return Promise.resolve();
}
function isDir(dir: string): boolean {
@@ -210,25 +275,17 @@ function repairedSpawnEnv(): NodeJS.ProcessEnv {
return env;
}
-export function realSpawnSlidev(config: SlidevSpawnConfig, port: number): SlidevProcess {
- const invocation = buildSlidevInvocation(config, port);
- const child = spawn(invocation.file, [...invocation.args], {
- cwd: config.projectRoot,
- env: repairedSpawnEnv(),
- stdio: 'ignore',
- shell: false,
- detached: process.platform !== 'win32',
- windowsHide: true,
- windowsVerbatimArguments: invocation.mode === 'windows-shell',
- });
+export function adaptSlidevChild(child: ChildProcess): SlidevProcess {
let alive = true;
let spawnError: NodeJS.ErrnoException | undefined;
child.on('exit', () => {
alive = false;
});
child.on('error', (err: NodeJS.ErrnoException) => {
- alive = false;
- spawnError = err;
+ if (child.pid === undefined) {
+ alive = false;
+ spawnError = err;
+ }
console.warn(
JSON.stringify({
event: 'slides-child-error',
@@ -239,8 +296,16 @@ export function realSpawnSlidev(config: SlidevSpawnConfig, port: number): Slidev
});
return {
onExit: (cb) => {
- child.on('exit', (code) => cb(code));
- child.on('error', () => cb(null));
+ let reported = false;
+ const report = (code: number | null) => {
+ if (reported) return;
+ reported = true;
+ cb(code);
+ };
+ child.on('exit', (code) => report(code));
+ child.on('error', () => {
+ if (child.pid === undefined) report(null);
+ });
},
get spawnError() {
return spawnError;
@@ -252,3 +317,17 @@ export function realSpawnSlidev(config: SlidevSpawnConfig, port: number): Slidev
},
};
}
+
+export function realSpawnSlidev(config: SlidevSpawnConfig, port: number): SlidevProcess {
+ const invocation = buildSlidevInvocation(config, port);
+ const child = spawn(invocation.file, [...invocation.args], {
+ cwd: config.projectRoot,
+ env: repairedSpawnEnv(),
+ stdio: 'ignore',
+ shell: false,
+ detached: process.platform !== 'win32',
+ windowsHide: true,
+ windowsVerbatimArguments: invocation.mode === 'windows-shell',
+ });
+ return adaptSlidevChild(child);
+}
diff --git a/packages/desktop/src/shared/ipc-channels.ts b/packages/desktop/src/shared/ipc-channels.ts
index ccfe46868..24560155a 100644
--- a/packages/desktop/src/shared/ipc-channels.ts
+++ b/packages/desktop/src/shared/ipc-channels.ts
@@ -49,6 +49,8 @@ import type {
OkSharePayloadFields,
OkSharingSetModeResult,
OkSharingStatusResult,
+ OkSlidesOpenResult,
+ OkSlidesStatusResult,
OkTerminalDockState,
OkTerminalDockStateUpdate,
OkTerminalDockStateWriteResult,
@@ -56,6 +58,8 @@ import type {
OkUpdateChannel,
OkSeedApplyOptions as SeedApplyOptions,
OkSeedPlanOptions as SeedPlanOptions,
+ SlidevOpenFailureReason,
+ SlidevSource,
} from '@inkeep/open-knowledge-core/desktop-bridge';
import type {
FindEnclosingGitRootResult,
@@ -81,23 +85,7 @@ export type { OkSharingSetModeResult, OkSharingStatusResult };
export type OkSharingResult = OkSharingStatusResult | OkSharingSetModeResult;
-export type SlidevSource = 'project-local' | 'global';
-
-export type OkSlidesStatusResult =
- | { readonly kind: 'status'; readonly available: true; readonly source: SlidevSource }
- | { readonly kind: 'status'; readonly available: false };
-
-export type SlidevOpenFailureReason =
- | 'not-available'
- | 'invalid-path'
- | 'spawn-error'
- | 'exited-early'
- | 'timeout'
- | 'unsupported-server';
-
-export type OkSlidesOpenResult =
- | { readonly kind: 'open'; readonly ok: true }
- | { readonly kind: 'open'; readonly ok: false; readonly reason: SlidevOpenFailureReason };
+export type { OkSlidesOpenResult, OkSlidesStatusResult, SlidevOpenFailureReason, SlidevSource };
export interface RecentProject {
path: string;
diff --git a/packages/desktop/tests/smoke/_helpers/platform-gate.ts b/packages/desktop/tests/smoke/_helpers/platform-gate.ts
index bdc38c9a8..1c66b0370 100644
--- a/packages/desktop/tests/smoke/_helpers/platform-gate.ts
+++ b/packages/desktop/tests/smoke/_helpers/platform-gate.ts
@@ -47,6 +47,7 @@ export const SPEC_PLATFORM_GATES = {
'sidebar-pill-lockstep-fade.e2e.ts': ['!DARWIN'],
'skill-scope-roundtrip.e2e.ts': ['!DARWIN'],
'skills-studio.e2e.ts': ['!DARWIN'],
+ 'slidev-render-readiness.e2e.ts': ['!PLATFORM_SUPPORTED'],
'terminal-dock-state.e2e.ts': ['!PTY_PLATFORM_SUPPORTED'],
'terminal-dock.e2e.ts': ['!PTY_PLATFORM_SUPPORTED'],
'terminal-links.e2e.ts': ['!PTY_PLATFORM_SUPPORTED'],
diff --git a/packages/desktop/tests/smoke/slidev-render-readiness.e2e.ts b/packages/desktop/tests/smoke/slidev-render-readiness.e2e.ts
new file mode 100644
index 000000000..ba8f5b4a5
--- /dev/null
+++ b/packages/desktop/tests/smoke/slidev-render-readiness.e2e.ts
@@ -0,0 +1,238 @@
+import { chmodSync, mkdirSync, mkdtempSync, writeFileSync } from 'node:fs';
+import { tmpdir } from 'node:os';
+import { join } from 'node:path';
+import type { ElectronApplication, Page } from '@playwright/test';
+import { _electron as electron } from '@playwright/test';
+import { captureAppProcess, closeAppBounded } from './_helpers/electron-cleanup';
+import { desktopLaunchOptions, resolveDesktopTarget } from './_helpers/launch-desktop';
+import {
+ homeEnv,
+ PLATFORM_SKIP_REASON,
+ PLATFORM_SUPPORTED,
+ SMOKE_ENABLED,
+ userDataDirFor,
+} from './_helpers/platform-gate';
+import { expect, test } from './_helpers/smoke-test';
+
+const TARGET = resolveDesktopTarget();
+
+function fakeSlidevServer(rendered: boolean): string {
+ const shell = rendered
+ ? '<!doctype html><html><head><meta property="slidev:version" content="52.19.0"></head><body><div id="app"><div data-slidev-no="1"><div class="slidev-slide-loading"></div></div></div><script>setTimeout(() => { document.querySelector("[data-slidev-no]").innerHTML = "<div class=\\"slidev-layout\\">Rendered</div>"; }, 600)</script></body></html>'
+ : '<!doctype html><html><head><meta property="slidev:version" content="52.19.0"></head><body><div id="app"><div data-slidev-no="1"></div></div><script>setTimeout(() => { document.querySelector("[data-slidev-no]").innerHTML = "<div class=\\"slidev-slide-loading\\"></div>"; }, 250)</script></body></html>';
+ return `
+const http = require('node:http');
+const args = process.argv.slice(2);
+const port = Number(args[args.indexOf('--port') + 1]);
+const shell = ${JSON.stringify(shell)};
+const server = http.createServer((_req, res) => {
+ res.writeHead(200, { 'content-type': 'text/html' });
+ res.end(shell);
+});
+server.listen(port, 'localhost');
+process.on('SIGTERM', () => server.close(() => process.exit(0)));
+setTimeout(() => process.exit(0), 120_000);
+`;
+}
+
+function seedProject(rendered = false): { tmpHome: string; projectDir: string; deckPath: string } {
+ const tmpHome = mkdtempSync(join(tmpdir(), 'ok-slidev-readiness-home-'));
+ const projectDir = mkdtempSync(join(tmpdir(), 'ok-slidev-readiness-project-'));
+ const deckPath = join(projectDir, 'slides.md');
+ const binDir = join(projectDir, 'node_modules', '.bin');
+ const fakeServerPath = join(projectDir, 'fake-slidev.cjs');
+ const userDataDir = userDataDirFor(tmpHome);
+
+ mkdirSync(join(projectDir, '.ok'), { recursive: true });
+ mkdirSync(binDir, { recursive: true });
+ mkdirSync(userDataDir, { recursive: true });
+ writeFileSync(
+ join(projectDir, '.ok', 'config.yml'),
+ "content:\n dir: '.'\n include: ['**/*.md']\n exclude: []\n",
+ );
+ const serverSource = fakeSlidevServer(rendered);
+ writeFileSync(deckPath, `---\nslides: true\n---\n\n# ${rendered ? 'Rendered' : 'Shell only'}\n`);
+ writeFileSync(fakeServerPath, serverSource);
+ if (process.platform === 'win32') {
+ writeFileSync(join(binDir, 'slidev.cmd'), `@"${process.execPath}" "${fakeServerPath}" %*\r\n`);
+ } else {
+ const binPath = join(binDir, 'slidev');
+ writeFileSync(binPath, `#!/usr/bin/env node\n${serverSource}`);
+ chmodSync(binPath, 0o755);
+ }
+ writeFileSync(
+ join(userDataDir, 'state.json'),
+ JSON.stringify({
+ recentProjects: [
+ {
+ path: projectDir,
+ name: 'Slidev readiness fixture',
+ lastOpenedAt: new Date().toISOString(),
+ },
+ ],
+ lastOpenedProject: projectDir,
+ versionPendingInstall: null,
+ lastSeenVersion: null,
+ lastSuccessfulCheckAt: null,
+ stuckHintShown: false,
+ }),
+ );
+ return { tmpHome, projectDir, deckPath };
+}
+
+async function findEditor(app: ElectronApplication): Promise<Page | undefined> {
+ for (const page of app.windows()) {
+ const mode = await page.evaluate(() => window.okDesktop?.config?.mode).catch(() => undefined);
+ if (mode === 'editor') return page;
+ }
+ return undefined;
+}
+
+async function isReachable(url: string): Promise<boolean> {
+ try {
+ await fetch(url, { signal: AbortSignal.timeout(500) });
+ return true;
+ } catch {
+ return false;
+ }
+}
+
+async function closeElectronAppBounded(app: ElectronApplication): Promise<void> {
+ const process = captureAppProcess(app);
+ await Promise.race([
+ app.close().catch(() => undefined),
+ closeAppBounded(process, { gracefulMs: 5_000 }),
+ ]);
+}
+
+test.describe('Slidev renderer readiness smoke', () => {
+ test.skip(!SMOKE_ENABLED, 'Set OK_DESKTOP_E2E_SMOKE=1 to run Electron smoke tests.');
+ test.skip(!PLATFORM_SUPPORTED, PLATFORM_SKIP_REASON);
+ test.skip(!TARGET.exists, TARGET.missingReason);
+
+ test('a server shell without a mounted deck stays hidden and returns a failure', async ({
+ captureStderrFor,
+ }) => {
+ const { tmpHome, projectDir, deckPath } = seedProject();
+ const app = await electron.launch(
+ desktopLaunchOptions({
+ target: TARGET,
+ args: [`--user-data-dir=${userDataDirFor(tmpHome)}`],
+ env: {
+ ...process.env,
+ ...homeEnv(tmpHome),
+ OK_DESKTOP_E2E_SMOKE: '1',
+ },
+ }),
+ );
+ captureStderrFor(app, { cleanupDirs: [tmpHome, projectDir] });
+ try {
+ await expect
+ .poll(() => findEditor(app), { timeout: 30_000, message: 'editor window did not open' })
+ .not.toBeUndefined();
+ const editor = await findEditor(app);
+ if (editor === undefined) throw new Error('editor window vanished after opening');
+
+ const openResult = editor.evaluate(async (path) => {
+ const slides = window.okDesktop?.slides;
+ if (slides === undefined) throw new Error('slides bridge unavailable');
+ return slides.open(path);
+ }, deckPath);
+
+ await expect
+ .poll(
+ () =>
+ app.evaluate(({ BrowserWindow }) =>
+ BrowserWindow.getAllWindows()
+ .filter((window) => window.webContents.getURL().startsWith('http://localhost:'))
+ .map((window) => ({
+ loading: window.webContents.isLoading(),
+ visible: window.isVisible(),
+ })),
+ ),
+ { timeout: 20_000, message: 'Slidev shell did not finish loading while hidden' },
+ )
+ .toEqual([{ loading: false, visible: false }]);
+ const slidevUrl = await app.evaluate(({ BrowserWindow }) =>
+ BrowserWindow.getAllWindows()
+ .find((window) => window.webContents.getURL().startsWith('http://localhost:'))
+ ?.webContents.getURL(),
+ );
+ if (slidevUrl === undefined) throw new Error('hidden Slidev shell vanished before failure');
+ await expect(openResult).resolves.toEqual({
+ kind: 'open',
+ ok: false,
+ reason: 'renderer-failed',
+ });
+ await expect
+ .poll(
+ () =>
+ app.evaluate(
+ ({ BrowserWindow }) =>
+ BrowserWindow.getAllWindows().filter((window) =>
+ window.webContents.getURL().startsWith('http://localhost:'),
+ ).length,
+ ),
+ { timeout: 5_000, message: 'failed Slidev shell window stayed open' },
+ )
+ .toBe(0);
+ await expect
+ .poll(() => isReachable(slidevUrl), {
+ timeout: 5_000,
+ message: 'failed Slidev process kept its loopback port open',
+ })
+ .toBe(false);
+ } finally {
+ await closeElectronAppBounded(app);
+ }
+ });
+
+ test('a mounted deck becomes visible and reports a successful open', async ({
+ captureStderrFor,
+ }) => {
+ const { tmpHome, projectDir, deckPath } = seedProject(true);
+ const app = await electron.launch(
+ desktopLaunchOptions({
+ target: TARGET,
+ args: [`--user-data-dir=${userDataDirFor(tmpHome)}`],
+ env: {
+ ...process.env,
+ ...homeEnv(tmpHome),
+ OK_DESKTOP_E2E_SMOKE: '1',
+ },
+ }),
+ );
+ captureStderrFor(app, { cleanupDirs: [tmpHome, projectDir] });
+ try {
+ await expect
+ .poll(() => findEditor(app), { timeout: 30_000, message: 'editor window did not open' })
+ .not.toBeUndefined();
+ const editor = await findEditor(app);
+ if (editor === undefined) throw new Error('editor window vanished after opening');
+
+ const openResult = editor.evaluate(async (path) => {
+ const slides = window.okDesktop?.slides;
+ if (slides === undefined) throw new Error('slides bridge unavailable');
+ return slides.open(path);
+ }, deckPath);
+
+ await expect
+ .poll(
+ () =>
+ app.evaluate(({ BrowserWindow }) =>
+ BrowserWindow.getAllWindows()
+ .filter((window) => window.webContents.getURL().startsWith('http://localhost:'))
+ .map((window) => ({
+ loading: window.webContents.isLoading(),
+ visible: window.isVisible(),
+ })),
+ ),
+ { timeout: 20_000, message: 'mounted Slidev deck did not become visible' },
+ )
+ .toEqual([{ loading: false, visible: true }]);
+ await expect(openResult).resolves.toEqual({ kind: 'open', ok: true });
+ } finally {
+ await closeElectronAppBounded(app);
+ }
+ });
+});
diff --git a/packages/server/src/checkpoint-retention-tie.test.ts b/packages/server/src/checkpoint-retention-tie.test.ts
index 8a5d82998..0a43a2773 100644
--- a/packages/server/src/checkpoint-retention-tie.test.ts
+++ b/packages/server/src/checkpoint-retention-tie.test.ts
@@ -1,3 +1,4 @@
+
import { execFileSync } from 'node:child_process';
import { mkdirSync, mkdtempSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
diff --git a/packages/server/src/qa-degradation-matrix.test.ts b/packages/server/src/qa-degradation-matrix.test.ts
index 84e3e5297..00bb6efe7 100644
--- a/packages/server/src/qa-degradation-matrix.test.ts
+++ b/packages/server/src/qa-degradation-matrix.test.ts
@@ -1,3 +1,4 @@
+
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import type * as Y from 'yjs';
import { createBridgeDeriveLossReporter } from './bridge-loss-detector.ts';
diff --git a/packages/server/src/qa-gc-budget-isolation.test.ts b/packages/server/src/qa-gc-budget-isolation.test.ts
index a800ca9f3..b65c4693e 100644
--- a/packages/server/src/qa-gc-budget-isolation.test.ts
+++ b/packages/server/src/qa-gc-budget-isolation.test.ts
@@ -1,3 +1,4 @@
+
import { mkdirSync, mkdtempSync, rmSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join, resolve } from 'node:path';
diff --git a/packages/server/src/qa-watcher-intake-lens.test.ts b/packages/server/src/qa-watcher-intake-lens.test.ts
index 2337e6c3c..4669d1b98 100644
--- a/packages/server/src/qa-watcher-intake-lens.test.ts
+++ b/packages/server/src/qa-watcher-intake-lens.test.ts
@@ -1,3 +1,4 @@
+
import { Hocuspocus } from '@hocuspocus/server';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
import * as Y from 'yjs';