Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Fix WYSIWYG Tabs strip phantom pills from nested components (#2053)

Nick Gomez4aa385da6717
diff --git a/.changeset/tabs-strip-nested-nodeview-pills.md b/.changeset/tabs-strip-nested-nodeview-pills.md
new file mode 100644
index 000000000..58cd80e18
--- /dev/null
+++ b/.changeset/tabs-strip-nested-nodeview-pills.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge-app": patch
+---
+
+Fix the WYSIWYG `<Tabs>` strip showing phantom tab pills when a tab nests other components. A `<Tab>` containing a `<Steps>`, `<Callout>`, image, or nested `<Tabs>` used to add one extra empty pill per nested block — the quickstart's two install tabs rendered as eight pills, with the spurious pills revealing no panel. The strip now counts only the Tabs's own direct tab children, matching the CSS active-panel index space exactly.
diff --git a/packages/app/package.json b/packages/app/package.json
index debdcd957..766c4fdae 100644
--- a/packages/app/package.json
+++ b/packages/app/package.json
@@ -25,7 +25,7 @@
"measure:fuzz": "bash scripts/measure-fuzz.sh",
"measure:stress": "bash scripts/measure-stress.sh",
"perf:compare": "bash scripts/perf-compare.sh",
- "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-compact-folders.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/init-load-byte-stable.e2e.ts tests/stress/single-file-ephemeral.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts",
+ "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-compact-folders.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/init-load-byte-stable.e2e.ts tests/stress/single-file-ephemeral.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts tests/stress/tabs-component-strip.e2e.ts",
"test:e2e:install-browsers": "playwright install chromium webkit firefox",
"test:visual": "playwright test --config playwright.visual.config.ts",
"test:visual:update": "playwright test --config playwright.visual.config.ts --update-snapshots",
diff --git a/packages/app/src/editor/components/Tabs.dom.test.tsx b/packages/app/src/editor/components/Tabs.dom.test.tsx
new file mode 100644
index 000000000..0b5798670
--- /dev/null
+++ b/packages/app/src/editor/components/Tabs.dom.test.tsx
@@ -0,0 +1,106 @@
+import { afterEach, describe, expect, test } from 'bun:test';
+import { cleanup } from '@testing-library/react';
+import { readTabSlots } from './Tabs.tsx';
+
+afterEach(cleanup);
+
+function contentDom(childRenderers: string): string {
+ return `<div class="component-children" data-node-view-content><div data-node-view-content-react>${childRenderers}</div></div>`;
+}
+
+function tabRenderer(label: string, id: string, nestedContentDom = ''): string {
+ return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="tab"><section class="tab-panel" data-tab-label="${label}" data-tab-id="${id}">${nestedContentDom}</section></div></div>`;
+}
+
+function containerRenderer(type: string, childRenderers = ''): string {
+ return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="${type}">${contentDom(childRenderers)}</div></div>`;
+}
+
+function nestedTabsRenderer(innerTabRenderers: string): string {
+ return `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="tabs"><div class="tabs"><div class="tabs-content" data-active-index="0">${contentDom(innerTabRenderers)}</div></div></div></div>`;
+}
+
+function mountOuterTabs(tabRenderers: string): HTMLElement {
+ document.body.innerHTML = `<div class="react-renderer node-jsxComponent"><div class="jsx-component-wrapper" data-component-type="tabs"><div class="tabs"><div class="tabs-content" data-active-index="0">${contentDom(tabRenderers)}</div></div></div></div>`;
+ const el = document.body.querySelector<HTMLElement>('.tabs-content');
+ if (!el) throw new Error('test DOM build failed: no .tabs-content');
+ return el;
+}
+
+describe('readTabSlots — counts only the Tabs own direct Tab children', () => {
+ test('two plain Tabs yield exactly two slots with verbatim labels and ids', () => {
+ const root = mountOuterTabs(tabRenderer('Alpha', 'alpha') + tabRenderer('Bravo', 'bravo'));
+
+ const slots = readTabSlots(root);
+
+ expect(slots).toHaveLength(2);
+ expect(slots.map((s) => s.label)).toEqual(['Alpha', 'Bravo']);
+ expect(slots.map((s) => s.panelId)).toEqual(['alpha', 'bravo']);
+ });
+
+ test('a single nested container inside a Tab does not add a phantom slot', () => {
+ const tab1 = tabRenderer(
+ 'Alpha',
+ 'alpha',
+ contentDom(containerRenderer('callout', '<p>prereq</p>')),
+ );
+ const root = mountOuterTabs(tab1 + tabRenderer('Bravo', 'bravo'));
+
+ const slots = readTabSlots(root);
+
+ expect(slots).toHaveLength(2);
+ expect(slots.map((s) => s.label)).toEqual(['Alpha', 'Bravo']);
+ expect(slots.map((s) => s.panelId)).toEqual(['alpha', 'bravo']);
+ });
+
+ test('the quickstart shape (Tab 1 = Callout + Steps with multiple Steps) yields two slots', () => {
+ const steps = containerRenderer(
+ 'steps',
+ containerRenderer('step', '<h3>Install</h3>') +
+ containerRenderer('step', '<h3>Create</h3>') +
+ containerRenderer('step', '<h3>Initialize</h3>') +
+ containerRenderer('step', '<h3>Open</h3>'),
+ );
+ const tab1 = tabRenderer(
+ 'macOS app',
+ 'macos',
+ contentDom(containerRenderer('callout', '<ul><li>prereq</li></ul>') + steps),
+ );
+ const root = mountOuterTabs(tab1 + tabRenderer('Web app', 'web'));
+
+ const slots = readTabSlots(root);
+
+ expect(slots).toHaveLength(2);
+ expect(slots.map((s) => s.label)).toEqual(['macOS app', 'Web app']);
+ });
+
+ test('a nested Tabs inside a Tab contributes no slots to the outer strip', () => {
+ const innerTabs = nestedTabsRenderer(
+ tabRenderer('Inner one', 'inner-1') + tabRenderer('Inner two', 'inner-2'),
+ );
+ const tab1 = tabRenderer('Outer one', 'outer-1', contentDom(innerTabs));
+ const root = mountOuterTabs(tab1 + tabRenderer('Outer two', 'outer-2'));
+
+ const slots = readTabSlots(root);
+
+ expect(slots).toHaveLength(2);
+ expect(slots.map((s) => s.label)).toEqual(['Outer one', 'Outer two']);
+ expect(slots.map((s) => s.panelId)).toEqual(['outer-1', 'outer-2']);
+ });
+
+ test('a non-Tab block at the top level falls back to a numbered label with null id', () => {
+ const root = mountOuterTabs(
+ tabRenderer('Real', 'real') + containerRenderer('callout', '<p>note</p>'),
+ );
+
+ const slots = readTabSlots(root);
+
+ expect(slots).toHaveLength(2);
+ expect(slots[0]).toMatchObject({ label: 'Real', panelId: 'real' });
+ expect(slots[1]).toMatchObject({ label: 'Tab 2', panelId: null });
+ });
+
+ test('an empty Tabs yields zero slots', () => {
+ expect(readTabSlots(mountOuterTabs(''))).toHaveLength(0);
+ });
+});
diff --git a/packages/app/src/editor/components/Tabs.tsx b/packages/app/src/editor/components/Tabs.tsx
index 746335d1e..a037eb07f 100644
--- a/packages/app/src/editor/components/Tabs.tsx
+++ b/packages/app/src/editor/components/Tabs.tsx
@@ -13,15 +13,12 @@ interface TabSummary {
panelId: string | null;
}
-const TABS_SELECTOR = '[data-component-type="tabs"]';
-const RENDERER_SELECTOR = '[data-node-view-content-react] > .react-renderer';
+const SLOT_SELECTOR =
+ ':scope > .component-children > [data-node-view-content-react] > .react-renderer';
-function readTabSlots(root: HTMLElement): TabSummary[] {
- const ownerTabs = root.closest(TABS_SELECTOR);
- if (!ownerTabs) return [];
- const all = Array.from(root.querySelectorAll<HTMLElement>(RENDERER_SELECTOR));
- const ours = all.filter((r) => r.parentElement?.closest(TABS_SELECTOR) === ownerTabs);
- return ours.map((r, i) => {
+export function readTabSlots(root: HTMLElement): TabSummary[] {
+ const renderers = Array.from(root.querySelectorAll<HTMLElement>(SLOT_SELECTOR));
+ return renderers.map((r, i) => {
const tabEl = r.querySelector<HTMLElement>('[data-tab-label]');
const fromAttr = tabEl?.getAttribute('data-tab-label');
const label = fromAttr?.trim() || `Tab ${i + 1}`;
diff --git a/packages/app/tests/stress/tabs-component-strip.e2e.ts b/packages/app/tests/stress/tabs-component-strip.e2e.ts
new file mode 100644
index 000000000..f081535e8
--- /dev/null
+++ b/packages/app/tests/stress/tabs-component-strip.e2e.ts
@@ -0,0 +1,67 @@
+import { randomUUID } from 'node:crypto';
+import { expect, test, waitForActiveProviderSynced } from './_helpers';
+
+const NESTED_TABS_MD = `<Tabs>
+
+<Tab label="macOS app">
+
+<Callout type="info" title="Prerequisites">
+macOS on Apple Silicon.
+</Callout>
+
+<Steps>
+
+<Step>
+
+### Install the desktop app
+
+</Step>
+
+<Step>
+
+### Create a new project
+
+</Step>
+
+<Step>
+
+### Initialize a knowledge base
+
+</Step>
+
+<Step>
+
+### Open with your AI agent
+
+</Step>
+
+</Steps>
+
+</Tab>
+
+<Tab label="Web app">
+
+Just open the web app in your browser.
+
+</Tab>
+
+</Tabs>`;
+
+test.describe('Tabs component strip', () => {
+ test('renders one strip pill per Tab when a Tab nests Steps and a Callout', async ({
+ page,
+ api,
+ }) => {
+ const docName = `tabs-strip-${randomUUID().slice(0, 8)}`;
+ await api.createPage(`${docName}.md`);
+ await api.replaceDoc(docName, NESTED_TABS_MD);
+ await page.goto(`/#/${docName}`);
+ await waitForActiveProviderSynced(page);
+ await page.waitForSelector('.ProseMirror');
+
+ const pills = page.locator('.tabs-tablist [role="tab"]');
+ await expect(pills).toHaveCount(2, { timeout: 10_000 });
+ await expect(pills.nth(0)).toHaveText('macOS app');
+ await expect(pills.nth(1)).toHaveText('Web app');
+ });
+});