Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Show a result when the desktop updater is inactive (PRD-8954) (#5793)

Andrew Mikofalvy5aba6973f1cc
diff --git a/.changeset/check-for-updates-unavailable.md b/.changeset/check-for-updates-unavailable.md
new file mode 100644
index 000000000..45be9aa39
--- /dev/null
+++ b/.changeset/check-for-updates-unavailable.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge-desktop": patch
+---
+
+Check for updates now tells you when this copy of OpenKnowledge can't update itself, instead of showing nothing.
diff --git a/knip.config.ts b/knip.config.ts
index d3638888e..65f0e8807 100644
--- a/knip.config.ts
+++ b/knip.config.ts
@@ -147,15 +147,11 @@ export default {
'packages/server': {
entry: ['src/**/*.test.ts', 'src/parse-worker.ts'],
project: 'src/**',
- ignoreDependencies: [
- '@types/shell-quote',
- ],
+ ignoreDependencies: ['@types/shell-quote'],
},
'packages/cli': {
entry: ['src/**/*.test.ts', 'scripts/*.ts', 'tests/**/*.ts', 'src/parse-worker.ts'],
- ignoreDependencies: [
- 'yjs',
- ],
+ ignoreDependencies: ['yjs'],
},
'packages/desktop': {
entry: [
diff --git a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
index 4549c74b3..a50b00123 100644
--- a/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
+++ b/packages/app/tests/integration/bug3-source-mode-writeback.test.ts
@@ -1,4 +1,3 @@
-
import { readFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
index 4fc2c11f9..6fcdc23f2 100644
--- a/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
+++ b/packages/app/tests/integration/indented-jsx-byte-sacred.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { normalizeBridge } from '@inkeep/open-knowledge-core';
import { updateYFragment } from '@tiptap/y-tiptap';
diff --git a/packages/app/tests/integration/interior-edit-freshness.test.ts b/packages/app/tests/integration/interior-edit-freshness.test.ts
index 9f2f6feb6..40b5cdfd6 100644
--- a/packages/app/tests/integration/interior-edit-freshness.test.ts
+++ b/packages/app/tests/integration/interior-edit-freshness.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
index 2a085742b..93666af70 100644
--- a/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
+++ b/packages/app/tests/integration/keystroke-cadence-danger-space.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/producer-guard-wiring.test.ts b/packages/app/tests/integration/producer-guard-wiring.test.ts
index 878d5196b..867598d34 100644
--- a/packages/app/tests/integration/producer-guard-wiring.test.ts
+++ b/packages/app/tests/integration/producer-guard-wiring.test.ts
@@ -1,4 +1,3 @@
-
import { setTimeout as wait } from 'node:timers/promises';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
diff --git a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
index 4ada3cf26..0970ac12f 100644
--- a/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
+++ b/packages/app/tests/integration/qa-039-reconciliation-counters-http.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterEach, describe, expect, test } from 'vitest';
import { agentWriteMd, createTestServer, type TestServer } from './test-harness';
diff --git a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
index cbe2b705f..b632185e1 100644
--- a/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
+++ b/packages/app/tests/integration/qa-045-restore-after-gc.test.ts
@@ -1,4 +1,3 @@
-
import { execFileSync } from 'node:child_process';
import { randomUUID } from 'node:crypto';
import { join } from 'node:path';
diff --git a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
index 89bc9b4d9..c530ce4ba 100644
--- a/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
+++ b/packages/app/tests/integration/qa-050-rollback-undo-shipped-path.test.ts
@@ -1,4 +1,3 @@
-
import { randomUUID } from 'node:crypto';
import { afterAll, afterEach, beforeAll, describe, expect, test } from 'vitest';
import type * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-after-rollback.test.ts b/packages/app/tests/integration/undo-after-rollback.test.ts
index a78aeb0e4..d3767adc9 100644
--- a/packages/app/tests/integration/undo-after-rollback.test.ts
+++ b/packages/app/tests/integration/undo-after-rollback.test.ts
@@ -1,4 +1,3 @@
-
import { ROLLBACK_ORIGIN } from '@inkeep/open-knowledge-server';
import { afterAll, beforeAll, describe, expect, test } from 'vitest';
import * as Y from 'yjs';
diff --git a/packages/app/tests/integration/undo-recycle-reset.test.ts b/packages/app/tests/integration/undo-recycle-reset.test.ts
index e7cc69c3f..b076f955c 100644
--- a/packages/app/tests/integration/undo-recycle-reset.test.ts
+++ b/packages/app/tests/integration/undo-recycle-reset.test.ts
@@ -1,4 +1,3 @@
-
import { writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { setTimeout as wait } from 'node:timers/promises';
diff --git a/packages/app/tests/integration/undo-rederive-survival.test.ts b/packages/app/tests/integration/undo-rederive-survival.test.ts
index 9ddcd0730..7935e35f8 100644
--- a/packages/app/tests/integration/undo-rederive-survival.test.ts
+++ b/packages/app/tests/integration/undo-rederive-survival.test.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter } from '@inkeep/open-knowledge-core';
import { Plugin, PluginKey } from '@tiptap/pm/state';
import { updateYFragment, yXmlFragmentToProseMirrorRootNode } from '@tiptap/y-tiptap';
diff --git a/packages/core/src/bridge/compose.ts b/packages/core/src/bridge/compose.ts
index 2a597ec3d..f4cc8a286 100644
--- a/packages/core/src/bridge/compose.ts
+++ b/packages/core/src/bridge/compose.ts
@@ -1,4 +1,3 @@
-
import { prependFrontmatter, stripFrontmatter } from '../extensions/frontmatter.ts';
export type ComposeAdjustment = 'none' | 'body' | 'frontmatter' | 'unresolved';
diff --git a/packages/core/src/bridge/doc-boundary-space.ts b/packages/core/src/bridge/doc-boundary-space.ts
index 01ef76a9f..8fb428b90 100644
--- a/packages/core/src/bridge/doc-boundary-space.ts
+++ b/packages/core/src/bridge/doc-boundary-space.ts
@@ -1,4 +1,3 @@
-
import { FRONTMATTER_RE, stripFrontmatter } from '../extensions/frontmatter.ts';
import { carriedEdgeEmpties, type DocEdgeEmpties } from '../markdown/doc-edge-blank-runs.ts';
diff --git a/packages/core/src/markdown/comment-promoter.ts b/packages/core/src/markdown/comment-promoter.ts
index fb0ba5a7c..fc267cbea 100644
--- a/packages/core/src/markdown/comment-promoter.ts
+++ b/packages/core/src/markdown/comment-promoter.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Paragraph, PhrasingContent, Root, RootContent, Text } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/merged-walker.ts b/packages/core/src/markdown/merged-walker.ts
index fa3cfcd86..bfd7e3109 100644
--- a/packages/core/src/markdown/merged-walker.ts
+++ b/packages/core/src/markdown/merged-walker.ts
@@ -1,4 +1,3 @@
-
import type { Nodes, Parent, Root } from 'mdast';
import { SKIP, visit } from 'unist-util-visit';
import type { VFile } from 'vfile';
diff --git a/packages/core/src/markdown/safe-url.ts b/packages/core/src/markdown/safe-url.ts
index 8be632ba4..4d3250d3a 100644
--- a/packages/core/src/markdown/safe-url.ts
+++ b/packages/core/src/markdown/safe-url.ts
@@ -1,4 +1,3 @@
-
export const SAFE_URL_SCHEMES = ['https', 'http', 'mailto', 'tel', 'ftp', 'sms'] as const;
const SCHEME_ALT = SAFE_URL_SCHEMES.map((s) => `${s}:`).join('|');
diff --git a/packages/desktop/src/main/auto-updater.ts b/packages/desktop/src/main/auto-updater.ts
index 8214bc6d7..68ce86dfa 100644
--- a/packages/desktop/src/main/auto-updater.ts
+++ b/packages/desktop/src/main/auto-updater.ts
@@ -143,6 +143,7 @@ type CheckNowResult =
relaunch: StagedRelaunch;
}
| { kind: 'not-available'; currentVersion: string }
+ | { kind: 'updater-inactive' }
| { kind: 'error'; message: string };
export interface StartAutoUpdaterHandle {
@@ -890,12 +891,16 @@ export function startAutoUpdater(opts: StartAutoUpdaterOpts): StartAutoUpdaterHa
};
const checkPromise = checkForUpdatesFromConfiguredFeed();
void checkPromise
- .then(() => {
- // UPSTREAM([email protected]): checkForUpdates emits its verdict event before its promise resolves, so a check still pending at resolve time produced no verdict; an inactive dev updater resolves the same way.
- if (menuCheck !== null) {
- logger.info('check-now resolved without a verdict');
- settleMenuCheck(null);
+ .then((result) => {
+ // UPSTREAM([email protected]): checkForUpdates emits its verdict event before its promise resolves, and resolves null without any event only when the updater is inactive.
+ if (menuCheck === null) return;
+ if (result === null) {
+ logger.info('check-now resolved null, updater inactive');
+ settleMenuCheck({ kind: 'updater-inactive' });
+ return;
}
+ logger.info('check-now resolved without a verdict');
+ settleMenuCheck(null);
})
.catch((err: unknown) => {
const retrying = revertToGithubFeed(err);
diff --git a/packages/desktop/src/main/index.ts b/packages/desktop/src/main/index.ts
index 1580d3549..061340c44 100644
--- a/packages/desktop/src/main/index.ts
+++ b/packages/desktop/src/main/index.ts
@@ -6912,6 +6912,15 @@ function bootPrimaryInstance(): void {
message: `OpenKnowledge ${result.latestVersion} is available.`,
detail: `It's downloading in the background. You'll be prompted to relaunch when the install is ready.`,
});
+ } else if (result.kind === 'updater-inactive') {
+ void dialog.showMessageBox(target, {
+ type: 'info',
+ buttons: ['OK'],
+ defaultId: 0,
+ title: "Updates Aren't Available",
+ message: "This copy of OpenKnowledge can't update itself.",
+ detail: `Development builds don't receive automatic updates. To update, pull the latest source or download the newest release from ${STUCK_HINT_DOWNLOAD_URL}.`,
+ });
} else {
void dialog.showMessageBox(target, {
type: 'warning',
diff --git a/packages/desktop/tests/integration/auto-updater.test.ts b/packages/desktop/tests/integration/auto-updater.test.ts
index 957b432c2..ac4a7829a 100644
--- a/packages/desktop/tests/integration/auto-updater.test.ts
+++ b/packages/desktop/tests/integration/auto-updater.test.ts
@@ -4123,7 +4123,10 @@ describe('check-now → showCheckNowResult feedback dispatch', () => {
await new Promise((resolve) => setTimeout(resolve, 0));
expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
expect(manualCheckPhases(rig)).toEqual(['started', 'settled']);
- expect(showCheckNowResult).toHaveBeenCalledTimes(outcome === 'resolve' ? 0 : 1);
+ expect(showCheckNowResult).toHaveBeenCalledTimes(1);
+ if (outcome === 'resolve') {
+ expect(showCheckNowResult).toHaveBeenCalledWith({ kind: 'updater-inactive' });
+ }
showCheckNowResult.mockClear();
watchdog.cb();
expect(showCheckNowResult).not.toHaveBeenCalled();
@@ -4164,12 +4167,42 @@ describe('check-now → showCheckNowResult feedback dispatch', () => {
);
});
- test('a verdict-less check settles silently and allows another manual check', async () => {
+ test('an inactive updater shows the updater-inactive result and allows another manual check', async () => {
const showCheckNowResult = vi.fn(() => {});
const { rig } = makeRig({ showCheckNowResult });
await Promise.resolve();
+ let phasesAtDialog: Array<'started' | 'settled'> = [];
+ showCheckNowResult.mockImplementation(() => {
+ phasesAtDialog = manualCheckPhases(rig);
+ });
rig.updater.checkForUpdates = vi.fn(() => Promise.resolve(null));
+ rig.ipc.invoke('ok:update:check-now');
+ const [watchdogHandle, watchdog] = liveTimerFor(rig.clock, MANUAL_CHECK_WATCHDOG_MS);
+ expect(manualCheckPhases(rig)).toEqual(['started']);
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(phasesAtDialog).toEqual(['started', 'settled']);
+ expect(showCheckNowResult).toHaveBeenCalledTimes(1);
+ expect(showCheckNowResult).toHaveBeenCalledWith({ kind: 'updater-inactive' });
+ expect(rig.clock.clearTimeout).toHaveBeenCalledWith(watchdogHandle);
+ watchdog.cb();
+ expect(showCheckNowResult).toHaveBeenCalledTimes(1);
+
+ rig.ipc.invoke('ok:update:check-now');
+ expect(rig.updater.checkForUpdates).toHaveBeenCalledTimes(2);
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled', 'started']);
+ await new Promise((resolve) => setTimeout(resolve, 0));
+ expect(manualCheckPhases(rig)).toEqual(['started', 'settled', 'started', 'settled']);
+ expect(showCheckNowResult).toHaveBeenCalledTimes(2);
+ expect(showCheckNowResult).toHaveBeenLastCalledWith({ kind: 'updater-inactive' });
+ });
+
+ test('a verdict-less check settles silently and allows another manual check', async () => {
+ const showCheckNowResult = vi.fn(() => {});
+ const { rig } = makeRig({ showCheckNowResult });
+ await Promise.resolve();
+ rig.updater.checkForUpdates = vi.fn(() => Promise.resolve(undefined));
+
rig.ipc.invoke('ok:update:check-now');
expect(manualCheckPhases(rig)).toEqual(['started']);
await new Promise((resolve) => setTimeout(resolve, 0));