Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix: sentence casing for the native desktop menu bar (#1880)

Andrew Mikofalvy5e642dd5ad2e
diff --git a/.changeset/native-menu-sentence-casing.md b/.changeset/native-menu-sentence-casing.md
new file mode 100644
index 000000000..5b7f6874f
--- /dev/null
+++ b/.changeset/native-menu-sentence-casing.md
@@ -0,0 +1,7 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Use consistent sentence casing for the native desktop menu bar. File/View menu items like "New File", "New Folder", "Show Hidden Files", "Copy Path", "Expand All", "Create New Project…", "Switch Project…", and "Open Recent" are now sentence case ("New file", "New folder", "Show hidden files", "Copy path", "Expand all", "Create new project…", "Switch project…", "Open recent", etc.), matching the in-app menus. Proper nouns keep their capitalization (Finder, Terminal, AI), and menu titles (File/Edit/View/Window/Help) are unchanged.
+
+The labels shared between the native menu and the in-app menus now come from a single `MENU_LABELS` constant in `@inkeep/open-knowledge-core`, with a test that keeps the renderer's translated strings in sync with it.
diff --git a/packages/app/src/components/CommandPalette.dom.test.tsx b/packages/app/src/components/CommandPalette.dom.test.tsx
index c5def15dc..446b9bac6 100644
--- a/packages/app/src/components/CommandPalette.dom.test.tsx
+++ b/packages/app/src/components/CommandPalette.dom.test.tsx
@@ -270,7 +270,7 @@ describe('CommandPalette DOM behavior', () => {
expect(refreshInstallStatesCalls).toBeGreaterThan(0);
const switchProject = screen.getByTestId('command-palette-switch-project');
- expect(switchProject.textContent).toContain('Switch Project');
+ expect(switchProject.textContent).toContain('Switch project');
expect(switchProject.textContent).toMatch(/⌘⇧N|Ctrl Shift P/);
expect(switchProject.querySelector('svg[aria-hidden="true"]')).not.toBeNull();
expect(document.body.textContent).not.toContain('Start fresh in a new folder');
diff --git a/packages/app/src/components/CommandPalette.tsx b/packages/app/src/components/CommandPalette.tsx
index 02d2c6cee..a977b9885 100644
--- a/packages/app/src/components/CommandPalette.tsx
+++ b/packages/app/src/components/CommandPalette.tsx
@@ -477,7 +477,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
!inExclusiveMode &&
!singleFile &&
bridge !== null &&
- matchesCommandQuery(t`Switch Project`, deferredQuery, ['switch project navigator projects']);
+ matchesCommandQuery(t`Switch project`, deferredQuery, ['switch project navigator projects']);
const showSettings =
!inExclusiveMode &&
!singleFile &&
@@ -1084,7 +1084,7 @@ export function CommandPalette({ bridge = null, open, onOpenChange }: CommandPal
>
<LayoutGrid />
<span>
- <Trans>Switch Project</Trans>
+ <Trans>Switch project</Trans>
</span>
<CommandShortcut>{formatShortcut('switch-project')}</CommandShortcut>
</CommandItem>
diff --git a/packages/app/src/components/ProjectSwitcher.dom.test.tsx b/packages/app/src/components/ProjectSwitcher.dom.test.tsx
index 5326ec21b..3bc35e64f 100644
--- a/packages/app/src/components/ProjectSwitcher.dom.test.tsx
+++ b/packages/app/src/components/ProjectSwitcher.dom.test.tsx
@@ -126,7 +126,7 @@ describe('ProjectSwitcher dropdown behavior', () => {
const menuText = screen.getByTestId('project-switcher-menu').textContent ?? '';
const openFolderIndex = menuText.indexOf('Open folder');
- const switchProjectIndex = menuText.indexOf('Switch Project');
+ const switchProjectIndex = menuText.indexOf('Switch project');
const newProjectIndex = menuText.indexOf('New project');
expect(openFolderIndex).toBeGreaterThan(-1);
expect(switchProjectIndex).toBeGreaterThan(openFolderIndex);
diff --git a/packages/app/src/components/ProjectSwitcher.tsx b/packages/app/src/components/ProjectSwitcher.tsx
index fa6fe14fb..b0f53523c 100644
--- a/packages/app/src/components/ProjectSwitcher.tsx
+++ b/packages/app/src/components/ProjectSwitcher.tsx
@@ -215,7 +215,7 @@ export function ProjectSwitcher({ bridge }: ProjectSwitcherProps) {
data-testid="project-switcher-switch-project"
>
<LayoutGrid aria-hidden="true" className="text-muted-foreground" />
- <Trans>Switch Project</Trans>
+ <Trans>Switch project</Trans>
</DropdownMenuItem>
<DropdownMenuItem onSelect={onCreateProject} data-testid="project-switcher-new-project">
<Plus aria-hidden="true" className="text-muted-foreground" />
diff --git a/packages/app/src/lib/menu-label-parity.test.ts b/packages/app/src/lib/menu-label-parity.test.ts
new file mode 100644
index 000000000..af46182ed
--- /dev/null
+++ b/packages/app/src/lib/menu-label-parity.test.ts
@@ -0,0 +1,31 @@
+import { beforeAll, describe, expect, it } from 'bun:test';
+import { readFileSync } from 'node:fs';
+import { join } from 'node:path';
+import { MENU_LABELS } from '@inkeep/open-knowledge-core';
+
+function collectStrings(node: unknown, out: Set<string>): void {
+ if (typeof node === 'string') {
+ out.add(node);
+ } else if (Array.isArray(node)) {
+ for (const child of node) collectStrings(child, out);
+ } else if (node && typeof node === 'object') {
+ for (const child of Object.values(node)) collectStrings(child, out);
+ }
+}
+
+const catalogStrings = new Set<string>();
+
+beforeAll(() => {
+ const catalog = JSON.parse(
+ readFileSync(join(import.meta.dir, '..', 'locales', 'en', 'messages.json'), 'utf8'),
+ ) as { messages: Record<string, unknown> };
+ collectStrings(catalog.messages, catalogStrings);
+});
+
+describe('shared menu labels stay in sync between the native menu and the renderer', () => {
+ for (const [key, label] of Object.entries(MENU_LABELS)) {
+ it(`renderer catalog contains MENU_LABELS.${key} ("${label}")`, () => {
+ expect(catalogStrings.has(label)).toBe(true);
+ });
+ }
+});
diff --git a/packages/app/src/locales/en/messages.json b/packages/app/src/locales/en/messages.json
index 22ccb2ff7..6a7de287c 100644
--- a/packages/app/src/locales/en/messages.json
+++ b/packages/app/src/locales/en/messages.json
@@ -89,7 +89,6 @@
"2RBzMG": ["Network error — check your connection and try again"],
"2VHJG0": ["Share OK config with my team?"],
"2XQ8Ww": ["Open preview when agent edits"],
- "2Xs2jo": ["Switch Project"],
"2YOwme": ["Restarted — now running v", ["appRuntime"], "."],
"2YZwPB": ["Forward-links response did not match expected shape."],
"2Znqb1": [" (missing)"],
diff --git a/packages/app/src/locales/en/messages.po b/packages/app/src/locales/en/messages.po
index 8b3fe6b05..6905d0248 100644
--- a/packages/app/src/locales/en/messages.po
+++ b/packages/app/src/locales/en/messages.po
@@ -5221,15 +5221,12 @@ msgstr "Suggestion menu navigation"
msgid "Suggestion menu open"
msgstr "Suggestion menu open"
+#: src/components/CommandPalette.tsx
+#: src/components/ProjectSwitcher.tsx
#: src/lib/keyboard-shortcuts.ts
msgid "Switch project"
msgstr "Switch project"
-#: src/components/CommandPalette.tsx
-#: src/components/ProjectSwitcher.tsx
-msgid "Switch Project"
-msgstr "Switch Project"
-
#: src/components/settings/SharingSection.tsx
msgid "Switch to local-only refused"
msgstr "Switch to local-only refused"
diff --git a/packages/app/src/locales/pseudo/messages.json b/packages/app/src/locales/pseudo/messages.json
index b62fe7752..639b95845 100644
--- a/packages/app/src/locales/pseudo/messages.json
+++ b/packages/app/src/locales/pseudo/messages.json
@@ -89,7 +89,6 @@
"2RBzMG": ["Ńēţŵōŕķ ēŕŕōŕ — ćĥēćķ ŷōũŕ ćōńńēćţĩōń àńď ţŕŷ àĝàĩń"],
"2VHJG0": ["Śĥàŕē ŌĶ ćōńƒĩĝ ŵĩţĥ ḿŷ ţēàḿ?"],
"2XQ8Ww": ["Ōƥēń ƥŕēvĩēŵ ŵĥēń àĝēńţ ēďĩţś"],
- "2Xs2jo": ["Śŵĩţćĥ ƤŕōĴēćţ"],
"2YOwme": ["Ŕēśţàŕţēď — ńōŵ ŕũńńĩńĝ v", ["appRuntime"], "."],
"2YZwPB": ["Ƒōŕŵàŕď-ĺĩńķś ŕēśƥōńśē ďĩď ńōţ ḿàţćĥ ēxƥēćţēď śĥàƥē."],
"2Znqb1": [" (ḿĩśśĩńĝ)"],
diff --git a/packages/app/src/locales/pseudo/messages.po b/packages/app/src/locales/pseudo/messages.po
index 1959b1d55..920f2e512 100644
--- a/packages/app/src/locales/pseudo/messages.po
+++ b/packages/app/src/locales/pseudo/messages.po
@@ -5216,13 +5216,10 @@ msgstr ""
msgid "Suggestion menu open"
msgstr ""
-#: src/lib/keyboard-shortcuts.ts
-msgid "Switch project"
-msgstr ""
-
#: src/components/CommandPalette.tsx
#: src/components/ProjectSwitcher.tsx
-msgid "Switch Project"
+#: src/lib/keyboard-shortcuts.ts
+msgid "Switch project"
msgstr ""
#: src/components/settings/SharingSection.tsx
diff --git a/packages/core/src/constants/menu-labels.ts b/packages/core/src/constants/menu-labels.ts
new file mode 100644
index 000000000..08c6f372e
--- /dev/null
+++ b/packages/core/src/constants/menu-labels.ts
@@ -0,0 +1,19 @@
+export const MENU_LABELS = {
+ newFile: 'New file',
+ newFolder: 'New folder',
+ newFromTemplate: 'New from template',
+ duplicate: 'Duplicate',
+ rename: 'Rename',
+ revealInFinder: 'Reveal in Finder',
+ openInTerminal: 'Open in Terminal',
+ openWithAi: 'Open with AI',
+ copyPath: 'Copy path',
+ fullPath: 'Full path',
+ relativePath: 'Relative path',
+ showHiddenFiles: 'Show hidden files',
+ showAllFiles: 'Show all files',
+ expandAll: 'Expand all',
+ collapseAll: 'Collapse all',
+} as const;
+
+export type MenuLabelKey = keyof typeof MENU_LABELS;
diff --git a/packages/core/src/index.ts b/packages/core/src/index.ts
index 1bd2b2373..a27f34e51 100644
--- a/packages/core/src/index.ts
+++ b/packages/core/src/index.ts
@@ -204,6 +204,7 @@ export {
SPAWN_ERROR_LOG,
} from './constants/lifecycle.ts';
export { GREP_MAX_RESULTS, READ_DOCUMENT_HISTORY_DEPTH } from './constants/mcp.ts';
+export { MENU_LABELS, type MenuLabelKey } from './constants/menu-labels.ts';
export { LOCAL_DIR, OK_DIR, OK_PROJECT_MARKER } from './constants/ok-dir.ts';
export {
PREVIEW_EMBED_STARTERS,
diff --git a/packages/desktop/src/main/menu.ts b/packages/desktop/src/main/menu.ts
index c01577091..1a36397e6 100644
--- a/packages/desktop/src/main/menu.ts
+++ b/packages/desktop/src/main/menu.ts
@@ -1,4 +1,4 @@
-import { SHOW_INSTALL_SKILL } from '@inkeep/open-knowledge-core';
+import { MENU_LABELS, SHOW_INSTALL_SKILL } from '@inkeep/open-knowledge-core';
import type { Dialog, MenuItemConstructorOptions } from 'electron';
import type { EntryPoint } from '../shared/entry-point.ts';
import type { EditorActiveTargetSnapshot } from '../shared/ipc-channels.ts';
@@ -8,7 +8,7 @@ import { promptForExistingFolder } from './dialog-helpers.ts';
export interface MenuDeps {
appName: string;
showDevToolsMenu: boolean;
- /** `electron.dialog` — injected so the File → Open Folder click handler
+ /** `electron.dialog` — injected so the File → Open folder click handler
* can call `promptForExistingFolder(dialog)` without importing `dialog`
* at module scope (breaks Bun-test module load; see file header). */
dialog: Dialog;
@@ -63,7 +63,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
const recentSubmenu: MenuItemConstructorOptions[] =
recents.length === 0
- ? [{ label: 'No Recent Projects', enabled: false }]
+ ? [{ label: 'No recent projects', enabled: false }]
: [
...recents.slice(0, 10).map((row) => ({
label: row.name,
@@ -74,7 +74,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
})),
{ type: 'separator' as const },
{
- label: 'Clear Menu',
+ label: 'Clear menu',
click: () => deps.clearRecentProjects(),
},
];
@@ -90,7 +90,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
...(deps.onCheckForUpdates
? ([
{
- label: 'Check for Updates…',
+ label: 'Check for updates…',
click: deps.onCheckForUpdates,
},
{ type: 'separator' as const },
@@ -118,25 +118,25 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
label: 'File',
submenu: [
{
- label: 'New File',
+ label: MENU_LABELS.newFile,
accelerator: 'CmdOrCtrl+N',
enabled: deps.onNewFile !== undefined,
click: () => deps.onNewFile?.(),
},
{
- label: 'New Folder',
+ label: MENU_LABELS.newFolder,
accelerator: 'CmdOrCtrl+Shift+N',
enabled: deps.onNewFolder !== undefined,
click: () => deps.onNewFolder?.(),
},
{
- label: 'New from Template\u2026',
+ label: `${MENU_LABELS.newFromTemplate}\u2026`,
enabled: deps.onNewFromTemplate !== undefined,
click: () => deps.onNewFromTemplate?.(),
},
{ type: 'separator' },
{
- label: 'Duplicate',
+ label: MENU_LABELS.duplicate,
accelerator: 'CmdOrCtrl+D',
enabled:
deps.onDuplicate !== undefined &&
@@ -145,7 +145,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
click: () => deps.onDuplicate?.(),
},
{
- label: 'Rename',
+ label: MENU_LABELS.rename,
enabled:
deps.onRename !== undefined &&
deps.activeTarget !== undefined &&
@@ -163,31 +163,31 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
},
{ type: 'separator' },
{
- label: 'Reveal in Finder',
+ label: MENU_LABELS.revealInFinder,
enabled: deps.onRevealInFinder !== undefined,
click: () => deps.onRevealInFinder?.(),
},
{
- label: 'Open in Terminal',
+ label: MENU_LABELS.openInTerminal,
enabled: deps.onOpenInTerminal !== undefined,
click: () => deps.onOpenInTerminal?.(),
},
{
- label: 'Open with AI',
+ label: MENU_LABELS.openWithAi,
enabled: deps.onSendToAi !== undefined && deps.activeTarget?.kind !== 'asset',
click: () => deps.onSendToAi?.(),
},
{
- label: 'Copy Path',
+ label: MENU_LABELS.copyPath,
enabled: deps.onCopyFullPath !== undefined || deps.onCopyRelativePath !== undefined,
submenu: [
{
- label: 'Full Path',
+ label: MENU_LABELS.fullPath,
enabled: deps.onCopyFullPath !== undefined,
click: () => deps.onCopyFullPath?.(),
},
{
- label: 'Relative Path',
+ label: MENU_LABELS.relativePath,
enabled: deps.onCopyRelativePath !== undefined,
click: () => deps.onCopyRelativePath?.(),
},
@@ -195,7 +195,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
},
{ type: 'separator' },
{
- label: 'Create New Project…',
+ label: 'Create new project…',
enabled: deps.onNewProject !== undefined,
click: () => deps.onNewProject?.(),
},
@@ -205,7 +205,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
click: () => deps.openNavigator(),
},
{
- label: 'Open Folder\u2026',
+ label: 'Open folder\u2026',
accelerator: 'CmdOrCtrl+O',
click: async () => {
const picked = await promptForExistingFolder(deps.dialog);
@@ -216,14 +216,14 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
},
{ type: 'separator' },
{
- label: 'Open Recent',
+ label: 'Open recent',
submenu: recentSubmenu,
},
{ type: 'separator' },
...(deps.reconfigureMcpWiring
? ([
{
- label: 'Configure AI Tool Integrations…',
+ label: 'Configure AI tool integrations…',
click: () => {
void deps.reconfigureMcpWiring?.();
},
@@ -243,7 +243,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
: []),
isMac
? {
- label: 'Close Tab',
+ label: 'Close tab',
accelerator: 'CmdOrCtrl+W',
enabled: deps.onCloseActiveTabOrWindow !== undefined,
click: () => deps.onCloseActiveTabOrWindow?.(),
@@ -264,7 +264,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
{ role: 'selectAll' },
{ type: 'separator' },
{
- label: 'Check Spelling While Typing',
+ label: 'Check spelling while typing',
type: 'checkbox',
checked: deps.spellCheckEnabled ?? true,
enabled: deps.onToggleSpellCheck !== undefined,
@@ -285,20 +285,20 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
] satisfies MenuItemConstructorOptions[])
: []),
{
- label: deps.sidebarVisible === false ? 'Show Sidebar' : 'Hide Sidebar',
+ label: deps.sidebarVisible === false ? 'Show sidebar' : 'Hide sidebar',
accelerator: 'CmdOrCtrl+Alt+S',
enabled: deps.onToggleSidebar !== undefined,
click: () => deps.onToggleSidebar?.(),
},
{
- label: deps.docPanelVisible === false ? 'Show Document Panel' : 'Hide Document Panel',
+ label: deps.docPanelVisible === false ? 'Show document panel' : 'Hide document panel',
accelerator: 'CmdOrCtrl+Alt+B',
enabled: deps.onToggleDocPanel !== undefined,
click: () => deps.onToggleDocPanel?.(),
},
{ type: 'separator' },
{
- label: 'Show Hidden Files',
+ label: MENU_LABELS.showHiddenFiles,
accelerator: 'CmdOrCtrl+Shift+.',
type: 'checkbox',
checked: deps.showHiddenFilesChecked ?? false,
@@ -306,7 +306,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
click: () => deps.onToggleShowHiddenFiles?.(),
},
{
- label: 'Show All Files',
+ label: MENU_LABELS.showAllFiles,
type: 'checkbox',
checked: deps.showAllFilesChecked ?? false,
enabled: deps.onToggleShowAllFiles !== undefined,
@@ -314,13 +314,13 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
},
{ type: 'separator' },
{
- label: 'Expand All',
+ label: MENU_LABELS.expandAll,
visible: deps.canExpandAll ?? true,
enabled: deps.onExpandAll !== undefined,
click: () => deps.onExpandAll?.(),
},
{
- label: 'Collapse All',
+ label: MENU_LABELS.collapseAll,
visible: deps.canCollapseAll ?? true,
enabled: deps.onCollapseAll !== undefined,
click: () => deps.onCollapseAll?.(),
@@ -354,7 +354,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
...(SHOW_INSTALL_SKILL
? ([
{
- label: 'Install for Claude Chat & Cowork (Desktop App)…',
+ label: 'Install for Claude Chat & Cowork (desktop app)…',
click: () => deps.openInstallSkillDialog?.(),
},
{ type: 'separator' as const },
@@ -368,7 +368,7 @@ export function buildMenuTemplate(deps: MenuDeps): MenuItemConstructorOptions[]
? ([
{ type: 'separator' as const },
{
- label: 'Check for Updates…',
+ label: 'Check for updates…',
click: deps.onCheckForUpdates,
},
] satisfies MenuItemConstructorOptions[])
diff --git a/packages/desktop/src/shared/labels.ts b/packages/desktop/src/shared/labels.ts
index f8b3189eb..c02f1d78a 100644
--- a/packages/desktop/src/shared/labels.ts
+++ b/packages/desktop/src/shared/labels.ts
@@ -1 +1 @@
-export const SWITCH_PROJECT_LABEL_WITH_ELLIPSIS = 'Switch Project…' as const;
+export const SWITCH_PROJECT_LABEL_WITH_ELLIPSIS = 'Switch project…' as const;
diff --git a/packages/desktop/tests/main/menu.test.ts b/packages/desktop/tests/main/menu.test.ts
index 45379c4f7..ebf9ccdfd 100644
--- a/packages/desktop/tests/main/menu.test.ts
+++ b/packages/desktop/tests/main/menu.test.ts
@@ -48,33 +48,33 @@ function findByLabel(
}
describe('buildMenuTemplate', () => {
- test('empty recents → "No Recent Projects" disabled placeholder', () => {
+ test('empty recents → "No recent projects" disabled placeholder', () => {
const deps = makeDeps();
const template = buildMenuTemplate(deps);
- const openRecent = findByLabel(template, 'Open Recent');
+ const openRecent = findByLabel(template, 'Open recent');
expect(openRecent).toBeDefined();
const sub = openRecent?.submenu as MenuItemConstructorOptions[] | undefined;
expect(Array.isArray(sub)).toBe(true);
expect(sub?.length).toBe(1);
- expect(sub?.[0]?.label).toBe('No Recent Projects');
+ expect(sub?.[0]?.label).toBe('No recent projects');
expect(sub?.[0]?.enabled).toBe(false);
});
- test('populated recents → N entries + separator + Clear Menu', () => {
+ test('populated recents → N entries + separator + Clear menu', () => {
const recents: RecentRow[] = [
{ path: '/tmp/a', name: 'alpha' },
{ path: '/tmp/b', name: 'beta' },
];
const deps = makeDeps({ getRecentProjects: () => recents });
const template = buildMenuTemplate(deps);
- const openRecent = findByLabel(template, 'Open Recent');
+ const openRecent = findByLabel(template, 'Open recent');
const sub = openRecent?.submenu as MenuItemConstructorOptions[] | undefined;
expect(sub?.length).toBe(4);
expect(sub?.[0]?.label).toBe('alpha');
expect(sub?.[0]?.sublabel).toBe('/tmp/a');
expect(sub?.[1]?.label).toBe('beta');
expect(sub?.[2]?.type).toBe('separator');
- expect(sub?.[3]?.label).toBe('Clear Menu');
+ expect(sub?.[3]?.label).toBe('Clear menu');
});
test('clamps at 10 entries even when more are present', () => {
@@ -84,13 +84,13 @@ describe('buildMenuTemplate', () => {
}));
const deps = makeDeps({ getRecentProjects: () => recents });
const template = buildMenuTemplate(deps);
- const openRecent = findByLabel(template, 'Open Recent');
+ const openRecent = findByLabel(template, 'Open recent');
const sub = openRecent?.submenu as MenuItemConstructorOptions[] | undefined;
expect(sub?.length).toBe(12);
expect(sub?.[0]?.label).toBe('project-0');
expect(sub?.[9]?.label).toBe('project-9');
expect(sub?.[10]?.type).toBe('separator');
- expect(sub?.[11]?.label).toBe('Clear Menu');
+ expect(sub?.[11]?.label).toBe('Clear menu');
});
test('recent-row click dispatches deps.openProject(path, "recents")', () => {
@@ -100,14 +100,14 @@ describe('buildMenuTemplate', () => {
openProject,
});
const template = buildMenuTemplate(deps);
- const openRecent = findByLabel(template, 'Open Recent');
+ const openRecent = findByLabel(template, 'Open recent');
const sub = openRecent?.submenu as MenuItemConstructorOptions[] | undefined;
const row = sub?.[0];
(row?.click as (() => void) | undefined)?.();
expect(openProject).toHaveBeenCalledWith('/tmp/foo', 'recents');
});
- test('File → Open Folder click dispatches deps.openProject(path, "pick-existing")', async () => {
+ test('File → Open folder click dispatches deps.openProject(path, "pick-existing")', async () => {
const openProject = mock(() => Promise.resolve());
const showOpenDialog = mock(() =>
Promise.resolve({ canceled: false, filePaths: ['/tmp/picked'] }),
@@ -117,38 +117,38 @@ describe('buildMenuTemplate', () => {
dialog: { showOpenDialog } as unknown as MenuDeps['dialog'],
});
const template = buildMenuTemplate(deps);
- const openFolder = findByLabel(template, 'Open Folder…');
+ const openFolder = findByLabel(template, 'Open folder…');
expect(openFolder).toBeDefined();
await (openFolder?.click as (() => Promise<void>) | undefined)?.();
expect(openProject).toHaveBeenCalledWith('/tmp/picked', 'pick-existing');
});
- test('Clear Menu click dispatches deps.clearRecentProjects()', () => {
+ test('Clear menu click dispatches deps.clearRecentProjects()', () => {
const clearRecentProjects = mock(() => {});
const deps = makeDeps({
getRecentProjects: () => [{ path: '/tmp/foo', name: 'foo' }],
clearRecentProjects,
});
const template = buildMenuTemplate(deps);
- const clearMenu = findByLabel(template, 'Clear Menu');
+ const clearMenu = findByLabel(template, 'Clear menu');
expect(clearMenu).toBeDefined();
(clearMenu?.click as (() => void) | undefined)?.();
expect(clearRecentProjects).toHaveBeenCalledTimes(1);
});
- test('Switch Project click dispatches deps.openNavigator()', () => {
+ test('Switch project click dispatches deps.openNavigator()', () => {
const openNavigator = mock(() => {});
const deps = makeDeps({ openNavigator });
const template = buildMenuTemplate(deps);
- const switchProject = findByLabel(template, 'Switch Project…');
+ const switchProject = findByLabel(template, 'Switch project…');
expect(switchProject).toBeDefined();
(switchProject?.click as (() => void) | undefined)?.();
expect(openNavigator).toHaveBeenCalledTimes(1);
});
- test('Switch Project rebound to Cmd+Shift+P (FR19 / D39 — Cmd+Shift+N now owns New Folder)', () => {
+ test('Switch project rebound to Cmd+Shift+P (FR19 / D39 — Cmd+Shift+N now owns New folder)', () => {
const template = buildMenuTemplate(makeDeps());
- const switchProject = findByLabel(template, 'Switch Project…');
+ const switchProject = findByLabel(template, 'Switch project…');
expect(switchProject?.accelerator).toBe('CmdOrCtrl+Shift+P');
});
@@ -271,13 +271,13 @@ describe('buildMenuTemplate', () => {
}
});
- describe('Check for Updates… menu item', () => {
+ describe('Check for updates… menu item', () => {
const isMac = process.platform === 'darwin';
test('omitted entirely when onCheckForUpdates dep is undefined (dev mode / boot failure)', () => {
const deps = makeDeps();
const template = buildMenuTemplate(deps);
- expect(findByLabel(template, 'Check for Updates…')).toBeUndefined();
+ expect(findByLabel(template, 'Check for updates…')).toBeUndefined();
});
if (isMac) {
@@ -289,7 +289,7 @@ describe('buildMenuTemplate', () => {
const sub = appMenu?.submenu as MenuItemConstructorOptions[] | undefined;
if (!sub) throw new Error('App submenu missing');
const aboutIdx = sub.findIndex((i) => i.role === 'about');
- const checkIdx = sub.findIndex((i) => i.label === 'Check for Updates…');
+ const checkIdx = sub.findIndex((i) => i.label === 'Check for updates…');
const settingsIdx = sub.findIndex((i) => i.label === 'Settings…');
expect(aboutIdx).toBeGreaterThanOrEqual(0);
expect(checkIdx).toBeGreaterThan(aboutIdx);
@@ -303,7 +303,7 @@ describe('buildMenuTemplate', () => {
const helpMenu = template.find((t) => t.label === 'Help');
const sub = helpMenu?.submenu as MenuItemConstructorOptions[] | undefined;
if (!sub) throw new Error('Help submenu missing');
- expect(sub.find((i) => i.label === 'Check for Updates…')).toBeDefined();
+ expect(sub.find((i) => i.label === 'Check for updates…')).toBeDefined();
});
} else {
test('non-mac: appears in Help menu only (no App menu on these platforms)', () => {
@@ -313,7 +313,7 @@ describe('buildMenuTemplate', () => {
const helpMenu = template.find((t) => t.label === 'Help');
const sub = helpMenu?.submenu as MenuItemConstructorOptions[] | undefined;
if (!sub) throw new Error('Help submenu missing');
- expect(sub.find((i) => i.label === 'Check for Updates…')).toBeDefined();
+ expect(sub.find((i) => i.label === 'Check for updates…')).toBeDefined();
});
}
@@ -321,9 +321,9 @@ describe('buildMenuTemplate', () => {
const onCheckForUpdates = mock(() => {});
const deps = makeDeps({ onCheckForUpdates });
const template = buildMenuTemplate(deps);
- const item = findByLabel(template, 'Check for Updates…');
+ const item = findByLabel(template, 'Check for updates…');
if (!item || typeof item.click !== 'function')
- throw new Error('Check for Updates… click missing');
+ throw new Error('Check for updates… click missing');
(item.click as () => void)();
expect(onCheckForUpdates).toHaveBeenCalledTimes(1);
});
@@ -336,7 +336,7 @@ describe('buildMenuTemplate', () => {
const last = fileSub?.[fileSub.length - 1];
expect(last).toBeDefined();
if (process.platform === 'darwin') {
- expect(last?.label).toBe('Close Tab');
+ expect(last?.label).toBe('Close tab');
expect(last?.accelerator).toBe('CmdOrCtrl+W');
expect(last?.role).toBeUndefined();
} else {
@@ -355,11 +355,11 @@ describe('buildMenuTemplate', () => {
expect(roles).toContain('minimize');
});
- test('Close Tab click dispatches deps.onCloseActiveTabOrWindow on macOS', () => {
+ test('Close tab click dispatches deps.onCloseActiveTabOrWindow on macOS', () => {
if (process.platform !== 'darwin') return;
const onCloseActiveTabOrWindow = mock(() => {});
const template = buildMenuTemplate(makeDeps({ onCloseActiveTabOrWindow }));
- const closeTab = findByLabel(template, 'Close Tab');
+ const closeTab = findByLabel(template, 'Close tab');
expect(closeTab?.enabled).toBe(true);
(closeTab?.click as (() => void) | undefined)?.();
expect(onCloseActiveTabOrWindow).toHaveBeenCalledTimes(1);
@@ -367,16 +367,16 @@ describe('buildMenuTemplate', () => {
});
describe('buildMenuTemplate — File menu state-aware items (US-020 / FR16 + FR19)', () => {
- test('New File renders with Cmd+N accelerator (FR19 — was unbound today)', () => {
+ test('New file renders with Cmd+N accelerator (FR19 — was unbound today)', () => {
const template = buildMenuTemplate(makeDeps({ onNewFile: mock(() => {}) }));
- const newFile = findByLabel(template, 'New File');
+ const newFile = findByLabel(template, 'New file');
expect(newFile).toBeDefined();
expect(newFile?.accelerator).toBe('CmdOrCtrl+N');
});
- test('New Folder renders with Cmd+Shift+N accelerator (FR19 — rebound from Switch Project)', () => {
+ test('New folder renders with Cmd+Shift+N accelerator (FR19 — rebound from Switch project)', () => {
const template = buildMenuTemplate(makeDeps({ onNewFolder: mock(() => {}) }));
- const newFolder = findByLabel(template, 'New Folder');
+ const newFolder = findByLabel(template, 'New folder');
expect(newFolder).toBeDefined();
expect(newFolder?.accelerator).toBe('CmdOrCtrl+Shift+N');
});
@@ -472,45 +472,45 @@ describe('buildMenuTemplate — File menu state-aware items (US-020 / FR16 + FR1
onCopyRelativePath: mock(() => {}),
}),
);
- expect(findByLabel(template, 'New File')?.enabled).toBe(true);
- expect(findByLabel(template, 'New Folder')?.enabled).toBe(true);
- expect(findByLabel(template, 'New from Template…')?.enabled).toBe(true);
+ expect(findByLabel(template, 'New file')?.enabled).toBe(true);
+ expect(findByLabel(template, 'New folder')?.enabled).toBe(true);
+ expect(findByLabel(template, 'New from template…')?.enabled).toBe(true);
expect(findByLabel(template, 'Reveal in Finder')?.enabled).toBe(true);
expect(findByLabel(template, 'Open in Terminal')?.enabled).toBe(true);
expect(findByLabel(template, 'Open with AI')?.enabled).toBe(true);
- expect(findByLabel(template, 'Copy Path')?.enabled).toBe(true);
+ expect(findByLabel(template, 'Copy path')?.enabled).toBe(true);
});
test('Items DISABLED when their handler dep is undefined (unit-test default = unwired)', () => {
const template = buildMenuTemplate(makeDeps());
- expect(findByLabel(template, 'New File')?.enabled).toBe(false);
- expect(findByLabel(template, 'New Folder')?.enabled).toBe(false);
- expect(findByLabel(template, 'New from Template…')?.enabled).toBe(false);
+ expect(findByLabel(template, 'New file')?.enabled).toBe(false);
+ expect(findByLabel(template, 'New folder')?.enabled).toBe(false);
+ expect(findByLabel(template, 'New from template…')?.enabled).toBe(false);
expect(findByLabel(template, 'Duplicate')?.enabled).toBe(false);
expect(findByLabel(template, 'Reveal in Finder')?.enabled).toBe(false);
expect(findByLabel(template, 'Open in Terminal')?.enabled).toBe(false);
expect(findByLabel(template, 'Open with AI')?.enabled).toBe(false);
- expect(findByLabel(template, 'Copy Path')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Copy path')?.enabled).toBe(false);
if (process.platform === 'darwin') {
- expect(findByLabel(template, 'Close Tab')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Close tab')?.enabled).toBe(false);
}
});
- test('Copy Path submenu renders Full Path + Relative Path (FR9 parity with sidebar)', () => {
+ test('Copy path submenu renders Full path + Relative path (FR9 parity with sidebar)', () => {
const template = buildMenuTemplate(
makeDeps({
onCopyFullPath: mock(() => {}),
onCopyRelativePath: mock(() => {}),
}),
);
- const copyPath = findByLabel(template, 'Copy Path');
+ const copyPath = findByLabel(template, 'Copy path');
expect(copyPath).toBeDefined();
const sub = copyPath?.submenu as MenuItemConstructorOptions[] | undefined;
- expect(sub?.[0]?.label).toBe('Full Path');
- expect(sub?.[1]?.label).toBe('Relative Path');
+ expect(sub?.[0]?.label).toBe('Full path');
+ expect(sub?.[1]?.label).toBe('Relative path');
});
- test('click handlers dispatch to deps (e.g. New File → onNewFile)', () => {
+ test('click handlers dispatch to deps (e.g. New file → onNewFile)', () => {
const onNewFile = mock(() => {});
const onDuplicate = mock(() => {});
const onMoveToTrash = mock(() => {});
@@ -524,13 +524,13 @@ describe('buildMenuTemplate — File menu state-aware items (US-020 / FR16 + FR1
onCopyFullPath,
}),
);
- (findByLabel(template, 'New File')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'New file')?.click as (() => void) | undefined)?.();
expect(onNewFile).toHaveBeenCalledTimes(1);
(findByLabel(template, 'Duplicate')?.click as (() => void) | undefined)?.();
expect(onDuplicate).toHaveBeenCalledTimes(1);
(findByLabel(template, 'Move to Trash')?.click as (() => void) | undefined)?.();
expect(onMoveToTrash).toHaveBeenCalledTimes(1);
- (findByLabel(template, 'Full Path')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Full path')?.click as (() => void) | undefined)?.();
expect(onCopyFullPath).toHaveBeenCalledTimes(1);
});
@@ -545,47 +545,47 @@ describe('buildMenuTemplate — File menu state-aware items (US-020 / FR16 + FR1
});
});
-describe('buildMenuTemplate — Create New Project… menu item', () => {
+describe('buildMenuTemplate — Create new project… menu item', () => {
test('renders enabled when onNewProject dep is provided', () => {
const template = buildMenuTemplate(makeDeps({ onNewProject: mock(() => {}) }));
- const item = findByLabel(template, 'Create New Project…');
+ const item = findByLabel(template, 'Create new project…');
expect(item).toBeDefined();
expect(item?.enabled).toBe(true);
});
test('DISABLED when onNewProject dep is omitted (unit-test default = unwired)', () => {
const template = buildMenuTemplate(makeDeps());
- expect(findByLabel(template, 'Create New Project…')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Create new project…')?.enabled).toBe(false);
});
test('enabled regardless of activeTarget scope (project-scope-independent)', () => {
const template = buildMenuTemplate(
makeDeps({ activeTarget: { kind: null }, onNewProject: mock(() => {}) }),
);
- expect(findByLabel(template, 'Create New Project…')?.enabled).toBe(true);
+ expect(findByLabel(template, 'Create new project…')?.enabled).toBe(true);
});
test('click dispatches deps.onNewProject()', () => {
const onNewProject = mock(() => {});
const template = buildMenuTemplate(makeDeps({ onNewProject }));
- const item = findByLabel(template, 'Create New Project…');
+ const item = findByLabel(template, 'Create new project…');
(item?.click as (() => void) | undefined)?.();
expect(onNewProject).toHaveBeenCalledTimes(1);
});
test('click is a safe no-op when onNewProject dep is omitted', () => {
const template = buildMenuTemplate(makeDeps());
- const item = findByLabel(template, 'Create New Project…');
+ const item = findByLabel(template, 'Create new project…');
expect(() => (item?.click as (() => void) | undefined)?.()).not.toThrow();
});
- test('heads the project cluster — appears before Switch Project… in the File submenu', () => {
+ test('heads the project cluster — appears before Switch project… in the File submenu', () => {
const template = buildMenuTemplate(makeDeps({ onNewProject: mock(() => {}) }));
const fileMenu = template.find((t) => t.label === 'File');
const sub = fileMenu?.submenu as MenuItemConstructorOptions[] | undefined;
if (!sub) throw new Error('File submenu missing');
- const createIdx = sub.findIndex((i) => i.label === 'Create New Project…');
- const switchIdx = sub.findIndex((i) => i.label === 'Switch Project…');
+ const createIdx = sub.findIndex((i) => i.label === 'Create new project…');
+ const switchIdx = sub.findIndex((i) => i.label === 'Switch project…');
expect(createIdx).toBeGreaterThanOrEqual(0);
expect(switchIdx).toBeGreaterThan(createIdx);
});
@@ -593,64 +593,64 @@ describe('buildMenuTemplate — Create New Project… menu item', () => {
test('does NOT reintroduce the ambiguous "New Project…" label (regression guard)', () => {
const template = buildMenuTemplate(makeDeps({ onNewProject: mock(() => {}) }));
expect(findByLabel(template, 'New Project…')).toBeUndefined();
- expect(findByLabel(template, 'Create New Project…')).toBeDefined();
+ expect(findByLabel(template, 'Create new project…')).toBeDefined();
});
});
describe('buildMenuTemplate — View menu visibility toggles + tree-scoped expand/collapse', () => {
- test('Show Hidden Files renders as a checkbox-type item', () => {
+ test('Show hidden files renders as a checkbox-type item', () => {
const template = buildMenuTemplate(
makeDeps({ onToggleShowHiddenFiles: mock(() => {}), showHiddenFilesChecked: false }),
);
- const item = findByLabel(template, 'Show Hidden Files');
+ const item = findByLabel(template, 'Show hidden files');
expect(item).toBeDefined();
expect(item?.type).toBe('checkbox');
expect(item?.checked).toBe(false);
expect(item?.enabled).toBe(true);
});
- test('Show Hidden Files binds Cmd+Shift+. accelerator (Finder convention)', () => {
+ test('Show hidden files binds Cmd+Shift+. accelerator (Finder convention)', () => {
const template = buildMenuTemplate(
makeDeps({ onToggleShowHiddenFiles: mock(() => {}), showHiddenFilesChecked: false }),
);
- expect(findByLabel(template, 'Show Hidden Files')?.accelerator).toBe('CmdOrCtrl+Shift+.');
+ expect(findByLabel(template, 'Show hidden files')?.accelerator).toBe('CmdOrCtrl+Shift+.');
});
- test('Show All Files renders as a checkbox-type item with checked state from deps', () => {
+ test('Show all files renders as a checkbox-type item with checked state from deps', () => {
const template = buildMenuTemplate(
makeDeps({ onToggleShowAllFiles: mock(() => {}), showAllFilesChecked: true }),
);
- const item = findByLabel(template, 'Show All Files');
+ const item = findByLabel(template, 'Show all files');
expect(item?.type).toBe('checkbox');
expect(item?.checked).toBe(true);
});
- test('Show Hidden Files DISABLED when toggle handler missing (unit-test default)', () => {
+ test('Show hidden files DISABLED when toggle handler missing (unit-test default)', () => {
const template = buildMenuTemplate(makeDeps());
- expect(findByLabel(template, 'Show Hidden Files')?.enabled).toBe(false);
- expect(findByLabel(template, 'Show All Files')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Show hidden files')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Show all files')?.enabled).toBe(false);
});
- test('Expand All / Collapse All render with visible=true by default', () => {
+ test('Expand all / Collapse all render with visible=true by default', () => {
const template = buildMenuTemplate(
makeDeps({ onExpandAll: mock(() => {}), onCollapseAll: mock(() => {}) }),
);
- expect(findByLabel(template, 'Expand All')?.visible).toBe(true);
- expect(findByLabel(template, 'Collapse All')?.visible).toBe(true);
+ expect(findByLabel(template, 'Expand all')?.visible).toBe(true);
+ expect(findByLabel(template, 'Collapse all')?.visible).toBe(true);
});
- test('Expand All HIDDEN when canExpandAll === false (smart-hide per D15)', () => {
+ test('Expand all HIDDEN when canExpandAll === false (smart-hide per D15)', () => {
const template = buildMenuTemplate(
makeDeps({ onExpandAll: mock(() => {}), canExpandAll: false }),
);
- expect(findByLabel(template, 'Expand All')?.visible).toBe(false);
+ expect(findByLabel(template, 'Expand all')?.visible).toBe(false);
});
- test('Collapse All HIDDEN when canCollapseAll === false', () => {
+ test('Collapse all HIDDEN when canCollapseAll === false', () => {
const template = buildMenuTemplate(
makeDeps({ onCollapseAll: mock(() => {}), canCollapseAll: false }),
);
- expect(findByLabel(template, 'Collapse All')?.visible).toBe(false);
+ expect(findByLabel(template, 'Collapse all')?.visible).toBe(false);
});
test('View menu click handlers dispatch to deps', () => {
@@ -666,13 +666,13 @@ describe('buildMenuTemplate — View menu visibility toggles + tree-scoped expan
onCollapseAll,
}),
);
- (findByLabel(template, 'Show Hidden Files')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Show hidden files')?.click as (() => void) | undefined)?.();
expect(onToggleShowHiddenFiles).toHaveBeenCalledTimes(1);
- (findByLabel(template, 'Show All Files')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Show all files')?.click as (() => void) | undefined)?.();
expect(onToggleShowAllFiles).toHaveBeenCalledTimes(1);
- (findByLabel(template, 'Expand All')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Expand all')?.click as (() => void) | undefined)?.();
expect(onExpandAll).toHaveBeenCalledTimes(1);
- (findByLabel(template, 'Collapse All')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Collapse all')?.click as (() => void) | undefined)?.();
expect(onCollapseAll).toHaveBeenCalledTimes(1);
});
@@ -699,8 +699,8 @@ describe('buildMenuTemplate — View menu visibility toggles + tree-scoped expan
const sub = view?.submenu as MenuItemConstructorOptions[] | undefined;
expect(sub).toBeDefined();
const labels = sub?.map((i) => i.label ?? `[role:${i.role ?? 'sep'}]`) ?? [];
- const showHiddenFilesIdx = labels.indexOf('Show Hidden Files');
- const expandAllIdx = labels.indexOf('Expand All');
+ const showHiddenFilesIdx = labels.indexOf('Show hidden files');
+ const expandAllIdx = labels.indexOf('Expand all');
const resetZoomIdx = labels.indexOf('[role:resetZoom]');
expect(showHiddenFilesIdx).toBeGreaterThan(-1);
expect(resetZoomIdx).toBeGreaterThan(showHiddenFilesIdx);
@@ -708,57 +708,57 @@ describe('buildMenuTemplate — View menu visibility toggles + tree-scoped expan
});
});
-describe('buildMenuTemplate — View → Show/Hide Sidebar', () => {
- test('renders "Hide Sidebar" when sidebarVisible is true (or undefined default)', () => {
+describe('buildMenuTemplate — View → Show/Hide sidebar', () => {
+ test('renders "Hide sidebar" when sidebarVisible is true (or undefined default)', () => {
const expanded = buildMenuTemplate(
makeDeps({ onToggleSidebar: mock(() => {}), sidebarVisible: true }),
);
- expect(findByLabel(expanded, 'Hide Sidebar')).toBeDefined();
- expect(findByLabel(expanded, 'Show Sidebar')).toBeUndefined();
+ expect(findByLabel(expanded, 'Hide sidebar')).toBeDefined();
+ expect(findByLabel(expanded, 'Show sidebar')).toBeUndefined();
const defaultDeps = buildMenuTemplate(makeDeps({ onToggleSidebar: mock(() => {}) }));
- expect(findByLabel(defaultDeps, 'Hide Sidebar')).toBeDefined();
- expect(findByLabel(defaultDeps, 'Show Sidebar')).toBeUndefined();
+ expect(findByLabel(defaultDeps, 'Hide sidebar')).toBeDefined();
+ expect(findByLabel(defaultDeps, 'Show sidebar')).toBeUndefined();
});
- test('renders "Show Sidebar" when sidebarVisible is false', () => {
+ test('renders "Show sidebar" when sidebarVisible is false', () => {
const collapsed = buildMenuTemplate(
makeDeps({ onToggleSidebar: mock(() => {}), sidebarVisible: false }),
);
- expect(findByLabel(collapsed, 'Show Sidebar')).toBeDefined();
- expect(findByLabel(collapsed, 'Hide Sidebar')).toBeUndefined();
+ expect(findByLabel(collapsed, 'Show sidebar')).toBeDefined();
+ expect(findByLabel(collapsed, 'Hide sidebar')).toBeUndefined();
});
test('binds CmdOrCtrl+Alt+S accelerator (⌥⌘S on macOS, Apple HIG sidebar convention)', () => {
const template = buildMenuTemplate(makeDeps({ onToggleSidebar: mock(() => {}) }));
- expect(findByLabel(template, 'Hide Sidebar')?.accelerator).toBe('CmdOrCtrl+Alt+S');
+ expect(findByLabel(template, 'Hide sidebar')?.accelerator).toBe('CmdOrCtrl+Alt+S');
const collapsed = buildMenuTemplate(
makeDeps({ onToggleSidebar: mock(() => {}), sidebarVisible: false }),
);
- expect(findByLabel(collapsed, 'Show Sidebar')?.accelerator).toBe('CmdOrCtrl+Alt+S');
+ expect(findByLabel(collapsed, 'Show sidebar')?.accelerator).toBe('CmdOrCtrl+Alt+S');
});
test('DISABLED when toggle handler missing (unit-test default)', () => {
const template = buildMenuTemplate(makeDeps());
- expect(findByLabel(template, 'Hide Sidebar')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Hide sidebar')?.enabled).toBe(false);
});
test('click dispatches deps.onToggleSidebar', () => {
const onToggleSidebar = mock(() => {});
const template = buildMenuTemplate(makeDeps({ onToggleSidebar, sidebarVisible: true }));
- (findByLabel(template, 'Hide Sidebar')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Hide sidebar')?.click as (() => void) | undefined)?.();
expect(onToggleSidebar).toHaveBeenCalledTimes(1);
const onToggleSidebar2 = mock(() => {});
const collapsed = buildMenuTemplate(
makeDeps({ onToggleSidebar: onToggleSidebar2, sidebarVisible: false }),
);
- (findByLabel(collapsed, 'Show Sidebar')?.click as (() => void) | undefined)?.();
+ (findByLabel(collapsed, 'Show sidebar')?.click as (() => void) | undefined)?.();
expect(onToggleSidebar2).toHaveBeenCalledTimes(1);
});
- test('Show/Hide Sidebar precedes Show Hidden Files in the View submenu', () => {
+ test('Show/Hide sidebar precedes Show hidden files in the View submenu', () => {
const template = buildMenuTemplate(
makeDeps({
onToggleSidebar: mock(() => {}),
@@ -768,63 +768,63 @@ describe('buildMenuTemplate — View → Show/Hide Sidebar', () => {
const view = findByLabel(template, 'View');
const sub = view?.submenu as MenuItemConstructorOptions[] | undefined;
const labels = sub?.map((i) => i.label ?? `[role:${i.role ?? 'sep'}]`) ?? [];
- const sidebarIdx = labels.indexOf('Hide Sidebar');
- const showHiddenFilesIdx = labels.indexOf('Show Hidden Files');
+ const sidebarIdx = labels.indexOf('Hide sidebar');
+ const showHiddenFilesIdx = labels.indexOf('Show hidden files');
expect(sidebarIdx).toBeGreaterThan(-1);
expect(showHiddenFilesIdx).toBeGreaterThan(sidebarIdx);
});
- test('renders "Hide Document Panel" when docPanelVisible is unset or true', () => {
+ test('renders "Hide document panel" when docPanelVisible is unset or true', () => {
const unsetDeps = buildMenuTemplate(makeDeps({ onToggleDocPanel: mock(() => {}) }));
- expect(findByLabel(unsetDeps, 'Hide Document Panel')).toBeDefined();
- expect(findByLabel(unsetDeps, 'Show Document Panel')).toBeUndefined();
+ expect(findByLabel(unsetDeps, 'Hide document panel')).toBeDefined();
+ expect(findByLabel(unsetDeps, 'Show document panel')).toBeUndefined();
const visible = buildMenuTemplate(
makeDeps({ onToggleDocPanel: mock(() => {}), docPanelVisible: true }),
);
- expect(findByLabel(visible, 'Hide Document Panel')).toBeDefined();
- expect(findByLabel(visible, 'Show Document Panel')).toBeUndefined();
+ expect(findByLabel(visible, 'Hide document panel')).toBeDefined();
+ expect(findByLabel(visible, 'Show document panel')).toBeUndefined();
});
- test('renders "Show Document Panel" when docPanelVisible is false', () => {
+ test('renders "Show document panel" when docPanelVisible is false', () => {
const collapsed = buildMenuTemplate(
makeDeps({ onToggleDocPanel: mock(() => {}), docPanelVisible: false }),
);
- expect(findByLabel(collapsed, 'Show Document Panel')).toBeDefined();
- expect(findByLabel(collapsed, 'Hide Document Panel')).toBeUndefined();
+ expect(findByLabel(collapsed, 'Show document panel')).toBeDefined();
+ expect(findByLabel(collapsed, 'Hide document panel')).toBeUndefined();
});
- test('Document Panel binds CmdOrCtrl+Alt+B accelerator (⌥⌘B on macOS, VS Code Secondary Side Bar convention)', () => {
+ test('Document panel binds CmdOrCtrl+Alt+B accelerator (⌥⌘B on macOS, VS Code Secondary Side Bar convention)', () => {
const visible = buildMenuTemplate(makeDeps({ onToggleDocPanel: mock(() => {}) }));
- expect(findByLabel(visible, 'Hide Document Panel')?.accelerator).toBe('CmdOrCtrl+Alt+B');
+ expect(findByLabel(visible, 'Hide document panel')?.accelerator).toBe('CmdOrCtrl+Alt+B');
const collapsed = buildMenuTemplate(
makeDeps({ onToggleDocPanel: mock(() => {}), docPanelVisible: false }),
);
- expect(findByLabel(collapsed, 'Show Document Panel')?.accelerator).toBe('CmdOrCtrl+Alt+B');
+ expect(findByLabel(collapsed, 'Show document panel')?.accelerator).toBe('CmdOrCtrl+Alt+B');
});
- test('Document Panel DISABLED when toggle handler missing (unit-test default)', () => {
+ test('Document panel DISABLED when toggle handler missing (unit-test default)', () => {
const template = buildMenuTemplate(makeDeps());
- expect(findByLabel(template, 'Hide Document Panel')?.enabled).toBe(false);
+ expect(findByLabel(template, 'Hide document panel')?.enabled).toBe(false);
});
- test('Document Panel click dispatches deps.onToggleDocPanel', () => {
+ test('Document panel click dispatches deps.onToggleDocPanel', () => {
const onToggleDocPanel = mock(() => {});
const template = buildMenuTemplate(makeDeps({ onToggleDocPanel, docPanelVisible: true }));
- (findByLabel(template, 'Hide Document Panel')?.click as (() => void) | undefined)?.();
+ (findByLabel(template, 'Hide document panel')?.click as (() => void) | undefined)?.();
expect(onToggleDocPanel).toHaveBeenCalledTimes(1);
const onToggleDocPanel2 = mock(() => {});
const collapsed = buildMenuTemplate(
makeDeps({ onToggleDocPanel: onToggleDocPanel2, docPanelVisible: false }),
);
- (findByLabel(collapsed, 'Show Document Panel')?.click as (() => void) | undefined)?.();
+ (findByLabel(collapsed, 'Show document panel')?.click as (() => void) | undefined)?.();
expect(onToggleDocPanel2).toHaveBeenCalledTimes(1);
});
});
-describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
+describe('buildMenuTemplate — Edit → Check spelling while typing', () => {
function editSubmenu(deps: MenuDeps): MenuItemConstructorOptions[] {
const edit = findByLabel(buildMenuTemplate(deps), 'Edit');
const sub = edit?.submenu as MenuItemConstructorOptions[] | undefined;
@@ -835,7 +835,7 @@ describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
test('renders as a checkbox-type item, checked when spellCheckEnabled is true', () => {
const item = findByLabel(
buildMenuTemplate(makeDeps({ spellCheckEnabled: true, onToggleSpellCheck: mock(() => {}) })),
- 'Check Spelling While Typing',
+ 'Check spelling while typing',
);
expect(item).toBeDefined();
expect(item?.type).toBe('checkbox');
@@ -845,7 +845,7 @@ describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
test('renders unchecked when spellCheckEnabled is false', () => {
const item = findByLabel(
buildMenuTemplate(makeDeps({ spellCheckEnabled: false, onToggleSpellCheck: mock(() => {}) })),
- 'Check Spelling While Typing',
+ 'Check spelling while typing',
);
expect(item?.checked).toBe(false);
});
@@ -853,7 +853,7 @@ describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
test('defaults to checked when spellCheckEnabled dep is omitted (matches the on-by-default persistence default)', () => {
const item = findByLabel(
buildMenuTemplate(makeDeps({ onToggleSpellCheck: mock(() => {}) })),
- 'Check Spelling While Typing',
+ 'Check spelling while typing',
);
expect(item?.checked).toBe(true);
});
@@ -861,13 +861,13 @@ describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
test('ENABLED when onToggleSpellCheck handler is provided', () => {
const item = findByLabel(
buildMenuTemplate(makeDeps({ onToggleSpellCheck: mock(() => {}) })),
- 'Check Spelling While Typing',
+ 'Check spelling while typing',
);
expect(item?.enabled).toBe(true);
});
test('DISABLED when onToggleSpellCheck handler is missing (unit-test default = unwired)', () => {
- const item = findByLabel(buildMenuTemplate(makeDeps()), 'Check Spelling While Typing');
+ const item = findByLabel(buildMenuTemplate(makeDeps()), 'Check spelling while typing');
expect(item?.enabled).toBe(false);
});
@@ -875,21 +875,21 @@ describe('buildMenuTemplate — Edit → Check Spelling While Typing', () => {
const onToggleSpellCheck = mock(() => {});
const item = findByLabel(
buildMenuTemplate(makeDeps({ onToggleSpellCheck })),
- 'Check Spelling While Typing',
+ 'Check spelling while typing',
);
(item?.click as (() => void) | undefined)?.();
expect(onToggleSpellCheck).toHaveBeenCalledTimes(1);
});
test('click is a safe no-op when onToggleSpellCheck dep is omitted', () => {
- const item = findByLabel(buildMenuTemplate(makeDeps()), 'Check Spelling While Typing');
+ const item = findByLabel(buildMenuTemplate(makeDeps()), 'Check spelling while typing');
expect(() => (item?.click as (() => void) | undefined)?.()).not.toThrow();
});
test('lives in the Edit submenu after the Select All role', () => {
const sub = editSubmenu(makeDeps({ onToggleSpellCheck: mock(() => {}) }));
const selectAllIdx = sub.findIndex((i) => i.role === 'selectAll');
- const spellIdx = sub.findIndex((i) => i.label === 'Check Spelling While Typing');
+ const spellIdx = sub.findIndex((i) => i.label === 'Check spelling while typing');
expect(selectAllIdx).toBeGreaterThanOrEqual(0);
expect(spellIdx).toBeGreaterThan(selectAllIdx);
});