Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix: isolate nested Playwright coverage env (#7571)

Nick Gomez5ead79031502
diff --git a/packages/app/src/build/e2e-coverage-contract.ts b/packages/app/src/build/e2e-coverage-contract.ts
index 2c3867d86..53d409929 100644
--- a/packages/app/src/build/e2e-coverage-contract.ts
+++ b/packages/app/src/build/e2e-coverage-contract.ts
@@ -1,6 +1,6 @@
import { isAbsolute, join, relative, sep } from 'node:path';
-const E2E_COVERAGE_DIR_ENV = 'OK_E2E_COVERAGE_DIR';
+export const E2E_COVERAGE_DIR_ENV = 'OK_E2E_COVERAGE_DIR';
export const E2E_COVERAGE_PATH = '/__ok-e2e-coverage';
interface CoverageRange {
diff --git a/packages/app/tests/meta/nested-playwright-env.test.ts b/packages/app/tests/meta/nested-playwright-env.test.ts
index c2b4b0b18..06a835709 100644
--- a/packages/app/tests/meta/nested-playwright-env.test.ts
+++ b/packages/app/tests/meta/nested-playwright-env.test.ts
@@ -1,4 +1,5 @@
import { afterEach, describe, expect, test, vi } from 'vitest';
+import { E2E_COVERAGE_DIR_ENV, e2eCoverageDir } from '../../src/build/e2e-coverage-contract.ts';
import { createNestedPlaywrightEnv } from '../stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts';
const OUTER_RUN_SERVING = {
@@ -7,6 +8,7 @@ const OUTER_RUN_SERVING = {
OK_TEST_E2E_SERVING: 'prebuilt',
OK_TEST_PREBUILT_APP: '/tmp/outer-prebuilt-app',
};
+const OUTER_RUN_COVERAGE_DIR = '/tmp/outer-coverage';
afterEach(() => {
vi.unstubAllEnvs();
@@ -15,10 +17,11 @@ afterEach(() => {
function stubOuterRun(): void {
for (const [name, value] of Object.entries(OUTER_RUN_SERVING)) vi.stubEnv(name, value);
vi.stubEnv('OK_NESTED_ENV_UNRELATED', 'kept');
+ vi.stubEnv(E2E_COVERAGE_DIR_ENV, OUTER_RUN_COVERAGE_DIR);
vi.stubEnv('PLAYWRIGHT_JSON_OUTPUT_FILE', '/tmp/outer-results.json');
}
-describe('a nested Playwright run starts from the outer environment without its server reuse or serving mode', () => {
+describe('a nested Playwright run starts from the outer environment without its server reuse, serving mode or coverage directory', () => {
test('the outer run’s reuse socket, run id, serving mode and prebuilt app are not inherited', () => {
stubOuterRun();
expect(process.env.OK_TEST_E2E_REUSE_SOCKET).toBe(OUTER_RUN_SERVING.OK_TEST_E2E_REUSE_SOCKET);
@@ -28,6 +31,15 @@ describe('a nested Playwright run starts from the outer environment without its
expect(Object.keys(env).filter((name) => name in OUTER_RUN_SERVING)).toEqual([]);
});
+ test('the outer run’s coverage directory is not inherited', () => {
+ stubOuterRun();
+ expect(e2eCoverageDir(process.env)).toBe(OUTER_RUN_COVERAGE_DIR);
+
+ const env = createNestedPlaywrightEnv({ OK_NESTED_ENV_OVERRIDE: 'set' });
+
+ expect(e2eCoverageDir(env)).toBeUndefined();
+ });
+
test('everything else the outer run had is kept, the overrides apply and the JSON report path is dropped', () => {
stubOuterRun();
diff --git a/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts b/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts
index 19b444161..4b9472395 100644
--- a/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts
+++ b/packages/app/tests/stress/_helpers/port-ownership/nested-playwright-env.test-helper.ts
@@ -1,3 +1,4 @@
+import { E2E_COVERAGE_DIR_ENV } from '../../../../src/build/e2e-coverage-contract.ts';
import { E2E_SERVING_ENV, PREBUILT_APP_ENV } from '../prebuilt/prebuilt-serving.ts';
import { REUSE_RUN_ENV, REUSE_SOCKET_ENV } from '../reuse/lease-protocol.ts';
@@ -6,6 +7,7 @@ const OUTER_RUN_SERVER_ENV = [
REUSE_RUN_ENV,
E2E_SERVING_ENV,
PREBUILT_APP_ENV,
+ E2E_COVERAGE_DIR_ENV,
] as const;
export function createNestedPlaywrightEnv(overrides: NodeJS.ProcessEnv): NodeJS.ProcessEnv {