Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Wait for the active editor before placing link carets (#5595)

Nick Gomez63d4f7dcfb58
diff --git a/packages/app/tests/stress/external-link-cue.e2e.ts b/packages/app/tests/stress/external-link-cue.e2e.ts
index 45b117448..3acb5edd5 100644
--- a/packages/app/tests/stress/external-link-cue.e2e.ts
+++ b/packages/app/tests/stress/external-link-cue.e2e.ts
@@ -1,4 +1,5 @@
import { randomUUID } from 'node:crypto';
+import type { Page } from '@playwright/test';
import {
expect,
externalLinkCueSnapshot,
@@ -8,6 +9,47 @@ import {
waitForActiveProviderSynced,
} from './_helpers';
+interface DeferredEditorMountWindow {
+ __externalLinkEditorRead?: 'getter-missing' | 'pending' | 'empty' | 'mounted';
+}
+
+async function deferEditorMountUntilRead(page: Page): Promise<void> {
+ await page.addInitScript(() => {
+ const probe = window as typeof window & DeferredEditorMountWindow;
+ const yieldToBrowser = scheduler.yield.bind(scheduler);
+ scheduler.yield = () => {
+ scheduler.yield = yieldToBrowser;
+ const descriptor = Object.getOwnPropertyDescriptor(window, '__activeEditor');
+ const readEditor = descriptor?.get;
+ if (!descriptor || !readEditor) {
+ probe.__externalLinkEditorRead = 'getter-missing';
+ return yieldToBrowser();
+ }
+ const gate = Promise.withResolvers<void>();
+ probe.__externalLinkEditorRead = 'pending';
+ Object.defineProperty(window, '__activeEditor', {
+ ...descriptor,
+ get() {
+ const editor = readEditor.call(window);
+ probe.__externalLinkEditorRead = editor ? 'mounted' : 'empty';
+ Object.defineProperty(window, '__activeEditor', descriptor);
+ gate.resolve();
+ return editor;
+ },
+ });
+ return gate.promise.then(yieldToBrowser);
+ };
+ });
+}
+
+function firstEditorRead(
+ page: Page,
+): Promise<DeferredEditorMountWindow['__externalLinkEditorRead']> {
+ return page.evaluate(
+ () => (window as typeof window & DeferredEditorMountWindow).__externalLinkEditorRead,
+ );
+}
+
test('a remote caret inside an external link does not duplicate the external-link cue', async ({
page,
api,
@@ -22,13 +64,29 @@ test('a remote caret inside an external link does not duplicate the external-lin
]);
const editorTab = await page.context().newPage();
+ await deferEditorMountUntilRead(editorTab);
await Promise.all([page.goto(`/#/${docName}`), editorTab.goto(`/#/${docName}`)]);
await Promise.all([waitForActiveProviderSynced(page), waitForActiveProviderSynced(editorTab)]);
await expect(
page.locator('.ProseMirror [data-link] [data-resolution-state="external"]'),
).toHaveText('Open Knowledge Burn Down');
+ await expect
+ .poll(
+ () => firstEditorRead(editorTab),
+ "mount gate armed at the editor tab's first scheduler.yield",
+ )
+ .not.toBeUndefined();
+ expect(
+ await firstEditorRead(editorTab),
+ 'active editor getter existed when the mount gate armed',
+ ).toBe('pending');
+ await expect.poll(() => editorTab.evaluate(() => Boolean(window.__activeEditor))).toBe(true);
await placeCaretAtEndOfText(editorTab, 'Open Kno');
+ expect(
+ await firstEditorRead(editorTab),
+ 'first active editor read came while the mount gate held the mount',
+ ).toBe('empty');
await expect(page.locator('.ProseMirror [data-link] .collaboration-cursor__caret')).toHaveCount(
1,