Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Exercise real tooltip primitives in DOM tests (#2949)

Dimitri POSTOLOV69c4e2784ae8
diff --git a/.changeset/test-real-tooltips.md b/.changeset/test-real-tooltips.md
new file mode 100644
index 000000000..31e09288a
--- /dev/null
+++ b/.changeset/test-real-tooltips.md
@@ -0,0 +1,5 @@
+---
+'@inkeep/open-knowledge': patch
+---
+
+Harden tooltip coverage by exercising the real tooltip primitives in component tests and preventing mocks that hide provider or event-composition regressions.
diff --git a/oxlint.config.ts b/oxlint.config.ts
index e66dcca8e..82f506fee 100644
--- a/oxlint.config.ts
+++ b/oxlint.config.ts
@@ -16,6 +16,12 @@ const restrictedSyntax = [
message:
"Do not use `typeof window !== 'undefined'` inside useLayoutEffect; useLayoutEffect already runs client-side.",
},
+ {
+ selector:
+ "CallExpression[callee.object.name='vi'][callee.property.name='doMock'] Literal[value='@/components/ui/tooltip'], CallExpression[callee.object.name='vi'][callee.property.name='mock'] Literal[value='@/components/ui/tooltip']",
+ message:
+ 'Do not mock tooltip primitives. Import TooltipProvider and wrap the rendered component instead.',
+ },
];
// Test files execute as ES modules, where a CommonJS `require()` is not
diff --git a/packages/app/src/components/EditorTabs.dom.test.tsx b/packages/app/src/components/EditorTabs.dom.test.tsx
index 6b2c195dd..1611c7d2c 100644
--- a/packages/app/src/components/EditorTabs.dom.test.tsx
+++ b/packages/app/src/components/EditorTabs.dom.test.tsx
@@ -2,6 +2,7 @@ import { act, cleanup, fireEvent, render, screen, waitFor, within } from '@testi
import { isMacOS } from '@tiptap/core';
import type { ReactNode } from 'react';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { assetTabId, folderTabId } from '@/editor/editor-tabs';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
import {
@@ -170,12 +171,6 @@ vi.doMock('@/components/ui/context-menu', () => ({
ContextMenuTrigger: ({ children }: { children?: ReactNode }) => <>{children}</>,
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: ({ children }: { children?: ReactNode }) => <>{children}</>,
- TooltipContent: ({ children }: { children?: ReactNode }) => <div role="tooltip">{children}</div>,
- TooltipTrigger: ({ children }: { children?: ReactNode }) => <>{children}</>,
-}));
-
vi.doMock('@/editor/DocumentContext', () => ({
useDocumentContext: () => ({
activeDocName,
@@ -280,7 +275,11 @@ function resetState() {
async function renderEditorTabs() {
const { EditorTabs } = await import('./EditorTabs');
- return render(<EditorTabs />);
+ return render(
+ <TooltipProvider>
+ <EditorTabs />
+ </TooltipProvider>,
+ );
}
function latestDndContext() {
diff --git a/packages/app/src/components/FileSidebar.dom.test.tsx b/packages/app/src/components/FileSidebar.dom.test.tsx
index 57cccc2a9..23f9b84bb 100644
--- a/packages/app/src/components/FileSidebar.dom.test.tsx
+++ b/packages/app/src/components/FileSidebar.dom.test.tsx
@@ -1,6 +1,7 @@
import { act, cleanup, fireEvent, render, screen, waitFor, within } from '@testing-library/react';
-import { type ReactNode, useEffect } from 'react';
+import { type MouseEventHandler, type ReactNode, useEffect } from 'react';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
import {
expectVisualClassTokens,
@@ -36,7 +37,7 @@ function Button({
children?: ReactNode;
asChild?: boolean;
onCheckedChange?: unknown;
- onClick?: () => void;
+ onClick?: MouseEventHandler<HTMLButtonElement>;
onSelect?: () => void;
size?: unknown;
variant?: unknown;
@@ -45,8 +46,8 @@ function Button({
return (
<button
type="button"
- onClick={() => {
- onClick?.();
+ onClick={(event) => {
+ onClick?.(event);
onSelect?.();
}}
{...props}
@@ -355,12 +356,6 @@ vi.doMock('@/components/ui/sidebar', () => ({
useSidebar: () => ({ state: sidebarState }),
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: PassThrough,
- TooltipContent: ({ children }: { children?: ReactNode }) => <div role="tooltip">{children}</div>,
- TooltipTrigger: PassThrough,
-}));
-
vi.doMock('@/editor/DocumentContext', () => ({
useDocumentContext: () => ({
activeDocName,
@@ -425,7 +420,7 @@ vi.doMock('sonner', () => ({
async function renderSidebar() {
const { FileSidebar } = await import('./FileSidebar');
- return render(<FileSidebar onOpenSearch={onOpenSearch} />);
+ return render(<FileSidebar onOpenSearch={onOpenSearch} />, { wrapper: TooltipProvider });
}
describe('FileSidebar runtime behavior', () => {
diff --git a/packages/app/src/components/FileSidebar.menu-action.dom.test.tsx b/packages/app/src/components/FileSidebar.menu-action.dom.test.tsx
index e9ce3de8a..771b05f33 100644
--- a/packages/app/src/components/FileSidebar.menu-action.dom.test.tsx
+++ b/packages/app/src/components/FileSidebar.menu-action.dom.test.tsx
@@ -1,6 +1,7 @@
import { cleanup, render, waitFor } from '@testing-library/react';
import { type ReactNode, useEffect } from 'react';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import type { ResolvedNavigationTarget } from './navigation-targets';
type MenuAction =
@@ -175,12 +176,6 @@ vi.doMock('@/components/ui/dropdown-menu', () => ({
DropdownMenuTrigger: PassThrough,
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: PassThrough,
- TooltipContent: ElementPassThrough,
- TooltipTrigger: PassThrough,
-}));
-
vi.doMock('@/components/handoff/OpenInAgentEmptySpaceSubmenu', () => ({
OpenInAgentEmptySpaceSubmenu: () => null,
}));
@@ -268,6 +263,10 @@ const {
subscribeToFileTreeMenuActionRename,
} = await import('@/lib/file-tree-menu-action-events');
+function renderSidebar() {
+ return render(<FileSidebar onOpenSearch={() => {}} />, { wrapper: TooltipProvider });
+}
+
describe('FileSidebar menu-action runtime routing', () => {
beforeEach(() => {
menuActionCallback = null;
@@ -327,7 +326,7 @@ describe('FileSidebar menu-action runtime routing', () => {
});
try {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('duplicate' as MenuAction);
@@ -339,7 +338,7 @@ describe('FileSidebar menu-action runtime routing', () => {
});
test('toggle-sidebar menu action invokes useSidebar().toggleSidebar()', async () => {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('toggle-sidebar' as MenuAction);
@@ -348,7 +347,7 @@ describe('FileSidebar menu-action runtime routing', () => {
});
test('create and tree-state actions route through the FileTree handle', async () => {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('new-doc' as MenuAction);
@@ -371,7 +370,7 @@ describe('FileSidebar menu-action runtime routing', () => {
const unsubscribeDelete = subscribeToFileTreeMenuActionDelete((target) => deleted.push(target));
try {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('rename' as MenuAction);
@@ -401,7 +400,7 @@ describe('FileSidebar menu-action runtime routing', () => {
const unsubscribeDelete = subscribeToFileTreeMenuActionDelete((target) => deleted.push(target));
try {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('rename' as MenuAction);
@@ -441,7 +440,7 @@ describe('FileSidebar menu-action runtime routing', () => {
const unsubscribeDelete = subscribeToFileTreeMenuActionDelete((target) => deleted.push(target));
try {
- const rendered = render(<FileSidebar onOpenSearch={() => {}} />);
+ const rendered = renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('rename' as MenuAction);
@@ -470,7 +469,7 @@ describe('FileSidebar menu-action runtime routing', () => {
});
test('shell, clipboard, handoff, and visibility-toggle actions use runtime dependencies', async () => {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
menuActionCallback?.('reveal-in-finder' as MenuAction);
@@ -535,7 +534,7 @@ describe('FileSidebar menu-action runtime routing', () => {
{ action: 'toggle-show-skills-section', key: 'showSkillsSection', defaultValue: true },
] as const;
- const { rerender } = render(<FileSidebar onOpenSearch={() => {}} />);
+ const { rerender } = renderSidebar();
await waitFor(() => expect(menuActionCallback).not.toBeNull());
for (const { action, key, defaultValue } of toggleRoundTrips) {
@@ -561,7 +560,7 @@ describe('FileSidebar menu-action runtime routing', () => {
});
test('pushes View menu state to the desktop bridge with merged visibility and tree gates', async () => {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
await waitFor(() =>
expect(notifyViewMenuStateChangedMock).toHaveBeenCalledWith(
diff --git a/packages/app/src/components/FileSidebar.share.dom.test.tsx b/packages/app/src/components/FileSidebar.share.dom.test.tsx
index e36be892c..dbb1f2519 100644
--- a/packages/app/src/components/FileSidebar.share.dom.test.tsx
+++ b/packages/app/src/components/FileSidebar.share.dom.test.tsx
@@ -2,6 +2,7 @@ import { cleanup, render, screen } from '@testing-library/react';
import userEvent from '@testing-library/user-event';
import type { ReactNode } from 'react';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
// Controls the mocked git-sync hook's hasRemote signal per test.
let hasRemote = true;
@@ -157,12 +158,6 @@ vi.doMock('@/components/ui/dropdown-menu', () => ({
DropdownMenuTrigger: PassThrough,
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: PassThrough,
- TooltipContent: ElementPassThrough,
- TooltipTrigger: PassThrough,
-}));
-
vi.doMock('@/components/handoff/OpenInAgentEmptySpaceSubmenu', () => ({
OpenInAgentEmptySpaceSubmenu: () => null,
}));
@@ -217,6 +212,10 @@ vi.doMock('sonner', () => ({
const { FileSidebar } = await import('./FileSidebar');
+function renderSidebar() {
+ return render(<FileSidebar onOpenSearch={() => {}} />, { wrapper: TooltipProvider });
+}
+
describe('FileSidebar project-root Share', () => {
beforeEach(() => {
hasRemote = true;
@@ -231,7 +230,7 @@ describe('FileSidebar project-root Share', () => {
});
test('the project-root header is marked so right-clicks open the project menu', async () => {
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
const header = await screen.findByText('open-knowledge');
// The header (or an ancestor) carries the right-click-exemption marker.
expect(header.closest('[data-sidebar-root-context]')).not.toBeNull();
@@ -239,7 +238,7 @@ describe('FileSidebar project-root Share', () => {
test('empty-space menu shows Share and dispatches a root-scope share input', async () => {
const user = userEvent.setup();
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
const share = await screen.findByTestId('empty-space-menu-share');
await user.click(share);
@@ -254,7 +253,7 @@ describe('FileSidebar project-root Share', () => {
test('Share is hidden when the project has no GitHub remote', async () => {
hasRemote = false;
- render(<FileSidebar onOpenSearch={() => {}} />);
+ renderSidebar();
// Another always-present root item proves the menu rendered.
await screen.findByTestId('empty-space-menu-new-file');
diff --git a/packages/app/src/components/InstanceBadge.dom.test.tsx b/packages/app/src/components/InstanceBadge.dom.test.tsx
index e7db404a1..1899f7ebf 100644
--- a/packages/app/src/components/InstanceBadge.dom.test.tsx
+++ b/packages/app/src/components/InstanceBadge.dom.test.tsx
@@ -1,27 +1,23 @@
import { cleanup, render, screen } from '@testing-library/react';
-import type { ReactNode } from 'react';
import { afterEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
vi.doMock('@lingui/react/macro', () => ({
useLingui: () => ({ t: renderLinguiTemplate }),
}));
-// Tooltip is decorative chrome; pass its parts through so the badge renders
-// without a TooltipProvider ancestor.
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: ({ children }: { children: ReactNode }) => <>{children}</>,
- TooltipTrigger: ({ children }: { children: ReactNode }) => <>{children}</>,
- TooltipContent: ({ children }: { children: ReactNode }) => <>{children}</>,
-}));
-
function setOkDesktop(value: { instanceLabel: string | null } | undefined): void {
(window as unknown as { okDesktop?: { instanceLabel: string | null } }).okDesktop = value;
}
async function renderInstanceBadge(className?: string) {
const { InstanceBadge } = await import('./InstanceBadge');
- return render(<InstanceBadge className={className} />);
+ return render(
+ <TooltipProvider>
+ <InstanceBadge className={className} />
+ </TooltipProvider>,
+ );
}
describe('InstanceBadge runtime behavior', () => {
diff --git a/packages/app/src/components/settings/OkignoreSection.dom.test.tsx b/packages/app/src/components/settings/OkignoreSection.dom.test.tsx
index acf04eea3..8a7822a80 100644
--- a/packages/app/src/components/settings/OkignoreSection.dom.test.tsx
+++ b/packages/app/src/components/settings/OkignoreSection.dom.test.tsx
@@ -1,6 +1,7 @@
import { act, cleanup, fireEvent, render, screen, waitFor, within } from '@testing-library/react';
import type { ReactNode } from 'react';
import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { emitConfigIgnoreNestedError } from '@/lib/config-ignore-nested-error-events';
import { emitConfigValidationRejected } from '@/lib/config-validation-events';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
@@ -131,12 +132,6 @@ vi.doMock('@/components/ui/skeleton', () => ({
),
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- Tooltip: ({ children }: { children?: ReactNode }) => <>{children}</>,
- TooltipContent: ({ children }: { children?: ReactNode }) => <div role="tooltip">{children}</div>,
- TooltipTrigger: ({ children }: { children?: ReactNode }) => <>{children}</>,
-}));
-
vi.doMock('@/components/PageListContext', () => ({
usePageList: () => ({
assetPaths: new Set(['assets/logo.png']),
@@ -185,7 +180,11 @@ async function renderSection({
synced?: boolean;
} = {}) {
const { OkignoreSection } = await import('./OkignoreSection');
- render(<OkignoreSection binding={binding as never} synced={synced} />);
+ render(
+ <TooltipProvider>
+ <OkignoreSection binding={binding as never} synced={synced} />
+ </TooltipProvider>,
+ );
return binding;
}
diff --git a/packages/app/src/components/settings/SettingsDialogBody.sections.dom.test.tsx b/packages/app/src/components/settings/SettingsDialogBody.sections.dom.test.tsx
index 421f7d828..89db2b69d 100644
--- a/packages/app/src/components/settings/SettingsDialogBody.sections.dom.test.tsx
+++ b/packages/app/src/components/settings/SettingsDialogBody.sections.dom.test.tsx
@@ -1,6 +1,7 @@
import { act, cleanup, fireEvent, render, screen, waitFor, within } from '@testing-library/react';
import { createContext, type ReactNode, use, useState } from 'react';
import { beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
type SyncStatus = {
@@ -212,13 +213,6 @@ vi.doMock('@/components/ui/toggle-group', () => ({
},
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- TooltipProvider: ({ children }: { children?: ReactNode }) => <>{children}</>,
- Tooltip: ({ children }: { children?: ReactNode }) => <>{children}</>,
- TooltipContent: ({ children }: { children?: ReactNode }) => <div>{children}</div>,
- TooltipTrigger: ({ children }: { children?: ReactNode }) => <>{children}</>,
-}));
-
vi.doMock('@/components/PublishToGitHubDialog', () => ({
PublishToGitHubDialog: (props: { open: boolean }) => {
publishDialogProps.push(props);
@@ -338,12 +332,14 @@ async function renderBody(
) {
const { SettingsDialogBody } = await import('./SettingsDialogBody');
render(
- <SettingsDialogBody
- activeId={props.activeId}
- userBinding={(props.userBinding ?? null) as never}
- okignoreBinding={(props.okignoreBinding ?? null) as never}
- okignoreSynced={props.okignoreSynced ?? false}
- />,
+ <TooltipProvider>
+ <SettingsDialogBody
+ activeId={props.activeId}
+ userBinding={(props.userBinding ?? null) as never}
+ okignoreBinding={(props.okignoreBinding ?? null) as never}
+ okignoreSynced={props.okignoreSynced ?? false}
+ />
+ </TooltipProvider>,
);
}
diff --git a/packages/app/src/components/settings/SettingsDialogBody.sync-mode.dom.test.tsx b/packages/app/src/components/settings/SettingsDialogBody.sync-mode.dom.test.tsx
index e13b44fac..5d2b4b976 100644
--- a/packages/app/src/components/settings/SettingsDialogBody.sync-mode.dom.test.tsx
+++ b/packages/app/src/components/settings/SettingsDialogBody.sync-mode.dom.test.tsx
@@ -8,8 +8,10 @@
* `autoSync.mode` on the project-local binding.
*/
import { cleanup, fireEvent, render, screen } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
import { createContext, type ReactNode, use } from 'react';
import { beforeEach, describe, expect, test, vi } from 'vitest';
+import { TooltipProvider } from '@/components/ui/tooltip';
import { renderLinguiTemplate } from '@/test-utils/lingui-mock';
type SyncStatus = {
@@ -152,15 +154,6 @@ vi.doMock('@/components/ui/toggle-group', () => ({
},
}));
-vi.doMock('@/components/ui/tooltip', () => ({
- TooltipProvider: ({ children }: { children?: ReactNode }) => <>{children}</>,
- Tooltip: ({ children }: { children?: ReactNode }) => <>{children}</>,
- TooltipContent: ({ children, ...props }: { children?: ReactNode; [key: string]: unknown }) => (
- <div {...props}>{children}</div>
- ),
- TooltipTrigger: ({ children }: { children?: ReactNode }) => <>{children}</>,
-}));
-
vi.doMock('@/components/PublishToGitHubDialog', () => ({
PublishToGitHubDialog: () => null,
}));
@@ -194,12 +187,14 @@ vi.doMock('@/lib/config-provider', () => ({
async function renderSyncSection() {
const { SettingsDialogBody } = await import('./SettingsDialogBody');
render(
- <SettingsDialogBody
- activeId="sync"
- userBinding={null as never}
- okignoreBinding={null as never}
- okignoreSynced={false}
- />,
+ <TooltipProvider>
+ <SettingsDialogBody
+ activeId="sync"
+ userBinding={null as never}
+ okignoreBinding={null as never}
+ okignoreSynced={false}
+ />
+ </TooltipProvider>,
);
}
@@ -293,6 +288,7 @@ describe('Settings Sync section — three-way mode control (real hooks + dialog)
});
test('a genuine read-only denial disables Full but keeps Off and Pull-only reachable', async () => {
+ const user = userEvent.setup();
syncStatus = {
...syncStatus,
pushPermission: { checkStatus: 'denied', deniedReason: 'no-collaborator' },
@@ -310,7 +306,13 @@ describe('Settings Sync section — three-way mode control (real hooks + dialog)
false,
);
// The disabled Full item carries a tooltip explaining the read-only denial.
- expect(screen.getByTestId('settings-sync-mode-full-tip').textContent ?? '').toContain(
+ const fullTrigger = screen
+ .getByTestId('settings-sync-mode-full')
+ .closest('[data-slot="tooltip-trigger"]');
+ if (fullTrigger === null) throw new Error('expected Full to have a tooltip trigger');
+ expect(screen.queryByTestId('settings-sync-mode-full-tip')).toBeNull();
+ await user.hover(fullTrigger);
+ expect((await screen.findByTestId('settings-sync-mode-full-tip')).textContent ?? '').toContain(
"You don't have permission to push to this repo",
);
});