Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
test(open-knowledge): fix partial mock.module factories + completeness guard (#1831)
Nick Gomez70710e2aea55
diff --git a/packages/app/src/components/GraphLegend.test.tsx b/packages/app/src/components/GraphLegend.test.tsxindex 41ee12929..132c0958d 100644--- a/packages/app/src/components/GraphLegend.test.tsx+++ b/packages/app/src/components/GraphLegend.test.tsx@@ -1,9 +1,11 @@import { beforeEach, describe, expect, mock, test } from 'bun:test';+import * as actualNextThemes from 'next-themes';import type { ReactElement, ReactNode } from 'react';const useThemeMock = mock(() => ({ resolvedTheme: 'light' as const }));mock.module('next-themes', () => ({+ ...actualNextThemes,useTheme: useThemeMock,}));diff --git a/packages/app/src/editor/clipboard/handle-drop.test.ts b/packages/app/src/editor/clipboard/handle-drop.test.tsindex 5629f22b8..4496bb646 100644--- a/packages/app/src/editor/clipboard/handle-drop.test.ts+++ b/packages/app/src/editor/clipboard/handle-drop.test.ts@@ -1,15 +1,18 @@import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';+import * as actualCore from '@inkeep/open-knowledge-core';+import * as actualSonner from 'sonner';import { createHandleDrop } from './handle-paste.ts';mock.module('@inkeep/open-knowledge-core', () => {return {+ ...actualCore,htmlToMdast: mock((_html: string) => ({ type: 'root', children: [] })),mdastToMarkdown: mock((_tree: unknown) => '**bold**'),};});-mock.module('sonner', () => ({ toast: { error: mock(() => {}) } }));+mock.module('sonner', () => ({ ...actualSonner, toast: { error: mock(() => {}) } }));interface FakeDropOptions {data: Record<string, string>;diff --git a/packages/app/src/editor/clipboard/handle-paste.test.ts b/packages/app/src/editor/clipboard/handle-paste.test.tsindex 9f5cb6a4a..18ddde78d 100644--- a/packages/app/src/editor/clipboard/handle-paste.test.ts+++ b/packages/app/src/editor/clipboard/handle-paste.test.ts@@ -1,15 +1,18 @@import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';+import * as actualCore from '@inkeep/open-knowledge-core';+import * as actualSonner from 'sonner';import { createHandlePaste } from './handle-paste.ts';mock.module('@inkeep/open-knowledge-core', () => {return {+ ...actualCore,htmlToMdast: mock((_html: string) => ({ type: 'root', children: [] })),mdastToMarkdown: mock((_tree: unknown) => '**bold**'),};});-mock.module('sonner', () => ({ toast: { error: mock(() => {}) } }));+mock.module('sonner', () => ({ ...actualSonner, toast: { error: mock(() => {}) } }));function fakeDT(data: Record<string, string>): ClipboardEvent {const evt = {diff --git a/packages/app/src/editor/clipboard/paste-failure-toast.test.ts b/packages/app/src/editor/clipboard/paste-failure-toast.test.tsindex 9f0a1ff45..6a2e7f120 100644--- a/packages/app/src/editor/clipboard/paste-failure-toast.test.ts+++ b/packages/app/src/editor/clipboard/paste-failure-toast.test.ts@@ -1,8 +1,9 @@import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';+import * as actualSonner from 'sonner';type ToastFn = { error: ReturnType<typeof mock> };const toastMock: ToastFn = { error: mock(() => {}) };-mock.module('sonner', () => ({ toast: toastMock }));+mock.module('sonner', () => ({ ...actualSonner, toast: toastMock }));// biome-ignore lint/suspicious/noExplicitAny: test-scoped dynamic importlet mod: any;diff --git a/packages/app/src/editor/clipboard/source-clipboard-recovery.test.ts b/packages/app/src/editor/clipboard/source-clipboard-recovery.test.tsindex eb5059657..0a5e3069d 100644--- a/packages/app/src/editor/clipboard/source-clipboard-recovery.test.ts+++ b/packages/app/src/editor/clipboard/source-clipboard-recovery.test.ts@@ -1,9 +1,10 @@import { afterEach, beforeEach, describe, expect, mock, test } from 'bun:test';import { ChunkedInsertError } from '@inkeep/open-knowledge-core';+import * as actualSonner from 'sonner';type ToastFn = { error: ReturnType<typeof mock> };const toastMock: ToastFn = { error: mock(() => {}) };-mock.module('sonner', () => ({ toast: toastMock }));+mock.module('sonner', () => ({ ...actualSonner, toast: toastMock }));// biome-ignore lint/suspicious/noExplicitAny: test-scoped dynamic importlet handleChunkedInsertFailure: any;diff --git a/packages/app/src/lib/dispatch-open-in-terminal.test.ts b/packages/app/src/lib/dispatch-open-in-terminal.test.tsindex 73cffdad9..ea25edaf0 100644--- a/packages/app/src/lib/dispatch-open-in-terminal.test.ts+++ b/packages/app/src/lib/dispatch-open-in-terminal.test.ts@@ -1,4 +1,5 @@import { afterEach, beforeEach, expect, mock, test } from 'bun:test';+import * as actualSonner from 'sonner';import { dispatchOpenInTerminal } from './dispatch-open-in-terminal.ts';type ToastCall = { kind: 'error' | 'success'; message: string; description?: string };@@ -9,6 +10,7 @@ const toastErrorMock = mock((message: string, opts?: { description?: string }) =});mock.module('sonner', () => ({+ ...actualSonner,toast: { error: toastErrorMock },}));diff --git a/packages/app/src/lib/install-server-drift-listener.test.ts b/packages/app/src/lib/install-server-drift-listener.test.tsindex df515cca3..20f530eca 100644--- a/packages/app/src/lib/install-server-drift-listener.test.ts+++ b/packages/app/src/lib/install-server-drift-listener.test.ts@@ -1,4 +1,5 @@import { describe, expect, mock, test } from 'bun:test';+import * as actualSonner from 'sonner';import type {OkDesktopBridge,OkServerRestartOutcome,@@ -12,6 +13,7 @@ const toastError = mock((_msg: string, _opts?: unknown) => 'error-id');const toastDismiss = mock((_id?: unknown) => {});const toastCustom = mock((_render: (id: unknown) => unknown, _opts?: unknown) => 'custom-id');mock.module('sonner', () => ({+ ...actualSonner,toast: Object.assign(mock(() => {}),{diff --git a/packages/app/src/presence/PresenceBar-avatar-click.test.tsx b/packages/app/src/presence/PresenceBar-avatar-click.test.tsxindex ae27e4731..e5ad9cc6c 100644--- a/packages/app/src/presence/PresenceBar-avatar-click.test.tsx+++ b/packages/app/src/presence/PresenceBar-avatar-click.test.tsx@@ -2,8 +2,11 @@ import { afterEach, describe, expect, mock, test } from 'bun:test';import type { AgentPresenceEntry } from '@inkeep/open-knowledge-core';import { renderToString } from 'react-dom/server';import { TooltipProvider } from '@/components/ui/tooltip';+import * as actualDocumentContext from '@/editor/DocumentContext';import type { AgentParticipant } from './use-presence';-import { isSelfAwarenessEntry } from './use-presence.ts';+import * as actualUsePresence from './use-presence';+import * as actualUseSyncStatus from './use-sync-status';+import * as actualUseSyncToasts from './use-sync-toasts';const openActivityPanelCalls: Array<[string, string | null]> = [];const openActivityPanel = (connectionId: string, targetDoc: string | null): void => {@@ -15,6 +18,7 @@ let crossDocAgents: AgentParticipant[] = [];let mockActiveDocName: string | null = null;mock.module('@/editor/DocumentContext', () => ({+ ...actualDocumentContext,useDocumentContext: () => ({activeProvider: null,activeDocName: mockActiveDocName,@@ -28,15 +32,17 @@ mock.module('@/editor/DocumentContext', () => ({}));mock.module('./use-presence', () => ({- isSelfAwarenessEntry,+ ...actualUsePresence,usePresence: () => ({ current: currentAgents, crossDoc: crossDocAgents }),}));mock.module('./use-sync-status', () => ({+ ...actualUseSyncStatus,useSyncStatus: () => ({ state: 'clean' }),}));mock.module('./use-sync-toasts', () => ({+ ...actualUseSyncToasts,useSyncToasts: () => {},}));diff --git a/packages/app/src/server/hocuspocus-plugin.test.ts b/packages/app/src/server/hocuspocus-plugin.test.tsindex e0ac4d1ee..a64f3bab8 100644--- a/packages/app/src/server/hocuspocus-plugin.test.ts+++ b/packages/app/src/server/hocuspocus-plugin.test.ts@@ -3,6 +3,7 @@ import { EventEmitter } from 'node:events';import { existsSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';import { tmpdir } from 'node:os';import { join } from 'node:path';+import * as actualServerPkg from '@inkeep/open-knowledge-server';import { resolveContentConfig } from './hocuspocus-plugin.ts';const createdDirs: string[] = [];@@ -66,6 +67,7 @@ describe('hocuspocusPlugin.configureServer middleware ordering', () => {const createAssetServeMiddlewareSpy = mock(() => innerAssetFn);mock.module('@inkeep/open-knowledge-server', () => ({+ ...actualServerPkg,createAssetServeMiddleware: createAssetServeMiddlewareSpy,createServer: () => ({lockDir: testContentDir,diff --git a/packages/app/tests/integration/mock-module-completeness.test.ts b/packages/app/tests/integration/mock-module-completeness.test.tsnew file mode 100644index 000000000..238903557--- /dev/null+++ b/packages/app/tests/integration/mock-module-completeness.test.ts@@ -0,0 +1,58 @@+import { describe, expect, test } from 'bun:test';+import { readFileSync } from 'node:fs';+import { join, relative } from 'node:path';+import { Glob } from 'bun';++const APP_ROOT = join(import.meta.dir, '..', '..');++const ALLOWLIST: Record<string, string> = {+ 'src/components/EditorActivityPool.lazy.test.ts::@/editor/SourceEditor':+ 'The factory COUNTS module loads to assert lazy non-loading — spreading the real module would ' ++ "load it and defeat the test. Safe: the factory provides SourceEditor, the module's only " ++ 'value export consumed by plain tests in this process.',+};++function extractMockModuleCalls(src: string): Array<{ specifier: string; factory: string }> {+ const calls: Array<{ specifier: string; factory: string }> = [];+ const re = /mock\.module\(\s*(['"])([^'"]+)\1\s*,/g;+ let m: RegExpExecArray | null = re.exec(src);+ while (m !== null) {+ let depth = 1;+ let i = re.lastIndex;+ while (i < src.length && depth > 0) {+ const ch = src[i];+ if (ch === '(') depth++;+ else if (ch === ')') depth--;+ i++;+ }+ calls.push({ specifier: m[2] ?? '', factory: src.slice(re.lastIndex, i) });+ m = re.exec(src);+ }+ return calls;+}++describe('mock.module factory completeness (process-global leak guard)', () => {+ test('every plain-test factory spreads the real module or is allowlisted', async () => {+ const glob = new Glob('src/**/*.test.{ts,tsx}');+ const violations: string[] = [];+ for await (const file of glob.scan(APP_ROOT)) {+ if (file.includes('.dom.test.')) continue;+ const abs = join(APP_ROOT, file);+ const rel = relative(APP_ROOT, abs);+ const src = readFileSync(abs, 'utf-8');+ if (!src.includes('mock.module(')) continue;+ for (const call of extractMockModuleCalls(src)) {+ const hasSpread = /\.\.\.\s*actual[A-Za-z_$]?[\w$]*/.test(call.factory);+ const allowKey = `${rel}::${call.specifier}`;+ if (!hasSpread && !(allowKey in ALLOWLIST)) {+ violations.push(+ `${rel} mocks '${call.specifier}' with a partial factory (no \`...actual*\`-convention spread). ` ++ `Spread the real module (static-import it as actual, then \`...actual\` first in the factory) ` ++ `or add '${allowKey}' to ALLOWLIST with a safety rationale.`,+ );+ }+ }+ }+ expect(violations).toEqual([]);+ });+});