Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

fix(ok): deflake Windows terminal smoke by asserting toasts first (#4093)

Nick Gomez743fc870da1e
diff --git a/packages/desktop/tests/smoke/terminal-dock.e2e.ts b/packages/desktop/tests/smoke/terminal-dock.e2e.ts
index 328c21753..34e779981 100644
--- a/packages/desktop/tests/smoke/terminal-dock.e2e.ts
+++ b/packages/desktop/tests/smoke/terminal-dock.e2e.ts
@@ -612,14 +612,18 @@ test.describe('Docked terminal — live Electron', () => {
const target = win as { setSize: (width: number, height: number, animate: boolean) => void };
target.setSize(900, 900, false);
});
+ // STOP: this notice auto-dismisses 4s after firing (sonner TOAST_LIFETIME; <Toaster> sets no duration), so assert it before slower waits.
+ await expect(page.getByText('Agent panel closed to keep Terminal readable.')).toBeVisible();
await expect.poll(() => page.evaluate(() => window.innerWidth)).toBeLessThan(1000);
await expectCollapsedRailColumn(page, '#agents-column');
await expect(page.locator('#terminal-column section[aria-label="Terminal"]')).toBeVisible();
- await expect(page.getByText('Agent panel closed to keep Terminal readable.')).toBeVisible();
await clickViewAgentsItem(app);
+ // STOP: this notice auto-dismisses 4s after firing (sonner TOAST_LIFETIME; <Toaster> sets no duration), so assert it before slower waits.
+ await expect(page.getByText('Terminal closed to make room for the agent panel.')).toBeVisible({
+ timeout: 10_000,
+ });
await expect(page.locator('#agents-column')).toBeVisible({ timeout: 10_000 });
- await expect(page.getByText('Terminal closed to make room for the agent panel.')).toBeVisible();
await expectCollapsedRailColumn(page, '#terminal-column');
await clickViewAgentsItem(app);
diff --git a/packages/desktop/tests/smoke/terminal-movement.e2e.ts b/packages/desktop/tests/smoke/terminal-movement.e2e.ts
index 584306fce..ed1d9634a 100644
--- a/packages/desktop/tests/smoke/terminal-movement.e2e.ts
+++ b/packages/desktop/tests/smoke/terminal-movement.e2e.ts
@@ -612,9 +612,12 @@ test.describe('Terminal placement continuity — live Electron', () => {
});
await page.reload({ waitUntil: 'domcontentloaded' });
- await expect(page.locator('#terminal-column')).toBeVisible({ timeout: 20_000 });
+ // STOP: this notice auto-dismisses 4s after firing (sonner TOAST_LIFETIME; <Toaster> sets no duration), so assert it before slower waits.
+ await expect(page.getByText('Agent panel closed to keep Terminal readable.')).toBeVisible({
+ timeout: 20_000,
+ });
+ await expect(page.locator('#terminal-column')).toBeVisible({ timeout: 10_000 });
await expectCollapsedRailColumn(page, '#agents-column');
- await expect(page.getByText('Agent panel closed to keep Terminal readable.')).toBeVisible();
await editorWindow.evaluate((windowHandle: unknown) => {
const target = windowHandle as {
setSize: (width: number, height: number, animate: boolean) => void;