Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Fix/task checkbox disabled after editable (#2166)
sarah749bcc361dff
diff --git a/.changeset/task-checkbox-disabled-after-editable.md b/.changeset/task-checkbox-disabled-after-editable.mdnew file mode 100644index 000000000..c55c24e15--- /dev/null+++ b/.changeset/task-checkbox-disabled-after-editable.md@@ -0,0 +1,5 @@+---+"@inkeep/open-knowledge-core": patch+---++Task-list checkboxes now stay clickable when an editor transitions from read-only to editable. The list-item NodeView set the checkbox's `disabled` state once at creation from `editor.isEditable`, but a `setEditable()` flip updates the view's editable flag without a document change, so ProseMirror never re-renders the NodeView and the stale `disabled` was never cleared. A checkbox created while the editor was read-only (for example, content loaded before the editor goes live) stayed permanently uncheckable. The NodeView now keeps `disabled` in sync with editability via the editor's `update` event (which `setEditable()` emits) and on every NodeView update.diff --git a/packages/core/src/extensions/list.ts b/packages/core/src/extensions/list.tsindex 6d3b483aa..ffc5f9ed7 100644--- a/packages/core/src/extensions/list.ts+++ b/packages/core/src/extensions/list.ts@@ -329,6 +329,10 @@ export const ListItemNode = Node.create({let checkbox: HTMLInputElement | null = null;const contentDiv = document.createElement('div');+ const syncDisabled = () => {+ if (checkbox) checkbox.disabled = !editor.isEditable;+ };+if (node.attrs.checked !== null) {checkboxLabel = document.createElement('label');checkboxLabel.contentEditable = 'false';@@ -336,10 +340,8 @@ export const ListItemNode = Node.create({checkbox = document.createElement('input');checkbox.type = 'checkbox';checkbox.checked = !!node.attrs.checked;-- if (!editor.isEditable) {- checkbox.disabled = true;- }+ syncDisabled();+ editor.on('update', syncDisabled);checkbox.addEventListener('change', () => {const pos = getPos();@@ -368,11 +370,15 @@ export const ListItemNode = Node.create({}if (checkbox && updatedNode.attrs.checked !== null) {checkbox.checked = !!updatedNode.attrs.checked;+ checkbox.disabled = !editor.isEditable;li.setAttribute('data-checked', String(!!updatedNode.attrs.checked));}node = updatedNode;return true;},+ destroy() {+ editor.off('update', syncDisabled);+ },};};},