Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
Allow digit-leading frontmatter tags (PRD-6941) (#1686)
tim-inkeep78abb7968956
diff --git a/.changeset/fix-frontmatter-digit-leading-tags.md b/.changeset/fix-frontmatter-digit-leading-tags.mdnew file mode 100644index 000000000..e7d234c5f--- /dev/null+++ b/.changeset/fix-frontmatter-digit-leading-tags.md@@ -0,0 +1,6 @@+---+"@inkeep/open-knowledge-core": patch+"@inkeep/open-knowledge-app": patch+---++Allow digit-leading tags (like the year `2026`) in a document's frontmatter `tags:` field. The property panel previously rejected them with "Tags must start with a letter…", even though a year is a legitimate tag. The frontmatter tag grammar is now more permissive than the inline `#tag` grammar: a frontmatter tag may start with a letter or a digit, while inline `#tag` in prose still requires a leading letter (so `#123` stays plain text and does not collide with issue-reference conventions).diff --git a/packages/app/src/components/PropertyWidgets.dom.test.tsx b/packages/app/src/components/PropertyWidgets.dom.test.tsxindex 637a01561..d3ad0b46a 100644--- a/packages/app/src/components/PropertyWidgets.dom.test.tsx+++ b/packages/app/src/components/PropertyWidgets.dom.test.tsx@@ -30,11 +30,11 @@ describe('ListWidget — render-side invalid tag flagging', () => {const chips = container.querySelectorAll('[data-testid="list-chip"]');expect(chips).toHaveLength(5);const invalid = container.querySelectorAll('[data-tag-invalid="true"]');- expect(invalid).toHaveLength(3);+ expect(invalid).toHaveLength(2);const invalidTexts = Array.from(invalid).map((el) =>(el.textContent ?? '').replace(/\s+/g, ' ').trim(),);- expect(invalidTexts.some((t) => t.includes('2026'))).toBe(true);+ expect(invalidTexts.some((t) => t.includes('2026'))).toBe(false);expect(invalidTexts.some((t) => t.includes('has spaces'))).toBe(true);expect(invalidTexts.some((t) => t.includes('hello!'))).toBe(true);});@@ -48,7 +48,7 @@ describe('ListWidget — render-side invalid tag flagging', () => {});test('invalid chips are wrapped in a Radix Tooltip trigger (content lazy-renders on open)', () => {- const { container } = renderWidget({ keyName: 'tags', value: ['2026'] });+ const { container } = renderWidget({ keyName: 'tags', value: ['bad!'] });const invalidChip = container.querySelector('[data-tag-invalid="true"]');expect(invalidChip?.getAttribute('data-slot')).toBe('tooltip-trigger');});@@ -76,10 +76,10 @@ describe('ListWidget — input-side grammar gate (tags field only)', () => {const onCommit = mock(() => {});const { container } = renderWidget({ keyName: 'tags', value: [], onCommit });const input = container.querySelector('[data-testid="list-chip-input"]') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(onCommit).toHaveBeenCalledTimes(0);- expect(input.value).toBe('2026');+ expect(input.value).toBe('bad!');expect(input.getAttribute('data-tag-invalid')).toBe('true');expect(input.getAttribute('aria-invalid')).toBe('true');const alert = container.querySelector('[data-testid="list-chip-input-error"]');@@ -101,13 +101,25 @@ describe('ListWidget — input-side grammar gate (tags field only)', () => {expect(container.querySelector('[data-testid="list-chip-input-error"]')).toBeNull();});+ test('addChip accepts a digit-leading tag like a year (2026)', () => {+ const onCommit = mock(() => {});+ const { container } = renderWidget({ keyName: 'tags', value: [], onCommit });+ const input = container.querySelector('[data-testid="list-chip-input"]') as HTMLInputElement;+ fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onCommit).toHaveBeenCalledTimes(1);+ expect(onCommit.mock.calls[0]?.[0]).toEqual(['2026']);+ expect(input.value).toBe('');+ expect(input.getAttribute('aria-invalid')).toBeNull();+ });+test('typing after a rejection clears the rejection state immediately', () => {const { container } = renderWidget({ keyName: 'tags', value: [] });const input = container.querySelector('[data-testid="list-chip-input"]') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(input.getAttribute('aria-invalid')).toBe('true');- fireEvent.change(input, { target: { value: '2026r' } });+ fireEvent.change(input, { target: { value: 'bad!x' } });expect(input.getAttribute('aria-invalid')).toBeNull();expect(container.querySelector('[data-testid="list-chip-input-error"]')).toBeNull();});@@ -116,7 +128,7 @@ describe('ListWidget — input-side grammar gate (tags field only)', () => {const onCommit = mock(() => {});const { container } = renderWidget({ keyName: 'tags', value: [], onCommit });const input = container.querySelector('[data-testid="list-chip-input"]') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(input.getAttribute('aria-invalid')).toBe('true');fireEvent.keyDown(input, { key: 'Escape' });diff --git a/packages/app/src/components/ui/tag-pill-input.dom.test.tsx b/packages/app/src/components/ui/tag-pill-input.dom.test.tsxindex 386aa9788..c81ca3682 100644--- a/packages/app/src/components/ui/tag-pill-input.dom.test.tsx+++ b/packages/app/src/components/ui/tag-pill-input.dom.test.tsx@@ -37,14 +37,14 @@ describe('TagPillInput — render-side invalid pill flagging', () => {value: ['showcase', '2026', 'has spaces', 'proj/team'],});const invalid = container.querySelectorAll('[data-tag-invalid="true"]');- expect(invalid).toHaveLength(2);+ expect(invalid).toHaveLength(1);const texts = Array.from(invalid).map((el) => el.textContent ?? '');- expect(texts.some((t) => t.includes('2026'))).toBe(true);+ expect(texts.some((t) => t.includes('2026'))).toBe(false);expect(texts.some((t) => t.includes('has spaces'))).toBe(true);});test('invalid pill is wrapped in a Radix Tooltip trigger (content lazy-renders)', () => {- const { container } = renderInput({ value: ['2026'] });+ const { container } = renderInput({ value: ['bad!'] });const invalidBadge = container.querySelector('[data-tag-invalid="true"]');expect(invalidBadge?.getAttribute('data-slot')).toBe('tooltip-trigger');});@@ -65,10 +65,10 @@ describe('TagPillInput — input-side grammar gate', () => {const onChange = mock(() => {});const { container } = renderInput({ onChange });const input = container.querySelector('input') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(onChange).toHaveBeenCalledTimes(0);- expect(input.value).toBe('2026');+ expect(input.value).toBe('bad!');expect(input.getAttribute('data-tag-invalid')).toBe('true');expect(input.getAttribute('aria-invalid')).toBe('true');const alert = container.querySelector('[data-testid="tag-pill-input-error"]');@@ -89,13 +89,25 @@ describe('TagPillInput — input-side grammar gate', () => {expect(input.getAttribute('aria-invalid')).toBeNull();});+ test('Enter on a digit-leading tag like a year (2026) commits', () => {+ const onChange = mock(() => {});+ const { container } = renderInput({ onChange });+ const input = container.querySelector('input') as HTMLInputElement;+ fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.keyDown(input, { key: 'Enter' });+ expect(onChange).toHaveBeenCalledTimes(1);+ expect(onChange.mock.calls[0]?.[0]).toEqual(['2026']);+ expect(input.value).toBe('');+ expect(input.getAttribute('aria-invalid')).toBeNull();+ });+test('typing clears rejection state for the next commit attempt', () => {const { container } = renderInput();const input = container.querySelector('input') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(input.getAttribute('aria-invalid')).toBe('true');- fireEvent.change(input, { target: { value: '2026r' } });+ fireEvent.change(input, { target: { value: 'bad!x' } });expect(input.getAttribute('aria-invalid')).toBeNull();});@@ -103,7 +115,7 @@ describe('TagPillInput — input-side grammar gate', () => {const onChange = mock(() => {});const { container } = renderInput({ onChange });const input = container.querySelector('input') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });expect(input.getAttribute('aria-invalid')).toBe('true');fireEvent.keyDown(input, { key: 'Escape' });@@ -154,7 +166,7 @@ describe('TagPillInput — a11y id wiring (regression: PR #1288 review findings)test('grammar-hint id is derived from the caller-supplied `id` prop (per-instance unique)', () => {const { container } = renderInput({ id: 'my-tags-field' });const input = container.querySelector('input') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });const alert = container.querySelector('[data-testid="tag-pill-input-error"]');expect(alert?.id).toBe('my-tags-field-grammar-hint');@@ -168,7 +180,7 @@ describe('TagPillInput — a11y id wiring (regression: PR #1288 review findings)</TooltipProvider>,);const [leftInput, rightInput] = container.querySelectorAll('input');- fireEvent.change(leftInput as HTMLInputElement, { target: { value: '2026' } });+ fireEvent.change(leftInput as HTMLInputElement, { target: { value: 'bad!' } });fireEvent.keyDown(leftInput as HTMLInputElement, { key: 'Enter' });fireEvent.change(rightInput as HTMLInputElement, { target: { value: 'has spaces' } });fireEvent.keyDown(rightInput as HTMLInputElement, { key: 'Enter' });@@ -184,7 +196,7 @@ describe('TagPillInput — a11y id wiring (regression: PR #1288 review findings)'aria-describedby': 'my-field-rhf-error',});const input = container.querySelector('input') as HTMLInputElement;- fireEvent.change(input, { target: { value: '2026' } });+ fireEvent.change(input, { target: { value: 'bad!' } });fireEvent.keyDown(input, { key: 'Enter' });const describedby = input.getAttribute('aria-describedby') ?? '';const ids = describedby.split(/\s+/).filter(Boolean);diff --git a/packages/app/src/editor/components/TagView.tsx b/packages/app/src/editor/components/TagView.tsxindex cffcbec9a..b8dd338a7 100644--- a/packages/app/src/editor/components/TagView.tsx+++ b/packages/app/src/editor/components/TagView.tsx@@ -1,4 +1,4 @@-import { FRONTMATTER_TAG_VALUE_RE } from '@inkeep/open-knowledge-core';+import { INLINE_TAG_VALUE_RE } from '@inkeep/open-knowledge-core';import { useLingui } from '@lingui/react/macro';import type { NodeViewProps } from '@tiptap/core';import { TextSelection } from '@tiptap/pm/state';@@ -11,7 +11,7 @@ function commitDraft(next: string,): boolean {if (typeof pos !== 'number') return false;- if (!next || !FRONTMATTER_TAG_VALUE_RE.test(next)) return false;+ if (!next || !INLINE_TAG_VALUE_RE.test(next)) return false;const { state, view } = editor;const curNode = state.doc.nodeAt(pos);if (!curNode || curNode.type.name !== 'tag') return false;@@ -86,7 +86,7 @@ function PlaceholderInput({ initialDraft, onCommit, onCancel }: PlaceholderInputclassName="bg-transparent border-0 p-0 outline-none focus:outline-none focus:ring-0 text-inherit font-inherit"onChange={(e) => {const next = e.target.value;- if (next === '' || FRONTMATTER_TAG_VALUE_RE.test(next)) {+ if (next === '' || INLINE_TAG_VALUE_RE.test(next)) {setDraft(next);}}}@@ -113,7 +113,7 @@ function PlaceholderInput({ initialDraft, onCommit, onCancel }: PlaceholderInputonCancel();return;}- if (FRONTMATTER_TAG_VALUE_RE.test(draft)) {+ if (INLINE_TAG_VALUE_RE.test(draft)) {onCommit(draft);} else {onCancel();diff --git a/packages/core/src/frontmatter/tags.test.ts b/packages/core/src/frontmatter/tags.test.tsindex 196cb1e46..5a78511a1 100644--- a/packages/core/src/frontmatter/tags.test.ts+++ b/packages/core/src/frontmatter/tags.test.ts@@ -7,18 +7,20 @@ import {} from './tags.ts';describe('FRONTMATTER_TAG_VALUE_RE', () => {- test('accepts shapes the inline promoter accepts', () => {+ test('accepts letter- and digit-leading shapes', () => {expect(FRONTMATTER_TAG_VALUE_RE.test('typescript')).toBe(true);expect(FRONTMATTER_TAG_VALUE_RE.test('proj/team/2026')).toBe(true);expect(FRONTMATTER_TAG_VALUE_RE.test('a-b_c')).toBe(true);expect(FRONTMATTER_TAG_VALUE_RE.test('a1')).toBe(true);+ expect(FRONTMATTER_TAG_VALUE_RE.test('2026')).toBe(true);+ expect(FRONTMATTER_TAG_VALUE_RE.test('123')).toBe(true);});- test('rejects digit-leading, empty, and whitespace shapes', () => {- expect(FRONTMATTER_TAG_VALUE_RE.test('123')).toBe(false);+ test('rejects empty, whitespace, and punctuation-leading shapes', () => {expect(FRONTMATTER_TAG_VALUE_RE.test('')).toBe(false);expect(FRONTMATTER_TAG_VALUE_RE.test('foo bar')).toBe(false);expect(FRONTMATTER_TAG_VALUE_RE.test('-leading-dash')).toBe(false);+ expect(FRONTMATTER_TAG_VALUE_RE.test('/leading-slash')).toBe(false);});});@@ -55,8 +57,8 @@ describe('extractFrontmatterTags', () => {const warn = spyOn(console, 'warn').mockImplementation(mock(() => {}));try {const out = extractFrontmatterTags('tags: [valid, "with space", "123digit", another]\n');- expect(out).toEqual(['valid', 'another']);- expect(warn).toHaveBeenCalledTimes(2);+ expect(out).toEqual(['valid', '123digit', 'another']);+ expect(warn).toHaveBeenCalledTimes(1);} finally {warn.mockRestore();}@@ -65,6 +67,7 @@ describe('extractFrontmatterTags', () => {test('coerces non-string scalars and applies the per-entry tag regex', () => {expect(extractFrontmatterTags('tags: [valid, 42, true, also]\n')).toEqual(['valid',+ '42','true','also',]);@@ -96,10 +99,10 @@ describe('isValidFrontmatterTagValue', () => {}});- test('rejects leading-digit values (year-only tags fail)', () => {- expect(isValidFrontmatterTagValue('2026')).toBe(false);- expect(isValidFrontmatterTagValue('42')).toBe(false);- expect(isValidFrontmatterTagValue('1q-recap')).toBe(false);+ test('accepts leading-digit values (year-only tags like 2026)', () => {+ expect(isValidFrontmatterTagValue('2026')).toBe(true);+ expect(isValidFrontmatterTagValue('42')).toBe(true);+ expect(isValidFrontmatterTagValue('1q-recap')).toBe(true);});test('rejects whitespace-containing values', () => {diff --git a/packages/core/src/frontmatter/tags.ts b/packages/core/src/frontmatter/tags.tsindex 124e185ff..c9801f480 100644--- a/packages/core/src/frontmatter/tags.ts+++ b/packages/core/src/frontmatter/tags.ts@@ -1,6 +1,6 @@import { parseFrontmatterYaml } from './yaml-codec.ts';-export const FRONTMATTER_TAG_VALUE_RE = /^[a-zA-Z][\w/-]*$/;+export const FRONTMATTER_TAG_VALUE_RE = /^[a-zA-Z0-9][\w/-]*$/;export function isValidFrontmatterTagValue(value: string): boolean {if (typeof value !== 'string') return false;@@ -9,7 +9,7 @@ export function isValidFrontmatterTagValue(value: string): boolean {}export const FRONTMATTER_TAG_GRAMMAR_HINT =- 'Tags must start with a letter and contain only letters, digits, underscores, dashes, and slashes.';+ 'Tags must start with a letter or digit and contain only letters, digits, underscores, dashes, and slashes.';function stripLeadingHash(value: string): string {return value.startsWith('#') ? value.slice(1) : value;diff --git a/packages/core/src/index.ts b/packages/core/src/index.tsindex a6fa609e2..8ac9ffd90 100644--- a/packages/core/src/index.ts+++ b/packages/core/src/index.ts@@ -370,6 +370,7 @@ export {} from './markdown/safe-url.ts';export {createTagInTextRegex,+ INLINE_TAG_VALUE_RE,TAG_IN_TEXT_PATTERN_SOURCE,} from './markdown/tag-promotion.ts';export {diff --git a/packages/core/src/markdown/tag-promotion.test.ts b/packages/core/src/markdown/tag-promotion.test.tsnew file mode 100644index 000000000..ff7ededf3--- /dev/null+++ b/packages/core/src/markdown/tag-promotion.test.ts@@ -0,0 +1,16 @@+import { describe, expect, test } from 'bun:test';+import { INLINE_TAG_VALUE_RE } from './tag-promotion.ts';++describe('INLINE_TAG_VALUE_RE', () => {+ test('accepts letter-leading values', () => {+ expect(INLINE_TAG_VALUE_RE.test('typescript')).toBe(true);+ expect(INLINE_TAG_VALUE_RE.test('proj/team')).toBe(true);+ expect(INLINE_TAG_VALUE_RE.test('a1')).toBe(true);+ });++ test('rejects digit-leading values (keeps #2026 as plain text)', () => {+ expect(INLINE_TAG_VALUE_RE.test('2026')).toBe(false);+ expect(INLINE_TAG_VALUE_RE.test('123')).toBe(false);+ expect(INLINE_TAG_VALUE_RE.test('1q-recap')).toBe(false);+ });+});diff --git a/packages/core/src/markdown/tag-promotion.ts b/packages/core/src/markdown/tag-promotion.tsindex 96bb5c560..aa0bb9efb 100644--- a/packages/core/src/markdown/tag-promotion.ts+++ b/packages/core/src/markdown/tag-promotion.ts@@ -7,6 +7,8 @@ export function createTagInTextRegex(): RegExp {}const TAG_IN_TEXT_RE = createTagInTextRegex();+export const INLINE_TAG_VALUE_RE = /^[a-zA-Z][\w/-]*$/;+function isEscapedHash(source: string, sourceOffsetOfHash: number): boolean {if (sourceOffsetOfHash <= 0) return false;if (source[sourceOffsetOfHash - 1] !== '\\') return false;