Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

PRD-8600: Pin electron-builder 26.16.1 (#4297)

Andrew Mikofalvy7aff781e21d0
diff --git a/.changeset/windows-removal-probe-timeout.md b/.changeset/windows-removal-probe-timeout.md
new file mode 100644
index 000000000..4f655845d
--- /dev/null
+++ b/.changeset/windows-removal-probe-timeout.md
@@ -0,0 +1,5 @@
+---
+'@inkeep/open-knowledge': patch
+---
+
+`ok deinit` and `ok uninstall` now allow up to 15 seconds for the Windows identity probe to start PowerShell on busy systems instead of 5 seconds; macOS and Linux keep the existing 5-second timeout.
diff --git a/.github/workflows/desktop-build.yml b/.github/workflows/desktop-build.yml
index 2ba4f52fe..000cd0a64 100644
--- a/.github/workflows/desktop-build.yml
+++ b/.github/workflows/desktop-build.yml
@@ -171,7 +171,9 @@ jobs:
# the keychain's own (electron-userland/electron-builder#10066), which
# macOS 26.6 (macos-26 image 20260831 onward) rejects with
# `SecKeychainUnlock: The user name or passphrase you entered is not
- # correct`. The v26 backport (#10172) is merged but unreleased.
+ # correct`. The v26 backport (#10172) shipped in 26.16.1. Keep this twin
+ # staged-keychain path until a stable tag carries that fixed dependency;
+ # desktop-release.yml documents the tag-tree rescue constraint.
- name: Prepare signing keychain (CSC_KEYCHAIN)
if: steps.signmode.outputs.mode == 'signed'
env:
diff --git a/.github/workflows/desktop-release.yml b/.github/workflows/desktop-release.yml
index 8373f12eb..7d9fbb593 100644
--- a/.github/workflows/desktop-release.yml
+++ b/.github/workflows/desktop-release.yml
@@ -635,10 +635,10 @@ jobs:
# slide on an already-unlocked keychain; macOS 26.6 (GitHub's macos-26
# image 20260831 onward) verifies it, and every signed build on that
# image died with `SecKeychainUnlock: The user name or passphrase you
- # entered is not correct`. The v26 backport (#10172) is merged but
- # unreleased, and a dependency bump would not reach already-cut tags
- # anyway: this job builds the TAG's tree while the workflow file is read
- # from main, so the fix has to live here. With CSC_KEYCHAIN set and
+ # entered is not correct`. The v26 backport (#10172) shipped in 26.16.1,
+ # but a dependency bump does not reach already-cut tags: this job builds
+ # the TAG's tree while the workflow file is read from main, so the fix
+ # still has to live here. With CSC_KEYCHAIN set and
# CSC_LINK unset, electron-builder skips its keychain setup entirely and
# reads identities from the keychain it is handed (macPackager.ts).
#
@@ -650,12 +650,20 @@ jobs:
# app-builder-lib's bundled Apple certs nor exports CSC_KEYCHAIN, and it
# would add a marketplace dependency on the release path for ~20 lines.
#
- # REMOVAL, once electron-builder >= 26.16.1 is pinned: delete this step
- # and its desktop-build.yml twin, restore CSC_LINK + CSC_KEY_PASSWORD on
- # both packager steps (desktop-build.yml in its signed-mode conditional
- # form), drop desktop-build.yml's "Remove signing keychain", and drop
- # the "macOS signing stays on the workflow-staged keychain" block in
- # release-cascade-shape.test.mjs. Keep "Attest the signed macOS app".
+ # REMOVAL, only after electron-builder >= 26.16.1 is pinned and a stable
+ # tag has been cut from a tree carrying that pin: delete this step and
+ # its desktop-build.yml twin; delete BOTH "Remove signing keychain"
+ # steps (this file's and desktop-build.yml's — the staging step is the
+ # only writer of CSC_KEYCHAIN, so both guards go dead); restore
+ # CSC_LINK + CSC_KEY_PASSWORD on both packager steps (desktop-build.yml
+ # in its signed-mode conditional form) and rewrite the "must NOT be set"
+ # notes on those two steps, which forbid exactly that restoration;
+ # rewrite both "Attest the signed macOS app" rationales, which state
+ # their reason for existing in terms of CSC_KEYCHAIN; and drop the
+ # "macOS signing stays on the workflow-staged keychain" block in
+ # release-cascade-shape.test.mjs. Keep the attestation steps themselves.
+ # Removal ends rescue-dispatch support for every older tag whose own
+ # lockfile still selects the buggy electron-builder release.
- name: Prepare signing keychain (CSC_KEYCHAIN)
env:
CSC_LINK: ${{ secrets.CSC_LINK }}
diff --git a/packages/cli/src/commands/removal-process-start.test.ts b/packages/cli/src/commands/removal-process-start.test.ts
index 88376ff92..51cae5cb0 100644
--- a/packages/cli/src/commands/removal-process-start.test.ts
+++ b/packages/cli/src/commands/removal-process-start.test.ts
@@ -40,7 +40,7 @@ describe('readRemovalProcessStart', () => {
'-NonInteractive',
expect.stringContaining('(Get-Process -Id 123).StartTime.ToUniversalTime()'),
]),
- expect.objectContaining({ timeout: 5000, windowsHide: true }),
+ expect.objectContaining({ timeout: 15_000, windowsHide: true }),
);
});
diff --git a/packages/cli/src/commands/removal-process-start.ts b/packages/cli/src/commands/removal-process-start.ts
index dbbaac882..f6e4caf13 100644
--- a/packages/cli/src/commands/removal-process-start.ts
+++ b/packages/cli/src/commands/removal-process-start.ts
@@ -20,7 +20,7 @@ export function readRemovalProcessStart(
const commandOptions: ExecFileSyncOptionsWithStringEncoding = {
encoding: 'utf8',
stdio: ['ignore', 'pipe', 'pipe'],
- timeout: 5000,
+ timeout: platform === 'win32' ? 15_000 : 5000,
windowsHide: true,
env: { ...env, LC_ALL: 'C', TZ: 'UTC0' },
};
diff --git a/packages/desktop/build/deb-postinst.sh b/packages/desktop/build/deb-postinst.sh
index bfa38244c..6176b0f93 100644
--- a/packages/desktop/build/deb-postinst.sh
+++ b/packages/desktop/build/deb-postinst.sh
@@ -1,6 +1,6 @@
#!/bin/bash
-# UPSTREAM([email protected]): FpmTarget runs this file through its macro
+# UPSTREAM([email protected]): FpmTarget runs this file through its macro
# templater before packaging, so every dollar-brace sequence is a macro and an
# unknown name throws at build time. Bash variables here use the $NAME form.
diff --git a/packages/desktop/build/deb-postrm.sh b/packages/desktop/build/deb-postrm.sh
index 147695444..665bc7b45 100644
--- a/packages/desktop/build/deb-postrm.sh
+++ b/packages/desktop/build/deb-postrm.sh
@@ -1,6 +1,6 @@
#!/bin/bash
-# UPSTREAM([email protected]): rpm runs the new package's %post BEFORE the
+# UPSTREAM([email protected]): rpm runs the new package's %post BEFORE the
# old package's %postun, so an unguarded teardown deletes the symlinks the
# upgrade just installed. $1 is an rpm instance count or a dpkg action word.
case "$1" in
diff --git a/packages/desktop/package.json b/packages/desktop/package.json
index 40e136b5c..660f8fcd8 100644
--- a/packages/desktop/package.json
+++ b/packages/desktop/package.json
@@ -61,7 +61,7 @@
"babel-plugin-react-compiler": "0.0.0-experimental-a8e64ef-20260402",
"culori": "^4.0.2",
"electron": "43.4.0",
- "electron-builder": "^26.9.0",
+ "electron-builder": "^26.16.1",
"electron-vite": "^6.0.0-beta.1",
"ts-morph": "^28.0.0",
"typescript": "~7.0.2",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
index 6cd8c6fc7..6c79707b4 100644
--- a/pnpm-lock.yaml
+++ b/pnpm-lock.yaml
@@ -1236,8 +1236,8 @@ importers:
specifier: 43.4.0
version: 43.4.0
electron-builder:
- specifier: ^26.9.0
- version: 26.15.3([email protected])
+ specifier: ^26.16.1
+ version: 26.16.1([email protected])
electron-vite:
specifier: ^6.0.0-beta.1
@@ -3483,6 +3483,10 @@ packages:
resolution: {integrity: sha512-V1JJ1WTRUqHHrOSh597hURcMqVKVGL/ea3kv0gSnEdsEZ0/+VyPghM1lMNGc00z7CIQorSvbKpuJkxvuHbvdbg==}
engines: {node: '>= 16'}
+ '@noble/[email protected]':
+ resolution: {integrity: sha512-jCs9ldd7NwzpgXDIf6P3+NrHh9/sD6CQdxHyjQI+h/6rDNo88ypBxxz45UDuZHz9r3tNz7N/VInSVoVdtXEI4A==}
+ engines: {node: ^14.21.3 || >=16}
+
resolution: {integrity: sha512-IYqDGiTXab6FniAgnSdZwgWbomxpy9FtYvLKs7wCUs2a8RkITG+DFGO1DM9cr+E3/RgADRpFjrKVaJ1z6sjtEg==}
engines: {node: '>= 20.19.0'}
@@ -6273,6 +6277,7 @@ packages:
'@xmldom/[email protected]':
resolution: {integrity: sha512-KRYzxepc14G/CEpEGc3Yn+JKaAeT63smlDr+vjB8jRfgTBBI9wRj/nkQEO+ucV8p8I9bfKLWp37uHgFrbntPvw==}
engines: {node: '>=10.0.0'}
+ deprecated: this version has critical issues, please update to the latest version
resolution: {integrity: sha512-jYcgT6xtVYhnhgxh3QgYDnnNMYTcf8ElbxxFzX0IZo+vabQqSPAjC3c1wJrKB5E19VwQei89QCiZZP86DCPF7g==}
@@ -6578,12 +6583,12 @@ packages:
resolution: {integrity: sha512-N6//FLET/tXYNM/F6ABca1oH6fWB+KlTt909Le28WMDBk8oaT4vY17DCrwg2MvmuqUKt3Ni4N5dGJ/EoBgcO6A==}
- resolution: {integrity: sha512-2VnyWkqsP5v5XbBhL3tD5Syx8iNPBYsoU7kY4S2fz7wg8Rj/nztWKCUzGKaFRTv0Xwf3/H058CR1Kvtd/3lRow==}
+ resolution: {integrity: sha512-FhaO6YOup01ZfQW0Z6gt3AyukJjv1gW4uFK47jTgwcHZKqyN/fSlK2LqPf9tAeZYLP2bRJLDzeOkRImsw2X4Pg==}
engines: {node: '>=14.0.0'}
peerDependencies:
- dmg-builder: 26.15.3
- electron-builder-squirrel-windows: 26.15.3
+ dmg-builder: 26.16.1
+ electron-builder-squirrel-windows: 26.16.1
resolution: {integrity: sha512-o5Roy6tNG4SL/FOkCAN6RzjiakZS25RLYFrcMttJqbdd8BWrnA+fGz57iN5Pb06pvBGvl5gQ0B48dJlslXvoTg==}
@@ -6833,8 +6838,8 @@ packages:
resolution: {integrity: sha512-g/kR520giAFYkSXTzcmF3kqQq7wi8F6N6SzeDgZrqTBN+VHdmgWOyTdD1yD7AATDId/yXLvuP34CxW46/BwCdw==}
engines: {node: '>=12.0.0'}
- resolution: {integrity: sha512-q2hn7Mbo2nFNkVekPiHFx6Nfo3hURmES3tfBn+k5Pqxl2RkmP3QGqZUhH/q9Pch/4G05NRhPjDlVj1O8q4Txvw==}
+ resolution: {integrity: sha512-RLyJhB7Si3YkzKR9ubQslWuXW3Vhs3CGe1i+SeixBZ0qTd1mk3XBmssvY22TlB6CS5blyko8Gu1JzpYk8UkYAg==}
engines: {node: '>=14.0.0'}
@@ -7573,8 +7578,8 @@ packages:
resolution: {integrity: sha512-WkrWp9GR4KXfKGYzOLmTuGVi1UWFfws377n9cc55/tb6DuqyF6pcQ5AbiHEshaDpY9v6oaSr2XCDidGmMwdzIA==}
engines: {node: '>=8'}
- resolution: {integrity: sha512-O3zJUFUYHJKgzPqioHxfxzBzlSC1eXCSr79gMSBKBP5AgjjpmrydMsMLotEg9fAJF36vdUncb+4ndRNxoPdlSQ==}
+ resolution: {integrity: sha512-pnI/3Qb24Uk+rMTgIUrsVUKosVgwmBUdF8Zeb8TexOSbpq8MWc7v6l+n+FrEqVkjNZwzBN+XpDS9ENgZ/rkWAw==}
resolution: {integrity: sha512-X7BJ2yElsnOJ30pZF4uIIDfBEVgF4XEBxL9Bxhy6dnrm5hkzqmsWHGTiHqRiITNhMyFLyAiWndIJP7Z1NTteDg==}
@@ -7625,16 +7630,16 @@ packages:
engines: {node: '>=0.10.0'}
hasBin: true
- resolution: {integrity: sha512-Jc19XPV9y9+2bAdZPkXuVNGNIEFBq9poHC61l8Kv6FdK7DRG3+Ic0rerC0DXOaeHNz8yW0fg/JnF8GQROOF5MA==}
+ resolution: {integrity: sha512-w0y44wSaT1l6R7CAGmeHn4nHPfvzDyCAU1xJyi1w9SbPYJpYn76SmHDzqHf8Y7l91cPWTdPYBpGQtB2T5mJ08A==}
- resolution: {integrity: sha512-a1KM5heqS3gQCZzizXEI8RjJy3QVogULPdeSknt76uLDpBIW/HDGsMg/XgP0riP6PI9COsRvFITKKGDqA8fJxA==}
+ resolution: {integrity: sha512-LrLK65QX5PUYYODXqp23FKrV7CILTtVY7mrJckNknO9jLNSMiqFkKbSMiDRw4CjOADMPVDdWLxY4mezOZWswxg==}
engines: {node: '>=14.0.0'}
hasBin: true
- resolution: {integrity: sha512-g/2bn8YTavY4cuS5F+jOS7zmZbXXBV8KZ8yHKfJjFPoKtzBqrpCdNPxBd3tqdBwP7BVd0lGzf7Bk2s0KesWZ4Q==}
+ resolution: {integrity: sha512-Vt3KzQIiw9BImvNOYtndg9Mjki+tl4+1sQiC/+G5j8khWaENOJFWodiB+sUl6yyHwtd37avehskdtPw7f8y/+Q==}
resolution: {integrity: sha512-cEto7aeOqBfU1D+c5py5pE+ooscKE75JifxLBdFUZsqAxRS6y7kebtxAZvICszSl05gPjYHDTjY+lXpyGvpJbg==}
@@ -14274,7 +14279,10 @@ snapshots:
'@noble/[email protected]': {}
- '@noble/[email protected]': {}
+ '@noble/[email protected]': {}
+
+ '@noble/[email protected]':
+ optional: true
'@nodable/[email protected]': {}
@@ -17035,7 +17043,7 @@ snapshots:
dependencies:
'@electron/asar': 3.4.1
'@electron/fuses': 1.8.0
@@ -17045,23 +17053,23 @@ snapshots:
'@electron/rebuild': 4.2.0
'@electron/universal': 2.0.3
'@malept/flatpak-bundler': 0.4.0
- '@noble/hashes': 2.2.0
+ '@noble/hashes': 1.8.0
'@peculiar/webcrypto': 1.7.1
'@types/fs-extra': 9.0.13
ajv: 8.20.0
asn1js: 3.0.10
async-exit-hook: 2.0.1
- builder-util: 26.15.3
+ builder-util: 26.16.0
builder-util-runtime: 9.7.0
chromium-pickle-js: 0.2.0
ci-info: 4.3.1
debug: 4.4.3
- dmg-builder: 26.15.3([email protected])
+ dmg-builder: 26.16.1([email protected])
dotenv: 16.6.1
dotenv-expand: 11.0.7
ejs: 3.1.10
- electron-builder-squirrel-windows: 26.15.3([email protected])
- electron-publish: 26.15.3
+ electron-builder-squirrel-windows: 26.16.1([email protected])
+ electron-publish: 26.16.0
fs-extra: 10.1.0
hosted-git-info: 4.1.0
isbinaryfile: 5.0.7
@@ -17316,7 +17324,7 @@ snapshots:
transitivePeerDependencies:
- supports-color
dependencies:
'@types/debug': 4.1.13
builder-util-runtime: 9.7.0
@@ -18024,10 +18032,10 @@ snapshots:
dependencies:
path-type: 4.0.0
dependencies:
- app-builder-lib: 26.15.3([email protected])([email protected])
- builder-util: 26.15.3
+ app-builder-lib: 26.16.1([email protected])([email protected])
+ builder-util: 26.16.0
fs-extra: 10.1.0
js-yaml: 4.3.1
transitivePeerDependencies:
@@ -18074,23 +18082,23 @@ snapshots:
dependencies:
jake: 10.9.4
dependencies:
- app-builder-lib: 26.15.3([email protected])([email protected])
- builder-util: 26.15.3
+ app-builder-lib: 26.16.1([email protected])([email protected])
+ builder-util: 26.16.0
electron-winstaller: 5.4.0
transitivePeerDependencies:
- dmg-builder
- supports-color
dependencies:
- app-builder-lib: 26.15.3([email protected])([email protected])
- builder-util: 26.15.3
+ app-builder-lib: 26.16.1([email protected])([email protected])
+ builder-util: 26.16.0
builder-util-runtime: 9.7.0
chalk: 4.1.2
ci-info: 4.4.0
- dmg-builder: 26.15.3([email protected])
+ dmg-builder: 26.16.1([email protected])
fs-extra: 10.1.0
lazy-val: 1.0.5
simple-update-notifier: 2.0.0
@@ -18099,11 +18107,11 @@ snapshots:
- electron-builder-squirrel-windows
- supports-color
dependencies:
'@types/fs-extra': 9.0.13
aws4: 1.13.2
- builder-util: 26.15.3
+ builder-util: 26.16.0
builder-util-runtime: 9.7.0
chalk: 4.1.2
form-data: 4.0.6
diff --git a/pnpm-workspace.yaml b/pnpm-workspace.yaml
index 0ae06fc08..aeff01c60 100644
--- a/pnpm-workspace.yaml
+++ b/pnpm-workspace.yaml
@@ -11,11 +11,20 @@ ignorePatchFailures: false
# (4320 = 3 days). Own-org packages (@inkeep/*) are exempt. This replaces the
# retired bunfig.toml posture (which expressed the same window in seconds:
# minimumReleaseAge = 259200). Emergency reproduction escape hatch (bypass the
-# cooldown for a single install): `pnpm install --config.minimum-release-age=0`.
+# cooldown for a single install): `pnpm install --config.minimumReleaseAge=0`.
minimumReleaseAge: 4320
minimumReleaseAgeExclude:
- '@inkeep/*'
- '@visimer/*'
+ # The four packages the electron-builder 26.16.1 train bumped; the keychain
+ # fix itself is in app-builder-lib and the others pin it exactly. Published
+ # 2026-09-07T18:24Z, so these stop having any effect at 2026-09-10T18:24Z
+ # (publish + minimumReleaseAge) — delete all four then. Version-qualified,
+ # so every later release stays gated.
# Dependency build scripts are blocked by default under pnpm; only these run.
# electron ships no install script of its own as of 43 — it fetches its platform