Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

Resolve doc-relative PDF media sources (#1887)

Dimitri POSTOLOV811aa2b3b43a
diff --git a/packages/app/src/editor/extensions/media-render-props.test.ts b/packages/app/src/editor/extensions/media-render-props.test.ts
index 40e97ca08..23c9763f8 100644
--- a/packages/app/src/editor/extensions/media-render-props.test.ts
+++ b/packages/app/src/editor/extensions/media-render-props.test.ts
@@ -68,4 +68,28 @@ describe('normalizeDocRelativeMediaRenderProps', () => {
normalizeDocRelativeMediaRenderProps('audio', { src: './song.mp3' }, 'notes/today'),
).toEqual({ src: '/notes/song.mp3' });
});
+
+ test('resolves relative PDF src against the current document directory', () => {
+ expect(
+ normalizeDocRelativeMediaRenderProps('Pdf', { src: './test.pdf' }, 'notes/today'),
+ ).toEqual({
+ src: '/notes/test.pdf',
+ });
+ expect(
+ normalizeDocRelativeMediaRenderProps('Pdf', { src: '../test.pdf' }, 'notes/archive/today'),
+ ).toEqual({ src: '/notes/test.pdf' });
+ });
+
+ test('resolves relative File src against the current document directory', () => {
+ expect(
+ normalizeDocRelativeMediaRenderProps('File', { src: './document.docx' }, 'notes/today'),
+ ).toEqual({ src: '/notes/document.docx' });
+ expect(
+ normalizeDocRelativeMediaRenderProps(
+ 'File',
+ { src: '../archive.zip' },
+ 'notes/archive/today',
+ ),
+ ).toEqual({ src: '/notes/archive.zip' });
+ });
});
diff --git a/packages/app/src/editor/extensions/media-render-props.ts b/packages/app/src/editor/extensions/media-render-props.ts
index 936385e3b..c0bbb6ada 100644
--- a/packages/app/src/editor/extensions/media-render-props.ts
+++ b/packages/app/src/editor/extensions/media-render-props.ts
@@ -1,6 +1,13 @@
import { normalizeDocRelativeAssetUrl } from '@inkeep/open-knowledge-core';
-const DOC_RELATIVE_SRC_COMPONENTS = new Set(['img', 'CommonMarkImage', 'video', 'audio']);
+const DOC_RELATIVE_SRC_COMPONENTS = new Set([
+ 'img',
+ 'CommonMarkImage',
+ 'video',
+ 'audio',
+ 'Pdf',
+ 'File',
+]);
export function normalizeDocRelativeMediaRenderProps(
descriptorName: string,