Skip to content

Beautiful, AI-native markdown IDE and LLM wiki

feat(open-knowledge): fade theme colors between palettes (#4374)

Andrew Mikofalvy81da98c00f28
diff --git a/.changeset/theme-color-transitions.md b/.changeset/theme-color-transitions.md
new file mode 100644
index 000000000..3d5470ca2
--- /dev/null
+++ b/.changeset/theme-color-transitions.md
@@ -0,0 +1,5 @@
+---
+"@inkeep/open-knowledge": patch
+---
+
+Theme changes now fade semantic app colors, terminal colors, and live HTML previews while preserving reduced-motion preferences and native window chrome settlement.
diff --git a/packages/app/package.json b/packages/app/package.json
index 72be0a09b..7f594cd74 100644
--- a/packages/app/package.json
+++ b/packages/app/package.json
@@ -29,7 +29,7 @@
"measure:stress": "bash scripts/measure-stress.sh",
"measure:sweep": "bash scripts/measure-sweep.sh",
"perf:compare": "bash scripts/perf-compare.sh",
- "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-collapse-spaced-folder.e2e.ts tests/stress/sidebar-file-list-fills.e2e.ts tests/stress/file-tree-sticky-collapse.e2e.ts tests/stress/file-tree-collapse-persistence.e2e.ts tests/stress/file-tree-fractional-zoom.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/lint-config-toggle.e2e.ts tests/stress/plugin-enable-notice.e2e.ts tests/stress/schema-edit-fields-view.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/navigation-history.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/new-item-shortcut-fast-path.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts tests/stress/tabs-component-strip.e2e.ts tests/stress/source-find-scroll.e2e.ts tests/stress/harness-app-warmth.e2e.ts tests/stress/qa-canary-authoring-both-modes.e2e.ts tests/stress/qa-canary-live-typing.e2e.ts tests/stress/keystroke-cadence-danger-space.e2e.ts tests/stress/jsx-unregistered-backspace-delete.e2e.ts tests/stress/jsx-unregistered-ime-concurrent.e2e.ts tests/stress/jsx-backspace-delete.e2e.ts tests/stress/link-authoring-bytes.e2e.ts tests/stress/link-authoring-apex.e2e.ts tests/stress/command-palette-parity.e2e.ts tests/stress/settings-search.e2e.ts tests/stress/okf-generated-index-settings.e2e.ts tests/stress/okf-recommended-skill-install.e2e.ts tests/stress/chip-popover-positioning.e2e.ts tests/stress/docs-open-scroll-restore.e2e.ts tests/stress/file-tree-decoration-chip-strip-repro.e2e.ts tests/stress/grip-click-nodeselect.e2e.ts tests/stress/jsx-halo-semantics.e2e.ts tests/stress/jsx-image-body-click.e2e.ts tests/stress/jsx-prop-panel-placeholder.e2e.ts tests/stress/jsx-range-encompass-halo.e2e.ts tests/stress/jsx-wildcard-convert.e2e.ts tests/stress/markdown-lint.e2e.ts tests/stress/frontmatter-schema-badge.e2e.ts tests/stress/frontmatter-glob-picker.e2e.ts tests/stress/unified-problems.e2e.ts tests/stress/mid-type-recovery.e2e.ts tests/stress/observer-a-multi-client.e2e.ts tests/stress/outline-toolbar-occlusion.e2e.ts tests/stress/selection-surface-pane-clip.e2e.ts tests/stress/quiet-tree-hidden-doc.e2e.ts tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts tests/stress/rename-noext-probe.e2e.ts tests/stress/show-ok-folders.e2e.ts tests/stress/source-polish.e2e.ts tests/stress/warm-skeleton-scroll-restore.e2e.ts tests/stress/props-toggle-scroll-preserve.e2e.ts tests/stress/yjs-no-dual-import.e2e.ts tests/stress/graph-panel-surfaces.e2e.ts tests/stress/asset-embed-real-fidelity.e2e.ts tests/stress/image-invalid-placeholder.e2e.ts tests/stress/local-target-audit.e2e.ts tests/stress/rename-content-preservation.e2e.ts tests/stress/rename-consolidation.e2e.ts tests/stress/outline-active-heading.e2e.ts tests/stress/outline-navigation.e2e.ts tests/stress/prd-7627-default-swatch.e2e.ts tests/stress/clipboard-dollar-math-source-fallback.e2e.ts tests/stress/source-mode-undo-keymap.e2e.ts tests/stress/source-undo-mode-flip.e2e.ts tests/stress/timeline-recovered-restore.e2e.ts tests/stress/blank-line-preservation.e2e.ts tests/stress/landing-helpers.e2e.ts tests/stress/agent-follow-scroll.e2e.ts tests/stress/mode-switch-landing.e2e.ts tests/stress/mode-switch-ordinal-divergence.e2e.ts tests/stress/comment-annotation-visibility.e2e.ts tests/stress/comment-opens-in-panel.e2e.ts tests/stress/qa-miles-edge-blanks.e2e.ts tests/stress/prop-upload.e2e.ts tests/stress/slash-command-auto-open.e2e.ts tests/stress/clipboard-relative-url-source-fallback.e2e.ts tests/stress/editor-split-view.e2e.ts tests/stress/language-load-failure.e2e.ts tests/stress/language-first-paint.e2e.ts tests/stress/user-text-direction.e2e.ts tests/stress/pseudolocale.e2e.ts tests/stress/language-picker.e2e.ts tests/stress/zh-hans-coverage-sweep.e2e.ts tests/stress/preview-tab-promotion.e2e.ts tests/stress/cv-paint-lock-click.e2e.ts tests/stress/cv-auto-paint-lock-click.e2e.ts tests/stress/history-traversal-preview-tab.e2e.ts tests/stress/tab-close-scroll-restore.e2e.ts tests/stress/skills-sidebar-open.e2e.ts tests/stress/trailing-affordance.e2e.ts tests/stress/text-doc-composer-inset.e2e.ts tests/stress/agents-settings-accessible-names.e2e.ts tests/stress/composer-growth-eof-reveal.e2e.ts",
+ "test:e2e": "playwright test tests/stress/ux-interactions.e2e.ts tests/stress/file-tree-create.e2e.ts tests/stress/file-tree-drag-to-root.e2e.ts tests/stress/file-tree-deselect-to-root.e2e.ts tests/stress/file-tree-collapse-spaced-folder.e2e.ts tests/stress/sidebar-file-list-fills.e2e.ts tests/stress/file-tree-sticky-collapse.e2e.ts tests/stress/file-tree-collapse-persistence.e2e.ts tests/stress/file-tree-fractional-zoom.e2e.ts tests/stress/create-then-rename-editable.e2e.ts tests/stress/find-replace.e2e.ts tests/stress/editor-tabs.e2e.ts tests/stress/crdt-stress.e2e.ts tests/stress/slash-command.e2e.ts tests/stress/paste-fidelity.e2e.ts tests/stress/fr-7a-disconnect-source-mode.e2e.ts tests/stress/docs-open.e2e.ts tests/stress/frozen-table-headers.e2e.ts tests/stress/asset-embed.e2e.ts tests/stress/asset-embed-advanced.e2e.ts tests/stress/asset-click-dispatch.e2e.ts tests/stress/handoff.e2e.ts tests/stress/multi-agent-presence.e2e.ts tests/stress/editor-mode-persistence.e2e.ts tests/stress/lint-config-toggle.e2e.ts tests/stress/plugin-enable-notice.e2e.ts tests/stress/schema-edit-fields-view.e2e.ts tests/stress/sidebar-search-pill.e2e.ts tests/stress/navigation-history.e2e.ts tests/stress/command-palette-semantic.e2e.ts tests/stress/agent-activity-panel.e2e.ts tests/stress/drop-pipeline-auto-open.e2e.ts tests/stress/command-palette-flicker.e2e.ts tests/stress/cm6-list-hanging-indent.e2e.ts tests/stress/ng7-rapid-nav-coherence.e2e.ts tests/stress/reveal-on-activate.e2e.ts tests/stress/selection-indicator.e2e.ts tests/stress/new-file-cross-doc-bleed.e2e.ts tests/stress/new-item-shortcut-fast-path.e2e.ts tests/stress/editor-mode-flip-cross-doc-bleed.e2e.ts tests/stress/editor-area-viewport-resize.e2e.ts tests/stress/qa-sidebar-responsive.e2e.ts tests/stress/prd-6955-reassertion-repro.e2e.ts tests/stress/prd-6955-reassertion-wedge.e2e.ts tests/stress/prd-6914-repro.e2e.ts tests/stress/showall-lazy-tree.e2e.ts tests/stress/tabs-component-strip.e2e.ts tests/stress/source-find-scroll.e2e.ts tests/stress/harness-app-warmth.e2e.ts tests/stress/qa-canary-authoring-both-modes.e2e.ts tests/stress/qa-canary-live-typing.e2e.ts tests/stress/keystroke-cadence-danger-space.e2e.ts tests/stress/jsx-unregistered-backspace-delete.e2e.ts tests/stress/jsx-unregistered-ime-concurrent.e2e.ts tests/stress/jsx-backspace-delete.e2e.ts tests/stress/link-authoring-bytes.e2e.ts tests/stress/link-authoring-apex.e2e.ts tests/stress/command-palette-parity.e2e.ts tests/stress/settings-search.e2e.ts tests/stress/okf-generated-index-settings.e2e.ts tests/stress/okf-recommended-skill-install.e2e.ts tests/stress/chip-popover-positioning.e2e.ts tests/stress/docs-open-scroll-restore.e2e.ts tests/stress/file-tree-decoration-chip-strip-repro.e2e.ts tests/stress/grip-click-nodeselect.e2e.ts tests/stress/jsx-halo-semantics.e2e.ts tests/stress/jsx-image-body-click.e2e.ts tests/stress/jsx-prop-panel-placeholder.e2e.ts tests/stress/jsx-range-encompass-halo.e2e.ts tests/stress/jsx-wildcard-convert.e2e.ts tests/stress/markdown-lint.e2e.ts tests/stress/frontmatter-schema-badge.e2e.ts tests/stress/frontmatter-glob-picker.e2e.ts tests/stress/unified-problems.e2e.ts tests/stress/mid-type-recovery.e2e.ts tests/stress/observer-a-multi-client.e2e.ts tests/stress/outline-toolbar-occlusion.e2e.ts tests/stress/selection-surface-pane-clip.e2e.ts tests/stress/quiet-tree-hidden-doc.e2e.ts tests/stress/raw-mdx-fallback-onblur-upgrade.e2e.ts tests/stress/rename-noext-probe.e2e.ts tests/stress/show-ok-folders.e2e.ts tests/stress/source-polish.e2e.ts tests/stress/warm-skeleton-scroll-restore.e2e.ts tests/stress/props-toggle-scroll-preserve.e2e.ts tests/stress/yjs-no-dual-import.e2e.ts tests/stress/graph-panel-surfaces.e2e.ts tests/stress/asset-embed-real-fidelity.e2e.ts tests/stress/image-invalid-placeholder.e2e.ts tests/stress/local-target-audit.e2e.ts tests/stress/rename-content-preservation.e2e.ts tests/stress/rename-consolidation.e2e.ts tests/stress/outline-active-heading.e2e.ts tests/stress/outline-navigation.e2e.ts tests/stress/prd-7627-default-swatch.e2e.ts tests/stress/clipboard-dollar-math-source-fallback.e2e.ts tests/stress/source-mode-undo-keymap.e2e.ts tests/stress/source-undo-mode-flip.e2e.ts tests/stress/timeline-recovered-restore.e2e.ts tests/stress/blank-line-preservation.e2e.ts tests/stress/landing-helpers.e2e.ts tests/stress/agent-follow-scroll.e2e.ts tests/stress/mode-switch-landing.e2e.ts tests/stress/mode-switch-ordinal-divergence.e2e.ts tests/stress/comment-annotation-visibility.e2e.ts tests/stress/comment-opens-in-panel.e2e.ts tests/stress/qa-miles-edge-blanks.e2e.ts tests/stress/prop-upload.e2e.ts tests/stress/slash-command-auto-open.e2e.ts tests/stress/clipboard-relative-url-source-fallback.e2e.ts tests/stress/editor-split-view.e2e.ts tests/stress/language-load-failure.e2e.ts tests/stress/language-first-paint.e2e.ts tests/stress/user-text-direction.e2e.ts tests/stress/pseudolocale.e2e.ts tests/stress/language-picker.e2e.ts tests/stress/zh-hans-coverage-sweep.e2e.ts tests/stress/preview-tab-promotion.e2e.ts tests/stress/cv-paint-lock-click.e2e.ts tests/stress/cv-auto-paint-lock-click.e2e.ts tests/stress/history-traversal-preview-tab.e2e.ts tests/stress/tab-close-scroll-restore.e2e.ts tests/stress/skills-sidebar-open.e2e.ts tests/stress/trailing-affordance.e2e.ts tests/stress/text-doc-composer-inset.e2e.ts tests/stress/agents-settings-accessible-names.e2e.ts tests/stress/composer-growth-eof-reveal.e2e.ts tests/stress/theme-fade.e2e.ts tests/stress/theme-color-conversion.e2e.ts",
"test:e2e:install-browsers": "playwright install chromium webkit firefox",
"test:visual": "playwright test --config playwright.visual.config.ts",
"test:visual:update": "playwright test --config playwright.visual.config.ts --update-snapshots",
diff --git a/packages/app/src/App.tsx b/packages/app/src/App.tsx
index d2fc60ee2..82453aefc 100644
--- a/packages/app/src/App.tsx
+++ b/packages/app/src/App.tsx
@@ -512,10 +512,10 @@ function NewItemShortcutHandler() {
}
function ConfigProviderHost({ children }: { children: ReactNode }) {
- const { collabUrl } = useDocumentContext();
+ const { collabUrl, collabTerminal } = useDocumentContext();
useServerKeepalive(collabUrl);
return (
- <ConfigProvider collabUrl={collabUrl}>
+ <ConfigProvider collabUrl={collabUrl} collabTerminal={collabTerminal}>
<EditorLifecycleFlush />
<BackgroundThrottleReporter />
{children}
diff --git a/packages/app/src/comments/anchor-layers.test.ts b/packages/app/src/comments/anchor-layers.test.ts
index f88aebf02..f1441aa97 100644
--- a/packages/app/src/comments/anchor-layers.test.ts
+++ b/packages/app/src/comments/anchor-layers.test.ts
@@ -1,17 +1,23 @@
import { describe, expect, it } from 'vitest';
-import { buildAnchorSegments, COMMENT_HUE, type PlacedAnchor } from './anchor-layers';
+import { buildAnchorSegments, commentColor, type PlacedAnchor } from './anchor-layers';
const at = (id: string | null, from: number, to: number): PlacedAnchor => ({ id, from, to });
-const ACTIVE_FILL = `rgba(${COMMENT_HUE},0.45)`;
+const ACTIVE_FILL = commentColor(0.45);
const RESTING =
- `border-radius:2px;padding-bottom:1px;cursor:pointer;background-color:rgba(${COMMENT_HUE},0.22);` +
- `box-shadow:inset 0 -2px 0 rgba(${COMMENT_HUE},0.7);`;
+ `border-radius:2px;padding-bottom:1px;cursor:pointer;background-color:${commentColor(0.22)};` +
+ `box-shadow:inset 0 -2px 0 ${commentColor(0.7)};`;
const ACTIVE =
`border-radius:2px;padding-bottom:1px;cursor:pointer;background-color:${ACTIVE_FILL};` +
- `box-shadow:inset 0 -2px 0 rgba(${COMMENT_HUE},1);`;
+ `box-shadow:inset 0 -2px 0 ${commentColor(1)};`;
describe('buildAnchorSegments', () => {
+ it('mixes comment opacity in sRGB to preserve the contrast contract', () => {
+ expect(commentColor(0.7)).toBe(
+ 'color-mix(in srgb,var(--ok-comment-hue, rgb(37 99 235)) 70%,transparent)',
+ );
+ });
+
it('leaves a lone unattended highlight on its original style', () => {
expect(buildAnchorSegments([at('t1', 4, 12)])).toEqual([
{ from: 4, to: 12, threadId: 't1', style: RESTING },
diff --git a/packages/app/src/comments/anchor-layers.ts b/packages/app/src/comments/anchor-layers.ts
index b713886ac..62ca42306 100644
--- a/packages/app/src/comments/anchor-layers.ts
+++ b/packages/app/src/comments/anchor-layers.ts
@@ -11,8 +11,7 @@ export interface AnchorSegment {
threadId: string | null;
}
-export const COMMENT_HUE = 'var(--ok-comment-hue,37,99,235)';
-const HUE = COMMENT_HUE;
+const COMMENT_HUE = 'var(--ok-comment-hue, rgb(37 99 235))';
const RESTING = { fill: 0.22, line: 0.7 };
@@ -20,15 +19,18 @@ const ACTIVE = { fill: 0.45, line: 1 };
export const COMMENT_ACTIVE_FILL = 0.45;
+export function commentColor(alpha: number): string {
+ return `color-mix(in srgb,${COMMENT_HUE} ${alpha * 100}%,transparent)`;
+}
+
function style(anchor: PlacedAnchor, active: boolean): string {
- const hue = HUE;
const { fill, line } = active ? ACTIVE : RESTING;
return [
'border-radius:2px',
'padding-bottom:1px',
...(anchor.id === null ? [] : ['cursor:pointer']),
- `background-color:rgba(${hue},${fill})`,
- `box-shadow:inset 0 -2px 0 rgba(${hue},${line})`,
+ `background-color:${commentColor(fill)}`,
+ `box-shadow:inset 0 -2px 0 ${commentColor(line)}`,
'',
].join(';');
}
diff --git a/packages/app/src/comments/comment-hue-contrast.test.ts b/packages/app/src/comments/comment-hue-contrast.test.ts
index d1c50a7a0..47c997f27 100644
--- a/packages/app/src/comments/comment-hue-contrast.test.ts
+++ b/packages/app/src/comments/comment-hue-contrast.test.ts
@@ -1,7 +1,7 @@
import { readFileSync } from 'node:fs';
import { dirname, resolve } from 'node:path';
import { fileURLToPath } from 'node:url';
-import { describe, expect, test } from 'vitest';
+import { assert, describe, expect, test } from 'vitest';
const GLOBALS_CSS = resolve(dirname(fileURLToPath(import.meta.url)), '../globals.css');
@@ -41,7 +41,9 @@ function declarations(name: string): string[] {
}
function hue(declaration: string): number[] {
- const parts = declaration.split(',').map((p) => Number(p.trim()));
+ const match = /^rgb\((.+)\)$/.exec(declaration);
+ assert(match, 'Expected an rgb color declaration');
+ const parts = match[1].split(/\s+/).map(Number);
expect(parts).toHaveLength(3);
for (const part of parts) expect(Number.isFinite(part)).toBe(true);
return parts;
diff --git a/packages/app/src/comments/property-row-rect.ts b/packages/app/src/comments/property-row-rect.ts
index 92cacd1bf..aae71f9e9 100644
--- a/packages/app/src/comments/property-row-rect.ts
+++ b/packages/app/src/comments/property-row-rect.ts
@@ -1,4 +1,4 @@
-import { COMMENT_ACTIVE_FILL, COMMENT_HUE } from './anchor-layers';
+import { COMMENT_ACTIVE_FILL, commentColor } from './anchor-layers';
const REVEAL_ATTR = 'data-comment-reveal';
@@ -67,7 +67,7 @@ export function locateInValue(
}
function paintRevealSelection(control: HTMLTextAreaElement | HTMLInputElement): void {
- control.style.setProperty('--comment-reveal-fill', `rgba(${COMMENT_HUE},${COMMENT_ACTIVE_FILL})`);
+ control.style.setProperty('--comment-reveal-fill', commentColor(COMMENT_ACTIVE_FILL));
control.setAttribute(REVEAL_ATTR, 'true');
const clear = () => {
control.removeAttribute(REVEAL_ATTR);
diff --git a/packages/app/src/components/NavigatorApp.tsx b/packages/app/src/components/NavigatorApp.tsx
index a5b993958..11d6cd58d 100644
--- a/packages/app/src/components/NavigatorApp.tsx
+++ b/packages/app/src/components/NavigatorApp.tsx
@@ -24,6 +24,7 @@ import {
import { subscribeLocalMenuAction } from '@/lib/local-menu-action-bus';
import { seedClient } from '@/lib/seed-client';
import { createCloneController } from '@/lib/share/clone-controller';
+import { useThemeColorTransitions } from '@/lib/theme-color-transitions';
import { ipcAuthQueryTransport } from '@/lib/transports/auth-query-transport';
import { ipcAuthTransport } from '@/lib/transports/auth-transport';
import { ipcCloneTransport } from '@/lib/transports/clone-transport';
@@ -93,6 +94,7 @@ export function NavigatorApp({ bridge }: { bridge: OkDesktopBridge }) {
const { theme: themeValue } = useTheme();
const { t } = useLingui();
+ useThemeColorTransitions(true);
useThemeBridge(bridge, themeValue ?? 'system');
useApplyConfigLanguage({
diff --git a/packages/app/src/components/TerminalWindowApp.config-provider.dom.test.tsx b/packages/app/src/components/TerminalWindowApp.config-provider.dom.test.tsx
index d6b4edaaa..21f7c2583 100644
--- a/packages/app/src/components/TerminalWindowApp.config-provider.dom.test.tsx
+++ b/packages/app/src/components/TerminalWindowApp.config-provider.dom.test.tsx
@@ -1,8 +1,9 @@
-import { cleanup, render, screen } from '@testing-library/react';
+import { act, cleanup, render, screen } from '@testing-library/react';
import { afterEach, describe, expect, test, vi } from 'vitest';
import { TooltipProvider } from '@/components/ui/tooltip';
import { useConfigContext } from '@/lib/config-provider';
import type { OkDesktopBridge } from '@/lib/desktop-bridge-types';
+import { TRANSITION_ATTRIBUTE, TRANSITION_STYLE_ID } from '@/lib/theme-color-transitions';
vi.doMock('@tanstack/react-query', () => ({
useQuery: () => ({ data: undefined, isLoading: false, isError: false }),
@@ -39,6 +40,24 @@ function bridgeWithCollabUrl(collabUrl: string): OkDesktopBridge {
describe('TerminalWindowApp ConfigProvider wiring', () => {
afterEach(() => {
cleanup();
+ vi.unstubAllGlobals();
+ document.documentElement.removeAttribute(TRANSITION_ATTRIBUTE);
+ document.getElementById(TRANSITION_STYLE_ID)?.remove();
+ });
+
+ test('arms theme colors through its provider in a project-less window', async () => {
+ const registerProperty = vi.fn();
+ vi.stubGlobal('CSS', { registerProperty });
+ render(
+ <TooltipProvider>
+ <TerminalWindowApp bridge={bridgeWithCollabUrl('')} />
+ </TooltipProvider>,
+ );
+ await act(async () => {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(registerProperty).toHaveBeenCalled();
+ expect(document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(true);
});
test('provides ConfigProvider context to its terminal subtree (project-less / empty collabUrl)', () => {
diff --git a/packages/app/src/components/TerminalWindowApp.tsx b/packages/app/src/components/TerminalWindowApp.tsx
index 6fe453389..6217a6e9d 100644
--- a/packages/app/src/components/TerminalWindowApp.tsx
+++ b/packages/app/src/components/TerminalWindowApp.tsx
@@ -14,7 +14,7 @@ interface TerminalWindowAppProps {
export function TerminalWindowApp({ bridge }: TerminalWindowAppProps) {
const collabUrl = bridge.config.collabUrl ? bridge.config.collabUrl : null;
return (
- <ConfigProvider collabUrl={collabUrl}>
+ <ConfigProvider collabUrl={collabUrl} collabTerminal={collabUrl === null}>
<TerminalWindowBody bridge={bridge} />
{}
<ReportBugMenuTrigger systemWide={collabUrl === null} />
diff --git a/packages/app/src/components/terminal-theme.dom.test.ts b/packages/app/src/components/terminal-theme.dom.test.ts
index 2592e8898..5065ebf70 100644
--- a/packages/app/src/components/terminal-theme.dom.test.ts
+++ b/packages/app/src/components/terminal-theme.dom.test.ts
@@ -1,5 +1,5 @@
import { afterEach, describe, expect, it, vi } from 'vitest';
-import { computeLiveXtermTheme } from './terminal-theme';
+import { computeLiveXtermTheme, liveTokenReaderForEpoch } from './terminal-theme';
describe('computeLiveXtermTheme default token reader', () => {
afterEach(() => {
@@ -28,4 +28,30 @@ describe('computeLiveXtermTheme default token reader', () => {
computeLiveXtermTheme('dark');
expect(spansInBody()).toBe(0);
});
+
+ it('shares one token read across terminal consumers in a frame', async () => {
+ let reads = 0;
+ const real = window.getComputedStyle.bind(window);
+ vi.spyOn(window, 'getComputedStyle').mockImplementation(((el: Element) => {
+ reads += 1;
+ return real(el);
+ }) as typeof window.getComputedStyle);
+
+ const reader = liveTokenReaderForEpoch(10_001);
+ computeLiveXtermTheme('dark', reader);
+ const readsForEpoch = reads;
+ computeLiveXtermTheme('dark', liveTokenReaderForEpoch(10_001));
+
+ expect(readsForEpoch).toBeGreaterThan(0);
+ expect(reads).toBe(readsForEpoch);
+ const paletteStyle = document.createElement('style');
+ document.head.appendChild(paletteStyle);
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ paletteStyle.remove();
+ computeLiveXtermTheme('dark', liveTokenReaderForEpoch(10_001));
+ expect(reads).toBeGreaterThan(readsForEpoch);
+ const readsAfterFrame = reads;
+ computeLiveXtermTheme('dark', liveTokenReaderForEpoch(10_002));
+ expect(reads).toBeGreaterThan(readsAfterFrame);
+ });
});
diff --git a/packages/app/src/components/terminal-theme.ts b/packages/app/src/components/terminal-theme.ts
index 8ccc6c1cc..da6e3fae7 100644
--- a/packages/app/src/components/terminal-theme.ts
+++ b/packages/app/src/components/terminal-theme.ts
@@ -1,5 +1,6 @@
import type { AnsiSlotName } from '@inkeep/open-knowledge-core';
import type { ITheme } from '@xterm/xterm';
+import { cssColorToHex } from '@/lib/css-color-to-hex';
export const XTERM_DARK_THEME = {
background: '#171717',
@@ -58,7 +59,7 @@ export type TokenColorReader = (token: string) => string | null;
function normalizeProbedColor(resolved: string | undefined): string | null {
if (!resolved || resolved === 'rgba(0, 0, 0, 0)' || resolved === 'transparent') return null;
if (resolved.includes('var(')) return null;
- return resolved;
+ return cssColorToHex(resolved, { alpha: true });
}
function readTokenColors(tokens: readonly string[]): Map<string, string | null> {
@@ -115,6 +116,23 @@ function createBatchedTokenReader(): TokenColorReader {
return (token) => batch.get(token) ?? null;
}
+let cachedEpoch = -1;
+let cachedTokenReader: TokenColorReader | null = null;
+
+export function liveTokenReaderForEpoch(epoch: number): TokenColorReader {
+ if (cachedEpoch !== epoch || cachedTokenReader === null) {
+ cachedEpoch = epoch;
+ cachedTokenReader = createBatchedTokenReader();
+ if (typeof requestAnimationFrame === 'function') {
+ requestAnimationFrame(() => {
+ cachedEpoch = -1;
+ cachedTokenReader = null;
+ });
+ }
+ }
+ return cachedTokenReader;
+}
+
export function computeLiveXtermTheme(
resolvedTheme: string | undefined,
readToken: TokenColorReader = createBatchedTokenReader(),
diff --git a/packages/app/src/components/use-live-xterm-theme.ts b/packages/app/src/components/use-live-xterm-theme.ts
index a8f3cf224..720b86b24 100644
--- a/packages/app/src/components/use-live-xterm-theme.ts
+++ b/packages/app/src/components/use-live-xterm-theme.ts
@@ -1,7 +1,7 @@
import type { ITheme } from '@xterm/xterm';
import { useEffect, useState } from 'react';
-import { COLOR_THEME_ATTRIBUTE } from '@/lib/use-apply-config-color-theme';
-import { computeLiveXtermTheme } from './terminal-theme';
+import { useColorThemeEpoch } from '@/lib/color-theme-epoch';
+import { computeLiveXtermTheme, liveTokenReaderForEpoch } from './terminal-theme';
function themesEqual(a: ITheme, b: ITheme): boolean {
const keys = new Set([...Object.keys(a), ...Object.keys(b)] as (keyof ITheme)[]);
@@ -10,36 +10,15 @@ function themesEqual(a: ITheme, b: ITheme): boolean {
}
export function useLiveXtermTheme(resolvedTheme: string | undefined): ITheme {
- const [theme, setTheme] = useState<ITheme>(() => computeLiveXtermTheme(resolvedTheme));
+ const epoch = useColorThemeEpoch();
+ const [theme, setTheme] = useState<ITheme>(() =>
+ computeLiveXtermTheme(resolvedTheme, liveTokenReaderForEpoch(epoch)),
+ );
useEffect(() => {
- const recompute = () => {
- const next = computeLiveXtermTheme(resolvedTheme);
- setTheme((prev) => (themesEqual(prev, next) ? prev : next));
- };
- recompute();
- let scheduled = 0;
- const schedule =
- typeof requestAnimationFrame === 'function'
- ? () => {
- if (scheduled) return;
- scheduled = requestAnimationFrame(() => {
- scheduled = 0;
- recompute();
- });
- }
- : recompute;
- const observer = new MutationObserver(schedule);
- observer.observe(document.documentElement, {
- attributes: true,
- attributeFilter: [COLOR_THEME_ATTRIBUTE, 'class'],
- });
- observer.observe(document.head, { childList: true, subtree: true, characterData: true });
- return () => {
- if (scheduled) cancelAnimationFrame(scheduled);
- observer.disconnect();
- };
- }, [resolvedTheme]);
+ const next = computeLiveXtermTheme(resolvedTheme, liveTokenReaderForEpoch(epoch));
+ setTheme((prev) => (themesEqual(prev, next) ? prev : next));
+ }, [epoch, resolvedTheme]);
return theme;
}
diff --git a/packages/app/src/editor/extensions/CodeBlockView.tsx b/packages/app/src/editor/extensions/CodeBlockView.tsx
index 625a3f4f7..292625f36 100644
--- a/packages/app/src/editor/extensions/CodeBlockView.tsx
+++ b/packages/app/src/editor/extensions/CodeBlockView.tsx
@@ -31,7 +31,7 @@ import {
import { Input } from '@/components/ui/input';
import { Popover, PopoverContent, PopoverTrigger } from '@/components/ui/popover';
import { useIsEmbedded } from '@/hooks/use-is-embedded';
-import { useColorThemeEpoch } from '@/lib/color-theme-epoch';
+import { subscribeColorThemeEpoch } from '@/lib/color-theme-epoch';
import { cn } from '@/lib/utils';
import { OPT_OUT_ATTR } from '../clipboard/index.ts';
import { CodePreviewEditModal } from '../components/CodePreviewEditModal';
@@ -105,7 +105,6 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
const { resolvedTheme } = useTheme();
const appTheme: PreviewTheme =
resolvedTheme === 'dark' || resolvedTheme === 'light' ? resolvedTheme : readAppTheme();
- const colorThemeEpoch = useColorThemeEpoch();
const [bakedTheme] = useState<PreviewTheme>(readAppTheme);
const rawLanguage = (node.attrs.language as string | null) ?? null;
const rawMeta = (node.attrs.meta as string | null) ?? null;
@@ -155,10 +154,14 @@ export function CodeBlockView({ node, updateAttributes, editor, getPos, selected
const editable = editor.isEditable;
const cursorInside = useCursorInside(editor, getPos);
- // biome-ignore lint/correctness/useExhaustiveDependencies: colorThemeEpoch is a signal-only dependency — its bump re-runs this effect so the live iframe re-reads the palette's tokens; it is intentionally not referenced in the body.
useEffect(() => {
- previewFrameRef.current?.contentWindow?.postMessage(buildPreviewThemeMessage(appTheme), '*');
- }, [appTheme, colorThemeEpoch]);
+ if (!previewActive) return;
+ const postTheme = () => {
+ previewFrameRef.current?.contentWindow?.postMessage(buildPreviewThemeMessage(appTheme), '*');
+ };
+ postTheme();
+ return subscribeColorThemeEpoch(postTheme);
+ }, [appTheme, previewActive]);
useEffect(() => {
function onMessage(e: MessageEvent) {
diff --git a/packages/app/src/editor/extensions/preview-live-tokens.test.ts b/packages/app/src/editor/extensions/preview-live-tokens.test.ts
index b3e2d7036..bfd8a585e 100644
--- a/packages/app/src/editor/extensions/preview-live-tokens.test.ts
+++ b/packages/app/src/editor/extensions/preview-live-tokens.test.ts
@@ -25,6 +25,15 @@ describe('readLivePreviewTokens', () => {
expect(tokens?.['--background']).toBe('#282a36');
});
+ test('forwards default-theme values while a root transition is active', () => {
+ const tokens = readLivePreviewTokens({
+ paletteActive: false,
+ transitionActive: true,
+ readToken: (name) => (name === '--background' ? 'oklab(0.4 0 0)' : null),
+ });
+ expect(tokens?.['--background']).toBe('oklab(0.4 0 0)');
+ });
+
test('forwards tokens beyond the baked snapshot set', () => {
const tokens = readLivePreviewTokens(withPalette({ '--syntax-string': '#50fa7b' }));
expect(tokens?.['--syntax-string']).toBe('#50fa7b');
diff --git a/packages/app/src/editor/extensions/preview-live-tokens.ts b/packages/app/src/editor/extensions/preview-live-tokens.ts
index 465fbc394..d17e155d8 100644
--- a/packages/app/src/editor/extensions/preview-live-tokens.ts
+++ b/packages/app/src/editor/extensions/preview-live-tokens.ts
@@ -1,32 +1,15 @@
import { PREVIEW_THEME_TOKENS } from '@inkeep/open-knowledge-core';
+import { THEME_COLOR_PROPERTIES } from '@/lib/theme-color-properties';
+import { themeColorTransitionsActive } from '@/lib/theme-color-transitions';
import { COLOR_THEME_ATTRIBUTE } from '@/lib/use-apply-config-color-theme';
-const EXTRA_PREVIEW_TOKENS = [
- '--popover',
- '--popover-foreground',
- '--secondary',
- '--secondary-foreground',
- '--muted',
- '--accent',
- '--accent-foreground',
- '--input',
- '--ring',
- '--selection-soft',
- '--syntax-keyword',
- '--syntax-string',
- '--syntax-number',
- '--syntax-comment',
- '--syntax-func',
- '--syntax-bg',
-] as const;
-
const PREVIEW_FORWARDED_TOKENS: readonly string[] = [
- ...PREVIEW_THEME_TOKENS.map((token) => token.name),
- ...EXTRA_PREVIEW_TOKENS,
+ ...new Set([...PREVIEW_THEME_TOKENS.map((token) => token.name), ...THEME_COLOR_PROPERTIES]),
];
export interface PreviewTokenEnv {
paletteActive: boolean;
+ transitionActive?: boolean;
readToken: (name: string) => string | null;
}
@@ -35,6 +18,7 @@ export function domPreviewTokenEnv(): PreviewTokenEnv | null {
const root = document.documentElement;
return {
paletteActive: root.hasAttribute(COLOR_THEME_ATTRIBUTE),
+ transitionActive: themeColorTransitionsActive(document),
readToken: (name) => {
try {
return getComputedStyle(root).getPropertyValue(name).trim() || null;
@@ -49,7 +33,7 @@ export function readLivePreviewTokens(
env: PreviewTokenEnv | null = domPreviewTokenEnv(),
): Record<string, string> | null {
if (!env) return null;
- if (!env.paletteActive) return {};
+ if (!env.paletteActive && !env.transitionActive) return {};
const out: Record<string, string> = {};
for (const name of PREVIEW_FORWARDED_TOKENS) {
const value = env.readToken(name);
diff --git a/packages/app/src/globals.css b/packages/app/src/globals.css
index 1815b0d8c..8b1655b2e 100644
--- a/packages/app/src/globals.css
+++ b/packages/app/src/globals.css
@@ -3287,15 +3287,15 @@ button:active:not(:disabled) {
* override would introduce a sibling `--selection` token at higher alpha
* for body prose. */
--selection-soft: oklch(0.66 0.18 259 / 0.18);
- /* Comment-highlight hue, as `r,g,b` for interpolation into `rgba()` by the
- anchor decorations (`comments/anchor-layers.ts`) and the property-value
+ /* Comment-highlight hue, as a color for interpolation by the anchor
+ decorations (`comments/anchor-layers.ts`) and the property-value
`::selection` twin. It lives here rather than in TS because it is the one
part of the mark that must differ per theme: the decoration paints the same
alpha ladder on both canvases, so a single hue cannot clear the 3:1 non-text
floor at both ends — blue-600 does it on white, and washes out to 2.4:1 on
the dark canvas. Dark takes blue-400. Gated by comment-hue-contrast.test.ts;
the Tailwind mirrors on the rail marker and thread card are hand-kept. */
- --ok-comment-hue: 37, 99, 235;
+ --ok-comment-hue: rgb(37 99 235);
/* Categorical chart palette for `html preview` embeds — five
perceptually-distinct hues aligned with the callout color system
(--chart-1 anchors to the brand azure, the rest track the
@@ -3417,7 +3417,7 @@ button:active:not(:disabled) {
--selection-soft: oklch(0.72 0.16 259 / 0.32);
/* Dark-canvas comment hue — blue-400. See the :root declaration for why this
is the one token in the mark that has to move with the theme. */
- --ok-comment-hue: 96, 165, 250;
+ --ok-comment-hue: rgb(96 165 250);
/* Dark-mode chart palette — same hue family as the :root block above,
lightness lifted for legibility on the dark --background. Keep in sync
with :root --chart-* and PREVIEW_THEME_TOKENS (preview-theme-tokens.test.ts). */
diff --git a/packages/app/src/hooks/use-theme-bridge.dom.test.tsx b/packages/app/src/hooks/use-theme-bridge.dom.test.tsx
index 95f0e3398..5606287a1 100644
--- a/packages/app/src/hooks/use-theme-bridge.dom.test.tsx
+++ b/packages/app/src/hooks/use-theme-bridge.dom.test.tsx
@@ -252,11 +252,11 @@ describe('useThemeBridge (Tier-3 mount)', () => {
await waitFor(
() => {
expect(stubBridge.setThemeSourceCalls.length).toBe(2);
+ expect(stubBridge.signalThemeAppliedCalls.length).toBe(2);
},
{ timeout: ASYNC_EFFECT_TIMEOUT_MS },
);
expect(stubBridge.setThemeSourceCalls[1]).toBe('dark');
- expect(stubBridge.signalThemeAppliedCalls.length).toBe(2);
});
test('reports chrome as hex even when the token is authored in a syntax Electron cannot parse', async () => {
@@ -321,6 +321,40 @@ describe('useThemeBridge (Tier-3 mount)', () => {
);
});
+ test('waits for the final transition sample without rerendering its owner', async () => {
+ let active = true;
+ let renders = 0;
+ const getAnimations = document.documentElement.getAnimations;
+ document.documentElement.getAnimations = () =>
+ active ? ([{ transitionProperty: '--background' }] as unknown as Animation[]) : [];
+ const stubBridge = makeStubBridge();
+ function Owner() {
+ renders += 1;
+ useThemeBridge(stubBridge as unknown as OkDesktopBridge, 'dark');
+ return null;
+ }
+ const view = render(<Owner />);
+ try {
+ await act(async () => {
+ await Promise.resolve();
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(stubBridge.signalThemeAppliedCalls).toHaveLength(0);
+ const rendersBeforeSettlement = renders;
+ active = false;
+ await waitFor(() => expect(stubBridge.signalThemeAppliedCalls).toHaveLength(1));
+ expect(renders).toBe(rendersBeforeSettlement);
+ await act(async () => {
+ document.head.appendChild(document.createElement('style')).remove();
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(stubBridge.signalThemeAppliedCalls).toHaveLength(1);
+ } finally {
+ view.unmount();
+ document.documentElement.getAnimations = getAnimations;
+ }
+ });
+
test('rejection path: signalThemeApplied still fires via .finally so the show-gate releases', async () => {
const rejectionError = new Error('ipc-teardown: setThemeSource bridge unreachable');
const stubBridge = makeRejectingBridge(rejectionError);
@@ -380,4 +414,39 @@ describe('useThemeBridge (Tier-3 mount)', () => {
media.restore();
}
});
+
+ test('coalesces reduced-transparency changes until the theme fade settles', async () => {
+ const media = installControllableMatchMedia(false);
+ let active = false;
+ const getAnimations = document.documentElement.getAnimations;
+ document.documentElement.getAnimations = () =>
+ active ? ([{ transitionProperty: '--background' }] as unknown as Animation[]) : [];
+ const stubBridge = makeStubBridge();
+ const view = render(
+ <HookProbe bridge={stubBridge as unknown as OkDesktopBridge} themeValue="dark" />,
+ );
+ try {
+ await waitFor(() => expect(stubBridge.signalThemeAppliedCalls).toHaveLength(1));
+ await act(async () => {
+ active = true;
+ const event = new Event('transitionrun');
+ Object.defineProperty(event, 'propertyName', { value: '--background' });
+ document.documentElement.dispatchEvent(event);
+ media.dispatchChange(true);
+ media.dispatchChange(false);
+ media.dispatchChange(true);
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(stubBridge.signalThemeAppliedCalls).toHaveLength(1);
+ active = false;
+ await waitFor(() => expect(stubBridge.signalThemeAppliedCalls).toHaveLength(2));
+ expect(stubBridge.signalThemeAppliedCalls.at(-1)).toEqual({ reducedTransparency: true });
+ media.dispatchChange(true);
+ expect(stubBridge.signalThemeAppliedCalls).toHaveLength(2);
+ } finally {
+ view.unmount();
+ document.documentElement.getAnimations = getAnimations;
+ media.restore();
+ }
+ });
});
diff --git a/packages/app/src/hooks/use-theme-bridge.test.ts b/packages/app/src/hooks/use-theme-bridge.test.ts
index 1d6f20912..1ae90f4db 100644
--- a/packages/app/src/hooks/use-theme-bridge.test.ts
+++ b/packages/app/src/hooks/use-theme-bridge.test.ts
@@ -1,5 +1,4 @@
import { describe, expect, test } from 'vitest';
-import { cssColorToHex } from './use-theme-bridge';
describe('useThemeBridge — module surface', () => {
test('exports the useThemeBridge hook', async () => {
@@ -7,34 +6,3 @@ describe('useThemeBridge — module surface', () => {
expect(typeof mod.useThemeBridge).toBe('function');
});
});
-
-describe('cssColorToHex', () => {
- test('converts legacy rgb / rgba to hex', () => {
- expect(cssColorToHex('rgb(250, 250, 250)')).toBe('#fafafa');
- expect(cssColorToHex('rgb(23, 23, 23)')).toBe('#171717');
- expect(cssColorToHex('rgba(250, 250, 250, 0.5)')).toBe('#fafafa');
- expect(cssColorToHex('rgb(250 250 250)')).toBe('#fafafa');
- });
-
- test('never derives a hex from a non-rgb color syntax', () => {
- for (const value of [
- 'oklch(0.985 0 0)',
- 'oklch(0.145 0 0)',
- 'color(srgb 0.98 0.98 0.98)',
- 'lab(97 0 0)',
- 'color-mix(in srgb, red, blue)',
- ]) {
- const hex = cssColorToHex(value);
- expect(hex === null || /^#[0-9a-f]{6}$/.test(hex), `${value} -> ${hex}`).toBe(true);
- expect(hex).not.toBe('#010000');
- }
- });
-
- test('rejects values that are not colors at all', () => {
- expect(cssColorToHex('')).toBeNull();
- expect(cssColorToHex('var(--sidebar)')).toBeNull();
- expect(cssColorToHex('not a color')).toBeNull();
- expect(cssColorToHex('rgb(300, 0, 0)')).toBeNull();
- expect(cssColorToHex('rgb(1, 2)')).toBeNull();
- });
-});
diff --git a/packages/app/src/hooks/use-theme-bridge.ts b/packages/app/src/hooks/use-theme-bridge.ts
index 1d7f0c589..7f99d0e7e 100644
--- a/packages/app/src/hooks/use-theme-bridge.ts
+++ b/packages/app/src/hooks/use-theme-bridge.ts
@@ -1,36 +1,8 @@
import { useEffect } from 'react';
+import { subscribeColorThemeEpoch } from '@/lib/color-theme-epoch';
+import { cssColorToHex } from '@/lib/css-color-to-hex';
import type { OkDesktopBridge } from '@/lib/desktop-bridge-types';
-
-function rgbToHex(value: string): string | null {
- const body = /^rgba?\(([^)]*)\)$/i.exec(value.trim())?.[1];
- if (body === undefined) return null;
- const parts = body.split(/[\s,/]+/).filter(Boolean);
- if (parts.length < 3) return null;
- let hex = '#';
- for (let i = 0; i < 3; i++) {
- const n = Math.round(Number(parts[i]));
- if (!Number.isFinite(n) || n < 0 || n > 255) return null;
- hex += n.toString(16).padStart(2, '0');
- }
- return hex;
-}
-
-function canvasHex(value: string): string | null {
- if (typeof document === 'undefined') return null;
- const ctx = document.createElement('canvas').getContext('2d');
- if (!ctx) return null;
- ctx.fillStyle = '#000000';
- ctx.fillStyle = value;
- const first = ctx.fillStyle;
- ctx.fillStyle = '#ffffff';
- ctx.fillStyle = value;
- if (ctx.fillStyle !== first) return null;
- return typeof first === 'string' && /^#[0-9a-f]{6}$/i.test(first) ? first.toLowerCase() : null;
-}
-
-export function cssColorToHex(value: string): string | null {
- return canvasHex(value) ?? rgbToHex(value);
-}
+import { themeColorTransitionsActive } from '@/lib/theme-color-transitions';
function resolveTokenHex(token: string): string | null {
const probe = document.createElement('span');
@@ -63,11 +35,27 @@ export function useThemeBridge(
themeValue: string | undefined,
colorThemeKey?: string,
): void {
- // biome-ignore lint/correctness/useExhaustiveDependencies: colorThemeKey is a signal-only dependency — a palette switch (e.g. Dracula -> Monokai, both dark) must re-run this effect to re-read + re-report chrome even though themeValue is unchanged; it is intentionally not referenced in the body.
+ // biome-ignore lint/correctness/useExhaustiveDependencies: colorThemeKey requests a fresh settled report for same-mode palette changes
useEffect(() => {
if (themeValue !== 'light' && themeValue !== 'dark' && themeValue !== 'system') return;
if (!bridge) return;
let cancelled = false;
+ let applied = false;
+ let reported: string | undefined;
+ const mql = window.matchMedia('(prefers-reduced-transparency: reduce)');
+ const signalSettledTheme = () => {
+ if (cancelled || !applied || themeColorTransitionsActive()) return;
+ const payload = {
+ reducedTransparency: mql.matches,
+ chrome: readChromeColors(),
+ };
+ const signature = JSON.stringify(payload);
+ if (signature === reported) return;
+ bridge.signalThemeApplied(payload);
+ reported = signature;
+ };
+ const unsubscribe = subscribeColorThemeEpoch(signalSettledTheme);
+ mql.addEventListener('change', signalSettledTheme);
bridge
.setThemeSource(themeValue)
.catch((err: unknown) => {
@@ -81,28 +69,13 @@ export function useThemeBridge(
})
.finally(() => {
if (cancelled) return;
- const reducedTransparency = window.matchMedia(
- '(prefers-reduced-transparency: reduce)',
- ).matches;
- bridge.signalThemeApplied({ reducedTransparency, chrome: readChromeColors() });
+ applied = true;
+ signalSettledTheme();
});
return () => {
cancelled = true;
+ unsubscribe();
+ mql.removeEventListener('change', signalSettledTheme);
};
- }, [bridge, themeValue, colorThemeKey]);
-
- useEffect(() => {
- if (!bridge) return;
- const mql = window.matchMedia('(prefers-reduced-transparency: reduce)');
- const handler = (event: MediaQueryListEvent) => {
- bridge.signalThemeApplied({
- reducedTransparency: event.matches,
- chrome: readChromeColors(),
- });
- };
- mql.addEventListener('change', handler);
- return () => {
- mql.removeEventListener('change', handler);
- };
- }, [bridge]);
+ }, [bridge, colorThemeKey, themeValue]);
}
diff --git a/packages/app/src/lib/color-theme-epoch.dom.test.tsx b/packages/app/src/lib/color-theme-epoch.dom.test.tsx
index 11f3fe906..bc37c7e12 100644
--- a/packages/app/src/lib/color-theme-epoch.dom.test.tsx
+++ b/packages/app/src/lib/color-theme-epoch.dom.test.tsx
@@ -1,6 +1,6 @@
import { act, cleanup, render } from '@testing-library/react';
import { afterEach, describe, expect, test } from 'vitest';
-import { useColorThemeEpoch } from './color-theme-epoch';
+import { subscribeColorThemeEpoch, useColorThemeEpoch } from './color-theme-epoch';
function Probe() {
const epoch = useColorThemeEpoch();
@@ -15,6 +15,7 @@ async function setColorThemeAndFlush(value: string): Promise<void> {
await act(async () => {
document.documentElement.setAttribute('data-color-theme', value);
await new Promise((resolve) => setTimeout(resolve, 0));
+ await new Promise((resolve) => requestAnimationFrame(resolve));
});
}
@@ -41,4 +42,55 @@ describe('useColorThemeEpoch', () => {
await setColorThemeAndFlush('monokai');
expect(epochOf(second)).toBeGreaterThan(before);
});
+
+ test('ignores descendant transition events', async () => {
+ const view = render(<Probe />);
+ const before = epochOf(view);
+ const child = document.createElement('div');
+ document.body.appendChild(child);
+ const event = new Event('transitionrun', { bubbles: true });
+ Object.defineProperty(event, 'propertyName', { value: '--background' });
+
+ await act(async () => {
+ child.dispatchEvent(event);
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+
+ expect(epochOf(view)).toBe(before);
+ child.remove();
+ });
+
+ test('samples active fades and their final frame, then stops on settlement or unsubscribe', async () => {
+ const originalGetAnimations = document.documentElement.getAnimations;
+ let active = true;
+ document.documentElement.getAnimations = () =>
+ active ? ([{ transitionProperty: '--background' }] as unknown as Animation[]) : [];
+ let samples = 0;
+ const unsubscribe = subscribeColorThemeEpoch(() => {
+ samples += 1;
+ });
+ const nextFrame = () => new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ try {
+ await nextFrame();
+ const first = samples;
+ await nextFrame();
+ expect(samples).toBeGreaterThan(first);
+ active = false;
+ const beforeSettlement = samples;
+ await nextFrame();
+ expect(samples).toBe(beforeSettlement + 1);
+ await nextFrame();
+ expect(samples).toBe(beforeSettlement + 1);
+ active = true;
+ const event = new Event('transitionrun');
+ Object.defineProperty(event, 'propertyName', { value: '--background' });
+ document.documentElement.dispatchEvent(event);
+ unsubscribe();
+ await nextFrame();
+ expect(samples).toBe(beforeSettlement + 1);
+ } finally {
+ unsubscribe();
+ document.documentElement.getAnimations = originalGetAnimations;
+ }
+ });
});
diff --git a/packages/app/src/lib/color-theme-epoch.ts b/packages/app/src/lib/color-theme-epoch.ts
index f4b0c45de..ecf6fc89d 100644
--- a/packages/app/src/lib/color-theme-epoch.ts
+++ b/packages/app/src/lib/color-theme-epoch.ts
@@ -1,30 +1,60 @@
import { useSyncExternalStore } from 'react';
+import { isThemeColorProperty } from './theme-color-properties';
+import { themeColorTransitionsActive } from './theme-color-transitions';
import { COLOR_THEME_ATTRIBUTE } from './use-apply-config-color-theme';
let epoch = 0;
const listeners = new Set<() => void>();
let observer: MutationObserver | null = null;
+let frame = 0;
function notify(): void {
epoch += 1;
for (const listener of listeners) listener();
}
-function subscribe(listener: () => void): () => void {
+function scheduleSample(): void {
+ if (frame || typeof requestAnimationFrame !== 'function') {
+ if (typeof requestAnimationFrame !== 'function') notify();
+ return;
+ }
+ frame = requestAnimationFrame(() => {
+ frame = 0;
+ notify();
+ if (themeColorTransitionsActive()) scheduleSample();
+ });
+}
+
+function onTransition(event: TransitionEvent): void {
+ if (event.target !== document.documentElement) return;
+ if (!isThemeColorProperty(event.propertyName)) return;
+ scheduleSample();
+}
+
+export function subscribeColorThemeEpoch(listener: () => void): () => void {
listeners.add(listener);
if (!observer && typeof document !== 'undefined') {
- observer = new MutationObserver(notify);
+ observer = new MutationObserver(scheduleSample);
observer.observe(document.documentElement, {
attributes: true,
attributeFilter: [COLOR_THEME_ATTRIBUTE, 'class'],
});
observer.observe(document.head, { childList: true, subtree: true, characterData: true });
+ document.documentElement.addEventListener('transitionrun', onTransition);
+ document.documentElement.addEventListener('transitionend', onTransition);
+ document.documentElement.addEventListener('transitioncancel', onTransition);
+ if (themeColorTransitionsActive()) scheduleSample();
}
return () => {
listeners.delete(listener);
if (listeners.size === 0) {
observer?.disconnect();
observer = null;
+ document.documentElement.removeEventListener('transitionrun', onTransition);
+ document.documentElement.removeEventListener('transitionend', onTransition);
+ document.documentElement.removeEventListener('transitioncancel', onTransition);
+ if (frame) cancelAnimationFrame(frame);
+ frame = 0;
}
};
}
@@ -38,5 +68,5 @@ function getServerSnapshot(): number {
}
export function useColorThemeEpoch(): number {
- return useSyncExternalStore(subscribe, getSnapshot, getServerSnapshot);
+ return useSyncExternalStore(subscribeColorThemeEpoch, getSnapshot, getServerSnapshot);
}
diff --git a/packages/app/src/lib/config-provider.dom.test.tsx b/packages/app/src/lib/config-provider.dom.test.tsx
index 1e379ba80..48a540239 100644
--- a/packages/app/src/lib/config-provider.dom.test.tsx
+++ b/packages/app/src/lib/config-provider.dom.test.tsx
@@ -7,6 +7,9 @@ vi.doMock('@/hooks/use-theme-bridge', () => ({
useThemeBridge: () => {},
}));
+const useThemeColorTransitions = vi.fn();
+vi.doMock('./theme-color-transitions', () => ({ useThemeColorTransitions }));
+
const { ConfigProvider, useConfigContext } = await import('./config-provider');
const EXPECTED_NULL_KEYS = [
@@ -39,6 +42,23 @@ function Consumer() {
describe('ConfigProvider runtime (Tier-3)', () => {
afterEach(() => {
cleanup();
+ vi.unstubAllGlobals();
+ useThemeColorTransitions.mockClear();
+ });
+
+ test('arms color transitions only once collaboration resolution has settled', () => {
+ const view = render(
+ <ConfigProvider collabUrl={null}>
+ <Consumer />
+ </ConfigProvider>,
+ );
+ expect(useThemeColorTransitions).toHaveBeenLastCalledWith(false);
+ view.rerender(
+ <ConfigProvider collabUrl={null} collabTerminal>
+ <Consumer />
+ </ConfigProvider>,
+ );
+ expect(useThemeColorTransitions).toHaveBeenLastCalledWith(true);
});
test('propagates the all-null value when collabUrl is null (cold-start window)', () => {
diff --git a/packages/app/src/lib/config-provider.theme-readiness.dom.test.tsx b/packages/app/src/lib/config-provider.theme-readiness.dom.test.tsx
new file mode 100644
index 000000000..874d32fcb
--- /dev/null
+++ b/packages/app/src/lib/config-provider.theme-readiness.dom.test.tsx
@@ -0,0 +1,36 @@
+import { act, cleanup, render } from '@testing-library/react';
+import { afterEach, expect, test, vi } from 'vitest';
+import { ConfigProvider } from './config-provider';
+import { TRANSITION_ATTRIBUTE, TRANSITION_STYLE_ID } from './theme-color-transitions';
+
+afterEach(() => {
+ cleanup();
+ vi.unstubAllGlobals();
+ document.documentElement.removeAttribute(TRANSITION_ATTRIBUTE);
+ document.getElementById(TRANSITION_STYLE_ID)?.remove();
+});
+
+test('registers and arms colors only after pending collaboration resolution settles', async () => {
+ const registerProperty = vi.fn();
+ vi.stubGlobal('CSS', { registerProperty });
+ const view = render(
+ <ConfigProvider collabUrl={null}>
+ <span>Pending</span>
+ </ConfigProvider>,
+ );
+ await act(async () => {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(registerProperty).not.toHaveBeenCalled();
+ expect(document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(false);
+ view.rerender(
+ <ConfigProvider collabUrl={null} collabTerminal>
+ <span>Offline</span>
+ </ConfigProvider>,
+ );
+ await act(async () => {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+ expect(registerProperty).toHaveBeenCalled();
+ expect(document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(true);
+});
diff --git a/packages/app/src/lib/config-provider.tsx b/packages/app/src/lib/config-provider.tsx
index eb9aecec3..76aa21875 100644
--- a/packages/app/src/lib/config-provider.tsx
+++ b/packages/app/src/lib/config-provider.tsx
@@ -28,6 +28,7 @@ import {
import { ConfigContext, type ConfigContextValue } from './config-context';
import { SavedThemesProvider, useSavedThemes } from './saved-themes-client';
import { useServerInstanceId } from './server-instance-store';
+import { useThemeColorTransitions } from './theme-color-transitions';
import { useApplyConfigColorTheme } from './use-apply-config-color-theme';
import { useApplyConfigLanguage } from './use-apply-config-language';
import { useApplyConfigTheme } from './use-apply-config-theme';
@@ -111,9 +112,11 @@ function makeOkignoreBinding(collabUrl: string, serverInstanceId: string | null)
function ConfigProviderBody({
collabUrl,
+ collabTerminal = false,
children,
}: {
collabUrl: string | null;
+ collabTerminal?: boolean;
children: ReactNode;
}) {
const { themes, loaded: savedThemesLoaded, loadError: savedThemesLoadError } = useSavedThemes();
@@ -281,6 +284,7 @@ function ConfigProviderBody({
enabled: colorThemeEnabled,
ready: colorThemeReady,
});
+ useThemeColorTransitions((collabUrl !== null || collabTerminal) && colorThemeReady);
useApplyConfigLanguage({
preference: merged?.appearance?.language,
userConfigSynced: userState?.synced ?? false,
@@ -331,7 +335,11 @@ function ConfigProviderBody({
return <ConfigContext value={value}>{children}</ConfigContext>;
}
-export function ConfigProvider(props: { collabUrl: string | null; children: ReactNode }) {
+export function ConfigProvider(props: {
+ collabUrl: string | null;
+ collabTerminal?: boolean;
+ children: ReactNode;
+}) {
return (
<SavedThemesProvider>
<ConfigProviderBody {...props} />
diff --git a/packages/app/src/lib/css-color-to-hex.dom.test.ts b/packages/app/src/lib/css-color-to-hex.dom.test.ts
new file mode 100644
index 000000000..47eb1d79e
--- /dev/null
+++ b/packages/app/src/lib/css-color-to-hex.dom.test.ts
@@ -0,0 +1,53 @@
+import { afterEach, expect, test, vi } from 'vitest';
+
+afterEach(() => {
+ vi.unstubAllGlobals();
+ vi.restoreAllMocks();
+});
+
+test('recreates a failed canvas and reports distinct failures without repeating each frame', async () => {
+ vi.resetModules();
+ const { cssColorToHex } = await import('./css-color-to-hex');
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined);
+ const getImageData = vi
+ .fn()
+ .mockImplementationOnce(() => {
+ throw new Error('canvas unavailable');
+ })
+ .mockImplementationOnce(() => {
+ throw new Error('canvas unavailable');
+ })
+ .mockImplementationOnce(() => {
+ throw new Error('readback denied');
+ })
+ .mockReturnValueOnce({ data: new Uint8ClampedArray([255, 255, 255, 255]) })
+ .mockImplementationOnce(() => {
+ throw new Error('readback denied');
+ })
+ .mockReturnValue({ data: new Uint8ClampedArray([255, 255, 255, 255]) });
+ const createElement = vi.fn(() => ({
+ width: 0,
+ height: 0,
+ getContext: () => ({
+ fillStyle: '',
+ clearRect: vi.fn(),
+ fillRect: vi.fn(),
+ getImageData,
+ }),
+ }));
+ vi.stubGlobal('document', { createElement });
+
+ const value = 'oklch(1 0 0)';
+ expect(cssColorToHex(value)).toBeNull();
+ expect(cssColorToHex(value)).toBeNull();
+ expect(cssColorToHex(value)).toBeNull();
+ expect(cssColorToHex(value)).toBe('#ffffff');
+ expect(cssColorToHex(value)).toBeNull();
+ expect(cssColorToHex(value)).toBe('#ffffff');
+ expect(createElement).toHaveBeenCalledTimes(5);
+ expect(warn.mock.calls).toEqual(
+ ['canvas unavailable', 'readback denied', 'readback denied'].map((error) => [
+ JSON.stringify({ event: 'css-color-to-hex-canvas-failed', error, value }),
+ ]),
+ );
+});
diff --git a/packages/app/src/lib/css-color-to-hex.test.ts b/packages/app/src/lib/css-color-to-hex.test.ts
new file mode 100644
index 000000000..0d73869e6
--- /dev/null
+++ b/packages/app/src/lib/css-color-to-hex.test.ts
@@ -0,0 +1,39 @@
+import { describe, expect, test } from 'vitest';
+import { cssColorToHex } from './css-color-to-hex';
+
+describe('cssColorToHex Node RGB fallback', () => {
+ test('preserves translucent selection colors for xterm', () => {
+ expect(cssColorToHex('rgba(80, 120, 255, 0.18)', { alpha: true })).toBe('#5078ff2e');
+ expect(cssColorToHex('rgb(80, 120, 255)', { alpha: true })).toBe('#5078ffff');
+ expect(cssColorToHex('rgba(80, 120, 255, 0)', { alpha: true })).toBe('#5078ff00');
+ });
+
+ test('keeps native chrome colors opaque', () => {
+ expect(cssColorToHex('rgba(80, 120, 255, 0.18)')).toBe('#5078ff');
+ });
+
+ test('converts legacy rgb and rgba values without losing their channels', () => {
+ expect(cssColorToHex('rgb(250, 250, 250)')).toBe('#fafafa');
+ expect(cssColorToHex('rgb(23, 23, 23)')).toBe('#171717');
+ expect(cssColorToHex('rgba(250, 250, 250, 0.5)')).toBe('#fafafa');
+ expect(cssColorToHex('rgb(250 250 250)')).toBe('#fafafa');
+ });
+
+ test('leaves CSS Color 4 conversion to the browser canvas', () => {
+ for (const value of [
+ 'oklch(0.985 0 0)',
+ 'oklch(0.145 0 0)',
+ 'color(srgb 0.98 0.98 0.98)',
+ 'lab(97 0 0)',
+ 'color-mix(in srgb, red, blue)',
+ ]) {
+ expect(cssColorToHex(value)).toBeNull();
+ }
+ });
+
+ test('returns null for values the numeric RGB fallback cannot parse', () => {
+ for (const value of ['', 'var(--sidebar)', 'not a color', 'rgb(300, 0, 0)', 'rgb(1, 2)']) {
+ expect(cssColorToHex(value)).toBeNull();
+ }
+ });
+});
diff --git a/packages/app/src/lib/css-color-to-hex.ts b/packages/app/src/lib/css-color-to-hex.ts
new file mode 100644
index 000000000..a82540ccc
--- /dev/null
+++ b/packages/app/src/lib/css-color-to-hex.ts
@@ -0,0 +1,68 @@
+function rgbToHex(value: string, includeAlpha: boolean): string | null {
+ const body = /^rgba?\(([^)]*)\)$/i.exec(value.trim())?.[1];
+ if (body === undefined) return null;
+ const parts = body.split(/[\s,/]+/).filter(Boolean);
+ if (parts.length < 3) return null;
+ let hex = '#';
+ for (let i = 0; i < 3; i++) {
+ const n = Math.round(Number(parts[i]));
+ if (!Number.isFinite(n) || n < 0 || n > 255) return null;
+ hex += n.toString(16).padStart(2, '0');
+ }
+ if (includeAlpha) {
+ const alpha = parts[3] === undefined ? 1 : Number(parts[3]);
+ if (!Number.isFinite(alpha) || alpha < 0 || alpha > 1) return null;
+ hex += Math.round(alpha * 255)
+ .toString(16)
+ .padStart(2, '0');
+ }
+ return hex;
+}
+
+let colorContext: CanvasRenderingContext2D | null = null;
+let lastCanvasFailure: string | null = null;
+
+function canvasHex(value: string, includeAlpha: boolean): string | null {
+ if (typeof document === 'undefined') return null;
+ try {
+ if (!colorContext) {
+ const canvas = document.createElement('canvas');
+ canvas.width = 1;
+ canvas.height = 1;
+ colorContext = canvas.getContext('2d', { willReadFrequently: true });
+ }
+ const ctx = colorContext;
+ if (!ctx) return null;
+ ctx.fillStyle = '#010203';
+ ctx.fillStyle = value;
+ const firstAccepted = ctx.fillStyle !== '#010203';
+ ctx.fillStyle = '#fefdfc';
+ ctx.fillStyle = value;
+ if (!firstAccepted && ctx.fillStyle === '#fefdfc') return null;
+ ctx.clearRect(0, 0, 1, 1);
+ ctx.fillStyle = value;
+ ctx.fillRect(0, 0, 1, 1);
+ const channels = ctx.getImageData(0, 0, 1, 1).data.slice(0, includeAlpha ? 4 : 3);
+ lastCanvasFailure = null;
+ return `#${Array.from(channels, (channel) => channel.toString(16).padStart(2, '0')).join('')}`;
+ } catch (error) {
+ colorContext = null;
+ const message = error instanceof Error ? error.message : String(error);
+ if (lastCanvasFailure !== message) {
+ lastCanvasFailure = message;
+ console.warn(
+ JSON.stringify({
+ event: 'css-color-to-hex-canvas-failed',
+ error: message,
+ value,
+ }),
+ );
+ }
+ return null;
+ }
+}
+
+export function cssColorToHex(value: string, options: { alpha?: boolean } = {}): string | null {
+ const includeAlpha = options.alpha ?? false;
+ return rgbToHex(value, includeAlpha) ?? canvasHex(value, includeAlpha);
+}
diff --git a/packages/app/src/lib/theme-color-properties.ts b/packages/app/src/lib/theme-color-properties.ts
new file mode 100644
index 000000000..c55b1d33c
--- /dev/null
+++ b/packages/app/src/lib/theme-color-properties.ts
@@ -0,0 +1,20 @@
+import { base16ToTokens, PREVIEW_THEME_TOKENS } from '@inkeep/open-knowledge-core';
+import { DEFAULT_CUSTOM_SCHEME } from './color-themes';
+
+const PALETTE_THEME_COLOR_PROPERTIES = Object.keys(base16ToTokens(DEFAULT_CUSTOM_SCHEME)).map(
+ (name) => `--${name}`,
+);
+
+export const THEME_COLOR_PROPERTIES: readonly string[] = [
+ ...new Set([
+ ...PREVIEW_THEME_TOKENS.filter((token) => token.name !== '--radius').map((token) => token.name),
+ ...PALETTE_THEME_COLOR_PROPERTIES,
+ '--ok-comment-hue',
+ ]),
+];
+
+const themeColorPropertySet = new Set(THEME_COLOR_PROPERTIES);
+
+export function isThemeColorProperty(name: string): boolean {
+ return themeColorPropertySet.has(name);
+}
diff --git a/packages/app/src/lib/theme-color-transitions.dom.test.tsx b/packages/app/src/lib/theme-color-transitions.dom.test.tsx
new file mode 100644
index 000000000..7a0d9ca9f
--- /dev/null
+++ b/packages/app/src/lib/theme-color-transitions.dom.test.tsx
@@ -0,0 +1,243 @@
+import { act, cleanup, render } from '@testing-library/react';
+import { afterEach, beforeEach, describe, expect, test, vi } from 'vitest';
+import { THEME_COLOR_PROPERTIES } from './theme-color-properties';
+import {
+ TRANSITION_ATTRIBUTE,
+ TRANSITION_FADING_ATTRIBUTE,
+ TRANSITION_STYLE_ID,
+} from './theme-color-transitions';
+
+let armThemeColorTransitions: typeof import('./theme-color-transitions').armThemeColorTransitions;
+let useThemeColorTransitions: typeof import('./theme-color-transitions').useThemeColorTransitions;
+
+function activeRootFade(document: Document): void {
+ Object.defineProperty(document.documentElement, 'getAnimations', {
+ value: () => [{ transitionProperty: '--background' }],
+ });
+}
+
+describe('theme color transitions', () => {
+ beforeEach(async () => {
+ vi.resetModules();
+ const transitions = await import('./theme-color-transitions');
+ armThemeColorTransitions = transitions.armThemeColorTransitions;
+ useThemeColorTransitions = transitions.useThemeColorTransitions;
+ });
+
+ afterEach(() => {
+ cleanup();
+ vi.restoreAllMocks();
+ vi.unstubAllGlobals();
+ document.documentElement.removeAttribute(TRANSITION_ATTRIBUTE);
+ document.documentElement.removeAttribute(TRANSITION_FADING_ATTRIBUTE);
+ document.documentElement.removeAttribute('data-color-theme');
+ document.getElementById(TRANSITION_STYLE_ID)?.remove();
+ });
+
+ test('leaves the document instant when typed property registration is unavailable', () => {
+ vi.stubGlobal('CSS', {});
+
+ const alternateDocument = document.implementation.createHTMLDocument();
+
+ expect(armThemeColorTransitions(alternateDocument)).toBe(false);
+ expect(alternateDocument.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(false);
+ expect(alternateDocument.getElementById(TRANSITION_STYLE_ID)).toBeNull();
+ });
+
+ test('reports a registration failure from the animation frame', async () => {
+ const warn = vi.spyOn(console, 'warn').mockImplementation(() => undefined);
+ vi.stubGlobal('CSS', {
+ registerProperty: () => {
+ throw new DOMException('invalid syntax', 'SyntaxError');
+ },
+ });
+
+ function ReadyProbe() {
+ useThemeColorTransitions(true);
+ return null;
+ }
+
+ render(<ReadyProbe />);
+ await act(async () => {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+
+ expect(warn).toHaveBeenCalledWith(
+ JSON.stringify({
+ event: 'theme-color-transitions-arm-failed',
+ error: 'SyntaxError: invalid syntax',
+ }),
+ );
+ });
+
+ test('arms every semantic token only after readiness', async () => {
+ const registerProperty = vi.fn();
+ vi.stubGlobal('CSS', { registerProperty });
+
+ function ReadyProbe({ ready }: { ready: boolean }) {
+ useThemeColorTransitions(ready);
+ return null;
+ }
+
+ const view = render(<ReadyProbe ready={false} />);
+ expect(registerProperty).not.toHaveBeenCalled();
+ expect(document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(false);
+
+ view.rerender(<ReadyProbe ready />);
+ expect(registerProperty).not.toHaveBeenCalled();
+
+ await act(async () => {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ });
+
+ expect(registerProperty).toHaveBeenCalledTimes(THEME_COLOR_PROPERTIES.length);
+ expect(THEME_COLOR_PROPERTIES).not.toContain('--radius');
+ expect(document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(true);
+ expect(document.getElementById(TRANSITION_STYLE_ID)?.textContent).toContain(
+ '--ansi-bright-white 200ms ease-out',
+ );
+ expect(document.getElementById(TRANSITION_STYLE_ID)?.textContent).toContain(
+ '--sidebar-primary 200ms ease-out',
+ );
+ });
+
+ test('accepts duplicate typed property registration after a module reload', () => {
+ const registerProperty = vi.fn(() => {
+ throw new DOMException('already registered', 'InvalidModificationError');
+ });
+ vi.stubGlobal('CSS', { registerProperty });
+
+ const alternateDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(alternateDocument, 'defaultView', { value: window });
+ expect(armThemeColorTransitions(alternateDocument)).toBe(true);
+ expect(registerProperty).toHaveBeenCalledTimes(THEME_COLOR_PROPERTIES.length);
+ expect(alternateDocument.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)).toBe(true);
+ });
+
+ test('does not add a second guard after a module reload', async () => {
+ const registerProperty = vi.fn();
+ const observe = vi.spyOn(MutationObserver.prototype, 'observe');
+ vi.stubGlobal('CSS', { registerProperty });
+
+ expect(armThemeColorTransitions()).toBe(true);
+ vi.resetModules();
+ const reloaded = await import('./theme-color-transitions');
+
+ expect(reloaded.armThemeColorTransitions()).toBe(true);
+ expect(registerProperty).toHaveBeenCalledTimes(THEME_COLOR_PROPERTIES.length);
+ expect(observe).toHaveBeenCalledTimes(1);
+ });
+
+ test('cancels descendant color transitions while preserving shadow geometry and transforms', async () => {
+ vi.stubGlobal('CSS', { registerProperty: vi.fn() });
+ const fadeDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(fadeDocument, 'defaultView', { value: window });
+ activeRootFade(fadeDocument);
+ expect(armThemeColorTransitions(fadeDocument)).toBe(true);
+
+ const child = fadeDocument.createElement('div');
+ const color = { transitionProperty: 'background-color', cancel: vi.fn() };
+ const decoration = { transitionProperty: 'text-decoration-color', cancel: vi.fn() };
+ const gradient = { transitionProperty: '--tw-gradient-from', cancel: vi.fn() };
+ const shadow = { transitionProperty: 'box-shadow', cancel: vi.fn() };
+ const transform = { transitionProperty: 'transform', cancel: vi.fn() };
+ Object.defineProperty(child, 'getAnimations', {
+ value: () => [color, decoration, gradient, shadow, transform],
+ });
+ fadeDocument.body.appendChild(child);
+
+ await act(async () => {
+ fadeDocument.documentElement.setAttribute('data-color-theme', 'dracula');
+ await Promise.resolve();
+ });
+ expect(fadeDocument.documentElement.hasAttribute(TRANSITION_FADING_ATTRIBUTE)).toBe(true);
+
+ const event = new Event('transitionrun', { bubbles: true });
+ Object.defineProperty(event, 'propertyName', { value: 'background-color' });
+ child.dispatchEvent(event);
+
+ expect(color.cancel).toHaveBeenCalledOnce();
+ expect(decoration.cancel).toHaveBeenCalledOnce();
+ expect(gradient.cancel).toHaveBeenCalledOnce();
+ expect(shadow.cancel).not.toHaveBeenCalled();
+ expect(transform.cancel).not.toHaveBeenCalled();
+ child.remove();
+ });
+
+ test('cancels color transitions already running when the theme mutation settles', async () => {
+ vi.stubGlobal('CSS', { registerProperty: vi.fn() });
+ const fadeDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(fadeDocument, 'defaultView', { value: window });
+ activeRootFade(fadeDocument);
+ expect(armThemeColorTransitions(fadeDocument)).toBe(true);
+
+ const child = fadeDocument.createElement('div');
+ const color = {
+ transitionProperty: 'background-color',
+ effect: { target: child },
+ cancel: vi.fn(),
+ };
+ const shadow = {
+ transitionProperty: 'box-shadow',
+ effect: { target: child },
+ cancel: vi.fn(),
+ };
+ Object.defineProperty(fadeDocument, 'getAnimations', { value: () => [color, shadow] });
+ fadeDocument.body.appendChild(child);
+
+ await act(async () => {
+ fadeDocument.documentElement.setAttribute('data-color-theme', 'dracula');
+ await Promise.resolve();
+ });
+
+ expect(color.cancel).toHaveBeenCalledOnce();
+ expect(shadow.cancel).not.toHaveBeenCalled();
+ child.remove();
+ });
+
+ test('clears the guard immediately when the root remains instant', async () => {
+ vi.stubGlobal('CSS', { registerProperty: vi.fn() });
+ const fadeDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(fadeDocument, 'defaultView', { value: window });
+ expect(armThemeColorTransitions(fadeDocument)).toBe(true);
+
+ await act(async () => {
+ fadeDocument.documentElement.setAttribute('data-color-theme', 'dracula');
+ await Promise.resolve();
+ });
+
+ expect(fadeDocument.documentElement.hasAttribute(TRANSITION_FADING_ATTRIBUTE)).toBe(false);
+ });
+
+ test('ignores idempotent root attribute writes', async () => {
+ vi.stubGlobal('CSS', { registerProperty: vi.fn() });
+ const fadeDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(fadeDocument, 'defaultView', { value: window });
+ fadeDocument.documentElement.setAttribute('data-color-theme', 'dracula');
+ activeRootFade(fadeDocument);
+ const getAnimations = vi.fn(() => []);
+ Object.defineProperty(fadeDocument, 'getAnimations', { value: getAnimations });
+ expect(armThemeColorTransitions(fadeDocument)).toBe(true);
+
+ await act(async () => {
+ fadeDocument.documentElement.setAttribute('data-color-theme', 'dracula');
+ await Promise.resolve();
+ });
+
+ expect(fadeDocument.documentElement.hasAttribute(TRANSITION_FADING_ATTRIBUTE)).toBe(false);
+ expect(getAnimations).not.toHaveBeenCalled();
+ });
+
+ test('surfaces registration failures other than duplicate registration', () => {
+ vi.stubGlobal('CSS', {
+ registerProperty: () => {
+ throw new DOMException('invalid syntax', 'SyntaxError');
+ },
+ });
+
+ const alternateDocument = document.implementation.createHTMLDocument();
+ Object.defineProperty(alternateDocument, 'defaultView', { value: window });
+
+ expect(() => armThemeColorTransitions(alternateDocument)).toThrow('invalid syntax');
+ });
+});
diff --git a/packages/app/src/lib/theme-color-transitions.ts b/packages/app/src/lib/theme-color-transitions.ts
new file mode 100644
index 000000000..1b9f7da4a
--- /dev/null
+++ b/packages/app/src/lib/theme-color-transitions.ts
@@ -0,0 +1,220 @@
+import { useEffect } from 'react';
+import { isThemeColorProperty, THEME_COLOR_PROPERTIES } from './theme-color-properties';
+
+export const TRANSITION_ATTRIBUTE = 'data-theme-color-transitions';
+export const TRANSITION_STYLE_ID = 'ok-theme-color-transitions';
+export const TRANSITION_FADING_ATTRIBUTE = 'data-theme-color-fading';
+const TRANSITION_DURATION_MS = 200;
+
+const transitionDeclarations = THEME_COLOR_PROPERTIES.map(
+ (name) => `${name} ${TRANSITION_DURATION_MS}ms ease-out`,
+).join(',');
+
+const armedDocuments = new WeakSet<Document>();
+
+function cssPropertiesApi(document: Document): typeof CSS | undefined {
+ return document.defaultView?.CSS;
+}
+
+function registerProperties(document: Document): boolean {
+ const css = cssPropertiesApi(document);
+ if (typeof css?.registerProperty !== 'function') return false;
+ const DOMExceptionCtor = document.defaultView?.DOMException;
+ for (const name of THEME_COLOR_PROPERTIES) {
+ try {
+ css.registerProperty({
+ name,
+ syntax: '<color>',
+ inherits: true,
+ initialValue: 'transparent',
+ });
+ } catch (error) {
+ if (
+ typeof DOMExceptionCtor === 'function' &&
+ error instanceof DOMExceptionCtor &&
+ error.name === 'InvalidModificationError'
+ ) {
+ continue;
+ }
+ throw error;
+ }
+ }
+ return true;
+}
+
+function installTransitionStyle(document: Document): void {
+ if (document.getElementById(TRANSITION_STYLE_ID)) return;
+ const style = document.createElement('style');
+ style.id = TRANSITION_STYLE_ID;
+ style.textContent = `@media (prefers-reduced-motion: no-preference){:root[${TRANSITION_ATTRIBUTE}]{transition:${transitionDeclarations}}}`;
+ document.head.appendChild(style);
+}
+
+function isDescendantColorTransition(name: string): boolean {
+ return (
+ name === 'color' ||
+ name === 'fill' ||
+ name === 'stroke' ||
+ name.endsWith('-color') ||
+ name === '--tw-gradient-from' ||
+ name === '--tw-gradient-via' ||
+ name === '--tw-gradient-to'
+ );
+}
+
+function installFadeGuards(document: Document): void {
+ const view = document.defaultView;
+ if (!view || typeof view.requestAnimationFrame !== 'function') return;
+ const root = document.documentElement;
+ let cleanupFrame = 0;
+ let fallbackTimer = 0;
+ let cancellationFrame = 0;
+ let fadeGeneration = 0;
+ let lastClass = root.getAttribute('class');
+ let lastPalette = root.getAttribute('data-color-theme');
+ const descendantTransitionElements = new Set<Element>();
+ const cancelColorTransitions = (element: Element) => {
+ for (const animation of element.getAnimations({ subtree: false })) {
+ if (
+ isDescendantColorTransition(
+ (animation as { transitionProperty?: string }).transitionProperty ?? '',
+ )
+ ) {
+ animation.cancel();
+ }
+ }
+ };
+ const cancelRunningDescendantColorTransitions = () => {
+ if (typeof document.getAnimations !== 'function') return;
+ for (const animation of document.getAnimations()) {
+ const effect = animation.effect;
+ const element = effect && 'target' in effect ? effect.target : null;
+ if (element === root || !(element instanceof view.Element)) continue;
+ if (
+ isDescendantColorTransition(
+ (animation as { transitionProperty?: string }).transitionProperty ?? '',
+ )
+ ) {
+ animation.cancel();
+ }
+ }
+ };
+ const scheduleDescendantCancellation = () => {
+ if (cancellationFrame) return;
+ cancellationFrame = view.requestAnimationFrame(() => {
+ cancellationFrame = 0;
+ for (const element of descendantTransitionElements) cancelColorTransitions(element);
+ if (root.hasAttribute(TRANSITION_FADING_ATTRIBUTE)) scheduleDescendantCancellation();
+ });
+ };
+ const clearIfSettled = (generation: number) => {
+ cleanupFrame = 0;
+ if (generation !== fadeGeneration) return;
+ if (document.hidden || !themeColorTransitionsActive(document)) {
+ root.removeAttribute(TRANSITION_FADING_ATTRIBUTE);
+ descendantTransitionElements.clear();
+ return;
+ }
+ scheduleCleanup(generation);
+ };
+ const scheduleCleanup = (generation: number) => {
+ cleanupFrame = view.requestAnimationFrame(() => clearIfSettled(generation));
+ };
+ const markFading = () => {
+ const nextClass = root.getAttribute('class');
+ const nextPalette = root.getAttribute('data-color-theme');
+ if (nextClass === lastClass && nextPalette === lastPalette) return;
+ lastClass = nextClass;
+ lastPalette = nextPalette;
+ fadeGeneration += 1;
+ const generation = fadeGeneration;
+ if (fallbackTimer) {
+ view.clearTimeout(fallbackTimer);
+ fallbackTimer = 0;
+ }
+ root.setAttribute(TRANSITION_FADING_ATTRIBUTE, '');
+ cancelRunningDescendantColorTransitions();
+ if (!themeColorTransitionsActive(document)) {
+ root.removeAttribute(TRANSITION_FADING_ATTRIBUTE);
+ descendantTransitionElements.clear();
+ return;
+ }
+ fallbackTimer = view.setTimeout(() => {
+ fallbackTimer = 0;
+ clearIfSettled(generation);
+ }, TRANSITION_DURATION_MS);
+ scheduleDescendantCancellation();
+ };
+ new view.MutationObserver(markFading).observe(root, {
+ attributes: true,
+ attributeFilter: ['class', 'data-color-theme'],
+ });
+ document.addEventListener('visibilitychange', () => {
+ if (!document.hidden) return;
+ fadeGeneration += 1;
+ if (fallbackTimer) view.clearTimeout(fallbackTimer);
+ if (cleanupFrame) view.cancelAnimationFrame(cleanupFrame);
+ root.removeAttribute(TRANSITION_FADING_ATTRIBUTE);
+ descendantTransitionElements.clear();
+ });
+ document.addEventListener(
+ 'transitionrun',
+ (event) => {
+ if (event.target === root || !root.hasAttribute(TRANSITION_FADING_ATTRIBUTE)) return;
+ if (!isDescendantColorTransition(event.propertyName)) return;
+ const element = event.target;
+ if (!(element instanceof view.Element)) return;
+ descendantTransitionElements.add(element);
+ cancelColorTransitions(element);
+ scheduleDescendantCancellation();
+ },
+ true,
+ );
+}
+
+export function armThemeColorTransitions(document: Document = window.document): boolean {
+ if (armedDocuments.has(document) || document.documentElement.hasAttribute(TRANSITION_ATTRIBUTE)) {
+ armedDocuments.add(document);
+ return true;
+ }
+ if (!registerProperties(document)) return false;
+ installTransitionStyle(document);
+ installFadeGuards(document);
+ document.documentElement.setAttribute(TRANSITION_ATTRIBUTE, '');
+ armedDocuments.add(document);
+ return true;
+}
+
+export function useThemeColorTransitions(ready: boolean): void {
+ useEffect(() => {
+ if (!ready) return;
+ const tryArm = () => {
+ try {
+ armThemeColorTransitions();
+ } catch (error) {
+ console.warn(
+ JSON.stringify({
+ event: 'theme-color-transitions-arm-failed',
+ error: error instanceof Error ? error.message : String(error),
+ }),
+ );
+ }
+ };
+ if (typeof requestAnimationFrame !== 'function') {
+ tryArm();
+ return;
+ }
+ const frame = requestAnimationFrame(tryArm);
+ return () => cancelAnimationFrame(frame);
+ }, [ready]);
+}
+
+export function themeColorTransitionsActive(document: Document = window.document): boolean {
+ const root = document.documentElement;
+ if (typeof root.getAnimations !== 'function') return false;
+ return root
+ .getAnimations({ subtree: false })
+ .some((animation) =>
+ isThemeColorProperty((animation as { transitionProperty?: string }).transitionProperty ?? ''),
+ );
+}
diff --git a/packages/app/src/lib/use-apply-config-theme.dom.test.tsx b/packages/app/src/lib/use-apply-config-theme.dom.test.tsx
index fe2c234d4..ab2621589 100644
--- a/packages/app/src/lib/use-apply-config-theme.dom.test.tsx
+++ b/packages/app/src/lib/use-apply-config-theme.dom.test.tsx
@@ -11,13 +11,7 @@ function ConfigThemeHarness({ themeValue }: { themeValue: string | undefined })
function themeTree(themeValue: string | undefined): ReactElement {
return (
- <ThemeProvider
- attribute="class"
- defaultTheme="system"
- enableSystem
- disableTransitionOnChange
- storageKey="ok-theme-v1"
- >
+ <ThemeProvider attribute="class" defaultTheme="system" enableSystem storageKey="ok-theme-v1">
<ConfigThemeHarness themeValue={themeValue} />
</ThemeProvider>
);
diff --git a/packages/app/src/main.tsx b/packages/app/src/main.tsx
index 909ecd600..45e2449b2 100644
--- a/packages/app/src/main.tsx
+++ b/packages/app/src/main.tsx
@@ -147,7 +147,6 @@ createRoot(root).render(
attribute="class"
defaultTheme="system"
enableSystem
- disableTransitionOnChange
storageKey="ok-theme-v1"
>
<RegisteredAgentHydrator />
diff --git a/packages/app/tests/stress/okf-generated-index-settings.e2e.ts b/packages/app/tests/stress/okf-generated-index-settings.e2e.ts
index 76d84fb46..dc4e0b59e 100644
--- a/packages/app/tests/stress/okf-generated-index-settings.e2e.ts
+++ b/packages/app/tests/stress/okf-generated-index-settings.e2e.ts
@@ -60,6 +60,11 @@ async function expectDisclosureContrast(page: Page, theme: 'light' | 'dark'): Pr
}, theme);
try {
+ await page.evaluate(async () => {
+ await Promise.all(
+ document.documentElement.getAnimations().map((animation) => animation.finished),
+ );
+ });
const results = await new AxeBuilder({ page })
.include('[data-testid="settings-okf-generate-index-confirm"]')
.withRules(['color-contrast'])
diff --git a/packages/app/tests/stress/theme-color-conversion.e2e.ts b/packages/app/tests/stress/theme-color-conversion.e2e.ts
new file mode 100644
index 000000000..1bd54438d
--- /dev/null
+++ b/packages/app/tests/stress/theme-color-conversion.e2e.ts
@@ -0,0 +1,152 @@
+import { PREVIEW_THEME_TOKENS } from '@inkeep/open-knowledge-core';
+import { expect, SETTINGS_PANEL_TIMEOUT_MS, test } from './_helpers';
+
+async function openColorThemes(page: import('@playwright/test').Page) {
+ await page.goto('/#settings');
+ await expect(page.getByTestId('settings-dialog')).toBeVisible({ timeout: 15_000 });
+ await page.getByTestId('settings-search-input').fill('Color theme');
+ await page.getByTestId('settings-search-results').getByText('Color theme').first().click();
+ await expect(page.getByRole('group', { name: 'Dracula' })).toBeVisible({
+ timeout: SETTINGS_PANEL_TIMEOUT_MS,
+ });
+}
+
+test('painted comment underlines retain their sRGB contrast in both default modes', async ({
+ page,
+}) => {
+ await page.emulateMedia({ reducedMotion: 'reduce' });
+ await page.goto('/');
+ const samples = await page.evaluate(async () => {
+ const modulePath = '/src/comments/anchor-layers.ts';
+ const { buildAnchorSegments, commentColor } = await import(modulePath);
+ const root = document.documentElement;
+ const originalClass = root.className;
+ const surface = document.createElement('div');
+ surface.className = 'bg-background';
+ const probe = document.createElement('span');
+ surface.append(probe);
+ document.body.append(surface);
+ const canvas = document.createElement('canvas');
+ canvas.width = canvas.height = 1;
+ const context = canvas.getContext('2d');
+ if (!context) throw new Error('Canvas unavailable');
+ try {
+ return ['light', 'dark'].map((mode) => {
+ root.classList.toggle('dark', mode === 'dark');
+ root.classList.toggle('light', mode === 'light');
+ const segment = buildAnchorSegments([{ id: 'comment', from: 0, to: 1 }])[0];
+ probe.style.cssText = segment.style;
+ const shadow = getComputedStyle(probe).boxShadow;
+ probe.style.backgroundColor = commentColor(0.7);
+ const lineColor = getComputedStyle(probe).backgroundColor;
+ const background = getComputedStyle(surface).backgroundColor;
+ context.clearRect(0, 0, 1, 1);
+ context.fillStyle = background;
+ context.fillRect(0, 0, 1, 1);
+ const backgroundPixels = [...context.getImageData(0, 0, 1, 1).data];
+ const backgroundRgb = backgroundPixels.slice(0, 3);
+ context.fillStyle = lineColor;
+ context.fillRect(0, 0, 1, 1);
+ const paintedRgb = [...context.getImageData(0, 0, 1, 1).data].slice(0, 3);
+ return {
+ mode,
+ shadow,
+ lineColor,
+ background,
+ backgroundRgb,
+ backgroundAlpha: backgroundPixels[3],
+ paintedRgb,
+ };
+ });
+ } finally {
+ root.className = originalClass;
+ surface.remove();
+ }
+ });
+ const luminance = (rgb: number[]) =>
+ rgb.reduce((sum, value, index) => {
+ const channel = value / 255;
+ const linear = channel <= 0.04045 ? channel / 12.92 : ((channel + 0.055) / 1.055) ** 2.4;
+ return sum + linear * [0.2126, 0.7152, 0.0722][index];
+ }, 0);
+ for (const sample of samples) {
+ expect(sample.backgroundAlpha, JSON.stringify(sample)).toBe(255);
+ expect(sample.shadow).toContain(sample.lineColor);
+ const [low, high] = [luminance(sample.paintedRgb), luminance(sample.backgroundRgb)].sort(
+ (a, b) => a - b,
+ );
+ expect((high + 0.05) / (low + 0.05), JSON.stringify(sample)).toBeGreaterThanOrEqual(3);
+ }
+});
+
+test('converts CSS Color 4 tokens for live xterm themes without losing alpha channels', async ({
+ page,
+}) => {
+ await openColorThemes(page);
+ const converted = await page.evaluate(async () => {
+ const modulePath = '/src/lib/css-color-to-hex.ts';
+ const { cssColorToHex } = await import(modulePath);
+ return {
+ transparentRgb: cssColorToHex('rgb(80 120 255 / 0)', { alpha: true }),
+ translucentRgb: cssColorToHex('rgb(80 120 255 / 0.18)', { alpha: true }),
+ color4White: cssColorToHex('oklch(1 0 0)', { alpha: true }),
+ color4Black: cssColorToHex('oklch(0 0 0)', { alpha: true }),
+ color4Translucent: cssColorToHex('oklch(0.66 0.18 259 / 0.18)', { alpha: true }),
+ color4Reference: (() => {
+ const canvas = document.createElement('canvas');
+ const context = canvas.getContext('2d');
+ if (!context) return null;
+ context.fillStyle = 'oklch(0.66 0.18 259 / 0.18)';
+ context.fillRect(0, 0, 1, 1);
+ return `#${Array.from(context.getImageData(0, 0, 1, 1).data, (channel) =>
+ channel.toString(16).padStart(2, '0'),
+ ).join('')}`;
+ })(),
+ };
+ });
+
+ expect(converted.transparentRgb).toBe('#5078ff00');
+ expect(converted.translucentRgb).toBe('#5078ff2e');
+ expect(converted.color4White).toBe('#ffffffff');
+ expect(converted.color4Black).toBe('#000000ff');
+ expect(converted.color4Translucent).toBe(converted.color4Reference);
+
+ const invalidRegisteredTokens = await page.evaluate(async (tokens) => {
+ const modulePath = '/src/lib/theme-color-properties.ts';
+ const { THEME_COLOR_PROPERTIES } = await import(modulePath);
+ return tokens
+ .filter(
+ (token) =>
+ THEME_COLOR_PROPERTIES.includes(token.name) &&
+ (!CSS.supports('color', token.light) || !CSS.supports('color', token.dark)),
+ )
+ .map((token) => token.name);
+ }, PREVIEW_THEME_TOKENS);
+ expect(invalidRegisteredTokens).toEqual([]);
+
+ const dracula = page.getByRole('button', { name: 'Use Dracula for the active light mode' });
+ await dracula.click();
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('dracula');
+ await expect
+ .poll(() => page.locator('html').evaluate((root) => root.getAnimations().length))
+ .toBe(0);
+
+ const monokai = page.getByRole('button', { name: 'Use Monokai for the active light mode' });
+ await monokai.click();
+
+ const samples = await page.evaluate(async () => {
+ const modulePath = '/src/components/terminal-theme.ts';
+ const { computeLiveXtermTheme } = await import(modulePath);
+ const values: string[] = [];
+ for (let index = 0; index < 24; index += 1) {
+ values.push(computeLiveXtermTheme('dark').selectionBackground ?? '');
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ }
+ return values;
+ });
+
+ expect(samples.every((value) => /^#[0-9a-f]{8}$/.test(value))).toBe(true);
+ expect(new Set(samples).size).toBeGreaterThan(2);
+ expect(samples[0]).not.toBe(samples.at(-1));
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('monokai');
+});
diff --git a/packages/app/tests/stress/theme-fade.e2e.ts b/packages/app/tests/stress/theme-fade.e2e.ts
new file mode 100644
index 000000000..5b430745d
--- /dev/null
+++ b/packages/app/tests/stress/theme-fade.e2e.ts
@@ -0,0 +1,237 @@
+import { expect, SETTINGS_PANEL_TIMEOUT_MS, test } from './_helpers';
+
+async function openColorThemes(page: import('@playwright/test').Page) {
+ await page.goto('/#settings');
+ await expect(page.getByTestId('settings-dialog')).toBeVisible({ timeout: 15_000 });
+ await page.getByTestId('settings-search-input').fill('Color theme');
+ await page.getByTestId('settings-search-results').getByText('Color theme').first().click();
+ await expect(page.getByRole('group', { name: 'Dracula' })).toBeVisible({
+ timeout: SETTINGS_PANEL_TIMEOUT_MS,
+ });
+}
+
+async function backgroundSamples(button: import('@playwright/test').Locator): Promise<string[]> {
+ return button.evaluate(async (element) => {
+ if (!(element instanceof HTMLButtonElement)) throw new Error('Expected a palette button');
+ const values = new Set<string>();
+ element.click();
+ for (let index = 0; index < 20; index += 1) {
+ values.add(
+ getComputedStyle(document.documentElement).getPropertyValue('--background').trim(),
+ );
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ }
+ return [...values];
+ });
+}
+
+test('theme settings fade typed tokens and persist a same-mode palette switch', async ({
+ page,
+}) => {
+ await page.addInitScript(() => {
+ (window as typeof window & { startupThemeTransitions: string[] }).startupThemeTransitions = [];
+ document.addEventListener('transitionrun', (event) => {
+ if (event.target !== document.documentElement || !event.propertyName.startsWith('--')) return;
+ (
+ window as typeof window & { startupThemeTransitions: string[] }
+ ).startupThemeTransitions.push(event.propertyName);
+ });
+ });
+ await openColorThemes(page);
+ expect(
+ await page.evaluate(
+ () =>
+ (window as typeof window & { startupThemeTransitions: string[] }).startupThemeTransitions,
+ ),
+ ).toEqual([]);
+
+ await page.getByRole('button', { name: 'Use Dracula for the active light mode' }).click();
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('dracula');
+ await expect
+ .poll(() => page.locator('html').evaluate((root) => root.classList.contains('dark')))
+ .toBe(true);
+
+ await expect
+ .poll(() => page.locator('html').evaluate((root) => root.getAnimations().length))
+ .toBe(0);
+ const samples = await backgroundSamples(
+ page.getByRole('button', { name: 'Use Monokai for the active light mode' }),
+ );
+
+ expect(samples).toContain('rgb(39, 40, 34)');
+ expect(new Set(samples).size).toBeGreaterThan(2);
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('monokai');
+
+ await page.reload();
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('monokai');
+ expect(
+ await page.evaluate(
+ () =>
+ (window as typeof window & { startupThemeTransitions: string[] }).startupThemeTransitions,
+ ),
+ ).toEqual([]);
+});
+
+test('theme settings retarget rapidly and honor reduced motion', async ({ page }) => {
+ await openColorThemes(page);
+
+ await page.getByRole('button', { name: 'Use Dracula for the active light mode' }).click();
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('dracula');
+ await page.getByRole('button', { name: 'Use Monokai for the active light mode' }).click();
+ await page.getByRole('button', { name: 'Use Gruvbox for the active light mode' }).click();
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('gruvbox');
+ await expect
+ .poll(() =>
+ page
+ .locator('html')
+ .evaluate((root) => getComputedStyle(root).getPropertyValue('--background').trim()),
+ )
+ .toBe('rgb(40, 40, 40)');
+
+ await page.emulateMedia({ reducedMotion: 'reduce' });
+ const search = page.getByTestId('settings-search-input');
+ await search.focus();
+ const focusedBefore = await page.evaluate(() =>
+ document.activeElement?.getAttribute('data-testid'),
+ );
+ const transformBefore = await search.evaluate((element) => getComputedStyle(element).transform);
+ await page
+ .getByRole('button', { name: 'Use Monokai for the active light mode' })
+ .evaluate((button) => button.click());
+ await expect.poll(() => page.locator('html').getAttribute('data-color-theme')).toBe('monokai');
+ const reducedMotionAnimations = await page.evaluate(() => document.getAnimations().length);
+ expect(reducedMotionAnimations).toBe(0);
+ expect(await page.evaluate(() => document.activeElement?.getAttribute('data-testid'))).toBe(
+ focusedBefore,
+ );
+ expect(await search.evaluate((element) => getComputedStyle(element).transform)).toBe(
+ transformBefore,
+ );
+});
+
+test('default light and dark modes fade surfaces without losing selection', async ({ page }) => {
+ await page.goto('/#settings');
+ await page.getByTestId('settings-sidebar-item-preferences').click();
+ await page.getByTestId('theme-picker-light').click();
+ expect(
+ await page
+ .locator('html')
+ .evaluate((root) => getComputedStyle(root).getPropertyValue('--radius').trim()),
+ ).toBe('0.625rem');
+ expect(
+ await page
+ .getByTestId('theme-picker-light')
+ .evaluate((button) => getComputedStyle(button).borderRadius),
+ ).not.toBe('0px');
+ await expect
+ .poll(() => page.locator('html').evaluate((root) => root.getAnimations().length))
+ .toBe(0);
+ const search = page.getByTestId('settings-search-input');
+ await search.focus();
+ const samples = await page.evaluate(async () => {
+ const input = document.querySelector<HTMLInputElement>('[data-testid="settings-search-input"]');
+ input?.setSelectionRange(0, 0);
+ const transformProbe = document.createElement('div');
+ const opacityProbe = document.createElement('div');
+ const sizeProbe = document.createElement('div');
+ const shadowProbe = document.createElement('div');
+ const colorProbe = document.createElement('div');
+ transformProbe.style.transition = 'transform 1s linear';
+ opacityProbe.style.transition = 'opacity 1s linear';
+ sizeProbe.style.transition = 'width 1s linear';
+ shadowProbe.style.transition = 'box-shadow 1s linear';
+ colorProbe.style.transition = 'color 1s linear';
+ opacityProbe.style.opacity = '1';
+ sizeProbe.style.width = '1px';
+ shadowProbe.style.boxShadow = '0 0 0 transparent';
+ colorProbe.style.color = 'rgb(0, 0, 0)';
+ const probes = [transformProbe, opacityProbe, sizeProbe, shadowProbe, colorProbe];
+ document.body.append(...probes);
+ void getComputedStyle(sizeProbe).width;
+ const initial = getComputedStyle(document.body).backgroundColor;
+ document.querySelector<HTMLButtonElement>('[data-testid="theme-picker-dark"]')?.click();
+ transformProbe.style.transform = 'translateX(1px)';
+ opacityProbe.style.opacity = '0.5';
+ sizeProbe.style.width = '2px';
+ shadowProbe.style.boxShadow = '0 0 1px black';
+ colorProbe.style.color = 'rgb(1, 1, 1)';
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ const transitionProperties = document
+ .getAnimations()
+ .map((animation) => (animation as CSSTransition).transitionProperty);
+ const colorTransitionProperties = colorProbe
+ .getAnimations()
+ .map((animation) => (animation as CSSTransition).transitionProperty);
+ const colors = [initial];
+ for (let index = 0; index < 24; index += 1) {
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ colors.push(getComputedStyle(document.body).backgroundColor);
+ }
+ probes.forEach((probe) => {
+ probe.remove();
+ });
+ return {
+ colors,
+ focused: document.activeElement === input,
+ selection: input?.selectionStart,
+ transitionProperties,
+ colorTransitionProperties,
+ };
+ });
+ expect(new Set(samples.colors).size).toBeGreaterThan(2);
+ expect(samples.colors[0]).not.toBe(samples.colors.at(-1));
+ expect(samples.focused).toBe(true);
+ expect(samples.selection).toBe(0);
+ expect(samples.transitionProperties).toContain('transform');
+ expect(samples.transitionProperties).toContain('opacity');
+ expect(samples.transitionProperties).toContain('width');
+ expect(samples.transitionProperties).toContain('box-shadow');
+ expect(samples.colorTransitionProperties).toEqual([]);
+ await expect(page.locator('html')).toHaveClass(/dark/);
+ await expect(page.locator('html')).not.toHaveAttribute('data-theme-color-fading');
+ const selectionColor = await page.evaluate(async () => {
+ const modulePath = '/src/components/terminal-theme.ts';
+ const { computeLiveXtermTheme } = await import(modulePath);
+ return computeLiveXtermTheme('dark').selectionBackground;
+ });
+ expect(selectionColor).toMatch(/^#[0-9a-f]{6}52$/);
+
+ await page.emulateMedia({ reducedMotion: 'reduce' });
+ const reducedMotion = await page.evaluate(async () => {
+ const colorProbe = document.createElement('div');
+ const flashProbe = document.createElement('div');
+ const opacityProbe = document.createElement('div');
+ colorProbe.style.transition = 'color 1s linear';
+ colorProbe.style.color = 'rgb(0, 0, 0)';
+ opacityProbe.style.cssText = 'opacity:1;transition:opacity 1s linear';
+ document.body.append(colorProbe, flashProbe, opacityProbe);
+ void getComputedStyle(colorProbe).color;
+ void getComputedStyle(flashProbe).boxShadow;
+ document.querySelector<HTMLButtonElement>('[data-testid="theme-picker-light"]')?.click();
+ colorProbe.style.color = 'rgb(1, 1, 1)';
+ flashProbe.className = 'ok-landing-flash';
+ opacityProbe.style.opacity = '0.5';
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ await new Promise<void>((resolve) => requestAnimationFrame(() => resolve()));
+ const transitionProperties = document
+ .getAnimations()
+ .map((animation) => (animation as CSSTransition).transitionProperty);
+ const flashTransitions = flashProbe
+ .getAnimations()
+ .map((animation) => (animation as CSSTransition).transitionProperty);
+ colorProbe.remove();
+ flashProbe.remove();
+ opacityProbe.remove();
+ return { transitionProperties, flashTransitions };
+ });
+ expect(reducedMotion.flashTransitions).toContain('box-shadow');
+ expect(reducedMotion.transitionProperties).toContain('opacity');
+ expect(
+ reducedMotion.transitionProperties.filter(
+ (property) => !['transform', 'opacity', 'box-shadow'].includes(property),
+ ),
+ ).toEqual([]);
+});
diff --git a/packages/desktop/tests/smoke/uninstall-window-chrome.e2e.ts b/packages/desktop/tests/smoke/uninstall-window-chrome.e2e.ts
index 195f692d3..8bf0be638 100644
--- a/packages/desktop/tests/smoke/uninstall-window-chrome.e2e.ts
+++ b/packages/desktop/tests/smoke/uninstall-window-chrome.e2e.ts
@@ -70,13 +70,33 @@ test.describe('uninstall renderer chrome smoke', () => {
);
expect(rendererIsDark).toBe(mainWantsDark);
- const readPrimary = (page: Page) =>
- page.evaluate(() =>
- getComputedStyle(document.documentElement).getPropertyValue('--primary').trim(),
+ await editorWindow.emulateMedia({ colorScheme: mainWantsDark ? 'dark' : 'light' });
+ await expect
+ .poll(() => editorWindow.evaluate(() => document.documentElement.classList.contains('dark')))
+ .toBe(mainWantsDark);
+ await editorWindow.evaluate(async () => {
+ await Promise.all(
+ document.documentElement.getAnimations().map((animation) => animation.finished),
);
+ });
+
+ const readPrimary = (page: Page) =>
+ page.evaluate(() => {
+ const token = getComputedStyle(document.documentElement)
+ .getPropertyValue('--primary')
+ .trim();
+ const probe = document.createElement('span');
+ probe.style.color = 'var(--primary)';
+ document.body.appendChild(probe);
+ const color = getComputedStyle(probe).color;
+ probe.remove();
+ return { token, color };
+ });
const uninstallPrimary = await readPrimary(uninstallWindow);
- expect(uninstallPrimary).not.toBe('');
- expect(uninstallPrimary).toBe(await readPrimary(editorWindow));
+ const editorPrimary = await readPrimary(editorWindow);
+ expect(uninstallPrimary.token).not.toBe('');
+ expect(editorPrimary.token).not.toBe('');
+ expect(uninstallPrimary.color).toBe(editorPrimary.color);
await expect(uninstallWindow.locator('#root')).not.toBeEmpty();
});