Beautiful, AI-native markdown IDE and LLM wiki
TypeScript 2nd-brainagent-skillsclaudecodexcompany-braindocsknowledge-knowledge-baseknowledge-managementllmllm-wikillm-wiki-karpathymarkdownmarkdown-editormdmdxnotespkmsecond-brainskills
fix(open-knowledge): drop redundant tooltips on labeled toolbar buttons (PRD-6912) (#1578)
Andrew Mikofalvy83ad4af48014
diff --git a/.changeset/editor-header-drop-redundant-labeled-tooltips.md b/.changeset/editor-header-drop-redundant-labeled-tooltips.mdnew file mode 100644index 000000000..9a3e782ac--- /dev/null+++ b/.changeset/editor-header-drop-redundant-labeled-tooltips.md@@ -0,0 +1,9 @@+---+"@inkeep/open-knowledge": patch+"@inkeep/open-knowledge-core": patch+"@inkeep/open-knowledge-server": patch+"@inkeep/open-knowledge-app": patch+"@inkeep/open-knowledge-desktop": patch+---++Drop the redundant hover tooltip from the editor toolbar's labeled actions. The "Open with AI" and "Share" buttons already show their name as visible text, so the tooltip that repeated that same text on hover was noise. Icon-only toolbar controls (the sync-status cloud, settings, help) keep their tooltips, since the tooltip is the only place their name appears.diff --git a/packages/app/src/components/ShareButton.test.ts b/packages/app/src/components/ShareButton.test.tsindex 3ad76eefa..afb633604 100644--- a/packages/app/src/components/ShareButton.test.ts+++ b/packages/app/src/components/ShareButton.test.ts@@ -48,10 +48,10 @@ describe('ShareButton — load-bearing structural guards', () => {expect(SRC).toContain('Link ready but could not copy to clipboard.');});- test('renders a Tooltip wrapping the Button trigger (consistent with sibling cluster)', () => {- expect(SRC).toContain("from '@/components/ui/tooltip'");- expect(SRC).toContain('<Tooltip>');- expect(SRC).toMatch(/<TooltipContent>\s*<Trans>Share<\/Trans>\s*<\/TooltipContent>/);+ test('does NOT wrap its labeled trigger in a redundant Tooltip (visible "Share" text is the affordance)', () => {+ expect(SRC).not.toContain("from '@/components/ui/tooltip'");+ expect(SRC).not.toContain('<TooltipContent>');+ expect(SRC).toContain('<Trans>Share</Trans>');});test('Button carries an aria-label so the icon-bearing affordance is screen-reader navigable', () => {diff --git a/packages/app/src/components/ShareButton.tsx b/packages/app/src/components/ShareButton.tsxindex cc5499451..3b67fa611 100644--- a/packages/app/src/components/ShareButton.tsx+++ b/packages/app/src/components/ShareButton.tsx@@ -5,7 +5,6 @@ import { toast } from 'sonner';import { Button } from '@/components/ui/button';import { Input } from '@/components/ui/input';import { Popover, PopoverAnchor, PopoverContent } from '@/components/ui/popover';-import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';import { useDocumentContext } from '@/editor/DocumentContext';import { useGitSyncStatusDetailed } from '@/hooks/use-git-sync-status';import { scheduleClipboardWrite } from '@/lib/share/clipboard-adapter';@@ -71,27 +70,24 @@ export function ShareButton({ onClickWhenNoRemote }: ShareButtonProps) {if (!open) setClipboardFailedUrl(null);}}>- <Tooltip>- <TooltipTrigger asChild>- <PopoverAnchor asChild>- <Button- variant="ghost"- size="sm"- aria-label={t`Share doc`}- onClick={handleClick}- disabled={busy}- className="gap-1.5 text-muted-foreground px-1.5"- data-testid="share-button"- >- <Share2 className="size-3.5" aria-hidden />- <Trans>Share</Trans>- </Button>- </PopoverAnchor>- </TooltipTrigger>- <TooltipContent>+ {/* No tooltip: the visible "Share" label already names the control, so a+ tooltip repeating it would be redundant. Icon-only toolbar siblings+ (e.g. SyncStatusBadge) still carry a tooltip — they have no visible+ text. */}+ <PopoverAnchor asChild>+ <Button+ variant="ghost"+ size="sm"+ aria-label={t`Share doc`}+ onClick={handleClick}+ disabled={busy}+ className="gap-1.5 text-muted-foreground px-1.5"+ data-testid="share-button"+ >+ <Share2 className="size-3.5" aria-hidden /><Trans>Share</Trans>- </TooltipContent>- </Tooltip>+ </Button>+ </PopoverAnchor><PopoverContentclassName="flex w-80 flex-col gap-2"data-testid="share-button-fallback-popover"diff --git a/packages/app/src/components/handoff/OpenInAgentMenu.test.ts b/packages/app/src/components/handoff/OpenInAgentMenu.test.tsindex 5f5cc0eba..33bd51ff2 100644--- a/packages/app/src/components/handoff/OpenInAgentMenu.test.ts+++ b/packages/app/src/components/handoff/OpenInAgentMenu.test.ts@@ -42,4 +42,10 @@ describe('OpenInAgentMenu source-level guards', () => {expect(triggerOpenTag).not.toBeNull();expect(triggerOpenTag?.[0]).not.toMatch(/aria-label/);});++ test('does NOT wrap its labeled trigger in a redundant Tooltip (visible "Open with AI" text is the affordance)', () => {+ expect(SRC).not.toContain("from '@/components/ui/tooltip'");+ expect(SRC).not.toContain('<TooltipContent>');+ expect(SRC).toContain('<Trans>Open with AI</Trans>');+ });});diff --git a/packages/app/src/components/handoff/OpenInAgentMenu.tsx b/packages/app/src/components/handoff/OpenInAgentMenu.tsxindex eb7460640..45ab4d9b1 100644--- a/packages/app/src/components/handoff/OpenInAgentMenu.tsx+++ b/packages/app/src/components/handoff/OpenInAgentMenu.tsx@@ -10,7 +10,6 @@ import {DropdownMenuItem,DropdownMenuTrigger,} from '@/components/ui/dropdown-menu';-import { Tooltip, TooltipContent, TooltipTrigger } from '@/components/ui/tooltip';import { useIsEmbedded } from '@/hooks/use-is-embedded';import { useConfigContext } from '@/lib/config-context';import { VISIBLE_TARGETS } from '@/lib/handoff/targets';@@ -77,25 +76,18 @@ export function OpenInAgentMenu({ input, open, onOpenChange }: OpenInAgentMenuPrreturn (<DropdownMenu open={menuOpen} onOpenChange={handleOpenChange}>- <Tooltip>- <TooltipTrigger asChild>- <DropdownMenuTrigger asChild>- <Button- variant="ghost"- size="sm"- disabled={triggerDisabled}- className="gap-1.5 text-muted-foreground px-1.5"- data-testid="open-in-agent-trigger"- >- <Sparkles className="size-3.5" aria-hidden="true" />- <Trans>Open with AI</Trans>- </Button>- </DropdownMenuTrigger>- </TooltipTrigger>- <TooltipContent>+ <DropdownMenuTrigger asChild>+ <Button+ variant="ghost"+ size="sm"+ disabled={triggerDisabled}+ className="gap-1.5 text-muted-foreground px-1.5"+ data-testid="open-in-agent-trigger"+ >+ <Sparkles className="size-3.5" aria-hidden="true" /><Trans>Open with AI</Trans>- </TooltipContent>- </Tooltip>+ </Button>+ </DropdownMenuTrigger><DropdownMenuContent align="end" className="min-w-[220px]" data-testid="open-in-agent-menu">{installedTargets.map((target) => {const installState = states[target.id];